[PATCH 1/1] ixgbevf: replace integer number with bool value

2016-07-28 Thread Zhu Yanjun
The variable get_mac_status is a bool variable. So a bool value is better than an integer number. Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 2 +- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Zhu Yanjun
在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet/nvidia/forcedeth.c, the functions nv_start_xmit() and nv_start_xmit_optimized() can be concurrently executed with nv_poll_controller(). nv_start_xmit line 2321: prev_tx_ctx->skb = skb; nv_start_xmit_optimized line 2479: prev_tx_ct

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
VIRTNET_SQ_STATS_LEN + + (page_pool_enabled && vi->mergeable_rx_bufs ? + page_pool_ethtool_stats_get_count() : 0)); vi->curr_queue_pairs should not multiply page_pool_ethtool

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
在 2023/11/29 22:59, Michael S. Tsirkin 写道: On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: 在 2023/5/26 13:46, Liang Chen 写道: what made you respond to a patch from May, now? I want to apply page_pool to our virtio_net. This virtio_net works on our device. I want to verify

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
在 2023/11/29 23:22, Zhu Yanjun 写道: 在 2023/11/29 22:59, Michael S. Tsirkin 写道: On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: 在 2023/5/26 13:46, Liang Chen 写道: what made you respond to a patch from May, now? I want to apply page_pool to our virtio_net. This virtio_net works

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
在 2023/11/30 10:34, Xuan Zhuo 写道: On Wed, 29 Nov 2023 23:29:10 +0800, Zhu Yanjun wrote: 在 2023/11/29 23:22, Zhu Yanjun 写道: 在 2023/11/29 22:59, Michael S. Tsirkin 写道: On Wed, Nov 29, 2023 at 10:50:57PM +0800, Zhu Yanjun wrote: 在 2023/5/26 13:46, Liang Chen 写道: what made you respond to a

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-11-29 Thread Zhu Yanjun
EN; } + + virtnet_get_page_pool_stats(dev, &data[idx]); virtnet_get_page_pool_stats(dev, &data[idx]); should be moved to between SQ and RQ. Combined with the correct page_pool_ethtool_stats_get_count, ethtool can get page_pool statistics. But all the values about page_poo

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-12-03 Thread Zhu Yanjun
在 2023/12/1 9:38, Xuan Zhuo 写道: On Thu, 30 Nov 2023 13:30:40 +0800, Zhu Yanjun wrote: 在 2023/11/30 10:34, Xuan Zhuo 写道: On Wed, 29 Nov 2023 23:29:10 +0800, Zhu Yanjun wrote: 在 2023/11/29 23:22, Zhu Yanjun 写道: 在 2023/11/29 22:59, Michael S. Tsirkin 写道: On Wed, Nov 29, 2023 at 10:50:57PM

Re: [PATCH vhost 18/23] vdpa/mlx5: Forward error in suspend/resume device

2024-06-23 Thread Zhu Yanjun
*mvdev = to_mvdev(vdev); struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev); + int err; Reverse Christmas Tree? Reviewed-by: Zhu Yanjun Zhu Yanjun mlx5_vdpa_info(mvdev, "suspending device\n"); down_write(&ndev->reslock); unregister_l

Re: [PATCH vhost 20/23] vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time

2024-07-08 Thread Zhu Yanjun
0 ms (only VQ config and resume). The measurements were done on a ConnectX6DX based vDPA device. " From the above, the performance is amazing. If we expect to use it in the production hosts, how much resources should we prepare to achieve this downtime? Zhu Yanjun The VQs are now created i

Re: [RFC PATCH 0/7] RDMA/rxe: On-Demand Paging on SoftRoCE

2022-09-08 Thread Zhu Yanjun
available for testing. pyverbs testcases in > rdma-core and perftest[7] are recommendable ones. Note that you may have to > build perftest from upstream since older versions do not handle ODP > capabilities correctly. ibv_rc_pingpong can also test the odp feature. Please add rxe odp tes

Re: [PATCH for-next v3 1/7] RDMA/rxe: Convert triple tasklets to use workqueue

2022-12-28 Thread Zhu Yanjun
he workqueue. > > There are already at least two patch sets that do this waiting to get > upstream. RXE accepted several patch sets just now. So it needs time to make tests and check bugs. Zhu Yanjun > Bob > > > > > As counterparts to tasklet_disable() and taskle

Re: [PATCH] RDMA/rxe: Fix memleak in rxe_mem_init_user

2020-08-19 Thread Zhu Yanjun
d, u64 start, > vaddr = page_address(sg_page_iter_page(&sg_iter)); > if (!vaddr) { > pr_warn("null vaddr\n"); > + ib_umem_release(umem); seems reasonabl

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-21 Thread Zhu Yanjun
nfig > to enable CRYPTO if CRYPTO_* selected. > > It is a little bit awkward to request all users of CRYPTO_* to request > select CRYPTO too. The same issue and similar patch is in this link: https://patchwork.kernel.org/project/linux-rdma/patch/20200915101559.33292-1-fazilyild

[PATCH V2] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe

2014-08-20 Thread Zhu Yanjun
I would also only expect a SCTP_PEER_ADDRESS_CHANGE notification when a path state changes, not on every try. " I made a patch to disable sending SCTP_PEER_ADDRESS_CHANGE notification every try. Now the patch is in the attachment. Please check it. Zhu Yanjun Zhu Yanjun (1): sctp

[PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe

2014-08-20 Thread Zhu Yanjun
y: Michael Tuexen Suggested-by: Daniel Borkmann Signed-off-by: Zhu Yanjun --- net/sctp/associola.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sctp/associola.c b/net/sctp/associola.c index 9de23a2..2e23f6b 100644 --- a/net/sctp/associola.c +++ b/net/sctp/associola.c @@ -813,6 +813

[PATCH 1/1] ipv4: net namespace does not inherit network configurations

2014-08-20 Thread Zhu Yanjun
inherit network configurations from another net namespace including the host. CC: Hong Zhiguo CC: David S. Miller Suggested-by: Cong Wang Signed-off-by: Zhu Yanjun --- net/ipv4/devinet.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/net/ipv4

[PATCH V2 0/1] ipv4: net namespace does not inherit network configurations

2014-08-20 Thread Zhu Yanjun
x this problem on ipv4. Any reply is appreciated. Zhu Yanjun (1): ipv4: net namespace does not inherit network configurations net/ipv4/devinet.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "

[PATCH 1/1] net:fec: buffer descriptor member variable order in IMX6

2014-08-21 Thread Zhu Yanjun
>From Reference Manual, freescale IMX6 is little endian mode. Therefore the first structure field is length, the second is status. CC: David Miller CC: Frank Li Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/freescale/fec.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[PATCH 0/1] net:fec: buffer descriptor member variable order in IMX6

2014-08-21 Thread Zhu Yanjun
>From Reference Manual, freescale IMX6 is little endian mode. Therefore the member variables in buffer descriptor should be length, status and so on. Zhu Yanjun (1): net:fec: buffer descriptor member variable order in IMX6 drivers/net/ethernet/freescale/fec.h | 3 ++- 1 file changed

sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe

2014-08-15 Thread Zhu Yanjun
to disable sending SCTP_PEER_ADDRESS_CHANGE notification every try. Now the patch is in the attachment. Please check it. Zhu Yanjun Zhu Yanjun (1): sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe net/sctp/associola.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 -- T

[PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe

2014-08-15 Thread Zhu Yanjun
When a failed probe comes along UNCONFIRMED path, it is not necessary to send SCTP_PEER_ADDR_CHANGE notification. Reported-by: DEEPAK KHANDELWAL Suggested-by: Vlad Yasevich Suggested-by: Michael Tuexen Signed-off-by: Zhu Yanjun --- net/sctp/associola.c | 1 + 1 file changed, 1 insertion

[PATCH] gianfar: disable vlan tag insertion by default on 2.6.x

2014-10-15 Thread Zhu Yanjun
longer, it is not necessary to disable it again. Zhu Yanjun (1): gianfar: disable vlan tag insertion by default drivers/net/gianfar.c | 6 -- 1 file changed, 6 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH] gianfar: disable vlan tag insertion by default

2014-10-15 Thread Zhu Yanjun
2.6.x kernels require a similar logic change as commit 51b8cbfc [gianfar: fix bug caused by e1653c3e] introduces for newer kernels. Gianfar driver originally enables vlan tag insertion by default. This will lead to unusable connections on some configurations. Since gianfar nic vlan tag insertion

Re: [PATCH 1/1] MAINTAINERS: add Yanjun to FORCEDETH maintainers list

2019-09-23 Thread Zhu Yanjun
On 2019/9/23 22:37, rain.1986.08...@gmail.com wrote: From: Rain River Yanjun has been spending quite a lot of time fixing bugs in FORCEDETH source code. I'd like to add Yanjun to maintainers list. Signed-off-by: Rain River Acked-by: Zhu Yanjun Thanks a lot. Zhu Y

Re: FW: [PATCH] RDMA/rxe: Fix possible NULL pointer dereference

2020-10-14 Thread Zhu Yanjun
Fix skb lifetime in rxe_rcv_mcast_pkt()") > Addresses-Coverity-ID: 1497804: Null pointer dereferences (NULL_RETURNS) > Signed-off-by: Alex Dewar Thanks a lot. Zhu Yanjun > --- > drivers/infiniband/sw/rxe/rxe_recv.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deleti