ping? any comments?
On Thu, Dec 20, 2012 at 10:43 PM, wrote:
> From: Zhi Yong Wu
>
> HI, guys,
>
> This patchset has been done scalability or performance tests
> by fs_mark, ffsb and compilebench.
> I have done the perf testing on Linux 3.7.0-rc8+ with Intel(R) C
Some misc bugs are found when i work on other tasks.
Now send out them for interview, thanks.
Zhi Yong Wu (2):
btrfs-progs: Close file descriptor on exit
btrfs-progs: Fix up memory leakage
cmds-filesystem.c | 16
1 files changed, 12 insertions(+), 4 deletions
Need to close fd on exit.
Signed-off-by: Zhi Yong Wu
---
cmds-filesystem.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index b1457de..e62c4fd 100644
--- a/cmds-filesystem.c
+++ b/cmds-filesystem.c
@@ -77,18 +77,23
Some code pathes forget to free memory on exit.
Changelog from v1:
Fix the variable is used uncorrectly. [Ram Pai]
Signed-off-by: Zhi Yong Wu
---
cmds-filesystem.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index
Sorry, forgot CCed to Ted.
On Tue, Sep 11, 2012 at 10:27 PM, wrote:
> From: Zhi Yong Wu
>
> HI, folks
> I have pushed the patchset to my kernel dev git tree:
> g...@github.com:wuzhy/kernel.git
>
> Also, you can review it via
> https://github.com/wuzhy/kernel/c
hi, all maintainers.
ping? any comments are appreciated, thanks.
On Wed, Sep 12, 2012 at 10:31 PM, Zhi Yong Wu wrote:
> Sorry, forgot CCed to Ted.
>
> On Tue, Sep 11, 2012 at 10:27 PM, wrote:
>> From: Zhi Yong Wu
>>
>> HI, folks
>> I have pushed the patchse
On Fri, Nov 2, 2012 at 4:41 PM, Zheng Liu wrote:
> On Fri, Nov 02, 2012 at 02:38:29PM +0800, Zhi Yong Wu wrote:
>> Here also has another question.
>>
>> How to save the file temperature among the umount to be able to
>> preserve the file tempreture after rebo
On Sat, Nov 3, 2012 at 4:10 AM, Darrick J. Wong wrote:
> On Fri, Nov 02, 2012 at 04:41:09PM +0800, Zheng Liu wrote:
>> On Fri, Nov 02, 2012 at 02:38:29PM +0800, Zhi Yong Wu wrote:
>> > Here also has another question.
>> >
>> > How to save the file temper
On Sat, Nov 3, 2012 at 5:27 AM, Mingming.cao wrote:
> On Fri, 2012-11-02 at 14:38 +0800, Zhi Yong Wu wrote:
>> Here also has another question.
>>
>> How to save the file temperature among the umount to be able to
>> preserve the file tempreture after reboot?
>>
/osd_client.h | 2 +-
> include/linux/ceph/osdmap.h | 6 +-
> net/ceph/messenger.c| 6 +-
> net/ceph/osd_client.c | 32 --
> net/ceph/osdmap.c | 18 ++-
> 29 files changed, 310 insertions(+
On Mon, Nov 5, 2012 at 3:41 PM, Greg Kroah-Hartman
wrote:
> On Mon, Nov 05, 2012 at 03:37:31PM +0800, Zhi Yong Wu wrote:
>> HI, greg
>>
>> Some of the patchset haven't passed the check of checkpatch.pl as below:
>>
>> WARNING: line over 80 characters
>
On Mon, Nov 5, 2012 at 4:28 PM, Dave Chinner wrote:
> On Mon, Nov 05, 2012 at 10:35:50AM +0800, Zhi Yong Wu wrote:
>> On Sat, Nov 3, 2012 at 5:27 AM, Mingming.cao wrote:
>> > On Fri, 2012-11-02 at 14:38 +0800, Zhi Yong Wu wrote:
>> >> Here also has another questio
On Mon, Nov 5, 2012 at 6:33 PM, Steven Whitehouse wrote:
> Hi,
>
> On Mon, 2012-11-05 at 16:44 +0800, Zhi Yong Wu wrote:
>> On Mon, Nov 5, 2012 at 4:28 PM, Dave Chinner wrote:
>> > On Mon, Nov 05, 2012 at 10:35:50AM +0800, Zhi Yong Wu wrote:
>> >> On Sat,
On Mon, Nov 5, 2012 at 7:07 PM, Steven Whitehouse wrote:
> Hi,
>
> On Mon, 2012-10-29 at 12:30 +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Add some util helpers to update access frequencies
>> for one file or its range.
>>
>&
On Mon, Nov 5, 2012 at 7:21 PM, Steven Whitehouse wrote:
> Hi,
>
> On Mon, 2012-10-29 at 12:30 +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Add a per-superblock workqueue and a delayed_work
>> to run periodic work to update map info on each sup
On Mon, Nov 5, 2012 at 7:57 PM, Steven Whitehouse wrote:
> Hi,
>
> On Mon, 2012-11-05 at 19:46 +0800, Zhi Yong Wu wrote:
>> On Mon, Nov 5, 2012 at 6:33 PM, Steven Whitehouse
>> wrote:
>> > Hi,
>> >
>> > On Mon, 2012-11-05 at 16:44 +0800, Zhi Yon
On Mon, Nov 5, 2012 at 8:07 PM, Steven Whitehouse wrote:
> Hi,
>
> On Mon, 2012-11-05 at 19:55 +0800, Zhi Yong Wu wrote:
>> On Mon, Nov 5, 2012 at 7:21 PM, Steven Whitehouse
>> wrote:
>> > Hi,
>> >
>> > On Mon, 2012-10-29 at 12:30 +0800, zwu
On Tue, Sep 25, 2012 at 3:37 PM, Dave Chinner wrote:
> On Sun, Sep 23, 2012 at 08:56:26PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> One root structure hot_info is defined, is hooked
>> up in super_block, and will be used to hold rb trees
>&
On Tue, Sep 25, 2012 at 3:37 PM, Dave Chinner wrote:
> On Sun, Sep 23, 2012 at 08:56:26PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> One root structure hot_info is defined, is hooked
>> up in super_block, and will be used to hold rb trees
>&
On Tue, Sep 25, 2012 at 6:12 PM, David Sterba wrote:
> On Tue, Sep 25, 2012 at 10:02:15AM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Need to close fd on exit.
>
> Strictly you don't need to, kernel will do that at exit() time.
I know, b
On Tue, Sep 25, 2012 at 6:14 PM, David Sterba wrote:
> On Tue, Sep 25, 2012 at 10:02:16AM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Some code pathes forget to free memory on exit.
>
> Same as with the fd's, kernel will free all memory for
thanks a lot for your review in my heart, Dave. It is very helpful to me.
On Tue, Sep 25, 2012 at 5:17 PM, Dave Chinner wrote:
> On Sun, Sep 23, 2012 at 08:56:27PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Add some utils helpers to update access freque
On Tue, Sep 25, 2012 at 5:28 PM, Dave Chinner wrote:
> On Sun, Sep 23, 2012 at 08:56:28PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Introduce one new mount option '-o hottrack',
>> and add its parsing support.
>> Its usage look
On Wed, Sep 26, 2012 at 1:14 AM, Goffredo Baroncelli wrote:
> On 09/25/2012 12:14 PM, David Sterba wrote:
>>
>> On Tue, Sep 25, 2012 at 10:02:16AM +0800, zwu.ker...@gmail.com wrote:
>>>
>>> From: Zhi Yong Wu
>>>
>>>Some code pathes forget to
On Tue, Sep 25, 2012 at 6:20 PM, Ram Pai wrote:
> On Sun, Sep 23, 2012 at 08:56:26PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> One root structure hot_info is defined, is hooked
>> up in super_block, and will be used to hold rb trees
>> ro
On Tue, Sep 25, 2012 at 5:54 PM, Ram Pai wrote:
> On Sun, Sep 23, 2012 at 08:56:30PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Adds a hash table structure which contains
>> a lot of hash list and is used to efficiently
>> look up the
(he, cur);
>> + if (IS_ERR(hr)) {
>> + WARN_ON(1);
>> + hot_inode_item_put(he);
>> + return;
>> + }
>> +
>> + spin_lock(&hr->hot_range.lock);
>> +
On Mon, Oct 29, 2012 at 10:01 AM, Dave Chinner wrote:
> On Sun, Oct 28, 2012 at 09:51:48PM +0800, Zhi Yong Wu wrote:
>> On Sun, Oct 28, 2012 at 3:55 PM, Zheng Liu wrote:
>> > Hi Zhiyong,
>> >
>> > On Thu, Oct 25, 2012 at 11:08:55PM +0800, zwu.ker...@gmail.co
utely not optional.
ah, i know, but now i need to make sure all the codes are correct at
first, then do these tests.
>
> -Andi
>
> --
> a...@linux.intel.com -- Speaking for myself only
--
Regards,
Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-
On Tue, Oct 30, 2012 at 2:11 AM, Greg KH wrote:
> On Mon, Oct 29, 2012 at 12:30:55PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> The debugfs function is used to get expected dentry.
>
> Huh? Why do you need this? Why haven't you added doc
On Tue, Oct 30, 2012 at 2:10 AM, Greg KH wrote:
> On Mon, Oct 29, 2012 at 12:30:57PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Add two proc files hot-kick-time and hot-update-delay
>> under the dir /proc/sys/fs/ in order to turn
>> TIME_TO_K
On Tue, Oct 30, 2012 at 6:34 AM, Greg KH wrote:
> On Tue, Oct 30, 2012 at 06:25:50AM +0800, Zhi Yong Wu wrote:
>> On Tue, Oct 30, 2012 at 2:11 AM, Greg KH wrote:
>> > On Mon, Oct 29, 2012 at 12:30:55PM +0800, zwu.ker...@gmail.com wrote:
>> >> From: Zhi Yong Wu
>
On Tue, Oct 30, 2012 at 6:54 AM, Greg KH wrote:
> On Tue, Oct 30, 2012 at 06:45:19AM +0800, Zhi Yong Wu wrote:
>> On Tue, Oct 30, 2012 at 6:34 AM, Greg KH wrote:
>> > On Tue, Oct 30, 2012 at 06:25:50AM +0800, Zhi Yong Wu wrote:
>> >> On Tue, Oct 30, 2012 at
On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote:
> On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote:
>> In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote:
>>> On Fri, Aug 23, 2013 at 7:45 AM, wrote:
>>>> From: Zhi Yong Wu
>&g
On Thu, Sep 5, 2013 at 7:59 AM, Davidlohr Bueso wrote:
> On Thu, 2013-09-05 at 01:22 +0800, Zhi Yong Wu wrote:
>> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote:
>> > On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote:
>> >> In Tue, Aug 27, 2013
On Thu, Sep 5, 2013 at 9:12 AM, Davidlohr Bueso wrote:
> On Thu, 2013-09-05 at 08:37 +0800, Zhi Yong Wu wrote:
>> On Thu, Sep 5, 2013 at 7:59 AM, Davidlohr Bueso wrote:
>> > On Thu, 2013-09-05 at 01:22 +0800, Zhi Yong Wu wrote:
>> >> On Mon, Sep 2, 2013
In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote:
> On Fri, Aug 23, 2013 at 7:45 AM, wrote:
>> From: Zhi Yong Wu
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> include/linux/rbtree_augmented.h | 3 ++-
>> lib/rbtree.c | 5 +++--
On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote:
> On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote:
>> In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote:
>>> On Fri, Aug 23, 2013 at 7:45 AM, wrote:
>>>> From: Zhi Yong Wu
>&g
On Tue, Sep 3, 2013 at 1:48 PM, Michel Lespinasse wrote:
> On Mon, Sep 2, 2013 at 9:45 PM, Zhi Yong Wu wrote:
>> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote:
>>> Thanks for the link - I now better understand where you are coming
>>> from with these fixes
On Tue, Sep 3, 2013 at 1:48 PM, Michel Lespinasse wrote:
> On Mon, Sep 2, 2013 at 9:45 PM, Zhi Yong Wu wrote:
>> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote:
>>> Thanks for the link - I now better understand where you are coming
>>> from with these fixes
On Tue, Sep 24, 2013 at 8:20 AM, Al Viro wrote:
> On Tue, Sep 17, 2013 at 06:17:45AM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> The patchset is trying to introduce hot tracking function in
>> VFS layer, which will keep track of real disk I/O in
@vger.kernel.org,
>> linux-kernel@vger.kernel.org, linux...@linux.vnet.ibm.com,
>> v...@zeniv.linux.org.uk, da...@fromorbit.com, d...@jikos.cz,
>> ty...@mit.edu, c...@us.ibm.com, Zhi Yong Wu
>> Subject: [RFC v3 01/13] btrfs: add one new mount option '-o hot_tr
On Wed, Oct 10, 2012 at 9:11 PM, Lukáš Czerner wrote:
> On Wed, 10 Oct 2012, Zhi Yong Wu wrote:
>
>> Date: Wed, 10 Oct 2012 20:21:48 +0800
>> From: Zhi Yong Wu
>> To: Lukáš Czerner
>> Cc: linux-fsde...@vger.kernel.org, linux-e...@vger.kernel.org,
>> linux
On Sun, Dec 2, 2012 at 8:27 PM, Zheng Liu wrote:
> On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>
> Please write a commit log to describe this patch, even though it is
> quite simple and straightfoward
Good suggestion, thanks.
>
41.32s)
delete tree total runs 10 avg 41.44 seconds (user 6.43s sys 25.19s)
delete compiled tree total runs 4 avg 47.81 seconds (user 7.18s sys
29.27s)
stat tree total runs 11 avg 20.41 seconds (user 6.39s sys 7.45s)
stat compiled tree total runs 7 avg 23.97 seconds (user 7.24s sys 8.74s)
On Fri,
On Tue, Oct 16, 2012 at 8:27 AM, Dave Chinner wrote:
> On Wed, Oct 10, 2012 at 06:07:31PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Add a per-superblock workqueue and a work_struct
>> to run periodic work to update map info on each superblock.
&g
On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote:
> On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> NOTE:
>>
>> The patchset is currently post out mainly to make sure
>> it is going in the correct di
On Thu, Oct 18, 2012 at 10:25 AM, Zheng Liu wrote:
> On Wed, Oct 17, 2012 at 02:34:15PM +0800, Zhi Yong Wu wrote:
>> >> diff --git a/fs/hot_tracking.h b/fs/hot_tracking.h
>> >> index d19e64a..7a79a6d 100644
>> >> --- a/fs/hot_tracking.h
>> &g
On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner wrote:
> On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote:
>> On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote:
>> > On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote:
>> >> From: Zhi Y
On Thu, Oct 18, 2012 at 1:17 PM, Dave Chinner wrote:
> On Thu, Oct 18, 2012 at 12:44:47PM +0800, Zhi Yong Wu wrote:
>> On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner wrote:
>> > On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote:
>> >> On Tue, Oct 16,
On Tue, Oct 16, 2012 at 11:17 AM, Dave Chinner wrote:
> On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> FS_IOC_GET_HEAT_INFO: return a struct containing the various
>> metrics collected in btrfs_freq_data structs, an
On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner wrote:
> On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> NOTE:
>>
>> The patchset is currently post out mainly to make sure
>> it is going in the correct di
HI, all guys.
any comments or suggestions?
On Thu, Dec 6, 2012 at 11:28 AM, Zhi Yong Wu wrote:
> HI, guys
>
> THe perf testing is done separately with fs_mark, fio, ffsb and
> compilebench in one kvm guest.
>
> Below is the performance testing report for hot tracking, and
On Tue, Nov 6, 2012 at 4:39 PM, Zheng Liu wrote:
> On Mon, Nov 05, 2012 at 10:29:39AM +0800, Zhi Yong Wu wrote:
>> On Fri, Nov 2, 2012 at 4:41 PM, Zheng Liu wrote:
>> > On Fri, Nov 02, 2012 at 02:38:29PM +0800, Zhi Yong Wu wrote:
>> >> Here also has another questio
> + int ret = -ENOMEM;
>> +
>> + root = kzalloc(sizeof(struct hot_info), GFP_NOFS);
>> + if (!root) {
>> + printk(KERN_ERR "%s: Failed to malloc memory for "
>> + "hot_info\n", __func__);
>> +
kmem_cache_free(hot_range_item_cachep, hr);
>
> radix_tree_preload_end()
I checked some kernel existing cases about the usage of
radix_tree_preload(), it seems that when radix_tree_preload() fail,
its error handling doesn't need call radix_tree_preload_end() any
more.
>
>
t;
> There's a stale \ at the end of the line, and I find this formatting
> hard to read. Does the following look acceptable?
yes, great, thanks.
>
> hot_update_freqs(mapping->host,
> (u64)(list_entry(pages->prev, struct page, lru)->index)
>
func_ops {
>> + hot_rw_freq_calc_fn *hot_rw_freq_calc_fn;
>> + hot_temp_calc_fn *hot_temp_calc_fn;
>> + hot_is_obsolete_fn *hot_is_obsolete_fn;
>> +};
>
> My suggestion is to make the types explicit in the structure.
sorry, i don't get your point, can you ela
;
>> + } else {
>> + /* not live temperature, get it from the hashlist */
>> + heat_info->temp = he->hot_inode.hot_freq_data.last_temp;
>> + }
>> + spin_unlock(&he->hot_inode.lock);
>> +
>> + hot_inode_item_pu
; + &root->heat_range_map[i].node_list, pos);
>> + goto next;
>> + }
>> +
>> + return NULL;
>> +}
>> +
>> +static void hot_debugfs_exit(struct super_block *sb)
>> +{
>> + struct dentry *vol_dentry;
>> +
>>
On Wed, Nov 7, 2012 at 8:00 AM, David Sterba wrote:
> On Mon, Oct 29, 2012 at 12:30:58PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Introduce one new mount option '-o hot_track',
>> and add its parsing support.
>> Its usage looks
On Wed, Nov 7, 2012 at 6:45 AM, Darrick J. Wong wrote:
> On Mon, Oct 29, 2012 at 12:30:45PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Add some util helpers to update access frequencies
>> for one file or its range.
>>
>> Si
On Wed, Nov 7, 2012 at 7:30 AM, Darrick J. Wong wrote:
> On Mon, Oct 29, 2012 at 12:30:52PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Introduce one framwork to enable that specific FS
>> can register its own hot tracking functions.
>&
super(
> {
> struct xfs_mount*mp = XFS_M(sb);
>
> + if (mp->m_flags & XFS_MOUNT_HOTTRACK)
> + hot_track_exit(sb);
> +
> xfs_filestream_unmount(mp);
> xfs_unmountfs(mp);
>
> @@ -1470,6 +1477,8 @@ xfs_fs_fill_super(
>
On Mon, Oct 29, 2012 at 12:30 PM, wrote:
> From: Zhi Yong Wu
>
> NOTE:
>
> The patchset can be obtained via my kernel dev git on github:
> g...@github.com:wuzhy/kernel.git hot_tracking
> If you're interested, you can also can review them via
> https://gi
On Thu, Nov 8, 2012 at 2:49 AM, Darrick J. Wong wrote:
> On Wed, Nov 07, 2012 at 04:27:05PM +0800, Zhi Yong Wu wrote:
>> On Wed, Nov 7, 2012 at 6:45 AM, Darrick J. Wong
>> wrote:
>> > On Mon, Oct 29, 2012 at 12:30:45PM +0800, zwu.ker...@gmail.com wrote:
On Thu, Nov 8, 2012 at 2:58 AM, Darrick J. Wong wrote:
> On Wed, Nov 07, 2012 at 04:34:35PM +0800, Zhi Yong Wu wrote:
>> On Wed, Nov 7, 2012 at 7:30 AM, Darrick J. Wong
>> wrote:
>> > On Mon, Oct 29, 2012 at 12:30:52PM +0800, zwu.ker...@gmail.com wrote:
HI,
The raw data is very big, i don't know if it is appropriate to post
them here. If you want to get them, please let me know.
On Thu, Dec 20, 2012 at 10:43 PM, wrote:
> From: Zhi Yong Wu
>
> HI, guys,
>
> This patchset has been done scalability or performance tests
&g
;
>> + if (!root) {
>> + printk(KERN_ERR "%s: Failed to malloc memory for "
>> + "hot_info\n", __func__);
>> + return ret;
>
> minor: you can drop the variable ret and just reurn ENOMEM here
>
>> + }
On Fri, Jul 26, 2013 at 7:35 PM, Dave Chinner wrote:
> On Fri, Jul 26, 2013 at 02:36:15PM +0800, Zhi Yong Wu wrote:
>> Dave,
>>
>> All comments are good to me, and will be applied to next version, thanks a
>> lot.
>>
>> On Fri, Jul 26, 2013 at 10:50 AM, D
On Mon, Jul 29, 2013 at 10:45 AM, Dave Chinner wrote:
> On Mon, Jul 29, 2013 at 09:38:11AM +0800, Zhi Yong Wu wrote:
>> By the way, how do you try the workload which has nothing but dirty
>> dquote objects?
>
> Create quota limits for non-existent users. That will allocate t
On Fri, Jul 26, 2013 at 7:37 PM, Dave Chinner wrote:
> On Fri, Jul 26, 2013 at 02:01:23PM +0800, Zhi Yong Wu wrote:
>> No, it still raised the same assertion as below:
>>
>> [ 521.715103] XFS: Assertion failed: !(bip->bli_item.li_flags &
>> XFS_LI_IN_AIL), file
On Tue, Jul 30, 2013 at 9:10 PM, Brian Foster wrote:
> On 07/30/2013 05:59 AM, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> It can take a long time to run log recovery operation because it is
>> single threaded and is bound by read latency. We can find
On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner wrote:
> On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> It can take a long time to run log recovery operation because it is
>> single threaded and is bound by read latenc
On Wed, Jul 31, 2013 at 9:35 PM, Ben Myers wrote:
> Hey Zhi,
>
> On Wed, Jul 31, 2013 at 12:07:32PM +0800, Zhi Yong Wu wrote:
>> On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner wrote:
>> > On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote:
HI,
If you'd like, you should draft one patch for this warning.
On Thu, Aug 22, 2013 at 9:02 AM, Joe Perches wrote:
> On Thu, 2013-08-22 at 08:44 +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Initialize csum variable to fix the build warning.
&
eturn -EINVAL;
> }
>
> - if (scsi_debug_guard > 1) {
> + if (scsi_debug_guard < 0 || scsi_debug_guard > 1) {
I don't think that it can fix that issue.
> printk(KERN_ERR "scsi_debug_init: guard must be 0 or 1\n");
>
HI, xfs maintainers,
any comments?
On Wed, Jul 31, 2013 at 4:42 PM, wrote:
> From: Zhi Yong Wu
>
> It can take a long time to run log recovery operation because it is
> single threaded and is bound by read latency. We can find that it took
> most of the time to wait for the r
at 09:38:44PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> When running the compilebench, one assertion failure was found.
>> This related line of code was introduced by commit 5f6bed76c0.
>>
>> commit 5f6bed76c0c85cb4d04885a5de00b629deee550b
&
Dave,
All comments are good to me, and will be applied to next version, thanks a lot.
On Fri, Jul 26, 2013 at 10:50 AM, Dave Chinner wrote:
> On Thu, Jul 25, 2013 at 04:23:39PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> It can take a long time to run l
On Wed, Aug 14, 2013 at 1:35 PM, Dave Chinner wrote:
> On Wed, Jul 31, 2013 at 04:42:45PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> It can take a long time to run log recovery operation because it is
>> single threaded and is bound by read latenc
Ping...
On Tue, May 14, 2013 at 8:59 AM, wrote:
> From: Zhi Yong Wu
>
> The patchset is trying to introduce hot tracking function in
> VFS layer, which will keep track of real disk I/O in memory.
> By it, you will easily know more details about disk I/O, and
> then detect
HI, Al Viro.
I have incorporated all comments from all reviewers and waited for
so long time. If you have no comments, can you merge the patchset?
thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majord
On Mon, Sep 17, 2012 at 5:45 PM, Marco Stornelli
wrote:
> 2012/9/17 :
>> From: Zhi Yong Wu
>>
>> NOTE:
>>
>> The patchset is currently post out mainly to make sure
>> it is going in the correct direction and hope to get some
>> helpful commen
On Tue, Sep 18, 2012 at 5:30 AM, Dave Chinner wrote:
> On Mon, Sep 17, 2012 at 03:18:34PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> NOTE:
>>
>> The patchset is currently post out mainly to make sure
>> it is going in the correct di
On Tue, Sep 18, 2012 at 2:20 PM, Dave Chinner wrote:
> On Tue, Sep 18, 2012 at 10:24:55AM +0800, Zhi Yong Wu wrote:
>> On Tue, Sep 18, 2012 at 5:30 AM, Dave Chinner wrote:
>> > On Mon, Sep 17, 2012 at 03:18:34PM +0800, zwu.ker...@gmail.com wrote:
>> >> 20 files
t" [fs/btrfs/btrfs.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> make: *** Waiting for unfinished jobs
Sorry for late response at first. Great, thanks.
>
>
> david
--
Regards,
Zhi Yong Wu
--
To unsubscribe from this list: send the line
urrounding code that a message is printed
> when enabling options, but the vfs prints its own, so I'm not sure if
> it's needed here as well. Just thinking, leave it as it is now.
OK
>
>> + btrfs_set_opt(info->mount_opt, HOT_TRACK);
>> + brea
e is printed
> when enabling options, but the vfs prints its own, so I'm not sure if
> it's needed here as well. Just thinking, leave it as it is now.
>
>> + btrfs_set_opt(info->mount_opt, HOT_TRACK);
>> + break;
>> #ifdef CONFIG_BTRFS_FS
On Thu, Oct 11, 2012 at 10:41 PM, David Sterba wrote:
> On Thu, Oct 11, 2012 at 10:35:28PM +0800, Zhi Yong Wu wrote:
>> >> --- a/fs/btrfs/super.c
>> >> +++ b/fs/btrfs/super.c
>> >> @@ -303,7 +304,7 @@ enum {
>> >> Opt_n
or tracking access frequency of inodes and sub-file
> ^^^ s/rbtrees/radix-trees
>> +ranges (hot_rb.c)
> Now it seems that all codes are in the same file.
HI, Zheng,
Good catch, i will update them, thanks.
>
> Regards,
> Zheng
-
On Mon, Oct 15, 2012 at 8:39 AM, Zheng Liu wrote:
> On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> NOTE:
>>
>> The patchset is currently post out mainly to make sure
>> it is going in the correct di
On Mon, Oct 15, 2012 at 3:48 PM, Dave Chinner wrote:
> On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> FS_IOC_GET_HEAT_INFO: return a struct containing the various
>> metrics collected in btrfs_freq_data structs, and
On Mon, Oct 15, 2012 at 3:55 PM, Dave Chinner wrote:
> On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Add a /sys/kernel/debug/hot_track// directory for each
>> volume that contains two files. The first, `inode_
On Mon, Oct 15, 2012 at 4:04 PM, Dave Chinner wrote:
> On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Add a /sys/kernel/debug/hot_track// directory for each
>> volume that contains two files. The first, `inode_
On Tue, Oct 16, 2012 at 11:17 AM, Dave Chinner wrote:
> On Wed, Oct 10, 2012 at 06:07:33PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> FS_IOC_GET_HEAT_INFO: return a struct containing the various
>> metrics collected in btrfs_freq_data structs, an
On Thu, Jan 10, 2013 at 8:48 AM, David Sterba wrote:
> On Thu, Dec 20, 2012 at 10:43:21PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>> --- a/fs/hot_tracking.c
>> +++ b/fs/hot_tracking.c
>> @@ -107,3 +189,38 @@ err:
>> kmem_ca
c_sub(cur_time, old_atime);
>> + new_delta = timespec_to_ns(&delta_ts) >> FREQ_POWER;
>> +
>> + *avg = (*avg << FREQ_POWER) - *avg + new_delta;
>> + *avg = *avg >> FREQ_POWER;
>> +}
>> +
>> +static void hot_freq_data_update(struct hot_fre
dahead.c
>> @@ -138,6 +139,12 @@ static int read_pages(struct address_space *mapping,
>> struct file *filp,
>> out:
>> blk_finish_plug(&plug);
>>
>> + /* Hot data tracking */
>> + hot_update_freqs(mapping->host,
>> + (loff_t)(list_entry(pages->prev, struct page, lru)->index)
>> + << PAGE_CACHE_SHIFT,
>> + (size_t)nr_pages * PAGE_CACHE_SIZE, 0);
>
> same comment here
Ditto. thanks.
>
>> +
>> return ret;
>> }
>
>
> david
--
Regards,
Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
unction up to here I've got lost in the shifts that
> I don't see the meaning of the resulting value and how can I interpet it
> if I watch it change over time. What are the expected weights of the
> number and time factors? There are more details in the documentation, but
> the b
1 - 100 of 236 matches
Mail list logo
