[PATCH v6 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices()

To remove mfd devices when unload this driver, should use devm_mfd_add_devices() instead. Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones Reviewed-by: Geert Uytterhoeven Reviewed-by: Matti Vaittinen --

[PATCH v6 04/12] regulator: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/regulator/bd9571mwv-regulator.c | 49 + 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a

[PATCH v6 12/12] mfd: bd9571mwv: Add support for BD9574MWF

From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen Co-developed-by: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/mfd/bd9571mwv.c

[PATCH v6 07/12] gpio: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-bd9571mwv.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH v6 08/12] gpio: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is similar chip with BD9571MWV. Note that BD9574MWF has additional features "RECOV_GPOUT", "FREQSEL" and "RTC_IN", but supports GPIO function only. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-

[PATCH v6 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

Use dev_regmap_add_irq_chip() to simplify the code. Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones Reviewed-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/mfd/bd9571mwv.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff

[PATCH v6 11/12] mfd: bd9571mwv: Make the driver more generic

: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/mfd/bd9571mwv.c | 89 +-- include/linux/mfd/bd9571mwv.h | 18 + 2 files changed, 54 insertions(+), 53 deletions(-) diff --git a/drivers/mfd/bd9571mwv.c

[PATCH v6 05/12] regulator: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is similar chip with BD9571MWV. Note that we don't support voltage rails VD{09,18,25,33} by this driver on BD9574. The VD09 voltage could be read from PMIC but that is not supported by this commit. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vait

[PATCH v6 02/12] dt-bindings: mfd: bd9571mwv: Document BD9574MWF

Document other similar specification chip BD9574MWF. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree

[PATCH v6 03/12] mfd: rohm-generic: Add BD9571 and BD9574

Add chip IDs for BD9571MWV and BD9574MWF. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones --- include/linux/mfd/rohm-generic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h

[PATCH v6 09/12] mfd: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Acked-for-MFD-by: Lee Jones --- drivers/mfd/bd9571mwv.c | 10 +- include/linux/mfd/bd9571mwv.h | 10 +- 2 files changed, 2 insertions(+), 18

[PATCH v6 00/12] treewide: bd9571mwv: Add support for BD9574MWF

571mwv: Make the driver more generic mfd: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda (10): mfd: bd9571mwv: Use devm_mfd_add_devices() dt-bindings: mfd: bd9571mwv: Document BD9574MWF mfd: rohm-generic: Add BD9571 and BD9574 regulator: bd9571mwv: rid of using struct bd9571m

[PATCH v6 06/12] gpio: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-bd9571mwv.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio

[PATCH 0/3] mfd: bd9571mwv: Add support for BD9574MWF

Add BD574MWF support into bd9571mwv mfd driver. Latest Ebisu-4D boards has this chip instead of BD9571MWV so that we need this patch. Khiem Nguyen (2): mfd: bd9571mwv: Make the driver more generic mfd: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda (1): mfd: bd9571mwv: Use the SPDX

[PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen [shimoda: rebase and refactor] Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 92

[PATCH 1/3] mfd: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 10 +- include/linux/mfd/bd9571mwv.h | 10 +- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/mfd/bd9571mwv.c b/drivers

[PATCH 2/3] mfd: bd9571mwv: Make the driver more generic

From: Khiem Nguyen Since the driver supports BD9571MWV PMIC only, this patch makes the functions and data structure become more generic so that it can support other PMIC variants as well. Signed-off-by: Khiem Nguyen [shimoda: rebase and refactor] Signed-off-by: Yoshihiro Shimoda --- drivers

RE: [PATCH v6 11/12] mfd: bd9571mwv: Make the driver more generic

Hi Lee, > From: Lee Jones, Sent: Thursday, December 24, 2020 12:39 AM > On Wed, 23 Dec 2020, Yoshihiro Shimoda wrote: > > From: Khiem Nguyen > > > > Since the driver supports BD9571MWV PMIC only, this patch makes > > the functions and data structure become more gene

[PATCH v7 00/12] treewide: bd9571mwv: Add support for BD9574MWF

ator drivers. - Add missing regmap ranges for BD9574MWF. - Rename "part_number" with "part_name". https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059 Khiem Nguyen (2): mfd: bd9571mwv: Make the driver more generic mfd: bd9571mwv: Add support fo

[PATCH v7 05/12] regulator: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is similar chip with BD9571MWV. Note that we don't support voltage rails VD{09,18,25,33} by this driver on BD9574. The VD09 voltage could be read from PMIC but that is not supported by this commit. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vait

[PATCH v7 02/12] dt-bindings: mfd: bd9571mwv: Document BD9574MWF

Document other similar specification chip BD9574MWF. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree

[PATCH v7 06/12] gpio: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-bd9571mwv.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio

[PATCH v7 09/12] mfd: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Acked-for-MFD-by: Lee Jones --- drivers/mfd/bd9571mwv.c | 10 +- include/linux/mfd/bd9571mwv.h | 10 +- 2 files changed, 2 insertions(+), 18

[PATCH v7 11/12] mfd: bd9571mwv: Make the driver more generic

: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/mfd/bd9571mwv.c | 77 +++ include/linux/mfd/bd9571mwv.h | 18 ++ 2 files changed, 43 insertions(+), 52 deletions(-) diff --git a/drivers/mfd/bd9571mwv.c

[PATCH v7 12/12] mfd: bd9571mwv: Add support for BD9574MWF

From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen Co-developed-by: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones

[PATCH v7 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

Use dev_regmap_add_irq_chip() to simplify the code. Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones Reviewed-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/mfd/bd9571mwv.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff

[PATCH v7 07/12] gpio: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-bd9571mwv.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH v7 08/12] gpio: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is similar chip with BD9571MWV. Note that BD9574MWF has additional features "RECOV_GPOUT", "FREQSEL" and "RTC_IN", but supports GPIO function only. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-

[PATCH v7 03/12] mfd: rohm-generic: Add BD9571 and BD9574

Add chip IDs for BD9571MWV and BD9574MWF. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones --- include/linux/mfd/rohm-generic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h

[PATCH v7 04/12] regulator: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/regulator/bd9571mwv-regulator.c | 49 + 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a

[PATCH v7 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices()

To remove mfd devices when unload this driver, should use devm_mfd_add_devices() instead. Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones Reviewed-by: Geert Uytterhoeven Reviewed-by: Matti Vaittinen --

RE: [PATCH v6 11/12] mfd: bd9571mwv: Make the driver more generic

Hi Lee, > From: Lee Jones, Sent: Thursday, December 24, 2020 4:34 PM > > Hi Lee, > > > > > From: Lee Jones, Sent: Thursday, December 24, 2020 12:39 AM > > > On Wed, 23 Dec 2020, Yoshihiro Shimoda wrote: > > > > From: Khiem Nguyen > &

RE: [PATCH v7 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

Hello Sergei, > From: Sergei Shtylyov, Sent: Thursday, December 24, 2020 5:50 PM > On 24.12.2020 10:04, Yoshihiro Shimoda wrote: > > > Use dev_regmap_add_irq_chip() to simplify the code. > > devm_? Thank you for the pointed it out. I'll fix it. Best regards, Yoshihiro Shimoda

[PATCH v8 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices()

To remove mfd devices when unload this driver, should use devm_mfd_add_devices() instead. Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones Reviewed-by: Geert Uytterhoeven Reviewed-by: Matti Vaittinen --

[PATCH v8 00/12] treewide: bd9571mwv: Add support for BD9574MWF

https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059 Khiem Nguyen (2): mfd: bd9571mwv: Make the driver more generic mfd: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda (10): mfd: bd9571mwv: Use devm_mfd_add_devices() dt-bindings: mfd: bd9571mwv: Document BD9574MW

[PATCH v8 04/12] regulator: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/regulator/bd9571mwv-regulator.c | 49 + 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a

[PATCH v8 06/12] gpio: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-bd9571mwv.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio

[PATCH v8 12/12] mfd: bd9571mwv: Add support for BD9574MWF

From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen Co-developed-by: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones

[PATCH v8 11/12] mfd: bd9571mwv: Make the driver more generic

: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones --- drivers/mfd/bd9571mwv.c | 77 +++ include/linux/mfd/bd9571mwv.h | 18 ++ 2 files changed, 43 insertions(+), 52 deletions(-) diff

[PATCH v8 09/12] mfd: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Acked-for-MFD-by: Lee Jones --- drivers/mfd/bd9571mwv.c | 10 +- include/linux/mfd/bd9571mwv.h | 10 +- 2 files changed, 2 insertions(+), 18

[PATCH v8 02/12] dt-bindings: mfd: bd9571mwv: Document BD9574MWF

Document other similar specification chip BD9574MWF. Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones --- Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt

[PATCH v8 07/12] gpio: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-bd9571mwv.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH v8 08/12] gpio: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is similar chip with BD9571MWV. Note that BD9574MWF has additional features "RECOV_GPOUT", "FREQSEL" and "RTC_IN", but supports GPIO function only. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-

[PATCH v8 03/12] mfd: rohm-generic: Add BD9571 and BD9574

Add chip IDs for BD9571MWV and BD9574MWF. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones --- include/linux/mfd/rohm-generic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h

[PATCH v8 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

Use devm_regmap_add_irq_chip() to simplify the code. Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones Reviewed-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/mfd/bd9571mwv.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff

[PATCH v8 05/12] regulator: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is similar chip with BD9571MWV. Note that we don't support voltage rails VD{09,18,25,33} by this driver on BD9574. The VD09 voltage could be read from PMIC but that is not supported by this commit. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vait

RE: [PATCH] serial: sh-sci: remove obsolete latency workaround

Hi Ulrich-san, > From: Ulrich Hecht, Sent: Thursday, April 15, 2021 6:36 PM > > Since the transition to hrtimers there is no more need to set a minimum > RX timeout to work around latency issues. > > Signed-off-by: Ulrich Hecht Thank you for the patch! Reviewed-by: Yoshih

RE: [PATCH v3 02/14] PCI: rcar: Don't allocate extra memory for the MSI capture address

merge the series without it but it would be good if > you can review and test anyway. I reviewed and tested this patch and it worked correctly. So, Reviewed-by: Yoshihiro Shimoda Tested-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 2/3] mfd: bd9571mwv: Make the driver more generic

Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:26 PM > > Hi Shimoda-san, > > On Tue, Dec 8, 2020 at 9:06 AM Yoshihiro Shimoda > wrote: > > index 80c6ef0..57bdb6a 100644 > > --- a/drivers/mfd/bd9

RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

- a/include/linux/mfd/bd9571mwv.h > > +++ b/include/linux/mfd/bd9571mwv.h > > > +#define BD9574MWF_VDCORE_VINIT 0x50 > > +#define BD9574MWF_VD09_VINIT 0x51 > > +#define BD9574MWF_VDCORE_SETVMAX 0x52 > > +#define BD9574MWF_VDCORE_SETVID0x54 > > +#define BD9574MWF_VDCORE_MONIVDAC 0x55 > > +#define BD9574MWF_VDCORE_PGD_CNT 0x56 > > Some of the above are the same as the corresponding BD9571MWV > registers, so using the same define may simplify regulator support > (cfr. BD9571MWV_DVFS_SETVID and BD9571MWV_DVFS_MONIVDAC). Indeed. I'll fix it. > > +#define BD9574MWF_PART_NUMBER "BD9574MWF" > > BD9574MWF_PART_NAME? Yes, I'll rename it. Best regards, Yoshihiro Shimoda

RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

Hi Geert-san, Matti, Thank you for your comments! > From: Geert Uytterhoeven, Sent: Thursday, December 10, 2020 5:20 PM > > Hi Matti, Shimoda-san, > > On Thu, Dec 10, 2020 at 8:33 AM Vaittinen, Matti > wrote: > > On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wr

RE: [PATCH 2/3] mfd: bd9571mwv: Make the driver more generic

break; > > } > > } > > Given we probably won't have more than a handful variants, I'm > leaning towards the switch() approach. OK. I got it. I'll use switch(). Best regards, Yoshihiro Shimoda

RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

Hi Matti, > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM > > On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote: > > From: Khiem Nguyen > > > > The new PMIC BD9574MWF inherits features from BD9571MWV. > > Add the support of new

RE: [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic

Hi Lee, Thank you for your review! > From: Lee Jones, Sent: Thursday, December 17, 2020 12:35 AM > > On Wed, 16 Dec 2020, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen > > > > Since the driver supports BD9571MWV PMIC only, > > this patch makes the func

RE: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF

Hi Lee, Thank you for your review! > From: Lee Jones, Sent: Thursday, December 17, 2020 12:38 AM > > On Wed, 16 Dec 2020, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen > > > > The new PMIC BD9574MWF inherits features from BD9571MWV. > > Add the suppo

[PATCH v4 00/12] treewide: bd9571mwv: Add support for BD9574MWF

MWF. - Add BD9574MWF support for gpio and regulator drivers. - Add missing regmap ranges for BD9574MWF. - Rename "part_number" with "part_name". https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059 Khiem Nguyen (2): mfd: bd9571mwv: Make the driver more ge

[PATCH v4 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices()

To remove mfd devices when unload this driver, should use devm_mfd_add_devices() instead. Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones --- drivers/mfd/bd9571mwv.c | 6 +++--- 1 file changed, 3 insert

[PATCH v4 04/12] regulator: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/regulator/bd9571mwv-regulator.c | 49 + 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a

[PATCH v4 06/12] gpio: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-bd9571mwv.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio

[PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

Use dev_regmap_add_irq_chip() to simplify the code. Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones --- drivers/mfd/bd9571mwv.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c index

[PATCH v4 07/12] gpio: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-bd9571mwv.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH v4 09/12] mfd: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Acked-for-MFD-by: Lee Jones --- drivers/mfd/bd9571mwv.c | 10 +- include/linux/mfd/bd9571mwv.h | 10 +- 2 files changed, 2 insertions(+), 18

[PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen Co-developed-by: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 83

[PATCH v4 08/12] gpio: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is silimar chip with BD9571MWV. Note that BD9574MWF has additional features "RECOV_GPOUT", "FREQSEL" and "RTC_IN", but supports GPIO function only. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-

[PATCH v4 03/12] mfd: rohm-generic: Add BD9571 and BD9574

Add chip IDs for BD9571MWV and BD9574MWF. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen Acked-for-MFD-by: Lee Jones --- include/linux/mfd/rohm-generic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h

[PATCH v4 05/12] regulator: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is silimar chip with BD9571MWV. Note that we don't support voltage rails VD{09,18,25,33} by this driver on BD9574. The VD09 voltage could be read from PMIC but that is not supported by this commit. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vait

[PATCH v4 11/12] mfd: bd9571mwv: Make the driver more generic

: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 89 +-- include/linux/mfd/bd9571mwv.h | 18 + 2 files changed, 54 insertions(+), 53 deletions(-) diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c

[PATCH v4 02/12] dt-bindings: mfd: bd9571mwv: Document BD9574MWF

Document other similar specification chip BD9574MWF. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree

RE: [PATCH] usb: renesas_usbhs: fix error return code of usbhsf_pkt_handler()

} if (likely(func)) /// [1] ret = func(pkt, &is_done); [1] This is always true here, so ret is always assigned by the func(). --- > To fix this bug, ret is assigned with -EINVAL in this case. Just a record: After fixed this, actual behavior is almost the same except printing error message. Best regards, Yoshihiro Shimoda

RE: [PATCH] usb: renesas_usbhs: fix error return code of usbhsf_pkt_handler()

Hi Jia-Ju, > From: Jia-Ju Bai, Sent: Tuesday, March 9, 2021 10:39 PM > On 2021/3/9 19:59, Yoshihiro Shimoda wrote: > > Hi Jia-Ju, > > > > Thank you for the patch! > > > >> From: Jia-Ju Bai, Sent: Sunday, March 7, 2021 6:01 PM > >> > >> Whe

RE: [PATCH] usb: renesas_usbhs: fix error return code of usbhsf_pkt_handler()

> From: Jia-Ju Bai, On 2021/3/10 10:54, Yoshihiro Shimoda wrote: > >> From: Jia-Ju Bai, Sent: Tuesday, March 9, 2021 10:39 PM > >> On 2021/3/9 19:59, Yoshihiro Shimoda wrote: > >>>> From: Jia-Ju Bai, Sent: Sunday, March 7, 2021 6:01 PM > >>>> >

RE: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

(hcd); > > >>> + if (ret) > > >>> + goto disable_usb_phy; > > >>> + } > > >>> + > > >>> + if ((xhci->quirks & XHCI_SKIP_PHY_INIT) || (priv && > > >&

RE: [PATCH v2 03/10] regulator: bd9571mwv: rid of using struct bd9571mwv

Hi Geert-san, Matti-san, > From: Geert Uytterhoeven, Sent: Wednesday, December 16, 2020 1:13 AM > On Tue, Dec 15, 2020 at 5:02 PM Geert Uytterhoeven > wrote: > > On Fri, Dec 11, 2020 at 3:03 PM Vaittinen, Matti > > wrote: > > > On Fri, 2020-12-11 at 20:27

RE: [PATCH v2 03/10] regulator: bd9571mwv: rid of using struct bd9571mwv

Hi Matti-san, > From: Vaittinen, Matti, Sent: Wednesday, December 16, 2020 3:00 PM > On Wed, 2020-12-16 at 02:13 +, Yoshihiro Shimoda wrote: > > Hi Geert-san, Matti-san, > > > > > From: Geert Uytterhoeven, Sent: Wednesday, December 16, 2020 1:13 > > > AM &

[PATCH v3 00/12] treewide: bd9571mwv: Add support for BD9574MWF

soc/list/?series=398059 Khiem Nguyen (2): mfd: bd9571mwv: Make the driver more generic mfd: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda (10): mfd: bd9571mwv: Use devm_mfd_add_devices() dt-bindings: mfd: bd9571mwv: Document BD9574MWF mfd: rohm-generic: Add BD9571 and BD9574

[PATCH v3 03/12] mfd: rohm-generic: Add BD9571 and BD9574

Add chip IDs for BD9571MWV and BD9574MWF. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- include/linux/mfd/rohm-generic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h index 4283b5b..affacf8 100644

[PATCH v3 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices()

To remove mfd devices when unload this driver, should use devm_mfd_add_devices() instead. Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

[PATCH v3 06/12] gpio: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-bd9571mwv.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio

[PATCH v3 05/12] regulator: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is silimar chip with BD9571MWV. Note that we don't support voltage rails VD{09,18,25,33} by this driver on BD9574. The VD09 voltage could be read from PMIC but that is not supported by this commit. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vait

[PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic

From: Khiem Nguyen Since the driver supports BD9571MWV PMIC only, this patch makes the functions and data structure become more generic so that it can support other PMIC variants as well. Signed-off-by: Khiem Nguyen [shimoda: rebase and refactor] Signed-off-by: Yoshihiro Shimoda --- drivers

[PATCH v3 07/12] gpio: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-bd9571mwv.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH v3 09/12] mfd: bd9571mwv: Use the SPDX license identifier

Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven --- drivers/mfd/bd9571mwv.c | 10 +- include/linux/mfd/bd9571mwv.h | 10 +- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a

[PATCH v3 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

Use dev_regmap_add_irq_chip() to simplify the code. Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c index e68c3fa..49e968e 100644 --- a

[PATCH v3 04/12] regulator: bd9571mwv: rid of using struct bd9571mwv

To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/regulator/bd9571mwv-regulator.c | 49 + 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a

[PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF

From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen [shimoda: rebase and refactor] Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 86

[PATCH v3 02/12] dt-bindings: mfd: bd9571mwv: Document BD9574MWF

Document other similar specification chip BD9574MWF. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree

[PATCH v3 08/12] gpio: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is silimar chip with BD9571MWV. Note that BD9574MWF has additional features "RECOV_GPOUT", "FREQSEL" and "RTC_IN", but supports GPIO function only. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-

RE: [PATCH v2 04/10] regulator: bd9571mwv: Add BD9574MWF support

Hello Matti-san, > From: Vaittinen, Matti, Sent: Friday, December 11, 2020 9:34 PM > > Hello again Shimada-san, > > On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > > Add support for BD9574MWF which is silimar chip with BD9571MWV. > > Note that BD9574MWF

RE: [PATCH v2 07/10] gpio: bd9571mwv: Add BD9574MWF support

Hi Matti-san, Thank you for your review! > From: Vaittinen, Matti, Sent: Friday, December 11, 2020 9:55 PM > > On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > > Add support for BD9574MWF which is silimar chip with BD9571MWV. > > Note that BD9574MWF has an ad

RE: [PATCH v2 09/10] mfd: bd9571mwv: Make the driver more generic

Hi Matti-san, Thank you for your review! > From: Vaittinen, Matti, Sent: Friday, December 11, 2020 10:29 PM > > Hi Yoshihiro-san, > > On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > > From: Khiem Nguyen > > > > Since the driver supports BD9571MW

RE: [PATCH v2 04/10] regulator: bd9571mwv: Add BD9574MWF support

Hello Matti-san, > From: Vaittinen, Matti, Sent: Monday, December 14, 2020 4:13 PM > > Hello Shimoda-san, > > On Mon, 2020-12-14 at 04:57 +0000, Yoshihiro Shimoda wrote: > > Hello Matti-san, > > > > > From: Vaittinen, Matti, Sent: Friday, December 11,

RE: [PATCH v2 08/10] mfd: bd9571mwv: Use the SPDX license identifier

> From: Yoshihiro Shimoda, Sent: Friday, December 11, 2020 8:28 PM > > Use the SPDX license identifier instead of a local description. > > Signed-off-by: Yoshihiro Shimoda I forgot to add Geert-san's Reviewed-by here. So, I'll submit v3 patch series later. htt

Re: [PATCH v2 1/4] xhci: Introduce xhci_init_driver()

c_drver.start = xhci_plat_start; Thank you for the care of xhci-rcar driver. However, this "xhci_plat_hc_drver" should be "xhci_plat_hc_driver". After I modified it by myself, I could build the xhci-plat-hcd.ko in my environment. Best regards, Yoshihiro Shimoda -- T

Re: [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA

nds on USB_RENESAS_USBHS && HAS_DMA > help > Renesas USBHS is a discrete USB host and peripheral controller chip > that supports both full and high speed USB 2.0 data transfers. > Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

Re: [PATCH v2] usb: renesas_usbhs: fix driver dependencies

ARM SoCs and SuperH architecture. >>> >>> Signed-off-by: Bartlomiej Zolnierkiewicz >>> Acked-by: Kyungmin Park >>> Cc: Simon Horman >>> Cc: Magnus Damm >>> --- >>> v2: >>> - s/ARCH_SH/SUPERH/ (thanks to Sergei Shtylyov) >

RE: [PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

Hi Geert-san, > Sent: Monday, August 24, 2015 9:13 PM > > Hi Shimoda-san, > > On Thu, Aug 20, 2015 at 8:28 AM, Yoshihiro Shimoda > wrote: > > This patch adds support for R-Car generation 3 USB2 PHY driver. > > This SoC has 3 EHCI/OHCI channels, and the channel

[PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

. 2) detects id pin to select host or peripheral on the channel 0. For now, this driver only supports 1) above. Signed-off-by: Yoshihiro Shimoda --- This patch is based on the latest linux-phy / next branch. (commit id = cfd093bbb5fe84ec8c7bb069fe618159a8b601f5) Changes from v1: - Revise

[PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

. 2) detects id pin to select host or peripheral on the channel 0. For now, this driver only supports 1) above. Signed-off-by: Yoshihiro Shimoda --- .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 37 +++ drivers/phy/Kconfig| 6 + drivers/phy/Makefile

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

Hi, > From: Roger Quadros > Sent: Monday, April 11, 2016 7:55 PM > > On 08/04/16 14:22, Yoshihiro Shimoda wrote: > > Hi, > > > >> From: Roger Quadros > >> Sent: Thursday, April 07, 2016 8:45 PM > >> > >> Hi, > >> > >>

RE: [PATCH] usb: renesas_usbhs: fix signed-unsigned return

p_pipecfg() prototype is changed like the following? static int usbhsp_setup_pipecfg(struct usbhs_pipe *pipe, int is_host, int dir_in, u16 *pipecfg); Best regards, Yoshihiro Shimoda > Signed-off-by: Sudip Mukherjee > --- > drivers

<    1   2   3   4   5   >