peripheral controller (HS-USB).
The OTG function is related to some PHY control registers, so I intend to add
the OTG/Dual-role core
support into the phy driver (drivers/phy/phy-rcar-gen3-usb2.c).
Best regards,
Yoshihiro Shimoda
up: -110
> > [ 32.340179] xhci_hcd :45:00.0: USB bus 2 deregistered
> > [ 32.345587] xhci_hcd :45:00.0: init :45:00.0 fail, -110
> > [ 32.351496] xhci_hcd: probe of :45:00.0 failed with error -110
> >
> > Cc: Yoshihiro Shimoda
> > Signed-off
Hi Yamada-san,
> From: Masahiro Yamada
> Sent: Monday, September 19, 2016 1:03 AM
>
> The combo of list_empty() check and return list_first_entry()
> can be replaced with list_first_entry_or_null().
>
> Signed-off-by: Masahiro Yamada
Thank you for the patch!
Acked-
This driver can support for r8a7796 SoC. So, this patch adds it.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++
drivers/phy/phy-rcar-gen3-usb2.c | 1 +
2 files changed, 3 insertions(+)
diff --git a
This patch set is based on the latest linux-phy.git / next branch.
(commit id = d9a6e11e10d657df9af1d321c0eccdead184f72a)
Yoshihiro Shimoda (2):
phy: rcar-gen3-usb2: revise the example of device tree doc
phy: rcar-gen3-usb2: Add a compatible string for r8a7796
Documentation/devicetree
The clocks property should be set to &cpg, not &mstpX_clks.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb
The USB 3.0 PHY modules of R-Car Gen3 SoCs have:
- Spread spectrum clock (ssc).
- Using USB 2.0 EXTAL clock instead of USB 3.0 clock.
- Enabling VBUS detection for usb3.0 peripheral.
So, this driver supports these features.
Signed-off-by: Yoshihiro Shimoda
---
This patch is based on the
rcar-gen3-usb2.c:(.text+0x250): undefined reference to
> `of_usb_get_dr_mode_by_phy'
>
> Other phy drivers select USB_COMMON for this, so let's do the same
> here.
>
> Fixes: 7e0540f41332 ("phy: rcar-gen3-usb2: check dr_mode for otg mode")
> Signed-off-by:
gt; Signed-off-by: Colin Ian King
Thank you for the patch!
Acked-by: Yoshihiro Shimoda
Best regards,
Yoshihiro Shimoda
: Yoshihiro Shimoda
---
drivers/phy/phy-rcar-gen3-usb2.c | 126 ++-
1 file changed, 124 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c
index d90dfcf..03d7079 100644
--- a/drivers/phy/phy-rcar-gen3
Hi,
I sent v4 patch set today. So, please ignore this version.
Best regards,
Yoshihiro Shimoda
> Sent: Thursday, October 01, 2015 7:11 PM
>
> This patch adds support for R-Car generation 3 USB2 PHY driver.
> This SoC has 3 EHCI/OHCI channels, and the channel 0 is shared
>
This patch adds support for runtime ID/VBUS pin detection if
the channel 0 of R-Car gen3 is used. So, we are able to use
the channel as both host and peripheral.
Signed-off-by: Yoshihiro Shimoda
---
.../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 +
drivers/phy/phy-rcar-gen3-usb2.c
SoC specific to use the
{ehci,ohci}-platform driver.
2) detects id pin to select host or peripheral on the channel 0.
For now, this driver only supports 1) above.
Signed-off-by: Yoshihiro Shimoda
---
.../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 37
drivers/phy/Kconfig
ove an unnecessary header file (asm/cmpxchg.h).
Yoshihiro Shimoda (3):
phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver
phy: rcar-gen3-usb2: change the mode to OTG on the combined channel
phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection
.../devicetree/bindings/phy/rcar-ge
Hi Geert-san,
> Sent: Tuesday, October 20, 2015 9:22 PM
>
> Hi Shimoda-san,
>
> On Tue, Oct 20, 2015 at 2:18 PM, Yoshihiro Shimoda
> wrote:
> > This patch fixes an issue that the "length" of scatterlist should be
> > set using sh_dma_length(). O
This patch fixes an issue that the "length" of scatterlist should be
set using sg_dma_len(). Otherwise, a dmaengine driver cannot work
correctly if CONFIG_NEED_SG_DMA_LENGTH=y.
Fixes: 7b39d90184 (serial: sh-sci: Fix NULL pointer dereference if HIGHMEM is
enabled)
Signed-off-by: Yoshihi
Hi,
> Sent: Saturday, October 17, 2015 10:44 AM
>
> Hi,
>
> On Tuesday 13 October 2015 03:52 PM, Yoshihiro Shimoda wrote:
< snip >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index 7eb5859d..45c6131 100644
> > --- a/drivers/ph
Hi,
> Sent: Saturday, October 17, 2015 10:48 AM
>
> Hi,
>
> On Tuesday 13 October 2015 03:52 PM, Yoshihiro Shimoda wrote:
> > To use the channel 0 of R-Car gen3 as periperal mode, This patch changes
> > the mode to OTG instead of HOST. Then, this driver needs to set s
Hi,
> Sent: Saturday, October 17, 2015 10:54 AM
>
> Hi,
>
> On Tuesday 13 October 2015 03:52 PM, Yoshihiro Shimoda wrote:
> > This patch adds support for runtime ID/VBUS pin detection if
> > the channel 0 of R-Car gen3 is used. So, we are able to use
> > the ch
/disable the clocks.
(In other words, this driver expects to enable/disable the clocks by
Runtime PM API by the phy-core driver.)
- Remove an unnecessary header file (asm/cmpxchg.h).
Yoshihiro Shimoda (4):
phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver
phy: rcar-gen3-usb2: change the
SoC specific to use the
{ehci,ohci}-platform driver.
2) detects id pin to select host or peripheral on the channel 0.
For now, this driver only supports 1) above.
Signed-off-by: Yoshihiro Shimoda
---
.../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 37
drivers/phy/Kconfig
This patch adds support for runtime ID/VBUS pin detection if
the channel 0 of R-Car gen3 is used. So, we are able to use
the channel as both host and peripheral.
Signed-off-by: Yoshihiro Shimoda
---
.../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 +
drivers/phy/phy-rcar-gen3-usb2.c
: Yoshihiro Shimoda
---
drivers/phy/phy-rcar-gen3-usb2.c | 124 ++-
1 file changed, 122 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c
index 9d9cf26..cf91f9f 100644
--- a/drivers/phy/phy-rcar-gen3
Add Renesas usb2 phy driver to maintainer entry.
Signed-off-by: Yoshihiro Shimoda
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index be0055c..ecff678 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8742,6 +8742,12 @@ F: drivers/rpmsg
This patch fixes an issue that the "length" of scatterlist should be
set using sh_dma_length(). Otherwise, a dmaengine driver cannot work
correctly if CONFIG_NEED_SG_DMA_LENGTH=y.
Fixes: 7b39d90184 (serial: sh-sci: Fix NULL pointer dereference if HIGHMEM is
enabled)
Signed-off-by:
w again:
- This "usb2" means the partial registers of USB 2.0 host block.
That host registers can control the USB2.0 PHY.
This "hsusb" means the partial registers of USB 2.0 peripheral block.
That peripheral registers can control the selector (host or peripher
SoC specific to use the
{ehci,ohci}-platform driver.
2) detects id pin to select host or peripheral on the channel 0.
For now, this driver only supports 1) above.
Signed-off-by: Yoshihiro Shimoda
---
This patch is based on the latest linux-phy / next branch.
(commit id
y simply rebasing and
> adding the right SoB?
I'm very sorry for this trouble.
When I ported this patch, I dropped the author's Signed-of-by wrongly..
Signed-off-by: Takeshi Kihara
Best regards,
Yoshihiro Shimoda
> Yours,
> Linus Walleij
>
> On Mon, Jul 9, 20
Hi Arnd,
Thank you for the patch!
> From: Arnd Bergmann, Sent: Tuesday, December 11, 2018 7:06 PM
> To: Greg Kroah-Hartman
> Cc: Arnd Bergmann ; Yoshihiro Shimoda
> ; Felipe Balbi
> ; Simon Horman ;
> Chris Brandt ;
> linux-...@vger.kernel.org; linux-kernel@vger.kernel.
.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=eaf3074e0a8c2a39c4c14aa8ef1c2ec09ace9c79
Best regards,
Yoshihiro Shimoda
Hi,
> From: Sasha Levin , Sent: Thursday, December 13, 2018 1:28
> PM
>
> From: Yoshihiro Shimoda
>
> [ Upstream commit 8c85f4b81296a530b8af2796c110fa482ac42d4f ]
Since this upstream commit are reverted by the following commit,
we should not backpo
Hi,
> From: Sasha Levin, Sent: Thursday, December 13, 2018 1:28 PM
>
> From: Yoshihiro Shimoda
>
> [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ]
This upstream commit is also reverted on mainline
as I mentioned other email thread[1]
[1]
https://lore.
Hi,
> From: Sasha Levin, Sent: Thursday, December 13, 2018 1:31 PM
>
> From: Yoshihiro Shimoda
>
> [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ]
This upstream commit is also reverted on mainline
as I mentioned other email thread [1]. So, we should not backport
Hi,
> From: Sasha Levin, Sent: Thursday, December 13, 2018 1:32 PM
>
> From: Yoshihiro Shimoda
>
> [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ]
This upstream commit is reverted on mainline as I mentioned other email thread
[1].
So, we should not backport
Hi Fabrizio,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
>
> Document RZ/G2E (R8A774C0) SoC bindings.
>
> Signed-off-by: Fabrizio Castro
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda
By the way, I'm not sure, but I'm wondering that w
Hi Fabrizio,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM
>
> Document RZ/G2E (R8A774C0) SoC bindings.
>
> Signed-off-by: Fabrizio Castro
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda
Best regards,
Yoshihiro Shimoda
> ---
> Documentatio
Hi Fabrizio,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:22 AM
>
> Document RZ/G2E (R8A774C0) SoC bindings.
>
> Signed-off-by: Fabrizio Castro
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda
Best regards,
Yoshihiro Shimoda
> ---
> Documentatio
Hi Fabrizio,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:24 AM
>
> RZ/G2E USB 3.0 implementation is like the one found on R-Car E3,
> therefore add the same quirk.
>
> Signed-off-by: Fabrizio Castro
Thank you for the patch!
Reviewed-by: Yoshihiro Shim
add
> r8a774c0 support in a similar fashion to what was done for the
> r8a77990.
>
> Signed-off-by: Fabrizio Castro
Thank you for the patch!
Acked-by: Yoshihiro Shimoda
Best regards,
Yoshihiro Shimoda
> ---
> drivers/usb/renesas_usbhs/common.c | 4
> 1 file change
Hello Fabrizio-san,
> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:16 PM
>
> Hello Yoshihiro-san,
>
> Thank you for your feedback!
>
> > From: Yoshihiro Shimoda
> > Sent: 14 December 2018 06:01
> > Subject: RE: [PATCH] dt-bindings: usb:
/dts/toshiba/tmpv7708-rm-mbrc.dtb' failed
make[2]: *** [arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dtb] Error 1
scripts/Makefile.build:530: recipe for target 'arch/arm64/boot/dts/toshiba'
failed
Best regards,
Yoshihiro Shimoda
Hi Stephen,
> From: Stephen Rothwell, Sent: Wednesday, February 17, 2021 6:18 AM
> On Tue, 16 Feb 2021 11:53:56 + Yoshihiro Shimoda
> wrote:
> >
> > > From: Stephen Rothwell, Sent: Tuesday, February 16, 2021 11:05 AM
> >
> > > diff --cc arch/arm6
According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK
bit location is bit 8, not bits 1 and 0. It also says that the register
address offset of UGSTS is 0x88, not 0x90.
So, this patch fixes the USBHS_UGSTS_LOCK value and some comments.
Signed-off-by: Yoshihiro Shimoda
CI controllers [1] also seem unclear why this quirk needs.
So,
Acked-by: Yoshihiro Shimoda
Best regards,
Yoshihiro Shimoda
[1]
---
commit da99706689481717998d1d48edd389f339eea979
Author: Daniel Thompson
Date: Thu Dec 21 15:06:15 2017 +0200
usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas u
I'm sorry, but what is "dynamically allocated device nodes"?
Best regards,
Yoshihiro Shimoda
> If so, it looks like the following code could cause a
> use-after-free, due to not incrementing th reference count:
>
> for_each_child_of_node(dev->of_node, np) {
>
Hello,
> From: Julia Lawall, Sent: Tuesday, February 26, 2019 6:01 PM
>
> On Tue, 26 Feb 2019, Yoshihiro Shimoda wrote:
>
> > Hello,
> > (Sergei made this code, so I added his email as CC)
> >
> > I'm sorry for the delayed response.
> >
> > &
This patch fixes memory leak at error paths of the probe function.
In for_each_child_of_node, if the loop returns, the driver should
call of_put_node() before returns.
Reported-by: Julia Lawall
Fixes: 1233f59f745 ("phy: Renesas R-Car Gen2 PHY driver")
Signed-off-by: Yoshihi
Hello,
> From: Julia Lawall, Sent: Wednesday, February 27, 2019 5:25 PM
>
> On Wed, 27 Feb 2019, Yoshihiro Shimoda wrote:
>
> > This patch fixes memory leak at error paths of the probe function.
> > In for_each_child_of_node, if the loop returns, the driver should
>
Andrew Jeffery
> Cc: Joel Stanley
> Cc: Wim Van Sebroeck
> Cc: Guenter Roeck
> Cc: Yoshihiro Shimoda
> Cc: Vincent Cheng
> Cc: linux-...@vger.kernel.org
> Cc: linux-cry...@vger.kernel.org
> Cc: linux-g...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Cc: io...
> From: Pali Rohár, Sent: Tuesday, February 2, 2021 12:12 AM
> On Tuesday 26 January 2021 10:06:06 Pali Rohár wrote:
> > On Tuesday 26 January 2021 04:27:37 Yoshihiro Shimoda wrote:
> > > Hi Pali,
> > > > > I can see the benefit in this.
> > >
masz Maciej Nowak
> Fixes: bd3d25b07342 ("arm64: dts: marvell: armada-37xx: link USB hosts with
> their PHYs")
> Cc: # 5.1+: ea17a0f153af: phy: marvell: comphy:
> Convert internal SMCC firmware return codes to
> errno
> Cc: # 5.1+: f768e718911e: usb: host: xhci-plat
required property
>
> Based on the dts files, a 'power-domains' property only exists on Gen 3
> which can be conditioned on !renesas,ipmmu-vmsa.
>
> Cc: Joerg Roedel
> Cc: Will Deacon
> Cc: Yoshihiro Shimoda
> Cc: io...@lists.linux-foundation.org
> S
this as
> > well. Thanks for the pointer!
>
> I also can confirm that changing that to unsigned long fixes the issue.
Thank you for the information! I also confirmed that changing the type of
max_slots fixed the issue on my environment (r8a77951-salvator-xs.dts with
defconfig).
Best regards,
Yoshihiro Shimoda
highlight=fallthrough#implicit-switch-case-fall-through
>
> Reviewed-by: Geert Uytterhoeven
> Signed-off-by: Gustavo A. R. Silva
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda
Best regards,
Yoshihiro Shimoda
but supports GPIO function only.
> >
> > Signed-off-by: Yoshihiro Shimoda
> > Reviewed-by: Matti Vaittinen
>
> Acked-by: Linus Walleij
Thank you for your Acked-by! I'll add your Acked-by in the next patch version
as v9.
> This looks like it compile-time depends on the other patches right?
You're correct.
Best regards,
Yoshihiro Shimoda
Document other similar specification chip BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
---
Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-by: Linus Walleij
Acked-by: Bartosz Golaszewski
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-by: Mark Brown
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23
: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 77 +++
include/linux/mfd/bd9571mwv.h | 18 ++
2 files changed, 43 insertions(+), 52 deletions(-)
diff
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
Co-developed-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
Use devm_regmap_add_irq_chip() to simplify the code.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Matti Vaittinen
Reviewed-by: Geert Uytterhoeven
---
drivers/mfd/bd9571mwv.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff
Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that BD9574MWF has additional features "RECOV_GPOUT",
"FREQSEL" and "RTC_IN", but supports GPIO function only.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-by: Li
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Linus Walleij
Acked-by: Bartosz Golaszewski
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18
Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vait
To remove mfd devices when unload this driver, should use
devm_mfd_add_devices() instead.
Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Matti Vaittinen
--
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
kernel.org/project/linux-renesas-soc/list/?series=398059
Khiem Nguyen (2):
mfd: bd9571mwv: Make the driver more generic
mfd: bd9571mwv: Add support for BD9574MWF
Yoshihiro Shimoda (10):
mfd: bd9571mwv: Use devm_mfd_add_devices()
dt-bindings: mfd: bd9571mwv: Document BD9574MWF
mfd: rohm-ge
Hi Matti-san,
> From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 8:56 PM
>
> Hi Yoshihiro san,
>
> On Thu, 2020-12-10 at 10:58 +0000, Yoshihiro Shimoda wrote:
> > Hi Matti,
> >
> > > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
index 4283b5b..affacf8 100644
--- a/include/linux/mfd/rohm
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio
Document other similar specification chip BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
b/Documentation/devicetree
umber" with "part_name".
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059
Khiem Nguyen (2):
mfd: bd9571mwv: Make the driver more generic
mfd: bd9571mwv: Add support for BD9574MWF
Yoshihiro Shimoda (8):
dt-bindings: mfd: bd9571mwv: Document BD9574MWF
mf
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio-bd9571mwv.c
index c0abc9c..abb622c
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that BD9574MWF has an additional feature, but doesn't
support it for now.
Signed-off-by: Yoshihiro Shimoda
---
drivers/gpio/gpio-bd9571mwv.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/dr
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git a/drivers/regulator/bd9571mwv
From: Khiem Nguyen
Since the driver supports BD9571MWV PMIC only,
this patch makes the functions and data structure become more generic
so that it can support other PMIC variants as well.
Signed-off-by: Khiem Nguyen
[shimoda: rebase and refactor]
Signed-off-by: Yoshihiro Shimoda
---
drivers
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
[shimoda: rebase and refactor]
Signed-off-by: Yoshihiro Shimoda
---
drivers/mfd/bd9571mwv.c | 86
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that BD9574MWF doesn't support AVS and VID.
Signed-off-by: Yoshihiro Shimoda
---
drivers/regulator/bd9571mwv-regulator.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/regu
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c b/drivers
Hi again,
> From: Yoshihiro Shimoda, Sent: Friday, December 11, 2020 9:49 AM
>
> > but as I said - these are only 'nit' comments and I am not insisting on
> > changing these. Especially since some of the comments are more related
> > to changing the original
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM
> On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda
> wrote:
> > --- a/drivers/mfd/bd9571mwv.c
> > +++ b/drivers/mfd/bd9571mwv.c
>
> > @@ -200,12 +277,14
Hi Matti-san,
> From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM
>
> On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote:
> > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda
> > wrote:
> > > Use dev_regmap_add_irq_chip() to simplify the c
ble[]?
> You still need the "bd9574mwf-gpio" entry, don't you?
You're correct. The MFD driver uses "bd9574mwf-gpio". And,
"bd9574mwf-gpio" with 0 is not good. So, I'll keep this patch.
Thank you for the point it out.
Best regards,
Yoshihiro Shimoda
least this MFD driver uses "bd9574mwf-gpio"
for probing. So, I'll keep that patch as-is.
Best regards,
Yoshihiro Shimoda
Hi Matti-san,
> From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:39 PM
>
> On Tue, 2020-12-22 at 09:25 +, Yoshihiro Shimoda wrote:
> > Hi Matti-san,
> >
> > > From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM
> > >
> &g
Document other similar specification chip BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
b/Documentation/devicetree
To remove mfd devices when unload this driver, should use
devm_mfd_add_devices() instead.
Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Matti Vaittinen
--
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18
: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/mfd/bd9571mwv.c | 89 +--
include/linux/mfd/bd9571mwv.h | 18 +
2 files changed, 54 insertions(+), 53 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that BD9574MWF has additional features "RECOV_GPOUT",
"FREQSEL" and "RTC_IN", but supports GPIO function only.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
Co-developed-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/mfd/bd9571mwv.c
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vait
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git a
BD9574MWF.
- Rename "part_number" with "part_name".
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059
Khiem Nguyen (2):
mfd: bd9571mwv: Make the driver more generic
mfd: bd9571mwv: Add support for BD9574MWF
Yoshihiro Shimoda (10):
mfd: bd9571mwv: Us
Use dev_regmap_add_irq_chip() to simplify the code.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Matti Vaittinen
Reviewed-by: Geert Uytterhoeven
---
drivers/mfd/bd9571mwv.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff
Hi Sergei,
> From: Sergei Shtylyov, Sent: Wednesday, December 23, 2020 6:15 PM
>
> On 22.12.2020 14:22, Yoshihiro Shimoda wrote:
>
> > Add support for BD9574MWF which is silimar chip with BD9571MWV.
>
> Similar (again)? :-)
Thank you for pointed it out! I'll f
1 - 100 of 437 matches
Mail list logo
