[PATCH 1/7] usb, chipidea: remove redundant D0 power state set

2013-06-02 Thread Yijing Wang
Pci_enable_device() will set device power state to D0, so it's no need to do it again in ci13xxx_pci_probe(). Signed-off-by: Yijing Wang Cc: Alexander Shishkin Cc: linux-...@vger.kernel.org --- drivers/usb/chipidea/ci13xxx_pci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-)

Re: [PATCH] tg3: remove redundant pm init code

2013-06-03 Thread Yijing Wang
On 2013/6/3 15:13, David Miller wrote: > From: Yijing Wang > Date: Wed, 29 May 2013 17:00:32 +0800 > >> Pci_enable_device() will set device pm state to D0, so >> it's no need to do it again in tg3_init_one(). >> >> Signed-off-by: Yijing Wang > > T

[PATCH] tg3: remove redundant pm init code

2013-06-03 Thread Yijing Wang
Pci_enable_device() will set device pm state to D0, so it's no need to do it again in tg3_init_one(). Acked-by: Michael Chan Signed-off-by: Yijing Wang --- drivers/net/ethernet/broadcom/tg3.c | 24 +++- 1 files changed, 3 insertions(+), 21 deletions(-) diff --

Re: [PATCH 3/9] aty128fb: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-25 Thread Yijing Wang
Ping.? On 2013/6/18 16:15, Yijing Wang wrote: > Pci core has been saved pm cap register offset by pdev->pm_cap in > pci_pm_init() > in init path. So we can use pdev->pm_cap instead of using > pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and > simplif

Re: [PATCH 9/9] radeon: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-25 Thread Yijing Wang
Ping? On 2013/6/18 16:24, Yijing Wang wrote: > Pci core has been saved pm cap register offset by pdev->pm_cap in > pci_pm_init() > in init path. So we can use pdev->pm_cap instead of using > pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and > simplif

Re: [PATCH 8/9] scsi/pm8001: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-25 Thread Yijing Wang
Hi, Any comments? On 2013/6/18 16:23, Yijing Wang wrote: > Pci core has been saved pm cap register offset by pdev->pm_cap in > pci_pm_init() > in init path. So we can use pdev->pm_cap instead of using > pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and

[PATCH 8/9] scsi/pm8001: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-25 Thread Yijing Wang
Pci core has been saved pm cap register offset by pdev->pm_cap in pci_pm_init() in init path. So we can use pdev->pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. Signed-off-by: Yijing Wang Cc: xjtu...@gmail.com Cc: l

[PATCH 3/9] aty128fb: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-25 Thread Yijing Wang
Pci core has been saved pm cap register offset by pdev->pm_cap in pci_pm_init() in init path. So we can use pdev->pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. Signed-off-by: Yijing Wang Cc: Paul Mackerras Cc: Jean-Chri

[PATCH 9/9] radeon: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-25 Thread Yijing Wang
Pci core has been saved pm cap register offset by pdev->pm_cap in pci_pm_init() in init path. So we can use pdev->pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. Signed-off-by: Yijing Wang Cc: Benjamin Herrenschmidt Cc

Re: [PATCH 8/9] scsi/pm8001: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-26 Thread Yijing Wang
On 2013/6/26 17:33, Jack Wang wrote: > On 06/18/2013 10:23 AM, Yijing Wang wrote: >> Pci core has been saved pm cap register offset by pdev->pm_cap in >> pci_pm_init() >> in init path. So we can use pdev->pm_cap instead of using >> pci_find_capability(pdev, PCI_

Re: [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros

2013-07-01 Thread Yijing Wang
ping...? On 2013/6/27 20:57, Yijing Wang wrote: > Use standard PM state macros PCI_Dx instead of numeric 0/1/2.. > > Signed-off-by: Yijing Wang > Cc: Forest Bond > Cc: Greg Kroah-Hartman > Cc: Jiri Kosina > Cc: Devendra Naga > Cc :Joe Perches > Cc: Marcos

Re: [PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros

2013-07-01 Thread Yijing Wang
On 2013/7/2 9:23, Greg Kroah-Hartman wrote: > On Tue, Jul 02, 2013 at 09:14:06AM +0800, Yijing Wang wrote: >> ping...? > > You are asking yourself the status of a patch? Interesting... > >> On 2013/6/27 20:57, Yijing Wang wrote: > > You sent this after I closed

Re: [PATCH 5/9] cciss: rework pci pm related code for simplification

2013-07-01 Thread Yijing Wang
Hi Jens, Sorry to disturb you, do you have any comments for this patch? Thanks! Yijing. On 2013/6/18 16:19, Yijing Wang wrote: > Use pci core pm interface to simplify code. > > Signed-off-by: Yijing Wang > Cc: Mike Miller > Cc: iss_storage...@hp.com > Cc: linux-kern

Re: [PATCH 5/9] cciss: rework pci pm related code for simplification

2013-07-02 Thread Yijing Wang
On 2013/7/2 16:02, Jens Axboe wrote: > On Tue, Jul 02 2013, Yijing Wang wrote: >> Hi Jens, >>Sorry to disturb you, do you have any comments for this patch? > > Looks fine to me, was waiting for Stephen/Mike to ack it and I'll pick > it up. > Hi Jens, Than

Re: [PATCH 5/9] cciss: rework pci pm related code for simplification

2013-07-02 Thread Yijing Wang
Cc: Stephen M. Cameron On 2013/7/2 16:02, Jens Axboe wrote: > On Tue, Jul 02 2013, Yijing Wang wrote: >> Hi Jens, >>Sorry to disturb you, do you have any comments for this patch? > > Looks fine to me, was waiting for Stephen/Mike to ack it and I'll pick > it

Re: [PATCH 9/9] radeon: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-26 Thread Yijing Wang
On 2013/6/26 21:15, Tomi Valkeinen wrote: > On 26/06/13 04:13, Yijing Wang wrote: >> Pci core has been saved pm cap register offset by pdev->pm_cap in >> pci_pm_init() >> in init path. So we can use pdev->pm_cap instead of using >> pci_find_capability(pdev, PCI_

Re: [PATCH 9/9] radeon: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-26 Thread Yijing Wang
On 2013/6/27 14:34, Tomi Valkeinen wrote: > On 27/06/13 04:51, Yijing Wang wrote: >> On 2013/6/26 21:15, Tomi Valkeinen wrote: > >>> I couldn't find the rest of this series, and I'm not familiar with PCI. >>> So: is this patch and "aty128fb: use pd

[Resend with Ack][PATCH 8/9] scsi/pm8001: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-27 Thread Yijing Wang
Pci core has been saved pm cap register offset by pdev->pm_cap in pci_pm_init() in init path. So we can use pdev->pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. Acked-by: Lindar Liu Tested-by: Lindar Liu Signed-off-by: Yijin

[PATCH 1/6] char/agp: replace numeric with standard PM state macros

2013-06-27 Thread Yijing Wang
Use standard PM state macros PCI_Dx instead of numeric 0/1/2.. Signed-off-by: Yijing Wang --- drivers/char/agp/ati-agp.c|4 ++-- drivers/char/agp/nvidia-agp.c |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/char/agp/ati-agp.c b/drivers/char/agp/ati

[PATCH 2/6] net/trivial: replace numeric with standard PM state macros

2013-06-27 Thread Yijing Wang
Use standard PM state macros PCI_Dx instead of numeric 0/1/2.. Signed-off-by: Yijing Wang Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ethernet/8390/ne2k-pci.c |2 +- drivers/net/ethernet/emulex/benet/be_main.c |4 ++-- drivers/net

[PATCH 3/6] sound/pci:trivial: replace numeric with standard PM state macros

2013-06-27 Thread Yijing Wang
Use standard PM state macros PCI_Dx instead of numeric 0/1/2.. Signed-off-by: Yijing Wang Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Jiri Kosina Cc: Bill Pemberton Cc: alsa-de...@alsa-project.org Cc: linux-kernel@vger.kernel.org --- sound/pci/cs4281.c |2 +- sound/pci/ens1370

[PATCH 4/6] vt6655/trivial: replace numeric with standard PM state macros

2013-06-27 Thread Yijing Wang
Use standard PM state macros PCI_Dx instead of numeric 0/1/2.. Signed-off-by: Yijing Wang Cc: Forest Bond Cc: Greg Kroah-Hartman Cc: Jiri Kosina Cc: Devendra Naga Cc :Joe Perches Cc: Marcos Paulo de Souza Cc: Bill Pemberton Cc: de...@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org

[PATCH 6/6] ssb/trivial: replace numeric with standard PM state macros

2013-06-27 Thread Yijing Wang
Use standard PM state macros PCI_Dx instead of numeric 0/1/2.. Signed-off-by: Yijing Wang Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ssb/pcihost_wrapper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ssb/pcihost_wrapper.c b

[PATCH 5/6] Gpio/trivial: replace numeric with standard PM state macros

2013-06-27 Thread Yijing Wang
Use standard PM state macros PCI_Dx instead of numeric 0/1/2.. Signed-off-by: Yijing Wang Cc: Michael Buesch Cc: Grant Likely Cc: Linus Walleij Cc: Jiri Kosina Cc: linux-kernel@vger.kernel.org --- drivers/gpio/gpio-bt8xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 3.4 stable][PATCH] pch_uart: fix a deadlock when pch_uart as console

2013-06-27 Thread Yijing Wang
g Li Signed-off-by: Greg Kroah-Hartman Signed-off-by: Yijing Wang Cc: sta...@vger.kernel.org --- drivers/tty/serial/pch_uart.c | 29 ++--- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 8b40a

Re: [PATCH 3.4 stable][PATCH] pch_uart: fix a deadlock when pch_uart as console

2013-06-28 Thread Yijing Wang
Hi Greg, I'm very sorry this email format problems, please drop this one, I will resend a correct email to describe this patch later. Thanks! Yijing. On 2013/6/28 11:10, Yijing Wang wrote: > From: Liang Li > > commit 384e301e3519599b000c1a2ecd938b533fc15d85 upstream &g

request for stable inclusion

2013-06-28 Thread Yijing Wang
Hi Greg, Jiri or Liang Li 384e301e3519599b000c1a2ecd938b533fc15d85 pch_uart: fix a deadlock when pch_uart as console This looks applicable to stable-3.4, and it was built successful for me. What do you think? Thanks! Yijing. -- To unsubscribe from this list: send the line "unsubscribe linux-ker

[PATCH v5 0/5] Fix aer_inject tool bug

2013-03-25 Thread Yijing Wang
exit The rest two patch mainly about to clean bus_ops; Yijing Wang (5): PCI/AER: Fix pci_ops return NULL in pci_read/write_aer PCI/AER: use list_for_each_entry to avoid a small race condition window PCI/AER: clean all untracked pci_ops_aer when rmmod aer_inject PCI/AER: clean pci_bus_ops

[PATCH v5 4/5] PCI/AER: clean pci_bus_ops when related pci bus was removed

2013-03-25 Thread Yijing Wang
When Inject aer errors to the target pci device, a pci_bus_ops will be allocated for the pci device's pci bus.When the pci bus was removed, we should also release the pci_bus_ops. Signed-off-by: Yijing Wang Reviewed-by: Sven Dietrich --- drivers/pci/pcie/aer/aer_inject.c |

[PATCH v5 2/5] PCI/AER: use list_for_each_entry to avoid a small race condition window

2013-03-25 Thread Yijing Wang
pci_bus_ops_pop to get bus_ops. Signed-off-by: Yijing Wang --- drivers/pci/pcie/aer/aer_inject.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c index fdab3bb..f499f01 100644 --- a/drivers/pci/pcie/aer

[PATCH v5 1/5] PCI/AER: Fix pci_ops return NULL in pci_read/write_aer

2013-03-25 Thread Yijing Wang
s_aer too.Now every access to the child bus's device will cause the system panic, because it will get a NULL pci_ops in pci_read_aer/pci_write_aer. Reviewed-by: Huang Ying Signed-off-by: Yijing Wang Signed-off-by: Jiang Liu Reviewed-by: Sven Dietrich --- drivers/pci/pcie/aer/aer_injec

[PATCH v5 3/5] PCI/AER: clean all untracked pci_ops_aer when rmmod aer_inject

2013-03-25 Thread Yijing Wang
ed-by: Huang Ying Signed-off-by: Yijing Wang --- drivers/pci/pcie/aer/aer_inject.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c index f499f01..4777c44 100644 --- a/driver

[PATCH v5 5/5] PCI/AER: free pci_bus_ops_list and remove pci_bus_ops_pop

2013-03-25 Thread Yijing Wang
Rewrite pci_bus_ops_list release code for simplification, and clean no used function pci_bus_ops_pop(). Reviewed-by: Huang Ying Signed-off-by: Yijing Wang --- drivers/pci/pcie/aer/aer_inject.c | 25 ++--- 1 files changed, 6 insertions(+), 19 deletions(-) diff --git a

Re: [PATCH -v2 0/3] Use PCIe DSN to improve pciehp_resume

2013-07-14 Thread Yijing Wang
On 2013/7/13 18:20, Paul Bolle wrote: > Yijing, > > On Fri, 2013-07-12 at 09:52 +0800, Yijing Wang wrote: >> Do you wireless card support Device Serial Number ? >> You can confirm it by lspci -vvv. > > Yes, it does: > lspci -vvv -s 03:00 | grep Serial >

[PATCH] video: remove unused variable "dev" in vga16fb_destroy()

2013-07-14 Thread Yijing Wang
Delete unused variable "dev" to fix build warning in drivers/video/vga16fb.c Signed-off-by: Yijing Wang Cc: Jingoo Han --- drivers/video/vga16fb.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c index 830ded

Re: [PATCH] PCI: update NumVFs register properly during enable/disable sriov

2013-07-29 Thread Yijing Wang
On 2013/7/29 22:31, Bjorn Helgaas wrote: > [+cc Don] > > On Wed, Jul 24, 2013 at 3:26 AM, Yijing Wang wrote: >> Currently, we only update NumVFs register during sriov_enable(). >> This register should also be updated properly during sriov_disable. >> Otherwise, we wi

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-29 Thread Yijing Wang
On 2013/7/30 7:33, Bjorn Helgaas wrote: > On Mon, May 27, 2013 at 9:15 PM, Yijing Wang wrote: >> Hi Bjorn and Jon, >>I'm sorry to disturb you. This patch is sent so long, but nobody seems >> had comment about it. >> Do you have any comment with this patch

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-29 Thread Yijing Wang
> I'm not sure this is implemented at the correct place. The idea of > using the serial number to detect card swaps is not really specific to > pciehp. I know the Device Serial Number capability is defined in the > PCIe spec, but it doesn't *require* any PCIe functionality, and > there's no reaso

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-29 Thread Yijing Wang
>> >> Hi Bjorn, >>I'm reworking this patch, but found some strange info about vpd serial >> number. >> I have two x86 machines, they almost have the same hardware topology. But by >> lspci, >> I found two different Broadcom BCM5709 NIC in different machine have the >> same vpd serial >> numb

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-31 Thread Yijing Wang
>>> PCIe Spec does not explicitly mention this issue, we can only get the >>> message that >>> root port/ root complex can split the TLP into smaller packets. For instance >>> one 256B packet split into two 128B packet. >>> >>> I confirm this issue in my X86 machine and IA64 machine. >>> 1. I unlo

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-31 Thread Yijing Wang
> Yes, I think that would be safe. If the switch is set to a larger MPS > than the hot-added device supports, I don't think we can safely use > the device. OK, I will refresh my patch, after test in my machine, I will send it out. Thanks! Yijing. > > Bjorn > > -- Thanks! Yijing -- To uns

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-07-31 Thread Yijing Wang
>> Yes, I think that would be safe. If the switch is set to a larger MPS >> than the hot-added device supports, I don't think we can safely use >> the device. > > I opened a bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=60671 > for this problem. Please correct any mistakes in my summary

[PATCH 03/16] cciss: clean up unnecessary MSI/MSI-X capability find

2013-08-08 Thread Yijing Wang
ill consume more time. Signed-off-by: Yijing Wang Cc: Mike Miller Cc: iss_storage...@hp.com Cc: linux-kernel@vger.kernel.org --- drivers/block/cciss.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 62b6c2c..8837

[PATCH 10/16] ntb: clean up unnecessary MSI/MSI-X capability find

2013-08-08 Thread Yijing Wang
ill consume more time. Signed-off-by: Yijing Wang Cc: Jon Mason Cc: linux-kernel@vger.kernel.org --- drivers/ntb/ntb_hw.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c index 2dacd19..090d1b2 100644 --- a/drivers/

[PATCH 14/16] amd_iommu: clean up unnecessary MSI/MSI-X capability find

2013-08-08 Thread Yijing Wang
ill consume more time. Signed-off-by: Yijing Wang Cc: Joerg Roedel Cc: io...@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org --- drivers/iommu/amd_iommu_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/io

[PATCH 16/16] tg3: clean up unnecessary MSI/MSI-X capability find

2013-08-08 Thread Yijing Wang
ill consume more time. Signed-off-by: Yijing Wang Cc: Nithin Nayak Sujir Cc: Michael Chan Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ethernet/broadcom/tg3.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg

[PATCH] PCI: update NumVFs register properly during enable/disable sriov

2013-07-24 Thread Yijing Wang
Currently, we only update NumVFs register during sriov_enable(). This register should also be updated properly during sriov_disable. Otherwise, we will get the stale "Number of VFs" info from lspci. Signed-off-by: Yijing Wang --- drivers/pci/iov.c |4 +++- 1 files changed, 3

Re: [PATCH -v3 3/3] PCI,pciehp: use PCIe DSN to identify device change during suspend

2013-07-26 Thread Yijing Wang
Hi Bjorn, Thanks for your review and comments! > > I'm not sure this is implemented at the correct place. The idea of > using the serial number to detect card swaps is not really specific to > pciehp. I know the Device Serial Number capability is defined in the > PCIe spec, but it doesn't *r

Re: [PATCH 2/7] PCI: move resources and bus_list releasing to pci_release_dev

2013-05-13 Thread Yijing Wang
On 2013/5/14 10:28, Yinghai Lu wrote: > We should not release resource in pci_destroy that is too early Hi Yinghai, "too early" means that after pci_stop_dev(), if someone else hold the device reference, it still care the device resource ? e.g.? Thanks! Yijing. > as there could be still other

Re: [PATCH 2/7] PCI: move resources and bus_list releasing to pci_release_dev

2013-05-13 Thread Yijing Wang
On 2013/5/14 11:56, Yinghai Lu wrote: > On Mon, May 13, 2013 at 8:20 PM, Yijing Wang wrote: >> On 2013/5/14 10:28, Yinghai Lu wrote: >>> We should not release resource in pci_destroy that is too early >> >> Hi Yinghai, >>"too early" means that aft

[Resend with Ack][PATCH] mm: remove CONFIG_HOTPLUG ifdefs

2013-04-08 Thread Yijing Wang
CONFIG_HOTPLUG is going away as an option, cleanup CONFIG_HOTPLUG ifdefs in mm files. Signed-off-by: Yijing Wang Acked-by: Greg Kroah-Hartman Cc: Minchan Kim Cc: Mel Gorman Cc: Bartlomiej Zolnierkiewicz Cc: Rik van Riel Cc: Hugh Dickins Cc: Bill Pemberton Cc: Greg Kroah-Hartman

[PATCH] i2c: remove CONFIG_HOTPLUG ifdefs

2013-04-08 Thread Yijing Wang
CONFIG_HOTPLUG is going away as an option, cleanup CONFIG_HOTPLUG ifdefs in i2c files. Signed-off-by: Yijing Wang Cc: Greg Kroah-Hartman Cc: Bill Pemberton --- drivers/i2c/i2c-core.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers

Re: [PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-25 Thread Yijing Wang
send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > . > -- Thanks! Yijing >From 44914e0e3

Re: [PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-26 Thread Yijing Wang
On 2013/4/26 14:20, Yinghai Lu wrote: > On Thu, Apr 25, 2013 at 9:02 PM, Yijing Wang wrote: >> Hi Yinghai, >>We should not remove this additional pci_disable_device(). >> Because we enable pcie port device twice before. The first is >> pci_enable_brides(),

Re: [RFC PATCH] PCI: Enable pci bridge when it is needed

2013-04-26 Thread Yijing Wang
I think it's cool! Now we enable bridge in various places, this is a headache. hi, yinghai, in this patch, enable bridges depend on the driver call pci_enable_device() explicitly. I was a little worried If there has some devices don't have some drivers bound, but used by system. like ioapic, the

Re: [RFC PATCH] PCI: Enable pci bridge when it is needed

2013-04-26 Thread Yijing Wang
On 2013/4/27 9:57, Yinghai Lu wrote: > On Fri, Apr 26, 2013 at 6:51 PM, Yijing Wang wrote: >> I think it's cool! Now we enable bridge in various places, this is a >> headache. >> >> hi, yinghai, in this patch, enable bridges depend on the driver call >> pc

Re: [PATCH v8 10/13] PCI/acpiphp: do not use ACPI PCI subdriver mechanism

2013-04-10 Thread Yijing Wang
>> Hi Bjorn, >> Thanks for review. >> >>> My goal is that a user should never have to specify a kernel boot >>> parameter or edit a modules.conf file, but the user did previously >>> have some way to influence whether we use pciehp or acpiphp. I know >>> we still have some issues, particul

Re: [PATCH -v2] PCI/VFIO: use pcie_flags_reg instead of access PCI-E Capabilities Register

2013-04-11 Thread Yijing Wang
ping? On 2013/4/2 9:52, Yijing Wang wrote: > Currently, we use pcie_flags_reg to cache PCI-E Capabilities Register, > because PCI-E Capabilities Register bits are almost read-only. This patch > use pcie_caps_reg() instead of another access PCI-E Capabilities Register. > > Signed

Re: [PATCH v8 10/13] PCI/acpiphp: do not use ACPI PCI subdriver mechanism

2013-04-11 Thread Yijing Wang
On 2013/4/12 1:29, Bjorn Helgaas wrote: > On Wed, Apr 10, 2013 at 7:50 PM, Yijing Wang wrote: >>>> Hi Bjorn, >>>> Thanks for review. >>>> >>>>> My goal is that a user should never have to specify a kernel boot >>>>&g

Re: [PATCH 2/2] PCI/IA64: fix pci_dev->enable_cnt balance when doing pci hotplug

2013-04-14 Thread Yijing Wang
>> @@ -383,6 +383,7 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root >> *root) >> } >> >> pci_scan_child_bus(pbus); >> + pci_enable_bridges(pbus); >> return pbus; >> >> out3: > > I think that with this patch, if you hot-add a PCI host bridge, you > will ca

Re: [PATCH 1/3] PCI,acpiphp: use generic pci_hp_add_bridge()

2013-04-15 Thread Yijing Wang
pci_scan_bridge() directly. I would appreciate if you can give some suggestions. Thanks! Yijing. On 2013/4/1 17:22, Yijing Wang wrote: > Use pci_hp_add_bridge() like most other hotplug drivers > rather than call pci_scan_bridge() directly. > > Signed-off-by: Yijing Wang > --- > d

Re: [PATCH 1/3] PCI,acpiphp: use generic pci_hp_add_bridge()

2013-04-15 Thread Yijing Wang
> On Mon, Apr 15, 2013 at 6:49 PM, Yijing Wang wrote: >> Hi Yinghai, >>Any comments about this patch? I searched the code history and found >> you introduced pci_hp_add_bridge() function at commit a8e4b9c10. In your >> patchset use pci_hp_add_bridge() for all

Re: [PATCH] PCI: update device mps when doing pci hotplug

2013-05-27 Thread Yijing Wang
ort mps. 2) target device under non root port We assume the target device both is a transmitter and receiver, so the safest way is to assign target device mps equal to its parent device. Any comments about this patch is welcome! Thanks! Yijing. On 2013/2/5 11:55, Yijing Wang wrote: >

[PATCH] tg3: remove redundant pm init code

2013-05-29 Thread Yijing Wang
Pci_enable_device() will set device pm state to D0, so it's no need to do it again in tg3_init_one(). Signed-off-by: Yijing Wang --- drivers/net/ethernet/broadcom/tg3.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/broadco

[PATCH] PCI/VFIO: use pcie_flags_reg instead of access PCI-E Capabilities Register

2013-03-27 Thread Yijing Wang
Currently, we use pcie_flags_reg to cache PCI-E Capabilities Register, because PCI-E Capabilities Register bits are almost read-only. This patch use pcie_flags_reg instead of another access PCI-E Capabilities Register. Signed-off-by: Yijing Wang --- drivers/vfio/pci/vfio_pci_config.c |6

[PATCH 1/2] mm: remove CONFIG_HOTPLUG ifdefs

2013-03-27 Thread Yijing Wang
CONFIG_HOTPLUG is going away as an option, cleanup CONFIG_HOTPLUG ifdefs in mm files. Signed-off-by: Yijing Wang Cc: Minchan Kim Cc: Mel Gorman Cc: Bartlomiej Zolnierkiewicz Cc: Rik van Riel Cc: Hugh Dickins Cc: Bill Pemberton Cc: Greg Kroah-Hartman --- include/linux/vmstat.h |7

[PATCH] i2c: remove CONFIG_HOTPLUG ifdefs

2013-03-27 Thread Yijing Wang
CONFIG_HOTPLUG is going away as an option, cleanup CONFIG_HOTPLUG ifdefs in i2c files. Signed-off-by: Yijing Wang --- drivers/i2c/i2c-core.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 991d38d..d1db97e 100644

[PATCH 1/2] PCI: decrease pci_dev->enable_cnt when no pcie capability found

2013-04-01 Thread Yijing Wang
We should decrease dev->enable_cnt when no pcie port capability found for balance. Signed-off-by: Yijing Wang Cc: Jiang Liu Cc: Kenji Kaneshige Cc: Shengzhou Liu --- drivers/pci/pcie/portdrv_core.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/pci/p

[PATCH 2/2] PCI/IA64: fix pci_dev->enable_cnt balance when doing pci hotplug

2013-04-01 Thread Yijing Wang
ing service driver aer Signed-off-by: Yijing Wang Cc: Fenghua Yu Cc: Yinghai Lu Cc: Greg Kroah-Hartman Cc: Thierry Reding Cc: "Rafael J. Wysocki" --- arch/ia64/pci/pci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pc

[PATCH 1/3] PCI,acpiphp: use generic pci_hp_add_bridge()

2013-04-01 Thread Yijing Wang
Use pci_hp_add_bridge() like most other hotplug drivers rather than call pci_scan_bridge() directly. Signed-off-by: Yijing Wang --- drivers/pci/hotplug/acpiphp_glue.c | 24 ++-- 1 files changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/pci/hotplug

[PATCH 2/3] PCI: acpiphp: remove unused function acpiphp_max_busnr

2013-04-01 Thread Yijing Wang
Clean up unuse function acpiphp_max_busnr() code. Signed-off-by: Yijing Wang --- drivers/pci/hotplug/acpiphp_glue.c | 30 -- 1 files changed, 0 insertions(+), 30 deletions(-) diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c

[PATCH 3/3] PCI, pciehp: remove check for configure display devices

2013-04-01 Thread Yijing Wang
Commit ac81860 removed unnecessary check for hotplug of display device. Currently pciehp is allowd to hotplug display device, So we also configure display device when hot added. Signed-off-by: Yijing Wang --- drivers/pci/hotplug/pciehp_pci.c |6 +- 1 files changed, 1 insertions(+), 5

Re: [PATCH] PCI/VFIO: use pcie_flags_reg instead of access PCI-E Capabilities Register

2013-04-01 Thread Yijing Wang
>> @@ -1017,13 +1017,9 @@ static int vfio_cap_len(struct vfio_pci_device *vdev, >> u8 cap, u8 pos) >> return byte; >> case PCI_CAP_ID_EXP: >> /* length based on version */ >> -ret = pci_read_config_word(pdev, pos + PCI_EXP_FLAGS, &word); >> -i

[PATCH -v2] PCI/VFIO: use pcie_flags_reg instead of access PCI-E Capabilities Register

2013-04-01 Thread Yijing Wang
Currently, we use pcie_flags_reg to cache PCI-E Capabilities Register, because PCI-E Capabilities Register bits are almost read-only. This patch use pcie_caps_reg() instead of another access PCI-E Capabilities Register. Signed-off-by: Yijing Wang --- drivers/vfio/pci/vfio_pci_config.c |6

Re: [PATCH 2/2] PCI/IA64: fix pci_dev->enable_cnt balance when doing pci hotplug

2013-04-01 Thread Yijing Wang
On 2013/4/2 6:23, Luck, Tony wrote: >> In IA64 platform, we don't call pci_enable_bridges() >> when scan all pci buses during system boot up. But in >> X86 we do it in > > Your patch looks plausible ... but I have a question. X86 doesn't > *directly* call pci_enable_bridges() from any arch/x86/* f

[RESEND BUGFIX PATCH 3/3] PCI: check whether pci device has been removed when remove a pci device by sysfs

2012-08-25 Thread Yijing Wang
jbd fan pr ocessor ide_pci_generic ide_core ata_piix libata mptsas mptscsih mptbase scsi_tr ansport_sas scsi_mod thermal thermal_sys hwmon Signed-off-by: Yijing Wang --- drivers/pci/pci-sysfs.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci

[RESEND BUGFIX PATCH 1/3] PCI/AER: fix pci_ops return NULL when hotplug a pci bus which was doing aer error inject

2012-08-25 Thread Yijing Wang
0f3dfc11d0 [] ia64_ret_from_syscall+0x0/0x20 sp=e00f3dfcfe30 bsp=e00f3dfc11d0 [] __kernel_syscall_via_break+0x0/0x20 sp=e00f3dfd bsp=e00f3dfc11d0 Disabling lock debugging due to kernel taint Signed-off-by: Yijing Wang Signed-off-by:

[RESEND BUGFIX PATCH 2/3] PCI/AER: clean pci_bus_ops when related pci bus was removed

2012-08-25 Thread Yijing Wang
When Inject aer errors to the target pci device, a pci_bus_ops will be allocated for the pci device's pci bus.When the pci bus was removed, we should also release the pci_bus_ops. Signed-off-by: Yijing Wang --- drivers/pci/pcie/aer/aer_inject.c | 43 +++

Re: [RESEND BUGFIX PATCH 3/3] PCI: check whether pci device has been removed when remove a pci device by sysfs

2012-08-26 Thread Yijing Wang
ize PCI hotplug operations patches. That is a more comprehensive solution actually. - Thanks. Yijing > On 08/25/2012 05:59 PM, Yijing Wang wrote: >> We remove a pci device maybe like this >> echo 1 > /sys/bus/pci/devices/:xx:xx.x/remove >> Then remove_store fu

[PATCH] PCI: Document PCIE BUS MPS parameters

2013-01-23 Thread Yijing Wang
understand and use the parameters. Signed-off-by: Yijing Wang --- Documentation/kernel-parameters.txt | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 363e348..4dfa8d2 100644 --- a

Re: [PATCH] PCI: Document PCIE BUS MPS parameters

2013-01-23 Thread Yijing Wang
于 2013-01-23 17:21, Andrew Murray 写道: > On Wed, Jan 23, 2013 at 08:01:36AM +0000, Yijing Wang wrote: >> Document PCIE BUS MPS parameters pcie_bus_tune_off, pcie_bus_safe, >> pcie_bus_peer2peer, pcie_bus_perf into Documentation/kernel-parameters.txt. >> These parameters were in

Re: [PATCH] PCI: Document PCIE BUS MPS parameters

2013-01-23 Thread Yijing Wang
On 2013/1/23 18:30, Andrew Murray wrote: > On Wed, Jan 23, 2013 at 10:13:02AM +0000, Yijing Wang wrote: >> ??? 2013-01-23 17:21, Andrew Murray ??: >>> On Wed, Jan 23, 2013 at 08:01:36AM +, Yijing Wang wrote: >>>> Document PCIE BUS MPS parameters pc

[Update][PATCH] PCI: Document PCIE BUS MPS parameters

2013-01-23 Thread Yijing Wang
understand and use the parameters. Signed-off-by: Yijing Wang --- Documentation/kernel-parameters.txt | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 363e348..1fb269b 100644 --- a

[PATCH] PCI: Document PCI Hotplug resource reservation parameters

2013-01-23 Thread Yijing Wang
Document pci hotplug resource reservation parameters hpiosize and hpmemsize into Documentation/kernel-parameters.txt. The two parameters can override default hotplug io size(256 bytes) and default mem size(2M). Signed-off-by: Yijing Wang --- Documentation/kernel-parameters.txt |6 ++ 1

Re: [Update][PATCH] PCI: Document PCIE BUS MPS parameters

2013-01-23 Thread Yijing Wang
Hi Randy, Thanks for your review and comments! please refer to inlined comments below. On 2013/1/24 7:39, Randy Dunlap wrote: > On 01/23/13 04:28, Yijing Wang wrote: >> Document PCIE BUS MPS parameters pcie_bus_tune_off, pcie_bus_safe, >> pcie_bus_peer2peer, pcie_bus_perf int

Re: [Update][PATCH] PCI: Document PCIE BUS MPS parameters

2013-01-23 Thread Yijing Wang
On 2013/1/24 10:02, Randy Dunlap wrote: > On 01/23/13 17:55, Yijing Wang wrote: >> Hi Randy, >>Thanks for your review and comments! please refer to inlined comments >> below. >> >> On 2013/1/24 7:39, Randy Dunlap wrote: >>> On 01/23/13 04:28, Yijing

[PATCH v2] PCI: Document PCIE BUS MPS parameters

2013-01-23 Thread Yijing Wang
cument PCIE BUS MPS parameters pcie_bus_tune_off, pcie_bus_safe, pcie_bus_peer2peer, pcie_bus_perf into Documentation/kernel-parameters.txt. These parameters were introduced by Jon Mason at commit 5f39e6705 and commit b03e7495a8. Signed-off-by: Yijing Wang --- Documentation/kernel-parameters.txt

Re: [PATCH] PCI: add PCIe 8.0 GT/s supported link speed define

2012-11-22 Thread Yijing Wang
> diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 20ae747..0cf8abb 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -469,6 +469,7 @@ > #define PCI_EXP_LNKSTA_CLS 0x000f /* Current Link Speed */ > #define PCI_EXP_LNKSTA_

Re: [PATCH v7 0/4] PCI: pciehp, shpchp deadlock fixes

2013-01-13 Thread Yijing Wang
> > I propose to push the entire series for inclusion in v3.8, since it > fixes an easy-to-cause deadlock with Thunderbolt adapters. > > --- > > Bjorn Helgaas (3): > PCI: shpchp: Make shpchp_wq non-ordered > PCI: shpchp: Handle push button event asynchronously >

Re: [PATCH v8 01/22] PCI, acpiphp: Add is_hotplug_bridge detection

2013-01-14 Thread Yijing Wang
On 2013/1/12 6:40, Yinghai Lu wrote: > When system support hotplug bridge with children hotplug slots, we need > to make sure that parent bridge get preallocated resource so later when > device is plugged into children slot, those children devices will get > resource allocated. > > We do not meet

Re: [PATCH 5/6] ACPI: Replace struct acpi_bus_ops with enum type

2012-12-12 Thread Yijing Wang
于 2012-12-12 2:30, Rafael J. Wysocki 写道: > Hi Gerry, > > On Tuesday, December 11, 2012 11:09:06 PM Jiang Liu wrote: >> Hi Rafael, >> I have worked out a patch set to clean up ACPI/PCI related >> notifications, >> please refer to >> http://www.spinics.net/lists/linux-pci/msg17822.html >>

Re: [PATCH 0/6] ACPI: Change the ACPI namespace scanning code ordering

2012-12-13 Thread Yijing Wang
Hi rafael, I tested the pachset in our IA64 machine, system boot up log seems ok, but when do IOH hot plug, there are two small problems that missing match and start acpi devices for the top acpi device(eg. pci host bridge), refer https://lkml.org/lkml/2012/12/12/268. Test Machine: IA64,2 phy

Re: [PATCH rev.2 0/6] ACPI: Change the ACPI namespace scanning code ordering

2012-12-14 Thread Yijing Wang
[4/6] - Reduce the usage of struct acpi_bus_ops >> [5/6] - Replace struct acpi_bus_ops with an enum type >> [6/6] - Change the ordering of acpi_bus_check_add() to avoid unnecessary >> checks. > > The second revision is necessary to address problems found by Yijing Wang > d

Re: [PATCH v8 22/22] PCI: move device_add out of pci_bus_add_device()

2013-01-15 Thread Yijing Wang
On 2013/1/12 6:40, Yinghai Lu wrote: > Move out device registering out of pci_bus_add_devices, so we could > put new created pci devices in device tree early. > > new pci_bus_add_devices will do the device_attach work to load pci drivers > instead. > > Signed-off-by: Yinghai Lu > --- > drivers/

Re: [RFC PATCH v5 7/8] PCI/PCIe: add "pci=nopciehp" to disable PCIe native hotplug

2013-01-18 Thread Yijing Wang
于 2013-01-19 1:35, Bjorn Helgaas 写道: > On Fri, Jan 18, 2013 at 9:07 AM, Jiang Liu wrote: >> If user specifies "pci=nopciehp" on kernel boot command line, OSPM >> won't claim PCIe native hotplug service from firmware and no PCIe >> port devices will be created for PCIe native hotplug service. > >

Re: 3.8-rc2: pciehp waitqueue hang...

2013-01-06 Thread Yijing Wang
On 2013/1/5 5:50, Bjorn Helgaas wrote: > [+to Yijing, +cc Kenji] > > On Fri, Jan 4, 2013 at 1:01 PM, Bjorn Helgaas wrote: >> On Thu, Jan 3, 2013 at 8:41 AM, Jiang Liu wrote: >>> Hi Daniel, >>> It seems like an issue caused by recursive PCIe HPC. >>> Could you please help to try the patch

Re: 3.8-rc2: pciehp waitqueue hang...

2013-01-08 Thread Yijing Wang
Hi Bjorn, I will send the shpchp patch soon. Thanks! Yijing >>> Yijing, please check for the same problem in other hotplug drivers. >>> Questions I have after a quick look: >>> >> >> Hi Bjorn, >>Sorry for delay reply. There are some busy work these days. >> >>> - shpchp_wq looks like it

Re: [PATCH v3 0/6] Update PCI notification patchset to latest kernel version

2013-01-09 Thread Yijing Wang
; ACPI/pci_slot: update PCI slot information when PCI hotplug event >> happens >> PCI/acpiphp: update ACPI hotplug slot information when PCI hotplug >> happens >> PCI/acpiphp: serialize access to the bridge_list list >> >> Yijing Wang (1): >> PCI/AE

[RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc()

2016-06-21 Thread Yijing Wang
Cache_sb is not used in cache_alloc, and we have copied sb info to cache->sb already, remove it. Signed-off-by: Yijing Wang --- drivers/md/bcache/super.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c in

[RESEND PATCH 3/3] bcache: Remove redundant block_size assignment

2016-06-21 Thread Yijing Wang
We have assigned sb->block_size before the switch, so remove the redundant one. Reviewed-by: Coly Li Signed-off-by: Yijing Wang Acked-by: Eric Wheeler --- drivers/md/bcache/super.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers

<    1   2   3   4   5   6   7   8   9   10   >