[PATCH v1 1/2] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
: Yakir Yang --- drivers/gpu/drm/panel/panel-simple.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..f178998 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel

[PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
t;detect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers

[PATCH v1.1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
t;detect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang --- Changes in v1.1: - unprepare the panel at the end of bridge->disable() function drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 22 +++--- 1 file changed, 15 insertions(+),

Re: [PATCH v1 1/2] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
Sean, On 07/21/2016 10:30 PM, Sean Paul wrote: On Thu, Jul 21, 2016 at 9:14 AM, Yakir Yang wrote: According to page 16 of Sharp LQ123P1JX31 datasheet, we need to add the missing delay timing. Panel prepare time should be t1 (0.5ms~10ms) plus t3 (0ms~100ms), and panel enable time should equal

[PATCH v2 1/3] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
: Yakir Yang Reviewed-by: Sean Paul --- Changes in v2: - Add the reviewed tag from Sean. drivers/gpu/drm/panel/panel-simple.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..f178998 100644 --- a

[PATCH v2 2/3] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
t;detect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang --- Changes in v2: - s/Panle/Panel/ (Sean) - Move the drm_panel_ out of a conditional, and throw the return code away (Sean) - Add comments about why we need unprepare the panel in bridge_disab

[PATCH v2 3/3] drm/bridge: analogix_dp: remove the panel prepare/unprepare in suspend/resume

2016-07-21 Thread Yakir Yang
We already manager the panel power status in bridge_disable and connector->detect functions, then we don't need to manager the panel power status at suspend/resume in particular. Signed-off-by: Yakir Yang --- Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_cor

Re: [PATCH v3 2/3] drm/bridge: analogix_dp: use jiffies to simulate timeout loop

2016-09-19 Thread Yakir Yang
Hi Sean, On 09/12/2016 09:51 PM, Sean Paul wrote: On Fri, Sep 9, 2016 at 5:44 AM, Yakir Yang wrote: Signed-off-by: Yakir Yang --- Changes in v3: - Suggested by Sean Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 3 ++- drivers/gpu/drm/bridge/analogix

Re: [PATCH v3 3/3] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-19 Thread Yakir Yang
Hi Sean, On 09/12/2016 09:52 PM, Sean Paul wrote: On Fri, Sep 9, 2016 at 5:45 AM, Yakir Yang wrote: Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: Yakir

[PATCH v3.1 2/2] dt-bindings: analogix_dp: rockchip: correct the wrong compatible name

2016-06-21 Thread Yakir Yang
t for rockchip variant of analogix_dp"). Reported-by: Tomasz Figa Signed-off-by: Yakir Yang --- Hi all, This is an external patch for analogix_dp misc cleanup thread [0] [0]: https://patchwork.kernel.org/patch/9175613/ BR, - Yakir .../devicetree/bindings/display/rockchip/analogix_dp-rockchip.tx

[PATCH v3.1 1/2] drm/rockchip: analogix_dp: introduce the pclk for grf

2016-06-21 Thread Yakir Yang
For RK3399's GRF module, if we want to operate the graphic related grf registers, we need to enable the pclk_vio_grf which supply power for VIO GRF IOs, so it's better to introduce an optional grf clock in driver. Signed-off-by: Yakir Yang --- Hi all, This is an external patch for a

Re: [PATCH v3 0/10]

2016-06-21 Thread Yakir Yang
Archit, On 06/21/2016 09:46 PM, Archit Taneja wrote: On 6/14/2016 5:15 PM, Yakir Yang wrote: RK3399 and RK3288 shared the same eDP IP controller, only some light difference with VOP configure and GRF configure. Also same misc fix to analogix_dp driver: - Hotplug invalid which report by Dan

[PATCH v3 3/4] arm64: dts: rockchip: add backlight support for rk3399 evb board

2016-06-21 Thread Yakir Yang
Add backlight node for evb board, perpare for panel device node. Signed-off-by: Yakir Yang --- Changes in v3: None Changes in v2: - provide some minimal patch description (Heiko) arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 40 + 1 file changed, 40 insertions

[PATCH v3 1/4] arm64: dts: rockchip: add VOP and VOP iommu node for rk3399

2016-06-21 Thread Yakir Yang
From: Mark Yao Add the core display-subsystem node and the two display controllers available on the rk3399. Signed-off-by: Mark Yao Signed-off-by: Yakir Yang --- Changes in v3: None Changes in v2: - provide some minimal patch description (Heiko) arch/arm64/boot/dts/rockchip/rk3399.dtsi | 58

[PATCH v3 4/4] arm64: dtsi: rockchip: introduce pclk_vio_grf in eDP device node

2016-06-21 Thread Yakir Yang
The pclk_vio_grf supply power for VIO GRF IOs, if it is disabled, driver would failed to operate the VIO GRF registers. Signed-off-by: Yakir Yang --- Changes in v3: - Add this patch in v3, due to another patch[0] need. [0]: https://patchwork.kernel.org/patch/9191737/ Changes in v2: None

[PATCH v3 2/4] arm64: dts: rockchip: add eDP device node for rk3399

2016-06-21 Thread Yakir Yang
Add rk3399 eDP device node, and connect to VOP device node with remote endpoint. Signed-off-by: Yakir Yang --- Changes in v3: None Changes in v2: - provide some minimal patch description (Heiko) arch/arm64/boot/dts/rockchip/rk3399.dtsi | 52 1 file changed, 52

[PATCH v3.1 4/4] arm64: dts: rockchip: introduce pclk_vio_grf in eDP device node

2016-06-21 Thread Yakir Yang
The pclk_vio_grf supply power for VIO GRF IOs, if it is disabled, driver would failed to operate the VIO GRF registers. Signed-off-by: Yakir Yang --- Changes in v3.1: - Correct the commit message. "arm64: dtsi: ..." ---> "arm64: dts: ..." Changes in v3: - Add t

[PATCH v3 0/4] Add the eDP/VOP device node for rk3399

2016-06-21 Thread Yakir Yang
nges in v2: - provide some minimal patch description (Heiko) - provide some minimal patch description (Heiko) - provide some minimal patch description (Heiko) Mark Yao (1): arm64: dts: rockchip: add VOP and VOP iommu node for rk3399 Yakir Yang (3): arm64: dts: rockchip: add eDP device node

Re: [PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-27 Thread Yakir Yang
Sean, Oops, sorry about miss your suggest :( On 07/22/2016 11:03 PM, Sean Paul wrote: On Thu, Jul 21, 2016 at 9:00 PM, Yakir Yang wrote: Sean, Thanks for your fast respond :-) But this patch is not the latest one, I have upgraded this to "v1.1" version to fix the eDP can

Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver

2016-07-31 Thread Yakir Yang
On 07/29/2016 04:38 PM, Tomeu Vizoso wrote: On 5 April 2016 at 04:06, Yakir Yang wrote: Hi Daniel, On 03/31/2016 06:15 PM, Daniel Vetter wrote: On Mon, Feb 15, 2016 at 07:08:05PM +0800, Yakir Yang wrote: Hi all, The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller

Re: [PATCH] drm/analogix_dp: Ensure the panel is properly prepared/unprepared

2016-07-31 Thread Yakir Yang
Sean, On 07/30/2016 03:16 AM, Sean Paul wrote: Instead of just preparing the panel on bind, actually prepare/unprepare during modeset/disable. The panel must be prepared in order to read hpd status, so we need to refcount the prepares in order to ensure we don't accidentally turn the panel off a

Re: [PATCH] drm/analogix_dp: Ensure the panel is properly prepared/unprepared

2016-07-31 Thread Yakir Yang
Sean, On 07/30/2016 03:16 AM, Sean Paul wrote: Instead of just preparing the panel on bind, actually prepare/unprepare during modeset/disable. The panel must be prepared in order to read hpd status, so we need to refcount the prepares in order to ensure we don't accidentally turn the panel off a

Re: [PATCH] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-06 Thread Yakir Yang
Sean, Thanks for your comments. On 09/07/2016 03:51 AM, Sean Paul wrote: On Fri, Aug 26, 2016 at 6:19 AM, Yakir Yang wrote: Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting

[PATCH v2 1/2] drm/bridge: analogix_dp: Remove duplicated code v2

2016-09-07 Thread Yakir Yang
: Tomeu Vizoso Cc: Javier Martinez Canillas Cc: Mika Kahola Cc: Yakir Yang Cc: Daniel Vetter Reviewed-by: Sean Paul Reviewed-by: Yakir Yang Tested-by: Javier Martinez Canillas Tested-by: Sean Paul --- Changes in v2: - A bunch of good fixes from Sean and Yakir - Moved the transfer function to

[PATCH v2 2/2] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-07 Thread Yakir Yang
Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Signed-off-by: Yakir Yang --- Changes in v2: - A bunch of good fixes from Sean drivers/gpu/drm/bridge/analogix

Re: [PATCH v2 2/2] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-09 Thread Yakir Yang
On 09/08/2016 10:12 PM, Sean Paul wrote: On Wed, Sep 7, 2016 at 11:48 PM, Yakir Yang wrote: Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Let's change to: Make

[PATCH v3 2/3] drm/bridge: analogix_dp: use jiffies to simulate timeout loop

2016-09-09 Thread Yakir Yang
Signed-off-by: Yakir Yang --- Changes in v3: - Suggested by Sean Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 3 ++- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 18 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH v3 3/3] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-09 Thread Yakir Yang
Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: Yakir Yang --- Changes in v3: - Update commit message - Add DP_TIMEOUT_PSR_LOOP_MS marcos - Correct the return

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso Cc: Javier Martinez Canillas Cc: Mika Kahola Cc: Yakir Yang Cc: Daniel Vetter --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 390 +++-- drivers/gpu/drm/bridge/analogix

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso Cc: Javier Martinez Canillas Cc: Mika Kahola Cc: Yakir Yang Cc: Daniel Vetter

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-08 Thread Yakir Yang
+ Archit Tomeu, Thanks for the update :-) But you have missed three tiny align problems, please see my inline notes, wish you could fix them. After that this patch looks good to me, so: Reviewed-by: Yakir Yang I guess this patch should go through Archit's drm_bridge tree, so I adde

Re: [PATCH v2] drm/bridge: analogix_dp: Ensure the panel is properly prepared/unprepared

2016-08-08 Thread Yakir Yang
x27;t accidentally turn the panel off at the wrong time. Signed-off-by: Sean Paul Reviewed-by: Yakir Yang And I also tested this patch on RK3399 Kevin board, panel works rightly, so: Tested-by: Yakir Yang Also add Archit into CC list, guess this patch should go through his drm_bridge's tree

[PATCH] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-08-26 Thread Yakir Yang
Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Signed-off-by: Yakir Yang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 6 ++--- drivers/gpu/drm/bridge/analogix

Re: [PATCH 06/12] drm: bridge/dw_hdmi: clean up HDMI vs DVI mode handling

2015-10-06 Thread Yakir Yang
and I have backport those 06/12 & 07/12 to chrome-3.14 tree, audio still works rightly when I changing the display resolutions. So I would like to share: Tested-by: Yakir Yang Besides, Andy, would you like to share your ACK here :) Best regards, - Yakir --- drivers/gpu/d

Re: [PATCH 07/12] drm: bridge/dw_hdmi: enable audio only if sink supports audio

2015-10-06 Thread Yakir Yang
eply. Tested-by: Yakir Yang - Yakir --- drivers/gpu/drm/bridge/dw_hdmi.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c index 7f764716f3c4..578d7362cd65 100644 --- a/drivers/gpu/drm/bridge/dw_hd

Re: [PATCH 08/12] drm: bridge/dw_hdmi: avoid enabling interface in mode_set

2015-10-06 Thread Yakir Yang
On 08/09/2015 12:04 AM, Russell King wrote: On a mode set, DRM makes the following sequence of calls: * for_each_encoder * bridge mode_fixup * encoder mode_fixup * crtc mode_fixup * for_each_encoder * bridge disable * encoder prepare * bridge post_disab

Re: [PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-06 Thread Yakir Yang
Hi all, Friendly ping. :) Best regards, - Yakir On 09/22/2015 03:20 PM, Yakir Yang wrote: Hi all, The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller share the same IP, so a lot of parts can be re-used. I split the common code into bridge directory, then rk3288

Re: [PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-07 Thread Yakir Yang
Hi Javier, On 10/07/2015 04:46 PM, Javier Martinez Canillas wrote: Hello Yakir, On 10/07/2015 08:25 AM, Yakir Yang wrote: Hi all, Friendly ping. :) Best regards, - Yakir Do you have a tree that I can use to test these patches? Wow, thanks a lot, I do have a tree on github

Re: [PATCH 08/12] drm: bridge/dw_hdmi: avoid enabling interface in mode_set

2015-10-07 Thread Yakir Yang
On 10/07/2015 05:18 PM, Russell King - ARM Linux wrote: On Wed, Oct 07, 2015 at 11:50:53AM +0800, Yakir Yang wrote: On 08/09/2015 12:04 AM, Russell King wrote: On a mode set, DRM makes the following sequence of calls: * for_each_encoder * bridge mode_fixup * encoder mode_fixup

Re: [PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-07 Thread Yakir Yang
Hi Javier, On 10/07/2015 07:25 PM, Javier Martinez Canillas wrote: Hello Yakir, On 10/07/2015 01:05 PM, Yakir Yang wrote: Hi Javier, On 10/07/2015 05:26 PM, Javier Martinez Canillas wrote: Hello Yakir, On 10/07/2015 11:02 AM, Yakir Yang wrote: Hi Javier, On 10/07/2015 04:46 PM, Javier

Re: [PATCH 10/12] drm: bridge/dw_hdmi: fix phy enable/disable handling

2015-10-08 Thread Yakir Yang
Oh, I haven't noticed that those patches already have been merged into linux-next :-) On 10/08/2015 03:17 AM, Russell King - ARM Linux wrote: On Wed, Oct 07, 2015 at 06:40:11PM +0800, Yakir Yang wrote: On 10/07/2015 05:48 PM, Russell King - ARM Linux wrote: On Wed, Oct 07, 2015 at

Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver

2015-08-30 Thread Yakir Yang
/next/linux-next.git when I'm preparing v4 series. Thanks, - Yakir Regards, Romain 2015-08-21 15:16 GMT+02:00 Thierry Reding : On Fri, Aug 21, 2015 at 08:24:16PM +0900, Jingoo Han wrote: On 2015. 8. 21., at PM 7:01, Yakir Yang wrote: Hi Jingoo, 在 2015/8/21 16:20, Jingoo Han 写道: On 2015.

[PATCH v4 0/16] Add Analogix Core Display Port Driver

2015-08-31 Thread Yakir Yang
node with remote-endpoint method, and create devicetree binding for driver. - Remove the clock enable/disbale with "sclk_edp" & "sclk_edp_24m", leave those clock to rockchip dp phy driver. - Add GNU license v2 declared and samsung copyright - Fix compile failed dut

[PATCH v4 01/16] drm: exynos/dp: fix code style

2015-08-31 Thread Yakir Yang
After run "checkpatch.pl -f --subjective" command, I see there are lots of alignment problem in exynos_dp driver, so let just fix them. - Take Romain suggest, rebase on linux-next branch Signed-off-by: Yakir Yang --- Changes in v4: None Changes in v3: None Changes in v2: - Take J

[PATCH v4 02/16] drm: exynos/dp: convert to drm bridge mode

2015-08-31 Thread Yakir Yang
In order to move exynos dp code to bridge directory, we need to convert driver drm bridge mode first. As dp driver already have a ptn3460 bridge, so we need to move ptn bridge to the next bridge of dp bridge. Signed-off-by: Yakir Yang --- Changes in v4: - Take Romain suggest, rebase on linux

[PATCH v4 04/16] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count

2015-08-31 Thread Yakir Yang
2Gbps, 2.7Gbps, 5.4Gbps}. Signed-off-by: Yakir Yang --- Changes in v4: - Take Jingoo Han suggest, update commit message more readable. - Adjust the order from 05 to 04 Changes in v3: - Take Thierry Reding suggest, link_rate and lane_count shouldn't config to the DT property value directly,

[PATCH v4 05/16] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & colorimetry

2015-08-31 Thread Yakir Yang
() in to achieve the compatibility hacks. Signed-off-by: Yakir Yang --- Changes in v4: - Take Krzysztof suggest, provide backword compatibility with samsung. - Take Thierry suggest, add "color-depth" and "color-space" dynamic parsed. Changes in v3: - Take Thierry Reding su

[PATCH v4 06/16] Documentation: drm/bridge: add document for analogix_dp

2015-08-31 Thread Yakir Yang
Analogix dp driver is split from exynos dp driver, so we just make an copy of exynos_dp.txt, and then simplify exynos_dp.txt Beside update some exynos dtsi file with the latest change according to the devicetree binding documents. Signed-off-by: Yakir Yang --- Changes in v4: - Take Krzysztof

[PATCH v4 07/16] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver

2015-08-31 Thread Yakir Yang
provide the backward compatibility, so there are no bisectability break that make this change in a separate patch. Signed-off-by: Yakir Yang --- Changes in v4: - Take Krzysztof suggest, separate all DTS changes to a separate patch. Changes in v3: None Changes in v2: None arch/arm/boot/dts

[PATCH v4 08/16] drm: rockchip/dp: add rockchip platform dp driver

2015-08-31 Thread Yakir Yang
Rockchip have three clocks for dp controller, we leave pclk_edp to analogix_dp driver control, and keep the sclk_edp_24m and sclk_edp in platform driver. Signed-off-by: Yakir Yang --- Changes in v4: - Remove some deprecated DT properties in rockchip dp document. Changes in v3: - Take Thierry

[PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-08-31 Thread Yakir Yang
From: Mark Yao Add bpc and color mode setting in rockchip_drm_vop driver, so connector could try to use the edid drm_display_info to config vop output mode. Signed-off-by: Mark Yao Signed-off-by: Yakir Yang --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpu/drm

[PATCH v4 10/16] phy: Add driver for rockchip Display Port PHY

2015-08-31 Thread Yakir Yang
This phy driver would control the Rockchip DisplayPort module phy clock and phy power, it is relate to analogix_dp-rockchip dp driver. If you want DP works rightly on rockchip platform, then you should select both of them. Signed-off-by: Yakir Yang --- Changes in v4: - Take Kishon suggest, add

[PATCH v4 11/16] drm: bridge: analogix/dp: add platform device type support

2015-08-31 Thread Yakir Yang
Signed-off-by: Yakir Yang --- Changes in v4: None Changes in v3: None Changes in v2: - Add GNU license v2 declared and samsung copyright drivers/gpu/drm/exynos/exynos_dp.c | 1 + drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 + include/drm/bridge/analogix_dp.h

[PATCH v4 12/16] drm: bridge: analogix/dp: add some rk3288 special registers setting

2015-08-31 Thread Yakir Yang
RK3288 need some special registers setting, we can separate them out by the dev_type of plat_data. Signed-off-by: Yakir Yang --- Changes in v4: None Changes in v3: None Changes in v2: - Fix compile failed dut to phy_pd_addr variable misspell error drivers/gpu/drm/bridge/analogix

[PATCH v4 13/16] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288

2015-08-31 Thread Yakir Yang
There are some IP limit on rk3288 that only support 4 physical lanes of 2.7/1.6 Gbps/lane, so seprate them out by device_type flag. Signed-off-by: Yakir Yang --- Changes in v4: - Take Thierry suggest, seprate the link-rate and lane-count limit out with the device_type flag. Changes in v3

[PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-08-31 Thread Yakir Yang
Some edp screen do not have hpd signal, so we can't just return failed when hpd plug in detect failed. This is an hardware property, so we need add a devicetree property "analogix,need-force-hpd" to indicate this sutiation. Signed-off-by: Yakir Yang --- Changes in v4: None Chang

[PATCH v4 15/16] drm: bridge: analogix/dp: move hpd detect to connector detect function

2015-08-31 Thread Yakir Yang
This change just make a little clean to make code more like drm core expect, move hdp detect code from bridge->enable(), and place them into connector->detect(). Signed-off-by: Yakir Yang --- Changes in v4: - Take Jingoo suggest, add commit messages. Changes in v3: - move dp hpd det

[PATCH v4 16/16] drm: bridge: analogix/dp: add edid modes parse in get_modes method

2015-08-31 Thread Yakir Yang
Display Port monitor could support kinds of mode which indicate in monitor edid, not just one single display resolution which defined in panel or devivetree property display timing. Signed-off-by: Yakir Yang --- Changes in v4: - Call drm_panel_prepare() in .get_modes function, ensure panel

Re: [PATCH v4 08/16] drm: rockchip/dp: add rockchip platform dp driver

2015-09-01 Thread Yakir Yang
Hi Heiko, 在 2015/9/1 22:24, Heiko Stuebner 写道: Am Dienstag, 1. September 2015, 14:01:28 schrieb Yakir Yang: Rockchip have three clocks for dp controller, we leave pclk_edp to analogix_dp driver control, and keep the sclk_edp_24m and sclk_edp in platform driver. Signed-off-by: Yakir Yang

Re: [PATCH v4 10/16] phy: Add driver for rockchip Display Port PHY

2015-09-01 Thread Yakir Yang
Hi Heiko, 在 09/02/2015 12:51 AM, Heiko Stuebner 写道: Am Dienstag, 1. September 2015, 14:04:15 schrieb Yakir Yang: This phy driver would control the Rockchip DisplayPort module phy clock and phy power, it is relate to analogix_dp-rockchip dp driver. If you want DP works rightly on rockchip

Re: [PATCH v6 10/17] phy: Add driver for rockchip Display Port PHY

2015-10-12 Thread Yakir Yang
Hi Kishon On 10/12/2015 11:02 PM, Kishon Vijay Abraham I wrote: Hi, On Saturday 10 October 2015 09:25 PM, Yakir Yang wrote: This phy driver would control the Rockchip DisplayPort module phy clock and phy power, it is relate to analogix_dp-rockchip dp driver. If you want DP works rightly on

Re: [PATCH v6 11/17] Documentation: phy: add document for rockchip dp phy

2015-10-12 Thread Yakir Yang
Hi Kishon, On 10/13/2015 06:28 AM, Kishon Vijay Abraham I wrote: Hi, On Saturday 10 October 2015 09:28 PM, Yakir Yang wrote: This phy driver is binded with the Rockchip DisplayPort driver, here are the brief properties: edp_phy: edp-phy@ff770274 { compatible

Re: [PATCH v5 0/17] Add Analogix Core Display Port Driver

2015-10-13 Thread Yakir Yang
Hi Javierm On 10/13/2015 05:21 PM, Javier Martinez Canillas wrote: Hello Yakir, Sorry for the delay but I was on holidays. On 10/10/2015 04:31 PM, Yakir Yang wrote: Hi Javier, [snip] Maybe you can email me the method the run mainline kernel on Peach Pit, so I can debug the analogix_dp

Re: [PATCH v4 01/16] drm: exynos/dp: fix code style

2015-09-05 Thread Yakir Yang
Hi Joe, 在 09/03/2015 01:57 PM, Joe Perches 写道: On Thu, 2015-09-03 at 13:33 +0800, Yakir Yang wrote: [] diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c [] @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp

Re: [PATCH v4 05/16] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & colorimetry

2015-09-05 Thread Yakir Yang
Hi Krzysztof, 在 09/03/2015 04:04 PM, Krzysztof Kozlowski 写道: On 01.09.2015 14:55, Yakir Yang wrote: Both hsync/vsync polarity and interlace mode can be parsed from drm display mode, and dynamic_range and ycbcr_coeff can be judge by the video code, same to color space and color depth can be

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-05 Thread Yakir Yang
Hi Thierry, 在 09/03/2015 04:38 PM, Thierry Reding 写道: On Wed, Sep 02, 2015 at 06:02:25PM +0800, Yakir Yang wrote: 在 2015/9/2 16:34, Thierry Reding 写道: [...] At the very least your code must compile when applied against a recent upstream tree. I would also expect you to make sure the code

Re: [PATCH v4 11/16] drm: bridge: analogix/dp: add platform device type support

2015-09-05 Thread Yakir Yang
Hi Krzysztof, 在 09/04/2015 08:36 AM, Krzysztof Kozlowski 写道: On 01.09.2015 15:07, Yakir Yang wrote: Empty commit message. Please explain here why you want to add platform device type support. Actually the title is confusing. You are not adding support for platform device types but rather

Re: [PATCH v4 03/16] drm: bridge: analogix/dp: split exynos dp driver to bridge dir

2015-09-06 Thread Yakir Yang
Hi Krzysztof, 在 09/04/2015 08:41 AM, Krzysztof Kozlowski 写道: On 03.09.2015 14:30, Yakir Yang wrote: Hi Krzysztof, 在 09/03/2015 08:58 AM, Krzysztof Kozlowski 写道: On 01.09.2015 14:49, Yakir Yang wrote: Split the dp core driver from exynos directory to bridge directory, and rename the core

Re: [PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-09-06 Thread Yakir Yang
Hi Rob, 在 09/05/2015 05:46 AM, Rob Herring 写道: On Wed, Sep 2, 2015 at 11:27 PM, Yakir Yang wrote: Hi Rob, 在 09/03/2015 04:17 AM, Rob Herring 写道: On Tue, Sep 1, 2015 at 1:14 AM, Yakir Yang wrote: Some edp screen do not have hpd signal, so we can't just return failed when hpd plug in d

Re: [PATCH v4 11/16] drm: bridge: analogix/dp: add platform device type support

2015-09-06 Thread Yakir Yang
Hi Krzysztof, 在 09/07/2015 07:55 AM, Krzysztof Kozlowski 写道: On 06.09.2015 13:07, Yakir Yang wrote: Hi Krzysztof, 在 09/04/2015 08:36 AM, Krzysztof Kozlowski 写道: On 01.09.2015 15:07, Yakir Yang wrote: Empty commit message. Please explain here why you want to add platform device type support

Re: [PATCH v4 03/16] drm: bridge: analogix/dp: split exynos dp driver to bridge dir

2015-09-06 Thread Yakir Yang
Hi Krzysztof, 在 09/07/2015 08:22 AM, Krzysztof Kozlowski 写道: On 06.09.2015 16:49, Yakir Yang wrote: Hi Krzysztof, 在 09/04/2015 08:41 AM, Krzysztof Kozlowski 写道: On 03.09.2015 14:30, Yakir Yang wrote: Hi Krzysztof, 在 09/03/2015 08:58 AM, Krzysztof Kozlowski 写道: On 01.09.2015 14:49, Yakir

Re: [PATCH v4 03/16] drm: bridge: analogix/dp: split exynos dp driver to bridge dir

2015-09-01 Thread Yakir Yang
Heiko, 在 09/02/2015 04:46 AM, Heiko Stuebner 写道: Am Dienstag, 1. September 2015, 13:49:58 schrieb Yakir Yang: Split the dp core driver from exynos directory to bridge directory, and rename the core driver to analogix_dp_*, leave the platform code to analogix_dp-exynos. Signed-off-by: Yakir

Re: [PATCH v4 10/16] phy: Add driver for rockchip Display Port PHY

2015-09-01 Thread Yakir Yang
Hi Heiko, 在 09/02/2015 04:58 AM, Heiko Stuebner 写道: Hi Yakir, small nit more below Am Dienstag, 1. September 2015, 18:51:16 schrieb Heiko Stuebner: Am Dienstag, 1. September 2015, 14:04:15 schrieb Yakir Yang: +- clocks: from common clock binding: handle to dp clock. + of memory mapped

Re: [PATCH v4 08/16] drm: rockchip/dp: add rockchip platform dp driver

2015-09-01 Thread Yakir Yang
Hi Heiko, 在 09/02/2015 05:00 AM, Heiko Stuebner 写道: Hi Yakir, Am Dienstag, 1. September 2015, 14:01:28 schrieb Yakir Yang: Rockchip have three clocks for dp controller, we leave pclk_edp to analogix_dp driver control, and keep the sclk_edp_24m and sclk_edp in platform driver. Signed-off-by

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-01 Thread Yakir Yang
Hi Heiko, 在 09/02/2015 05:00 AM, Heiko Stuebner 写道: Hi Yakir, Am Dienstag, 1. September 2015, 14:01:48 schrieb Yakir Yang: From: Mark Yao Add bpc and color mode setting in rockchip_drm_vop driver, so connector could try to use the edid drm_display_info to config vop output mode. Signed-off

Re: [PATCH v4 0/16] Add Analogix Core Display Port Driver

2015-09-01 Thread Yakir Yang
Hi Heiko, 在 09/02/2015 05:47 AM, Heiko Stuebner 写道: Hi Yakir, Am Dienstag, 1. September 2015, 13:46:11 schrieb Yakir Yang: The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller share the same IP, so a lot of parts can be re-used. I split the common code into bridge

Re: [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting

2015-09-02 Thread Yakir Yang
Thierry, 在 2015/9/2 16:34, Thierry Reding 写道: On Wed, Sep 02, 2015 at 10:06:36AM +0800, Yakir Yang wrote: 在 09/02/2015 05:00 AM, Heiko Stuebner 写道: Am Dienstag, 1. September 2015, 14:01:48 schrieb Yakir Yang: [...] diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm

Re: [PATCH v4 10/16] phy: Add driver for rockchip Display Port PHY

2015-09-02 Thread Yakir Yang
Hi Rob, 在 09/02/2015 09:27 PM, Rob Herring 写道: On Tue, Sep 1, 2015 at 1:04 AM, Yakir Yang wrote: This phy driver would control the Rockchip DisplayPort module phy clock and phy power, it is relate to analogix_dp-rockchip dp driver. If you want DP works rightly on rockchip platform, then you

Re: [PATCH v4 03/16] drm: bridge: analogix/dp: split exynos dp driver to bridge dir

2015-09-02 Thread Yakir Yang
Hi Emil, 在 09/02/2015 10:50 PM, Emil Velikov 写道: [Dropping the CC list] Hmm...Don't understand what this means. If you can explain, that would be better, so I would not miss your suggest. :-) Hi Yakir Yang, On 1 September 2015 at 06:49, Yakir Yang wrote: Split the dp core driver

Re: [PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-09-02 Thread Yakir Yang
Hi Rob, 在 09/03/2015 04:17 AM, Rob Herring 写道: On Tue, Sep 1, 2015 at 1:14 AM, Yakir Yang wrote: Some edp screen do not have hpd signal, so we can't just return failed when hpd plug in detect failed. This is a property of the panel (or connector perhaps), so this property should be lo

Re: [PATCH v4 01/16] drm: exynos/dp: fix code style

2015-09-02 Thread Yakir Yang
Hi Krzysztof, 在 09/03/2015 08:21 AM, Krzysztof Kozlowski 写道: On 01.09.2015 14:46, Yakir Yang wrote: After run "checkpatch.pl -f --subjective" command, I see there are lots of alignment problem in exynos_dp driver, so let just fix them. Hi, Warnings from checkpatch are not a re

Re: [PATCH v4 03/16] drm: bridge: analogix/dp: split exynos dp driver to bridge dir

2015-09-02 Thread Yakir Yang
Hi Krzysztof, 在 09/03/2015 08:58 AM, Krzysztof Kozlowski 写道: On 01.09.2015 14:49, Yakir Yang wrote: Split the dp core driver from exynos directory to bridge directory, and rename the core driver to analogix_dp_*, leave the platform code to analogix_dp-exynos. Signed-off-by: Yakir Yang

Re: [PATCH v4 01/16] drm: exynos/dp: fix code style

2015-09-02 Thread Yakir Yang
Hi Krzysztof, 在 09/03/2015 01:08 PM, Krzysztof Kozlowski 写道: On 03.09.2015 14:04, Yakir Yang wrote: Hi Krzysztof, 在 09/03/2015 08:21 AM, Krzysztof Kozlowski 写道: On 01.09.2015 14:46, Yakir Yang wrote: After run "checkpatch.pl -f --subjective" command, I see there are lots of

Re: [PATCH v6 0/17] Add Analogix Core Display Port Driver

2015-10-19 Thread Yakir Yang
Hi Javier, On 10/19/2015 06:40 PM, Javier Martinez Canillas wrote: Hello Yakir, On 10/10/2015 05:35 PM, Yakir Yang wrote: Hi all, The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller share the same IP, so a lot of parts can be re-used. I split the common code into bridge

Re: [PATCH v6 0/17] Add Analogix Core Display Port Driver

2015-10-20 Thread Yakir Yang
Hi Javier, On 10/20/2015 05:48 PM, Javier Martinez Canillas wrote: Hello Yakir, On 10/20/2015 04:10 AM, Yakir Yang wrote: Hi Javier, On 10/19/2015 06:40 PM, Javier Martinez Canillas wrote: Hello Yakir, On 10/10/2015 05:35 PM, Yakir Yang wrote: Hi all, The Samsung Exynos eDP

[PATCH v7 0/17] Add Analogix Core Display Port Driver

2015-10-23 Thread Yakir Yang
sspell - Improved commit message more readable, and avoid using some uncommon style like bellow: (Joe Preches) - retval = exynos_dp_read_bytes_from_i2c(... ...); + retval = + exynos_dp_read_bytes_from_i2c(..); - Get panel node with remote-endpoi

[PATCH v7 01/17] drm: exynos: dp: convert to drm bridge mode

2015-10-23 Thread Yakir Yang
In order to move exynos dp code to bridge directory, we need to convert driver drm bridge mode first. As dp driver already have a ptn3460 bridge, so we need to move ptn bridge to the next bridge of dp bridge. Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None

[PATCH v7 03/17] drm: bridge: analogix/dp: fix some obvious code style

2015-10-23 Thread Yakir Yang
Fix some obvious alignment problems, like alignment and line over 80 characters problems, make this easy to be maintained later. Reviewed-by: Krzysztof Kozlowski Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: None Changes in v5

[PATCH v7 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range

2015-10-23 Thread Yakir Yang
: Krzysztof Kozlowski Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: - Back to use the of_property_read_bool() interfacs to provoid backward compatibility of "hsync-active-high" "vsync-active-high" "interlaced" to avoid -EOVERFLOW er

[PATCH v7 04/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count

2015-10-23 Thread Yakir Yang
2Gbps, 2.7Gbps, 5.4Gbps}. Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - Update commit message more readable. (Jingoo) - Adjust the order from 05 to 04 Changes in v3: - The link_rate and lane_count shou

[PATCH v7 07/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver

2015-10-23 Thread Yakir Yang
compatibility is fully preserved, so there are no bisectability break that make this change in a separate patch. Reviewed-by: Krzysztof Kozlowski Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: - Fix Peach Pit hpd property name error: - hpd

[PATCH v7 06/17] Documentation: drm/bridge: add document for analogix_dp

2015-10-23 Thread Yakir Yang
Analogix dp driver is split from exynos dp driver, so we just make an copy of exynos_dp.txt, and then simplify exynos_dp.txt Beside update some exynos dtsi file with the latest change according to the devicetree binding documents. Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang

[PATCH v7 08/17] drm: rockchip: dp: add rockchip platform dp driver

2015-10-23 Thread Yakir Yang
Rockchip have three clocks for dp controller, we leave pclk_edp to analogix_dp driver control, and keep the sclk_edp_24m and sclk_edp in platform driver. Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: None Changes in v5: - Remove the empty

[PATCH v7 09/17] Documentation: drm/bridge: add document for analogix_dp

2015-10-23 Thread Yakir Yang
Rockchip DP driver is a helper driver of analogix_dp coder driver, so most of the DT property should be descriped in analogix_dp document. Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: None Changes in v5: - Split binding doc's from d

[PATCH v7 10/17] phy: Add driver for rockchip Display Port PHY

2015-10-23 Thread Yakir Yang
Add phy driver for the Rockchip DisplayPort PHY module. This is required to get DisplayPort working in Rockchip SoCs. Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: - Simply the commit message. (Kishon) - Symmetrical enable/disbale the phy

[PATCH v7 11/17] Documentation: phy: add document for rockchip dp phy

2015-10-23 Thread Yakir Yang
Add dt binding documentation for rockchip display port PHY. Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: None Changes in v5: - Split binding doc's from driver changes. (Rob) - Update the rockchip,grf explain in document, and correc

[PATCH v7 13/17] drm: bridge: analogix/dp: add some rk3288 special registers setting

2015-10-23 Thread Yakir Yang
RK3288 need some special registers setting, we can separate them out by the dev_type of plat_data. Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Fix compile failed dut to phy_pd_addr variable

[PATCH v7 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

2015-10-23 Thread Yakir Yang
Some edp screen do not have hpd signal, so we can't just return failed when hpd plug in detect failed. This is an hardware property, so we need add a devicetree property "analogix,need-force-hpd" to indicate this sutiation. Tested-by: Javier Martinez Canillas Signed-off

[PATCH v7 12/17] drm: rockchip: vop: add bpc and color mode setting

2015-10-23 Thread Yakir Yang
From: Mark Yao Add bpc and color mode setting in rockchip_drm_vop driver, so connector could try to use the edid drm_display_info to config vop output mode. Signed-off-by: Mark Yao Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: None Changes in v5: - Fix compiled error (Heiko

[PATCH v7 14/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288

2015-10-23 Thread Yakir Yang
There are some IP limit on rk3288 that only support 4 physical lanes of 2.7/1.6 Gbps/lane, so seprate them out by device_type flag. Tested-by: Javier Martinez Canillas Signed-off-by: Yakir Yang --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: - Seprate the link

  1   2   3   4   5   6   7   8   >