Re: [PATCH] x86/mce: Keep quiet in case of broadcasted mce after system panic

2017-02-16 Thread Xunlei Pang
On 02/16/2017 at 06:18 PM, Borislav Petkov wrote: > On Thu, Feb 16, 2017 at 01:36:37PM +0800, Xunlei Pang wrote: >> I tried to use qemu to inject SRAO("mce -b 0 0 0xb100 0x5 0x0 >> 0x0"), >> it works well in 1st kernel, but it doesn't work for 1s

Re: [PATCH] x86/mce: Keep quiet in case of broadcasted mce after system panic

2017-02-16 Thread Xunlei Pang
On 02/16/2017 at 08:22 PM, Borislav Petkov wrote: > On Thu, Feb 16, 2017 at 07:52:09PM +0800, Xunlei Pang wrote: >> then mce will be broadcast to the other cpus which are still running >> in the first kernel(i.e. looping in crash_nmi_callback). > Simple: the crash code

Re: [PATCH] x86/mce: Keep quiet in case of broadcasted mce after system panic

2017-02-17 Thread Xunlei Pang
On 02/17/2017 at 05:07 PM, Borislav Petkov wrote: > On Fri, Feb 17, 2017 at 09:53:21AM +0800, Xunlei Pang wrote: >> It changes the value of cpu_online_mask/etc which will cause confusion to >> vmcore analysis. > Then export the crashing_cpu variable, initialize it to somethin

[PATCH v2] x86/mce: Don't participate in rendezvous process once nmi_shootdown_cpus() was made

2017-02-19 Thread Xunlei Pang
://patchwork.kernel.org/patch/6167631/ https://lists.gt.net/linux/kernel/2146557 Cc: Naoya Horiguchi Suggested-by: Borislav Petkov Signed-off-by: Xunlei Pang --- v1->v2: Using crashing_cpu according to Borislav's suggestion. arch/x86/include/asm/reboot.h| 1 + arch/x86/kernel/cpu/mcheck/mc

Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once nmi_shootdown_cpus() was made

2017-02-20 Thread Xunlei Pang
On 02/20/2017 at 07:09 PM, Borislav Petkov wrote: > On Mon, Feb 20, 2017 at 02:10:37PM +0800, Xunlei Pang wrote: >> @@ -1128,8 +1129,9 @@ void do_machine_check(struct pt_regs *regs, long >> error_code) >> */ >> int lmce = 1; >> >> -/

Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once nmi_shootdown_cpus() was made

2017-02-20 Thread Xunlei Pang
On 02/20/2017 at 09:29 PM, Xunlei Pang wrote: > On 02/20/2017 at 07:09 PM, Borislav Petkov wrote: >> On Mon, Feb 20, 2017 at 02:10:37PM +0800, Xunlei Pang wrote: >>> @@ -1128,8 +1129,9 @@ void do_machine_check(struct pt_regs *regs, long >>> error_code) >&

Re: [PATCH v2] x86/mce: Don't participate in rendezvous process once nmi_shootdown_cpus() was made

2017-02-20 Thread Xunlei Pang
On 02/21/2017 at 04:26 AM, Borislav Petkov wrote: > On Mon, Feb 20, 2017 at 09:29:24PM +0800, Xunlei Pang wrote: >> There is a small window between crash and kdump kernel boot, so >> if a SRAO comes within this window it will also cause the mce >> synchronization problem on t

Re: [PATCH] Add +~800M crashkernel explaination

2017-01-11 Thread Xunlei Pang
On 01/12/2017 at 03:35 AM, Robert LeBlanc wrote: > On Wed, Dec 14, 2016 at 4:17 PM, Xunlei Pang wrote: >> As I replied in another post, if you really want to detail the behaviour, >> should mention >> "crashkernel=size[KMG][@offset[KMG]]" with @offset[KMG] specifi

Re: [PATCH][RFC v4] timekeeping: ignore the bogus sleep time if pm_trace is enabled

2016-08-27 Thread Xunlei Pang
t; 1. rtc is used as persist clock to compensate for sleep time, >(because system does not have a nonstop clocksource) or > 2. rtc is used to calculate the sleep time in rtc_resume. > > Cc: Rafael J. Wysocki > Cc: John Stultz > Cc: Thomas Gleixner > Cc: Xunlei

[PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle()

2016-07-09 Thread Xunlei Pang
Should update "cfs_rq->throttled_clock_task" other than pcfs_rq's. Signed-off-by: Xunlei Pang --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 4088eed..039de34 100644 --- a/kernel/

Re: [PATCH v3] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-10 Thread Xunlei Pang
On 2016/07/08 at 19:28, Juri Lelli wrote: > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them, under a different name, to setup a new dl_entity, after: > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" > > as we currently do > > setup_ne

Re: [PATCH v3] sched/deadline: remove useless param from setup_new_dl_entity

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 16:01, luca abeni wrote: > Hello, > > On Mon, 11 Jul 2016 13:03:56 +0800 > Xunlei Pang wrote: > >> On 2016/07/08 at 19:28, Juri Lelli wrote: > [...] >>> @@ -363,6 +364,15 @@ static inline void setup_new_dl_entity(struct &

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 15:25, Wanpeng Li wrote: > 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : >> Hierarchy could be already throttled at this point. Throttled next >> buddy could trigger null pointer dereference in pick_next_task_fair(). > There is cfs_rq->next check in pick_next_entity(), so how

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 16:22, Xunlei Pang wrote: > On 2016/07/11 at 15:25, Wanpeng Li wrote: >> 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov : >>> Hierarchy could be already throttled at this point. Throttled next >>> buddy could trigger null pointer dereference in pick_ne

Re: [PATCH] sched/fair: do not announce throttled next buddy in dequeue_task_fair

2016-07-11 Thread Xunlei Pang
On 2016/07/11 at 17:54, Wanpeng Li wrote: > Hi Konstantin, Xunlei, > 2016-07-11 16:42 GMT+08:00 Xunlei Pang : >> On 2016/07/11 at 16:22, Xunlei Pang wrote: >>> On 2016/07/11 at 15:25, Wanpeng Li wrote: >>>> 2016-06-16 20:57 GMT+08:00 Konstantin Khlebnikov >&g

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-11 Thread Xunlei Pang
On 2016/07/05 at 19:33, Hidehiro Kawai wrote: > This patch fixes one of the problems reported by Daniel Walker > (https://lkml.org/lkml/2015/6/24/44). > > If crash_kexec_post_notifiers boot option is specified, other CPUs > are stopped by smp_send_stop() instead of machine_crash_shutdown() > in cra

Re: [PATCH v2] kexec: Fix kdump failure with notsc

2016-07-11 Thread Xunlei Pang
On 2016/07/07 at 18:17, Wei Jiangang wrote: > If we specify the 'notsc' boot parameter for the dump-capture kernel, > and then trigger a crash(panic) by using "ALT-SysRq-c" or "echo c > > /proc/sysrq-trigger", > the dump-capture kernel will hang in calibrate_delay_converge(): > > /* wait for "s

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-11 Thread Xunlei Pang
On 2016/07/12 at 11:56, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi Xunlei, > > Thanks for the review. > >> From: Xunlei Pang [mailto:xp...@redhat.com] >> Sent: Tuesday, July 12, 2016 12:12 PM >> On 2016/07/05 at 19:33, Hidehiro Kawai wrote: >>> This patch fixes one of

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-12 Thread Xunlei Pang
On 2016/07/12 at 15:12, 河合英宏 / KAWAI,HIDEHIRO wrote: >> From: linux-kernel-ow...@vger.kernel.org >> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Xunlei Pang >> Sent: Tuesday, July 12, 2016 3:57 PM >> On 2016/07/12 at 11:56, 河合英宏 / KAWAI,HIDEHIRO wrote: >&

Re: [PATCH v7 2/2] Documentation: kdump: add description of enable multi-cpus support

2016-08-17 Thread Xunlei Pang
On 2016/08/18 at 09:50, Zhou Wenjian wrote: > multi-cpu support is useful to improve the performance of kdump in > some cases. So add the description of enable multi-cpu support in > dump-capture kernel. > > Signed-off-by: Zhou Wenjian > Acked-by: Baoquan He > --- > Documentation/kdump/kdump.txt

[PATCH] fib_trie: Fix the description of pos and bits

2016-08-17 Thread Xunlei Pang
1) Fix one typo: s/tn/tp/ 2) Fix the description about the "u" bits. Signed-off-by: Xunlei Pang --- net/ipv4/fib_trie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index d07fc07..eb7c5d1 100644 --- a/net/ipv4/fib_tr

Re: [PATCH][RFC v4] timekeeping: ignore the bogus sleep time if pm_trace is enabled

2016-08-18 Thread Xunlei Pang
On 2016/08/18 at 18:36, Oliver Neukum wrote: > On Thu, 2016-08-18 at 18:43 +0800, Chen Yu wrote: >> Previously we encountered some memory overflow issues due to >> the bogus sleep time brought by inconsistent rtc, which is >> triggered when pm_trace is enabled, please refer to: >> https://patchwork

Re: [patch] kexec: potetially using uninitialized variable

2016-03-11 Thread Xunlei Pang
Hi Dan, On 2016/03/11 at 16:07, Dan Carpenter wrote: > At the end of the function we check if "ret" has a negative error code, > but it seems possible that it is uninitialized. > > Fixes: 12db5562e035 ('kexec: load and relocate purgatory at kernel load time') > Signed-off-by: Dan Carpenter > > di

Re: [PATCH V2] proc-vmcore: wrong data type casting fix

2016-03-12 Thread Xunlei Pang
On 2016/03/12 at 12:49, Dave Young wrote: > Hi, Andrew > > On 03/11/16 at 12:27pm, Andrew Morton wrote: >> On Fri, 11 Mar 2016 16:42:48 +0800 Dave Young wrote: >> >>> On i686 PAE enabled machine the contiguous physical area could be large >>> and it can cause trimming down variables in below calcu

Re: [PATCH V2] proc-vmcore: wrong data type casting fix

2016-03-12 Thread Xunlei Pang
On 2016/03/12 at 21:59, Baoquan He wrote: > On 03/12/16 at 08:43pm, Xunlei Pang wrote: >> On 2016/03/12 at 12:49, Dave Young wrote: >>> Hi, Andrew >>> >>> On 03/11/16 at 12:27pm, Andrew Morton wrote: >>>> On Fri, 11 Mar 2016 16:42:48 +0800 Dave Youn

Re: [PATCH] iommu/vt-d: Assign old irt entries a common valid vector in kdump kernel

2016-03-02 Thread Xunlei Pang
On 03/02/2016 at 10:58 PM, Joerg Roedel wrote: > On Wed, Mar 02, 2016 at 06:02:28PM +0800, Xunlei Pang wrote: >> Currently, the kernel copies the old irt entries during iommu >> initialization for kdump, so old vectors in the first kernel are >> used but having no related ke

Re: [PATCH V2 0/2] kexec: Make a pair of map/unmap reserved pages in error path

2016-03-22 Thread Xunlei Pang
On 2016/03/23 at 10:48, Baoquan He wrote: > On 03/01/16 at 05:53pm, Xunlei Pang wrote: >> This is a bug fix. >> >> After this, I will try to do a cleanup for crash_unmap/map_reserved_pages() >> (only used by S390) to consolidate it with >> arch_kexec_unprotect

Re: [PATCH V2 0/2] kexec: Make a pair of map/unmap reserved pages in error path

2016-03-23 Thread Xunlei Pang
On 2016/03/23 at 16:23, Baoquan He wrote: > On 03/23/16 at 11:32am, Xunlei Pang wrote: >> On 2016/03/23 at 10:48, Baoquan He wrote: >>> On 03/01/16 at 05:53pm, Xunlei Pang wrote: >>>> This is a bug fix. >>>> >>>> After this, I will

Re: [PATCH V2 0/2] kexec: Make a pair of map/unmap reserved pages in error path

2016-03-24 Thread Xunlei Pang
On 2016/03/23 at 20:32, Baoquan He wrote: > On 03/23/16 at 05:59pm, Xunlei Pang wrote: >> On 2016/03/23 at 16:23, Baoquan He wrote: >>> On 03/23/16 at 11:32am, Xunlei Pang wrote: >>>> On 2016/03/23 at 10:48, Baoquan He wrote: >>>>> On 03/01/16 at 05:

Re: [PATCH V2 0/2] kexec: Make a pair of map/unmap reserved pages in error path

2016-03-01 Thread Xunlei Pang
This is a bug fix. After this, I will try to do a cleanup for crash_unmap/map_reserved_pages() (only used by S390) to consolidate it with arch_kexec_unprotect/protect_crashkres(). Regards, Xunlei On 03/01/2016 at 04:02 PM, Minfei Huang wrote: > v1: > - Bisect the patch according to Andrew Morto

[PATCH] iommu/vt-d: Assign old irt entries a common valid vector in kdump kernel

2016-03-02 Thread Xunlei Pang
he old irt entries to use a special allocated vector and related irq handler. Signed-off-by: Xunlei Pang --- drivers/iommu/intel_irq_remapping.c | 78 - 1 file changed, 68 insertions(+), 10 deletions(-) diff --git a/drivers/iommu/intel_irq_remapping.c b/dri

[PATCH] workqueue: Free useless memory when disabling NUMA in wq_numa_init()

2015-09-16 Thread Xunlei Pang
From: Xunlei Pang wq_update_unbound_numa_attrs_buf and tbl will never be used in case of invalid NUMA node mapping, so just free them. Signed-off-by: Xunlei Pang --- kernel/workqueue.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index

[PATCH 1/2] kexec: Introduce a protection mechanism for the crashkernel reserved memory

2015-12-23 Thread Xunlei Pang
architecture can make its specific implementation by overriding arch_kexec_protect_crashkres() and arch_kexec_unprotect_crashkres(). Signed-off-by: Xunlei Pang --- include/linux/kexec.h | 2 ++ kernel/kexec.c| 9 - kernel/kexec_core.c | 6 ++ kernel/kexec_file.c | 8 +++- 4

[PATCH 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2015-12-23 Thread Xunlei Pang
Implement the protection method for the crash kernel memory reservation for the 64-bit x86 kdump. Signed-off-by: Xunlei Pang --- Only provided x86_64 implementation, as I've only tested on x86_64 so far. arch/x86/kernel/machine_kexec_64.c | 43 ++ 1

Re: [PATCH 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2015-12-23 Thread Xunlei Pang
On 12/24/2015 at 01:54 PM, Dave Young wrote: > Ccing Vivek > > On 12/23/15 at 07:12pm, Xunlei Pang wrote: >> Implement the protection method for the crash kernel memory >> reservation for the 64-bit x86 kdump. >> >> Signed-off-by: Xunlei Pang >> --- >>

Re: [PATCH 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2015-12-23 Thread Xunlei Pang
On 12/24/2015 at 02:16 PM, Dave Young wrote: > Hi, Xunlei > > On 12/24/15 at 02:05pm, Xunlei Pang wrote: >> On 12/24/2015 at 01:54 PM, Dave Young wrote: >>> Ccing Vivek >>> >>> On 12/23/15 at 07:12pm, Xunlei Pang wrote: >>>> Imple

Re: [PATCH 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2015-12-27 Thread Xunlei Pang
On 12/24/2015 at 02:44 PM, Xunlei Pang wrote: > On 12/24/2015 at 02:16 PM, Dave Young wrote: >> Hi, Xunlei >> >> On 12/24/15 at 02:05pm, Xunlei Pang wrote: >>> On 12/24/2015 at 01:54 PM, Dave Young wrote: >>>> Ccing Vivek >>>> >>>&

Re: [PATCH 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2015-12-29 Thread Xunlei Pang
On 12/28/2015 at 08:14 PM, Minfei Huang wrote: > On 12/28/15 at 02:32pm, Xunlei Pang wrote: >> On 12/24/2015 at 02:44 PM, Xunlei Pang wrote: >>>>>>> +static void kexec_mark_crashkres(bool protect) >>>>>>> +{ >>>>>>> +

Re: [PATCH] kexec: unmap reserved pages for each error-return way

2016-01-28 Thread Xunlei Pang
On 2016/01/28 at 18:32, Michael Holzheu wrote: > On Wed, 27 Jan 2016 11:15:46 -0800 > Andrew Morton wrote: > >> On Wed, 27 Jan 2016 14:48:31 +0300 Dmitry Safonov >> wrote: >> >>> For allocation of kimage failure or kexec_prepare or load segments >>> errors there is no need to keep crashkernel me

Re: [PATCH] kexec: unmap reserved pages for each error-return way

2016-01-28 Thread Xunlei Pang
On 2016/01/28 at 20:44, Michael Holzheu wrote: > On Thu, 28 Jan 2016 19:56:56 +0800 > Xunlei Pang wrote: > >> On 2016/01/28 at 18:32, Michael Holzheu wrote: >>> On Wed, 27 Jan 2016 11:15:46 -0800 >>> Andrew Morton wrote: >>> >>>> On Wed,

Re: [PATCH] kexec: unmap reserved pages for each error-return way

2016-01-28 Thread Xunlei Pang
On 2016/01/28 at 17:02, Dmitry Safonov wrote: > On 01/28/2016 05:58 AM, Xunlei Pang wrote: >> Hi Dmitry, >> >> On 2016/01/28 at 03:15, Andrew Morton wrote: >>> On Wed, 27 Jan 2016 14:48:31 +0300 Dmitry Safonov >>> wrote: >>> >>>&g

[PATCH] kexec: Move some memembers and definitions within the scope of CONFIG_KEXEC_FILE

2015-12-20 Thread Xunlei Pang
Move the stuff currently only used by the kexec file code within CONFIG_KEXEC_FILE (and CONFIG_KEXEC_VERIFY_SIG). Also move internal "struct kexec_sha_region" and "struct kexec_buf" into "kexec_internal.h". Signed-off-by: Xunlei Pang --- arch/x86/kernel/machi

Re: [PATCH] kexec: Move some memembers and definitions within the scope of CONFIG_KEXEC_FILE

2015-12-22 Thread Xunlei Pang
On 12/22/2015 at 06:47 PM, Minfei Huang wrote: > On 12/21/15 at 02:09pm, Xunlei Pang wrote: >> diff --git a/include/linux/kexec.h b/include/linux/kexec.h >> index 7b68d27..2cc643c 100644 >> --- a/include/linux/kexec.h >> +++ b/include/linux/kexec.h >

Re: [PATCH] kexec: unmap reserved pages for each error-return way

2016-01-27 Thread Xunlei Pang
On 2016/01/27 at 19:48, Dmitry Safonov wrote: > For allocation of kimage failure or kexec_prepare or load segments > errors there is no need to keep crashkernel memory mapped. > It will affect only s390 as map/unmap hook defined only for it. > As on unmap s390 also changes os_info structure let's c

[PATCH v2 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2016-01-06 Thread Xunlei Pang
Implement the protection method for the crash kernel memory reservation for the 64-bit x86 kdump. Signed-off-by: Xunlei Pang --- arch/x86/kernel/machine_kexec_64.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/arch/x86/kernel/machine_kexec_64.c b

[PATCH v2 1/2] kexec: Introduce a protection mechanism for the crashkernel reserved memory

2016-01-06 Thread Xunlei Pang
architecture can make its specific implementation by overriding arch_kexec_protect_crashkres() and arch_kexec_unprotect_crashkres(). Signed-off-by: Xunlei Pang --- include/linux/kexec.h | 2 ++ kernel/kexec.c| 9 - kernel/kexec_core.c | 6 ++ kernel/kexec_file.c | 8 +++- 4

Re: [PATCH v2 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2016-01-06 Thread Xunlei Pang
On 01/07/2016 at 01:08 AM, Minfei Huang wrote: > On 01/06/16 at 05:50pm, Xunlei Pang wrote: >> diff --git a/arch/x86/kernel/machine_kexec_64.c >> b/arch/x86/kernel/machine_kexec_64.c >> index 819ab3f..cda867d 100644 >> --- a/arch/x86/kernel/machine_kexec_64

Re: [PATCH v2 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2016-01-06 Thread Xunlei Pang
On 01/07/2016 at 10:14 AM, Xunlei Pang wrote: > On 01/07/2016 at 01:08 AM, Minfei Huang wrote: >> On 01/06/16 at 05:50pm, Xunlei Pang wrote: >>> diff --git a/arch/x86/kernel/machine_kexec_64.c >>> b/arch/x86/kernel/machine_kexec_64.c >>> index 819ab3f..cda8

Re: [PATCH v2 2/2] kexec: Provide arch_kexec_protect(unprotect)_crashkres()

2016-01-06 Thread Xunlei Pang
On 01/07/2016 at 10:36 AM, Minfei Huang wrote: > On 01/07/16 at 10:14am, Xunlei Pang wrote: >>>> +static int >>>> +kexec_mark_range(unsigned long start, unsigned long end, bool protect) >>>> +{ >>>> + struct page *page; >>>> + unsi

[PATCH 2/2] mm/slub: Get rid of count_partial()

2020-07-02 Thread Xunlei Pang
Now the partial counters are ready, let's use them directly and get rid of count_partial(). Co-developed-by: Wen Yang Signed-off-by: Xunlei Pang --- mm/slub.c | 57 - 1 file changed, 24 insertions(+), 33 deletions(-) diff --git

[PATCH 1/2] mm/slub: Introduce two counters for the partial objects

2020-07-02 Thread Xunlei Pang
impact is minimal. Co-developed-by: Wen Yang Signed-off-by: Xunlei Pang --- mm/slab.h | 2 ++ mm/slub.c | 38 +- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/mm/slab.h b/mm/slab.h index 7e94700..5935749 100644 --- a/mm/slab.h +++ b/mm/slab.h

[PATCH] mm: memcg: Fix memcg reclaim soft lockup

2020-08-26 Thread Xunlei Pang
eginning of shrink_lruvec() to give up the cpu to others. Signed-off-by: Xunlei Pang --- mm/vmscan.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 99e1796..349a88e 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2449,6 +2449,12 @@ static void shrink_lru

Re: [PATCH] mm: memcg: Fix memcg reclaim soft lockup

2020-08-26 Thread Xunlei Pang
On 2020/8/26 下午7:45, xunlei wrote: > On 2020/8/26 下午7:00, Michal Hocko wrote: >> On Wed 26-08-20 18:41:18, xunlei wrote: >>> On 2020/8/26 下午4:11, Michal Hocko wrote: >>>> On Wed 26-08-20 15:27:02, Xunlei Pang wrote: >>>>> We've met softlockup w

[PATCH v2] mm: memcg: Fix memcg reclaim soft lockup

2020-08-26 Thread Xunlei Pang
de_memcgs() to solve this issue, and any other possible issue like meomry.min protection. Suggested-by: Michal Hocko Signed-off-by: Xunlei Pang --- mm/vmscan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index 99e1796..bbdc38b 100644 --- a/mm/vmscan.c +++ b/mm/vm

[PATCH v3] mm: memcg: Fix memcg reclaim soft lockup

2020-08-26 Thread Xunlei Pang
de_memcgs() to solve this issue, this will mean that we will get a scheduling point for each memcg in the reclaimed hierarchy without any dependency on the reclaimable memory in that memcg thus making it more predictable. Acked-by: Chris Down Acked-by: Michal Hocko Suggested-by: Michal Hocko S

Re: [PATCH] sched/fair: Fix wrong cpu selecting from isolated domain

2020-08-27 Thread Xunlei Pang
On 2020/8/24 PM8:30, Xunlei Pang wrote: > We've met problems that occasionally tasks with full cpumask > (e.g. by putting it into a cpuset or setting to full affinity) > were migrated to our isolated cpus in production environment. > > After some analysis, we found that it i

[PATCH] sched/fair: Fix wrong cpu selecting from isolated domain

2020-08-24 Thread Xunlei Pang
omain mask. Fix it by checking the valid domain mask in select_idle_smt(). Fixes: 10e2f1acd010 ("sched/core: Rewrite and improve select_idle_siblings()) Reported-by: Wetp Zhang Signed-off-by: Xunlei Pang --- kernel/sched/fair.c | 9 + 1 file changed, 5 insertions(+), 4 deletion

Re: [PATCH] mm: memcg: yield cpu when we fail to charge pages

2020-09-13 Thread Xunlei Pang
On 2020/9/9 AM2:50, Julius Hemanth Pitti wrote: > For non root CG, in try_charge(), we keep trying > to charge until we succeed. On non-preemptive > kernel, when we are OOM, this results in holding > CPU forever. > > On SMP systems, this doesn't create a big problem > because oom_reaper get a chan

[PATCH RESEND] sched/fair: Fix wrong cpu selecting from isolated domain

2020-09-23 Thread Xunlei Pang
ing the valid domain mask in select_idle_smt(). Fixes: 10e2f1acd010 ("sched/core: Rewrite and improve select_idle_siblings()) Reported-by: Wetp Zhang Reviewed-by: Jiang Biao Signed-off-by: Xunlei Pang --- kernel/sched/fair.c | 9 + 1 file changed, 5 insertions(+), 4 deletions

Re: [PATCH RESEND] sched/fair: Fix wrong cpu selecting from isolated domain

2020-09-24 Thread Xunlei Pang
On 9/24/20 3:18 PM, Vincent Guittot wrote: > On Thu, 24 Sep 2020 at 08:48, Xunlei Pang wrote: >> >> We've met problems that occasionally tasks with full cpumask >> (e.g. by putting it into a cpuset or setting to full affinity) >> were migrated to our isolate

[PATCH] memcg: Ignore unprotected parent in mem_cgroup_protected()

2019-06-15 Thread Xunlei Pang
in this scenario to achieve the flexibility. In order not to break previous hierarchical behaviour, only ignore the parent when there's no protected ancestor upwards the hierarchy. Signed-off-by: Xunlei Pang --- include/linux/page_counter.h | 2 ++ mm/memcontrol.c | 5 + mm/p

[PATCH] psi: Don't account force reclaim as memory pressure

2019-06-15 Thread Xunlei Pang
this patch. Signed-off-by: Xunlei Pang --- include/linux/swap.h | 3 ++- mm/memcontrol.c | 13 +++-- mm/vmscan.c | 9 ++--- 3 files changed, 15 insertions(+), 10 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 4bfb5c4ac108..74b5443877d4 10

Re: [PATCH] psi: Don't account force reclaim as memory pressure

2019-06-15 Thread Xunlei Pang
Hi Chris, On 2019/6/15 PM 11:58, Chris Down wrote: > Hi Xunlei, > > Xunlei Pang writes: >> There're several cases like resize and force_empty that don't >> need to account to psi, otherwise is misleading. > > I'm afraid I'm quite confused by this

Re: [PATCH] memcg: Ignore unprotected parent in mem_cgroup_protected()

2019-06-15 Thread Xunlei Pang
Hi Chirs, On 2019/6/16 AM 12:08, Chris Down wrote: > Hi Xunlei, > > Xunlei Pang writes: >> Currently memory.min|low implementation requires the whole >> hierarchy has the settings, otherwise the protection will >> be broken. >> >> Our hierarchy is ki

Re: [PATCH] memcg: Ignore unprotected parent in mem_cgroup_protected()

2019-06-16 Thread Xunlei Pang
Hi Chris, On 2019/6/16 PM 6:37, Chris Down wrote: > Hi Xunlei, > > Xunlei Pang writes: >> docker and various types(different memory capacity) of containers >> are managed by k8s, it's a burden for k8s to maintain those dynamic >> figures, simply set "max

[PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section

2017-04-20 Thread Xunlei Pang
se vmcoreinfo now is kept far away from other kernel data structures. Suggested-by: Eric Biederman Cc: Michael Holzheu Cc: Juergen Gross Signed-off-by: Xunlei Pang --- v3->v4: -Rebased on the latest linux-next -Handle S390 vmcoreinfo_note properly -Handle the newly-added xen/mmu_

[PATCH v4 3/3] kdump: Protect vmcoreinfo data under the crash memory

2017-04-20 Thread Xunlei Pang
and update to use this new one instead in the following crash_save_vmcoreinfo(). BTW, we do not touch vmcoreinfo_note, because it will be fully updated using the protected vmcoreinfo_data after crash which is surely correct just like the cpu crash note. Cc: Michael Holzheu Signed-off-by: Xunlei Pan

[PATCH v4 2/3] powerpc/fadump: Use the correct VMCOREINFO_NOTE_SIZE for phdr

2017-04-20 Thread Xunlei Pang
ter fix it, also this change should be safe and backward compatible. After this, we can get rid of variable vmcoreinfo_max_size, let's use the corresponding macros directly, fewer variables means more safety for vmcoreinfo operation. Cc: Mahesh Salgaonkar Cc: Hari Bathini Signed-off-by: Xunlei P

Re: [PATCH v4 2/3] powerpc/fadump: Use the correct VMCOREINFO_NOTE_SIZE for phdr

2017-04-20 Thread Xunlei Pang
Cc "Michael Holzheu" On 04/20/2017 at 07:39 PM, Xunlei Pang wrote: > vmcoreinfo_max_size stands for the vmcoreinfo_data, the > correct one we should use is vmcoreinfo_note whose total > size is VMCOREINFO_NOTE_SIZE. > > Like explained in commit 77019967f06b ("

Re: [PATCH 1/2] x86/mm/ident_map: Add PUD level 1GB page support

2017-04-25 Thread Xunlei Pang
On 04/26/2017 at 03:49 AM, Yinghai Lu wrote: > On Tue, Apr 25, 2017 at 2:13 AM, Xunlei Pang wrote: >> The current kernel_ident_mapping_init() creates the identity >> mapping using 2MB page(PMD level), this patch adds the 1GB >> page(PUD level) support. >> >> Th

[PATCH v2 1/2] x86/mm/ident_map: Add PUD level 1GB page support

2017-04-26 Thread Xunlei Pang
booting into the new kernel. We will utilize this new support in the following patch. Signed-off-by: Xunlei Pang --- v1->v2: - Rename info.use_pud_page to info.direct_gbpages - Align PUD_MASK before set_pud() arch/x86/boot/compressed/pagetable.c | 2 +- arch/x86/include/asm/init.h |

[PATCH v2 2/2] x86_64/kexec: Use PUD level 1GB page for identity mapping if available

2017-04-26 Thread Xunlei Pang
tity mapping pgtable for kdump if 1GB feature is available. Signed-off-by: Xunlei Pang --- arch/x86/kernel/machine_kexec_64.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c index 1d4f2b0..613df62 100644 -

Re: [PATCH v2 1/2] x86/mm/ident_map: Add PUD level 1GB page support

2017-04-26 Thread Xunlei Pang
On 04/26/2017 at 04:09 PM, Ingo Molnar wrote: > * Xunlei Pang wrote: > >> The current kernel_ident_mapping_init() creates the identity >> mapping using 2MB page(PMD level), this patch adds the 1GB >> page(PUD level) support. >> >> This is useful on large m

Re: [PATCH v4 3/3] kdump: Protect vmcoreinfo data under the crash memory

2017-04-26 Thread Xunlei Pang
On 04/26/2017 at 03:09 PM, Dave Young wrote: > On 04/20/17 at 07:39pm, Xunlei Pang wrote: >> Currently vmcoreinfo data is updated at boot time subsys_initcall(), >> it has the risk of being modified by some wrong code during system >> is running. >> >> As a resu

Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section

2017-04-26 Thread Xunlei Pang
On 04/26/2017 at 03:19 PM, Dave Young wrote: > Add ia64i list, and s390 list although Michael has tested it > > On 04/20/17 at 07:39pm, Xunlei Pang wrote: >> As Eric said, >> "what we need to do is move the variable vmcoreinfo_note out >> of the kernel's

Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section

2017-04-26 Thread Xunlei Pang
On 04/26/2017 at 05:51 PM, Xunlei Pang wrote: > On 04/26/2017 at 03:19 PM, Dave Young wrote: >> Add ia64i list, and s390 list although Michael has tested it >> >> On 04/20/17 at 07:39pm, Xunlei Pang wrote: >>> As Eric said, >>> "what we need to do is

Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section

2017-04-26 Thread Xunlei Pang
On 04/27/2017 at 11:06 AM, Dave Young wrote: > [snip] > > static int __init crash_save_vmcoreinfo_init(void) > { > + /* One page should be enough for VMCOREINFO_BYTES under all archs */ Can we add a comment in the VMCOREINFO_BYTES header file about the one page assumpt

Re: [PATCH v4 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section

2017-04-26 Thread Xunlei Pang
On 04/27/2017 at 01:44 PM, Dave Young wrote: > Hi Xunlei, > > On 04/27/17 at 01:25pm, Xunlei Pang wrote: >> On 04/27/2017 at 11:06 AM, Dave Young wrote: >>> [snip] >>>>>>> >>>>>>> static int __init crash_save_vmcoreinfo_init

[PATCH v5 1/3] kexec: Move vmcoreinfo out of the kernel's .bss section

2017-04-27 Thread Xunlei Pang
se vmcoreinfo now is kept far away from other kernel data structures. Cc: Juergen Gross Suggested-by: Eric Biederman Tested-by: Michael Holzheu Reviewed-by: Juergen Gross Signed-off-by: Xunlei Pang --- v4->v5: Changed VMCOREINFO_BYTES definition to PAGE_SIZE according to Dave's comm

[PATCH v5 2/3] powerpc/fadump: Use the correct VMCOREINFO_NOTE_SIZE for phdr

2017-04-27 Thread Xunlei Pang
-by: Dave Young Signed-off-by: Xunlei Pang --- v4->v5: No change. v3->v4: -Rebased on the latest linux-next arch/powerpc/kernel/fadump.c | 3 +-- include/linux/crash_core.h | 1 - kernel/crash_core.c | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/powe

[PATCH v5 3/3] kdump: Protect vmcoreinfo data under the crash memory

2017-04-27 Thread Xunlei Pang
and update to use this new one instead in the following crash_save_vmcoreinfo(). BTW, we do not touch vmcoreinfo_note, because it will be fully updated using the protected vmcoreinfo_data after crash which is surely correct just like the cpu crash note. Tested-by: Michael Holzheu Signed-off-by: Xu

Re: [tip:locking/core] rtmutex: Deboost before waking up the top waiter

2017-04-05 Thread Xunlei Pang
On 04/05/2017 at 04:08 PM, Mike Galbraith wrote: > locking/rtmutex: Fix preempt leak in __rt_mutex_futex_unlock() > > mark_wakeup_next_waiter() already disables preemption, doing so > again leaves us with an unpaired preempt_disable(). You can also fix the corresponding comment in rt_mutex_postunl

[PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-10 Thread Xunlei Pang
runs out of bandwidth of the current period. Cc: Daniel Bristot de Oliveira Cc: Steven Rostedt Signed-off-by: Xunlei Pang --- kernel/sched/deadline.c | 47 +++ 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/kernel/sched/deadline.c b/k

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-10 Thread Xunlei Pang
On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: > On 04/10/2017 11:22 AM, Xunlei Pang wrote: >> I was testing Daniel's changes with his test case in the commit >> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >> task activated after t

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-10 Thread Xunlei Pang
On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: > On 04/10/2017 11:22 AM, Xunlei Pang wrote: >> I was testing Daniel's changes with his test case in the commit >> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >> task activated after t

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Xunlei Pang
On 04/11/2017 at 01:53 PM, Xunlei Pang wrote: > On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: >> On 04/10/2017 11:22 AM, Xunlei Pang wrote: >>> I was testing Daniel's changes with his test case in the commit >>> df8eac8cafce ("sched/deadline: Thr

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Xunlei Pang
On 04/11/2017 at 05:24 PM, Daniel Bristot de Oliveira wrote: > On 04/11/2017 09:06 AM, Xunlei Pang wrote: >> On 04/11/2017 at 01:53 PM, Xunlei Pang wrote: >>> On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: >>>> On 04/10/2017 11:22 AM, Xunlei Pang wrote

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-11 Thread Xunlei Pang
On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: > On 04/10/2017 11:22 AM, Xunlei Pang wrote: >> I was testing Daniel's changes with his test case in the commit >> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >> task activated after t

Re: [RFC PATCH] x86_64/mm/boot: Fix kernel_ident_mapping_init() failure for kexec

2017-03-30 Thread Xunlei Pang
On 03/24/2017 at 08:04 PM, Kirill A. Shutemov wrote: > On Mon, Mar 20, 2017 at 02:11:31PM +0800, Xunlei Pang wrote: >> I found that the kdump is broken on linux-4.11.0-rc2+ > That's actually tip tree or linux-next. The problematic change is not in > Linus' tree. >

Re: [RFC PATCH] x86_64/mm/boot: Fix kernel_ident_mapping_init() failure for kexec

2017-03-30 Thread Xunlei Pang
On 03/30/2017 at 07:21 PM, Xunlei Pang wrote: > On 03/24/2017 at 08:04 PM, Kirill A. Shutemov wrote: >> On Mon, Mar 20, 2017 at 02:11:31PM +0800, Xunlei Pang wrote: >>> I found that the kdump is broken on linux-4.11.0-rc2+ >> That's actually tip tree or linux-next. The

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-12 Thread Xunlei Pang
On 04/12/2017 at 02:55 PM, Luca Abeni wrote: > Hi, > > On Wed, 12 Apr 2017 13:27:32 +0800 > Xunlei Pang wrote: > [...] >> The more I read the code, the more I am confused why >> dl_entity_overflow() is needed, if the task is before its deadline, >> just let it

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-12 Thread Xunlei Pang
On 04/12/2017 at 09:10 PM, luca abeni wrote: > On Wed, 12 Apr 2017 20:30:04 +0800 > Xunlei Pang wrote: > [...] >>> If the relative deadline is different from the period, then the >>> check is an approximation (and this is the big issue here). I am >>> still n

Re: [PATCH] sched/deadline: Throttle a constrained task activated if overflow

2017-04-13 Thread Xunlei Pang
On 04/11/2017 at 04:47 AM, Daniel Bristot de Oliveira wrote: > On 04/10/2017 11:22 AM, Xunlei Pang wrote: >> I was testing Daniel's changes with his test case in the commit >> df8eac8cafce ("sched/deadline: Throttle a constrained deadline >> task activated after t

[PATCH 2/2] x86_64/kexec: Use PUD level 1GB page for identity mapping if available

2017-04-25 Thread Xunlei Pang
tity mapping pgtable for kdump if 1GB feature is available. Signed-off-by: Xunlei Pang --- arch/x86/kernel/machine_kexec_64.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c index 1d4f2b0..41f1ae7 100644 -

[PATCH 1/2] x86/mm/ident_map: Add PUD level 1GB page support

2017-04-25 Thread Xunlei Pang
booting into the new kernel. We will utilize this new support in the following patch. Signed-off-by: Xunlei Pang --- arch/x86/boot/compressed/pagetable.c | 2 +- arch/x86/include/asm/init.h | 3 ++- arch/x86/kernel/machine_kexec_64.c | 2 +- arch/x86/mm/ident_map.c | 13

Re: [PATCH] sched/deadline: Zero out positive runtime after throttling constrained tasks

2017-05-24 Thread Xunlei Pang
Hi Peter, On 05/11/2017 at 10:35 PM, Daniel Bristot de Oliveira wrote: > On 05/10/2017 03:03 PM, Xunlei Pang wrote: >> When a contrained task is throttled by dl_check_constrained_dl(), >> it may carry the remaining positive runtime, as a result when >> dl_task_ti

Re: [PATCH v3 2/2] x86_64/kexec: Use PUD level 1GB page for identity mapping if available

2017-05-08 Thread Xunlei Pang
On 05/08/2017 at 02:29 PM, Ingo Molnar wrote: > * Xunlei Pang wrote: > >> On 05/05/2017 at 05:20 PM, Ingo Molnar wrote: >>> * Xunlei Pang wrote: >>> >>>> On 05/05/2017 at 02:52 PM, Ingo Molnar wrote: >>>>> * Xunlei Pang wrote: >>

[PATCH] sched/deadline: Zero out positive runtime after throttling constrained tasks

2017-05-10 Thread Xunlei Pang
if positive after throttling. Fixes: df8eac8cafce ("sched/deadline: Throttle a constrained deadline task activated after the deadline) Cc: Daniel Bristot de Oliveira Signed-off-by: Xunlei Pang --- kernel/sched/deadline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/dead

Re: [PATCH] sched/deadline: Zero out positive runtime after throttling constrained tasks

2017-05-10 Thread Xunlei Pang
On 05/10/2017 at 09:36 PM, Steven Rostedt wrote: > On Wed, 10 May 2017 21:03:37 +0800 > Xunlei Pang wrote: > >> When a contrained task is throttled by dl_check_constrained_dl(), >> it may carry the remaining positive runtime, as a result when >> dl_task_timer() fires an

Re: [PATCH v5 28/32] x86/mm, kexec: Allow kexec to be used with SME

2017-05-31 Thread Xunlei Pang
On 05/31/2017 at 01:46 AM, Tom Lendacky wrote: > On 5/25/2017 11:17 PM, Xunlei Pang wrote: >> On 04/19/2017 at 05:21 AM, Tom Lendacky wrote: >>> Provide support so that kexec can be used to boot a kernel when SME is >>> enabled. >>> >>> Support

<    1   2   3   4   5   6   >