Re: Address already in use problem

2016-09-21 Thread Xin Long
>> > Hi, >> > >> > Which kernel are you using? Depending on it, that may be fixed by a >> > recent patchset from Xin Long, 'sctp: fix the transmit err process' >> > patchset more exactly. >> > >> > Marcelo > > Ah no,

Re: [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression

2016-07-28 Thread Xin Long
On Wed, Jul 27, 2016 at 9:54 AM, kernel test robot wrote: > > FYI, we noticed a -37.2% regression of netperf.Throughput_Mbps due to commit: > > commit a6c2f792873aff332a4689717c3cd6104f46684c ("sctp: implement prsctp TTL > policy") > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next

Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression

2016-08-05 Thread Xin Long
>> It doesn't make much sense to me. the codes I added cannot be >> triggered without enable any pr policies. and I also did the tests in > > It seems these pr policies has to be turned on by user space, i.e. > netperf in this case? > > I checked netperf's source code, it doesn't seem set any optio

Re: KASAN: use-after-free Read in sctp_association_free

2017-11-02 Thread Xin Long
On Thu, Nov 2, 2017 at 1:55 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 25a5d23b47994cdb451dcd2bc8ac310a1492f71b > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is at

Re: WARNING in refcount_sub_and_test

2017-10-26 Thread Xin Long
On Thu, Oct 26, 2017 at 10:49 PM, Dmitry Vyukov wrote: > On Thu, Oct 26, 2017 at 10:53 AM, ChunYu Wang wrote: >> Hi all, >> >> I am failed to reproduce it on target kernel with the reproducer file >> or replaying the target syzkaller description log file, do I made >> something wrong or there exi

Re: WARNING in refcount_sub_and_test

2017-10-26 Thread Xin Long
On Fri, Oct 27, 2017 at 12:13 AM, Dmitry Vyukov wrote: > On Thu, Oct 26, 2017 at 5:49 PM, Xin Long wrote: >> On Thu, Oct 26, 2017 at 10:49 PM, Dmitry Vyukov wrote: >>> On Thu, Oct 26, 2017 at 10:53 AM, ChunYu Wang wrote: >>>> Hi all, >>>> >>>

Re: WARNING in refcount_sub_and_test

2017-10-26 Thread Xin Long
On Fri, Oct 27, 2017 at 12:56 AM, Xin Long wrote: > On Fri, Oct 27, 2017 at 12:13 AM, Dmitry Vyukov wrote: >> On Thu, Oct 26, 2017 at 5:49 PM, Xin Long wrote: >>> On Thu, Oct 26, 2017 at 10:49 PM, Dmitry Vyukov wrote: >>>> On Thu, Oct 26, 2017 at 10:53 AM, Ch

Re: KASAN: use-after-free Read in refcount_inc_not_zero

2017-11-03 Thread Xin Long
On Fri, Nov 3, 2017 at 1:35 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 73d3393ada4f70fa3df5639c8d438f2f034c0ecb > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is at

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2017-11-05 Thread Xin Long
On Mon, Oct 30, 2017 at 10:36 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > c69fe407803d4b554b7397fad9598a04717ac255 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is

Re: net/sctp/socket.c:2681:6-11: ERROR: invalid reference to the index variable of the iterator on line 2661 (fwd)

2018-08-30 Thread Xin Long
> Subject: net/sctp/socket.c:2681:6-11: ERROR: invalid reference to the index > variable of the iterator on line 2661 > > CC: kbuild-...@01.org > CC: linux-kernel@vger.kernel.org > TO: Xin Long > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi

Re: general protection fault in sctp_v6_get_dst

2018-01-11 Thread Xin Long
On Thu, Jan 11, 2018 at 2:15 AM, syzbot wrote: > syzkaller has found reproducer for the following crash on > 61ad64080e039dce99a7f8d89b729bbea995e2f7 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

Re: WARNING in netlink_ack (2)

2018-01-12 Thread Xin Long
On Thu, Jan 11, 2018 at 1:31 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > cf1fb158230edce8a0482bfb2e59b9c390477fb6 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is a

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-01-31 Thread Xin Long
ck if net namespace is exiting") in net/net-next from 5 days ago, maybe >>> fixed due to that? >>> >> >> This appears to be the commit introducing the refcnt leak: >> >> $ git bisect bad >> dbc2b5e9a09e9a6664679a667ff81cff6e5f2641 is the first bad commit >> c

Re: general protection fault in strlen

2018-01-18 Thread Xin Long
On Thu, Jan 18, 2018 at 11:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 8cbab92dff778e516064c13113ca15d4869ec883 > > So far this crash happened 19 times on linux-next, net-next, upstream. > C reproducer is attached. > syzkaller reproducer is attached. > Raw

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2018-01-19 Thread Xin Long
On Sat, Jan 20, 2018 at 1:19 AM, Guillaume Nault wrote: > On Tue, Jan 16, 2018 at 04:21:40PM +0800, Xin Long wrote: >> ipv4 tunnels don't really set dev->hard_header_len properly, >> we may should fix it in pppoe by using needed_headroom, >> as what it doesn'

Re: KASAN: use-after-free Read in sctp_packet_transmit

2018-01-05 Thread Xin Long
On Sat, Jan 6, 2018 at 6:07 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 8a4816cad00bf14642f0ed6043b32d29a05006ce > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is at

Re: WARNING: held lock freed!

2018-01-08 Thread Xin Long
000209a9000 R14: 0100 R15: 0001 > == > BUG: KASAN: use-after-free in debug_spin_lock_before > kernel/locking/spinlock_debug.c:83 [inline] > BUG: KASAN: use-after-free in do_raw_spin_lock+0x1e0/0x220 &g

Re: KASAN: stack-out-of-bounds Read in __nla_put

2018-01-17 Thread Xin Long
On Wed, Jan 17, 2018 at 1:58 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > fdddade65d7b5f8779374eb73d09889185280f60 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is

Re: tun: memory leak in tun_set_iff

2018-01-17 Thread Xin Long
On Wed, Jan 10, 2018 at 2:20 AM, Dmitry Vyukov wrote: > Hello, > > syzkaller has hit the following memory leak on 4.15-rc7. > Reproducer is attached. > > unreeferenced object 0x88002c9ac400 (size 4096): > comm "syz-executor0", pid 12349, jiffies 4295751114 (age 10.067s) > hex dump (first 3

Re: KASAN: stack-out-of-bounds Read in __nla_put

2018-01-17 Thread Xin Long
On Thu, Jan 18, 2018 at 12:59 AM, David Ahern wrote: > On 1/17/18 2:39 AM, Xin Long wrote: >> I guess you need to move up your memset(0) a little bit: >> >> @@ -2427,6 +2443,7 @@ int netlink_rcv_skb(struct sk_buff *skb, int >> (*cb)(struct sk_buff *, >>

Re: WARNING: held lock freed!

2018-01-08 Thread Xin Long
On Mon, Jan 8, 2018 at 8:09 PM, Marcelo Ricardo Leitner wrote: > On Mon, Jan 08, 2018 at 06:01:14PM +0800, Xin Long wrote: >> On Mon, Jan 8, 2018 at 6:58 AM, syzbot >> wrote: >> > Hello, >> > >> > syzkaller hit the following crash on >> >

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2018-01-16 Thread Xin Long
On Tue, Jan 16, 2018 at 4:22 AM, syzbot wrote: > syzkaller has found reproducer for the following crash on > b625c1ff82272e26c76570d3c7123419ec345b20 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-09 Thread Xin Long
On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman wrote: > On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on net-next commit >> fd372a7a9e5e9d8011a0222d10edd3523abcd3b1 (Thu Mar 8 19:43:48 2018 +) >> Merge tag 'mlx5-updates-2018-02-28-2' of >>

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-10 Thread Xin Long
On Sat, Mar 10, 2018 at 9:13 PM, Neil Horman wrote: > On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote: >> On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman wrote: >> > On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote: >> >> Hello, >> >> >&g

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-12 Thread Xin Long
On Sun, Mar 11, 2018 at 3:04 AM, Neil Horman wrote: > On Sun, Mar 11, 2018 at 12:22:32AM +0800, Xin Long wrote: >> On Sat, Mar 10, 2018 at 9:13 PM, Neil Horman wrote: >> > On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote: >> >> On Sat, Mar 10, 2018 at 6:08

Re: [GIT PULL] SELinux patches for v4.17

2018-04-07 Thread Xin Long
On Sat, Apr 7, 2018 at 7:07 AM, Linus Torvalds wrote: > On Tue, Apr 3, 2018 at 6:37 PM, Paul Moore wrote: >> >> Everything passes the selinux-testsuite, but there are a few known >> merge conflicts. The first is with the netdev tree and is in >> net/sctp/socket.c. Unfortunately it is a bit ugly

Re: [GIT PULL] SELinux patches for v4.17

2018-04-08 Thread Xin Long
d in my >> tree, but I don't actually expect the merge to have had any issues >> even if the refactoring made it a bit more complex than most merges >> are. >> >> Thanks for the quick response Richard. >> >> Xin Long looked it over and gave it the thum

Re: [GIT PULL] SELinux patches for v4.17

2018-04-08 Thread Xin Long
On Mon, Apr 9, 2018 at 6:44 AM, Richard Haines wrote: > On Sun, 2018-04-08 at 19:59 +0100, Richard Haines via Selinux wrote: >> On Mon, 2018-04-09 at 01:43 +0800, Xin Long wrote: >> > On Sun, Apr 8, 2018 at 10:09 PM, Richard Haines >> > wrote: >> > > On Sun

Re: linux-next: manual merge of the selinux tree with the net-next tree

2018-03-08 Thread Xin Long
g. You may also want to consider >>> cooperating with the maintainer of the conflicting tree to minimise any >>> particularly complex conflicts. >>> >>> -- >>> Cheers, >>> Stephen Rothwell >> >> The resolution now looks like below (

Re: linux-next: manual merge of the selinux tree with the net-next tree

2018-03-08 Thread Xin Long
On Thu, Mar 8, 2018 at 10:07 AM, Stephen Rothwell wrote: > Hi all, > > On Mon, 5 Mar 2018 12:40:54 +1100 Stephen Rothwell > wrote: >> >> Today's linux-next merge of the selinux tree got a conflict in: >> >> net/sctp/socket.c >> >> between several refactoring commits from the net-next tree and

Re: BUG: corrupted list in sctp_association_free

2018-03-13 Thread Xin Long
On Tue, Mar 13, 2018 at 3:34 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > fd372a7a9e5e9d8011a0222d10edd3523abcd3b1 (Thu Mar 8 19:43:48 2018 +) > Merge tag 'mlx5-updates-2018-02-28-2' of > git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux > > Unf

Re: KASAN: use-after-free Read in sctp_hash_transport

2018-11-19 Thread Xin Long
_asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:433 > sctp_hash_transport+0x803/0x810 net/sctp/input.c:958 Caused by: commit cd2b708750582e327789d8fb07c6eb5f79f7759f Author: Xin Long Date: Fri Feb 17 16:35:24 2017 +0800 sctp: check duplicate node before inserting a new transport

Re: KASAN: use-after-free Read in sctp_epaddr_lookup_transport

2018-11-19 Thread Xin Long
port+0xacb/0xb20 > net/sctp/input.c:971 > Read of size 8 at addr 8881cde426b0 by task syz-executor3/18110 > The same fix is needed in sctp_epaddr_lookup_transport() as: commit bab1be79a5169ac748d8292b20c86d874022d7ba Author: Xin Long Date: Mon Aug 27 18:38:31 20

Re: KASAN: use-after-free Read in __lock_sock

2018-11-19 Thread Xin Long
On Sat, Nov 17, 2018 at 4:18 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:ccda4af0f4b9 Linux 4.20-rc2 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=156cd53340 > kernel config: https://syzkaller.appspot.com/x/

[PATCHv2 net 2/3] flex_array: support flex_array_resize

2018-12-06 Thread Xin Long
ested-by: Neil Horman Signed-off-by: Xin Long Acked-by: Neil Horman --- include/linux/flex_array.h | 11 + lib/flex_array.c | 58 ++ 2 files changed, 69 insertions(+) diff --git a/include/linux/flex_array.h b/include/linux/flex_ar

[PATCHv2 net 0/3] net: add support for flex_array_resize in flex_array

2018-12-06 Thread Xin Long
) for managing its stream memory so far. v1->v2: Cc LKML and more developers. Xin Long (3): flex_array: make FLEX_ARRAY_BASE_SIZE the same value of FLEX_ARRAY_PART_SIZE flex_array: support flex_array_resize sctp: fa_resize sctp stream instead of redo fa_alloc inc

[PATCHv2 net 1/3] flex_array: make FLEX_ARRAY_BASE_SIZE the same value of FLEX_ARRAY_PART_SIZE

2018-12-06 Thread Xin Long
added in the next patch. Suggested-by: Neil Horman Signed-off-by: Xin Long Acked-by: Neil Horman --- include/linux/flex_array.h | 29 + lib/flex_array.c | 15 --- 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/include/

[PATCHv2 net 3/3] sctp: fa_resize sctp stream instead of redo fa_alloc

2018-12-06 Thread Xin Long
s, while flex_array_clear() and flex_array_shrink() are called to free the unused memory before shrinking. Fixes: 5e32a431 ("sctp: introduce stream scheduler foundations") Reported-by: Ying Xu Reported-by: syzbot+e33a3a138267ca119...@syzkaller.appspotmail.com Suggested-by: Neil Hor

Re: INFO: rcu detected stall in kfree_skbmem

2018-05-14 Thread Xin Long
On Mon, May 14, 2018 at 9:34 PM, Neil Horman wrote: > On Fri, May 11, 2018 at 12:00:38PM +0200, Dmitry Vyukov wrote: >> On Mon, Apr 30, 2018 at 8:09 PM, syzbot >> wrote: >> > Hello, >> > >> > syzbot found the following crash on: >> > >> > HEAD commit:5d1365940a68 Merge >> > git://git.kernel.o

Re: [PATCH 6/6] Drop flex_arrays

2018-12-13 Thread Xin Long
On Sat, Sep 8, 2018 at 1:57 AM Kent Overstreet wrote: > > All existing users have been converted to generic radix trees NAK, SCTP is still using flex_arrays, # grep flex_array net/sctp/* This patch will break the build. > > Signed-off-by: Kent Overstreet > Acked-by: Dave Hansen > --- > Docume

Re: KMSAN: kernel-infoleak in sctp_getsockopt

2018-12-10 Thread Xin Long
On Thu, Dec 6, 2018 at 8:08 PM Marcelo Ricardo Leitner wrote: > > On Thu, Dec 06, 2018 at 11:36:08AM +0100, Alexander Potapenko wrote: > > On Wed, Dec 5, 2018 at 8:31 PM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:fffec98ae2a6

[PATCH net] sctp: initialize sin6_flowinfo for ipv6 addrs in sctp_inet6addr_event

2018-12-10 Thread Xin Long
e28...@syzkaller.appspotmail.com Signed-off-by: Xin Long --- net/sctp/ipv6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index fc6c5e4..7f0539d 100644 --- a/net/sctp/ipv6.c +++ b/net/sctp/ipv6.c @@ -101,6 +101,7 @@ static int sctp_inet6addr_event(str

Re: perf script doesn't dump a normal call trace

2018-11-06 Thread Xin Long
On Mon, Nov 5, 2018 at 5:49 PM Jiri Olsa wrote: > > On Mon, Nov 05, 2018 at 03:20:15PM +0900, Xin Long wrote: > > SNIP > > > > > > [root@ibm-x3650m4-02 perf]# ./perf probe 'consume_skb' > > > > > [root@ibm-x3650m4-02 perf]# .

perf script doesn't dump a normal call trace

2018-11-01 Thread Xin Long
On upstream kernel(4.19) or RHEL-8 kernel(4.18.0): # perf record -e 'skb:consume_skb' -ag ^C[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.612 MB perf.data (634 samples) ] # perf script swapper 0 [009] 274370.117711: skb:consume_skb: skbaddr=0x962c591d

Re: perf script doesn't dump a normal call trace

2018-11-03 Thread Xin Long
On Fri, Nov 2, 2018 at 7:26 PM Jiri Olsa wrote: > > On Fri, Nov 02, 2018 at 03:36:13PM +0900, Xin Long wrote: > > On upstream kernel(4.19) or RHEL-8 kernel(4.18.0): > > > > # perf record -e 'skb:consume_skb' -ag > > ^C[ perf record: Woken up 1 times to writ

Re: perf script doesn't dump a normal call trace

2018-11-04 Thread Xin Long
On Mon, Nov 5, 2018 at 4:18 AM Jiri Olsa wrote: > > On Sat, Nov 03, 2018 at 06:36:21PM +0900, Xin Long wrote: > > On Fri, Nov 2, 2018 at 7:26 PM Jiri Olsa wrote: > > > > > > On Fri, Nov 02, 2018 at 03:36:13PM +0900, Xin Long wrote: > > > > On ups

Re: INFO: rcu detected stall in corrupted

2018-05-24 Thread Xin Long
ate_heartbeat_event+0x218/0x450 net/sctp/sm_sideeffect.c:406 >> call_timer_fn+0x230/0x940 kernel/time/timer.c:1326 >> >> >> Some kind of infinite loop. >> >> When the hrtimer fires, it can point to any code that sits below but does >> not necessarily have a bug

Re: non-blocking connect for kernel SCTP sockets

2018-05-02 Thread Xin Long
On Wed, May 2, 2018 at 5:06 PM, Michal Kubecek wrote: > Hello, > > while investigating a bug, we noticed that DLM tries to connect an SCTP > socket in non-blocking mode using > > result = sock->ops->connect(sock, (struct sockaddr *)&daddr, addr_len, > O_

Re: KMSAN: uninit-value in __sctp_v6_cmp_addr

2018-05-16 Thread Xin Long
dump_stack.c:77 [inline] > dump_stack+0x185/0x1d0 lib/dump_stack.c:113 > kmsan_report+0x142/0x240 mm/kmsan/kmsan.c:1067 > __msan_warning_32+0x6c/0xb0 mm/kmsan/kmsan_instr.c:683 > __sctp_v6_cmp_addr+0x49a/0x850 net/sctp/ipv6.c:580 Pls check if the testing kernel has this commit: commi

Re: INFO: rcu detected stall in sctp_packet_transmit

2018-05-16 Thread Xin Long
On Wed, May 16, 2018 at 4:11 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:961423f9fcbc Merge branch 'sctp-Introduce-sctp_flush_ctx' > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1366aea780 > kernel config: htt

Re: INFO: rcu detected stall in sctp_packet_transmit

2018-05-16 Thread Xin Long
On Wed, May 16, 2018 at 6:53 PM, Dmitry Vyukov wrote: > On Wed, May 16, 2018 at 12:44 PM, Xin Long wrote: >> On Wed, May 16, 2018 at 4:11 PM, syzbot >> wrote: >>> Hello, >>> >>> syzbot found the following crash on: >>> >>> HEAD commit:

Re: [PATCH net] sctp: get sctphdr by offset in sctp_compute_cksum

2019-02-25 Thread Xin Long
On Mon, Feb 25, 2019 at 10:08 PM Neil Horman wrote: > > On Mon, Feb 25, 2019 at 09:20:44PM +0800, Xin Long wrote: > > On Mon, Feb 25, 2019 at 8:47 PM Neil Horman wrote: > > > > > > On Mon, Feb 25, 2019 at 07:25:37PM +0800, Xin Long wrote: > > &

Re: [PATCH net] sctp: get sctphdr by offset in sctp_compute_cksum

2019-02-27 Thread Xin Long
On Tue, Feb 26, 2019 at 8:29 PM Neil Horman wrote: > > On Tue, Feb 26, 2019 at 12:15:54AM +0800, Xin Long wrote: > > On Mon, Feb 25, 2019 at 10:08 PM Neil Horman wrote: > > > > > > On Mon, Feb 25, 2019 at 09:20:44PM +0800, Xin Long wrote: > > > > O

Re: [RFC PATCH net] rxrpc: Fix missing dependency on NET_UDP_TUNNEL

2021-02-09 Thread Xin Long
quot;rxrpc: use udp tunnel APIs instead of open code in > rxrpc_open_socket") > Reported-by: kernel test robot > Suggested-by: Vadim Fedorenko > Signed-off-by: David Howells > cc: Xin Long > cc: a...@dev.mellanox.co.il > cc: Jakub Kicinski > --- > > net/rxrp

Re: [PATCH net-next] ip_vti: Fix unused variable warning

2020-07-31 Thread Xin Long
8c7ec75a ("ip_vti: not register vti_ipip_handler twice") Acked-by: Xin Long > --- > net/ipv4/ip_vti.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c > index 49daaed89764..f687abb069fa 100644 > --- a/net/ipv4/ip_vti.c

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

2020-05-20 Thread Xin Long
On Tue, May 19, 2020 at 4:53 PM Steffen Klassert wrote: > > On Fri, May 15, 2020 at 04:39:57PM +0800, Yuehaibing wrote: > > > > Friendly ping... > > > > Any plan for this issue? > > There was still no consensus between you and Xin on how > to fix this issue. Once this happens, I consider applying

Re: WARNING: suspicious RCU usage in tipc_l2_send_msg

2020-08-19 Thread Xin Long
On Sat, Jun 27, 2020 at 1:25 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:b835a71e usbnet: smsc95xx: Fix use-after-free after removal > git tree: net > console output: https://syzkaller.appspot.com/x/log.txt?x=1095a51d10 > kernel config: https

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Xin Long
On Thu, Dec 3, 2015 at 8:41 PM, Herbert Xu wrote: > On Mon, Nov 30, 2015 at 06:18:59PM +0800, Herbert Xu wrote: >> >> OK that's better. I think I see the problem. The test in >> rhashtable_insert_rehash is racy and if two threads both try >> to grow the table one of them may be tricked into doin

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Xin Long
On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu wrote: > On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote: >> >> sorry for late test, but unfortunately, my case with rhashtalbe still >> return EBUSY. >> I added some debug code in rhashtable_insert_rehash(), and fo

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Xin Long
On Thu, Dec 17, 2015 at 5:00 PM, Xin Long wrote: > On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu > wrote: >> On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote: >>> >>> sorry for late test, but unfortunately, my case with rhashtalbe still >>> retur

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-18 Thread Xin Long
On Fri, Dec 18, 2015 at 10:26 AM, Herbert Xu wrote: > On Fri, Dec 18, 2015 at 12:07:08AM +0800, Xin Long wrote: >> >> I'm just wondering, why do not we handle the genuine double rehash >> issue inside rhashtable? i mean it's just a temporary error that a >> s

rhashtable: how to deal with that rhashtable_lookup_insert_key return -EBUSY

2015-11-19 Thread Xin Long
when I use rhashtable_lookup_insert_key, sometimes it will return -EBUSY. im not sure if there is a good way to workabout it. or I should just try again and again until it's inserted successfully ? I have seen some use in kernel by now, but it seems that no one consider this issue for their cases

[PATCH] virtio: queue variable should be initialized in vring_create_virtqueue

2016-04-24 Thread Xin Long
'queue' may be used uninitialized in vring_create_virtqueue, actually when we compile kernel, gcc can also give this warning. Fixes: 2a2d1382fe9d ("virtio: Add improved queue allocation API") Signed-off-by: Xin Long --- drivers/virtio/virtio_ring.c | 2 +- 1 file change

[PATCH net] sctp: call gso_reset_checksum when computing checksum in sctp_gso_segment

2019-02-12 Thread Xin Long
gso_reset_checksum() when computing checksum in sctp_gso_segment. Reported-by: Jianlin Shi Signed-off-by: Xin Long --- net/sctp/offload.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sctp/offload.c b/net/sctp/offload.c index 123e9f2..edfcf16 100644 --- a/net/sctp/offload.c +++ b

[PATCH net] sctp: set stream ext to NULL after freeing it in sctp_stream_outq_migrate

2019-02-12 Thread Xin Long
introduce stream scheduler foundations") Reported-by: syzbot+58e480e7b28f2d890...@syzkaller.appspotmail.com Signed-off-by: Xin Long --- net/sctp/stream.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/sctp/stream.c b/net/sctp/stream.c index f246331..2936ed1 100644 --- a/n

Re: net/dst_cache.c: preemption bug in net/dst_cache.c

2019-09-09 Thread Xin Long
On Fri, Aug 23, 2019 at 3:58 PM Bharath Vedartham wrote: > > Hi all, > > I just want to bring attention to the syzbot bug [1] > > Even though syzbot claims the bug to be in net/tipc, I feel it is in > net/dst_cache.c. Please correct me if I am wrong. > > This bug is being triggered a lot of times

Re: kernel BUG at include/linux/skbuff.h:LINE! (2)

2019-08-18 Thread Xin Long
On Sat, Aug 17, 2019 at 2:38 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:459c5fb4 Merge branch 'mscc-PTP-support' > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=13f2d33c60 > kernel config: https://syzkaller.a

Re: KASAN: slab-out-of-bounds Read in sctp_inq_pop

2019-08-26 Thread Xin Long
On Tue, Aug 27, 2019 at 1:15 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:9733a7c6 Add linux-next specific files for 20190823 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=143ec11e60 > kernel config: https:

Re: kernel BUG at include/linux/skbuff.h:LINE! (2)

2019-08-23 Thread Xin Long
On Mon, Aug 19, 2019 at 10:44 PM Xin Long wrote: > > On Sun, Aug 18, 2019 at 10:13 PM Dmitry Vyukov wrote: > > > > On Sun, Aug 18, 2019 at 7:07 AM Xin Long wrote: > > > > > > On Sat, Aug 17, 2019 at 2:38 AM syzbot > > > wrote: > > > >

Re: kernel BUG at include/linux/skbuff.h:LINE! (2)

2019-08-19 Thread Xin Long
On Sun, Aug 18, 2019 at 10:13 PM Dmitry Vyukov wrote: > > On Sun, Aug 18, 2019 at 7:07 AM Xin Long wrote: > > > > On Sat, Aug 17, 2019 at 2:38 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on:

Re: memory leak in sctp_get_port_local (3)

2019-10-14 Thread Xin Long
On Mon, Oct 14, 2019 at 10:50 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:da940012 Merge tag 'char-misc-5.4-rc3' of git://git.kernel.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11c87fc760 > kernel config:

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-14 Thread Xin Long
On Wed, Feb 13, 2019 at 9:52 PM Marcelo Ricardo Leitner wrote: > > On Wed, Feb 13, 2019 at 12:35:56PM +0800, Xin Long wrote: > > On Wed, Feb 13, 2019 at 4:00 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-14 Thread Xin Long
On Thu, Feb 14, 2019 at 10:39 PM Marcelo Ricardo Leitner wrote: > > On Thu, Feb 14, 2019 at 12:17:45PM -0200, Marcelo Ricardo Leitner wrote: > > On Thu, Feb 14, 2019 at 10:03:30PM +0800, Xin Long wrote: > > > On Wed, Feb 13, 2019 at 9:52 PM Marcelo Ricardo Leitner > > &

Re: KASAN: invalid-free in sctp_stream_free

2019-02-10 Thread Xin Long
On Tue, Feb 5, 2019 at 1:21 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:dc4c89997735 Add linux-next specific files for 20190201 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17eb3dc4c0 > kernel config: htt

[PATCH net] sctp: improve the events for sctp stream reset

2019-01-21 Thread Xin Long
quot;sctp: implement receiver-side procedures for the Incoming SSN Reset Request Parameter") Fixes: 11ae76e67a17 ("sctp: implement receiver-side procedures for the Reconf Response Parameter") Reported-by: Ying Xu Signed-off-by: Xin Long --- net/sctp/stream.c | 39 +---

[PATCH net] sctp: improve the events for sctp stream adding

2019-01-21 Thread Xin Long
res for the Add Incoming Streams Request Parameter") Reported-by: Ying Xu Signed-off-by: Xin Long --- net/sctp/stream.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/net/sctp/stream.c b/net/sctp/stream.c index 6c188b0..80e0ae5 100644 --- a/net/sctp/str

[PATCH net] sctp: set chunk transport correctly when it's a new asoc

2019-01-21 Thread Xin Long
me fields, like vtag to 'retval' chunk from that wrong transport's asoc. This patch is to fix it by setting 'retval' transport correctly which belongs to the right asoc in sctp_make_init_ack() and sctp_sf_do_5_1D_ce(). Fixes: b9fd683982c9 ("sctp: add sctp_packet_singlet

[PATCH net] sctp: set flow sport from saddr only when it's 0

2019-01-21 Thread Xin Long
simply handle it by setting flow sport from saddr only when it's 0 in sctp_v4/6_get_dst(). Fixes: 6e91b578bf3f ("sctp: re-use sctp_transport_pmtu in sctp_transport_route") Reported-by: Ying Xu Signed-off-by: Xin Long --- net/sctp/ipv6.c | 3 ++- net/sctp/protocol.c | 3 ++- 2 f

Re: KMSAN: kernel-infoleak in sctp_getsockopt

2019-01-14 Thread Xin Long
On Mon, Jan 14, 2019 at 5:34 PM Alexander Potapenko wrote: > > On Mon, Dec 10, 2018 at 9:56 AM Xin Long wrote: > > > > On Thu, Dec 6, 2018 at 8:08 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Thu, Dec 06, 2018 at 11:36:08AM +0100, Alexander Po

[PATCH net] erspan: build the header with the right proto according to erspan_ver

2019-01-14 Thread Xin Long
in erspan_xmit() according to erspan_ver. While at it, also remove the unused parameter 'proto' in erspan_fb_xmit(). Fixes: 94d7d8f29287 ("ip6_gre: add erspan v2 support") Reported-by: Jianlin Shi Signed-off-by: Xin Long --- net/ipv4/ip_gre.c | 23 ++- n

[PATCH net] sctp: allocate sctp_sockaddr_entry with kzalloc

2019-01-14 Thread Xin Long
in sctp_v4/6_copy_addrlist(). Reported-by: Alexander Potapenko Signed-off-by: Xin Long --- net/sctp/ipv6.c | 5 + net/sctp/protocol.c | 4 +--- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index b9ed271..ed8e006 100644 --- a/net/sctp/ipv6.c

[PATCHv3 net] sctp: check and update stream->out_curr when allocating stream_out

2019-02-03 Thread Xin Long
;) Reported-by: Ying Xu Reported-by: syzbot+e33a3a138267ca119...@syzkaller.appspotmail.com Signed-off-by: Xin Long --- net/sctp/stream.c | 20 1 file changed, 20 insertions(+) diff --git a/net/sctp/stream.c b/net/sctp/stream.c index 80e0ae5..f246331 100644 --- a/net/sctp/strea

Re: memory leak in sctp_get_port_local (2)

2019-08-09 Thread Xin Long
p_bucket_create net/sctp/socket.c:8374 [inline] > [<ff3ccf22>] sctp_get_port_local+0x189/0x5b0 > net/sctp/socket.c:8121 > [<eed41612>] sctp_do_bind+0xcc/0x1e0 net/sctp/socket.c:402 > [<00002bf65239>] sctp_bind+0x44/0x70 net/sctp/s

Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb

2019-08-02 Thread Xin Long
a problem with 4.19.y? How about 5.2.y? If not, can > > you do 'git bisect' to find the patch that fixes the issue? > > > > thanks, > > > > greg k-h > > Hi, please pick this to 4.14.y and 4.19.y, tested that it fixes the > crash in both: > >

Re: [PATCH] net: sctp: fix memory leak in sctp_send_reset_streams

2019-07-24 Thread Xin Long
On Sun, Jun 2, 2019 at 9:36 PM Xin Long wrote: > > On Sun, Jun 2, 2019 at 6:52 PM Neil Horman wrote: > > > > On Sun, Jun 02, 2019 at 11:44:29AM +0800, Hillf Danton wrote: > > > > > > syzbot found the following crash on: > > > > > > HEAD com

Re: KASAN: user-memory-access Read in ip6_hold_safe (3)

2019-06-23 Thread Xin Long
e 2019/06/01 15:51 bpf-next 0462eaac > > Since it happens a dozen of times per day, most likely it was > introduced into net-next around dfb569f2 (syzbot should do new builds > every ~12h, minus broken trees). I think all these pcpu memory corruptions can be marked as Fixed-by: commit c3bcde026684c62d7a2b6f626dc7cf763833875c Author: Xin Long Date: Mon Jun 17 21:34:15 2019 +0800 tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb

Re: memory leak in sctp_v4_create_accept_sk

2019-06-24 Thread Xin Long
On Mon, Jun 24, 2019 at 3:28 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:abf02e29 Merge tag 'pm-5.2-rc6' of git://git.kernel.org/pu.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=13470eb2a0 > kernel config:

Re: memory leak in sctp_get_port_local

2019-06-25 Thread Xin Long
On Wed, May 29, 2019 at 2:28 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:cd6c84d8 Linux 5.2-rc2 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=101a184aa0 > kernel config: https://syzkaller.appspot.com/x/.conf

Re: general protection fault in sctp_sched_prio_sched

2019-06-25 Thread Xin Long
4 > --- a/net/sctp/stream.c > +++ b/net/sctp/stream.c > @@ -153,13 +153,20 @@ int sctp_stream_init(struct sctp_stream *stream, __u16 > outcnt, __u16 incnt, > int sctp_stream_init_ext(struct sctp_stream *stream, __u16 sid) > { > struct sctp_stream_out_ext *soute; > + int ret; > > soute = kzalloc(sizeof(*soute), GFP_KERNEL); > if (!soute) > return -ENOMEM; > SCTP_SO(stream, sid)->ext = soute; > > - return sctp_sched_init_sid(stream, sid, GFP_KERNEL); > + ret = sctp_sched_init_sid(stream, sid, GFP_KERNEL); > + if (ret) { > + kfree(SCTP_SO(stream, sid)->ext); > + SCTP_SO(stream, sid)->ext = NULL; > + } > + > + return ret; > } > > void sctp_stream_free(struct sctp_stream *stream) > Tested-by: Xin Long Hi, Marcelo, please feel free to move forward with this patch, :-)

Re: memory leak in tipc_buf_acquire

2019-06-09 Thread Xin Long
On Sat, May 25, 2019 at 5:18 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:4dde821e Merge tag 'xfs-5.2-fixes-1' of git://git.kernel.o.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=107db73aa0 > kernel config:

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-12 Thread Xin Long
On Wed, Feb 13, 2019 at 4:00 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:d4104460aec1 Add linux-next specific files for 20190211 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=14140124c0 > kernel config: ht

[PATCH net] sctp: get sctphdr by offset in sctp_compute_cksum

2019-02-25 Thread Xin Long
ng offset, which is always right in all places. Fixes: e6d8b64b34aa ("net: sctp: fix and consolidate SCTP checksumming code") Reported-by: Li Shuang Signed-off-by: Xin Long --- include/net/sctp/checksum.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/sctp/c

Re: [PATCH net] sctp: get sctphdr by offset in sctp_compute_cksum

2019-02-25 Thread Xin Long
On Mon, Feb 25, 2019 at 8:47 PM Neil Horman wrote: > > On Mon, Feb 25, 2019 at 07:25:37PM +0800, Xin Long wrote: > > sctp_hdr(skb) only works when skb->transport_header is set properly. > > > > But in the path of nf_conntrack_in: sctp_packet() -> sctp_error() > &

Re: general protection fault in fib6_purge_rt

2019-03-20 Thread Xin Long
On Thu, Mar 21, 2019 at 12:54 AM Jon Maloy wrote: > > > > > -Original Message- > > From: Dmitry Vyukov > > Sent: 20-Mar-19 17:41 > > To: Jon Maloy > > Cc: syzbot ; > > da...@davemloft.net; kuz...@ms2.inr.ac.ru; linux- > > ker...@vger.kernel.org; net...@vger.kernel.org; syzkaller- > > b..

Re: general protection fault in sctp_sched_rr_dequeue

2019-03-06 Thread Xin Long
On Wed, Mar 6, 2019 at 9:42 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:63bdf4284c38 Merge branch 'linus' of git://git.kernel.org/.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=100347cb20 > kernel config:

Re: INFO: rcu detected stall in is_bpf_text_address

2018-05-20 Thread Xin Long
On Sat, May 19, 2018 at 11:57 PM, Eric Dumazet wrote: > SCTP experts, please take a look. > > On 05/19/2018 08:55 AM, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:73fcb1a370c7 Merge branch 'akpm' (patches from Andrew) >> git tree: upstream >> conso

Re: linux-next: manual merge of the selinux tree with the net-next tree

2018-03-04 Thread Xin Long
On Mon, Mar 5, 2018 at 9:40 AM, Stephen Rothwell wrote: > Hi Paul, > > Today's linux-next merge of the selinux tree got a conflict in: > > net/sctp/socket.c > > between several refactoring commits from the net-next tree and commit: > > 2277c7cd75e3 ("sctp: Add LSM hooks") > > from the selinux

Re: KASAN: slab-out-of-bounds Read in __sctp_v6_cmp_addr

2018-04-22 Thread Xin Long
On Mon, Apr 23, 2018 at 9:02 AM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 83beed7b2b26f232d782127792dd0cd4362fdc41 (Fri Apr 20 17:56:32 2018 +) > Merge branch 'fixes' of > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal > syzbot da

Re: KASAN: use-after-free Read in sctp_do_sm

2018-05-08 Thread Xin Long
On Tue, May 8, 2018 at 9:58 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:f142f08bf7ec Fix typo in comment. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1159ade780 > kernel config: https://syzkaller.appspot.co

Re: [PATCH][V3][net-next] net: sctp: fix array overrun read on sctp_timer_tbl

2017-01-24 Thread Xin Long
xes CoverityScan CID#1397639 ("Out-of-bounds read") > > Fixes: 7b9438de0cd4 ("sctp: add stream reconf timer") > Signed-off-by: Colin Ian King Reviewed-by: Xin Long

  1   2   >