Re: [Linuxarm] Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers

Hi Geert, On 2021/2/24 17:41, Geert Uytterhoeven wrote: Hi Xiaofei, On Sun, Feb 7, 2021 at 12:46 PM Xiaofei Tan wrote: Replace spin_lock_irqsave with spin_lock in hard IRQ of SCSI drivers. There are no function changes, but may speed up if interrupt happen too often. I'll bite: how

Re: [Linuxarm] Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers

...@vger.kernel.org; linux-kernel@vger.kernel.org; linux...@openeuler.org Subject: [Linuxarm] Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers On Sun, 7 Feb 2021, Xiaofei Tan wrote: Replace spin_lock_irqsave with spin_lock in hard IRQ of SCSI drivers. There are no function

[PATCH 0/6] spin lock usage optimization for RTC drivers

Replace spin_lock_irqsave with spin_lock in hard IRQ of RTC drivers. There is no function changes, but may speed up if interrupt happen too often. Xiaofei Tan (6): rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ rtc: pm8xxx: Replace spin_lock_irqsave with spin_lock in hard IRQ

[PATCH 5/6] rtc: mxc: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/rtc/rtc-mxc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c index 65b29b0

[PATCH 3/6] rtc: r7301: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/rtc/rtc-r7301.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-r7301.c b/drivers/rtc/rtc-r7301.c index

[PATCH 4/6] rtc: tegra: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/rtc/rtc-tegra.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index

[PATCH 6/6] rtc: mxc_v2: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/rtc/rtc-mxc_v2.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-mxc_v2.c b/drivers/rtc/rtc-mxc_v2.c

[PATCH 2/6] rtc: pm8xxx: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/rtc/rtc-pm8xxx.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c

[PATCH 1/6] rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/rtc/rtc-cmos.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index

[PATCH 1/1] PCI/AER: Change to use helper pcie_aer_is_native() in some places

Use helper function pcie_aer_is_native() in some places to keep the code tidy. No function changes. Signed-off-by: Xiaofei Tan --- drivers/pci/pcie/aer.c | 4 ++-- drivers/pci/pcie/err.c | 2 +- drivers/pci/pcie/portdrv_core.c | 2 +- 3 files changed, 4 insertions(+), 4

[PATCH] mmc: cavium: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/mmc/host/cavium.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/cavium.c b/drivers/mmc/host/cavium.c

[PATCH v2] PCI/AER: Change to use helper pcie_aer_is_native() in some places

Use helper function pcie_aer_is_native() in some places to keep the code tidy. No function changes. Signed-off-by: Xiaofei Tan Reviewed-by: Krzysztof Wilczyński --- Changes from v1 to v2: - Add the fix suggested by Krzysztof. --- drivers/pci/pcie/aer.c | 4 ++-- drivers/pci/pcie

[PATCH] ACPI / APEI: do memory failure on the physical address reported by ARM processor error section

ed. Fixes: 8fcc4ae6faf8 ("arm64: acpi: Make apei_claim_sea() synchronise with APEI's irq work") Signed-off-by: Xiaofei Tan --- drivers/acpi/apei/ghes.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b

Re: [PATCH] ACPI / APEI: do memory failure on the physical address reported by ARM processor error section

Hi James， On 2020/7/31 21:48, James Morse wrote: > Hi Tan, > > On 30/07/2020 08:32, Xiaofei Tan wrote: >> After the following commit applied, user-mode SEA is preferentially >> processed by APEI. Do memory failure to recover. >> >> But there are some problems:

[PATCH v2] ACPI / APEI: do memory failure on the physical address reported by ARM processor error section

ould update firmware. Don't report the RAS error in SEA processing flow when physical address is not recorded. Signed-off-by: Xiaofei Tan --- drivers/acpi/apei/ghes.c | 70 1 file changed, 53 insertions(+), 17 deletions(-) diff --git a/drivers/a

Re: [PATCH] ACPI: AC: fix some errors and warnings reported by checkpatch.pl

Hi Rafael， On 2021/3/24 23:57, Rafael J. Wysocki wrote: On Tue, Mar 23, 2021 at 2:01 PM Xiaofei Tan wrote: Fix some errors and warnings reported by checkpatch.pl, including following five types: Well, they are coding style issues rather than errors. Right, i could change the description

Re: [PATCH] ACPI: AC: fix some errors and warnings reported by checkpatch.pl

these will _not_ be updated #3: FILE: drivers/acpi/ac.c:3: + * acpi_ac.c - ACPI AC Adapter Driver ($Revision: 27 $) On 2021/3/25 9:26, Xiaofei Tan wrote: Hi Rafael， On 2021/3/24 23:57, Rafael J. Wysocki wrote: On Tue, Mar 23, 2021 at 2:01 PM Xiaofei Tan wrote: Fix some errors and warnings r

[PATCH] ACPI: AC: fix some errors and warnings reported by checkpatch.pl

for single statement blocks WARNING: void function return statements are not generally useful Signed-off-by: Xiaofei Tan --- drivers/acpi/ac.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c index b86e

[PATCH RFC for-next 1/1] arm64: sve: Fix some compile errors about sve_cond_update_zcr_vq

); ^~ kvm_pmu_update_run The root cause is that sve_cond_update_zcr_vq is not defined when ARM64_SVE is not selected. Fix it by adding an empty definition when CONFIG_ARM64_SVE=n. Signed-off-by: Xiaofei Tan --- arch/arm64/include/asm/fpsimd.h | 2 ++ 1 file changed, 2 insertions

Re: [Linuxarm] Re: [PATCH v3 00/12] acpi: fix some coding style issues

Hi Rafael, On 2021/3/29 20:50, Rafael J. Wysocki wrote: On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan wrote: Fix some coding style issues reported by checkpatch.pl. Only cleanup and no function changes. Differences from v2 to v3: - Remove the modifications that may cause function change

Re: [PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed

Hi David, On 2021/3/29 18:09, David Laight wrote: From: Xiaofei Tan Sent: 27 March 2021 07:46 Replace __attribute__((packed)) by __packed following the advice of checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_fpdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v2] ACPI: AC: fix some coding style issues

for single statement blocks WARNING: void function return statements are not generally useful WARNING: CVS style keyword markers, these will _not_ be updated Signed-off-by: Xiaofei Tan --- drivers/acpi/ac.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git

[PATCH 01/15] ACPI: APD: fix a block comment align issue

Fix the following coding style issue reported by checkpatch.pl. WARNING: Block comments should align the * on each line +/** +* Create platform device during acpi scan attach handle. Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_apd.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 14/15] ACPI: device_sysfs: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Missing a blank line after declarations WARNING: Block comments should align the * on each line ERROR: open brace '{' following function definitions go on the next line Signed-off-by: X

[PATCH 00/15] acpi: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl. Xiaofei Tan (15): ACPI: APD: fix a block comment align issue ACPI: processor: fix some coding style issues ACPI: acpi_dbg: fix some coding style issues ACPI: acpi_fpdt: replace __attribute__((packed)) by __packed remove useless

[PATCH 05/15] remove useless return statement for void function

Remove useless return statement for void function, reported by checkpatch.pl. WARNING: void function return statements are not generally useful FILE: drivers/acpi/acpi_ipmi.c:482: + return; +} Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_ipmi.c | 1 - 1 file changed, 1 deletion

[PATCH 10/15] ACPI: button: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line ERROR: code indent should use tabs where possible Signed-off-by: Xiaofei Tan --- drivers/acpi

[PATCH 12/15] ACPI: custom_method: fix a coding style issue

Fix the following coding style issue reported by checkpatch.pl ERROR: "foo * bar" should be "foo *bar" FILE: drivers/acpi/custom_method.c:22: +static ssize_t cm_write(struct file *file, const char __user * user_buf, Signed-off-by: Xiaofei Tan --- drivers/acpi/custom_met

[PATCH 07/15] ACPI: acpi_memhotplug: fix a coding style issue

Fix the following coding style issue reported by checkpatch.pl WARNING: __initdata should be placed after acpi_no_memhotplug FILE: drivers/acpi/acpi_memhotplug.c:326: +static bool __initdata acpi_no_memhotplug; Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_memhotplug.c | 2 +- 1 file

[PATCH 09/15] ACPI: battery: fix some coding style issues

ERROR: spaces required around that '?' (ctx:WxV) WARNING: Block comments should align the * on each line Signed-off-by: Xiaofei Tan --- drivers/acpi/battery.c | 64 ++ 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/dr

[PATCH 03/15] ACPI: acpi_dbg: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: space prohibited between function name and open parenthesis WARNING: else is not generally useful after a break or return Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_dbg.c | 40

[PATCH 11/15] ACPI: cppc_acpi: fix some coding style issues

Signed-off-by: Xiaofei Tan --- drivers/acpi/cppc_acpi.c | 71 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index ae53740..3dbaf47 100644 --- a/drivers/acpi/cppc_acpi.c +++ b

[PATCH 06/15] ACPI: acpi_lpss: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: Missing a blank line after declarations Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_lpss.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH 13/15] ACPI: device_pm: fix some coding style issues

Fix the following coding style issue reported by checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Xiaofei Tan --- drivers/acpi/device_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index 0961537

[PATCH 02/15] ACPI: processor: fix some coding style issues

: Xiaofei Tan --- drivers/acpi/acpi_processor.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index fc89f3a..2d5bd2a 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c

[PATCH 15/15] ACPI: dock: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Missing a blank line after declarations ERROR: spaces required around that ':' WARNING: Statements should start on a tabstop Signed-off-by: Xiaofei Tan --- drivers/acpi/dock.c | 7 +

[PATCH 08/15] ACPI: acpi_pad: fix a coding style issue

Fix the following coding style issue reported by checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_pad.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c index b84ab72

[PATCH 04/15] ACPI: acpi_fpdt: replace __attribute__((packed)) by __packed

Replace __attribute__((packed)) by __packed following the advice of checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_fpdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c index a89a806..690a88a 100644

Re: [PATCH 05/15] remove useless return statement for void function

Oh, sorry, the title doesn't contain subsystem and module name. I'll send v2 later. Please ignore this one. thanks. On 2021/3/27 14:40, Xiaofei Tan wrote: Remove useless return statement for void function, reported by checkpatch.pl. WARNING: void function return statements are not

Re: [PATCH 00/15] acpi: fix some coding style issues

Please ignore this patch set. thanks. On 2021/3/27 14:40, Xiaofei Tan wrote: Fix some coding style issues reported by checkpatch.pl. Xiaofei Tan (15): ACPI: APD: fix a block comment align issue ACPI: processor: fix some coding style issues ACPI: acpi_dbg: fix some coding style issues

[PATCH v2 00/15] acpi: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl. Differences from v1 to v2: - Add subsystem and module name in the name of patch 05/15. - Change to use more proper module name for some patch names. Xiaofei Tan (15): ACPI: APD: fix a block comment align issue ACPI: processor: fix some

[PATCH v2 01/15] ACPI: APD: fix a block comment align issue

Fix the following coding style issue reported by checkpatch.pl. WARNING: Block comments should align the * on each line +/** +* Create platform device during acpi scan attach handle. Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_apd.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed

Replace __attribute__((packed)) by __packed following the advice of checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_fpdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c index a89a806..690a88a 100644

[PATCH v2 03/15] ACPI: debug: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: space prohibited between function name and open parenthesis WARNING: else is not generally useful after a break or return Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_dbg.c | 40

[PATCH v2 05/15] ACPI: ipmi: remove useless return statement for void function

Remove useless return statement for void function, reported by checkpatch.pl. WARNING: void function return statements are not generally useful FILE: drivers/acpi/acpi_ipmi.c:482: + return; +} Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_ipmi.c | 1 - 1 file changed, 1 deletion

[PATCH v2 12/15] ACPI: custom_method: fix a coding style issue

Fix the following coding style issue reported by checkpatch.pl ERROR: "foo * bar" should be "foo *bar" FILE: drivers/acpi/custom_method.c:22: +static ssize_t cm_write(struct file *file, const char __user * user_buf, Signed-off-by: Xiaofei Tan --- drivers/acpi/custom_met

[PATCH v2 07/15] ACPI: memhotplug: fix a coding style issue

Fix the following coding style issue reported by checkpatch.pl WARNING: __initdata should be placed after acpi_no_memhotplug FILE: drivers/acpi/acpi_memhotplug.c:326: +static bool __initdata acpi_no_memhotplug; Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_memhotplug.c | 2 +- 1 file

[PATCH v2 08/15] ACPI: acpi_pad: fix a coding style issue

Fix the following coding style issue reported by checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_pad.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c index b84ab72

[PATCH v2 09/15] ACPI: battery: fix some coding style issues

ERROR: spaces required around that '?' (ctx:WxV) WARNING: Block comments should align the * on each line Signed-off-by: Xiaofei Tan --- drivers/acpi/battery.c | 64 ++ 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/dr

[PATCH v2 06/15] ACPI: LPSS: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: simple_strtol is obsolete, use kstrtol instead WARNING: Missing a blank line after declarations Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_lpss.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH v2 11/15] ACPI: CPPC: fix some coding style issues

Signed-off-by: Xiaofei Tan --- drivers/acpi/cppc_acpi.c | 71 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index ae53740..3dbaf47 100644 --- a/drivers/acpi/cppc_acpi.c +++ b

[PATCH v2 13/15] ACPI: PM: fix some coding style issues

Fix the following coding style issue reported by checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Xiaofei Tan --- drivers/acpi/device_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index 0961537

[PATCH v2 02/15] ACPI: processor: fix some coding style issues

: Xiaofei Tan --- drivers/acpi/acpi_processor.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index fc89f3a..2d5bd2a 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c

[PATCH v2 10/15] ACPI: button: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line ERROR: code indent should use tabs where possible Signed-off-by: Xiaofei Tan --- drivers/acpi

[PATCH v2 15/15] ACPI: dock: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Missing a blank line after declarations ERROR: spaces required around that ':' WARNING: Statements should start on a tabstop Signed-off-by: Xiaofei Tan --- drivers/acpi/dock.c | 7 +

[PATCH v2 14/15] ACPI: sysfs: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Missing a blank line after declarations WARNING: Block comments should align the * on each line ERROR: open brace '{' following function definitions go on the next line Signed-off-by: X

Re: [PATCH v2 06/15] ACPI: LPSS: fix some coding style issues

Hi Andy, On 2021/3/27 16:17, Andy Shevchenko wrote: On Saturday, March 27, 2021, Xiaofei Tan mailto:tanxiao...@huawei.com>> wrote: Fix some coding style issues reported by checkpatch.pl <http://checkpatch.pl>, including following types: WARNING: simple_strtol

Re: [PATCH v2 06/15] ACPI: LPSS: fix some coding style issues

Hi Andy, On 2021/3/27 16:19, Andy Shevchenko wrote: On Saturday, March 27, 2021, Xiaofei Tan mailto:tanxiao...@huawei.com>> wrote: Fix some coding style issues reported by checkpatch.pl <http://checkpatch.pl>, including following types: WARNING: simple_strtol

Re: [PATCH 00/15] acpi: fix some coding style issues

OK. thanks for reviewing this patch set. On 2021/3/27 16:21, Andy Shevchenko wrote: On Saturday, March 27, 2021, Xiaofei Tan mailto:tanxiao...@huawei.com>> wrote: Fix some coding style issues reported by checkpatch.pl <http://checkpatch.pl>. NAK until it’s proven t

[PATCH v3 07/12] ACPI: button: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line ERROR: code indent should use tabs where possible Signed-off-by: Xiaofei Tan --- drivers/acpi

[PATCH v3 08/12] ACPI: CPPC: fix some coding style issues

Signed-off-by: Xiaofei Tan --- drivers/acpi/cppc_acpi.c | 71 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index ae53740..3dbaf47 100644 --- a/drivers/acpi/cppc_acpi.c +++ b

[PATCH v3 02/12] ACPI: processor: fix some coding style issues

: Xiaofei Tan --- drivers/acpi/acpi_processor.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index fc89f3a..2d5bd2a 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c

[PATCH v3 10/12] ACPI: PM: add a missed blank line after declarations

Add a missed blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/acpi/device_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index 0961537..16c0fe8 100644 --- a/drivers/acpi/device_pm.c

[PATCH v3 00/12] acpi: fix some coding style issues

module name for some patch names. Xiaofei Tan (12): ACPI: APD: fix a block comment align issue ACPI: processor: fix some coding style issues ACPI: ipmi: remove useless return statement for void function ACPI: LPSS: add a missed blank line after declarations ACPI: acpi_pad: add a missed

[PATCH v3 06/12] ACPI: battery: fix some coding style issues

ERROR: spaces required around that '?' (ctx:WxV) WARNING: Block comments should align the * on each line Signed-off-by: Xiaofei Tan --- drivers/acpi/battery.c | 63 +++--- 1 file changed, 34 insertions(+), 29 deletions(-) diff --git a/dr

[PATCH v3 12/12] ACPI: dock: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Missing a blank line after declarations ERROR: spaces required around that ':' WARNING: Statements should start on a tabstop Signed-off-by: Xiaofei Tan --- drivers/acpi/dock.c | 7 +

[PATCH v3 11/12] ACPI: sysfs: fix some coding style issues

Fix some coding style issues reported by checkpatch.pl, including following types: WARNING: Missing a blank line after declarations WARNING: Block comments should align the * on each line ERROR: open brace '{' following function definitions go on the next line Signed-off-by: X

[PATCH v3 05/12] ACPI: acpi_pad: add a missed blank line after declarations

Add a missed blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_pad.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c index b84ab72..df4adeb 100644 --- a/drivers/acpi/acpi_pad.c

[PATCH v3 03/12] ACPI: ipmi: remove useless return statement for void function

Remove useless return statement for void function, reported by checkpatch.pl. WARNING: void function return statements are not generally useful FILE: drivers/acpi/acpi_ipmi.c:482: + return; +} Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_ipmi.c | 1 - 1 file changed, 1 deletion

[PATCH v3 01/12] ACPI: APD: fix a block comment align issue

Fix the following coding style issue reported by checkpatch.pl. WARNING: Block comments should align the * on each line +/** +* Create platform device during acpi scan attach handle. Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_apd.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v3 09/12] ACPI: custom_method: fix a coding style issue

Fix the following coding style issue reported by checkpatch.pl ERROR: "foo * bar" should be "foo *bar" FILE: drivers/acpi/custom_method.c:22: +static ssize_t cm_write(struct file *file, const char __user * user_buf, Signed-off-by: Xiaofei Tan --- drivers/acpi/custom_met

[PATCH v3 04/12] ACPI: LPSS: add a missed blank line after declarations

Add a missed blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/acpi/acpi_lpss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c index be73974..ca742f1 100644 --- a/drivers/acpi/acpi_lpss.c

[PATCH v2 05/10] tty: tty_jobctrl: Remove spaces before tabs

Remove spaces before tabs following the advice of checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 7003b6b..9cbb08a 100644 --- a/drivers

[PATCH v2 06/10] tty: tty_ldisc: Fix an issue of code indent should use tabs

Fix an issue of code indent should use tabs, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 1ba74d6..2992319 100644 --- a/drivers/tty

[PATCH v2 00/10] tty: Fix some coding style issues

Fix some issues reported by checkpatch.pl. All of them are coding style issues, no function changes. Differences from v1 to v2: - Remove one redundant tab for the patch 02/10. - Add some expression optimization for some sentenses following - Jiri's advice for the patch 04/10. Xiaofei Ta

[PATCH v2 01/10] tty/sysrq: Add a blank line after declarations

Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 959f9e1..0372ed7 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c

[PATCH v2 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

Fix coding style issues of block comments, reported by checkpatch.pl. Besides, do some expression optimization for the sentenses. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/tty

[PATCH v2 10/10] tty: tty_ldisc: Remove the repeated word 'the'

Remove the repeated word 'the' following advice of checkpatch.pl Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 56e67f7..fdc4fa3 100644 --- a/d

[PATCH v2 08/10] tty: tty_ldisc: Fix coding style issues of block comments

Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index df0b589

[PATCH v2 03/10] tty: tty_jobctrl: Add a blank line after declarations

Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 4b751b9..86070f7 100644 --- a/drivers/tty/tty_jobctrl.c

[PATCH v2 07/10] tty: tty_ldisc: Add a blank line after declarations

Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 2992319..df0b589 100644 --- a/drivers/tty/tty_ldisc.c +++ b

[PATCH v2 02/10] tty/sysrq: Fix issues of code indent should use tabs

Fix issues of code indent should use tabs, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/sysrq.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 0372ed7..6628792

[PATCH v2 09/10] tty: tty_ldisc: Do not use assignment in if condition

Do not use assignment in if condition following the advice of checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 874d238..56e67f7 100644 --- a/drivers

Re: [PATCH v2 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

Hi Jiri, On 2021/4/7 13:26, Jiri Slaby wrote: On 06. 04. 21, 13:24, Xiaofei Tan wrote: Fix coding style issues of block comments, reported by checkpatch.pl. Besides, do some expression optimization for the sentenses. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16

[PATCH v3 03/10] tty: tty_jobctrl: Add a blank line after declarations

Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 4b751b9..86070f7 100644 --- a/drivers/tty/tty_jobctrl.c

[PATCH v3 02/10] tty/sysrq: Fix issues of code indent should use tabs

Fix issues of code indent should use tabs, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/sysrq.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 0372ed7..6628792

[PATCH v3 01/10] tty/sysrq: Add a blank line after declarations

Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 959f9e1..0372ed7 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c

[PATCH v3 00/10] tty: Fix some coding style issues

expression optimization for some sentenses following - Jiri's advice for the patch 04/10. Xiaofei Tan (10): tty/sysrq: Add a blank line after declarations tty/sysrq: Fix issues of code indent should use tabs tty: tty_jobctrl: Add a blank line after declarations tty: tty_jobctrl: Fix coding style

[PATCH v3 07/10] tty: tty_ldisc: Add a blank line after declarations

Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 2992319..df0b589 100644 --- a/drivers/tty/tty_ldisc.c +++ b

[PATCH v3 05/10] tty: tty_jobctrl: Remove spaces before tabs

Remove spaces before tabs following the advice of checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 5b4ab16..72df97b 100644 --- a/drivers

[PATCH v3 09/10] tty: tty_ldisc: Do not use assignment in if condition

Do not use assignment in if condition following the advice of checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 874d238..56e67f7 100644 --- a/drivers

[PATCH v3 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

Fix coding style issues of block comments, reported by checkpatch.pl. Besides, do some expression optimization for the sentenses. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/tty

[PATCH v3 10/10] tty: tty_ldisc: Remove the repeated word 'the'

Remove the repeated word 'the' following advice of checkpatch.pl Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 56e67f7..fdc4fa3 100644 --- a/d

[PATCH v3 08/10] tty: tty_ldisc: Fix coding style issues of block comments

Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index df0b589

[PATCH v3 06/10] tty: tty_ldisc: Fix an issue of code indent should use tabs

Fix an issue of code indent should use tabs, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index 1ba74d6..2992319 100644 --- a/drivers/tty

[PATCH] tty: pty: Add a blank line after declarations

Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/pty.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c index 5e23745..106265a 100644 --- a/drivers/tty/pty.c +++ b/drivers/tty/pty.c @@ -159,6

Re: [PATCH v5] ACPI / APEI: fix the regression of synchronous external aborts occur in user-mode

Hi James, Boris a friendly ping.. any comments for this ? On 2021/2/5 20:55, Rafael J. Wysocki wrote: On Tue, Jan 26, 2021 at 2:32 PM tanxiaofei wrote: @James Hi James, please help to review this patch. Thank you very much. :) James, Boris, any comments? On 2020/12/10 20:09, Xiaofei Tan

[PATCH 00/10] tty: Fix some coding style issues

Fix some issues reported by checkpatch.pl. All of them are coding style issues, no function changes. Xiaofei Tan (10): tty/sysrq: Add a blank line after declarations tty/sysrq: Fix issues of code indent should use tabs tty: tty_jobctrl: Add a blank line after declarations tty: tty_jobctrl

[PATCH 03/10] tty: tty_jobctrl: Add a blank line after declarations

Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 4b751b9..86070f7 100644 --- a/drivers/tty/tty_jobctrl.c

[PATCH 02/10] tty/sysrq: Fix issues of code indent should use tabs

Fix issues of code indent should use tabs, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/sysrq.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 0372ed7..1ece100

  1   2   >