Re: KASAN: slab-out-of-bounds Read in erspan_xmit

2018-01-23 Thread William Tu
; to generate packet. but I have no clue where to run it. Maybe I'm still missing something? Thanks a lot William On Mon, Jan 22, 2018 at 2:57 PM, William Tu wrote: > On Mon, Jan 22, 2018 at 2:45 PM, David Ahern wrote: >> [ cc William Tu ] >> >> On 1/22/18 12:58 PM, syzbo

Re: KASAN: slab-out-of-bounds Read in erspan_xmit

2018-01-23 Thread William Tu
Thanks for the reply. On Tue, Jan 23, 2018 at 11:03 AM, Dmitry Vyukov wrote: > On Tue, Jan 23, 2018 at 7:58 PM, David Ahern wrote: >> On 1/23/18 11:50 AM, William Tu wrote: >>> Hi, >>> >>> I'm new to kasan and trying to follow this instruction to reprodu

Re: KASAN: slab-out-of-bounds Read in erspan_xmit

2018-01-23 Thread William Tu
On Tue, Jan 23, 2018 at 11:45 AM, Dmitry Vyukov wrote: > On Tue, Jan 23, 2018 at 8:17 PM, William Tu wrote: >> Thanks for the reply. >> >> On Tue, Jan 23, 2018 at 11:03 AM, Dmitry Vyukov wrote: >>> On Tue, Jan 23, 2018 at 7:58 PM, David Ahern wrote: >>>

Re: KASAN: slab-out-of-bounds Read in erspan_xmit

2018-01-22 Thread William Tu
On Mon, Jan 22, 2018 at 2:45 PM, David Ahern wrote: > [ cc William Tu ] > > On 1/22/18 12:58 PM, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on net-next commit >> 9d6474e458b13a94a0d5b141f2b8f38adf1991ae (Mon Jan 22 02:55:38 2018 +) >> t

Re: [PATCH][next] gre: fix TUNNEL_SEQ bit check on sequence numbering

2018-03-21 Thread William Tu
|. > > Detected by CoverityScan, CID#1466039 ("Operands don't affect result") > > Fixes: 77a5196a804e ("gre: add sequence number for collect md mode.") > Signed-off-by: Colin Ian King Thanks for the fix! btw, how can I access the CoverityScan result with this CI

Re: [PATCH net] ixgbe: fix double clean of tx descriptors with xdp

2019-08-21 Thread William Tu
On Wed, Aug 21, 2019 at 9:57 AM Alexander Duyck wrote: > > On Wed, Aug 21, 2019 at 9:22 AM Ilya Maximets wrote: > > > > On 21.08.2019 4:17, Alexander Duyck wrote: > > > On Tue, Aug 20, 2019 at 8:58 AM Ilya Maximets > > > wrote: > > >> > > >> On 20.08.2019 18:35, Alexander Duyck wrote: > > >>> O

Re: [PATCH net] ixgbe: fix double clean of tx descriptors with xdp

2019-08-22 Thread William Tu
On Thu, Aug 22, 2019 at 1:17 AM Ilya Maximets wrote: > > On 22.08.2019 0:38, William Tu wrote: > > On Wed, Aug 21, 2019 at 9:57 AM Alexander Duyck > > wrote: > >> > >> On Wed, Aug 21, 2019 at 9:22 AM Ilya Maximets > >> wrote: > >>> >

Re: [PATCH net v2] ixgbe: fix double clean of tx descriptors with xdp

2019-08-22 Thread William Tu
'ixgbe_xsk_clean_tx_ring()' since we don't need most of the > complications implemented in the regular 'ixgbe_clean_tx_irq()' > and we're allowed to directly use 'next_to_clean' and 'next_to_use' > indexes. > > Fixes: 8221c5eba8c

Re: [PATCH net v3] ixgbe: fix double clean of tx descriptors with xdp

2019-08-22 Thread William Tu
2: > > * 'ixgbe_clean_xdp_tx_irq()' refactored to look more like > > 'ixgbe_xsk_clean_tx_ring()'. > > > > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 29 > > 1 file changed, 11 insertions(+), 18 deletions(-) > > Thanks for addressing my concerns. > > Acked-by: Alexander Duyck Thanks. Tested-by: William Tu

Re: [PATCH net v3] ixgbe: fix double clean of tx descriptors with xdp

2019-08-23 Thread William Tu
On Thu, Aug 22, 2019 at 11:10 PM Björn Töpel wrote: > > On 2019-08-22 19:32, William Tu wrote: > > On Thu, Aug 22, 2019 at 10:21 AM Alexander Duyck > > wrote: > >> > >> On Thu, Aug 22, 2019 at 10:12 AM Ilya Maximets > >> wrote: > >>>

Re: [PATCH] erspan: remove the incorrect mtu limit for erspan

2019-10-03 Thread William Tu
d link show erspan0 > 21: erspan0@NONE: mtu 1600 qdisc noop state DOWN > mode DEFAULT group default qlen 1000 > link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu > 68 maxmtu 0 > > Fixes: 61e84623ace3 ("net: centralize net_device min/max MTU checking&qu

Re: [PATCH] ip6erspan: remove the incorrect mtu limit for ip6erspan

2019-10-08 Thread William Tu
the dev mtu of the erspan device to not be greater > than 1500, this limit value is not correct for ip6erspan tap > device. > > Signed-off-by: Haishuang Yan Thanks for the patch. Acked-by: William Tu > --- > net/ipv6/ip6_gre.c | 1 + > 1 file changed, 1 insertion(+) &

Re: [PATCH] ip6_gre: reload ipv6h in prepare_ip6gre_xmit_ipv6

2019-07-24 Thread William Tu
On Wed, Jul 24, 2019 at 08:00:42PM +0800, Haishuang Yan wrote: > Since ip6_tnl_parse_tlv_enc_lim() can call pskb_may_pull() > which may change skb->data, so we need to re-load ipv6h at > the right place. > > Fixes: 898b29798e36 ("ip6_gre: Refactor ip6gre xmit codes"

Re: [PATCH bpf v3] xdp: fix hang while unregistering device bound to xdp socket

2019-06-10 Thread William Tu
the resources and unref device. > > This should also allow socket killing via ss(8) utility. > > Fixes: 965a99098443 ("xsk: add support for bind for Rx") > Signed-off-by: Ilya Maximets > --- Tested-by: William Tu

Re: [PATCH bpf v2] xdp: fix race on generic receive path

2019-07-03 Thread William Tu
; broader perspective and find the most low hanging fruit. > > Thanks Ilya for this fix. > > Acked-by: Magnus Karlsson > > > Fixes: c497176cb2e4 ("xsk: add Rx receive functions and poll support") > > Signed-off-by: Ilya Maximets > > --- Tested on my machine and works ok. Tested-by: William Tu

Re: [PATCH bpf] xdp: fix possible cq entry leak

2019-07-08 Thread William Tu
Good catch, Ilya! Thanks for the patch! > > Acked-by: Björn Töpel > Thanks Tested-by: William Tu

Re: [PATCH 2/2] erspan: fix error handling for erspan tunnel

2018-09-10 Thread William Tu
On Mon, Sep 10, 2018 at 7:20 AM Haishuang Yan wrote: > > When processing icmp unreachable message for erspan tunnel, tunnel id > should be erspan_net_id instead of ipgre_net_id. > > Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") > Cc:

Re: [PATCH v3,net-next 2/2] ip6_gre: fix potential memory leak in ip6erspan_rcv

2017-12-20 Thread William Tu
On Tue, Dec 19, 2017 at 6:07 PM, Haishuang Yan wrote: > If md is NULL, tun_dst must be freed, otherwise it will cause memory > leak. > > Fixes: ef7baf5e083c ("ip6_gre: add ip6 erspan collect_md mode") > Cc: William Tu > Signed-off-by: Haishuang Yan > > --- &

Re: [PATCH 1/2] ip_gre: fix error path when erspan_rcv failed

2017-12-14 Thread William Tu
support for ERSPAN") > Cc: William Tu > Signed-off-by: Haishuang Yan > --- Thanks for the patch. Acked-by: William Tu

Re: [PATCH 2/2] ip6_gre: fix error path when ip6erspan_rcv failed

2017-12-14 Thread William Tu
On Thu, Dec 14, 2017 at 8:05 AM, Haishuang Yan wrote: > Same as ipv4 code, when ip6erspan_rcv call return PACKET_REJECT, we > should call icmpv6_send to send icmp unreachable message in error path. > > Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support") >

Re: [PATCH 1/2] ip_gre: fix potential memory leak in erspan_rcv

2017-12-14 Thread William Tu
On Thu, Dec 14, 2017 at 7:15 AM, Haishuang Yan wrote: > If md is NULL, tun_dst must be freed, otherwise it will cause memory > leak. > > Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") > Cc: William Tu > Signed-off-by: Haishuang Yan &g

Re: [PATCH] ip_gre: fix wrong return value of erspan_rcv

2017-12-15 Thread William Tu
On Thu, Dec 14, 2017 at 6:46 PM, Haishuang Yan wrote: > If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM. > > Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") > Cc: William Tu > Signed-off-by: Haishuang Yan > --- Thank

Re: [PATCH] ip6_gre: fix a pontential issue in ip6erspan_rcv

2017-12-15 Thread William Tu
On Thu, Dec 14, 2017 at 6:46 PM, Haishuang Yan wrote: > pskb_may_pull() can change skb->data, so we need to load ipv6h/ershdr at > the right place. > > Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support") > Cc: William Tu > Signed-off-by: Haishuang Y