from the socket code.
>> sysctl_net_ll_poll controls how many microseconds to poll.
>> Default is zero (disabled).
>> Individual protocol support will be added by subsequent patches.
>>
>> Signed-off-by: Alexander Duyck
>> Signed-off-by: Jesse Brandeburg
>&g
net/ipv4/proc.c |1
>> net/socket.c |6 ++
>> 12 files changed, 208 insertions(+), 2 deletions(-)
>> create mode 100644 include/net/ll_poll.h
>
> Acked-by: Eric Dumazet
>
Tested-by: Willem de Bruijn
Per Eliezer's request, I
s changed, 88 insertions(+), 0 deletions(-)
>
> Signed-off-by: Eric Dumazet
>
Tested-by: Willem de Bruijn
(per Eliezer's request)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
;> Signed-off-by: Eliezer Tamir
>> ---
>>
>> net/core/datagram.c |4
>> net/ipv4/udp.c |6 +-
>> net/ipv6/udp.c |6 +-
>> 3 files changed, 14 insertions(+), 2 deletions(-)
>
> Acked-by: Eric Dumazet
>
Tested
recvmsg(), when there is no data in the socket we busy-poll.
>> This is a good example of how to add busy-poll support to more protocols.
>>
>> Signed-off-by: Alexander Duyck
>> Signed-off-by: Jesse Brandeburg
>> Signed-off-by: Eliezer Tamir
>> ---
>
> Ac
On Tue, May 21, 2013 at 2:54 AM, Eliezer Tamir
wrote:
> On 20/05/2013 23:20, Or Gerlitz wrote:
>>
>> On Mon, May 20, 2013 at 1:16 PM, Eliezer Tamir
>> wrote:
>>>
>>> Add the ixgbe driver code implementing ndo_ll_poll.
>>> It should be easy for other drivers to do something similar
>>> in order to
>> 2. How is the logic aware of RSS and RFS?
>>
>> With TCP sockets, the driver knows the specific ring it need to poll so
>> this should be mapped and provide the best latency.
>
>
> This code is blissfully oblivious of RFS and RSS, it only assumes that the
> packets for a socket are likely to con
> UML is still too strange for valgrind, despite progress on both sides
> (valgrind accepting more strange things and UML becoming less
> strange).
>
> I tried grinding UML a month or so ago, and its use of clone was a
> sticking point.
>
I think I read your remark, yes. Thanks for the update; I h
On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote:
> tun now use flow caches based automatic queue steering method. This
> may not suffice all user cases. To extend it to be able to use more
> flow steering policy, this patch abstracts flow steering logic into
> tun_steering_ops, then we can decla
On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote:
> This patch introduces new ioctl for change packet steering policy for
> tun. Only automatic flow steering is supported, more policies will
> come.
>
> Signed-off-by: Jason Wang
> ---
> drivers/net/tun.c | 35 +
On Sat, Oct 21, 2017 at 9:56 PM, Wei Wei wrote:
> I have uploaded the VM core dump [1]. And I don’t know if these logs are
> helpful in the case of
> failing to get the C reproducer currently.
>
> [1] https://github.com/dotweiba/skb_clone_atomic_inc_bug/blob/master/vmcore.gz
Thanks. So this woul
On Wed, Oct 25, 2017 at 2:24 PM, Willem de Bruijn
wrote:
> On Sat, Oct 21, 2017 at 9:56 PM, Wei Wei wrote:
>> I have uploaded the VM core dump [1]. And I don’t know if these logs are
>> helpful in the case of
>> failing to get the C reproducer currently.
>>
&g
On Thu, Nov 2, 2017 at 12:51 PM, Jason Wang wrote:
>
>
> On 2017年11月02日 11:45, Michael S. Tsirkin wrote:
>>
>> On Thu, Nov 02, 2017 at 11:43:48AM +0800, Jason Wang wrote:
>>>
>>>
>>> On 2017年11月02日 09:11, Willem de Bruijn wrote:
>>>
On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote:
> This patch introduces an eBPF based queue selection method based on
> the flow steering policy ops. Userspace could load an eBPF program
> through TUNSETSTEERINGEBPF. This gives much more flexibility compare
> to simple but hard coded policy in
On Fri, Nov 3, 2017 at 5:56 PM, Willem de Bruijn
wrote:
> On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote:
>> This patch introduces an eBPF based queue selection method based on
>> the flow steering policy ops. Userspace could load an eBPF program
>> through TUNSETSTEERING
On Fri, Jan 5, 2018 at 4:54 AM, Jason Wang wrote:
> This patch allows userspace to attach eBPF filter to tun. This will
> allow to implement VM dataplane filtering in a more efficient way
> compared to cBPF filter by allowing either qemu or libvirt to
> attach eBPF filter to tun.
>
> Signed-off-by
On Tue, Jan 2, 2018 at 12:23 PM, Willem de Bruijn
wrote:
>> Actually, changes just to inet_gso_segment and ipv6_gso_segment
>> will suffice:
>>
>>bool udpfrag = false, fixedid = false, gso_partial, encap;
>> struct sk_buff *segs = ERR_PTR(-EINVAL);
On Wed, Sep 19, 2018 at 12:02 PM Kirill Tkhai wrote:
>
> On 19.09.2018 18:49, Eric Dumazet wrote:
> > On Wed, Sep 19, 2018 at 8:41 AM Kirill Tkhai wrote:
> >>
> >> On 19.09.2018 17:55, Eric Dumazet wrote:
> >>> On Wed, Sep 19, 2018 at 5:29 AM Kirill Tkhai wrote:
>
> Many workloads have
> @@ -394,25 +394,30 @@ static void __packet_set_status(struct packet_sock *po,
> void *frame, int status)
> static int __packet_get_status(struct packet_sock *po, void *frame)
> {
> union tpacket_uhdr h;
> -
> - smp_rmb();
> + int status;
>
> h.raw = frame;
>
On Fri, Jul 6, 2018 at 6:16 PM Willem de Bruijn
wrote:
>
> On Fri, Jul 6, 2018 at 1:55 PM syzbot
> wrote:
> >
> > syzbot has found a reproducer for the following crash on:
> >
> > HEAD commit:70ba5b6db96f ipv4: Return EINVAL when ping_group_range sys..
&g
On Sun, Jul 8, 2018 at 6:58 PM Willem de Bruijn
wrote:
>
> On Fri, Jul 6, 2018 at 6:16 PM Willem de Bruijn
> wrote:
> >
> > On Fri, Jul 6, 2018 at 1:55 PM syzbot
> > wrote:
> > >
> > > syzbot has found a reproducer for the following crash on:
From: Willem de Bruijn
Apply commit syntax validation to Fixes tags:
Remove the existing exclusion match on " !~ /\bfixes ..." and
generalize keyword match to "[Cc]ommit|Fixes:".
Unlike commit tags, fixes tags must take up an entire line and
may not have line breaks.
When
On Fri, May 18, 2018 at 11:44 AM, David Miller wrote:
> From: Eric Dumazet
> Date: Fri, 18 May 2018 08:30:43 -0700
>
>> We probably need to revert Willem patch
>> (7ce875e5ecb8562fd44040f69bda96c999e38bbc)
>
> Is it really valid to reach ip_recv_err with an ipv6 socket?
I guess the issue is tha
On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn
wrote:
> On Fri, May 18, 2018 at 11:44 AM, David Miller wrote:
>> From: Eric Dumazet
>> Date: Fri, 18 May 2018 08:30:43 -0700
>>
>>> We probably need to revert Willem patch
>>> (7ce875e5ecb8562fd44040f69bd
On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn
wrote:
> On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn
> wrote:
>> On Fri, May 18, 2018 at 11:44 AM, David Miller wrote:
>>> From: Eric Dumazet
>>> Date: Fri, 18 May 2018 08:30:43 -0700
>>>
>&
On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn
wrote:
> On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn
> wrote:
>> On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn
>> wrote:
>>> On Fri, May 18, 2018 at 11:44 AM, David Miller wrote:
>>>> From: Eric
On Fri, May 18, 2018 at 4:03 AM, DaeRyong Jeong wrote:
> We report the crash: WARNING in __static_key_slow_dec
>
> This crash has been found in v4.8 using RaceFuzzer (a modified
> version of Syzkaller), which we describe more at the end of this
> report.
> Even though v4.8 is the relatively old ve
On Tue, Dec 11, 2018 at 3:31 PM Deepa Dinamani wrote:
>
> With the new y2038 safe timestamping options added, update the
> documentation to reflect the changes.
>
> Signed-off-by: Deepa Dinamani
Thanks for adding documentation.
Acked-by: Willem de Bruijn
One suggestion below i
On Tue, Dec 11, 2018 at 3:30 PM Deepa Dinamani wrote:
>
> Add SO_TIMESTAMP_NEW and SO_TIMESTAMPNS_NEW variants of
> socket timestamp options.
> These are the y2038 safe versions of the SO_TIMESTAMP_OLD
> and SO_TIMESTAMPNS_OLD for all architectures.
>
> Note that the format of scm_timestamping.ts[
On Tue, Dec 11, 2018 at 3:30 PM Deepa Dinamani wrote:
>
> Add SO_TIMESTAMPING_NEW variant of socket timestamp options.
> This is the y2038 safe versions of the SO_TIMESTAMPING_OLD
> for all architectures.
>
> Signed-off-by: Deepa Dinamani
> Cc: ch...@zankel.net
> Cc: fenghua...@intel.com
> Cc: r.
> This did not address yet the previous comments on consistency and
> unnecessary code churn.
>
> The existing logic to differentiate SO_TIMESTAMP from SO_TIMESTAMPNS
> in both tcp_recv_timestamp and __sock_recv_timestamp is
>
> if (sock_flag(sk, SOCK_RCVTSTAMP)) {
> if (sock_flag(sk, SOCK_
On Fri, Dec 14, 2018 at 8:07 PM Deepa Dinamani wrote:
>
> > > diff --git a/arch/alpha/include/uapi/asm/socket.h
> > > b/arch/alpha/include/uapi/asm/socket.h
> > > index 00e45c80e574..352e3dc0b3d9 100644
> > > --- a/arch/alpha/include/uapi/asm/socket.h
> > > +++ b/arch/alpha/include/uapi/asm/socke
> 3 reasons for not doing this:
>
> 1. We do not want to break userspace. If we move this to
> linux/socket.h all the userspace programs now have to include
> linux/socket.h or get this definition through a new libc.
> 2. All the socket options are together in the file asm/socket.h. It
> doesn't se
On Sun, Dec 16, 2018 at 2:19 PM David Miller wrote:
>
> From: Paolo Abeni
> Date: Sun, 16 Dec 2018 19:55:40 +0100
>
> > Again, I messed it! I'm really sorry to waste everybody's time.
> > I was unable to give proper coverage with different configs. I tested
> > vs.:
> >
> > CONFIG_IPV6=ymn
> > CO
On Thu, Dec 20, 2018 at 6:15 AM Ido Schimmel wrote:
>
> +Willem
>
> On Thu, Dec 20, 2018 at 08:45:40AM +0100, Christian Borntraeger wrote:
> > Folks,
> >
> > I got this warning today. I cant tell when and why this happened, so I do
> > not know yet how to reproduce.
> > Maybe someone has a quick
On Thu, Dec 20, 2018 at 9:16 AM Ido Schimmel wrote:
>
> On Thu, Dec 20, 2018 at 09:04:25AM -0500, Willem de Bruijn wrote:
> > On Thu, Dec 20, 2018 at 6:15 AM Ido Schimmel wrote:
> > >
> > > +Willem
> > >
> > > On Thu, Dec 20, 2018 at 08:45:40AM +
On Thu, Dec 20, 2018 at 9:34 AM Willem de Bruijn
wrote:
>
> On Thu, Dec 20, 2018 at 9:16 AM Ido Schimmel wrote:
> >
> > On Thu, Dec 20, 2018 at 09:04:25AM -0500, Willem de Bruijn wrote:
> > > On Thu, Dec 20, 2018 at 6:15 AM Ido Schimmel wrote:
> > > >
>
On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel wrote:
>
> On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote:
> > On 20.12.2018 10:12, Ido Schimmel wrote:
> > > +Willem
> > >
> > > On Thu, Dec 20, 2018 at 08:45:40AM +0100, Christian Borntraeger wrote:
> > >> Folks,
> > >>
> > >>
On Fri, Dec 21, 2018 at 1:45 AM Christian Borntraeger
wrote:
>
>
>
> On 20.12.2018 18:23, Willem de Bruijn wrote:
> > On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel wrote:
> >>
> >> On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote:
>
On Mon, Jan 7, 2019 at 10:29 PM Deepa Dinamani wrote:
>
> The series introduces new socket timestamps that are
> y2038 safe.
>
> The time data types used for the existing socket timestamp
> options: SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING
> are not y2038 safe. The series introduces SO_TIM
On Thu, Jan 3, 2019 at 7:07 AM syzbot
wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of git://git.kern..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=12245d8f40
> kernel config:
On Thu, Jan 3, 2019 at 1:39 PM Willem de Bruijn
wrote:
>
> On Thu, Jan 3, 2019 at 7:07 AM syzbot
> wrote:
> >
> > Hello,
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of gi
On Thu, Jan 3, 2019 at 2:07 PM Stefano Brivio wrote:
>
> On Thu, 3 Jan 2019 12:01:29 -0800
> Eric Dumazet wrote:
>
> > On 01/03/2019 05:07 AM, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of
> > >
> > >
> > > > On Thu, Jan 3, 2019 at 10:54 PM Stefano Brivio
> > > > wrote:
> > > > >
> > > > > On Thu, 3 Jan 2019 15:15:06 -0600
> > > > > Willem de Bruijn wrote:
> > > > >
> > > > > &g
Mina Almasry wrote:
> Minor fix for virtio: code wanting to access the fields inside an skb
> frag should use the skb_frag_*() helpers, instead of accessing the
> fields directly. This allows for extensions where the underlying
> memory is not a page.
>
> Signed-off-by: Mina Almasry
>
> ---
>
>
Mina Almasry wrote:
> Use netmem_ref instead of page in skb_frag_t. Currently netmem_ref
> is always a struct page underneath, but the abstraction allows efforts
> to add support for skb frags not backed by pages.
>
> There is unfortunately 1 instance where the skb_frag_t is assumed to be
> a bio_
Yunjian Wang wrote:
> Now the zero-copy feature of AF_XDP socket is supported by some
> drivers, which can reduce CPU utilization on the xdp program.
> This patch set allows tun to support AF_XDP Rx zero-copy feature.
>
> This patch tries to address this by:
> - Use peek_len to consume a xsk->desc
Maciej Fijalkowski wrote:
> On Wed, Feb 28, 2024 at 07:05:56PM +0800, Yunjian Wang wrote:
> > This patch set allows TUN to support the AF_XDP Tx zero-copy feature,
> > which can significantly reduce CPU utilization for XDP programs.
>
> Why no Rx ZC support though? What will happen if I try rxdrop
Steffen Trumtrar wrote:
> This series tries to pick up the work on the virtio-net timestamping
> feature from Willem de Bruijn.
>
> Original series
> Message-Id: 20210208185558.995292-1-willemdebruijn.ker...@gmail.com
> Subject: [PATCH RFC v2 0/4] virtio-net: add
Jason Wang wrote:
> On Tue, Dec 19, 2023 at 12:36 AM Willem de Bruijn
> wrote:
> >
> > Steffen Trumtrar wrote:
> > > This series tries to pick up the work on the virtio-net timestamping
> > > feature from Willem de Bruijn.
> > >
> > > Origina
Sean Anderson wrote:
> Padding is not included in UDP and TCP checksums. Therefore, reduce the
> length of the checksummed data to include only the data in the IP
> payload. This fixes spurious reported checksum failures like
>
> rx: pkt: sport=33000 len=26 csum=0xc850 verify=0xf9fe
> pkt: bad csu
Sean Anderson wrote:
> On 9/6/24 22:05, Willem de Bruijn wrote:
> > Sean Anderson wrote:
> >> Padding is not included in UDP and TCP checksums. Therefore, reduce the
> >> length of the checksummed data to include only the data in the IP
> >> payload. This fixes
Eric Dumazet wrote:
> On Mon, Sep 9, 2024 at 5:02 PM Sean Anderson wrote:
> >
> > On 9/6/24 22:05, Willem de Bruijn wrote:
> > > Sean Anderson wrote:
> > >> Padding is not included in UDP and TCP checksums. Therefore, reduce the
> > >> length of
Jakub Kicinski wrote:
> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote:
> > > This seems to be a bug in the driver.
> > >
> > > A call to skb_put_padto(skb, ETH_ZLEN) should be added.
> >
> > In which case this test detecting it may be nic
Sean Anderson wrote:
> On 9/9/24 21:01, Willem de Bruijn wrote:
> > Jakub Kicinski wrote:
> >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote:
> >> > > This seems to be a bug in the driver.
> >> > >
> >> > > A call to sk
Sean Anderson wrote:
> On 9/10/24 13:42, Willem de Bruijn wrote:
> > Sean Anderson wrote:
> >> On 9/9/24 21:01, Willem de Bruijn wrote:
> >> > Jakub Kicinski wrote:
> >> >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote:
>
On Thu, Sep 12, 2024 at 2:31 AM Anders Roxell wrote:
>
> Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> Signed-off-by: Anders Roxell
This target is automatically built for targets that depend on it.
See the commit that introduced it, b86761ff6374.
+++ b/tools/testing/selftest
On Sun, Sep 15, 2024 at 8:45 AM Anders Roxell wrote:
>
> On Thu, 12 Sept 2024 at 17:23, Jakub Kicinski wrote:
> >
> > On Thu, 12 Sep 2024 08:31:18 +0200 Anders Roxell wrote:
> > > Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> > > Signed-off-by: Anders Roxell
> > > ---
> > > t
7;t affect result").
>>
>> Fixes: 9c7077622dd9 ("packet: make packet_snd fail on len smaller than l2
>> header")
>> Signed-off-by: Christoph Jaeger
>> ---
>
> Nice catch !
>
> Acked-by: Eric Dumazet
>
Indeed. I'm responsible for
On Thu, Mar 19, 2015 at 4:01 AM, Alexander Drozdov wrote:
> Introduce TP_STATUS_CSUM_VALID tp_status flag to tell the
> af_packet user that at least the transport header checksum
> has been already validated.
This changes the interface slightly. Processes should be treating
this previously unused
On Thu, Mar 19, 2015 at 2:08 PM, Alexander Drozdov wrote:
> On Thu, 19 Mar 2015 11:29:32 -0400, Willem de Bruijn
> wrote:
>>
>> On Thu, Mar 19, 2015 at 4:01 AM, Alexander Drozdov
>> wrote:
>>>
>>> Introduce TP_STATUS_CSUM_VALID tp_status flag to tel
On Fri, Mar 20, 2015 at 2:46 AM, Alexander Drozdov wrote:
>
> On 19.03.2015 21:50:03 +0300 Willem de Bruijn wrote:
>>
>> On Thu, Mar 19, 2015 at 2:08 PM, Alexander Drozdov
>> wrote:
>>>
>>> On Thu, 19 Mar 2015 11:29:32 -0400, Willem de Bruijn
>>&
>>> I think the bigger issues as you've pointed out are the cost of
>>> the additional spin lock and should the additional state be
>>> stored in-band (fewer cache lines) or out-of band (less risk of
>>> breaking due to unpredictable application behavior).
>>
>> We don't need the spinlock if cleari
On Tue, May 22, 2018 at 10:12 AM, Jon Rosen (jrosen) wrote:
> On Monday, May 21, 2018 2:17 PM, Jon Rosen (jrosen) wrote:
>> On Monday, May 21, 2018 1:07 PM, Willem de Bruijn
>> wrote:
>>> On Mon, May 21, 2018 at 8:57 AM, Jon Rosen (jrosen)
>>> wrote:
>
>
On Wed, May 23, 2018 at 7:54 AM, Jon Rosen (jrosen) wrote:
>> > For the ring, there is no requirement to allocate exactly the amount
>> > specified by the user request. Safer than relying on shared memory
>> > and simpler than the extra allocation in this patch would be to allocate
>> > extra shad
On Sun, May 20, 2018 at 7:13 PM, Willem de Bruijn
wrote:
> On Fri, May 18, 2018 at 2:59 PM, Willem de Bruijn
> wrote:
>> On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn
>> wrote:
>>> On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn
>>> wrote:
>>>
On Wed, May 23, 2018 at 11:29 AM, Jon Rosen (jrosen) wrote:
>
>
>> -Original Message-----
>> From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com]
>> Sent: Wednesday, May 23, 2018 9:37 AM
>> To: Jon Rosen (jrosen)
>> Cc: David S. Miller ;
On Wed, May 23, 2018 at 11:40 AM, Willem de Bruijn
wrote:
> On Sun, May 20, 2018 at 7:13 PM, Willem de Bruijn
> wrote:
>> On Fri, May 18, 2018 at 2:59 PM, Willem de Bruijn
>> wrote:
>>> On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn
>>> wrote:
>>>
On Tue, Apr 3, 2018 at 11:55 PM, Jon Rosen wrote:
> Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which
> casues the ring to get corrupted by allowing multiple kernel threads
> to claim ownership of the same ring entry, Mark the ring entry as
> already being used within the spin_lo
>> >One issue with the above proposed change to use TP_STATUS_IN_PROGRESS
>> >is that the documentation of the tp_status field is somewhat
>> >inconsistent. In some places it's described as TP_STATUS_KERNEL(0)
>> >meaning the entry is owned by the kernel and !TP_STATUS_KERNEL(0)
>>
On Tue, Feb 23, 2021 at 8:48 AM Balazs Nemeth wrote:
>
> On Mon, 2021-02-22 at 11:39 +0800, Jason Wang wrote:
> >
> > On 2021/2/19 10:55 下午, Willem de Bruijn wrote:
> > > On Fri, Feb 19, 2021 at 3:53 AM Jason Wang
> > > wrote:
> > > >
>
ncap L2 type and set the inner_protocol
> as ETH_P_TEB.
>
> Suggested-by: Willem de Bruijn
> Signed-off-by: huangxuesen
> Signed-off-by: chengzhiyong
> Signed-off-by: wangli
Thanks, this is exactly what I meant.
Acked-by: Willem de Bruijn
One small point regarding Signed-off-by
On Wed, Feb 17, 2021 at 1:12 PM Jason A. Donenfeld wrote:
>
> Hi Netdev & Willem,
>
> I've received a report of stack corruption -- via the stack protector
> check -- in icmp_send. I was sent a vmcore, and was able to extract
> the OOPS from there. However, I've been unable to produce the bug and
On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote:
>
> Hi Willem,
>
> On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn
> wrote:
> > A vmlinux image might help. I couldn't find one for this kernel.
>
> https://data.zx2c4.com/icmp_send-crash-e03b4a42-70
On Wed, Feb 17, 2021 at 6:18 PM Jason A. Donenfeld wrote:
>
> On 2/18/21, Willem de Bruijn wrote:
> > On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote:
> >>
> >> Hi Willem,
> >>
> >> On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn
&
On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote:
>
> For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
> set) based on the type in the virtio net hdr, but the skb could contain
> anything since it could come from packet_snd through a raw socket. If
> there is a mismatch
On Fri, Feb 19, 2021 at 3:53 AM Jason Wang wrote:
>
>
> On 2021/2/18 11:50 下午, Willem de Bruijn wrote:
> > On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote:
> >> For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
> >> set) based
esses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
(for netdrv)
Acked-by: Willem de Bruijn
On Fri, Jan 29, 2021 at 2:56 PM Sven Van Asbroeck wrote:
>
> From: Sven Van Asbroeck
>
> Multi-buffer packets enable us to use rx ring buffers smaller than
> the mtu. This will allow us to change the mtu on-the-fly, without
> having to stop the network interface in order to re-size the rx
> ring
On Fri, Jan 29, 2021 at 6:03 PM Sven Van Asbroeck wrote:
>
> Hoi Willem, thanks a lot for reviewing this patch, much appreciated !!
>
> On Fri, Jan 29, 2021 at 5:11 PM Willem de Bruijn
> wrote:
> >
> > > +static struct sk_buff *
> > > +lan743x_rx_trim_sk
On Sat, Jan 30, 2021 at 4:53 AM Hariprasad Kelam wrote:
>
> Hi Willem,
>
> > -Original Message-
> > From: Willem de Bruijn
> > Sent: Thursday, January 28, 2021 1:50 AM
> > To: Hariprasad Kelam
> > Cc: Network Development ; LKML > ker
On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote:
>
> The channel stop and suspend paths both call __gsi_channel_stop(),
> which quiesces channel activity, disables NAPI, and (on other than
> SDM845) stops the channel. Similarly, the start and resume paths
> share __gsi_channel_start(), which sta
On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote:
>
> On 1/30/21 9:25 AM, Willem de Bruijn wrote:
> > On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote:
> >>
> >> The channel stop and suspend paths both call __gsi_channel_stop(),
> >> which quiesces channel
On Sat, Jan 30, 2021 at 12:04 PM Geetha sowjanya wrote:
>
> The current admin function (AF) driver and the netdev driver supports
> OcteonTx2 silicon variants. The same OcteonTx2's Resource Virtualization Unit
> (RVU)
> is carried forward to the next-gen silicon ie OcteonTx3, with some changes
>
On Sun, Jan 31, 2021 at 8:11 AM Hariprasad Kelam wrote:
>
> This series of patches add support for forward error correction(fec) and
> physical link configuration. Patches 1&2 adds necessary mbox handlers for fec
> mode configuration request and to fetch stats. Patch 3 registers driver
> callbacks
On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote:
>
> On 1/31/21 8:52 AM, Willem de Bruijn wrote:
> > On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote:
> >>
> >> On 1/30/21 9:25 AM, Willem de Bruijn wrote:
> >>> On Fri, Jan 29, 2021 at 3:29 PM Alex El
On Mon, Feb 1, 2021 at 9:35 AM Alex Elder wrote:
>
> On 1/31/21 7:36 PM, Willem de Bruijn wrote:
> > On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote:
> >>
> >> On 1/31/21 8:52 AM, Willem de Bruijn wrote:
> >>> On Sat, Jan 30, 2021 at 11:29 PM Alex Elde
n separate
> steps (patches). Now both are moved around together in patch 5 and
> 6, which eliminates the need for the final (NAPI-only) patch.
>
> I won't repeat the patch summaries provided in v1:
> https://lore.kernel.org/netdev/20210129202019.2099259-1-el...@linaro.org/
>
>
ac header.
I would only not infer it based on some imprecise measure, such as
inner_maclen being 14. But add a new explicit flag
BPF_F_ADJ_ROOM_ENCAP_L2_ETH. Update inner protocol if the flag is
passed and inner_maclen >= ETH_HLEN. Fail the operation if the flag is
passed and inner_maclen is t
On Fri, Feb 26, 2021 at 3:15 PM Cong Wang wrote:
>
> On Thu, Feb 25, 2021 at 7:59 PM Xuesen Huang wrote:
> > v3:
> > - Fix the code format.
> >
> > v2:
> > Suggested-by: Willem de Bruijn
> > - Add a new flag to specify the type of the inne
> > > 2) The code quality of this driver is actually very low, and I also
> > > hope to improve it gradually. Actually this driver had been completely
> > > broken for many years and no one had noticed this until I fixed it in
> > > commit 8fdcabeac398 (drivers/net/wan/x25_asy: Fix to make it work)
On Thu, Jul 30, 2020 at 9:36 PM Xie He wrote:
>
> I'm really sorry to have re-sent the patch when the patch is still in
> review. I don't intend to be disrespectful to anyone. And I apologize
> for any disrespectfulness this might appear. Sorry.
>
> I'm also sorry for not having sent the patch wit
On Fri, Jul 31, 2020 at 4:41 PM Xie He wrote:
>
> Thank you for your thorough review comment!
>
> On Fri, Jul 31, 2020 at 7:13 AM Willem de Bruijn
> wrote:
> >
> > Thanks for fixing a kernel panic. The existing line was added recently
> > in commit 9dc829a135fb (
On Sat, Aug 1, 2020 at 8:46 AM Xie He wrote:
>
> On Fri, Jul 31, 2020 at 7:33 PM Willem de Bruijn
> wrote:
> >
> > I quickly scanned the main x.25 datapath code. Specifically
> > x25_establish_link, x25_terminate_link and x25_send_frame. These all
> > write thi
0x91/0x1f0
> [ 168.399289] ? irq_init_percpu_irqstack+0xc0/0x100
> [ 168.399291] __dev_queue_xmit+0x721/0x8e0
> [ 168.399295] ? packet_parse_headers.isra.0+0xd2/0x110
> [ 168.399297] dev_queue_xmit+0x10/0x20
> [ 168.399298] packet_sendmsg+0xbf0/0x19b0
> ..
>
>
On Wed, Aug 5, 2020 at 10:22 AM Colin Ian King wrote:
>
> On 05/08/2020 09:06, Willem de Bruijn wrote:
> > On Wed, Aug 5, 2020 at 2:54 AM Eric Dumazet wrote:
> >>
> >>
> >>
> >> On 8/4/20 5:30 AM, Colin King wrote:
> >>> From: Colin Ian
On Wed, Aug 5, 2020 at 10:57 AM Xie He wrote:
>
> On Tue, Aug 4, 2020 at 10:23 PM Martin Schiller wrote:
> >
> > > Adding skb_cow before these skb_push calls would indeed help
> > > preventing kernel panics, but that might not be the essential issue
> > > here, and it might also prevent us from d
168.399281] lapb_data_request+0x76/0xc0 [lapb]
> [ 168.399283] lapbeth_xmit+0x56/0x90 [lapbether]
> [ 168.399286] dev_hard_start_xmit+0x91/0x1f0
> [ 168.399289] ? irq_init_percpu_irqstack+0xc0/0x100
> [ 168.399291] __dev_queue_xmit+0x721/0x8e0
> [ 168.399295] ? packet_pars
On Thu, Aug 6, 2020 at 1:48 PM linmiaohe wrote:
>
> From: Miaohe Lin
>
> We could be trapped in deadloop when we try to copy userspace skb frags
> buffers to kernel with a cloned skb:
>
> [kbox] catch panic event, panic reason:kernel stack overflow
> [kbox] catch panic event, start logging.
> CPU
located.
>
> Cc: Willem de Bruijn
> Cc: Martin Schiller
> Signed-off-by: Xie He
> ---
> drivers/net/wan/lapbether.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
> index 1ea15f2123ed..cc297ea9c6
1 - 100 of 551 matches
Mail list logo