-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 40 +++-
1 file changed, 11 insertions(+), 29 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index b53ba9e..3256c51 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi
-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 269 -
1 file changed, 241 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 94a64ad..1d9
From: Paolo Bonzini
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 29 +
1 file changed, 29 insertions
From: Paolo Bonzini
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 17 +
1 file changed, 9 insertions(+), 8
io-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (1):
virtio-scsi: reset virtqueue affinity when doing cpu hotplug
drivers/scsi/virtio_scsi.c | 359 -
1 file changed, 290 insertions(+), 69 d
an we get your Acked-by?
Paolo Bonzini (3):
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (2):
virtio-scsi: redo allocation of target data
virtio-scsi: rese
y.
Cc: James Bottomley
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 71 --
1 file changed, 25 insertions(+), 46 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/driver
From: Paolo Bonzini
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 29 +
1 file changed, 29 insertions
-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 282 -
1 file changed, 254 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index dc2daec..13d
From: Paolo Bonzini
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 17 +
1 file changed, 9 insertions(+), 8
+ /* Does the affinity hint is set for virtqueues? */
> Could you rephrase that, please?
Thank you, fixed in V6, please review.
>
> Tested on qemu and w/ Google Compute Engine's virtio-scsi device.
Cool.
>
> Reviewed-and-tested-by: Venkatesh Srinivas
Do you mind revi
On 03/20/2013 03:24 PM, Asias He wrote:
> On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote:
>> Add hot cpu notifier to reset the request virtqueue affinity
>> when doing cpu hotplug.
>>
>> Cc: linux-s...@vger.kernel.org
>> Signed-off-by: Paolo Bonzi
On 03/20/2013 03:24 PM, Asias He wrote:
> On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote:
>> Add hot cpu notifier to reset the request virtqueue affinity
>> when doing cpu hotplug.
>>
>> Cc: linux-s...@vger.kernel.org
>> Signed-off-by: Paolo Bonzi
On 03/28/2013 10:22 AM, Wanlong Gao wrote:
> On 03/23/2013 07:28 PM, Wanlong Gao wrote:
>> This series implements virtio-scsi queue steering, which gives
>> performance improvements of up to 50% (measured both with QEMU and
>> tcm_vhost backends).
>>
>> This versi
aitqueue after the polling
> failure. Fix this by:
>
> - examing the POLLERR when setting backend and report erros to userspace
> - let tun always add to waitqueue in .poll() after the queue is created even
> if
> it was detached.
Fixed my kernel oops here, thank you.
Tested-
On 01/25/2013 11:28 AM, Jason Wang wrote:
> On 01/21/2013 07:25 PM, Wanlong Gao wrote:
>> Split out the clean affinity function to virtnet_clean_affinity().
>>
>> Cc: Rusty Russell
>> Cc: "Michael S. Tsirkin"
>> Cc: Jason Wang
>> Cc
On 01/25/2013 01:13 PM, Jason Wang wrote:
> On 01/25/2013 12:20 PM, Wanlong Gao wrote:
>> On 01/25/2013 11:28 AM, Jason Wang wrote:
>>> On 01/21/2013 07:25 PM, Wanlong Gao wrote:
>>>> Split out the clean affinity function to virtnet_clean_affinity().
>>>>
On 01/25/2013 09:04 AM, K. Y. Srinivasan wrote:
> Properly initialize scatterlist before using it.
>
> Signed-off-by: K. Y. Srinivasan
> Cc: Stable
Reviewed-by: Wanlong Gao
> ---
> drivers/scsi/storvsc_drv.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions
On 01/25/2013 02:12 PM, Jason Wang wrote:
> On 01/25/2013 01:40 PM, Wanlong Gao wrote:
>> On 01/25/2013 01:13 PM, Jason Wang wrote:
>>> On 01/25/2013 12:20 PM, Wanlong Gao wrote:
>>>> On 01/25/2013 11:28 AM, Jason Wang wrote:
>>>>> On 01/21/2013 07:2
On 01/25/2013 03:04 PM, Jason Wang wrote:
> On 01/25/2013 02:42 PM, Wanlong Gao wrote:
>> On 01/25/2013 02:12 PM, Jason Wang wrote:
>>> On 01/25/2013 01:40 PM, Wanlong Gao wrote:
>>>> On 01/25/2013 01:13 PM, Jason Wang wrote:
>>>>> On 01/25/2013 12:20 P
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Eric Dumazet
Cc: "David S. Miller"
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
Acked-by: Michael S. Tsirkin
---
V6->V7:
serialize virtnet_set_queues to avoid
umazet
Cc: "David S. Miller"
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
Acked-by: Michael S. Tsirkin
---
V6->V7: no change
V5->V6:
deal with CPU_DOWN_PREPARE separately by just cleaning affinity
V4->V5:
Ne
Split out the clean affinity function to virtnet_clean_affinity().
Cc: Rusty Russell
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Eric Dumazet
Cc: "David S. Miller"
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
On 01/25/2013 05:00 PM, Jason Wang wrote:
> On 01/25/2013 04:36 PM, Wanlong Gao wrote:
>> As Michael mentioned, set affinity and select queue will not work very
>> well when CPU IDs are not consecutive, this can happen with hot unplug.
>> Fix this bug by traversal the online C
t_set = false;
>>>> + }
>>>> }
>>> Sorry, looks like the issue of v6 still exists, we need set per-cpu
>>> index unconditionally here (and also in 2/3), the cpus != queues check
>>> may bypass this setting.
>> This fixed in 2/3, when cpus !=
Split out the clean affinity function to virtnet_clean_affinity().
Cc: Rusty Russell
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Eric Dumazet
Cc: "David S. Miller"
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Eric Dumazet
Cc: "David S. Miller"
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
Acked-by: Michael S. Tsirkin
---
V7->V8:
set vq index uncondition
umazet
Cc: "David S. Miller"
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
Acked-by: Michael S. Tsirkin
---
V5->V6:
deal with CPU_DOWN_PREPARE separately by just cleaning affinity
V4->V5:
New method to deal wi
On 02/19/2013 03:56 PM, Rusty Russell wrote:
> virtio_scsi can really use this, to avoid the current hack of copying
> the whole sg array. Some other things get slightly neater, too.
>
> Signed-off-by: Rusty Russell
I like this simple implementation.
Reviewed-by:
Using the new virtqueue_add_sgs function lets us simplify the queueing
path. In particular, all data protected by the tgt_lock is just gone
(multiqueue will find a new use for the lock).
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 93
On 02/20/2013 05:38 PM, Asias He wrote:
> On 02/20/2013 04:37 PM, Wanlong Gao wrote:
>> Using the new virtqueue_add_sgs function lets us simplify the queueing
>> path. In particular, all data protected by the tgt_lock is just gone
>> (multiqueue will find a new use for the lo
Using the new virtqueue_add_sgs function lets us simplify the queueing
path. In particular, all data protected by the tgt_lock is just gone
(multiqueue will find a new use for the lock).
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
V1->V2:
add the lost comments (As
On 02/19/2013 03:56 PM, Rusty Russell wrote:
> Extract the post-counting code into virtqueue_add(), make both callers
> use it.
>
> Signed-off-by: Rusty Russell
Reviewed-by: Wanlong Gao
> ---
> drivers/virtio/virtio_ring.c | 147
> +++
> FIXME: I'm not sure about the unclean sglist bit. I had a more
> ambitious one which conditionally ignored end markers in the iterator,
> but it was ugly and I suspect this is just as fast. Maybe we should
> just fix all the drivers?
>
> Signed-off-by: Rusty Russell
On 02/19/2013 03:56 PM, Rusty Russell wrote:
> We never add buffers with input and output parts, so use the new accessors.
>
> Signed-off-by: Rusty Russell
Reviewed-by: Wanlong Gao
> ---
> drivers/net/virtio_net.c | 11 +--
> 1 file changed, 5 insertio
On 02/19/2013 03:56 PM, Rusty Russell wrote:
> We never add buffers with input and output parts, so use the new accessors.
>
> Signed-off-by: Rusty Russell
Reviewed-by: Wanlong Gao
> ---
> drivers/char/hw_random/virtio-rng.c |2 +-
> 1 file changed, 1 insert
On 02/19/2013 03:56 PM, Rusty Russell wrote:
> We never add buffers with input and output parts, so use the new accessors.
>
> Signed-off-by: Rusty Russell
Reviewed-by: Wanlong Gao
> ---
> drivers/rpmsg/virtio_rpmsg_bus.c |8
> 1 file changed, 4 insertio
On 02/19/2013 03:56 PM, Rusty Russell wrote:
> We never add buffers with input and output parts, so use the new accessors.
>
> Signed-off-by: Rusty Russell
Reviewed-by: Wanlong Gao
> ---
> drivers/virtio/virtio_balloon.c |6 +++---
> 1 file changed, 3 insertio
On 02/19/2013 03:56 PM, Rusty Russell wrote:
> We never add buffers with input and output parts, so use the new accessors.
>
> Signed-off-by: Rusty Russell
Reviewed-by: Wanlong Gao
> ---
> drivers/net/caif/caif_virtio.c |3 +--
> 1 file changed, 1 insertion(+), 2 dele
On 02/19/2013 03:56 PM, Rusty Russell wrote:
> We never add buffers with input and output parts, so use the new accessors.
>
> Signed-off-by: Rusty Russell
Reviewed-by: Wanlong Gao
> ---
> drivers/char/virtio_console.c |6 +++---
> 1 file changed, 3 insertio
return status */
> + BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ));
>
> - ctrl.class = class;
> - ctrl.cmd = cmd;
The class and cmd assignment of ctrl header is forgotten?
Thanks,
Wanlong Gao
> + /* Add header */
> + sg_init_one(&
net eth0: Failed to disable allmulti mode.
[7.549744] net eth0: Failed to set MAC fitler table.
[7.550705] net eth0: Failed to disable promisc mode.
[7.551603] net eth0: Failed to disable allmulti mode.
[7.552504] net eth0: Failed to set MAC fitler table.
[7.553423] net eth0: Fa
On 02/21/2013 05:41 PM, Jason Wang wrote:
> On 02/21/2013 04:30 PM, Wanlong Gao wrote:
>> On 02/19/2013 03:56 PM, Rusty Russell wrote:
>>> It's a bit cleaner to hand multiple sgs, rather than one big one.
>>>
>>> Signed-off-by: Rusty Russell
>
ot;);
close(fd);
munmap(pa, len);
return 1;
Cc: Andrew Morton
Cc: KOSAKI Motohiro
Cc: linux...@kvack.org (open list:MEMORY MANAGEMENT)
Signed-off-by: Wanlong Gao
---
mm/mmap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/mmap.c b/mm/mma
On 09/13/2012 12:03 PM, Laurent Pinchart wrote:
> Hi Wanlong,
>
> Thanks for the patch.
>
> On Monday 27 August 2012 15:23:15 Wanlong Gao wrote:
>> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
>> translated as ENOTTY to user mode.
>>
>
loc/Kconfig
> create mode 100644 lib/zsmalloc/Makefile
> create mode 100644 lib/zsmalloc/zsmalloc.c
Since there's just one file here, why not just move to lib flatly without
creating a new directory?
Thanks,
Wanlong Gao
--
To unsubscribe from this list: send the line "unsubscribe
t;
>>> Please don't think do_mmap_pgoff() is for mmap(2) specific and read a
>>> past thread before resend
>>> a patch.
>>
>> So, what's your opinion about this bug? How to fix it in your mind?
>
> Fix glibc instead of kernel.
>
OK,
i2c_client *client)
Ditto.
> +{
> + int icnt;
> + struct lp8755_chip *pchip = i2c_get_clientdata(client);
> +
> + for (icnt = 0; icnt < mphase_buck[pchip->mphase].nreg; icnt++)
<..>
> +static struct i2c_driver lp8755_i2c_driver = {
> + .driver = {
>
Tidy up the goto label in init(), and remove the useless
NULL pointer assignment.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 28
Create a separate work queue for virtio-scsi to improve the performance.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 15 ++-
1 file changed, 14
Use pr_err() instead of printk() for code cleanups.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
Reassign err is not needed, just a cleanup.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi
Just use the macro instead of define a variable.
Cc: James E.J. Bottomley
Cc: Paolo Bonzini
Cc: Rusty Russell
Cc: linux-s...@vger.kernel.org
Cc: k...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
=4820/3169, in_queue=7991, util=90.62%
sdb: ios=6364/5358, merge=39/53, ticks=3810/2816, in_queue=6615, util=84.63%
sdc: ios=6458/5352, merge=74/47, ticks=4425/3048, in_queue=7459, util=88.41%
Wanlong Gao (5):
virtio-scsi: remove the useless assignment
virtio-scsi: remove the needless
On 11/07/2012 08:23 PM, Asias He wrote:
> On Wed, Nov 7, 2012 at 6:18 PM, Wanlong Gao wrote:
>> patch 1-3,5 are some cleanups.
>> patch 4: create a separate work queue for virtio-scsi
>> to improve the performance, I tested with tmpfs backed
>> disk, the config fil
d the improvement, because the code you
> touched (complete_event) shouldn't ever run during a normal benchmark.
> It's only used for hotplug/hot-unplug.
>
> Nevertheless, I'll queue the cleanup patches. Thanks for those.
Oops, got it, I will investigate more. Thank you
2 +0200
>
> [SCSI] virtio-scsi: split scatterlist per target
>
> Go ahead and make sure that vq->vq_lock is relinquished w/ spin_unlock
> first, then release tgt->tgt_lock w/ spin_unlock_irqrestore.
Did you hit any error? I don't think this order is wrong.
Thanks,
Wanlong
irtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/net/virtio_net.c | 39 ++-
1 file changed, 38 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index a6fcf15..9710
On 12/26/2012 06:06 PM, Jason Wang wrote:
> On 12/26/2012 03:06 PM, Wanlong Gao wrote:
>> Add a cpu notifier to virtio-net, so that we can reset the
>> virtqueue affinity if the cpu hotplug happens. It improve
>> the performance through enabling or disabling the virtqueue
&g
On 12/27/2012 11:28 AM, Jason Wang wrote:
> On 12/26/2012 06:19 PM, Wanlong Gao wrote:
>> On 12/26/2012 06:06 PM, Jason Wang wrote:
>>> On 12/26/2012 03:06 PM, Wanlong Gao wrote:
>>>> Add a cpu notifier to virtio-net, so that we can reset the
>>>> virtque
On 12/27/2012 02:39 PM, Jason Wang wrote:
> Currently, polling error were ignored in vhost. This may lead some issues (e.g
> kenrel crash when passing a tap fd to vhost before calling TUNSETIFF). Fix
> this
> by:
Can this kernel crash be reproduced by hand?
Thanks,
Wanlong Gao
&
io=34625MB, aggrb=247902KB/s, minb=247902KB/s, maxb=247902KB/s,
mint=143025msec, maxt=143025msec
Chained:
Run status group 0 (all jobs):
READ: io=34863MB, aggrb=242320KB/s, minb=242320KB/s, maxb=242320KB/s,
mint=147325msec, maxt=147325msec
WRITE: io=34437MB, aggrb=
n here.
> Without this data it is possible that your host
> is undersubscribed and you are drinking up more host CPU.
>
> Another thing to note is that ATM you might need to
> test with idle=poll on host otherwise we have strange interaction
> with power management where reducing
if (err)
>>>>>> return err;
>>>>>>
>>>>>> -virtscsi_init_vq(&vscsi->ctrl_vq, vqs[0]);
>>>>>> -virtscsi_init_vq(&vscsi->event_vq, vqs[1]);
>>>>>>
On 04/18/2013 09:35 PM, Jens Axboe wrote:
> On Thu, Apr 18 2013, Wanlong Gao wrote:
>>> A bio is always fully initialized, regardless of which internal
>>> allocator it came from. If people are doing private kmallocs, then they
>>> better be using bio_init() as well
On 04/18/2013 10:30 PM, Jens Axboe wrote:
> On Thu, Apr 18 2013, Wanlong Gao wrote:
>> On 04/18/2013 09:35 PM, Jens Axboe wrote:
>>> On Thu, Apr 18 2013, Wanlong Gao wrote:
>>>>> A bio is always fully initialized, regardless of which internal
>>>>
On 04/18/2013 10:30 PM, Jens Axboe wrote:
> On Thu, Apr 18 2013, Wanlong Gao wrote:
>> On 04/18/2013 09:35 PM, Jens Axboe wrote:
>>> On Thu, Apr 18 2013, Wanlong Gao wrote:
>>>>> A bio is always fully initialized, regardless of which internal
>>>>
ay without the new TP.
Thank you for investigating this. And sorry for my incompleted panic picture
before that let you detour. :-(
Regards,
Wanlong Gao
>
> Thanks.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
ecause of the prerequisites. James, can we get your Acked-by?
Paolo Bonzini (3):
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (2):
virtio-scsi: redo all
From: Paolo Bonzini
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff
From: Paolo Bonzini
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 17 +
1 file changed, 9 insertions(+), 8
-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
Tested-by: Venkatesh Srinivas
---
drivers/scsi/virtio_scsi.c | 282 -
1 file changed, 254 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio
y.
Cc: James Bottomley
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 71 --
1 file changed, 25 insertions(+), 46 deletions(-)
diff --git a/driver
On 03/23/2013 02:36 PM, Paolo Bonzini wrote:
> Il 20/03/2013 08:56, Wanlong Gao ha scritto:
>>> This one does not apply on top of virtio-next + patch 1-4 in this series.
>>
>> I'm very sorry.
>>
>> This fault is because I modified the 4/5 from
>>
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
Reviewed-by: Asias He
---
drivers/scsi/virtio_scsi.c | 29 +
1 file changed, 29 insertions
On 04/06/2013 04:40 PM, James Bottomley wrote:
> On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote:
>> On 03/28/2013 10:22 AM, Wanlong Gao wrote:
>>> On 03/23/2013 07:28 PM, Wanlong Gao wrote:
>>>> This series implements virtio-scsi queue steering, which gives
&g
On 03/23/2013 07:28 PM, Wanlong Gao wrote:
> This series implements virtio-scsi queue steering, which gives
> performance improvements of up to 50% (measured both with QEMU and
> tcm_vhost backends).
>
> This version rebased on Rusty's virtio ring rework patches, which
>
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers
From: Paolo Bonzini
Avoid duplicated code in all of the callers.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi
-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 269 -
1 file changed, 241 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 3573704..7a54293 100644
--- a/drivers/sc
structs in the
flexible array member at the end of struct virtio_scsi, because
we will place the virtqueues there in the next patches.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 45
From: Paolo Bonzini
This will be needed soon in order to retrieve the per-target
struct.
Cc: linux-s...@vger.kernel.org
Signed-off-by: Paolo Bonzini
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a
d-by?
Paolo Bonzini (4):
virtio-scsi: redo allocation of target data
virtio-scsi: pass struct virtio_scsi to virtqueue completion function
virtio-scsi: push vq lock/unlock into virtscsi_vq_done
virtio-scsi: introduce multiqueue support
Wanlong Gao (1):
virtio-scsi: reset virtqueue affinity
nus Torvalds
Linus pointed out that ENOIOCTLCMD should be translated as ENOTTY to user
mode, and we should fix up the broken drivers then.
Wanlong Gao (5):
drivers:tty:fix up ENOIOCTLCMD error handling
net:atm:fix up ENOIOCTLCMD error handling
media:dvb:fix up ENOIOCTLCMD error handling
v
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: "David S. Miller"
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
net/atm/resources.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/atm/resourc
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Martin Schwidefsky
Cc: Heiko Carstens
Cc: linux...@de.ibm.com
Cc: linux-s...@vger.kernel.org (open list:S390)
Signed-off-by: Wanlong Gao
---
drivers/s390/block/dasd_ioctl.c | 2 +-
1 file
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Laurent Pinchart
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/media/video/omap3isp/ispvideo.c | 10 +-
1 file changed, 5
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/media/dvb/dvb-core/dvbdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
For example:
fd = open("/dev/tty", O_RDWR);
ioctl(fd, -1, &argp);
then the errno should be ENOTTY but not EINVAL.
Cc: Greg Kroah-Hartman
Signed-off-by: Wanlong Gao
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Eric Dumazet
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
V5->V6:
remove {get|put}_online_cpus from virtnet_del_vqs (Jason)
V4->V5:
Add get/put_online_cpus to
Split out the clean affinity function to virtnet_clean_affinity().
Cc: Rusty Russell
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Eric Dumazet
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
V5->V6: NEW
drivers/net/virt
umazet
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
V5->V6:
deal with CPU_DOWN_PREPARE separately by just cleaning affinity
V4->V5:
New method to deal with the cpu hotplug actions (Rusty)
drivers/net/v
On 01/22/2013 09:12 AM, Rusty Russell wrote:
> Wanlong Gao writes:
>
>> As Michael mentioned, set affinity and select queue will not work very
>> well when CPU IDs are not consecutive, this can happen with hot unplug.
>> Fix this bug by traversal the online CPUs, and c
ur Acked-by?
I can't apply this series on top of Rusty's virtio-next, I missed something
or needed rebase them ?
Thanks,
Wanlong Gao
>
> Paolo
>
> Paolo Bonzini (4):
> virtio-scsi: redo allocation of target data
> virtio-scsi: pass struct virtio_scsi to
umazet
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/net/virtio_net.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index ca17a58..e0b1f25 10
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
Cc: Eric Dumazet
Cc: virtualizat...@lists.linux-foundation.org
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
V3->V4:
move vq_index into virtnet_info (Jason)
change the mapping value when not setting af
These two patches are based on the multi-queue virtio-scsi patch set.
We set cpu affinity when the num_queues equals to the number
of VCPUs. Split out the set affinity function, this also
fix the bug when CPU IDs are not consecutive.
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c
Add hot cpu notifier to reset the request virtqueue affinity
when doing cpu hotplug.
Signed-off-by: Wanlong Gao
---
drivers/scsi/virtio_scsi.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index
1 - 100 of 136 matches
Mail list logo
