struct cifs_writedata is declared twice.
One is declared at 209th line.
And struct cifs_writedata is defined blew.
The declaration hear is not needed. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
fs/cifs/cifsglob.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/cifs/cifsglob.h
There is a return above the break.
The break here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing
---
arch/arm/mach-s3c/mach-rx1950.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-s3c/mach-rx1950.c b/arch/arm/mach-s3c/mach-rx1950.c
index 6e19add158a9..9da94686001a
There is a return above the break.
The break here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing
---
arch/sh/boards/mach-landisk/gio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sh/boards/mach-landisk/gio.c
b/arch/sh/boards/mach-landisk/gio.c
index ff2200fec29a
struct iov_iter has been declared at 66th line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/linux/fs.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index ec8f3ddf4a6a..7f3cbd47670a 100644
--- a/include/linux/fs.h
+++ b/include
struct host1x is declared at 20th line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/linux/host1x.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/host1x.h b/include/linux/host1x.h
index ce59a6a6a008..462f0bc7a703 100644
--- a/include/linux/host1x.h
+++ b
struct task_struct is declared at 9th line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/linux/debug_locks.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
index 2915f56ad421..0b3187a5290d 100644
--- a/include/linux
struct evlist has been declared at 10th line.
struct comm has been declared at 15th line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
tools/perf/util/metricgroup.h | 1 -
tools/perf/util/thread-stack.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/tools/perf/util/metricgroup.h
struct dss_device has been declared at 51st line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index a40abeafd2e9
struct drm_i915_private, struct intel_crtc_state and
struct intel_crtc have been declared before.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/i915/display/intel_crt.h | 1 -
drivers/gpu/drm/i915/display/intel_display.h | 1 -
drivers/gpu/drm/i915/display
struct xen_drm_front_drm_info has been declared.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/xen/xen_drm_front_conn.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.h
b/drivers/gpu/drm/xen/xen_drm_front_conn.h
index
struct _adapter has been declared at 23rd line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/staging/rtl8712/drv_types.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging/rtl8712/drv_types.h
index 0c4325073c63
struct sk_buff has been declared. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/net/ethernet/netronome/nfp/nfp_app.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_app.h
b/drivers/net/ethernet/netronome/nfp/nfp_app.h
index 76d13af46a7a
struct lbs_private has been declared at 22nd line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/net/wireless/marvell/libertas/decl.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/libertas/decl.h
b/drivers/net/wireless/marvell/libertas/decl.h
struct scsi_host_cmd_pool has been declared. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/scsi/scsi_host.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index e30fd963b97d..5fa8f6a78d05 100644
--- a/include/scsi
struct device has been declared at 133rd line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/linux/libnvdimm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h
index 01f251b6e36c..89b69e645ac7 100644
--- a/include/linux
struct path has been declared at 85th line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/linux/mount.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/mount.h b/include/linux/mount.h
index 5d92a7e1a742..30272f961af7 100644
--- a/include/linux/mount.h
+++ b
struct sock has been declared. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/net/bpf_sk_storage.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/bpf_sk_storage.h b/include/net/bpf_sk_storage.h
index 0e85713f56df..2926f1f00d65 100644
--- a/include/net
struct _adapter has been declared at 23rd line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/staging/rtl8712/drv_types.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging/rtl8712/drv_types.h
index 0c4325073c63
struct _adapter has been declared at 23rd line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
Changelog:
v3:
- Delete trailing whitespace.
v2:
- Delete the blank line.
---
drivers/staging/rtl8712/drv_types.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8712
struct dss_device has been declared. Remove the duplicate.
And sort these forward declarations alphabetically.
Signed-off-by: Wan Jiabing
---
Changelog:
v2:
- Sort forward declarations alphabetically.
---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 -
1 file changed, 4 insertions(+), 5
linux/kernel.h has been included. Remove the duplicate.
Reorder include files to be in alphabetic order.
Signed-off-by: Wan Jiabing
---
Changelog:
v3:
- Reorder include files to be in alphabetic order.
v2:
- Remove the duplicate which won't make worse.
---
drivers/watchdog/dw_wdt.
struct task_struct has been declared.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
Changelog:
v2:
- Remove another duplicate declaration for being closer
to its user.
---
include/linux/debug_locks.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/debug_locks.h b
struct task_struct is declared twice.
Remove the duplicate.
Reviewed-by: Andy Shevchenko
Signed-off-by: Wan Jiabing
---
Changelog:
v3:
- Add reviewer info and modify subject line
v2:
- Remove another duplicate declaration for being closer
to its user.
---
include/linux/debug_locks.h | 2
dce110/dce110_resource.h has been included at line 58, so remove
the duplicate include at line 64.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
b
../hw_ddc.h, ../hw_gpio.h and ../hw_hpd.h have been included
at line 32, so remove them.
Signed-off-by: Wan Jiabing
---
.../gpu/drm/amd/display/dc/gpio/dce110/hw_factory_dce110.c| 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/gpio/dce110
linux/errno.h has been included at line 11, so remove the
duplicate include at line 16.
Signed-off-by: Wan Jiabing
---
drivers/soc/litex/litex_soc_ctrl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soc/litex/litex_soc_ctrl.c
b/drivers/soc/litex/litex_soc_ctrl.c
index
linux/io.h has been included at line 6, so remove the
duplicate include at line 18.
Signed-off-by: Wan Jiabing
---
drivers/pinctrl/pinctrl-k210.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
index 8a733cf77ba0..f831526d06ff
linux/kernel.h has been included at line 17, so remove the
duplicate one at line 22.
Signed-off-by: Wan Jiabing
---
drivers/watchdog/dw_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index 32d0e1781e63..b1642e2d9175 100644
--- a
linux/string.h has been included at line 21, so remove the
duplicate one at line 22.
Signed-off-by: Wan Jiabing
---
drivers/media/test-drivers/vidtv/vidtv_psi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/test-drivers/vidtv/vidtv_psi.c
b/drivers/media/test-drivers/vidtv
indir_table.h has been included at line 41, so remove
the duplicate one at line 43.
Signed-off-by: Wan Jiabing
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
b/drivers
vhca_event.h has been included at line 4, so remove the
duplicate one at line 8.
Signed-off-by: Wan Jiabing
---
drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c
b/drivers/net/ethernet
linux/regmap.h has been included at line 13, so remove the
duplicate one at line 14.
Signed-off-by: Wan Jiabing
---
drivers/net/can/m_can/tcan4x5x.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/can/m_can/tcan4x5x.h b/drivers/net/can/m_can/tcan4x5x.h
index c66da829b795
linux/of_device.h has been included at line 25, so remove
the duplicate one at line 35.
Signed-off-by: Wan Jiabing
---
drivers/thermal/ti-soc-thermal/ti-bandgap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
b/drivers/thermal/ti-soc-thermal/ti
asm/bug.h has been included at line 12, so remove
the duplicate one at line 21.
Signed-off-by: Wan Jiabing
---
arch/powerpc/include/asm/book3s/64/mmu-hash.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h
b/arch/powerpc/include/asm/book3s/64
asm/interrupt.h has been included at line 12. According to
alphabetic order,we remove the duplicate one at line 10.
Signed-off-by: Wan Jiabing
---
arch/powerpc/kernel/interrupt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel
linux/kernel.h has been included at line 22. According to
alphabetic order, we remove the duplicate one at line 17.
Signed-off-by: Wan Jiabing
---
drivers/watchdog/dw_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index
linux/sched/clock.h has been included at line 33.
So we remove the duplicate one at line 56. For better
understanding, we also move sched/cputime.h under the
sched including segment.
Signed-off-by: Wan Jiabing
---
arch/powerpc/kernel/time.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
linux/pgtable.h has been included at line 11 with annotation.
So we remove the duplicate one at line 8.
Signed-off-by: Wan Jiabing
---
include/linux/crash_dump.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index a5192b718dbe
linux/mtd/nand.h has been included at line 17.
So we remove the duplicate one at line 21.
Signed-off-by: Wan Jiabing
---
include/linux/mtd/rawnand.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index 6b3240e44310..93e8f72beba6
linux/compat.h has been included at line 8.So we remove
the duplicate one at line 12.
Signed-off-by: Wan Jiabing
---
mm/process_vm_access.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
index f5fee9cf90f8..4bcc11958089 100644
--- a/mm
string.h has been included at line 15.So we remove the
duplicate one at line 17.
Signed-off-by: Wan Jiabing
---
tools/testing/selftests/mincore/mincore_selftest.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/mincore/mincore_selftest.c
b/tools/testing/selftests
sched.h has been included at line 33.
So we remove the duplicate one at line 36.
Signed-off-by: Wan Jiabing
---
tools/testing/selftests/powerpc/mm/tlbie_test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/mm/tlbie_test.c
b/tools/testing/selftests/powerpc
pthread.h has been included at line 17.
So we remove the duplicate one at line 20.
Signed-off-by: Wan Jiabing
---
tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c
b/tools/testing/selftests
inttypes.h has been included at line 19.
So we remove the duplicate one at line 23.
Signed-off-by: Wan Jiabing
---
tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/tm/tm-poison.c
b/tools/testing/selftests/powerpc
sys/stat.h has been included at line 23, so remove the
duplicate one at line 27.
linux/string.h has been included at line 7, so remove the
duplicate one at line 9.
time.h has been included at line 14, so remove the
duplicate one at line 28.
Signed-off-by: Wan Jiabing
---
tools/perf/builtin
sched.h has been included at line 33, so remove the
duplicate one at line 36.
inttypes.h has been included at line 19, so remove the
duplicate one at line 23.
pthread.h has been included at line 17,so remove the
duplicate one at line 20.
Signed-off-by: Wan Jiabing
---
tools/testing/selftests
move sched/cputime.h
under sched including segament.
Signed-off-by: Wan Jiabing
---
arch/powerpc/include/asm/book3s/64/mmu-hash.h | 1 -
arch/powerpc/kernel/interrupt.c | 1 -
arch/powerpc/kernel/time.c| 3 +--
3 files changed, 1 insertion(+), 4 deletions(-)
diff
linux/tty.h has been included at line 13, so
remove the duplicate one at line 21.
Signed-off-by: Wan Jiabing
---
arch/arm/mach-sa1100/hackkit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c
index 3085f1c2e586..3fe34ee7c0ab
ifdef CONFIG_NVM, linux/blkdev.h and uapi/linux/lightnvm.h
would be included twice. So remove them.
By the way, I find that struct nvm_rq is declared twice.
If removing the duplicated declaration really makes sense, it would
be much clean up work to do in inlude/linux.
Signed-off-by: Wan
struct device is declared twice.So remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/linux/pm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/pm.h b/include/linux/pm.h
index 482313a8ccfc..c9657408fee1 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
struct ccw1 is declared twice. One has been declared
at 21st line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
arch/s390/include/asm/ccwdev.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/s390/include/asm/ccwdev.h b/arch/s390/include/asm/ccwdev.h
index 778247bb1d61
struct task_struct is declared twice. One has been declared
at 154th line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
arch/parisc/include/asm/processor.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/parisc/include/asm/processor.h
b/arch/parisc/include/asm/processor.h
index
This patch series tried to remove duplicate struct declaration.
Wan Jiabing (4):
net: wireless: broadcom: Remove duplicate struct declaration
net: wireless: microchip: Remove duplicate struct declaration
net: wireless: marvell: Remove duplicate struct declaration
net: ethernet: stmicro
struct brcmf_bus is declared twice. One has been declared
at 37th line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h
b
struct wilc is declared twice. One has been declared
at 352nd line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/net/wireless/microchip/wilc1000/wlan.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.h
b/drivers/net/wireless
struct stmmac_safety_stats is declared twice. One has been
declared at 29th line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/net/ethernet/stmicro/stmmac/hwif.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h
b/drivers/net/ethernet
struct lbtf_private is declared twice. One has been declared
at 157th line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/net/wireless/marvell/libertas_tf/libertas_tf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/libertas_tf/libertas_tf.h
b
struct dc_state is declared twice. One has been
declared at 273rd line. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/amd/display/dc/dc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index
In f29b5f3e6fc0a, the script is update to support python3.
Fix the python interpreter update to python3.
Fixes: f29b5f3e6fc0a ("show_delta: Update script to support python3")
Signed-off-by: Wan Jiabing
---
scripts/show_delta | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
linux/clk.h is included more than once.
Signed-off-by: Wan Jiabing
---
drivers/bus/bt1-apb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
index b25ff941e7c7..74b1b712ef3a 100644
--- a/drivers/bus/bt1-apb.c
+++ b/drivers/bus/bt1-apb.c
@@ -22,7
amdgpu_hdp.h has been included at line 91, so remove
the duplicate include.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 49267eb64302
linux/blkdev.h has been included at line 18, so remove
the duplicate include at line 27.
Signed-off-by: Wan Jiabing
---
drivers/scsi/ufs/ufshcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c86760788c72..e8aa7de17d0a 100644
nvif/if000c.h has been included at line 33, so remove
the duplicate include at line 36.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/nouveau/nouveau_dmem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c
b/drivers/gpu/drm/nouveau/nouveau_dmem.c
index
priv.h has been included at line 22, so remove
the duplicate include at line 24.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
b/drivers/gpu/drm/nouveau/nvkm
struct trace_array is declared twice. One has been declared
at forward struct declaration. Remove the duplicate.
And sort these forward declarations alphabetically.
Signed-off-by: Wan Jiabing
---
include/linux/trace_events.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff
struct mem_cgroup is declared twice. One has been declared
at forward struct declaration. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/linux/memcontrol.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index
struct trace_array is declared twice. One has been declared
at forward declaration. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
Changelog:
v2:
- Undo sorting forward declarations alphabetically.
---
include/linux/trace_events.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include
struct dwc2_hsotg is declared twice. One has been declared
at forward declaration. Remove the duplicate one.
Signed-off-by: Wan Jiabing
---
drivers/usb/dwc2/core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index 7161344c6522
struct rapl_package is declared twice. One has been declared
at 80th line.
By reviewing the code, it should declare struct rapl_domain
rather than rapl_package. Modify it.
Signed-off-by: Wan Jiabing
---
include/linux/intel_rapl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
struct drm_i915_private, struct intel_crtc_state and
struct intel_crtc is declared twice.
Remove the duplicate.
Reviewed-by: José Roberto de Souza
Signed-off-by: Wan Jiabing
---
Changelog:
v2:
- Modify subject line.
- Delete trailing whitespace in commit log.
---
drivers/gpu/drm/i915/display
struct nd_region has been declared at 118th line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/nvdimm/nd-core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvdimm/nd-core.h b/drivers/nvdimm/nd-core.h
index 564faa36a3ca..e54551caf335 100644
--- a/drivers/nvdimm/nd
struct iscsi_iser_task has been declared at 201st line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/infiniband/ulp/iser/iscsi_iser.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h
b/drivers/infiniband/ulp/iser/iscsi_iser.h
index
Declaring struct pt_regs is unnecessary.
On the one hand, there is no function using it;
on the other hand, struct pt_regs has been declared
in linux/kernel.h. Remove them.
Reorder the forward declaration to be in alphabetic order.
Signed-off-by: Wan Jiabing
---
include/linux/profile.h | 5
struct ip_set is declared twice. One is declared at 79th line,
so remove the duplicate.
Signed-off-by: Wan Jiabing
---
include/linux/netfilter/ipset/ip_set.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/netfilter/ipset/ip_set.h
b/include/linux/netfilter/ipset/ip_set.h
struct request and struct request_queue have been
declared at forward struct declaration.
Remove the duplicate and reorder the forward declaration
to be in alphabetic order.
Signed-off-by: Wan Jiabing
---
drivers/scsi/scsi_priv.h | 8 +++-
1 file changed, 3 insertions(+), 5 deletions
could also just review the results.
Signed-off-by: Wan Jiabing
---
scripts/checkdeclares.pl | 55
1 file changed, 55 insertions(+)
create mode 100755 scripts/checkdeclares.pl
diff --git a/scripts/checkdeclares.pl b/scripts/checkdeclares.pl
new file mode 1
struct dc_state has been declared at 273rd line.
Remove the duplicate.
Delete duplicate blank lines.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/amd/display/dc/dc.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd
struct tegra_dc has been declared at 13rd line.
Remove the duplicate.
Move struct tegra_plane declaration forward.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/tegra/hub.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tegra/hub.h b/drivers/gpu/drm
struct cx231xx has been declared at 146th line.
struct em28xx has been declared at 219th line.
Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/media/usb/cx231xx/cx231xx.h | 2 --
drivers/media/usb/em28xx/em28xx.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/media
could also just review the results.
Signed-off-by: Wan Jiabing
---
Changelog:
v2:
- Delete unused variable @file_lines.
---
scripts/checkdeclares.pl | 53
1 file changed, 53 insertions(+)
create mode 100755 scripts/checkdeclares.pl
diff --git a/sc
struct ipoib_cm_tx is defined at 245th line.
And the definition is independent on the MACRO.
The declaration here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing
---
drivers/infiniband/ulp/ipoib/ipoib.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/ulp/ipoib
Fix coccicheck warning:
tools/perf/bench/find-bit-bench.c:123:5-8:
Unneeded variable: "err". Return "0" on line 134
Signed-off-by: Wan Jiabing
---
tools/perf/bench/find-bit-bench.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/bench
Fix coccicheck warning:
tools/thermal/tmon/pid.c:57:5-8:
Unneeded variable: ret. Return 0 on line 68
Signed-off-by: Wan Jiabing
---
tools/thermal/tmon/pid.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/thermal/tmon/pid.c b/tools/thermal/tmon/pid.c
index
t/alignment_handler.c:331:5-7:
Unneeded variable: "rc". Return "0" on line 344
./tools/testing/selftests/powerpc/alignment/alignment_handler.c:349:5-7:
Unneeded variable: "rc". Return "0" on line 360
./tools/testing/selftests/powerpc/alignment/alignment_handler
t/alignment_handler.c:331:5-7:
Unneeded variable: "rc". Return "0" on line 344
./tools/testing/selftests/powerpc/alignment/alignment_handler.c:349:5-7:
Unneeded variable: "rc". Return "0" on line 360
./tools/testing/selftests/powerpc/alignment/alignment_handler
Fix coccicheck warning:
./tools/perf/util/evlist.c:1316:5-8: Unneeded variable: "err". Return "-
ENOMEM" on line 1341
Signed-off-by: Wan Jiabing
---
tools/perf/util/evlist.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/evlist
Fix the following coccicheck warning:
./drivers/scsi/megaraid/megaraid_sas_base.c:8644:30-32:
WARNING !A || A && B is equivalent to !A || B
Signed-off-by: Wan Jiabing
---
drivers/scsi/megaraid/megaraid_sas_base.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a
Fix the following coccicheck warning:
./drivers/net/ethernet/sfc/enum.h:80:7-28: duplicated argument to |
Signed-off-by: Wan Jiabing
---
drivers/net/ethernet/sfc/enum.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/enum.h b/drivers/net/ethernet/sfc/enum.h
index
Fix the following coccicheck warning:
./drivers/net/ethernet/cavium/liquidio/cn66xx_regs.h:413:6-28:
duplicated argument to & or |
The CN6XXX_INTR_M1UPB0_ERR here is duplicate.
Here should be CN6XXX_INTR_M1UNB0_ERR.
Signed-off-by: Wan Jiabing
---
drivers/net/ethernet/cavium/liqu
Fix the following coccicheck warning:
./drivers/crypto/ux500/cryp/cryp_p.h:84:6-27:duplicated argument to |
Signed-off-by: Wan Jiabing
---
drivers/crypto/ux500/cryp/cryp_p.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/ux500/cryp/cryp_p.h
b/drivers/crypto/ux500/cryp
Fix the following coccicheck warning:
./drivers/scsi/qla4xxx/ql4_83xx.c:475:23-25: WARNING !A || A && B is
equivalent to !A || B
Signed-off-by: Wan Jiabing
---
drivers/scsi/qla4xxx/ql4_83xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql
Fix the following coccicheck warning:
./arch/m68k/include/asm/sun3xflop.h:109:2-3: Unneeded semicolon
Signed-off-by: Wan Jiabing
---
arch/m68k/include/asm/sun3xflop.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/include/asm/sun3xflop.h
b/arch/m68k/include/asm
Fix the following coccicheck warning:
./drivers/power/reset/vexpress-poweroff.c:136:2-3: Unneeded semicolon
Signed-off-by: Wan Jiabing
---
drivers/power/reset/vexpress-poweroff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/vexpress-poweroff.c
b
struct ubi_wl_entry is defined at 178th line.
The declaration here is unnecessary. Remove it.
Reviewed-by: Tudor Ambarus
Signed-off-by: Wan Jiabing
---
Changelog:
v2:
- Add reviewer info and modify the subject line.
---
drivers/mtd/ubi/ubi.h | 2 --
1 file changed, 2 deletions(-)
diff --git a
struct cx231xx is declared at 146th line.
The declaration here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing
---
drivers/media/usb/cx231xx/cx231xx.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx.h
b/drivers/media/usb/cx231xx/cx231xx.h
index
struct em28xx is declared at 219th line.
The declaration here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing
---
drivers/media/usb/em28xx/em28xx.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx.h
b/drivers/media/usb/em28xx/em28xx.h
index
struct hfs_btree is defined at 73rd line.
The declaration here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing
---
fs/hfsplus/hfsplus_fs.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
index 12b20479ed2b..4da395c25f4a 100644
--- a/fs
struct mem_info is defined at 22nd line.
The declaration here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing
---
tools/perf/util/mem-events.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
index 755cef7e0625..5ddbeaa057b0
struct sci_phy_proto is defined at 142nd line.
The declaration here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing
---
drivers/scsi/isci/phy.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/isci/phy.h b/drivers/scsi/isci/phy.h
index 45fecfa36a98..5aaf95b14b2e 100644
Clean up trailing whitespace.
Signed-off-by: Wan Jiabing
---
fs/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 216f16e74351..6c6cb46c0667 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -52,8 +52,8 @@
* The new code replaces the old
1 - 100 of 126 matches
Mail list logo