Re: [PATCH] async_tx: use memchr_inv

2012-10-28 Thread Vinod Koul
On Sun, 2012-10-28 at 00:49 +0900, Akinobu Mita wrote: > Use memchr_inv() to check the specified page is filled with zero. > > Signed-off-by: Akinobu Mita > Cc: Vinod Koul > Cc: Dan Williams > --- Looks fine to me, need Dan;s ack before applying > crypto/async_tx/asyn

Re: [PATCH] ioat: Fix DMA memory sync direction correct flag

2012-10-28 Thread Vinod Koul
. Applied, thanks -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] dmaengine: use for_each_set_bit

2012-10-28 Thread Vinod Koul
On Fri, 2012-10-26 at 23:35 +0900, Akinobu Mita wrote: > Use for_each_set_bit() to implement for_each_dma_cap_mask() and > remove unused first_dma_cap() and next_dma_cap(). Applied thanks -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] dma: amba-pl08x: use vchan_dma_desc_free_list

2012-10-28 Thread Vinod Koul
desc in the list_head. Because vchan->desc_free callback is > set > as pl08x_desc_free() for amba-pl08x driver. Applied thanks -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

Re: [PATCH] dmatest: adjust invalid module parameters for number of source buffers

2012-10-28 Thread Vinod Koul
not adjusted and the unsupported number of source buffers are passed to the > device. But most drivers don't check it, so unexpected results will happen. > > This makes an appropriate adjustment for these module parameters before use. Applied thanks -- Vinod Koul Intel Corp. -

Re: [PATCH 06/16] dma: Convert dev_printk(KERN_ to dev_(

2012-10-28 Thread Vinod Koul
On Sun, 2012-10-28 at 01:05 -0700, Joe Perches wrote: > dev_ calls take less code than dev_printk(KERN_ > and reducing object size is good. > Coalesce formats for easier grep. Applied thanks -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] async_tx: use memchr_inv

2012-10-29 Thread Vinod Koul
On Sun, 2012-10-28 at 00:49 +0900, Akinobu Mita wrote: > Use memchr_inv() to check the specified page is filled with zero. > Applied Thanks -- Vinod Koul Intel Corp. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

Re: [PATCH] DMA: shdma: fix CHCLR register address calculation

2013-08-25 Thread Vinod Koul
On Tue, Jul 02, 2013 at 05:37:58PM +0200, Guennadi Liakhovetski wrote: > struct sh_dmae_device::chan_reg is a pointer to u32, therefore when adding > offsets to it care should be taken to add offsets in sizeof(u32) units, not > in bytes. This patch corrects such a bug. While at it we also remove th

Re: [PATCH 0/3] DMA: shdma: several stylistic improvements and support for new SoCs

2013-08-25 Thread Vinod Koul
On Tue, Jul 02, 2013 at 05:45:49PM +0200, Guennadi Liakhovetski wrote: > Hi > > The first two patches in this small series improve driver internals a bit > by using preferred APIs, the 3rd patch adds support for new DMAC versions, > present on AG5, APE6, H2. Applied, thanks Although the patch 1

Re: [PATCH v2] DMA: shdma: make a pointer const

2013-08-25 Thread Vinod Koul
On Fri, Aug 02, 2013 at 04:18:09PM +0200, Guennadi Liakhovetski wrote: > Platform data shouldn't be changed at run-time, so, pointers to it should > be const. Applied, thanks ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vge

Re: [PATCH v5 0/7] DMA: shdma: switch DT to use OF device ID tables

2013-08-25 Thread Vinod Koul
On Fri, Aug 02, 2013 at 04:50:35PM +0200, Guennadi Liakhovetski wrote: > In this version of shdma Device Tree support I preserved the DT > configuration approach via OF device ID tables from v4, but now it is only > used for the DT-mode, the C-version is left untouched. In this series I > only i

Re: [PATCH] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-25 Thread Vinod Koul
On Wed, Aug 21, 2013 at 06:51:56PM +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. Can you pls rebase this as resend. I have applied bunch of sh-dma patch

Re: [PATCH] dma: ipu: remove unnecessary platform_set_drvdata()

2013-08-25 Thread Vinod Koul
On Wed, Aug 21, 2013 at 06:52:54PM +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. Applied, thanks ~Vinod -- To unsubscribe from this list: send the line

Re: [PATCH] dma/Kconfig: TI_EDMA needs to be boolean

2013-08-25 Thread Vinod Koul
On Thu, Aug 22, 2013 at 02:03:24PM -0700, Guenter Roeck wrote: > Fix: > > arch/arm/common/built-in.o: undefined reference to `edma_filter_fn' > > seen with "make ARCH=arm allmodconfig" > > Commit 6cba4355 (ARM: edma: Add DT and runtime PM support to the private EDMA > API) adds a dependency on e

Re: [PATCH] dma: ste_dma: Fix warning when CONFIG_ARM_LPAE=y

2013-08-25 Thread Vinod Koul
On Wed, Aug 21, 2013 at 09:34:02PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > When CONFIG_ARM_LPAE=y the following build warning are generated: > > drivers/dma/ste_dma40.c:3228:2: warning: format '%x' expects argument of type > 'unsigned int', but argument 4 has type 'resource_size_t

Re: [PATCH 1/2] acpi-dma, doc: append managed function to the list

2013-08-25 Thread Vinod Koul
On Wed, Aug 21, 2013 at 02:27:05PM +0300, Andy Shevchenko wrote: > ACPI DMA provides managed function to register the slave DMA controller in the > internal container. This patch anounces that function in the corresponding > documentation file. Applied, thanks ~Vinod -- To unsubscribe from this li

Re: [PATCH v5 0/7] DMA: shdma: switch DT to use OF device ID tables

2013-08-26 Thread Vinod Koul
On Mon, Aug 26, 2013 at 04:17:25PM +0900, Simon Horman wrote: > On Sun, Aug 25, 2013 at 01:06:57PM +0530, Vinod Koul wrote: > > On Fri, Aug 02, 2013 at 04:50:35PM +0200, Guennadi Liakhovetski wrote: > > > In this version of shdma Device Tree support I preserved the DT > >

Re: [PATCH RESEND] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-26 Thread Vinod Koul
On Mon, Aug 26, 2013 at 09:32:05AM +0900, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manually clear the > device driver data to NULL. Applied, thanks ~Vinod -- To unsubscribe from this list: send the line

Re: [PATCH -next] dma: cppi41: fix error return code in cppi41_dma_probe()

2013-08-26 Thread Vinod Koul
On Fri, Aug 23, 2013 at 10:59:15AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return -EINVAL in the irq parse and map error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun This need to go thru USB tree A

Re: [PATCH] dma: sh: remove unnecessary platform_set_drvdata()

2013-08-26 Thread Vinod Koul
On Mon, Aug 26, 2013 at 02:38:17PM +0200, Guennadi Liakhovetski wrote: > On Wed, 21 Aug 2013, Jingoo Han wrote: > > > The driver core clears the driver data to NULL after device_release > > or on probe failure. Thus, it is not needed to manually clear the > > device driver data to NULL. > > > > S

Re: [PATCH] DMA: shdma: fix a bad merge - remove free_irq()

2013-08-26 Thread Vinod Koul
On Mon, Aug 26, 2013 at 02:27:51PM +0200, Guennadi Liakhovetski wrote: > A bad merge resulted in a left-over free_irq() call. This patch removes it. Applied, thanks Can you also test this branch and see if anything is remaining And can you take care then ARM patches in last serries are merged thi

Re: [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node

2013-08-26 Thread Vinod Koul
On Mon, Aug 26, 2013 at 03:18:00PM +0200, Laurent Pinchart wrote: > Hi Richard, > > (Dropping Dan Williams from the CC list as his e-mail address doesn't seem to > be valid anymore) > > > > > >> Hmm. Looking at the patch, I'm not sure it's right. > > > > >> > > > > >> This patch simply passes a

Re: [PATCH] DMA: shdma: fix a bad merge - remove free_irq()

2013-08-27 Thread Vinod Koul
On Tue, Aug 27, 2013 at 11:21:00AM +0200, Guennadi Liakhovetski wrote: > Hi Vinod, > > On Mon, 26 Aug 2013, Vinod Koul wrote: > > > On Mon, Aug 26, 2013 at 02:27:51PM +0200, Guennadi Liakhovetski wrote: > > > A bad merge resulted in a left-over free_irq() call. T

Re: [PATCH] DMA: let filter functions of of_dma_simple_xlate possible check of_node

2013-08-27 Thread Vinod Koul
On Mon, Aug 26, 2013 at 08:15:17PM +0200, Arnd Bergmann wrote: > On Monday 26 August 2013 19:40:57 Vinod Koul wrote: > > And the selection should be done for the cases where you dont have > > programmable > > mux in dmac. For programmable ones passing slave_id in dma_sla

Re: [PATCH] DMA: shdma: fix a bad merge - remove free_irq()

2013-08-27 Thread Vinod Koul
On Tue, Aug 27, 2013 at 04:46:51PM +0200, Guennadi Liakhovetski wrote: > Ok, to me it looks like you did fix some patches in the topic/sh branch, > but: > > patch "DMA: shdma: move two macros to a header" is missing > patch "dma: use dev_get_platdata()" is missing (but ok, it's common for > driv

Re: [PATCH resend] dma: pl330: Fix handling of TERMINATE_ALL while processing completed descriptors

2013-08-27 Thread Vinod Koul
On Tue, Aug 27, 2013 at 08:34:05PM +0200, Lars-Peter Clausen wrote: > The pl330 DMA driver is broken in regard to handling a terminate all request > while it is processing the list of completed descriptors. This is most visible > when calling dmaengine_terminate_all() from within the descriptors ca

Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support

2013-08-28 Thread Vinod Koul
On Fri, Aug 16, 2013 at 02:07:54PM +0800, Jingchang Lu wrote: > Add Freescale enhanced direct memory(eDMA) controller support. > The eDMA controller deploys DMAMUXs routing DMA request sources(slot) > to eDMA channels. > This module can be found on Vybrid and LS-1 SoCs. > + devicet...@vger.kernel.

Re: [[PATCH] 0/3] imx-dma: fixes

2013-10-03 Thread Vinod Koul
On Sun, Sep 29, 2013 at 01:56:03AM +0200, Michael Grzeschik wrote: > Hi Christoph, > > On Tue, Sep 24, 2013 at 08:35:03AM +0200, Christoph Fritz wrote: > > On Mon, 2013-09-23 at 09:49 +0530, Vinod Koul wrote: > > > On Tue, Sep 17, 2013 at 03:56:05PM +0200, Michael Grzesc

Re: [[PATCH] 0/3] imx-dma: fixes

2013-10-03 Thread Vinod Koul
On Tue, Sep 17, 2013 at 03:56:05PM +0200, Michael Grzeschik wrote: > Hello, > > this series is solving some lockdep issues in the imx-dma code. > There are some list_head and deadlock issues in the code, > that is running the implementation into unsafe situations. Thanks a bunch for doing this. I

[GIT PULL] slave-dmaengine fixes

2013-10-05 Thread Vinod Koul
Hey Linus, Here is the slave dmanegine fixes. We have the fix for deadlock issue on imx-dma by Michael and Josh's edma config fix along with author change The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f: Linus Torvalds (1): Linux 3.12-rc1 are available in th

[RFC] dmaengine: add dma_slave_get_caps api

2013-07-08 Thread Vinod Koul
https://patchwork.kernel.org/patch/2094891/ Signed-off-by: Vinod Koul --- include/linux/dmaengine.h | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 96d3e4a..f259f27

Re: [RFC] dmaengine: add dma_slave_get_caps api

2013-07-08 Thread Vinod Koul
On Mon, Jul 08, 2013 at 02:01:35PM +0200, Lars-Peter Clausen wrote: > On 07/08/2013 10:54 AM, Vinod Koul wrote: > > +/* struct dma_slave_caps - expose capabilities of a slave channel only > > + * > > + * @src_addr_widths: bit mask of src addr widths the channel supports >

Re: [RFC] dmaengine: add dma_slave_get_caps api

2013-07-08 Thread Vinod Koul
On Mon, Jul 08, 2013 at 04:28:29PM +0200, Lars-Peter Clausen wrote: > On 07/08/2013 03:40 PM, Vinod Koul wrote: > > On Mon, Jul 08, 2013 at 02:01:35PM +0200, Lars-Peter Clausen wrote: > >> On 07/08/2013 10:54 AM, Vinod Koul wrote: > >>> +/* struct dma_slave_caps -

Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

2013-09-16 Thread Vinod Koul
On Thu, Sep 05, 2013 at 05:53:19PM +0800, Jingchang Lu wrote: > Add Freescale enhanced direct memory(eDMA) controller support. > The eDMA controller deploys DMAMUXs routing DMA request sources(slot) > to eDMA channels. > This module can be found on Vybrid and LS-1 SoCs. > > Signed-off-by: Alison W

Re: [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA

2013-09-16 Thread Vinod Koul
On Wed, Sep 04, 2013 at 12:10:45PM -0400, Josh Boyer wrote: > On Wed, Sep 04, 2013 at 09:32:03AM -0400, Josh Boyer wrote: > > The TI_EDMA driver unconditionally calls functions provided by the > > TI_PRIV_EDMA code, but it doesn't force that to be built-in. If that isn't > > otherwise enabled some

Re: [PATCH 1/1] dma: tegra20-apb-dma: Staticize tegra_dma_prep_dma_cyclic

2013-09-16 Thread Vinod Koul
On Fri, Sep 06, 2013 at 05:16:22PM +0530, Sachin Kamat wrote: > tegra_dma_prep_dma_cyclic is referenced only in this file. > Make it static. Applied, thanks ~Vinod > > Signed-off-by: Sachin Kamat > Cc: Laxman Dewangan > --- > drivers/dma/tegra20-apb-dma.c |2 +- > 1 file changed, 1 inserti

Re: [PATCH v4 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-09-17 Thread Vinod Koul
On Thu, Sep 05, 2013 at 12:35:23AM +0200, Heiko Stübner wrote: > This adds a new driver to support the s3c24xx dma using the dmaengine > and makes the old one in mach-s3c24xx obsolete in the long run. > > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > with numerous virtu

Re: [PATCH] dma: pl330: Simplify irq allocation

2013-09-17 Thread Vinod Koul
On Fri, Sep 13, 2013 at 11:33:33AM +0200, Michal Simek wrote: > On 09/12/2013 03:42 PM, Vinod Koul wrote: > > On Wed, Sep 04, 2013 at 04:40:17PM +0200, Michal Simek wrote: > >> Use devm_request_irq function. > > > > Applied, thanks > > Thanks. I have one cha

[GIT PULL] slave-dmaengine update for 3.12

2013-09-09 Thread Vinod Koul
of CONFIG register dmaengine: PL08x: Rework LLI handling to be less fragile dmaengine: PL08x: Move LLI dumping code into separate function dmaengine: PL08x: Add support for PL080S variant dmaengine: PL08x: Add support for different maximum transfer size Vinod Koul (9):

Re: [PATCH] dma: pl330: Simplify irq allocation

2013-09-12 Thread Vinod Koul
On Wed, Sep 04, 2013 at 04:40:17PM +0200, Michal Simek wrote: > Use devm_request_irq function. Applied, thanks ~Vinod signature.asc Description: Digital signature

Re: [PATCH v2] edma: Update author email address

2013-09-12 Thread Vinod Koul
On Wed, Sep 04, 2013 at 10:32:50AM -0400, Josh Boyer wrote: > Matt's @ti.com address bounces. Update the MODULE_AUTHOR information in > edma.c to his Linaro address. Applied, thanks ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH v5 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-10-07 Thread Vinod Koul
a s3c2416-based board, memcpy using the dmatest module and > slave_sg partially using the spi-s3c64xx driver. > > Signed-off-by: Heiko Stuebner > Acked-by: Linus Walleij Acked-by: Vinod Koul -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v6 3/3] dma: Add Freescale eDMA engine driver support

2013-10-10 Thread Vinod Koul
On Thu, Oct 10, 2013 at 09:39:04AM +, Lu Jingchang-B35083 wrote: > Hi, Vinod, > > Could you please help review this patch? Could it be merged into your next > tree? > Thanks! Where is the patch 1 & 2 of the series, I dont sem to find it. Also I need ACK from one of the DT maintainers on t

Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls

2013-10-10 Thread Vinod Koul
On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote: > Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed > resource allocation) got rid of shdma_free_irq() but unfortunately got merged > later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add d

Re: [PATCH] dma: edma.c: remove edma_desc leakage

2013-10-10 Thread Vinod Koul
On Mon, Oct 07, 2013 at 07:19:58PM -0300, Geyslan G. Bem wrote: > Free memory allocated to edma_desc when failing to allocate slot. > > Signed-off-by: Geyslan G. Bem Applied thanks ~Vinod > --- > drivers/dma/edma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/edma.c b/d

[GIT PULL] slave-dmaengine fixes

2013-08-31 Thread Vinod Koul
Hey Linus, Please consider the pull request for 3.11 to recive a fix for the resolving TI_EDMA driver's build error in allmodconfig to have filter function built in. The following changes since commit c095ba7224d8edc71dcef0d655911399a8bd4a3f: Linus Torvalds (1): Linux 3.11-rc4 are avai

Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support

2013-09-01 Thread Vinod Koul
On Thu, Aug 29, 2013 at 03:32:04AM +, Lu Jingchang-B35083 wrote: Please use a right MUA and wrap your lines at 80chars... > > > > > > + return -EINVAL; > > > + } > > > + return 0; > > > + > > > + default: > > > + return -ENXIO; > > > + } > > > +} > >

Re: [PATCH 00/18] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-09-02 Thread Vinod Koul
On Sun, Aug 11, 2013 at 07:59:12PM +0200, Tomasz Figa wrote: > This is first non-RFC version of my patches extending support of > amba-pl08x DMA engine driver to PL080S DMA engine (PL080 modified by > Samsung) found in Samsung S3C64xx SoCs. > > Due to changes scattered across different areas of ke

Re: [PATCH] dma: imx-sdma: Staticize sdma_driver_data structures

2013-09-02 Thread Vinod Koul
On Sun, Sep 01, 2013 at 09:57:12PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Sparse report the following warnings: > > drivers/dma/imx-sdma.c:330:25: warning: symbol 'sdma_imx31' was not declared. > Should it be static? > drivers/dma/imx-sdma.c:351:25: warning: symbol 'sdma_imx25' w

Re: [PATCH] pch_dma: Add MODULE_DEVICE_TABLE

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 12:02:06AM +0100, Ben Hutchings wrote: > pch_dma currently isn't auto-loaded if built as a module. Applied, thanks ~Vinod signature.asc Description: Digital signature

Re: [PATCH 1/2] dma: sh: use devm_ioremap_resource() instead of devm_request_and_ioremap()

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 10:23:15AM +0900, Jingoo Han wrote: > Use devm_ioremap_resource() because devm_request_and_ioremap() is > obsoleted by devm_ioremap_resource(). Applied both, Thanks ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 07:10:53AM +, Lu Jingchang-B35083 wrote: > > -Original Message- > > From: Vinod Koul [mailto:vinod.k...@intel.com] > > Sent: Monday, September 02, 2013 12:51 PM > > To: Lu Jingchang-B35083 > > Cc: shawn@linaro.org; linux-ker

Re: [PATCH v3] dma: add driver for R-Car HPB-DMAC

2013-09-02 Thread Vinod Koul
On Sun, Aug 25, 2013 at 12:33:24AM +0400, Sergei Shtylyov wrote: > From: Max Filippov > > Add support for HPB-DMAC found in Renesas R-Car SoCs, using 'shdma-base' DMA > driver framework. > > Based on the original patch by Phil Edworthy . > > Signed-off-by: Max Filippov > [Sergei: removed usel

Re: [PATCH 1/1] dma: imx-dma: Remove redundant NULL check

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 01:21:18PM +0530, Sachin Kamat wrote: > kfree on a NULL pointer is a no-op. Null pointer check is > not necessary. Applied, thanks ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH 1/2] dma: ste_dma40: Remove duplicate const

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 01:44:58PM +0530, Sachin Kamat wrote: > 'const' was added twice. > Applied, both thanks ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 07:32:53AM +, Lu Jingchang-B35083 wrote: > > > > > > > + chan->private = fn_param; > > > > > > why do you need to use chan->private? > > > > > [Lu Jingchang] > > > > > The private used here is to store the slot_id information, which > > must > > > > be used > > > > > by

Re: [PATCH v3 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-09-02 Thread Vinod Koul
On Wed, Aug 28, 2013 at 12:13:51AM +0200, Heiko Stübner wrote: > This adds a new driver to support the s3c24xx dma using the dmaengine > and makes the old one in mach-s3c24xx obsolete in the long run. > > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > with numerous virtu

Re: [PATCH v4 0/6] dma: edma: Support scatter-lists of any length

2013-09-02 Thread Vinod Koul
re will not be any noticeable > performance improvement. But above experiment just shows as proof of concept > that even using 1 slot is managed by just DMA'ing 1 SG entry at a time. much better series, thanks I think i am okay with this, if anyone has objections pls speak up. Also I

Re: [PATCH 4/7] dma: replace devm_request_and_ioremap by devm_ioremap_resource

2013-09-02 Thread Vinod Koul
On Mon, Aug 19, 2013 at 01:20:38PM +0200, Julia Lawall wrote: > From: Julia Lawall > > Use devm_ioremap_resource instead of devm_request_and_ioremap. > > This was done using the semantic patch > scripts/coccinelle/api/devm_ioremap_resource.cocci > > The relevant call to platform_get_resource wa

Re: [PATCH 1/2] dma: sh: use devm_ioremap_resource() instead of devm_request_and_ioremap()

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 12:04:29PM +0530, Vinod Koul wrote: > On Mon, Sep 02, 2013 at 10:23:15AM +0900, Jingoo Han wrote: > > Use devm_ioremap_resource() because devm_request_and_ioremap() is > > obsoleted by devm_ioremap_resource(). > Applied both, Thanks I have removed this

[PATCH] dmaengine: dma_slave_caps: remove sg entries

2013-09-02 Thread Vinod Koul
As pointed by Russell in [1], the sg properties are already availble in struct device, so no need to duplicate here. [1]: http://marc.info/?l=linux-omap&m=137416733628831 Signed-off-by: Vinod Koul --- include/linux/dmaengine.h |8 1 files changed, 0 insertions(+), 8 delet

Re: [PATCH] dmaengine: dma_slave_caps: remove sg entries

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 04:52:06PM +0200, Lars-Peter Clausen wrote: > On 09/02/2013 02:21 PM, Vinod Koul wrote: > > As pointed by Russell in [1], the sg properties are already availble in > > struct device, > > so no need to duplicate here. > > > > [1]:

Re: [PATCH] dmaengine: dma_slave_caps: remove sg entries

2013-09-02 Thread Vinod Koul
On Mon, Sep 02, 2013 at 07:10:52PM +0200, Lars-Peter Clausen wrote: > On 09/02/2013 06:12 PM, Vinod Koul wrote: > > On Mon, Sep 02, 2013 at 04:52:06PM +0200, Lars-Peter Clausen wrote: > >> On 09/02/2013 02:21 PM, Vinod Koul wrote: > >>> As pointed by Russell in [1],

Re: [PATCH v4 2/6] dma: edma: Write out and handle MAX_NR_SG at a given time

2013-09-02 Thread Vinod Koul
On Thu, Aug 29, 2013 at 06:05:41PM -0500, Joel Fernandes wrote: > Process SG-elements in batches of MAX_NR_SG if they are greater > than MAX_NR_SG. Due to this, at any given time only those many > slots will be used in the given channel no matter how long the > scatter list is. We keep track of how

Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support

2013-09-03 Thread Vinod Koul
On Tue, Sep 03, 2013 at 05:43:21AM +, Lu Jingchang-B35083 wrote: > Do you mean the DMA_SLAVE_CONFIG device_control? Yeah, the slave driver > could pass > the slave_id. But the DMA_SLAVE_CONFIG may be called more than once, and the > eDMA > driver just needs to set the slave id once for any

Re: [[PATCH] 0/3] imx-dma: fixes

2013-09-22 Thread Vinod Koul
On Tue, Sep 17, 2013 at 03:56:05PM +0200, Michael Grzeschik wrote: > Hello, > > this series is solving some lockdep issues in the imx-dma code. > There are some list_head and deadlock issues in the code, > that is running the implementation into unsafe situations. Thanks for this, I have trying to

Re: [PATCH] DMA: ste_dma40: use a power of 2 check

2013-09-22 Thread Vinod Koul
On Wed, Sep 18, 2013 at 09:33:08AM +0200, Guennadi Liakhovetski wrote: > dst_addr_width and src_addr_width should be a power of 2. Currently the > driver checks, that they both lie between 1 and 8 and that they are eqal typo ^ >

Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support

2013-09-22 Thread Vinod Koul
On Tue, Sep 17, 2013 at 08:08:46AM +, Lu Jingchang-B35083 wrote: > > > + case DMA_PAUSE: > > > + if (fsl_chan->edesc) > > > + fsl_edma_disable_request(fsl_chan); > > racy here too... > It only set the channel HW register, no list is handled, > is lock needed here? Thank

Re: [PATCH -next] dma: mmp_pdma: use list_move instead of list_del/list_add

2013-09-23 Thread Vinod Koul
On Mon, Sep 23, 2013 at 02:07:20PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Using list_move() instead of list_del() + list_add(). > > Signed-off-by: Wei Yongjun Applied, thanks ~Vinod > --- > drivers/dma/mmp_pdma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff -

Re: [PATCH 30/51] DMA-API: dma: dw_dmac.c: convert to use dma_coerce_mask_and_coherent()

2013-09-23 Thread Vinod Koul
On Fri, Sep 20, 2013 at 06:26:16PM +0300, Andy Shevchenko wrote: > On Fri, Sep 20, 2013 at 5:40 PM, Russell King - ARM Linux > wrote: > > On Fri, Sep 20, 2013 at 05:26:46PM +0300, Andy Shevchenko wrote: > >> On Thu, 2013-09-19 at 22:55 +0100, Russell King wrote: > >> > This code sequence: > >> >

[GIT PULL] slave-dmaengine updates for 3.7

2012-10-08 Thread Vinod Koul
m1 as DMA_PRIVATE DMA: PL330: Set the capability of pdm0 and pdm1 as DMA_PRIVATE Ulf Hansson (1): dma/ste_dma40: Fixup clock usage during probe Vinod Koul (3): Merge branch 'for-3.7' into next Merge branch 'fixes_for-3.6' into next spi: davici - make

Re: [GIT PULL] MMC updates for 3.7-rc1

2012-10-08 Thread Vinod Koul
On Mon, 2012-10-08 at 23:36 -0400, Chris Ball wrote: > Hi Linus, > > On Mon, Oct 08 2012, Chris Ball wrote: > > Please pull from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git > > tags/mmc-merge-for-3.7-rc1 > > > > to receive the MMC merge for 3.7. There are currently two c

Re: [PATCH 1/4] DMA: PL330: fix locking in pl330_free_chan_resources()

2012-11-30 Thread Vinod Koul
On Fri, 2012-11-30 at 11:59 +0100, Bartlomiej Zolnierkiewicz wrote: > > Acked-by: Jassi Brar > > Vinod/Dan could you please pick this patch for 3.8? Thanks! I will check and queue it up today -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH 1/1] DMA: PL330: Use devm_* functions

2012-12-03 Thread Vinod Koul
On Mon, 2012-12-03 at 16:50 +0530, Sachin Kamat wrote: > On 15 November 2012 11:57, Sachin Kamat wrote: > > devm_* functions are device managed and make the code and error > > handling a bit simpler. > > > > Cc: Jassi Brar > > Signed-off-by: Sachin Kamat Appli

Re: [PATCH] dma: add new DMA control commands

2012-10-17 Thread Vinod Koul
On Thu, 2012-10-18 at 13:32 +0800, Huang Shijie wrote: > From: Huang Shijie > > [1] Why add these new DMA control commands? > In mx6q, the gpmi-nand driver is the only user of the APBH-DMA. The dma > clock > is enabled when we have successfully requested a DMA channel. So even when >

[GIT PULL] dmaengine updates

2012-12-21 Thread Vinod Koul
raz Hashim (1): dmaengine/dmatest: terminate transfers only in case of errors Vinod Koul (5): of: dma- fix build break for !CONFIG_OF dmaengine: fix build failure due to missing semi-colon Merge branch 'topic/dmaengine_dt' into next dmaengine: fix !of_dma compilation

Re: [PATCH v2 0/5] dmaengine: add ACPI DMA helpers and use them in dw_dmac

2013-04-21 Thread Vinod Koul
On Tue, Apr 16, 2013 at 08:11:57PM +0200, Rafael J. Wysocki wrote: > On Tuesday, April 16, 2013 03:14:47 PM Andy Shevchenko wrote: > > On Mon, 2013-04-15 at 22:06 +0530, Vinod Koul wrote: > > > On Tue, Apr 09, 2013 at 02:05:42PM +0300, Andy Shevchenko wrote: > > > >

Re: [PATCH 02/32] dmaengine: ste_dma40: Move default memcpy configs into the driver

2013-04-22 Thread Vinod Koul
ing them into the driver instead. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Acked-by: Vinod Koul -- ~Vinod > --- > arch/arm/mach-ux500/devices-db8500.c| 28 --

Re: [PATCH 01/32] dmaengine: ste_dma40: Assign memcpy channels in the driver

2013-04-22 Thread Vinod Koul
hem directly into the driver. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Acked-by: Vinod Koul -- ~Vinod > --- > arch/arm/mach-ux500/devices-db8500.c| 12

Re: [PATCH 13/32] dmaengine: ste_dma40: Calculate number of logical channels from physical ones

2013-04-22 Thread Vinod Koul
lable ones, which is 32 per physical channel. However, this now > means we can remove some platform data and we don't have to worry > about adding vendor specific variables to Device Tree. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent &g

Re: [PATCH 17/32] dmaengine: ste_dma40: Remove redundant argument from d40_phy_cfg()

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:11:59AM +0100, Lee Jones wrote: > d40_phy_cfg is now only ever called to configure physical channels, so > there's no requirement to pass though an argument describing the type > of channel and to subsequently test for it. > > Cc: Vinod Koul >

Re: [PATCH 21/32] dmaengine: ste_dma40: Also report the number of logical channels

2013-04-22 Thread Vinod Koul
r: > and 256 logical channels > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones > --- > drivers/dma/ste_dma40.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/

Re: [PATCH 19/32] dmaengine: ste_dma40: Move more setup into the configuration routines

2013-04-22 Thread Vinod Koul
> > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Acked-by: Vinod Koul -- ~Vinod > --- > drivers/dma/ste_dma40.c | 22 ++ > 1 file changed, 10 insertions(+), 12 deletions(-) > > dif

Re: [PATCH 22/32] dmaengine: ste_dma40: Allocate plat_data on declaration

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:12:04AM +0100, Lee Jones wrote: > It's the way that most other drivers do it. > > Very trivial clean-up which reduces line count and simplifies code. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Si

Re: [PATCH 22/32] dmaengine: ste_dma40: Allocate plat_data on declaration

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:12:04AM +0100, Lee Jones wrote: > It's the way that most other drivers do it. > > Very trivial clean-up which reduces line count and simplifies code. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Si

Re: [PATCH 20/32] dmaengine: ste_dma40: Move rev error-check up to revision acquisition

2013-04-22 Thread Vinod Koul
; move the check right up underneath where we acquire the version. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Acked-by: Vinod Koul -- ~Vinod > --- > drivers/dma/ste_dma40.c | 10 -- > 1 file c

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

2013-04-22 Thread Vinod Koul
lightly more specific settings. I would like these to be DMAENGINE_IS_SRC... and this patch use the defines provided in dmaengine -- ~Vinod > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones > ---

Re: [PATCH 14/32] dmaengine: ste_dma40: Remove 'always true' checking

2013-04-22 Thread Vinod Koul
t; > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Acked-by: Vinod Koul The init should be updated to use devm_ versions.. -- ~Vinod > --- > drivers/dma/ste_dma40.c | 16 +--- > 1 file changed, 5 inserti

Re: [PATCH 21/32] dmaengine: ste_dma40: Also report the number of logical channels

2013-04-22 Thread Vinod Koul
On Mon, Apr 22, 2013 at 11:14:55AM +0100, Lee Jones wrote: > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > On Thu, Apr 18, 2013 at 11:12:03AM +0100, Lee Jones wrote: > > > Now we know the total of physical and logical channels, we may as > > > well report t

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-22 Thread Vinod Koul
to move > the remaining code in d40_phy_cfg(), which is mostly runtime configuration > into the runtime_config() routine. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones > --- > drivers/dma/ste_dma40.c|

Re: [PATCH 16/32] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:11:58AM +0100, Lee Jones wrote: > All configuration left in d40_phy_cfg() is runtime configurable and > there is already a call into it from d40_runtime_config(), so let's > rely on that. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per F

Re: [PATCH 23/32] dmaengine: ste_dma40: Allow driver to be probe()able when DT is enabled

2013-04-22 Thread Vinod Koul
provide > the compatible string and prepare the driver to not receive a platform > data pointer. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Acked-by: Vinod Koul -- ~Vinod &

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:11:50AM +0100, Lee Jones wrote: > The current implementation of the DMA40's local MAX() macro evaluates > its arguments more times than is necessary. This patch strips it > optimises it to only evaluate what's appropriate. > > Cc: Vinod Koul

Re: [PATCH 03/32 v2] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 01:16:37PM +0100, Lee Jones wrote: > The aim is to make the code that little more readable. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Acked-by: Arnd Bergmann > Signed-off-by: Lee Jones Acked-by: Vinod Ko

Re: [PATCH 24/32] dmaengine: ste_dma40: Supply full Device Tree parsing support

2013-04-22 Thread Vinod Koul
request and allocate a channel in the correct manor. typo^^^^^ > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones > --- > .../devicetree/bindin

Re: [PATCH 24/32 v2] dmaengine: ste_dma40: Supply full Device Tree parsing support

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 01:12:53PM +0100, Lee Jones wrote: > Using the new DMA DT bindings and API, we can register the DMA40 driver > as Device Tree capable. Now, when a client attempts to allocate a > channel using the DMA DT bindings via its own node, we are able to parse > the request and alloc

Re: [PATCH 24/32 v3] dmaengine: ste_dma40: Supply full Device Tree parsing support

2013-04-22 Thread Vinod Koul
request and allocate a channel in the correct manner. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Okay read vN if there is one, before replying! so.. Acked-by: Vinod Koul -- ~Vinod > > diff --git a/Documentati

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

2013-04-22 Thread Vinod Koul
On Mon, Apr 22, 2013 at 11:27:48AM +0100, Lee Jones wrote: > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: > > > There are lots of lengthy if() statements located sporadically up and > > > down the driver.

Re: [PATCH 21/32] dmaengine: ste_dma40: Also report the number of logical channels

2013-04-22 Thread Vinod Koul
On Mon, Apr 22, 2013 at 11:37:15AM +0100, Lee Jones wrote: > On Mon, 22 Apr 2013, Vinod Koul wrote: > You only get a warning for this too: Yup, oh i wrongly mention error > > WARNING: quoted string split across lines > #33: FILE: drivers/dma/ste_dma40.c:3204: > + d

Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding

2013-04-22 Thread Vinod Koul
On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote: > On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com : > > From: Ludovic Desroches > > +#ifdef CONFIG_OF > > +static bool at_dma_filter(struct dma_chan *chan, void *slave) this is not defined for else case here. Also this could be CO

<    1   2   3   4   5   6   7   8   9   10   >