[PATCHv2] kmemleak: Add option to print warnings to dmesg

2018-08-27 Thread Vincent Whitchurch
into automated test systems since those kind of systems presumably already save kernel logs. Signed-off-by: Vincent Whitchurch --- v2: Print hex dump too. lib/Kconfig.debug | 9 + mm/kmemleak.c | 37 ++--- 2 files changed, 39 insertions(+), 7 dele

Re: [PATCHv2] kmemleak: Add option to print warnings to dmesg

2018-08-28 Thread Vincent Whitchurch
On Mon, Aug 27, 2018 at 03:16:41PM -0700, Andrew Morton wrote: > On Mon, 27 Aug 2018 10:38:21 +0200 Vincent Whitchurch > wrote: > > > Currently, kmemleak only prints the number of suspected leaks to dmesg > > but requires the user to read a debugfs file to get the actual st

[PATCH 1/2] kmemleak: dump all objects for slab usage analysis

2018-08-28 Thread Vincent Whitchurch
t for slab usage analysis. Signed-off-by: Vincent Whitchurch --- mm/kmemleak.c | 53 + 1 file changed, 53 insertions(+) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 17dd883198ae..7bef05c690d6 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c

[PATCH 2/2] scripts: add kmemleak2pprof.py for slab usage analysis

2018-08-28 Thread Vincent Whitchurch
xa4 0.18MB 1.28% 31.86% 0.20MB 1.42% _do_fork+0xb0/0x41c 0.13MB 0.88% 32.74% 0.13MB 0.88% early_trace_init+0x16c/0x374 0.09MB 0.66% 33.40% 0.17MB 1.17% inet_init+0x128/0x24c 0.09MB 0.65% 34.05% 0.09MB 0.65% __kernfs_new_node+0x34/0x1a8 Signed-off-by: Vinc

Re: [PATCH 2/2] scripts: add kmemleak2pprof.py for slab usage analysis

2018-08-30 Thread Vincent Whitchurch
On Tue, Aug 28, 2018 at 04:28:04PM -0700, Andrew Morton wrote: > On Tue, 28 Aug 2018 12:39:14 +0200 Vincent Whitchurch > wrote: > > > Add a script which converts /sys/kernel/debug/kmemleak_all to the pprof > > format, which can be used for analysing memory usage. See &

Re: [PATCHv2] kmemleak: Add option to print warnings to dmesg

2018-08-30 Thread Vincent Whitchurch
On Tue, Aug 28, 2018 at 11:26:22AM +0100, Catalin Marinas wrote: > On Tue, Aug 28, 2018 at 12:14:12PM +0200, Vincent Whitchurch wrote: > > On Mon, Aug 27, 2018 at 03:16:41PM -0700, Andrew Morton wrote: > > > On Mon, 27 Aug 2018 10:38:21 +0200 Vincent Whitchurch > > &

[PATCH] watchdog: Mark watchdog touch functions as notrace

2018-08-21 Thread Vincent Whitchurch
4f06dcbb5d ("stop_machine: Touch_nmi_watchdog() after MULTI_STOP_PREPARE") Signed-off-by: Vincent Whitchurch --- kernel/watchdog.c | 4 ++-- kernel/watchdog_hld.c | 2 +- kernel/workqueue.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/watchdog.c b/ker

[PATCH] kmemleak: Add option to print warnings to dmesg

2018-08-24 Thread Vincent Whitchurch
asier integration of kmemleak into automated test systems since those kind of systems presumably already save kernel logs. Signed-off-by: Vincent Whitchurch --- lib/Kconfig.debug | 9 + mm/kmemleak.c | 21 + 2 files changed, 26 insertions(+), 4 deletions(-) diff --git

[PATCH] kmemleak: Always register debugfs file

2018-08-24 Thread Vincent Whitchurch
, if the file doesn't exist, kmemleak is not available in the kernel. If writing "scan" or any other value than "clear" to this file results in EBUSY, then kmemleak is available but is disabled by default and can be activated via the kernel command line. Signed-off-by: Vi

Re: [PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-22 Thread Vincent Whitchurch
On Thu, Nov 22, 2018 at 12:01:54PM +, Dave Martin wrote: > On Mon, Nov 19, 2018 at 05:25:12PM +0100, Vincent Whitchurch wrote: > > st_info is currently overwritten after relocation and used to store the > > elf_type(). However, we're going to need it fix kallsyms on ARM&#

[PATCH 1/2] module: Overwrite st_size instead of st_info

2018-11-19 Thread Vincent Whitchurch
Signed-off-by: Vincent Whitchurch --- v4: Split out to separate patch. Use st_size instead of st_other. v1-v3: See PATCH 2/2 kernel/module.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 49a405891587..3d86a38b580c 100644 --

[PATCH 2/2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-19 Thread Vincent Whitchurch
/kallsyms | grep tun_get_socket 7f802d4c t tun_get_socket [tun] PC is at tun_get_socket+0x0/0x24 [tun] pc : [<7f802d4c>] Signed-off-by: Vincent Whitchurch --- v4: Split out st_value overwrite change. Add HAVE* macro to avoid function call. v3: Do not overwrite st_value v2:

[PATCH v3] ARM: module: Fix function kallsyms on Thumb-2

2018-11-13 Thread Vincent Whitchurch
served. After the fix: $ cat /proc/kallsyms | grep tun_get_socket 7fcd30e0 t tun_get_socket [tun] PC is at tun_get_socket+0x8/0x2c [tun] pc : [<7fcdb0e8>] Signed-off-by: Vincent Whitchurch --- v3: Do not overwrite st_value v2: Fix build warning with !MODULES arch/arm/kernel/module.c

[PATCH v5 2/2] ARM: module: Fix function kallsyms on Thumb-2

2018-12-04 Thread Vincent Whitchurch
/kallsyms | grep tun_get_socket 7f802d4c t tun_get_socket [tun] PC is at tun_get_socket+0x0/0x24 [tun] pc : [<7f802d4c>] Signed-off-by: Vincent Whitchurch --- v5: Use/move local variables to reduce calls and keep lines short. Use const arg. v4: Split out st_value overwrite chang

[PATCH v5 1/2] module: Overwrite st_size instead of st_info

2018-12-04 Thread Vincent Whitchurch
eviewed-by: Dave Martin Signed-off-by: Vincent Whitchurch --- v5: Add Dave Martin's Reviewed-by v4: Split out to separate patch. Use st_size instead of st_other. v1-v3: See PATCH 2/2 kernel/module.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/module.c b/

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-09 Thread Vincent Whitchurch
On Fri, Nov 02, 2018 at 02:53:22PM +0100, Jessica Yu wrote: > +++ Vincent Whitchurch [01/11/18 16:29 +0100]: > > On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: > > > Could this be done in modpost? I'm guessing the answer is no as some > > > relocation

[PATCH v6 modules-next 1/2] module: Overwrite st_size instead of st_info

2018-12-14 Thread Vincent Whitchurch
eviewed-by: Miroslav Benes Reviewed-by: Dave Martin Signed-off-by: Vincent Whitchurch --- v6: Add Miroslav Benes' Reviewed-by v5: Add Dave Martin's Reviewed-by v4: Split out to separate patch. Use st_size instead of st_other. v1-v3: See PATCH 2/2 kernel/module.c | 4 ++-- 1 file c

[PATCH v6 modules-next 2/2] ARM: module: Fix function kallsyms on Thumb-2

2018-12-14 Thread Vincent Whitchurch
/kallsyms | grep tun_get_socket 7f802d4c t tun_get_socket [tun] PC is at tun_get_socket+0x0/0x24 [tun] pc : [<7f802d4c>] Signed-off-by: Vincent Whitchurch --- v6: Rename module_kallsyms_symbol_value() -> kallsyms_symbol_value() v5: Use/move local variables to reduce calls a

Re: [PATCH v5 2/2] ARM: module: Fix function kallsyms on Thumb-2

2018-12-14 Thread Vincent Whitchurch
On Thu, Dec 06, 2018 at 06:29:20PM +0100, Jessica Yu wrote: > Also, do you mind if I drop the module_ prefix from > module_kallsyms_symbol_value()? I recently submitted some internal > module kallsyms cleanups [1] and there we have the newly renamed > kallsyms_symbol_name(), so I think it'd be nice

[PATCH] drop_caches: Allow unmapping pages

2019-01-07 Thread Vincent Whitchurch
tive(file):240 kB Inactive(file): 2344 kB Signed-off-by: Vincent Whitchurch --- Documentation/sysctl/vm.txt | 4 fs/drop_caches.c| 3 ++- include/linux/fs.h | 10 -- kernel/sysctl.c | 4 ++-- mm/truncat

[PATCH] ARM: module: Fix function kallsyms on Thumb-2

2018-10-29 Thread Vincent Whitchurch
7fcd30e0 t tun_get_socket [tun] PC is at tun_get_socket+0x8/0x2c [tun] pc : [<7fcdb0e8>] Signed-off-by: Vincent Whitchurch --- arch/arm/kernel/module.c | 14 ++ include/linux/moduleloader.h | 2 ++ kernel/module.c | 6 ++ 3 files changed, 22 insertions

[PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-10-31 Thread Vincent Whitchurch
7fcd30e0 t tun_get_socket [tun] PC is at tun_get_socket+0x8/0x2c [tun] pc : [<7fcdb0e8>] Signed-off-by: Vincent Whitchurch --- v2: Fix build warning with !MODULES arch/arm/kernel/module.c | 14 ++ include/linux/moduleloader.h | 3 +++ kernel/module.c

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-01 Thread Vincent Whitchurch
On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: > Could this be done in modpost? I'm guessing the answer is no as some > relocations may rely on that bit being set in st_value, right? > Therefore we can only clear the bit _after_ relocations to the module > are applied at runtime, corre

[PATCH v2] sysctl: Add panic-fatal-signals

2019-01-28 Thread Vincent Whitchurch
ned-off-by: Vincent Whitchurch --- v2: Put the sysctl behind a config option include/linux/signal.h | 1 + init/Kconfig | 14 ++ kernel/signal.c| 5 - kernel/sysctl.c| 9 + 4 files changed, 28 insertions(+), 1 deletion(-) diff --git a/include/linu

[PATCH] tty: Add NULL TTY driver

2019-04-03 Thread Vincent Whitchurch
. with console=ttynull. Signed-off-by: Vincent Whitchurch --- drivers/tty/Kconfig | 14 ++ drivers/tty/Makefile | 1 + drivers/tty/ttynull.c | 109 ++ 3 files changed, 124 insertions(+) create mode 100644 drivers/tty/ttynull.c diff --git a

Re: [PATCH] tty: Add NULL TTY driver

2019-04-03 Thread Vincent Whitchurch
On Wed, Apr 03, 2019 at 03:12:13PM +0200, Greg KH wrote: > On Wed, Apr 03, 2019 at 01:33:27PM +0200, Vincent Whitchurch wrote: > > If no console driver is enabled (or if a non-present driver is selected > > with something like console=null in an attempt to disable the console), &

Re: [PATCH] tty: Add NULL TTY driver

2019-04-11 Thread Vincent Whitchurch
On Fri, Apr 05, 2019 at 02:32:41PM +0200, Enrico Weigelt, metux IT consult wrote: > On 05.04.19 11:00, Vincent Whitchurch wrote: > > On Fri, Apr 05, 2019 at 10:39:43AM +0200, Enrico Weigelt, metux IT consult > > wrote: > >> On 03.04.19 16:11, Vincent Whitchurch wrote:

[PATCH] perf bench mem: Always memset source before memcpy

2020-08-10 Thread Vincent Whitchurch
LLC-loads 8.674301124 seconds time elapsed $ $cmd --cycles 214,758,651 LLC-loads 8.644480006 seconds time elapsed Fixes: 47b5757bac03c3387c ("perf bench mem: Move boilerplate memory allocation to the infrastructure") Signed-off-by: Vincent Whitchurch --- tools/perf/b

[PATCH v3] cifs: Silently ignore unknown oplock break handle

2021-03-19 Thread Vincent Whitchurch
NumMids 2 : 424d53fe 0040 0012 .SMB@... 0010: 0001 0020: 0030: Signed-off-by: Vincent Whitchurch

[PATCH] CIFS: Prevent error log on spurious oplock break

2021-03-05 Thread Vincent Whitchurch
ch we ignore as per the spec. Signed-off-by: Vincent Whitchurch --- fs/cifs/smb2misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c index 60d4bd1eae2b..3ea3bda64083 100644 --- a/fs/cifs/smb2misc.c +++ b/fs/cifs

[PATCH v2] cifs: Silently ignore unknown oplock break handle

2021-03-16 Thread Vincent Whitchurch
f 0020: 0030: Signed-off-by: Vincent Whitchurch --- Notes: v2: - Drop change to lease break - Rewrite commit message fs/cifs/smb2misc.c

Re: [PATCH 1/9] regulator: Update DA9121 dt-bindings

2020-11-20 Thread Vincent Whitchurch
ml > @@ -8,40 +8,185 @@ title: Dialog Semiconductor DA9121 voltage regulator > > maintainers: >- Vincent Whitchurch > + - Adam Ward I'm quite happy to have myself removed from the list instead. You are in a much better position to maintain the bindings for these chip

Re: [PATCH 1/9] regulator: Update DA9121 dt-bindings

2020-11-25 Thread Vincent Whitchurch
On Fri, Nov 20, 2020 at 02:47:42PM +0100, Vincent Whitchurch wrote: > On Fri, Nov 20, 2020 at 01:14:50PM +0100, Adam Ward wrote: > > - buck1: > > -description: > > - Initial data for the Buck1 regulator. > > -$ref: "regulator.yaml#" > >

Re: [PATCH] CIFS: Prevent error log on spurious oplock break

2021-03-12 Thread Vincent Whitchurch
On Tue, Mar 09, 2021 at 04:29:14PM +0100, Steve French wrote: > On Tue, Mar 9, 2021, 07:42 Vincent Whitchurch via samba-technical > mailto:samba-techni...@lists.samba.org>> > wrote: >> Thank you for the suggestions. In my case, I've only received some >> reports

Re: [PATCH] CIFS: Prevent error log on spurious oplock break

2021-03-09 Thread Vincent Whitchurch
On Tue, Mar 09, 2021 at 01:05:11AM +0100, ronnie sahlberg wrote: > On Sun, Mar 7, 2021 at 8:52 PM Shyam Prasad N via samba-technical > wrote: > > The reason for rejecting the request maybe a number of things like: > > corrupted request, stale request (for some old session), or for a > > wrong hand

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-21 Thread Vincent Whitchurch
On Fri, Jan 18, 2019 at 04:49:16PM -0700, Stephen Warren wrote: > On 1/16/19 9:32 AM, Vincent Whitchurch wrote: > > The Virtio-over-PCIe framework living under drivers/misc/mic/vop implements > > a > > generic framework to use virtio between two Linux systems, given shared

[PATCH] mic: vop: Fix broken virtqueues

2019-01-29 Thread Vincent Whitchurch
virtqueue() to create the needed vring layout from the start, instead of attempting to patch in the used ring later. __vring_new_virtqueue() was added way back in commit 2a2d1382fe9dcc ("virtio: Add improved queue allocation API") in order to address mic's usecase, according

[PATCH] sysctl: Add panic-fatal-signals

2019-01-16 Thread Vincent Whitchurch
ned-off-by: Vincent Whitchurch --- include/linux/signal.h | 1 + kernel/signal.c| 5 - kernel/sysctl.c| 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/signal.h b/include/linux/signal.h index cc7e2c1cd444..109efd1432e9 100644 --- a/inc

[PATCH 8/8] vop: Add loopback

2019-01-16 Thread Vincent Whitchurch
Add a loopback driver to allow testing and evaluation of the VOP framework without special hardware. The host and the guest will run under the same kernel. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/Kconfig| 10 + drivers/misc/mic/vop/Makefile | 2 + drivers

[PATCH 3/8] vop: Add definition of readq/writeq if missing

2019-01-16 Thread Vincent Whitchurch
Include so that readq/writeq are replaced by two readl/writel on systems that do not support them. The values read/written are pointers which will be 32-bit on 32-bit systems so the non-atomicity should not matter. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 1 + 1

[PATCH 7/8] vop: Use consistent DMA

2019-01-16 Thread Vincent Whitchurch
The vop code maps buffers using the streaming DMA API but never syncs them so it doesn't work on systems without cache coherence. The vrings want consistent mappings, and not streaming mappings so use that API to allocate and map buffers. Signed-off-by: Vincent Whitchurch --- drivers/mis

[PATCH 1/8] vop: Use %z for size_t

2019-01-16 Thread Vincent Whitchurch
Fixes these kind of errors on 32-bit: drivers/misc/mic/vop/vop_vringh.c:590:3: error: format '%lx' expects argument of type 'long unsigned int', but argument 7 has type 'size_t {aka unsigned int}' [-Werror=format=] Signed-off-by: Vincent Whitchurch --- drivers

[PATCH 5/8] vop: vringh: Do not crash if no DMA channel

2019-01-16 Thread Vincent Whitchurch
Fallback gracefully if no DMA channel is provided instead of dereferencing NULL pointers. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_vringh.c | 32 +++ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/misc/mic/vop

[PATCH 6/8] vop: Fix handling of >32 feature bits

2019-01-16 Thread Vincent Whitchurch
This is needed, for example, for VIRTIO_F_IOMMU_PLATFORM. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c index 26b23f2cf94c

[PATCH 4/8] vop: Allow building on more systems

2019-01-16 Thread Vincent Whitchurch
VOP_BUS does not actually depend on 32-bit X86 or PCI. The code uses archdata.dma_ops so it can be built on ARM too. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/Kconfig b/drivers/misc

[PATCH 2/8] vop: Cast pointers to uintptr_t

2019-01-16 Thread Vincent Whitchurch
Fix these on 32-bit: vop_vringh.c:711:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 8 drivers/misc/mic/vop/vop_vringh.c | 4 ++-- 2 files changed, 6 insertions(+), 6

[PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-16 Thread Vincent Whitchurch
the series does not break anything there. Vincent Whitchurch (8): vop: Use %z for size_t vop: Cast pointers to uintptr_t vop: Add definition of readq/writeq if missing vop: Allow building on more systems vop: vringh: Do not crash if no DMA channel vop: Fix handling of >32 featu

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-17 Thread Vincent Whitchurch
On Wed, Jan 16, 2019 at 06:07:53PM +0100, Arnd Bergmann wrote: > On Wed, Jan 16, 2019 at 5:33 PM Vincent Whitchurch > wrote: > > The Virtio-over-PCIe framework living under drivers/misc/mic/vop implements > > a > > generic framework to use virtio between two Lin

Re: [PATCH] sysctl: Add panic-fatal-signals

2019-01-17 Thread Vincent Whitchurch
On Wed, Jan 16, 2019 at 09:06:18AM -0800, Kees Cook wrote: > On Wed, Jan 16, 2019 at 4:54 AM Vincent Whitchurch > wrote: > > Add a sysctl which asks the kernel to panic when any userspace process > > receives a fatal signal which would trigger a core dump. This has > > p

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-17 Thread Vincent Whitchurch
On Thu, Jan 17, 2019 at 01:39:27PM +0100, Arnd Bergmann wrote: > Correct, and again we have to see if this is a good interface. The NTB > and PCIe-endpoint interfaces have a number of differences and a > number of similarities. In particular they should both be usable with > virtio-style drivers, b

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-17 Thread Vincent Whitchurch
On Thu, Jan 17, 2019 at 07:21:42AM -0800, Christoph Hellwig wrote: > On Thu, Jan 17, 2019 at 04:19:06PM +0100, Vincent Whitchurch wrote: > > On the RC, a vop-host-backend driver (PCI driver) sets up some shared > > memory area which the RC and the endpoint can use to communicate t

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-17 Thread Vincent Whitchurch
On Thu, Jan 17, 2019 at 04:53:25PM +0100, Arnd Bergmann wrote: > On Thu, Jan 17, 2019 at 4:19 PM Vincent Whitchurch > wrote: > > On Thu, Jan 17, 2019 at 01:39:27PM +0100, Arnd Bergmann wrote: > > > Can you describe how you expect a VOP device over NTB or > > > P

[PATCH] mic: vop: Fix crash on remove

2019-02-01 Thread Vincent Whitchurch
oved. The structure in question is only examined to get the virtual address of the allocated used page. Store that pointer locally instead to fix the crash. Fixes: 1ce9e6055fa0 ("virtio_ring: introduce packed ring support") Signed-off-by: Vincent Whitchurch --- drivers/misc/mi

[PATCH] mic: vop: Fix use-after-free on remove

2019-02-01 Thread Vincent Whitchurch
8800da18600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb 88800da18680: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb == Fixes: 0063e8bbd2b62d136 ("virtio_vop: don't kfree device on register failure") Sign

Re: [PATCH v2] mic: vop: Fix broken virtqueues

2019-02-01 Thread Vincent Whitchurch
On Wed, Jan 30, 2019 at 08:40:23PM +0100, Greg KH wrote: > This patch is already in my tree, can you just send a "fixup" patch > instead of me having to revert the old one and then adding this one > again? I've now posted the fixup patch separately as "mic: vop: Fix crash on remove". Thanks.

Re: [PATCH] tty: Add NULL TTY driver

2019-04-05 Thread Vincent Whitchurch
On Fri, Apr 05, 2019 at 10:39:43AM +0200, Enrico Weigelt, metux IT consult wrote: > On 03.04.19 16:11, Vincent Whitchurch wrote: > > > Especially on embedded systems, it would be convenient to have a simple > > way to disable the console (both for kernel and userspace) on

[PATCH v2] printk: Do not lose last line in kmsg buffer dump

2019-07-11 Thread Vincent Whitchurch
31 32 33 34 35 0a ] 12345. 0020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Signed-off-by: Vincent Whitchurch --- v2: Move fix to kmsg_dump_get_buffer() kernel/printk/printk.c | 2 +- 1 file cha

Re: [PATCH v2] printk: Do not lose last line in kmsg buffer dump

2019-07-12 Thread Vincent Whitchurch
On Fri, Jul 12, 2019 at 10:09:04AM +0200, Petr Mladek wrote: > The patch looks like a hack using a hole that the next cycle > does not longer check the number of really stored characters. > > What would happen when msg_print_text() starts adding > the trailing '\0' as suggested by > https://lkml.k

[PATCH] crypto: cryptd - Fix skcipher instance memory leak

2019-07-02 Thread Vincent Whitchurch
2, jiffies 4294894830 (age 52.760s) backtrace: kmem_cache_alloc_trace+0x270/0x2d0 cryptd_create+0x990/0x124c cryptomgr_probe+0x5c/0x1e8 kthread+0x258/0x318 ret_from_fork+0x10/0x1c Signed-off-by: Vincent Whitchurch --- crypto/cryptd.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH] printk: Do not lose last line in kmsg dump

2019-07-09 Thread Vincent Whitchurch
lways LOG_LINE_MAX + PREFIX_MAX, and PREFIX_MAX has a value which is larger than the largest possible prefix). Signed-off-by: Vincent Whitchurch --- I posted this patch two years ago and received no replies. This problem is still present in mainline. https://lore.kernel.org/patchwork/patch/78110

Re: [PATCH] printk: Do not lose last line in kmsg dump

2019-07-10 Thread Vincent Whitchurch
On Tue, Jul 09, 2019 at 04:29:39PM +0200, Petr Mladek wrote: > On Tue 2019-07-09 19:12:30, Sergey Senozhatsky wrote: > > On (07/09/19 10:10), Vincent Whitchurch wrote: > > > A dump of a 64-byte buffer filled by kmsg_dump_get_buffer(), before this > > > patch: > > &

[PATCH v2 char-misc-next 5/7] mic: vop: Fix init race with shared interrupts

2019-02-22 Thread Vincent Whitchurch
eeping a local list of virtqueues in this driver and using that instead of the list inside the struct virtio_device, similar to how virtio-pci handles this. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 42 ++--- 1 file changed, 39 insertio

[PATCH v2 char-misc-next 3/7] mic: vop: Allow building on more systems

2019-02-22 Thread Vincent Whitchurch
VOP_BUS does not actually depend on x86-64 or PCI or X86_DEV_DMA_OPS. The dependency on X86_DEV_DMA_OPS has been unnecessary since commit 5657933dbb6e25fe ("treewide: Move dma_ops from struct dev_archdata into struct device"). Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/K

[PATCH v2 char-misc-next 4/7] vop: Add loopback driver

2019-02-22 Thread Vincent Whitchurch
Add a loopback driver to allow testing and evaluation of the VOP framework without special hardware. The host and the guest will run under the same kernel. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/Kconfig| 10 + drivers/misc/mic/vop/Makefile | 2 + drivers

[PATCH v2 char-misc-next 4/7] mic: vop: Add loopback driver

2019-02-22 Thread Vincent Whitchurch
Add a loopback driver to allow testing and evaluation of the VOP framework without special hardware. The host and the guest will run under the same kernel. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/Kconfig| 10 + drivers/misc/mic/vop/Makefile | 2 + drivers

[PATCH v2 char-misc-next 1/7] vop: Cast pointers to unsigned long

2019-02-22 Thread Vincent Whitchurch
Fix these on 32-bit: vop_vringh.c:711:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 13 + drivers/misc/mic/vop/vop_vringh.c | 5 +++-- 2 files changed, 12

[PATCH v2 char-misc-next 3/7] vop: Allow building on more systems

2019-02-22 Thread Vincent Whitchurch
VOP_BUS does not actually depend on x86-64 or PCI or X86_DEV_DMA_OPS. The dependency on X86_DEV_DMA_OPS has been unnecessary since commit 5657933dbb6e25fe ("treewide: Move dma_ops from struct dev_archdata into struct device"). Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/K

[PATCH v2 char-misc-next 6/7] samples: mic: Split out vop code from mpssd

2019-02-22 Thread Vincent Whitchurch
is just movement of unmodified code between files. Signed-off-by: Vincent Whitchurch --- samples/mic/mpssd/Makefile |4 +- samples/mic/mpssd/mpssd.c | 1317 +- samples/mic/mpssd/mpssd.h |1 + samples/mic/mpssd/vop.c| 1357

[PATCH v2 char-misc-next 2/7] mic: Rename ioremap pointer to remap

2019-02-22 Thread Vincent Whitchurch
o "ioremap" passed 3 arguments, but takes just 2 Rename ioremap to remap to fix this. Likewise for iounmap. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/bus/scif_bus.h| 8 drivers/misc/mic/bus/vop_bus.h | 8 drivers/misc/mic/card/mic_device.c | 8 ++

[PATCH v2 char-misc-next 1/7] mic: vop: Cast pointers to unsigned long

2019-02-22 Thread Vincent Whitchurch
Fix these on 32-bit: vop_vringh.c:711:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 13 + drivers/misc/mic/vop/vop_vringh.c | 5 +++-- 2 files changed, 12

[PATCH v2 char-misc-next 0/7] Virtio-over-PCIe on non-MIC

2019-02-22 Thread Vincent Whitchurch
patches which have merged - Use unsigned long instead of uintptr_t - Drop "Use consistent DMA" for now since it's not needed for loopback - Add race fix - Build on all architectures, not just ARM and x86 - Add sample userspace code Vincent Whitchurch (7): mic: vop: Cast pointers t

[PATCH v2 char-misc-next 7/7] samples: mic: Add sample VOP userspace

2019-02-22 Thread Vincent Whitchurch
uest: # ping6 fe80::1%mic0 Ping from guest to host: # ping6 fe80::0%eth1 Signed-off-by: Vincent Whitchurch --- samples/mic/mpssd/.gitignore | 1 + samples/mic/mpssd/Makefile | 5 - samples/mic/mpssd/vopd.c | 25 + 3 files changed, 30 insertions(+), 1 dele

[PATCH] Documentation/sysctl/vm.txt: Fix drop_caches bit number

2019-01-11 Thread Vincent Whitchurch
Bits are usually numbered starting from zero, so 4 should be bit 2, not bit 3. Suggested-by: Matthew Wilcox Signed-off-by: Vincent Whitchurch --- Documentation/sysctl/vm.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl

[PATCH v3] kmemleak: add module param to print warnings to dmesg

2018-09-03 Thread Vincent Whitchurch
ial handling makes kmemleak more similar to other kernel debug options (slab debugging, debug objects, etc). Signed-off-by: Vincent Whitchurch --- v3: Expand use case description. Replace config option with module parameter. mm/kmemleak.c | 42 +++--- 1 file chan

Re: [PATCH v2] dynamic debug: allow printing to trace event

2020-08-25 Thread Vincent Whitchurch
On Fri, Aug 14, 2020 at 11:30:34PM +0200, Jason Baron wrote: > On 8/14/20 1:15 PM, Steven Rostedt wrote: > > On Fri, 14 Aug 2020 15:31:51 +0200 > > Vincent Whitchurch wrote: > >> index aa9ff9e1c0b3..f599ed21ecc5 100644 > >> --- a/include/linux/dynamic

[PATCH v3 1/2] dynamic debug: split enable and printk flags

2020-08-25 Thread Vincent Whitchurch
ff-by: Vincent Whitchurch --- include/linux/dynamic_debug.h | 9 + lib/dynamic_debug.c | 8 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index aa9ff9e1c0b3..738421898aac 100644 --- a/include/

[PATCH v3 0/2] Dynamic debug trace support

2020-08-25 Thread Vincent Whitchurch
v3: - Split flag rename to a separate patch - Rename event to printk:dyndbg v2: - Remove stack buffer and use code similar to __ftrace_trace_stack() - Use an event with the same class as printk:console Vincent Whitchurch (2): dynamic debug: split enable and printk flags dynamic debug

[PATCH v3 2/2] dynamic debug: allow printing to trace event

2020-08-25 Thread Vincent Whitchurch
e truncated. Signed-off-by: Vincent Whitchurch --- .../admin-guide/dynamic-debug-howto.rst | 1 + include/linux/dynamic_debug.h | 4 +- include/trace/events/printk.h | 12 +- lib/dynamic_debug.c | 153 +++---

Re: [PATCH v2] dynamic debug: allow printing to trace event

2020-08-25 Thread Vincent Whitchurch
On Fri, Aug 14, 2020 at 07:15:31PM +0200, Steven Rostedt wrote: > On Fri, 14 Aug 2020 15:31:51 +0200 > Vincent Whitchurch wrote: > > index aa9ff9e1c0b3..f599ed21ecc5 100644 > > --- a/include/linux/dynamic_debug.h > > +++ b/include/linux/dynamic_debug.h > > @@ -

[PATCH v2 2/2] ARM: module: fix handling of unwind init sections

2020-05-11 Thread Vincent Whitchurch
of range (0xcbb54078 -> 0x7f80) Fix this by informing the module core that these sections are init sections, and by removing the init unwind tables before the module core frees the init sections. Signed-off-by: Vincent Whitchurch --- v2: No changes. arch/arm/kernel/module.c | 22 +++

[PATCH v2 1/2] module: allow arch overrides for .init section names

2020-05-11 Thread Vincent Whitchurch
override the section name so that ARM can fix this. Signed-off-by: Vincent Whitchurch --- v2: Add comment and move module_init_section() next to module_exit_section(). include/linux/moduleloader.h | 5 + kernel/module.c | 9 +++-- 2 files changed, 12 insertions(+), 2 deleti

Re: [PATCH v2 1/2] module: allow arch overrides for .init section names

2020-05-14 Thread Vincent Whitchurch
On Mon, May 11, 2020 at 05:45:00PM +0200, Jessica Yu wrote: > +++ Vincent Whitchurch [11/05/20 13:48 +0200]: > >ARM stores unwind information for .init.text in sections named > >.ARM.extab.init.text and .ARM.exidx.init.text. Since those aren't > >currently recognized

Re: [PATCH v3 2/2] dynamic debug: allow printing to trace event

2020-09-02 Thread Vincent Whitchurch
On Wed, Aug 26, 2020 at 09:53:57PM +0200, Joe Perches wrote: > On Wed, 2020-08-26 at 15:32 -0400, Steven Rostedt wrote: > > On Tue, 25 Aug 2020 08:53:25 -0700 > > Joe Perches wrote: > > > > > > The print buffer is statically allocated and managed using code borrowed > > > > from __ftrace_trace_st

[PATCH] regulator: pwm: Fix machine constraints application

2020-09-02 Thread Vincent Whitchurch
fooregulator: failed to get the current voltage(-22) After this patch: fooregulator: Setting 225-225uV fooregulator: 2250 mV Signed-off-by: Vincent Whitchurch --- drivers/regulator/pwm-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH v2] dynamic debug: allow printing to trace event

2020-08-14 Thread Vincent Whitchurch
er will be truncated. Signed-off-by: Vincent Whitchurch --- v2: - Remove stack buffer and use code similar to __ftrace_trace_stack() - Use an event with the same class as printk:console .../admin-guide/dynamic-debug-howto.rst | 1 + include/linux/dynamic_debug.h | 7 +-

Re: [PATCH] dynamic debug: allow printing to trace event

2020-08-14 Thread Vincent Whitchurch
On Thu, Jul 23, 2020 at 05:26:44PM +0200, Steven Rostedt wrote: > On Thu, 23 Jul 2020 12:57:35 +0200 > Vincent Whitchurch wrote: > > > Would it be acceptable to just use a fixed size for the event? At least > > for my own debugging use cases it's preferable to jus

[PATCH v2] gpio: mockup: Allow probing from device tree

2020-10-27 Thread Vincent Whitchurch
Allow the mockup driver to be probed via the device tree without any module parameters, allowing it to be used to configure and test higher level drivers like the leds-gpio driver and corresponding userspace before actual hardware is available. Signed-off-by: Vincent Whitchurch --- v2: Remove

Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-27 Thread Vincent Whitchurch
On Tue, Oct 27, 2020 at 08:05:43AM +0100, Sherry Sun wrote: > Can you help test the patch about removing the codes of reassign used > ring, and comment on the impact for Intel MIC platform? Thanks for > any help. I don't have access to MIC hardware myself, either. But this patch is quite certain

[PATCH] of: Fix reserved-memory overlap detection

2020-10-20 Thread Vincent Whitchurch
(0x1000--0x2000) Signed-off-by: Vincent Whitchurch --- drivers/of/of_reserved_mem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 46b9371c8a33..1c5259e3e81f 100644 --- a/drivers/of/of_reserved_mem.c +

Re: [PATCH] of: Fix reserved-memory overlap detection

2020-10-20 Thread Vincent Whitchurch
On Tue, Oct 20, 2020 at 03:00:14PM +0200, Rob Herring wrote: > On Tue, Oct 20, 2020 at 2:36 AM Vincent Whitchurch > wrote: > > > > The reserved-memory overlap detection code fails to detect overlaps if > > either of the regions starts at address 0x0. For some reason

[PATCH v2] of: Fix reserved-memory overlap detection

2020-10-21 Thread Vincent Whitchurch
: OVERLAP DETECTED! bar@0 (0x--0x1000) overlaps with foo@0 (0x--0x2000) OF: reserved mem: OVERLAP DETECTED! foo@0 (0x--0x2000) overlaps with baz@1000 (0x1000--0x00002000) Signed-off-by: Vincent Whitchurch --- v2: Fix handling of dynamically allocat

Re: [PATCH] of: Fix reserved-memory overlap detection

2020-10-21 Thread Vincent Whitchurch
On Tue, Oct 20, 2020 at 04:17:27PM +0200, Rob Herring wrote: > On Tue, Oct 20, 2020 at 8:46 AM Vincent Whitchurch > wrote: > > On Tue, Oct 20, 2020 at 03:00:14PM +0200, Rob Herring wrote: > > > On Tue, Oct 20, 2020 at 2:36 AM Vincent Whitchurch > > > wrote: >

Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-28 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 02:47:49AM +0100, Sherry Sun wrote: > > Subject: Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used > > ring > > > > On Tue, Oct 27, 2020 at 08:05:43AM +0100, Sherry Sun wrote: > > > Can you help test the patch about removing the codes of reassign used > >

Re: [PATCH V5 0/2] Change vring space from nomal memory to dma coherent memory

2020-10-28 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 06:58:36AM +0100, Greg KH wrote: > Have you all seen: > > https://lore.kernel.org/r/8c1443136563de34699d2c084df478181c205db4.1603854416.git.sudeep.d...@intel.com No, that link doesn't work and I can't find that email from Sudeep in any of the archives: https://lore

Re: [PATCH v2] gpio: mockup: Allow probing from device tree

2020-10-28 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 12:43:22PM +0100, Andy Shevchenko wrote: > On Wed, Oct 28, 2020 at 10:00 AM Vincent Whitchurch > wrote: > > Allow the mockup driver to be probed via the device tree without any > > module parameters, allowing it to be used to configure and test higher

Re: [PATCH v2] gpio: mockup: Allow probing from device tree

2020-10-28 Thread Vincent Whitchurch
On Tue, Oct 27, 2020 at 07:12:13PM +0100, Bartosz Golaszewski wrote: > On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch > wrote: > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > > index 67ed4f238d43..c93892a6936a 100644 > > --- a/drivers/gpio

[PATCH v3] gpio: mockup: Allow probing from device tree

2020-10-28 Thread Vincent Whitchurch
Allow the mockup driver to be probed via the device tree without any module parameters, allowing it to be used to configure and test higher level drivers like the leds-gpio driver and corresponding userspace before actual hardware is available. Signed-off-by: Vincent Whitchurch --- Notes

Re: [PATCH v2] gpio: mockup: Allow probing from device tree

2020-10-29 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 09:25:32PM +0100, Andy Shevchenko wrote: > On Wed, Oct 28, 2020 at 8:41 PM Bartosz Golaszewski wrote: > > On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch > > > +#ifdef CONFIG_OF > > > +static const struct of_dev

[PATCH v4] gpio: mockup: Allow probing from device tree

2020-10-29 Thread Vincent Whitchurch
Allow the mockup driver to be probed via the device tree without any module parameters, allowing it to be used to configure and test higher level drivers like the leds-gpio driver and corresponding userspace before actual hardware is available. Signed-off-by: Vincent Whitchurch --- Notes

Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-29 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 04:50:36PM +0100, Arnd Bergmann wrote: > I think we should try to do something on top of the PCIe endpoint subsystem > to make it work across arbitrary combinations of host and device > implementations, > and provide a superset of what the MIC driver, (out-of-tree) Bluefield

  1   2   >