Patch "x86: Store a per-cpu shadow copy of CR4" gives VirtualBox 4.3.24 indigestion.

2015-03-03 Thread Valdis Kletnieks
Just a heads up, as it's a out-of-tree module, so this is mostly to get it out for the benefit of others googling for this.. I'm seeing a kernel panic with VirtualBox 4.3.24 with a weird but consistent traceback: [ 359.370165] created IOMMU domain 8801ffeecd80 [ 395.739820] general protect

[RFC PATCH] Don't reset timestamps in include/generated if not needed

2015-03-03 Thread Valdis Kletnieks
Kbuild regenerates bounds.h and asm-offsets.h, resetting the timestamps and forcing rebuilds even if the contents haven't changed. Add a bit of shell magic to only replace the file if the contents have in fact changed, which should speed up git bisects and similar. Signed-off-by: V

Re: Patch "x86: Store a per-cpu shadow copy of CR4" gives VirtualBox 4.3.24 indigestion.

2015-03-03 Thread Valdis . Kletnieks
On Tue, 03 Mar 2015 17:08:37 -0800, Andy Lutomirski said: > > Are they poking cr4 directly with mov? Let's see: > > /* Enable the VMX bit in CR4 if necessary. */ > RTCCUINTREG uCr4 = ASMGetCR4(); > if (!(uCr4 & X86_CR4_VMXE)) > ASMSetCR4(uCr4 | X86_CR4_VMXE); > > ASMSetCR4 is a

linux-next - crashes in rhashtable_shrink

2015-01-29 Thread Valdis Kletnieks
For the past few kernels, I've seen occasional crashes in rhashtable_shrink. Looks like the last thing to touch that code was the patch series: Subject [PATCH 0/9 net-next v2] rhashtable: Per bucket locks & deferred table resizing DateFri, 2 Jan 2015 23:00:13 +0100 Most common appears to be

linux-next - process hangs in do_exit().

2015-01-29 Thread Valdis Kletnieks
Saw my laptop grind to a halt this morning where processes would hang while trying to exit. Looks like Al was last person to touch kernel/acct.c back around Jan 9: commit 9e251d02041432487d89cb340e72490c4bbc198a Author: Al Viro Date: Fri Jan 9 20:40:02 2015 -0500 kill pin_put() touched c

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Valdis . Kletnieks
On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said: > Fix a possible null pointer dereference, there is > otherwise a risk of a possible null pointer dereference. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drive

Re: [PATCH v3] doc: brief user documentation for completion

2015-01-29 Thread Valdis . Kletnieks
On Thu, 29 Jan 2015 16:55:45 +0100, Nicholas Mc Guire said: > Signed-off-by: Nicholas Mc Guire > --- > > v3: cleanups and merged review notes from Jonathan Corbet > > patch is against 3.19.0-rc5 -next-20150119 > > Documentation/scheduler/completion.txt | 243 >

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Valdis . Kletnieks
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: > > > - if (ir == NULL) { > > > - dev_err(ir->l.dev, "close: no private_data attached to the file !\n"); > > > > Yes, the dev_err() call is an obvious thinko. > > > > However, I'm not sure whether removing it entirely is right either.

linux-next 20141216 BUG: sleeping function called from invalid context at mm/slab.c:2849

2014-12-16 Thread Valdis Kletnieks
Not sure who's to blame here, but I'm tending towards selinux based on who was holding the locks... Spotted these two while booting single-user on 20141216. 20141208 doesn't throw these, so it's something in the last week or so.. Tossed it twice - once for /sbin/sulogin, and then a second time f

Re: [PATCH] drivers:md: Remove no longer needed fixme comment in raid5.c

2014-12-17 Thread Valdis . Kletnieks
On Thu, 18 Dec 2014 10:19:06 +1100, NeilBrown said: > On Wed, 17 Dec 2014 10:49:33 -0500 Nicholas Krause > wrote: > > > Removes the no longer needed fix me comment related to not needing the > > agrument faster for the function, > > sync_request. Due to getting warnings when building without the

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Valdis . Kletnieks
On Wed, 17 Dec 2014 18:20:21 +, Steven Honeyman said: > On 17 December 2014 at 17:54, Pali Rohár wrote: > >> > Dell Latitude E6540 > >> Can somebody else with dell laptops test this patch series? > > > > Steven Honeyman, can you test this autodetection patch on your > > Latitude E6540? I'm

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Valdis . Kletnieks
s into the current set of patches, and feel free to put this in there: Tested-By: Valdis Kletnieks pgpKR2rqksDtf.pgp Description: PGP signature

Re: [PATCH v4 1/2] cfg80211: Add API to change the indoor regulatory setting

2015-02-19 Thread Valdis . Kletnieks
On Fri, 20 Feb 2015 01:53:44 +0100, "Luis R. Rodriguez" said: > Wider community: > > anyone aware of any *need* in the kernel to know whether one is indoor or > not on a device running Linux other than wifi? Clearly it should be something > that might be of interest to at least other RF devices, so

linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-20 Thread Valdis Kletnieks
linux-next 20160420 is whining at an incredible rate - in 20 minutes of uptime, I piled up some 41,000 hits from all over the place (cleaned up to skip the CPU and PID so the list isn't quite so long): % grep include/net/sock.h /var/log/messages | cut -f5- -d: | sed -e 's/PID: [0-9]* /PID: (elid

IPv6 patch mysteriously breaks IPv4 VPN

2016-04-20 Thread Valdis Kletnieks
I'll say up front - no, I do *not* have a clue why this commit causes this problem - it makes exactly zero fsking sense. Scenario: $WORK is blessed with a Juniper VPN system. I've been seeing for a while now (since Dec-ish) an issue where at startup, the tun0 device will get wedged. ifconfig re

Re: linux-next crash during very early boot

2016-04-20 Thread Valdis . Kletnieks
On Fri, 15 Apr 2016 10:10:33 -0400, valdis.kletni...@vt.edu said: > On Thu, 14 Apr 2016 10:35:47 +0900, Joonsoo Kim said: > > On Wed, Apr 13, 2016 at 08:29:46PM -0400, Valdis Kletnieks wrote: > > > I'm seeing my laptop crash/wedge up/something during very early > >

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-21 Thread Valdis . Kletnieks
On Thu, 21 Apr 2016 09:42:12 +0200, Hannes Frederic Sowa said: > Hi, > > On Thu, Apr 21, 2016, at 02:30, Valdis Kletnieks wrote: > > linux-next 20160420 is whining at an incredible rate - in 20 minutes of > > uptime, I piled up some 41,000 hits from all over the place (clean

Re: [PATCH] mvsas:Fix possible NULL pointer deference in mvs_dev_found_notify

2016-03-09 Thread Valdis . Kletnieks
On Wed, 09 Mar 2016 22:33:47 +0200, Dāvis Mosāns said: > About whether mvs_find_dev_mvi can return NULL it looks like it's possible, > but I'm not sure if it practically happens. I guess it did hence patch. Or the "bug" was found by incorrect code inspection. Nick has a history of submitting p

next-20160314 - KASAN breaks 'make C=2' build...

2016-03-15 Thread Valdis Kletnieks
This config breaks sparse: grep KASAN .config CONFIG_KASAN_SHADOW_OFFSET=0xdc00 CONFIG_HAVE_ARCH_KASAN=y CONFIG_KASAN=y # CONFIG_KASAN_OUTLINE is not set CONFIG_KASAN_INLINE=y CONFIG_TEST_KASAN=m LANG=C make C=2 CHK include/config/kernel.release CHK include/generated/uapi

Re: next-20160314 - KASAN breaks 'make C=2' build...

2016-03-15 Thread Valdis . Kletnieks
On Tue, 15 Mar 2016 12:22:18 +0300, Andrey Ryabinin said: > 2016-03-15 12:11 GMT+03:00 Valdis Kletnieks : > > This config breaks sparse: > > 4AM is a bad time to figure out who's to blame here > > Update your sparse please. Make sure it has d917662d54ba ("l

Re: next-20160314 - crash in i2c_dev_init/bus_register_notifier at boot

2016-03-18 Thread Valdis . Kletnieks
On Thu, 17 Mar 2016 21:52:25 +0100, Wolfram Sang said: > Can you try a newer -next or apply this patch on top? > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/patch/drivers/i2c?id=3Db980a26d02d1f54be3134222304fcd27ea33 > > I think this should solve it. Confirming that iss

next-20160314 - crash in i2c_dev_init/bus_register_notifier at boot

2016-03-19 Thread Valdis Kletnieks
Seeing this consistent crash on next-20160314. Sorry for shortened traceback, hand-transcribed as the crash doesn't get logged to /sys/fs/pstore as expected. next-20160307 works just fine. BUG: unable to handle kernel NULL pointer dereference at 0260 IP: blocking_notifier_chain_register+0

KASAN overhead?

2016-03-19 Thread Valdis Kletnieks
So I built linux-next next-20160417 with KASAN enabled: CONFIG_KASAN_SHADOW_OFFSET=0xdc00 CONFIG_HAVE_ARCH_KASAN=y CONFIG_KASAN=y # CONFIG_KASAN_OUTLINE is not set CONFIG_KASAN_INLINE=y CONFIG_TEST_KASAN=m and saw an *amazing* slowdown. For compar

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-24 Thread Valdis . Kletnieks
On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said: > >>> + return !debug_locks || > >>> +lockdep_is_held(&sk->sk_lock) || > Issue here is that once lockdep detected a problem (not necessarily in > net/ tree btw), your helper always 'detect' a problem, since lockdep > automatically dis

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-24 Thread Valdis . Kletnieks
On Sun, 24 Apr 2016 14:00:17 -0700, Eric Dumazet said: > On Sun, 2016-04-24 at 15:56 -0400, valdis.kletni...@vt.edu wrote: > > On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said: > > > > > >>> + return !debug_locks || > > > >>> +lockdep_is_held(&sk->sk_lock) || > > > > > Issue he

Confusing olddefault prompt for Z3FOLD

2016-04-26 Thread Valdis Kletnieks
Saw this duplicate prompt text in today's linux-next in a 'make oldconfig': Low density storage for compressed pages (ZBUD) [Y/n/m/?] y Low density storage for compressed pages (Z3FOLD) [N/m/y/?] (NEW) ? I had to read the help texts for both before I clued in that one used two compressed pages, a

Re: f.s. corruption ext3 kernel 4.4.8

2016-04-26 Thread Valdis . Kletnieks
On Mon, 25 Apr 2016 09:09:28 +0800, Barry Kauler said: > Of course, when it mounted "ro" the first time, that should have set > off alarm bells and I should probably have backed up immediately. Actually, you should be doing that on a regular basis (every weekend or whatever), so you'll have a bac

next-20151101 - depmod issues with Lustre modules

2015-11-02 Thread Valdis Kletnieks
next-20151101 compiles fine, but depmod has a cow: depmod: ERROR: Found 2 modules in dependency cycles! depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet Sorry, not sure which commit(s) introduced the issue. next-20151022 was OK. pgpNdrNfmHVUA.pgp Description: PGP signature

slab.h debugging tags....

2015-10-08 Thread Valdis Kletnieks
Author: Rasmus Villemoes Date: Wed Oct 7 15:09:20 2015 +1100 slab.h: sprinkle __assume_aligned attributes causes *tons* of whinges if you do 'make C=2' with sparse 0.5.0: CHECK drivers/media/usb/pwc/pwc-if.c include/linux/slab.h:307:43: error: attribute '__assume_aligned__': unknown

Re: slab.h debugging tags....

2015-10-10 Thread Valdis . Kletnieks
ror: attribute '__assume_aligned__': unknown attribute but there's only like a few that disable sparse. Everything else behaves now. Feel free to stick this on it: Tested-By: Valdis Kletnieks pgpvreXX02hVD.pgp Description: PGP signature

[PATCH 0/8] staging: exfat: Code cleanups

2019-10-22 Thread Valdis Kletnieks
Two main goals here - remove the code to mount FAT and VFAT filesystes, and make a lot of functions static to reduce namespace pollution. Valdis Kletnieks (8): staging: exfat: Clean up namespace pollution, part 1 staging: exfat: Remove FAT/VFAT mount support, part 1 staging: exfat: Remove

[PATCH 2/8] staging: exfat: Remove FAT/VFAT mount support, part 1

2019-10-22 Thread Valdis Kletnieks
Remove the top-level mount functionality, to make this driver handle only exfat file systems. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/Kconfig | 9 -- drivers/staging/exfat/exfat.h | 2 - drivers/staging/exfat/exfat_core.c | 142

[PATCH 5/8] staging: exfat: Clean up static definitions in exfat_cache.c

2019-10-22 Thread Valdis Kletnieks
Move static function bodies before first use, remove the definition in exfat.h Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 4 -- drivers/staging/exfat/exfat_cache.c | 94 +++-- 2 files changed, 48 insertions(+), 50 deletions(-) diff --git

[PATCH 3/8] staging: exfat: Remove FAT/VFAT mount support, part 2

2019-10-22 Thread Valdis Kletnieks
Remove no longer referenced FAT/VFAT routines. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 49 +- drivers/staging/exfat/exfat_core.c | 755 - 2 files changed, 2 insertions(+), 802 deletions(-) diff --git a/drivers/staging/exfat/exfat.h

[PATCH 6/8] staging: exfat: More static cleanups for exfat_core.c

2019-10-22 Thread Valdis Kletnieks
Move static function bodies before first use, remove the definition in exfat.h Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 6 - drivers/staging/exfat/exfat_core.c | 500 ++--- 2 files changed, 250 insertions(+), 256 deletions(-) diff --git

[PATCH 7/8] staging: exfat: Finished code movement for static cleanups in exfat_core.c

2019-10-22 Thread Valdis Kletnieks
Move static function bodies before first use, remove the definition in exfat.h Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 10 - drivers/staging/exfat/exfat_core.c | 661 ++--- 2 files changed, 330 insertions(+), 341 deletions(-) diff --git

[PATCH 4/8] staging: exfat: Cleanup static entries in exfat.h

2019-10-22 Thread Valdis Kletnieks
Many of the static definitions that remain are not needed, as the function definition is already before the first use. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 53 --- 1 file changed, 53 deletions(-) diff --git a/drivers/staging/exfat

[PATCH 1/8] staging: exfat: Clean up namespace pollution, part 1

2019-10-22 Thread Valdis Kletnieks
Make as much as possible static. We're over-exuberant here for the benefit of a following patch, as the compiler will flag now-unused static code Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 156 ++--- drivers/staging/exfat/exfat_core.c

[PATCH 8/8] staging: exfat: Update TODO

2019-10-22 Thread Valdis Kletnieks
Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/TODO | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/staging/exfat/TODO b/drivers/staging/exfat/TODO index b60e50b9cf4e..110c30834bd2 100644 --- a/drivers/staging/exfat/TODO +++ b/drivers

[PATCH 1/1] staging: exfat: Update MAINTAINERS file

2019-10-22 Thread Valdis Kletnieks
Add a L: tag so get_maintainers.pl output includes the linux-fsdevel list Signed-off-by: Valdis Kletnieks --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3d09efe69508..188435ae 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6186,6 +6186,7

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread valdis . kletnieks
On Mon, 28 Jan 2019 09:18:45 -0800, Song Liu said: > On Sun, Jan 27, 2019 at 8:43 PM wrote: > > The attached patch silences the warnings, because we *know* we're > > overwriting > > the default initializer. That leaves bpf/core.c with only 6 other warnings, > > which become more visible in compa

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread valdis . kletnieks
On Tue, 29 Jan 2019 00:22:26 +0100, Daniel Borkmann said: > I think moving in separate file would be overkill, imho. However, lets get > the kdoc and prototype warning fixed. I have a bunch of spare time at the moment, so the kdoc and prototype warnings are on my to-do list.

[PATCH] kernel/bpf/core.c - fix bitrotted kerneldoc.

2019-01-28 Thread valdis . kletnieks
Over the years, the function signature has changed, the kerneldoc block hasn't. Signed-off-by: Valdis Kletnieks diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index 2a81b8af3748..2728b6247091 100644 --- a/kernel/bpf/core.c +++ b/kernel/bpf/core.c @@ -1216,8 +1216,9 @@

[PATCH] include/linux/bpf.h - fix missing prototype warnings...

2019-01-28 Thread valdis . kletnieks
__weak bpf_jit_free_exec(void *addr) | ^ All three are weak functions that archs can override, although none do so currently. Provide prototypes for when a new arch provides its own. Signed-off-by: Valdis Kletnieks diff --git a/include/linux/bpf.h b/include

[PATCH] kernel/bpf/cgroup.c - clean up kerneldoc warnings

2019-01-28 Thread valdis . kletnieks
cribed in '__cgroup_bpf_detach' Add a kerneldoc line for 'flags'. Fixing the warning for 'unused_flags' is best approached by removing the unused parameter on the function call. Signed-off-by: Valdis Kletnieks diff --git a/include/linux/bpf-cgroup.h b/include/linu

[PATCH] init/calibrate.c - provide proper prototype.

2019-01-29 Thread valdis . kletnieks
. Let's provide one to prevent surprises. Signed-off-by: Valdis Kletnieks diff --git a/include/linux/delay.h b/include/linux/delay.h index b78bab4395d8..8e6828094c1e 100644 --- a/include/linux/delay.h +++ b/include/linux/delay.h @@ -55,6 +55,7 @@ static inline void ndelay(unsigned long x)

Re: [regression -next0117] What is kcompactd and why is he eating 100% of my cpu?

2019-01-29 Thread valdis . kletnieks
On Mon, 28 Jan 2019 10:16:27 +0100, Jan Kara said: > So my buffer_migrate_page_norefs() is certainly buggy in its current > incarnation (as a result block device page cache is not migratable at all). > I've sent Andrew a patch over week ago but so far it got ignored. The patch > is attached, can y

Re: [regression -next0117] What is kcompactd and why is he eating 100% of my cpu?

2019-01-29 Thread valdis . kletnieks
On Tue, 29 Jan 2019 20:06:39 -0500, valdis.kletni...@vt.edu said: > On Mon, 28 Jan 2019 10:16:27 +0100, Jan Kara said: > > > So my buffer_migrate_page_norefs() is certainly buggy in its current > > incarnation (as a result block device page cache is not migratable at all). > > I've sent Andrew a pa

Re: [bpf] 568f196756: BUG:assuming_atomic_context_at_kernel/seccomp.c

2019-02-22 Thread valdis . kletnieks
On Thu, 21 Feb 2019 14:39:27 +0100, Daniel Borkmann said: > Fyi, false positive and already fixed in bpf-next. > > (https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=435b3ff5b08a99a15647be32735abf8db66cea9a) Is there a reason this commit appeared in next-20190221 but did

Re: [bpf] 568f196756: BUG:assuming_atomic_context_at_kernel/seccomp.c

2019-02-22 Thread valdis . kletnieks
On Sat, 23 Feb 2019 00:15:38 +0100, Jann Horn said: > On Fri, Feb 22, 2019 at 11:42 PM wrote: > > Is there a reason this commit appeared in next-20190221 but did not seem to > > be > > in next-20190222 (confirmed via 'git tag --contains')?y ast@, he wanted to > > fix it in a different way: > htt

Re: linux-next 20180327 - "SELinux: (dev dm-3, type ext4) getxattr errno 34"

2018-03-29 Thread valdis . kletnieks
On Thu, 29 Mar 2018 21:32:21 -0400, "Theodore Y. Ts'o" said: > Yes, the breakage is my fault; my apologies. The new version of the > patch is already posted in bugzilla (and on linux-ext4). I'll be > pushing out a refreshed ext4.git branch shortly. Confirming that reverting de57a63ea4389e39b1cd

next-20180416 - warnings from 'make tools/perf'

2018-04-22 Thread valdis . kletnieks
Seeing these warnings. 'diff' tells me that the files are in fact significantly different. Warning: Kernel ABI header at 'tools/include/uapi/linux/kvm.h' differs from latest version at 'include/uapi/linux/kvm.h' Warning: Kernel ABI header at 'tools/include/uapi/linux/prctl.h' differs from lates

Re: next-20180416 - warnings from 'make tools/perf'

2018-04-23 Thread valdis . kletnieks
On Mon, 23 Apr 2018 08:52:04 +0200, Ingo Molnar said: > The warnings are harmless, and they should be fixed in v4.17-rc2. Having been burnt all too many times over the past 4 decades by mismatched headers, I figured I should mention it... I see that in next-20180423 it's down to 2 warnings (prct

Re: Softlockup and Hardlockup sample test module

2018-04-15 Thread valdis . kletnieks
On Sun, 15 Apr 2018 13:17:27 +0530, Ivid Suvarna said: > I had tried with the module where I put a busy loop inside spinlock > but was not able to cause any lockups. Maybe this is because of SMP > which schedule the job to other CPU. "How do I make a task to run on > single CPU only?" So you get

linux-next 20170117 - lockdep whines and BUGs in ata_scsi_rbuf_fill()

2017-01-18 Thread valdis . kletnieks
linux-next 20170110 didn't exhibit this. Am seeing at boot a lockdep whine, followed by 3 BUGs. ata_scsi_rbuf_fill() is in the traceback for all of them.'git log' hints that it's one of 6 commits against drivers/ata/libata-scsi.c by Christoph, but none of them spring out as being the guilty pa

[PATCH] Fix annoyingly awkward typo in drm_edid_load.c

2016-05-29 Thread Valdis Kletnieks
Fix egregious typo in comment. Signed-off-by: Valdis Kletnieks --- a/drivers/gpu/drm/drm_edid_load.c 2016-04-20 17:54:27.208059935 -0400 +++ b/drivers/gpu/drm/drm_edid_load.c 2016-05-30 02:15:43.747105384 -0400 @@ -271,7 +271,7 @@ * by commas, search through the list looking for

Re: Kernel 4.6 - failing compilation Vmware modules

2016-05-30 Thread Valdis . Kletnieks
On Mon, 30 May 2016 17:14:24 +0200, Roman Fiala said: > this is the first time, when I would like to report kernel problem. It's not a kernel problem, it's an out-of-tree module problem. You really should take it to the VMWare people. Having said that, note that the dkms messages aren't very he

Re: [PATCH 13/15] mtd: nand: samsung: retrieve ECC requirements from extended ID

2016-05-30 Thread Valdis . Kletnieks
On Mon, 30 May 2016 09:44:46 +0200, Boris Brezillon said: > Hi Valdis, > Actually, that was my first reaction [1], but the more I think about it > the more I realize it's a non-issue. > AFAICT, there's no full-id entries for Samsung NANDs in the nand_ids > table, so this either means there's no re

Re: mmotm 2016-10-27-18-27 uploaded

2016-10-31 Thread Valdis . Kletnieks
On Sun, 30 Oct 2016 14:15:30 -0400, Paul Gortmaker said: > On Thu, Oct 27, 2016 at 9:28 PM, wrote: > > The mm-of-the-moment snapshot 2016-10-27-18-27 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > Just a heads up: > > Somehow one of the akpm commits as it appears in linux-

Patch to include/linux/kernel.h breaks 3rd party modules.

2016-12-21 Thread Valdis Kletnieks
Yes, I know that usually out-of-tree modules are on their own. However, this one may require a rethink.. (Sorry for not catching this sooner, I hadn't tried to deal with the affected module since this patch hit linux-next in next-20161128) commit 7fd8329ba502ef76dd91db561c7aed696b2c7720 Author: P

[PATCH] Fix usage of true and false as field names in struct taint_flag

2016-12-22 Thread Valdis Kletnieks
the field names to not shadow something likely to be used by third-party modules. Signed-off-by: Valdis Kletnieks --- diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 56aec84237ad..420d4b87feb0 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -514,8 +514,8

Re: [RFC PATCH] ext4: increase the protection of drop nlink and ext4 inode destroy

2016-12-31 Thread Valdis . Kletnieks
On Mon, 26 Dec 2016 20:34:17 +0800, yi zhang said: > Because of the disk and hardware issue, the ext4 filesystem have > many errors, the inode->i_nlink of ext4 becomes zero abnormally > but the dentry is still positive, it will cause memory corruption > after the following process: > > 1) Due to t

Re: Fix usage of true and false as field names in struct taint_flag

2017-01-03 Thread Valdis . Kletnieks
On Tue, 03 Jan 2017 11:55:36 -0800, Jessica Yu said: > Hm, you and Larry Finger sent the exact same fix at around the same > time, although I think people are leaning towards the other patch > (it's just a naming preference), see here: > >https://lkml.kernel.org/r/20161224195532.15128-1-larry.

Re: [PATCH] Fix usage of true and false as field names in struct taint_flag

2016-12-26 Thread Valdis . Kletnieks
On Fri, 23 Dec 2016 12:59:35 +0100, Petr Mladek said: > On Thu 2016-12-22 13:56:38, Valdis Kletnieks wrote: > > commit 7fd8329ba502ef76dd91db561c7aed696b2c7720 > > Author: Petr Mladek > > Date: Wed Sep 21 13:47:22 2016 +0200 > > > > taint/module: Clean

[PATCH] Fix usage of true and false as field names in struct taint_flag

2016-12-26 Thread Valdis Kletnieks
/* also show as a per-module taint flag */ +}; and hilarity ensues when an out-of-tree module has this: # ifndef true # define true (1) # endif # ifndef false # define false (0) # endif Change the field names to not shadow something likely to be used by third-party modules. Signed-off-

Re: [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2016-12-27 Thread Valdis . Kletnieks
On Wed, 28 Dec 2016 00:15:30 +0200, Andy Shevchenko said: > On Tue, Dec 27, 2016 at 3:51 PM, Pali Rohár wrote: > > I have no idea how to do it (properly) outside of i2c-i801.c file. > > I doubt we need a single line of code for this. See [1] and perhaps > create an EFI variable with necessary upg

Re: [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

2016-12-28 Thread Valdis . Kletnieks
On Wed, 28 Dec 2016 15:03:02 +0100, Wolfram Sang said: > > I have absolutely no idea how to you want to achieve calling that > > i2c_new_device() registration > > without kernel patches. > > Documentation/i2c/instantiating-devices lists all supported methods. > Method 4 is userspace instantiation.

Re: [PATCH RFC 0/4] 5-level EPT

2016-12-29 Thread Valdis . Kletnieks
On Thu, 29 Dec 2016 17:25:59 +0800, Liang Li said: > x86-64 is currently limited physical address width to 46 bits, which > can support 64 TiB of memory. Some vendors require to support more for > some use case. Intel plans to extend the physical address width to > 52 bits in some of the future pro

linux-next 20161129 - BUG: sleeping function called from invalid context at mm/page_alloc.c:3775

2016-11-29 Thread Valdis Kletnieks
Seeing this same BUG all over the place at boot - some 30 times just getting to a single-user prompt and saving a dmesg. Everything from netlink to execve to ext4 file I/O to process exit time. [3.746004] BUG: sleeping function called from invalid context at mm/page_alloc.c:3775 [3.74609

linux-next 20161129 - lockdep: kernel/sched/core.c:7747 Illegal context switch in RCU-bh read-side critical section!

2016-11-29 Thread Valdis Kletnieks
May or may not be related to the BUG I just reported - the first hit on that one was right after this in the log [2.740391] === [2.740433] suspicious RCU usage. ] [2.740463] 4.9.0-rc7-next-20161129-dirty #361 Not tainted [2.740464] --

Re: [PATCH] infiniband: remove WARN that is not kernel bug

2016-11-18 Thread Valdis . Kletnieks
On Fri, 18 Nov 2016 12:24:37 +0100, Dmitry Vyukov said: > WARNINGs mean kernel bugs. > The one in ucma_write() points to user programming error > or a malicious attempt. This is not a kernel bug, remove it. > - if (WARN_ON_ONCE(!ib_safe_file_access(filp))) > + if (!ib_safe_file_access(filp

next-20170207 initify_plugin kills gcc7.

2017-02-08 Thread valdis . kletnieks
Seen in next-20170207: [/usr/src/linux-next] gcc --version gcc (GCC) 7.0.1 20170204 (Red Hat 7.0.1-0.6) Copyright (C) 2017 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PU

linux-next 20170130 - BUG mmc driver 'sleeping function called from invalid context'

2017-02-03 Thread valdis . kletnieks
Booted next-20170130 with a flash memory card forgotten in the reader slot, and it produced a truly impressive amount of splattage - managing to trigger both a BUG for sleeping in an invalid context *and* a lockdep whinge. I can't tell if it's 2 mmc bugs, or if lockdep got confused due to the BUG

Re: [PATCH-tip v5 17/21] TP-futex: Group readers together in wait queue

2017-02-03 Thread valdis . kletnieks
On Fri, 03 Feb 2017 13:03:50 -0500, Waiman Long said: > On a 2-socket 36-core E5-2699 v3 system (HT off) running on a 4.10 > WW futex TP futex Glibc > - > Total locking ops35,707,234

Re: [PATCH-tip v5 17/21] TP-futex: Group readers together in wait queue

2017-02-03 Thread valdis . kletnieks
On Fri, 03 Feb 2017 13:42:46 -0500, Waiman Long said: > This patch set does guarantee some minimum performance level, but it > can't guarantee fairness for all the lock waiters. OK, sounds like it's a situation that's statistically unlikely, but it has protections against starvation so the system

Re: [PATCH] fs/proc: Add compiler check for -Wno-override-init to support gcc < 4.2

2016-08-03 Thread Valdis . Kletnieks
On Wed, 03 Aug 2016 17:33:32 +0200, Geert Uytterhoeven said: > With gcc < 4.2 (e.g. 4.1.2): > > CC fs/proc/task_mmu.o > cc1: error: unrecognized command line option "-Wno-override-init" > > To fix this, only enable the compiler option when it is actually > supported by the compiler.

linux-next: UBSAN whine and BUG in net/ipv4/fib_trie.c

2016-06-06 Thread Valdis Kletnieks
Seeing this in next-20160606 (next-20160530 is fine), does it ring any bells before I spend a long evening doing a bisect? The Google doesn't seem to have seen this traceback in the past week [ 226.938222] [ 2

Re: performance delta after VFS i_mutex=>i_rwsem conversion

2016-06-06 Thread Valdis . Kletnieks
On Mon, 06 Jun 2016 14:20:32 -0700, Linus Torvalds said: > I guess some "concurrent readdir with unlink" load would show that > behavior, but is it _realistic_? No idea. Let's not worry about it too > much until somebody shows a reason to worry. I've seen Makefiles where 'make clean' does a 'find

Re: [kernel-hardening] Re: [PATCH 9/9] mm: SLUB hardened usercopy support

2016-07-08 Thread Valdis . Kletnieks
On Sat, 09 Jul 2016 15:58:20 +1000, Michael Ellerman said: > I then get two hits, which may or may not be valid: > > [2.309556] usercopy: kernel memory overwrite attempt detected to > d3510028 (kernfs_node_cache) (64 bytes) > [2.309995] CPU: 7 PID: 2241 Comm: wait-for-root Not tai

linux-next - lockdep whine in MMC/SDHC code

2016-06-27 Thread Valdis Kletnieks
This may be indicative of an actual problem, as I've had at least one time that subsequently mounting and then trying to access files on the partition caused kernel BUGs. Seen in next-0614 and next-0627. Google reports similar issues, but from the 2013/2014 timeframe [2.610725] NET: Regi

Re: [PATCH 32/32] ver_linux: 'printversion()' function definition

2016-06-28 Thread Valdis . Kletnieks
On Tue, 28 Jun 2016 13:19:06 +0300, Alexander Kapshuk said: > Definition of the 'printversion()' function. The function tests whether > the variable that contains the version number is empty, and prints > the name of the utility and its version number as a formatted string, > if the version number

Re: [PATCH 32/32] ver_linux: 'printversion()' function definition

2016-06-28 Thread Valdis . Kletnieks
On Tue, 28 Jun 2016 17:40:36 +0300, Alexander Kapshuk said: > Seeing this is a complete rewrite of the script from the shell > language into awk, one would not be able to apply the patches > submitted incrementally to be able to test each change being > introduced separately. In this respect, defi

Re: [kernel-hardening] Re: [PATCH v1 0/2] Introduce the initify gcc plugin

2016-06-28 Thread Valdis . Kletnieks
On Tue, 28 Jun 2016 14:49:15 -0700, Joe Perches said: > Another potentially useful plugin, especially for embedded systems, > would be to compress any string literal marked with > >  __attribute__((format(printf, string-index,))) > > and decompress the compressed format on the stack in lib/v

Re: DMAR error messages after 'shutdown -r'.

2016-03-07 Thread Valdis . Kletnieks
(Sorry for the delay, $DAYJOB took a lot of cycles. Adding AHCI maintainers to cc:) On Tue, 16 Feb 2016 17:47:45 +0100, Joerg Roedel said: > On Tue, Feb 09, 2016 at 02:59:00PM -0500, Valdis Kletnieks wrote: > > [0.027629] Freeing SMP alternatives memory: 28K (fff

Re: [PATCH 5/9] x86: Add documentation for rd/wr fs/gs base

2016-03-23 Thread Valdis . Kletnieks
On Mon, 21 Mar 2016 09:16:05 -0700, Andi Kleen said: > From: Andi Kleen > > v2: Minor updates to documentation requested in review. > +In addition the kernel needs to explicitly enable these instructions, as it > +may otherwise not correctly context switch the state. Newer Linux > +kernels enable

Re: KASAN overhead?

2016-03-19 Thread Valdis . Kletnieks
On Sat, 19 Mar 2016 13:13:59 +0100, Alexander Potapenko said: > Which GCC version were you using? Are you sure it didn't accidentally > enable the outline instrumentation (e.g. if the compiler is too old)? gcc --version gcc (GCC) 6.0.0 20160311 (Red Hat 6.0.0-0.16) * Fri Mar 11 2016 Jakub Jelin

Re: [PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning

2016-03-20 Thread Valdis . Kletnieks
On Sat, 19 Mar 2016 19:22:09 -0700, Joe Perches said: > On Sun, 2016-03-20 at 07:48 +0530, Parth Sane wrote: > > Hi, > > Thanks for pointing out that the changes have been done. Nevertheless > > this was a good learning exercise. How do I check which changes have > > already been done? > > Use this

Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Valdis . Kletnieks
On Fri, 19 Feb 2016 17:45:48 +0100, Aurelien Jarno said: > On 2016-02-19 12:11, Aurelien Jarno wrote: > Actually the same patch with a bit more context shows the issue: > > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > > index e7a4fde..b372a75 100644 > > --- a/arch/x86/kvm/emul

Re: Silence compiler warning in arch/x86/kvm/emulate.c

2016-02-19 Thread Valdis . Kletnieks
On Fri, 19 Feb 2016 18:56:05 +0100, Paolo Bonzini said: > On 19/02/2016 18:54, valdis.kletni...@vt.edu wrote: > > But under what conditions is 'la' a 64-bit quantity that has any > > bits set in the high 32 bits (meaning it's a pointer to something > > over the 4G line) - but it's still valid to sm

Re: [PATCH RESEND] mmc:host:Fix error handling for calls to the function shdci_runtime_pm_get in the file sdhci.c

2016-02-11 Thread Valdis . Kletnieks
On Thu, 11 Feb 2016 10:06:04 +0200, Adrian Hunter said: > On 10/02/16 16:34, Nicholas Krause wrote: > > This fixes error handling for various function calls to > pm_runtime_resume() returns 1 if the device's runtime PM status was already > 'active', and -EACCES means that 'power.disable_depth' is

Re: [RFC PATCH 07/16] efi: Public the function of transferring EFI status to kernel error

2015-08-01 Thread Valdis . Kletnieks
On Thu, 30 Jul 2015 17:23:22 +0100, Matt Fleming said: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > Moved the function of transferring EFI status to kernel error for > > later used by EFI stub. > > > > Signed-off-by: Lee, Chun-Yi > > --- > > drivers/firmware/efi/vars.c | 33 -

Re: Feature request, "create on mount" to create mount point directory on mount, implied remove on unmount

2015-07-05 Thread Valdis . Kletnieks
On Fri, 03 Jul 2015 13:01:59 +0100, jon said: > Hi, could I make a hugely nieve user request :-) > > Would it be possible to add a new mount option to everything? > > New mount option 'com' = "create on mount" (implied remove on unmount). > > > Example fstab entry > /mounts/amountpoint LABEL=nota

Re: [PATCH 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-05 Thread Valdis . Kletnieks
On Fri, 03 Jul 2015 18:50:07 +0530, Pintu Kumar said: > This patch provides 2 things: > 2. Enable shrink_all_memory API in kernel with new CONFIG_SHRINK_MEMORY. > Currently, shrink_all_memory function is used only during hibernation. > With the new config we can make use of this API for non-hibern

Re: [PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern variable

2015-07-05 Thread Valdis . Kletnieks
On Sun, 05 Jul 2015 06:07:54 +0800, Chen Gang said: > For upstream cris toolchain (gcc is 6.0 typo? pgpqUqjfv2xqt.pgp Description: PGP signature

Re: Feature request, "create on mount" to create mount point directory on mount, implied remove on unmount

2015-07-05 Thread Valdis . Kletnieks
On Mon, 06 Jul 2015 03:34:59 +0100, jon said: > I remember "virtual memory" and even "virtual addressing" but I think > the term "virtual machine" is modern, maybe someone else knows, google > did not help me much trying to prove it one way or the other. Hardly. IBM was working with virtual mach

Re: [PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern variable

2015-07-06 Thread Valdis . Kletnieks
On Mon, 06 Jul 2015 15:49:20 +0800, Chen Gang said: > On 07/06/2015 02:25 AM, valdis.kletni...@vt.edu wrote: > > On Sun, 05 Jul 2015 06:07:54 +0800, Chen Gang said: > >> For upstream cris toolchain (gcc is 6.0 > > > > typo? > > > > Do you mean "toolchain" -> "tool chain"? No, I was wondering where

Re: [PATCH v2] add stealth mode

2015-07-06 Thread Valdis . Kletnieks
On Thu, 02 Jul 2015 10:56:01 +0200, Matteo Croce said: > Add option to disable any reply not related to a listening socket, > like RST/ACK for TCP and ICMP Port-Unreachable for UDP. > Also disables ICMP replies to echo request and timestamp. > The stealth mode can be enabled selectively for a singl

Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function

2015-07-06 Thread Valdis . Kletnieks
On Mon, 06 Jul 2015 18:50:12 +0530, Ravi Teja Darbha said: > Why would you use a macro to avoid code duplication? The macro does end up putting code in each place it's used. However, the actual code is in one place rather than open-coded in multiple places that can diverge over time (somebody patc

next-20150714 - busted IPv6 source address selection...

2015-07-14 Thread Valdis Kletnieks
next-20150714 w/ one ethernet commit reverted. -0706 w/ same revert works. "ip addr show" for the wireless says: 5: wlp3s0b1: mtu 1500 qdisc fq_codel state UP group default qlen 1000 link/ether bc:85:56:1f:4f:6d brd ff:ff:ff:ff:ff:ff inet 172.30.42.75/27 brd 172.30.42.95 scope global dy

[PATCH] ov519.c - allow setting i2c_detect_tries

2015-07-15 Thread Valdis Kletnieks
dinfo drivers/media/usb/gspca/gspca_ov519.ko | grep parm parm: i2c_detect_tries:Number of times to try to init I2C (default 10) (int) parm: frame_rate:Frame rate (5, 10, 15, 20 or 30 fps) (int) Reported-By: Demhlyr Signed-Off-By: Valdis Kletnieks --- a/drivers/media/usb/

<    5   6   7   8   9   10   11   >