Re: NFS4 authentification / fsuid

2007-09-19 Thread Valdis . Kletnieks
On Wed, 19 Sep 2007 01:16:28 EDT, Kyle Moffett said: > I am assuming that if the laptop has sufficiently important data on > it to warrant the above steps then I am also clueful enough to: >(A) Not carry the laptop around unsecured areas, >(B) Keep a close enough eye on it and be aware

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-19 Thread Valdis . Kletnieks
On Wed, 19 Sep 2007 21:57:27 +0200, Jiri Slaby said: > On 09/19/2007 09:54 PM, Andi Kleen wrote: > >> Yeah. (But X doesn't run -- this is maybe the known issue in this release) . > > > > What do you mean with not run? > > (II) intel(0): Initializing HW Cursor > (II) intel(0): xf86BindGARTMemory:

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Valdis . Kletnieks
On Wed, 19 Sep 2007 11:38:57 PDT, Rick Jones said: > One has to set their way-back machine pretty far back to find the *BSD > bits which used 0.0.0.0 as the "all nets, all subnets" (to mis-use a > term) broadcast IPv4 address when sending. Perhaps as far back as the > time before HP-UX 7 or Su

Re: [Announce] Linux-tiny project revival

2007-09-19 Thread Valdis . Kletnieks
On Wed, 19 Sep 2007 12:41:08 PDT, Tim Bird said: > The patchkit gives a place for things to live while they are out > of mainline, and still have multiple people use and work on them. Is anybody working on testing that the patchkit "does no harm" for bigger boxes (laptops, desktops, servers)? Tha

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-20 Thread Valdis . Kletnieks
On Wed, 19 Sep 2007 22:47:41 +0200, Jiri Slaby said: > On 09/19/2007 10:32 PM, [EMAIL PROTECTED] wrote: > > That would probably have been me, saying that x86_64-mm-cpa-clflush.patch > > broke > > the NVidia graphics driver in 23-rc3-mm1. Is it breaking *other* X drivers > > as > > well? > > Ye

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-21 Thread Valdis . Kletnieks
On Thu, 20 Sep 2007 17:06:05 CDT, Matt Mackall said: > On Thu, Sep 20, 2007 at 11:42:29AM +1000, Dave Airlie wrote: > > I've attached a more complicated patch that does a 2 stage effort to > > unmapping and freeing pages. My kernel no longer hangs with this > > patch... > > > > Jiri can you confi

Re: [Announce] Linux-tiny project revival

2007-09-21 Thread Valdis . Kletnieks
On Thu, 20 Sep 2007 18:18:41 CDT, Rob Landley said: > Worse, if you feed an absolute path to O= when you build the kernel out of > tree, then it uses absolute paths for all the __FILE__ strings and that makes > kernel BIG. (Did that by accident a while back.) Too bad there's no way > to kee

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 01:44:41 +0200, Andi Kleen said: > Full bisect needed then I guess. Ok as a short cut you could perhaps > the cpa-* patches first (might need to drop some later depending > patches), then the drm and agp trees. The later depending patches: x86_64-mm-cpa-clflush.patch x86_64-

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 19:30:04 +0200, Jiri Slaby said: > On 09/21/2007 07:16 PM, [EMAIL PROTECTED] wrote: > > On Thu, 20 Sep 2007 17:06:05 CDT, Matt Mackall said: > >> 2.6.23-rc3-mm1: solid lock on X shutdown (noticed when upgrading) > >> -rc4-mm1: solid lock on X shutdown, random solid locks a

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: > I plan to use gzip compression on following drivers' firmware, > if patches will be accepted: > >textdata bss dec hex filename > 17653 109968 240 127861 1f375 drivers/net/acenic.o >6628 120448 4 127

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 20:18:06 BST, Denys Vlasenko said: > On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: > > Should this be redone to use the existing firmware loading framework to > > load the firmware instead? > > Not in every case. > > For example, bnx2 maintainer says that driver

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 19:30:04 +0200, Jiri Slaby said: > On 09/21/2007 07:16 PM, [EMAIL PROTECTED] wrote: > > Hmm.. maybe I'm chasing a different bug manifested by the same patch. For > > me, > > it's been a solid lockup at X startup since -rc3-mm1, and this patch doesn't > > change matters. > >

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-23 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 21:43:20 +0200, Jiri Slaby said: > On 09/21/2007 09:38 PM, Jiri Slaby wrote: > > It is rather the other user who adds the page to some other list while bein g at > > deferred_pages list. Could you try my debug patch > > (http://lkml.org/lkml/2007/9/19/141)? > > or the whitespac

Re: [PATCH] Uninline kcalloc()

2007-09-23 Thread Valdis . Kletnieks
On Sun, 23 Sep 2007 00:03:49 +0400, Alexey Dobriyan said: > -static inline void *kcalloc(size_t n, size_t size, gfp_t flags) > -{ > - if (n != 0 && size > ULONG_MAX / n) > - return NULL; > - return __kmalloc(n * size, flags | __GFP_ZERO); > -} > +void *kcalloc(size_t n, size_t

Re: [PATCH] Uninline kcalloc()

2007-09-24 Thread Valdis . Kletnieks
On Mon, 24 Sep 2007 08:22:31 +0200, Jan Engelhardt said: > > On Sep 24 2007 01:35, [EMAIL PROTECTED] wrote: > >On Sun, 23 Sep 2007 00:03:49 +0400, Alexey Dobriyan said: > > > >> -static inline void *kcalloc(size_t n, size_t size, gfp_t flags) > >> -{ > >> - if (n != 0 && size > ULONG_MAX / n) > >

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-24 Thread Valdis . Kletnieks
On Mon, 24 Sep 2007 08:06:45 +0200, Jiri Slaby said: > Heh :). The few last before the list corruption BUG (you have to have > LIST_DEBUG > enabled) -- but it seems you never reached that phase? Seems to be somewhat racy - had one attempt that obviously got into some grand Mongolian flustercluck

Re: [PATCH] Uninline kcalloc()

2007-09-24 Thread Valdis . Kletnieks
On Mon, 24 Sep 2007 11:44:35 +0400, Alexey Dobriyan said: > On 9/24/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > On Sun, 23 Sep 2007 00:03:49 +0400, Alexey Dobriyan said: > > > > > -static inline void *kcalloc(size_t n, size_t size, gfp_t flags) > > > -{ > > > - if (n != 0 && size > ULONG_M

Re: [PATCH] Uninline kcalloc()

2007-09-24 Thread Valdis . Kletnieks
On Mon, 24 Sep 2007 11:44:35 +0400, Alexey Dobriyan said: > Interesting. Here is output from kernel with patch applied and leak > plugged into proc_dointvec() (I checked twice): > > $ grep kcalloc /proc/slab_allocators > $ grep proc_dointvec /proc/slab_allocators > size-64

2.6.23-rc7-mm1 - 'touch' command causes Oops.

2007-09-24 Thread Valdis . Kletnieks
On Mon, 24 Sep 2007 02:17:16 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc7/2.6.23-rc7-mm1/ It lived fast, it died young, it didn't leave a pretty corpse... Something in the startup scripts did a 'touch', and ker-blam. [ 15.668000] Unable t

Re: [PATCH]: proc: export a processes resource limits via proc/

2007-08-17 Thread Valdis . Kletnieks
On Fri, 17 Aug 2007 12:45:47 PDT, Andrew Morton said: > On Fri, 17 Aug 2007 06:59:18 -0400 > Neil Horman <[EMAIL PROTECTED]> wrote: > > > Currently, there exists no method for a process to query the resource > > limits of another process. They can be inferred via some mechanisms but > > they > >

Re: The vi editor causes brain damage

2007-08-19 Thread Valdis . Kletnieks
On Sat, 18 Aug 2007 22:20:34 PDT, Marc Perkel said: > Let me give you and example of the difference between > Linux open source world brain damaged thinking and > what it's like out here in the real world. > > Go to a directory with 10k files and type: > > rm * > > What do you get? > > /bin/rm:

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-19 Thread Valdis . Kletnieks
On Sat, 18 Aug 2007 01:29:58 EDT, Kyle Moffett said: > XFCE. If you can show me a security system other than SELinux which > is sufficiently flexible to secure those 2 million lines of code > along with the other 50 million lines of code found in various pieces > of software on my Debian bo

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Valdis . Kletnieks
On Tue, 21 Aug 2007 09:16:43 PDT, "Paul E. McKenney" said: > I agree that instant gratification is hard to come by when synching > up compiler and kernel versions. Nonetheless, it should be possible > to create APIs that are are conditioned on the compiler version. We've tried that, sort of. Se

Re: NFS hang + umount -f: better behaviour requested.

2007-08-21 Thread Valdis . Kletnieks
On Tue, 21 Aug 2007 14:50:42 EDT, John Stoffel said: > Now maybe those issues are raised when you have a Linux NFS server > with Solaris clients. But in my book, reliable NFS servers are key, > and if they are reliable, 'soft,intr' works just fine. And you don't need all that ext3 journal overhe

2.6.23-rc3-mm1 - irda goes belly up

2007-08-23 Thread Valdis . Kletnieks
On Wed, 22 Aug 2007 02:06:48 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc3/2.6.23-rc3-mm1/ OK, so I don't actually *use* the irDA on my laptop for much, but I figure if I have the hardware, I should at least make sure the driver comes up. 23-r

Re: 2.6.23-rc3-mm1 - irda goes belly up

2007-08-23 Thread Valdis . Kletnieks
On Thu, 23 Aug 2007 21:37:55 +0400, Alexey Dobriyan said: > On Thu, Aug 23, 2007 at 09:33:46AM -0400, [EMAIL PROTECTED] wrote: > > On Wed, 22 Aug 2007 02:06:48 PDT, Andrew Morton said: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc3/2.6.23-rc3-mm1/ > > > > OK, so I d

Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r

2007-08-23 Thread Valdis . Kletnieks
On Thu, 23 Aug 2007 21:29:41 +0200, Segher Boessenkool said: > int f(atomic_t *x) > { > return atomic_read(x) + atomic_read(x); > } > ld r0,@r0 > slli r0,#1 > jmp lr Looks like peephole optimization at work. pgpB5VxTDd0mQ.pgp Description: PGP signature

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-25 Thread Valdis . Kletnieks
words, business as usual. Thanks. Feel free to stick this on both patches: Tested-By: Valdis Kletnieks <[EMAIL PROTECTED]> pgpTmryobqq0I.pgp Description: PGP signature

Re: [PATCH 1/2] sysctl: Properly register the irda binary sysctl numbers.

2007-08-25 Thread Valdis . Kletnieks
On Sat, 25 Aug 2007 06:57:17 MDT, Eric W. Biederman said: > It's good to have confirmation that my sysctl_check routine > didn't find something else wrong. If I understand the code, anything it whinges about is either an outright bug or it's a round of ammo already chambered. ;) As far as "somet

linux-next 20141208 - net/sched/sch_fq_codel.c:97 suspicious RCU

2014-12-09 Thread Valdis Kletnieks
Spotted this in dmesg while investigating why my wireless broke sometime between next-20141201 and next-20141208. Probably not related, as wireless has been broken on several boot attempts of -1208, but this has popped only once Looks like the fault of commit 46e5da40aec256155cfedee96dd21a75

Re: linux-next 20141208 - net/sched/sch_fq_codel.c:97 suspicious RCU

2014-12-09 Thread Valdis . Kletnieks
On Tue, 09 Dec 2014 10:07:31 -0800, Eric Dumazet said: > On Tue, Dec 9, 2014 at 9:51 AM, Valdis Kletnieks > > commit 46e5da40aec256155cfedee96dd21a75da941f2c > > Author: John Fastabend > > Date: Fri Sep 12 20:04:52 2014 -0700 > > Well, its a (harmless) typo

[PATCH] fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c

2014-12-09 Thread Valdis Kletnieks
commit 46e5da40ae (net: qdisc: use rcu prefix and silence sparse warnings) triggers a spurious warning: net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! The code should be using the _bh variant of rcu_dereference. Signed-off-by: Valdis Kletnieks --- net/sched

[PATCH] USB_EHCI_TT_NEWSCHED in *86 defconfig

2015-01-02 Thread Valdis Kletnieks
s accepted). Signed-off-by: Valdis Kletnieks --- a/arch/x86/configs/i386_defconfig.dist 2014-12-19 12:38:51.467027402 -0500 +++ b/arch/x86/configs/i386_defconfig 2015-01-02 11:03:55.817776347 -0500 @@ -248,7 +248,7 @@ CONFIG_USB=y CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_MON=y CONFIG_US

Re: mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test'

2015-01-25 Thread Valdis . Kletnieks
On Sat, 24 Jan 2015 02:16:23 -0500, Johannes Weiner said: > I would generally agree, but this code, which implements a userspace > interface, is already grotesquely inefficient and heavyhanded. It's > also superseded in the next release, so we can just keep this simple > at this point. Wait, wha

Re: Fwd: Question about kernel interfaces

2015-01-09 Thread Valdis . Kletnieks
On Fri, 09 Jan 2015 18:00:07 +0530, Siddhartha De said: > In what timeframe should we migrate to "pure" sysfs and drop using > any ioctls (if a sysfs interface exists)? Pretty much the answer is "you don't", for the wsame reason that there's still a lot of non-process stuff in /proc - there's no

Re: Question about kernel interfaces

2015-01-18 Thread Valdis . Kletnieks
On Sun, 18 Jan 2015 15:03:55 +0530, Siddhartha De said: > Let's say you need to call an ioctl from a shell script ( I know its a > very rare use case but please bear with me ... :) ) There's a *reason* it's very rare... > So the current way of doing it is probably to write a C program which > ac

linux-next - strange audio bug

2015-04-02 Thread Valdis Kletnieks
Next-20150310 works OK, next-20150324 has the bug. Dell Latitude E6530 laptop, lspci tells me: 01:00.1 Audio device: NVIDIA Corporation GF108 High Definition Audio Controller (rev a1) Subsystem: Dell Device 0535 ... Kernel driver in use: snd_hda_intel Symptoms: Audio wo

Re: [alsa-devel] linux-next - strange audio bug

2015-04-02 Thread Valdis . Kletnieks
On Fri, 03 Apr 2015 08:44:12 +0800, Hui Wang said: > It sounds like the suspend or resume of power management introduces this > problem. Probably you could reproduce this problem very soon just > repeatedly suspend and resume the system. I don't do suspend on this laptop, I poweroff and reboot wh

Re: resurrecting tcphealth

2012-07-13 Thread valdis . kletnieks
On Fri, 13 Jul 2012 16:55:44 -0700, Stephen Hemminger said: > >+/* Course retransmit inefficiency- this packet has been > >received twice. */ > >+tp->dup_pkts_recv++; > > I don't understand that comment, could you use a better sentence please? I think what

next-20150610 - repeated hangs at e1000e_phc_gettime+0x2e/0x60

2015-06-11 Thread Valdis Kletnieks
I'm seeing repeated hard lockups on my Dell Latitude E6530. Helpful info: 0) next-20150603 works, so the problem landed in linux-next in the last week. 1) All 3 times happened while I was at home, using wireless, so the interface didn't have link and was ifconfig'ed down. 2) Remarkably similar t

Re: next-20150610 - repeated hangs at e1000e_phc_gettime+0x2e/0x60

2015-06-12 Thread Valdis . Kletnieks
On Thu, 11 Jun 2015 22:57:48 -0400, Valdis Kletnieks said: > 0) next-20150603 works, so the problem landed in linux-next in the last week. > > 1) All 3 times happened while I was at home, using wireless, so > the interface didn't have link and was ifconfig'ed down. All

e1000e driver - hang after 4 hours of uptime - finally bisected!

2015-06-18 Thread Valdis Kletnieks
(follow up to a report from last week - bisecting took a while as I could only do 1 or 2 tests an evening) My Dell Latitude E6530 crashes with a specific kernel lockup almost exactly 4 hours after boot if there isn't a cable connected to the Ethernet port: [14508.846327] Kernel panic - not syncin

get-maintainer.pl \C gives perl indigestion...

2015-06-18 Thread Valdis Kletnieks
Fedora Rawhide upgraded from Perl 5.20 to 5.22, and is now whinging about stuff: I'd supply a patch, but I'm unsure why \C is being used instead of a '.' - presumably the "Break a UTF-8 character into pieces" semantic is desired here. % scripts/get_maintainer.pl -f scripts/get_maintainer.pl \C i

Re: get-maintainer.pl \C gives perl indigestion...

2015-06-18 Thread Valdis . Kletnieks
On Thu, 18 Jun 2015 16:46:14 -0700, Joe Perches said: > On Thu, 2015-06-18 at 17:33 -0400, Valdis Kletnieks wrote: > > Fedora Rawhide upgraded from Perl 5.20 to 5.22, and is now whinging about s tuff: > > > > I'd supply a patch, but I'm unsure why \C is being used in

linux-next 20180327 - "SELinux: (dev dm-3, type ext4) getxattr errno 34"

2018-03-29 Thread valdis . kletnieks
Seeing this error trying to mount ext4 disks. next-20180320 was OK. SELinux: (dev dm-3, type ext4) getxattr errno 34 and for /var, it refused to mount entirely (which brought the boot process to a screeching halt). git log shows commits in the past few days against both selinux and ext4, but not

linux-next 20180515 - ACPI disabled..

2018-05-15 Thread valdis . kletnieks
Seeing this at boot with linux-next 20180415. ACPI gets disabled, hilarity and hijinks result - everything from a lot of stuff can't find an IRQ to the dual-core w/ HT CPU coming up as just 1 core no HT. 20180430 works just fine... [0.00] ACPI: Early table checksum verification disabled

Re: linux-next 20180515 - ACPI disabled..

2018-05-15 Thread valdis . kletnieks
On Tue, 15 May 2018 15:49:15 -0600, Al Stone said: > Not off-hand. Could you please send me a copy of > /sys/firmware/acpi/tables/APIC cat /sys/firmware/acpi/tables/APIC | od -x 000 5041 4349 0072 3903 4544 4c4c 2020 020 4243 3358 2020 0020 2009 0107 4d41 2049 040 0013 0001 000

Re: [PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include

2019-03-12 Thread valdis . kletnieks
On Tue, 12 Mar 2019 23:46:11 +0100, Pali Rohar said: > Can you identify in which commit was introduced this problem? If yes, > then Fixes: keyword should be added into commit message. I admit not knowing how long that's been there - I mostly found myself with a large amount of free time, a good s

Heads up: next-20190115 and GCC 9.0 don't play nice.

2019-01-25 Thread valdis . kletnieks
So a GCC 9 escaped to Fedora Rawhide in the last few days, and things didn't go well. Fortunately, I had the 8.2.1-7 RPMs still around. Issue 1: There's a new warning added for taking the address of a member of a packed array. It wasn't *too* noisy. Issue 2: Looks like it's not ready for prime ti

Re: Heads up: next-20190115 and GCC 9.0 don't play nice.

2019-01-26 Thread valdis . kletnieks
On Fri, 25 Jan 2019 22:02:05 -0500, valdis.kletni...@vt.edu said: > So a GCC 9 escaped to Fedora Rawhide in the last few days, and things didn't > go well. Fortunately, I had the 8.2.1-7 RPMs still around. > > Issue 1: There's a new warning added for taking the address of a member of > a packed arr

Re: [regression -next0117] What is kcompactd and why is he eating 100% of my cpu?

2019-01-26 Thread valdis . kletnieks
On Sat, 26 Jan 2019 21:00:05 +0100, Pavel Machek said: > top - 13:38:51 up 1:42, 16 users, load average: 1.41, 1.93, 1.62 > Tasks: 182 total, 3 running, 138 sleeping, 0 stopped, 0 zombie > %Cpu(s): 2.3 us, 57.8 sy, 0.0 ni, 39.9 id, 0.0 wa, 0.0 hi, 0.0 si, 0.0 > st > KiB Mem: 30200

Re: [regression -next0117] What is kcompactd and why is he eating 100% of my cpu?

2019-01-27 Thread valdis . kletnieks
On Sun, 27 Jan 2019 17:00:27 +0100, Pavel Machek said: > > > I've noticed this as well on earlier kernels (next-20181224 to 20190115) > > > Some more info: > > > 1) echo 3 > /proc/sys/vm/drop_caches unwedges kcompactd in 1-3 seconds. > > This aspect is curious as it indicates that kcompactd could

Re: [PATCH] drivers: iio: industrialio-core: add check when kzalloc fails

2019-01-27 Thread valdis . kletnieks
On Thu, 24 Jan 2019 19:58:00 +0530, Bharath Vedartham said: > add code to handle the case when kzalloc fails to allocate memory to dev > > Signed-off-by: Bharath Vedartham > dev_set_name(&dev->dev, "iio:device%d", dev->id); > INIT_LIST_HEAD(&dev->buffer_list); > +

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-01-27 Thread valdis . kletnieks
On Fri, 25 Jan 2019 22:14:32 -0200, Rodrigo Ribeiro said: > Maybe, one checkstyle patch is enough, right? Which drivers can I truly > contribute to? I'll give you a pointer to the "How to contribute" the Kernel Newbies list and IRC channel uses: https://lists.kernelnewbies.org/pipermail/kernelne

next-20190125 - objtool complains about dumpstack

2019-01-27 Thread valdis . kletnieks
Seen in a build: CC arch/x86/kernel/dumpstack.o arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x9: undefined stack state arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x0: stack state mismatch: cfa1=6+16 cfa2=7+8 Probably a gcc9 code generation that objtool do

[PATCH] bpf/core.c - silence warning messages

2019-01-27 Thread valdis . kletnieks
s, because we *know* we're overwriting the default initializer. That leaves bpf/core.c with only 6 other warnings, which become more visible in comparison. Signed-off-by: Valdis Kletnieks diff --git a/kernel/bpf/Makefile b/kernel/bpf/Makefile index 4c2fa3ac56f6..2606665f2cb5 100644 --- a

Re: next-20190125 - objtool complains about dumpstack

2019-01-27 Thread valdis . kletnieks
On Sun, 27 Jan 2019 22:18:25 -0600, Josh Poimboeuf said: > On Sun, Jan 27, 2019 at 10:45:03PM -0500, valdis.kletni...@vt.edu wrote: > > Seen in a build: > > > > CC arch/x86/kernel/dumpstack.o > > arch/x86/kernel/dumpstack.o: warning: objtool: oops_begin()+0x9: undefined > > stack state > >

[PATCH] kernel/hung_task.c - fix sparse warnings

2019-01-27 Thread valdis . kletnieks
tl_hung_task_panic' was not declared. Should it be static? kernel/hung_task.c:219:5: warning: symbol 'proc_dohung_task_timeout_secs' was not declared. Should it be static? Add the appropriate header file to provide declarations. Signed-off-by: Valdis Kletnieks diff --git

next-20140312 - build error in drivers/acpi/sleep.c

2014-03-13 Thread Valdis Kletnieks
Seen in the most recent linux-next with a CONFIG_SUSPEND=n .config: CC drivers/acpi/sleep.o drivers/acpi/sleep.c: In function 'acpi_sleep_init': drivers/acpi/sleep.c:808:2: error: implicit declaration of function 'acpi_sleep_state_supported' [-Werror=implicit-function-declaration] if (ac

next-20140313 - build error in e1000e driver

2014-03-13 Thread Valdis Kletnieks
My kernel has CONFIG_PM_SLEEP=n, which leads to hilarity... CC drivers/net/ethernet/intel/e1000e/netdev.o drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend' undeclared here (not in a function) .suspend = e1000e_pm_suspend, ^ drivers/net/ethernet/i

ACPICA 20140214 auto-serialize weirds my machine...

2014-03-14 Thread Valdis Kletnieks
Surprisingly enough, this hasn't seemed to have bitten many Linux people yet, Google only finds a BSD thread (where the same ACPICA code is in use): http://comments.gmane.org/gmane.os.dragonfly-bsd.user/1817 I found this, but haven't tried it yet: commit 5f1cb4a92e4c4aabd139ff9ca1e11c0e2db2ac59

Re: ACPICA 20140214 auto-serialize weirds my machine...

2014-03-14 Thread Valdis . Kletnieks
On Fri, 14 Mar 2014 17:10:46 +0100, "Rafael J. Wysocki" said: > We have a commit that removes this command line argument already. Oh, OK.. > But those messages: > > > > > [0.119344] ACPI: Executed 1 blocks of module-level executable AML code > > [0.135282] ACPI Error: Cannot acquire Mute

Re: ACPICA 20140214 auto-serialize weirds my machine...

2014-03-14 Thread Valdis . Kletnieks
On Fri, 14 Mar 2014 19:36:54 -, "Moore, Robert" said: > Sabrina, Valdis: > > Do either of you see any error messages like this: > > ACPI Error: Mutex [0x1] is not acquired, cannot release (20140214/utmutex-437) All of my "ACPI Error:" messages look like either: ACPI Error: Cannot acquire Mute

Re: next-20140312 - build error in drivers/acpi/sleep.c

2014-03-14 Thread Valdis . Kletnieks
On Thu, 13 Mar 2014 22:23:51 +0100, "Rafael J. Wysocki" said: > On Thursday, March 13, 2014 02:48:31 PM Valdis Kletnieks wrote: > > Seen in the most recent linux-next with a CONFIG_SUSPEND=n .config: > > CC drivers/acpi/sleep.o > > drivers/acpi/sleep.

Re: The sheer number of sparse warnings in the kernel

2014-03-04 Thread Valdis . Kletnieks
On Wed, 26 Feb 2014 15:31:47 -0800, "H. Peter Anvin" said: > Yes... it looks like the 0.4.5-rc1 that shipped in Fedora is indeed out > of date. With 0.5.0 I "only" see 8,207 messages, which means that at > least the linux/err.h issue is gone. Unfortunately, that's not true, at least with the Fed

Re: [PATCH] Add option to build with -O3

2014-03-05 Thread Valdis . Kletnieks
On Wed, 05 Mar 2014 01:19:17 -0500, Jon Ringle said: > If you are not the intended recipient, please contact the sender by reply > email and destroy all copies of the original message. Is your company willing to indemnify my organization for the costs of tracking down *all* copies of the message

Re: Unkillable R-state process stuck in sendfile

2014-02-18 Thread Valdis . Kletnieks
On Mon, 17 Feb 2014 16:51:37 +0400, Vladimir Davydov said: > out_fd = eventfd(0, 0); > if (out_fd < 0) > err(1, "eventfd"); > ret = sendfile64(out_fd, in_fd, NULL, SIZE); > I'm not sure if this is actually bad and should be fixed, but perhaps > it's worth m

Re: [PATCH 0/2] Fix missing misc nodes

2014-02-18 Thread Valdis . Kletnieks
On Tue, 18 Feb 2014 02:27:23 -0300, Lucas De Marchi said: > These patches are not intended for merging as is... clearly we have at least > one problem: fram's minor is clashing with logibm's. I don't know what to do > here. They both look like obscure devices to me. Are there any architectures wh

next-20140114 - BUG: spinlock wrong CPU on CPU#3, mount/597

2014-01-15 Thread Valdis Kletnieks
Am seeing this at boot on next-20140114, but I hit this same exact stack trace at least once on next-20131218. v3.13-rc7 doesn't have the problem, so it's not a 3.13 release showstopper. I may not be able to bisect this, as there's 2 or 3 other now-fixed bugs that cause lots of 'bisect skips' bec

Re: next-20140114 - BUG: spinlock wrong CPU on CPU#3, mount/597

2014-01-16 Thread Valdis . Kletnieks
On Thu, 16 Jan 2014 11:39:34 +0100, Jan Kara said: > Hum, the complaint is for group->notification_waitq->lock which > is an internal lock for the wait queue. Actually the corruption seems to be > only a single bit flip - the whole spinlock structure looks correct, only > owner_cpu got flipped f

Re: [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix-fix.patch

2014-09-23 Thread Valdis . Kletnieks
On Tue, 23 Sep 2014 13:28:48 +0200, Michal Hocko said: > And there is another one hitting during randconfig. The patch makes my > eyes bleed Amen. But I'm not seeing a better fix either. > #if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION) > - "tlb_flush_pending %d\n",

Re: Tightening up rdpmc permissions?

2014-09-29 Thread Valdis . Kletnieks
On Mon, 29 Sep 2014 09:39:16 -0700, Andy Lutomirski said: > Would it make sense to restrict rdpmc to tasks that are in mms that > have a perf_event mapping? After all, unless I misunderstand > something, user code can't reliably use rdpmc unless they've mapped a > perf_event object to check the r

Re: [PATCH v3 6/8] phy: miphy28lp: Add SSC support for PCIE

2014-09-29 Thread Valdis . Kletnieks
On Fri, 26 Sep 2014 10:54:15 +0200, Gabriel FERNANDEZ said: > SSC is the technique of modulating the operating frequency of a signal > slightly to spread its radiated emissions over a range of frequencies. > This reduction in the maximum emission for a given frequency helps meet > radiated emission

Re: [PATCH resend] arm:extend the reserved memory for initrd to be page aligned

2014-09-29 Thread Valdis . Kletnieks
On Fri, 26 Sep 2014 10:40:54 +0800, "Wang, Yalin" said: > I am really confused, > I read this web: > http://www.arm.linux.org.uk/developer/patches/info.php > it said use diff -urN to generate patch like this: > > diff -Nru linux.orig/lib/string.c linux/lib/string.c > > but I see other developers u

Re: [PATCH resend] arm:extend the reserved memory for initrd to be page aligned

2014-09-30 Thread Valdis . Kletnieks
On Tue, 30 Sep 2014 09:02:09 +0200, Uwe Kleine-König said: > > 'diff -urN' has the advantage that it will work against a tree extracted > > from a release tarball, and doesn't have a requirement that you have git > That's wrong, patches generated by git-format-patch are also applicable > just fin

Re: [PATCH v11 00/21] Add support for NV-DIMMs to ext4

2014-09-30 Thread Valdis . Kletnieks
On Thu, 25 Sep 2014 16:33:17 -0400, Matthew Wilcox said: > Patch 19 adds some DAX infrastructure to support ext4. > > Patch 20 adds DAX support to ext4. It is broadly similar to ext2's DAX > support, but it is more efficient than ext4's due to its support for > unwritten extents. I don't current

Re: [PATCH v11 00/21] Add support for NV-DIMMs to ext4

2014-09-30 Thread Valdis . Kletnieks
On Tue, 30 Sep 2014 10:48:54 -0400, Matthew Wilcox said: > No, it doesn't try to do that. Wouldn't you be better served with an > LD_PRELOAD that forces O_DIRECT on? Not when you don't want it on every file, and users are creating and deleting files once in a while. A chattr-like command is eas

next-20140930 dies while trying to leave initramfs

2014-09-30 Thread Valdis Kletnieks
Seeing a number of different tracebacks right around when the initramfs is trying to pivot over to the real root. Out of 4 testing boots, I've seen 4 failures. next-20140922 runs fine. Anybody recognize this, before I spend several hours bisecting? Traceback 1 (Seen 3 times) [ 37.243757] EXT4

Re: [PATCH v11 00/21] Add support for NV-DIMMs to ext4

2014-09-30 Thread Valdis . Kletnieks
On Tue, 30 Sep 2014 12:08:41 -0400, Matthew Wilcox said: > The more I think about this, the more I think this is a bad idea. > When you have a file open with O_DIRECT, your I/O has to be done in > 512-byte multiples, and it has to be aligned to 512-byte boundaries > in memory. If an unsuspecting

Re: [PATCH v11 00/21] Add support for NV-DIMMs to ext4

2014-09-30 Thread Valdis . Kletnieks
On Tue, 30 Sep 2014 15:25:17 -0600, Andreas Dilger said: > I think you would be much better off having more aggressive "use once" > semantics in the page cache, so that page cache pages for streaming > writes are evicted more aggressively from cache rather than going down > the "automatic O_DIRECT

Re: [RFC PATCH 1/2] printk: Add context information to the header of /dev/kmsg

2014-05-19 Thread Valdis . Kletnieks
On Mon, 19 May 2014 19:28:38 +0900, Yoshihiro YUNOMAE said: > The header information is changed as follows: >/; Has this been tested with popular userspace that reads /dev/kmsg, to make sure that it actually plays nice with a 5th field being added? Yes, I know that Documentation/ABI/dev-

Re: Revert 462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge : Sanitize skb before it enters the IP stack)

2014-05-19 Thread Valdis . Kletnieks
On Mon, 19 May 2014 23:49:22 +0930, David Newall said: > How does a packet get fragmented in this case? Does it only happen when > bridging to a device with smaller MTU? That scenario sounds quite > un-bridge-like. It also sounds like something that can be handled by > real routing. Which does

Re: [PATCH] printk: Use symbolic defines for console loglevels

2014-05-19 Thread Valdis . Kletnieks
On Mon, 19 May 2014 20:27:32 +0200, Borislav Petkov said: > From: Borislav Petkov > > ... instead of naked numbers. > > Stuff in sysrq.c used to set it to 8 which is supposed to mean above > default level so set it to DEBUG instead as we're terminating/killing > all tasks and we want to be verbose

Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

2014-05-20 Thread Valdis . Kletnieks
sers. So it's OK by me if Pali adds this to the signoffs after fixing the checkpatch and the one serious nit below Tested-By: Valdis Kletnieks Acked-By: Valdis Kletnieks One nit: > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -127,6 +127,16 @

Re: Warning from kernel/printk/printk.c in linux-next

2014-04-30 Thread Valdis . Kletnieks
entation of console_sem I was seeing this same exact traceback on next-20140429. Can confirm the message is gone after applying this patch. If you haven't pushed it upstream, feel free to add: Tested-By: Valdis Kletnieks pgpi3pXymFKuO.pgp Description: PGP signature

Re: [PATCH 2/2] FS/CONFIGFS: Use pr_fmt

2014-05-13 Thread Valdis . Kletnieks
On Tue, 13 May 2014 13:50:49 -0700, Andrew Morton said: > On Tue, 13 May 2014 20:24:28 +0200 Fabian Frederick wrote: > > +#ifdef pr_fmt > > +#undef pr_fmt > > +#endif > > Why this? > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Won't GCC whinge by default about the #define if it doesn't exac

Re: [PATCH 1/1 v2] fanotify: check file flags passed in fanotify_init

2014-05-13 Thread Valdis . Kletnieks
On Tue, 13 May 2014 19:34:33 +0200, "Michael Kerrisk (man-pages)" said: > >> The 'switch' could just be replaced by: > >> > >> if ((event_f_flags & O_ACCMODE) == 3) > >> return -EINVAL; > >> > >> (But I'm not sure if some might prefer the idiom you have used.) > >> > >> Cheers, > >> > >>

next-20140409 Bad Kconfig help text in drivers/acpi/Kconfig

2014-05-09 Thread Valdis Kletnieks
So this commit landed in linux-next recently: commit e2a7c3d7812369daae56f069eab2e8f3e548d231 Author: Lan Tianyu Date: Sun May 4 11:07:24 2014 +0800 ACPI: Revert "ACPI: Remove CONFIG_ACPI_PROCFS_POWER and cm_sbsc.c" The commit 1e2d9cd and 7d7ee95 remove ACPI Proc Battery directory

pstore wierdness on Dell Latitude E6530.

2014-04-09 Thread Valdis Kletnieks
For some reason, /sys/fs/pstore has 537 files in it, all called 'console-efi', all having inode number 8021, and all consisting of the same one line: [/sys/fs/pstore] cat console-efi [1.567734] pci :00:1c.1: PCI bridge to [bus 03] [/sys/fs/pstore] ls | uniq -c 537 console-efi [/sys/fs

Re: pstore wierdness on Dell Latitude E6530.

2014-04-10 Thread Valdis . Kletnieks
Madper: Feel free to stick this on the patch: Tested-By: Valdis Kletnieks The gory details: I now have different filenames and inodes, with different contents, rather than duplicates: ls -li /sys/fs/pstore | head total 0 8034 -r--r--r--. 1 root root 67 Aug 13 2013 console-efi-0-1376377513 8033

Possible issue with commit 6f008e72cd - locking/mutex: Fix debug checks.

2014-04-10 Thread Valdis Kletnieks
So recent linux-next lock up on my laptop due to a third-party module. Bisection finds this as the source of the issue: 6f008e72cd111a119b5d8de8c5438d892aae99eb is the first bad commit commit 6f008e72cd111a119b5d8de8c5438d892aae99eb Author: Peter Zijlstra Date: Wed Mar 12 13:24:42 2014 +0100

Re: 3.14.0+/x86: lockdep and mutexes not getting along

2014-04-11 Thread Valdis . Kletnieks
On Thu, 10 Apr 2014 16:15:59 +0200, Peter Zijlstra said: > On Thu, Apr 10, 2014 at 11:18:24AM +0200, Peter Zijlstra wrote: > > So I managed to reproduce, and the below makes it go away. I just don't > > understand why though. will stare more. > > /me kicks himself.. bloody obvious fail there :-) >

Re: new module to check constant memory for corruption

2014-04-12 Thread Valdis . Kletnieks
On Sun, 13 Apr 2014 03:33:10 +0200, alexander.kleinso...@gmx.de said: > printk(KERN_EMERG MODNAME "error: const kernel memory is broken > (%08lx != 0), please reboot!", g_SumLast); Make a list of all the things that can dynamically modify kernel text while it's running, starting wi

Re: [PATCH] #CleanUp non-gender-neutral README

2014-03-25 Thread Valdis . Kletnieks
On Mon, 24 Mar 2014 01:09:16 -, Feminist Software Foundation said: > From: Feminist-Software-Foundation > The merge window is expected to open *next* week, around Monday or Tuesday. Please resubmit then. pgpNc2_MhLJ7W.pgp Description: PGP signature

Re: Kernel 3.16-rc6 Bug with Sound?

2014-07-25 Thread Valdis . Kletnieks
On Fri, 25 Jul 2014 18:57:33 -0400, Nick Krause said: > Hey guys after compiling and running the kernel in the subject line I > get no sound > and a message of no sound codec could be found. I am new so this may be > a missed needed config for sound or it's a bug. I am attaching my config > to he

Re: next-20140707 - crash during cryptsetup.

2014-07-14 Thread Valdis Kletnieks
System died a horrid death when cryptsetup was trying to get an encrypted disk up and running. Bisected down to this commit, and vanilla next-20140714 crashes the same way, but boots fine with this single commit reverted: commit 254c4407cb84a6dec90336054615b0f0e996bb7c Author: Maurizio Lombardi

Re: [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks

2014-07-14 Thread Valdis . Kletnieks
On Mon, 14 Jul 2014 14:14:24 -0400, Nicholas Krause said: > This patch addresses the fix me message in this file that states to > remove all definitions not related to reg-clocks in this header > file. > > Signed-off-by: Nicholas Krause > --- > arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22

Re: next-20140640 - fatal crash at boot time in sound drivers...

2014-07-01 Thread Valdis . Kletnieks
On Tue, 01 Jul 2014 11:18:15 +0200, Takashi Iwai said: > At Mon, 30 Jun 2014 12:45:54 -0400, Valdis Kletnieks wrote: > > > > Seeing this on a Dell Latitude E6530 - kernel lives for just a few > > seconds before committing hari-kiri trying to initialize the sound chipset. >

next-20140640 - fatal crash at boot time in sound drivers...

2014-06-30 Thread Valdis Kletnieks
Seeing this on a Dell Latitude E6530 - kernel lives for just a few seconds before committing hari-kiri trying to initialize the sound chipset. lspci reports the following audio devices: 00:1b.0 Audio device: Intel Corporation 7 Series/C210 Series Chipset Family High Definition Audio Controller (

next-20140707 - crash during cryptsetup.

2014-07-08 Thread Valdis Kletnieks
Not sure *who* to pin this one on, so drop it on lkml and see who notices... next-20140701 works just fine. System died a horrid death when cryptsetup was trying to get an encrypted disk up and running. This ring any bells? If not, I'll probably spend part of the evening bisecting... [ 25.9

<    3   4   5   6   7   8   9   10   11   >