[PATCH] usbip: vhci_hcd: Convert use of __constant_cpu_to_le16 to cpu_to_le16

definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- drivers/usb/usbip/vhci_hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16 to cpu_to_le16

definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- drivers/usb/gadget/function/f_uac1.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] scsi: fcoe: Convert use of __constant_htons to htons

completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_htons(x) + htons(x) Signed-off-by: Vaishali Thakkar --- drivers/scsi/fcoe/fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers

[PATCH] [SCSI] bnx2fc: Convert use of __constant_htons to htons

completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_htons(x) + htons(x) Signed-off-by: Vaishali Thakkar --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc

[PATCH] thermal: cpu_cooling: Remove usage of devm functions

with kfree. Signed-off-by: Vaishali Thakkar --- This patch is having one checkpatch.pl warning which suggests that kfree(NULL) is safe. But I think leaving code with if is nice because it reflects the fact that kcalloc was under an if. So, I have ignored checkpatch. If maintainer wants me to go

Re: [PATCH] thermal: cpu_cooling: Remove usage of devm functions

On Wed, Aug 19, 2015 at 1:54 PM, Viresh Kumar wrote: > On Wed, Aug 19, 2015 at 11:52 AM, Vaishali Thakkar > wrote: >> In the function cpufreq_get_requested_power, the memory allocated >> for load_cpu is live within the function only. And after the >> allocation it i

Re: [PATCH] qeth: Convert use of __constant_htons to htons

On Wed, Aug 19, 2015 at 2:00 PM, Ursula Braun wrote: > >> From: Vaishali Thakkar >> To:Ursula Braun , >> Cc:Ursula Braun1/Germany/IBM@IBMDE, BOEBLINGEN >> LINUX390/Germany/IBM@IBMDE, mschw...@linux.vnet.ibm.com, >> heica...@linux.vnet.ib

Re: [PATCH] thermal: cpu_cooling: Remove usage of devm functions

On Wed, Aug 19, 2015 at 1:54 PM, Viresh Kumar wrote: > On Wed, Aug 19, 2015 at 11:52 AM, Vaishali Thakkar > wrote: >> In the function cpufreq_get_requested_power, the memory allocated >> for load_cpu is live within the function only. And after the >> allocation it i

[PATCH v2] power_supply: max8998: Use devm_power_supply_register

max8998_battery_remove as it is now redundant. Signed-off-by: Vaishali Thakkar --- Changes since v1: - Make commit log more reasonable --- drivers/power/max8998_charger.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/power

[PATCH] ASoC: tegra: Convert to managed resources

Use managed resource functions devm_clk_put and devm_snd_soc_register_component to simplify error handling. To be compatible with the change various gotos are replaced with direct returns, and unneeded labels are dropped. Signed-off-by: Vaishali Thakkar --- sound/soc/tegra/tegra20_spdif.c | 37

[PATCH] ASoC: rockchip: i2s: Adjust devm usage

snd_dmaengine_pcm_unregister in probe and remove functions. Signed-off-by: Vaishali Thakkar --- sound/soc/rockchip/rockchip_i2s.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index acb5be5..b936102 100644 --- a/sound/soc

[PATCH] ASoC: davinci-vcif: Use devm_snd_soc_register_component

Use resource managed function devm_snd_soc_register_component for component registration instead of snd_soc_register_component. Also, remove davinci_vcif_remove as it is now redundant. Signed-off-by: Vaishali Thakkar --- sound/soc/davinci/davinci-vcif.c | 14 +++--- 1 file changed, 3

[PATCH] leds: leds-fsg: Use devm_led_classdev_register

-off-by: Vaishali Thakkar --- drivers/leds/leds-fsg.c | 51 - 1 file changed, 12 insertions(+), 39 deletions(-) diff --git a/drivers/leds/leds-fsg.c b/drivers/leds/leds-fsg.c index 2b4dc73..df0e5da 100644 --- a/drivers/leds/leds-fsg.c +++ b/drivers

[PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE

DEFINE_PCI_DEVICE_TABLE; initializer i; @@ - DEFINE_PCI_DEVICE_TABLE(a) + const struct pci_device_id a[] = i; Signed-off-by: Vaishali Thakkar --- arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu

[PATCH] wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE

DEFINE_PCI_DEVICE_TABLE; initializer i; @@ - DEFINE_PCI_DEVICE_TABLE(a) + const struct pci_device_id a[] = i; Signed-off-by: Vaishali Thakkar --- This patch is against linux-next branch --- drivers/scsi/wd719x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/wd719x.c b/drivers

[PATCH v2] drm/msm: Move call to PTR_ERR_OR_ZERO after reassignment

Here, a location is reset to NULL before being passed to PTR_ERR. So, PTR_ERR should be called before its argument is reassigned to NULL. Further to simplify things use PTR_ERR_OR_ZERO instead of PTR_ERR and IS_ERR. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar Reviewed-by

Re: [PATCH] drm/msm: Move call to PTR_ERR_OR_ZERO after reassignment

On Thursday 28 April 2016 06:23 PM, Eric Engestrom wrote: > On Wed, Apr 27, 2016 at 04:51:37PM +0530, Vaishali Thakkar wrote: >> Here, a location is reset to NULL before being passed to PTR_ERR. >> So, PTR_ERR should be called before its argument is reassigned >> to NULL

[PATCH] clk: bcm/kona: Do not use sizeof on pointer type

. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- drivers/clk/bcm/clk-kona-setup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c index deaa7f9..526b0b0 100644 --- a/drivers/clk/bcm/clk-ko

[PATCH] [SCSI] csiostor: Do not use sizeof on pointer type

When sizeof is applied to a pointer typed expression, it gives the size of the pointer. So, here do not use sizeof on pointer type. Problem found using Coccinelle. Fixes: a3667aaed569 ('[SCSI] csiostor: Chelsio FCoE offload driver') Signed-off-by: Vaishali Thakkar --- drivers/scs

[PATCH] perf tests: Do not use sizeof on pointer type

ound using Coccinelle. Signed-off-by: Vaishali Thakkar --- tools/perf/tests/dso-data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c index dc673ff..8cf0d9e 100644 --- a/tools/perf/tests/dso-data.c +++ b/tools/perf/tests/

Re: [PATCH] Coccinelle: noderef: Add a rule and correct the old rule

On Friday 06 May 2016 01:40 AM, Julia Lawall wrote: > > > On Wed, 27 Apr 2016, Vaishali Thakkar wrote: > >> Add a new rule to detect the cases where sizeof is used as a >> subexpression rather than a top level argument. >> >> Also, for the patch mode third

[PATCH v2] Coccinelle: noderef: Add a rule and correct the old rule

Add a new rule to detect the cases where sizeof is used as a subexpression rather than a top level argument. Also, for the patch mode third rule should behave same as second rule with arguments reversed. So, change that as well. Signed-off-by: Vaishali Thakkar --- Changes since v1

[PATCH v3] Coccinelle: noderef: Add new rules and correct the old rule

Add new rules to detect the cases where sizeof is used in function calls as a argument. Also, for the patch mode third rule should behave same as second rule with arguments reversed. So, change that as well. Signed-off-by: Vaishali Thakkar --- Changes since v2: - Add rules for function

[PATCH] drm/msm: Move call to PTR_ERR_OR_ZERO after reassignment

Here, a location is reset to NULL before being passed to PTR_ERR. So, PTR_ERR should be called before its argument is reassigned to NULL. Further to simplify things use PTR_ERR_OR_ZERO instead of PTR_ERR and IS_ERR. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- drivers

[PATCH] Coccinelle: noderef: Add a rule and correct the old rule

Add a new rule to detect the cases where sizeof is used as a subexpression rather than a top level argument. Also, for the patch mode third rule should behave same as second rule with arguments reversed. So, change that as well. Signed-off-by: Vaishali Thakkar --- scripts/coccinelle/misc

[PATCH] pinctrl: imx1-core: add missing of_node_put

) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } Signed-off-by: Vaishali Thakkar --- drivers/pinctrl/freescale/pinctrl-imx1-core.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl

[PATCH] hw_random: octeon-rng: Use devm_hwrng_register

Use resource managed function devm_hwrng_register instead of hwrng_register to make the error-path simpler. Also, remove octeon_rng_remove as it is now redundant. Signed-off-by: Vaishali Thakkar --- drivers/char/hw_random/octeon-rng.c | 12 +--- 1 file changed, 1 insertion(+), 11

[PATCH] Input: ad714x: Convert to using managed resources

, various gotos are replaced with direct returns, and unneeded labels are dropped. With these changes remove ad714x_remove and corresponding calls of it as they are now redundant. Signed-off-by: Vaishali Thakkar --- Please note that this patch is having three lines over 80 characters as limiting them to

Re: [PATCH] Input: ad714x: Convert to using managed resources

On Sat, Sep 12, 2015 at 11:52 PM, Dmitry Torokhov wrote: > On Sat, Sep 12, 2015 at 08:26:18PM +0530, Vaishali Thakkar wrote: >> Use managed resource functions devm_request_threaded_irq, >> devm_inpute_allocate_device and devm_kzalloc to simplify >> error handling

Re: [PATCH] Input: ad714x: Convert to using managed resources

On Sun, Sep 13, 2015 at 12:31 PM, Dmitry Torokhov wrote: > On Sat, Sep 12, 2015 at 10:08 PM, Vaishali Thakkar > wrote: >> On Sat, Sep 12, 2015 at 11:52 PM, Dmitry Torokhov >> wrote: >>> On Sat, Sep 12, 2015 at 08:26:18PM +0530, Vaishali Thakkar wrote: >>

[PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE

DEFINE_PCI_DEVICE_TABLE; initializer i; @@ - DEFINE_PCI_DEVICE_TABLE(a) + const struct pci_device_id a[] = i; Signed-off-by: Vaishali Thakkar --- drivers/misc/cxl/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c index 32ad097..3ed0621 100644

[PATCH] mm/hugetlb: Fix incorrect proc nr_hugepages value

value. Basically if the value of the variable hugepages is set multiple times on a command line for a specific supported hugepagesize then proc layer should consider the last specified value. Signed-off-by: Vaishali Thakkar --- The patch contains one line over 80 characters as I think limiting t

Re: [PATCH] mm/hugetlb: Fix incorrect proc nr_hugepages value

On Wednesday 17 February 2016 03:29 PM, Kirill A. Shutemov wrote: > On Wed, Feb 17, 2016 at 01:13:26AM +0530, Vaishali Thakkar wrote: >> Currently incorrect default hugepage pool size is reported by proc >> nr_hugepages when number of pages for the default huge page size is >

[PATCH] Coccinelle: Add api/setup_timer.cocci

Use the timer API function setup_timer instead of structure field assignments to initialize a timer. Signed-off-by: Vaishali Thakkar --- scripts/coccinelle/api/setup_timer.cocci | 199 +++ 1 file changed, 199 insertions(+) create mode 100644 scripts/coccinelle/api

Re: [PATCH] staging: rtl8192e: rtllib_softmac.c: Remove multiple blank lines

On Sunday 28 February 2016 08:18 PM, Tapan Prakash T wrote: > Fixed blank lines issues reported by checkpatch.pl Hi, I can see that you have sent 3 patches for the same file. But they are sent as separate patches. So, this might be confusing for the maintainer. So, in this case these are some p

[PATCH] staging: comedi: Use setup_timer

This patch introduces the use of function setup_timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (&x); + setup_timer (&x, y, z); - x.function = y; - x.data = z; Signed-off-by: Vaishali Thakkar --- drivers/staging/comedi

[PATCH] staging: dgnc: Use setup_timer

This patch introduces the use of function setup_timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (&x); + setup_timer (&x, y, z); - x.function = y; - x.data = z; Signed-off-by: Vaishali Thakkar --- drivers/stag

[PATCH] staging: wlan-ng: Use setup_timer

This patch introduces the use of function setup_timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (&x); + setup_timer (&x, y, z); - x.function = y; - x.data = z; Signed-off-by: Vaishali Thakkar --- drivers/staging

[PATCH] mm/slab_common: Use kmem_cache_free

!= &x ?-kfree(x) +kmem_cache_free(c,x) Signed-off-by: Vaishali Thakkar --- mm/slab_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index e03dd6f..67f182c 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -331,7 +331,7 @@

[PATCH] dlm: Use put_unaligned_be16

tmp ( - memcpy(ptr, (T)&tmp, \(2\|sizeof(u16)\|sizeof(__be16)\|sizeof(uint16_t)\|sizeof(e16)\)); + put_unaligned_be16(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_be16(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Vaishali Th

[PATCH] iio: gp2ap020a00f: Use put_unaligned_le32

2(y,ptr); ...+> ? tmp = e @@ type T; identifier tmp; @@ - T tmp; ...when != tmp Signed-off-by: Vaishali Thakkar --- drivers/iio/light/gp2ap020a00f.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a0

[PATCH] lpfc: Use setup_timer

This patch introduces the use of function setup_timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (&x); + setup_timer (&x, y, z); - x.function = y; - x.data = z; Signed-off-by: Vaishali Thakkar --- drivers/scsi/lpfc/lpf

[PATCH] drivers/net: Use setup_timer and mod_timer

.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/3com/3c589_cs.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/3com/3c589_cs.c b/drivers/net/ethernet/3com/3c589_cs.c index f18647c..c5a3205 100644 --- a/driv

[PATCH] pcmcia: Use setup_timer and mod_timer

.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- drivers/pcmcia/pd6729.c | 8 +++- drivers/pcmcia/yenta_socket.c | 8 +++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c index 34ace48..0f70b4d 1006

[PATCH] pcmcia: Use setup_timer

This patch introduces the use of function setup_timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (&x); + setup_timer (&x, y, z); - x.function = y; - x.data = z; Signed-off-by: Vaishali Thakkar --- drivers/pcmcia/omap_cf.

[PATCH] drivers/net: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/8390/axnet_cs.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/driv

[PATCH] drivers/net: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/8390/pcnet_cs.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/driv

[PATCH] net: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/smsc/smc91c92_cs.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --g

[PATCH] isdn: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- drivers/isdn/pcbit/drv.c| 8 +++- drivers/isdn/pcbit/edss1.c | 7 ++- drivers/isdn/pcbit/layer2.c

Re: [PATCH] net: Use setup_timer and mod_timer

On Fri, Feb 27, 2015 at 11:11 PM, David Miller wrote: > > I'm not applying these patches. > > Your Subject lines need adjusting. You have to say what specific > thing you are touching in each change. > > All of your changes say "net: " therefore someone scanning the > "git shortlog" can't tell wh

[PATCH v2] net: smc91c92_cs: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- Changes since v1: -Change subject line drivers/net/ethernet/smsc/smc91c92_cs.c | 7 ++- 1

[PATCH v2] net: 8390: pcnet_cs: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- Changes since v1: -Change subject line -Change commit log drivers/net/ethernet/8390/pcnet_cs.

[PATCH v2] net: 8390: axnet_cs: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- Changes since v1: -Change subject line -Change commit log drivers/net/ethernet/8390/axnet_cs.

[PATCH] net: stmmac: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(

[PATCH] net: pasemi: Use setup_timer and mod_timer

; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/pasemi/pasemi_mac.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --g

[PATCH] usb: core: Do not use sizeof on pointer type

When sizeof is applied to a pointer typed expression, it gives the size of the pointer. So, do not use sizeof on pointer type. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- drivers/usb/core/hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] clk: sunxi: Use resource_size

Use the function resource_size instaed of explicit computation. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- drivers/clk/sunxi/clk-sun9i-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c b/drivers/clk/sunxi/clk

[PATCH] net: fjes: Use resource_size

Use the function resource_size instead of explicit computation. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- drivers/net/fjes/fjes_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index

[PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL

Function dup_variable_bug is called inside the spinlock. This may lead to issues when kzalloc sleeps, so it is better to use GFP_ATOMIC in this spinlocked context. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- drivers/firmware/efi/vars.c | 2 +- 1 file changed, 1

Re: [PATCH] efi: Use GFP_ATOMIC instead of GFP_KERNEL

On Monday 18 April 2016 02:48 AM, Matt Fleming wrote: > On Fri, 15 Apr, at 08:38:37AM, Julia Lawall wrote: >> I looked at it a bit with Vaishali. I wonder if it would be possible at >> least to have only one flag? Then one wouldn't have to maintain the >> subtle relationship between atomic and

[PATCH] ima: Use sizeof struct rather than pointer

is a ***. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- security/integrity/ima/ima_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/integrity/ima/ima_template.c b/security/integrity/ima/ima_template.c index febd12e..fdba86f 1

[PATCH] iio: gyro: ssp_gyro_sensor: Use devm_iio_device_register

Use resourced managed function devm_iio_device_register to make error path simpler. To be compatible with the change, the remove function is removed as it is now redundant. Signed-off-by: Vaishali Thakkar --- drivers/iio/gyro/ssp_gyro_sensor.c | 12 +--- 1 file changed, 1 insertion

[PATCH] extcon: axp288: Convert to using managed resources

. Signed-off-by: Vaishali Thakkar --- drivers/extcon/extcon-axp288.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index ea962bc..9668d6a 100644 --- a/drivers/extcon/extcon-axp288.c +++ b

Re: [PATCH] wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE

On Fri, Jul 17, 2015 at 11:16 AM, Vaishali Thakkar wrote: > Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use > struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with > the goal of getting rid of this macro completely. > > The Coccinelle semantic patch tha

Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE

Ping! On Fri, Jul 17, 2015 at 10:57 AM, Vaishali Thakkar wrote: > Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use > struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with > the goal of getting rid of this macro completely. > > The Coccinelle semantic patch tha

Re: [PATCH] wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE

Ping! On Fri, Jul 17, 2015 at 11:16 AM, Vaishali Thakkar wrote: > Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use > struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with > the goal of getting rid of this macro completely. > > The Coccinelle semantic patch tha

[PATCH 0/5] soc: qcom: Add SoC info driver

cleanly applies on top of v5.0-rc6. Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc soc: qcom: Add socinfo driver soc: qcom: socinfo: Expose custom attributes soc: qcom: socinfo: Expose image information base: soc: Export soc_device_register/unregister APIs

[PATCH 4/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- drivers/soc/qcom/socinfo.c | 210 + 1 file changed, 210 insertions(+) diff

[PATCH 3/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Note that this may have some 80 char checkpatch warnings as fixing them makes code less readable. --- drivers/soc/qcom

[PATCH 2/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struc, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- drivers/soc/qcom/Kconfig | 8 ++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/smem.c| 8 ++ drivers/soc/qcom/socinfo.c | 197

[PATCH 1/5] base: soc: Add serial_number attribute to soc

rdized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar --- Documentation/ABI/testing/sysfs-devices-soc | 7 +++ drivers/base/soc.c | 7 +++ include/linux/sys_soc.h | 1 + 3 files changed, 15 inserti

[PATCH 5/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar --- drivers/base/soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/soc.c b/drivers/base/soc.c index b0933b9fe67f

Re: [Outreachy kernel] [PATCH] net: dsa: add missing of_node_put

On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote: > Hi Himadri, Thanks for the patch! For the scope of Outreachy, we prefer that you send patches in staging directory as Greg makes sure to pick them during the application period. Of course, you're very much encouraged to contribute to other

[PATCH v2 0/5] soc: qcom: Add SoC info driver

cleanly applies on top of v5.0-rc6. Changes since v1: - Align ifdefs to left, remove unnecessary debugfs dir creation check and fix function signatures in patch 3 - Fix comment for teh case when serial number is not available in patch 1 Vaishali Thakkar (5

[PATCH v2 1/5] base: soc: Add serial_number attribute to soc

rdized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar --- Changes since v1: - Make comment more clear for the case when serial number is not available --- Documentation/ABI/testing/sysfs-devices-soc | 7 +++ drivers/base/soc.c

[PATCH v2 4/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v1: - None --- drivers/soc/qcom/socinfo.c | 210 + 1

[PATCH v2 2/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struc, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v1: - None --- drivers/soc/qcom/Kconfig | 8 ++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/smem.c| 8 ++ drivers/soc/qcom

[PATCH v2 3/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v1: - Remove unnecessary debugfs dir creation check - Align ifdefs to left - Fix

[PATCH v2 5/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar --- Changes since v1: - None --- drivers/base/soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/soc.c b/drivers

Re: [PATCH v2 5/5] base: soc: Export soc_device_register/unregister APIs

On Wed, 20 Feb 2019 at 12:25, Greg KH wrote: > > On Wed, Feb 20, 2019 at 10:29:46AM +0530, Vaishali Thakkar wrote: > > From: Vinod Koul > > > > Qcom Socinfo driver can be built as a module, so > > export these two APIs. > > > > Signed-off-by: Vinod

[PATCH v5 3/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struct, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v4: - Return PTR_ERR in qcom_socinfo_probe instead of error value - Return PTR_ERR in smem probe to print proper error message

[PATCH v5 4/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v4: - Introduce socinfo_params and use create_debugfs_{u32,x32} instead of driver

[PATCH v5 1/5] base: soc: Add serial_number attribute to soc

rdized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd --- Changes since v4: - Add Stephen's reviewed-by Changes since v3: - Add Greg's Reviewed-by Changes since v2:

[PATCH v5 2/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd Reviewed-by: Bjorn Andersson --- Changes since v4: - Add Bjorn and Stephen&#

[PATCH v5 0/5] soc: qcom: Add SoC info driver

of nitpick fixes in patch 3 - Major refactoring for using core debugfs functions and eliminating duplicate code in patch 4 and 5 [detailed info can be found under --- in each patch] Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc base: soc: Exp

[PATCH v5 5/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v4: - Reduce number of duplicate image macros and functions - Introduce array for

Re: [PATCH v2] soc: qcom: socinfo: Annotate switch cases with fall through

custom attributes") > Reported-by: Stephen Rothwell > Signed-off-by: Bjorn Andersson Acked-by: Vaishali Thakkar > --- > drivers/soc/qcom/socinfo.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > i

[PATCH v6 0/5] soc: qcom: Add SoC info driver

ing patches. Version 4 was adding context at the bottom of the file with 'git am'. Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc base: soc: Export soc_device_register/unregister APIs soc: qcom: Add socinfo driver soc: qcom: socinfo: Expose cust

[PATCH v6 1/5] base: soc: Add serial_number attribute to soc

rdized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd --- Changes since v5: - No code changes, fix diff.context setting for formatting patches. Version 5 was adding context at the bot

[PATCH v6 4/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v5: - No code changes, fix my diff.context setting for formatting patches. Version 5 was

[PATCH v6 2/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd Reviewed-by: Bjorn Andersson --- Changes since v5: - No code changes, fix

[PATCH v6 5/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v5: - No code changes, fix diff.context setting for formatting patches. Version 5

[PATCH v6 3/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struct, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v5: -No code changes, fix diff.context setting for formatting patches. Version 5 was adding context at the bottom of the file

[PATCH v3 1/5] base: soc: Add serial_number attribute to soc

rdized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar --- Changes since v2: - None Changes since v1: - Make comment more clear for the case when serial number is not available --- Documentation/ABI/testing/sysfs-devices-soc | 7 +++

[PATCH v3 5/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v2: - None Changes since v1: - None --- drivers/soc/qcom/socinfo.c | 210

[PATCH v3 3/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struct, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v2: - Fix typo in the work log under signed off by s Changes since v1: - None --- drivers/soc/qcom/Kconfig | 8 ++ drivers/soc/qcom

[PATCH v3 2/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar --- Changes since v2: - Reordered patches [patch 5->patch 2] Changes since v1: - None --- drivers/base/soc.c | 2 ++ 1 f

[PATCH v3 4/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v2: - None Changes since v1: - Remove unnecessary debugfs dir creation check

[PATCH v3 0/5] soc: qcom: Add SoC info driver

: - Reorder patches [patch five -> patch two] Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc base: soc: Export soc_device_register/unregister APIs soc: qcom: Add socinfo driver soc: qcom: socinfo: Expose custom attributes soc: qcom: socinfo: Expose image informat

Re: [PATCH v3 5/5] soc: qcom: socinfo: Expose image information

On Thu, 21 Feb 2019 at 22:04, Greg KH wrote: > > On Thu, Feb 21, 2019 at 09:54:19PM +0530, Vaishali Thakkar wrote: > > static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo) > > { > > + struct smem_image_version *smem_image_versio

<    1   2   3   4   >