[PATCH] fs/9p: Drop memory allocation cast

Drop useless cast on the result of kmem_cache_alloc. Signed-off-by: Vaishali Thakkar --- fs/ncpfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c index 1af15fc..2cc3090 100644 --- a/fs/ncpfs/inode.c +++ b/fs/ncpfs/inode.c @@ -52,7

[PATCH] fsl/qe: Use resource_size

Use the function resource_size instead of explicit computation. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- drivers/soc/fsl/qe/qe_tdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qe/qe_tdm.c b/drivers/soc/fsl/qe/qe_tdm.c index

Re: [Question] Calling request_firmware under the spinlocks in file advansys.c

On Tuesday 13 September 2016 02:48 PM, Vaishali Thakkar wrote: > Hi, > > In the file drivers/scsi/advansys.c we are calling function AdvISR at 2 > instances > [in the function advansys_reset and advansys_interrupt] while holding > spinlock. > Function AdvISR eventually c

Re: A potential race in drivers/iio/adc/vf610_adc.ko

On Saturday 03 September 2016 08:53 PM, Jonathan Cameron wrote: > On 02/09/16 09:05, Pavel Andrianov wrote: >> > >> Hi! > Hi Pavel, >> >> There is a potential race in drivers/iio/adc/vf610_adc.ko. Handlers >> vf610_set_conversion_mode and vf610_write_raw are called via >> device_attibute interfa

[Question] Calling request_firmware under the spinlocks in file advansys.c

Hi, In the file drivers/scsi/advansys.c we are calling function AdvISR at 2 instances [in the function advansys_reset and advansys_interrupt] while holding spinlock. Function AdvISR eventually calls request_firmware following this sequence of routines: AdvISR -> adv_async_callback -> AdvResetCh

[PATCH] [SCSI] wd719x: Avoid calling request_firmware under spinlock

ff-by: Vaishali Thakkar --- Please note that the patch is compile-tested only. And this change may require driver testing. --- drivers/scsi/wd719x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c index e3da1a2..b8e57f3 100644

Re: [PATCH] usb: gadget: f_uac1: Convert use of __constant_cpu_to_le16 to cpu_to_le16

On Tue, Oct 6, 2015 at 4:59 AM, Felipe Balbi wrote: > Vaishali Thakkar writes: > >> On Mon, Aug 24, 2015 at 2:29 PM, David Laight >> wrote: >>> From: Vaishali Thakkar [mailto:vthakkar1...@gmail.com] >>>> Sent: 22 August 2

Re: [PATCH] leds: leds-cobalt-qube: Use devm_led_classdev_register

On Thu, Aug 27, 2015 at 12:56 PM, Jacek Anaszewski wrote: > Hi Vaishali, > > Thanks for the patch. > > On 08/27/2015 07:13 AM, Vaishali Thakkar wrote: >> >> Use resource-managed function devm_led_classdev_register instead >> of led_classdev_register to make th

[PATCH v2] leds: leds-cobalt-qube: Use devm_led_classdev_register

cobalt_qube_led_remove. Signed-off-by: Vaishali Thakkar --- Changes since v1: - Remove use of variable retval - Change commit log --- drivers/leds/leds-cobalt-qube.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/leds/leds-cobalt

Re: [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE

On Thu, Oct 22, 2015 at 3:53 AM, Muhammad Falak R Wani wrote: > Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with > the goal of getting rid of this macro completely, as this macro > is deprecated. Duplicate of :https://lkml.org/lkml/2015/7/17/62 > Signed-off-by: Muhammad Falak R W

Re: [PATCH v2] leds: leds-cobalt-qube: Use devm_led_classdev_register

On Fri, Sep 4, 2015 at 4:54 PM, Jacek Anaszewski wrote: > Hi Vaishali, > > > On 09/01/2015 02:35 PM, Vaishali Thakkar wrote: >> >> Use resource-managed function devm_led_classdev_register instead >> of led_classdev_register to make the error-path simpler. >>

Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE

On Thu, Oct 1, 2015 at 1:37 PM, Ingo Molnar wrote: > > * Vaishali Thakkar wrote: > >> Ping! > > Pong. This patch is already upstream. Oops! Sorry. I just realized that you already applied it but it is still showing me in linux-next when grepped for it and is blocking the

Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE

On Thu, Oct 1, 2015 at 1:55 PM, Ingo Molnar wrote: > > * Vaishali Thakkar wrote: > >> On Thu, Oct 1, 2015 at 1:37 PM, Ingo Molnar wrote: >> > >> > * Vaishali Thakkar wrote: >> > >> >> Ping! >> > >> > Pong. This patch

[PATCH] perf/x86/intel/uncore: Do not use macro DEFINE_PCI_DEVICE_TABLE()

VICE_TABLE; initializer i; @@ - DEFINE_PCI_DEVICE_TABLE(a) + const struct pci_device_id a[] = i; Signed-off-by: Vaishali Thakkar --- arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c

Re: [PATCH] Input: da9052_onkey: Convert to managed resources

On Fri, Oct 2, 2015 at 11:13 PM, Dmitry Torokhov wrote: > On Tue, Aug 04, 2015 at 12:52:53PM +, Opensource [Steve Twiss] wrote: >> On 27 July 2015 03:56, Vaishali Thakkar wrote: >> >> > Subject: [PATCH] Input: da9052_onkey: Convert to managed resources >> > &g

Re: [Outreachy kernel] Re: [PATCH 1/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

On Thu, Apr 8, 2021 at 7:41 PM ascordeiro wrote: > > Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu: > > Ola Aline, > Ola Ezequiel, > > > Welcome to the kernel community. Hope you enjoy some of this > > Outreachy adventures. > Thank you! > > > Normally, when you submit a v2, we want t

[PATCH] Drivers: block: Introduce use of put_unaligned_be64

tr, (T)&tmp, ...); + put_unaligned_be64(y,ptr); ) ...+> ? tmp = e @script:python@ p << o.p; @@ print "dangerous second argument in %s:%s" % (p[0].file,p[0].line) @@ type T; identifier o.tmp; @@ - T tmp; ...when != tmp // Signed-off-by: Vaishali Thakkar --- drivers/bl

[PATCH] Drivers: block: Introduce use of put_unaligned_be64

tr, (T)&tmp, ...); + put_unaligned_be64(y,ptr); ) ...+> ? tmp = e @script:python@ p << o.p; @@ print "dangerous second argument in %s:%s" % (p[0].file,p[0].line) @@ type T; identifier o.tmp; @@ - T tmp; ...when != tmp // Signed-off-by: Vaishali Thakkar --- drivers/bl

[PATCH] NFC: port100: Introduce the use of function put_unaligned_le16

ptr, (T)&tmp, \(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(e16)\)); + put_unaligned_le16(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Vaishali Thakkar --- drivers/nfc/port100.c

Re: [PATCH] NFC: port100: Introduce the use of function put_unaligned_le16

On Wed, Dec 24, 2014 at 12:54 AM, Arend van Spriel wrote: > On 12/23/14 16:27, Vaishali Thakkar wrote: >> >> This patch introduces the use of function put_unaligned_le16. >> >> This is done using Coccinelle and semantic patch used is as follows: >> >> @a@

[PATCH v2] NFC: port100: Introduce the use of function put_unaligned_le16a...@linux.intel.com,

ptr, (T)&tmp, \(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(e16)\)); + put_unaligned_le16(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Vaishali Thakkar --- Changes since v1:

[PATCH] NFC: port100: Introduce the use of function put_unaligned_le16

ptr, (T)&tmp, \(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(e16)\)); + put_unaligned_le16(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Vaishali Thakkar --- Changes since v1:

[PATCH v3] NFC: port100: Introduce the use of function put_unaligned_le16

ptr, (T)&tmp, \(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(e16)\)); + put_unaligned_le16(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Vaishali Thakkar --- Changes since v1:

[PATCH v2] NVMe: Use put_unaligned_be64

tmp ( - memcpy(ptr, (T)&tmp, \(8\|sizeof(u64)\|sizeof(__be64)\|sizeof(uint64_t)\|sizeof(e64)\)); + put_unaligned_be64(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_be64(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Va

[PATCH] Staging: rtl8192u: Remove check of ieee in rtl819x_BAProc.c

This patch fixes following smatch warning: drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c:117 ieee80211_ADDBA() warn: variable dereferenced before check 'ieee' (see line 114) As ieee can not be NULL at this point, all such checks are removed. Signed-off-by: Vaishali Thakkar --

[PATCH] Staging: rtl8192u: Use put_unaligned_le16 in rtl819x_BAProc.c

hen != tmp ( - memcpy(ptr, (T)&tmp, \(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(uint16_t)\|sizeof(e16)\)); + put_unaligned_le16(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Va

[PATCH] IB/ipath: Convert use of __constant_ to

, replace __constant_be16_to_cpu with be16_to_cpu and __constant_cpu_to_be64 with cpu_to_be64, with the goal of getting rid of the definition of __constant_be16_to_cpu and __constant_cpu_to_be64 completely. Signed-off-by: Vaishali Thakkar --- drivers/infiniband/hw/ipath/ipath_verbs.c | 4 ++-- 1

[PATCH] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX

) | - __constant_cpu_to_be64(x) + cpu_to_be64(x) ) Signed-off-by: Vaishali Thakkar --- drivers/infiniband/ulp/srpt/ib_srpt.c | 61 ++- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt

[PATCH v2] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX

) | - __constant_cpu_to_be64(x) + cpu_to_be64(x) ) Signed-off-by: Vaishali Thakkar --- Changes since v1: - Shorten lines to 80 characters --- drivers/infiniband/ulp/srpt/ib_srpt.c | 71 +-- 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a

[PATCH] [SCSI] qla4xxx: Convert __constant_cpu_to_le16 to cpu_to_le16

definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- drivers/scsi/qla4xxx/ql4_nx.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] tty: Convert use of __constant_htons to htons

completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_htons(x) + htons(x) Signed-off-by: Vaishali Thakkar --- drivers/tty/n_gsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c

[PATCH v2] [SCSI] qla4xxx: Replace __constant_cpu_to_le16 with cpu_to_le16

definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- Changes since v1: - Make subject more concise --- drivers/scsi/qla4xxx

[PATCH] isdn/hisax: Convert use of __constant_cpu_to_le16 to cpu_to_le16

definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- drivers/isdn/hisax/st5481_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] usb: gadget: Convert use of __constant_cpu_to_le16 to cpu_to_le16

definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- drivers/usb/gadget/legacy/audio.c | 6 +++--- drivers/usb/gadget/legacy/dbgp.c

[PATCH] [media] s5k5baf: Convert use of __constant_cpu_to_be16 to cpu_to_be16

definition of __constant_cpu_to_be16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_be16(x) + cpu_to_be16(x) Signed-off-by: Vaishali Thakkar --- drivers/media/i2c/s5k5baf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] net: rose: Use mod_timer

= e4 - add_timer (&e1); + mod_timer (&e1, e2); Signed-off-by: Vaishali Thakkar --- net/rose/rose_link.c | 16 net/rose/rose_loopback.c | 6 +- net/rose/rose_timer.c| 30 +- 3 files changed, 10 insertions(+), 42 deletions(-) diff --gi

[PATCH] USB: serial: Use setup_timer

e1, a, b); ... when != a = e2 when != b = e3 -e1.function = a; ... when != b = e4 -e1.data = b; Signed-off-by: Vaishali Thakkar --- drivers/usb/serial/mos7840.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/m

[PATCH] isdn/capi: Use setup_timer

e1, a, b); ... when != a = e2 when != b = e3 -e1.data = b; ... when != a = e4 -e1.function = a; Signed-off-by: Vaishali Thakkar --- drivers/isdn/capi/capidrv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c index

[PATCH] net: mv643xx_eth: Use setup_timer

-e.data = da; -e.function = func; Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/marvell/mv643xx_eth.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 1c75829.

[PATCH] net: dl2k: Use setup_timer

e1, a, b); ... when != a = e2 when != b = e3 -e1.data = b; ... when != a = e4 -e1.function = a; Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/dlink/dl2k.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethern

[PATCH] ethernet/intel: Use setup_timer

e1, a, b); ... when != a = e2 when != b = e3 -e1.function = a; ... when != b = e4 -e1.data = b; Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/intel/e100.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/in

[PATCH] xen-netfront: Use setup_timer

-e.data = da; -e.function = func; Signed-off-by: Vaishali Thakkar --- drivers/net/xen-netfront.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 3f45afd..10a087a 100644 --- a/drivers/net/xen-netfront.c +++ b

[PATCH] atm: idt77105: Use setup_timer

... when != a = e2 -e1.function = a; Signed-off-by: Vaishali Thakkar --- drivers/atm/idt77105.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/atm/idt77105.c b/drivers/atm/idt77105.c index 909c95b..feb023d 100644 --- a/drivers/atm/idt77105.c +++ b/drivers/atm/id

[PATCH] usb: udc: Convert use of __constant_cpu_to_leXX to cpu_to_leXX

the goal of getting rid of the definition of __constant_cpu_to_le{16,32} completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ ( - __constant_cpu_to_le16(x) + cpu_to_le16(x) | - __constant_cpu_to_le32(x) + cpu_to_le32(x) ) Signed-off-by: Vaishali Thakkar

[PATCH] qeth: Convert use of __constant_htons to htons

completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_htons(x) + htons(x) Signed-off-by: Vaishali Thakkar --- drivers/s390/net/qeth_l2_main.c | 2 +- drivers/s390/net/qeth_l3_main.c | 6 +++--- 2 files changed, 4 insertions(+), 4

[PATCH] s390/zcrypt: Convert use of __constant_cpu_to_le16 to cpu_to_le16

definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- drivers/s390/crypto/zcrypt_pcicc.c | 8 1 file changed, 4 insertions

[PATCH] NFS: Convert use of __constant_htonl to htonl

completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_htonl(x) + htonl(x) Signed-off-by: Vaishali Thakkar --- fs/nfs/callback_xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/callback_xdr.c b/fs/nfs

[PATCH] arch/ia64: Use setup_timer

... when != a = e2 -e1.function = a; Signed-off-by: Vaishali Thakkar --- arch/ia64/kernel/mca.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/ia64/kernel/mca.c b/arch/ia64/kernel/mca.c index dd5801e..2889412 100644 --- a/arch/ia64/kernel/mca.c +++ b/arch/ia64/kern

[PATCH] ARM: pxa: Use setup_timer

... when != a = e2 -e1.function = a; Signed-off-by: Vaishali Thakkar --- arch/arm/mach-pxa/sharpsl_pm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c index 051a655..bdc0c41 100644 --- a/arch/arm/mach-pxa/shar

[PATCH] ARM: iop32x: Use setup_timer

... when != a = e2 -e1.function = a; Signed-off-by: Vaishali Thakkar --- arch/arm/mach-iop32x/n2100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c index c1cd80e..4a64a11 100644 --- a/arch/arm/mach-iop32x/n2100.c ++

[PATCH] Drivers: block: Use setup_timer

... when != a = e2 -e1.function = a; Signed-off-by: Vaishali Thakkar --- drivers/block/umem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/umem.c b/drivers/block/umem.c index 4cf81b5..cd999a1 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c @@ -738,

[PATCH] Blackfin: Use setup_timer

... when != a = e2 -e1.function = a; Signed-off-by: Vaishali Thakkar --- arch/blackfin/kernel/nmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/blackfin/kernel/nmi.c b/arch/blackfin/kernel/nmi.c index 9919d29..64dd717 100644 --- a/arch/blackfin/kernel/nmi.c +++ b/arch/

[PATCH] aoe: Convert use of __constant_ to

) | - __constant_cpu_to_be16(x) + cpu_to_be16(x) ) Signed-off-by: Vaishali Thakkar --- drivers/block/aoe/aoecmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 422b7d8..6e891d2 100644 --- a/drivers/block/aoe/aoecmd.c +++ b

[PATCH] aoe: Convert use of __constant_htons to htons

completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_htons(x) + htons(x) Signed-off-by: Vaishali Thakkar --- drivers/block/aoe/aoenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/aoe/aoenet.c b

[PATCH] [media] dvb_core: Replace memset with eth_zero_addr

-off-by: Vaishali Thakkar --- drivers/media/dvb-core/dvb_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c index a694fb1..b81e026 100644 --- a/drivers/media/dvb-core/dvb_net.c +++ b/drivers/media/dvb-core

[PATCH] Staging: wilc1000: Replace memset with eth_zero_addr

-off-by: Vaishali Thakkar --- drivers/staging/wilc1000/linux_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index f5296f5..2a3d875 100644 --- a/drivers/staging/wilc1000/linux_mon.c +++ b/drivers

[PATCH] [SCSI] fnic: Replace memset with eth_broadcast_addr

); +eth_broadcast_addr(e); // Signed-off-by: Vaishali Thakkar --- drivers/scsi/fnic/fnic_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 155b286..650d448 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b

[PATCH v2] [SCSI] fnic: Replace memset with eth_broadcast_addr

\),ETH_ALEN); +eth_broadcast_addr(e); // Signed-off-by: Vaishali Thakkar --- Change since v1: - Fix mistake in commit log --- drivers/scsi/fnic/fnic_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index

[PATCH] drm/vc4: make function vc4_allocate_bin_bo static

Sparse complains with following warning: drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol 'vc4_allocate_bin_bo' was not declared. Should it be static? Make vc4_allocate_bin static as it is not used outside of vc4_v3d.c. Signed-off-by: Vaishali Thakkar --- drivers/gpu/drm/vc4/vc4

[PATCH] drm: rcar-du: Use drm_dev_put

As specified in drm_drv.c, drm_dev_unref is a compatibility alias for drm_dev_put and shouldn't be used in new code. So, use drm_dev_put instead. Signed-off-by: Vaishali Thakkar --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

Re: [PATCH] drm: rcar-du: Use drm_dev_put

On Wed, Apr 25, 2018 at 7:02 PM, Laurent Pinchart wrote: > Hi Vaishali, > > Thank you for the patch. > > On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote: >> As specified in drm_drv.c, drm_dev_unref is a compatibility alias >> for drm_dev_put and should

[PATCH] drm/core: Remove drm_dev_unref() and it's uses

s used for mass-patching. Signed-off-by: Vaishali Thakkar --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 4 ++-- drivers/gpu/drm/arc/arcpgu_drv.c | 4 ++-- drivers/gpu/drm/armada/armada_drv.c| 6 +++--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

On Thu, Apr 26, 2018 at 6:15 PM, Laurent Pinchart wrote: > Hi Daniel, > > On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote: >> On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote: >> > It's been a while since we introduced drm_dev{get/p

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

On Fri, 1 Mar 2019 at 03:02, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-02-24 22:50:43) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > > index 02078049fac7..ccadeba69a81 100644 > > --- a/drivers/soc/qcom/socinfo.c > > ++

Re: [Outreachy kernel] [PATCH v3] staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h

On Wed, Apr 7, 2021 at 10:49 AM Fabio M. De Francesco wrote: > > On Wednesday, April 7, 2021 10:18:13 AM CEST Greg KH wrote: > > On Tue, Apr 06, 2021 at 06:00:37PM +0200, Fabio M. De Francesco wrote: > > > Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols > > > are not used

Re: [Outreachy kernel] [PATCH] staging: iio: cdc: remove repeated word

On Mon, Apr 5, 2021 at 12:24 AM David Villasana Jiménez wrote: > > Fix checkpatch warning: > WARNING: Possible repeated word: 'from' You don't need to include the checkpatch warning in the commit log. Your commit log should just be able to give enough information about why you're doing this chang

[PATCH] ASoC: xtensa: Remove unnecessary snd_pcm_lib_preallocate_free_for_all()

The ALSA core takes care that all preallocated memory is freed when the PCM itself is freed. There is no need to do this manually in the driver. Signed-off-by: Vaishali Thakkar --- sound/soc/xtensa/xtfpga-i2s.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/sound/soc/xtensa/xtfpga

[PATCH] power_supply: Adjust devm usage

Use devm_kasprintf instead of kasprintf. Also, remove various gotos by direct returns and drop unneeded label err_free_name. Signed-off-by: Vaishali Thakkar --- drivers/power/bq24735-charger.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a

Re: [PATCH] power_supply: Adjust devm usage

t; On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote: >> Use devm_kasprintf instead of kasprintf. Also, remove various >> gotos by direct returns and drop unneeded label err_free_name. > > Please also use devm_power_supply_unregister() instead > of pow

Re: [PATCH] power_supply: Adjust devm usage

On Fri, Jul 24, 2015 at 5:59 PM, Krzysztof Kozlowski wrote: > 2015-07-24 21:17 GMT+09:00 Frans Klaver : >> Hi, Hi >> On Fri, Jul 24, 2015 at 1:58 PM, Vaishali Thakkar >> wrote: >>> Use devm_kasprintf instead of kasprintf. Also, remove various >>> gotos by

Re: [PATCH] power_supply: Adjust devm usage

On Fri, Jul 24, 2015 at 6:29 PM, Sebastian Reichel wrote: > Hi, > > On Fri, Jul 24, 2015 at 06:03:38PM +0530, Vaishali Thakkar wrote: >> On Fri, Jul 24, 2015 at 5:56 PM, Sebastian Reichel wrote: >> > On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote

Re: [PATCH] power_supply: Adjust devm usage

On Fri, Jul 24, 2015 at 7:08 PM, Sebastian Reichel wrote: > Hi, Hi, > On Fri, Jul 24, 2015 at 06:44:41PM +0530, Vaishali Thakkar wrote: >> [...] >> >> This makes sense. Thanks for explanation and review :) >> So, can I send all changes along with getting rid o

[PATCH] scsi: Use module_pci_driver

le_pci_driver; @@ -module_exit(e); +module_pci_driver(x); Signed-off-by: Vaishali Thakkar --- drivers/scsi/a100u2w.c | 14 +- drivers/scsi/am53c974.c | 14 +- drivers/scsi/dc395x.c | 25 + drivers/scsi/dmx3191d.c | 14 +- drivers/scsi/hpsa.c

[PATCH] scsi: Use module_platform_driver

arer name module_platform_driver; @@ -module_exit(e); +module_platform_driver(x); Signed-off-by: Vaishali Thakkar --- drivers/scsi/jazz_esp.c | 14 +- drivers/scsi/mac_esp.c| 14 +- drivers/scsi/qlogicpti.c | 14 +- drivers/scsi/sni_53c710.c | 14 +-

[PATCH] uio: uio_fsl_elbc_gpcm: Use module_platform_driver

arer name module_platform_driver; @@ -module_exit(e); +module_platform_driver(x); Signed-off-by: Vaishali Thakkar --- drivers/uio/uio_fsl_elbc_gpcm.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/uio/uio_fsl_elbc_gpcm.c b/drivers/uio/uio_fsl_elbc_gpcm.c ind

[PATCH] net: systemport: Use eth_hw_addr_random

off-by: Vaishali Thakkar --- Note that this patch is compile tested only and I have used file drivers/net/ethernet/hisilicon/hix5hd2_gmac.c as a reference. Also, original call didn't make assignment to NET_ADDR_RANDOM. So, it would be good if someone can test this change. --- drivers/net/

[PATCH] neterion: s2io: Use module_pci_driver

; declarer name module_exit; declarer name module_pci_driver; @@ -module_exit(e); +module_pci_driver(x); Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/neterion/s2io.c | 26 +- drivers/net/ethernet/neterion/s2io.h | 2 -- 2 files changed, 1 insertion(+), 27 delet

[PATCH v2] coresight: replicator: Use module_platform_driver

Use module_platform_driver for drivers whose init and exit functions only register and unregister, respectively. Signed-off-by: Vaishali Thakkar --- Changes since v1: - As per Mathieu's suggestion, remove the comment and code of Coccinelle - Also, add blank line b

Re: [PATCH v2] thermal: cpu_cooling: Remove usage of devm functions

On Wed, Aug 26, 2015 at 6:44 PM, Viresh Kumar wrote: > On 26-08-15, 14:09, Javi Merino wrote: >> On Wed, Aug 26, 2015 at 01:51:58PM +0100, Viresh Kumar wrote: >> > On 26-08-15, 13:47, Javi Merino wrote: >> > > I missed this because I wasn't CCed :( Thankfully, I'll be in >> > > MAINTAINERS for th

[PATCH] leds: leds-cobalt-qube: Use devm_led_classdev_register

Use resource-managed function devm_led_classdev_register instead of led_classdev_register to make the error-path simpler. To be compatible with the change, goto is replaced with direct return and unneeded label is dropped. Also, remove redundant cobalt_qube_led_remove. Signed-off-by: Vaishali

Re: [PATCH] soc: versatile: Use devm_kzalloc

On Wed, Jul 29, 2015 at 2:00 PM, Linus Walleij wrote: > On Tue, Jul 28, 2015 at 4:17 PM, Vaishali Thakkar > wrote: >> On 28 Jul 2015 17:35, "Linus Walleij" wrote: > >>> Reviewed-by: Linus Walleij >>> Please get this through ARM SoC or tell me if I sh

Re: [PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate

On Thu, Jul 30, 2015 at 5:54 PM, Pablo Neira Ayuso wrote: > On Sun, Jul 26, 2015 at 05:27:37PM +0530, Vaishali Thakkar wrote: >> For simple modules that contain a single xt_match without any >> additional setup code then ends up being a block of duplicated >> boilerplate.

Re: [PATCH] Staging:wilc1000 :Remove braces for single statement blocks

On 31 Jul 2015 10:49, "Shraddha Barke" wrote: > > This patch fixes the following checkpatch.pl warning: > > WARNING: braces {} are not necessary for single statement blocks There should be one line space between your commit log and Signed-off-by line. > Signed-off-by: Shraddha Barke > --- > dr

[PATCH v2] power_supply: bq24735: Convert to using managed resources

Use managed resource functions like devm_kasprintf and devm_power_supply_register in bq24735_charger_probe. To be compatible with the change, replace various gotos by direct returns and drop unneeded labels. Also, remove bq24735_charger_remove as it is now redundant. Signed-off-by: Vaishali

[PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate

For simple modules that contain a single xt_match without any additional setup code then ends up being a block of duplicated boilerplate. This patch adds a new macro, module_xt_match(), which replaces the module_init()/module_exit() registrations with template functions. Signed-off-by: Vaishali

[PATCH] Input: da9052_onkey: Convert to managed resources

Use managed resource functions devm_input_allocate_device and devm_kzalloc. To be compatible with the change, replace various gotos by direct returns and drop unneeded labels. Signed-off-by: Vaishali Thakkar --- drivers/input/misc/da9052_onkey.c | 15 --- 1 file changed, 4

[PATCH] soc: versatile: Use devm_kzalloc

This patch introduces the use of devm_kzalloc and does away with kfree in the probe function. Signed-off-by: Vaishali Thakkar --- Some comments on this patch and driver: - Here, after this change there will be a kfree on the failure of the regmap_read too. I am not sure if driver is currently

Re: [PATCH] usb: gadget: Convert use of __constant_cpu_to_le16 to cpu_to_le16

On Sat, Jun 6, 2015 at 7:02 AM, Vaishali Thakkar wrote: > In big endian cases, macro cpu_to_le16 unfolds to __swab16 which > provides special case for constants. In little endian cases, > __constant_cpu_to_le16 and cpu_to_le16 expand directly to the > same expression.

Re: [PATCH] ASoC: tegra: Convert to managed resources

On Mon, Aug 17, 2015 at 12:47 PM, Alexandre Courbot wrote: > On Thu, Aug 13, 2015 at 4:29 PM, Vaishali Thakkar > wrote: >> Use managed resource functions devm_clk_put and >> devm_snd_soc_register_component to simplify error handling. >> >> To be compatible wit

Re: [PATCH] ASoC: tegra: Convert to managed resources

On Tue, Aug 18, 2015 at 2:17 AM, Mark Brown wrote: > On Mon, Aug 17, 2015 at 03:02:29PM +0530, Vaishali Thakkar wrote: > >> I think you are right. I missed that. But now thing is , this patch is >> already >> applied here: >> https://git.kernel.org/cgit/linux/kerne

[PATCH] video: fbdev: Use devm_clk_get

. Signed-off-by: Vaishali Thakkar --- drivers/video/fbdev/pxa168fb.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c index e209b03..efb57c0 100644 --- a/drivers/video/fbdev/pxa168fb.c +++ b/drivers

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar wrote: > > On 17 Aug 2015 13:57, "Jacek Anaszewski" wrote: >> >> Hi Vaishali, >> >> Thanks for the patch. Unfortunately it causes build break. >> Please fix the issues and resubmit. > > Oop

[PATCH] crypto: sahara: Use dmam_alloc_coherent

This patch moves the data allocated using dma_alloc_coherent to the corresponding managed interface. To be compatible with the change, various gotos are replaced with direct returns and unneeded labels are dropped. Signed-off-by: Vaishali Thakkar --- drivers/crypto/sahara.c | 46

Re: [PATCH] ASoC: tegra: Convert to managed resources

On Tue, Aug 18, 2015 at 12:48 PM, Alexandre Courbot wrote: > On Mon, Aug 17, 2015 at 6:32 PM, Vaishali Thakkar > wrote: >> On Mon, Aug 17, 2015 at 12:47 PM, Alexandre Courbot wrote: >>> On Thu, Aug 13, 2015 at 4:29 PM, Vaishali Thakkar >>> wrote: >&

[PATCH] Revert part of "ASoC: tegra: Convert to managed resources"

_component instead of devm_snd_soc_register_component. Signed-off-by: Vaishali Thakkar --- sound/soc/tegra/tegra20_spdif.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/tegra/tegra20_spdif.c b/sound/soc/tegra/tegra20_spdif.c index a814da0..66237bc 100644 -

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

On Tue, Aug 18, 2015 at 12:57 PM, Jacek Anaszewski wrote: > Hi Vaishali, > > On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: >> >> On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar >> wrote: >>> >>> >>> On 17 Aug 2015 13:57, &qu

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

On Tue, Aug 18, 2015 at 6:06 PM, Jacek Anaszewski wrote: > On 08/18/2015 02:14 PM, Vaishali Thakkar wrote: >> >> On Tue, Aug 18, 2015 at 12:57 PM, Jacek Anaszewski >> wrote: >>> >>> Hi Vaishali, >>> >>> On 08/18/2015 07:46 AM, Vaishali T

[PATCH v2] leds: leds-fsg: Use devm_led_classdev_register

-off-by: Vaishali Thakkar --- Changes since v1: - Fix build errors --- drivers/leds/leds-fsg.c | 52 - 1 file changed, 12 insertions(+), 40 deletions(-) diff --git a/drivers/leds/leds-fsg.c b/drivers/leds/leds-fsg.c index 2b4dc73..257a813

Re: [PATCH] mtd: denali: Use module_pci_driver

On Wed, Aug 19, 2015 at 6:02 AM, Brian Norris wrote: > > On Tue, Jul 07, 2015 at 12:53:45PM +0530, Vaishali Thakkar wrote: > > Use module_pci_driver for drivers whose init and exit functions > > only register and unregister, respectively. > > > > A simplified vers

Re: [PATCH] qeth: Convert use of __constant_htons to htons

em in linux-next and they are blocking removal of these macros. Do inform me in case there is any problem with this patch. Thank You. > Regards, Ursula Braun > > On Wed, 2015-06-10 at 16:22 +0530, Vaishali Thakkar wrote: >> In little endian cases, the macro htons unfolds to __swab16

  1   2   3   4   >