Re: [PATCH v11 15/27] iommu/exynos: use convenient macro to handle gate clocks

2014-03-18 Thread Tomasz Figa
On 18.03.2014 12:18, Sachin Kamat wrote: On 18 March 2014 16:33, Cho KyongHo wrote: On Fri, 14 Mar 2014 22:27:59 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 19:13, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:09, Cho KyongHo wrote: exynos-iommu driver must care about

Re: [PATCH v3 2/3] mfd: sec-core: Add of_compatible strings for clock MFD cells

2014-03-18 Thread Tomasz Figa
Hi Krzysztof, On 17.03.2014 10:19, Krzysztof Kozlowski wrote: Add of_compatible strings for S5M8767 and S2MPS14 clock MFD cells. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c |3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-18 Thread Tomasz Figa
On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some master device descriptor like fimc-is which is an abstraction of very complex H/W may have multiple System MMUs. For those devices, the

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-18 Thread Tomasz Figa
On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo wrote: This patch uses managed device helper functions in the probe(). Signed-off-by: Cho KyongHo --- [snip] + data->clk = devm_clk_get(de

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-18 Thread Tomasz Figa
On 18.03.2014 10:56, Cho KyongHo wrote: On Fri, 14 Mar 2014 13:59:00 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:08, Cho KyongHo wrote: [snip] -static bool __exynos_sysmmu_disable(struct sysmmu_drvdata *data) +static void __sysmmu_disable_nocount(struct sysmmu_drvdata *data

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-18 Thread Tomasz Figa
On 18.03.2014 11:38, Cho KyongHo wrote: On Fri, 14 Mar 2014 14:28:36 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:05, Cho KyongHo wrote: This patch uses managed device helper functions in the probe(). Signed-off-by: Cho KyongHo --- drivers/iommu/exynos-iommu.c | 64

Re: [PATCH v11 13/27] iommu/exynos: support for device tree

2014-03-18 Thread Tomasz Figa
On 18.03.2014 11:52, Cho KyongHo wrote: On Fri, 14 Mar 2014 14:39:33 +0100, Tomasz Figa wrote: @@ -557,11 +558,23 @@ static int exynos_sysmmu_probe(struct platform_device *pdev) return 0; } -static struct platform_driver exynos_sysmmu_driver = { - .probe

Re: [PATCH v11 19/27] iommu/exynos: add support for power management subsystems.

2014-03-18 Thread Tomasz Figa
On 18.03.2014 12:23, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:07:53 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: [snip] @@ -677,11 +679,40 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev) platform_set_drvdata(pdev, data

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-18 Thread Tomasz Figa
On 17.03.2014 06:19, Chanwoo Choi wrote: Hi Tomasz, On 03/15/2014 02:35 AM, Tomasz Figa wrote: Hi Chanwoo, Mark, On 14.03.2014 11:56, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 07:35 PM, Mark Rutland wrote: On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: Hi Mark, On 03/14

Re: [PATCHv2 0/8] devfreq: exynos4: Support dt and use common ppmu driver

2014-03-18 Thread Tomasz Figa
On 17.03.2014 02:58, Chanwoo Choi wrote: Hi Tomasz, On 03/15/2014 02:58 AM, Tomasz Figa wrote: Hi Chanwoo, On 13.03.2014 09:17, Chanwoo Choi wrote: This patchset support devicetree and use common ppmu driver instead of individual code of exynos4_bus.c to remove duplicate code. Also this

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-19 Thread Tomasz Figa
Hi Chanwoo, On 19.03.2014 10:47, Chanwoo Choi wrote: Hi Tomasz, On 03/19/2014 12:46 AM, Tomasz Figa wrote: On 17.03.2014 06:19, Chanwoo Choi wrote: Hi Tomasz, On 03/15/2014 02:35 AM, Tomasz Figa wrote: Hi Chanwoo, Mark, On 14.03.2014 11:56, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 07

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-19 Thread Tomasz Figa
On 19.03.2014 10:01, Sachin Kamat wrote: On 19 March 2014 14:29, Cho KyongHo wrote: On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar 2014 20:52:43 +0530, Sachin Kamat wrote: Hi KyongHo, On 14 March 2014 10:35, Cho KyongHo wrote

Re: [PATCH v2 2/4] drivers: clk: use CONFIG_COMMON_CLK_SAMSUNG for Samsung clock support

2014-03-19 Thread Tomasz Figa
Hi Pankaj, On 12.03.2014 05:32, Pankaj Dubey wrote: This patch includes Samsung clock Kconfig file, and replaces PLAT_SAMSUNG with COMMON_CLK_SAMSUNG for Samsung common clock support. Any Samsung SoC want to use Samsung common clock infrastructure can simply select COMMON_CLK_SAMSUNG. Signed-of

Re: [PATCH v2 1/4] clk: samsung: add new Kconfig for Samsung common clock options

2014-03-19 Thread Tomasz Figa
Hi Pankaj, On 12.03.2014 05:32, Pankaj Dubey wrote: This patch adds new Kconfig file for adding new config option as COMMON_CLK_SAMSUNG for Samsung common clock. This patch also moves S3C24XX specific clock options here in this file. Signed-off-by: Pankaj Dubey --- drivers/clk/samsung/Kconfi

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Tomasz Figa
On 19.03.2014 02:03, Cho KyongHo wrote: On Tue, 18 Mar 2014 16:09:50 +0100, Tomasz Figa wrote: On 18.03.2014 10:56, Cho KyongHo wrote: On Fri, 14 Mar 2014 13:59:00 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:08, Cho KyongHo wrote: [snip] @@ -637,11 +708,14 @@ static void

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-19 Thread Tomasz Figa
On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some master device descriptor like fimc-is

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-19 Thread Tomasz Figa
On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: Hi KyongHo, On 14.03.2014 06:10, Cho KyongHo wrote: Some

Re: [PATCH v11 0/4] thermal: samsung: Clean up and add support for Exynos5420

2014-03-19 Thread Tomasz Figa
Hi Leela, On 19.03.2014 12:19, Leela Krishna Amudala wrote: Hi All, I didn't see this series in mainline, Any comments for this ? Naveen had posted v12 of this series and I believe all the patches got my Reviewed-by. Best regards, Tomasz -- To unsubscribe from this list: send the line "uns

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Tomasz Figa
Hi Grant, On 19.03.2014 18:03, Grant Grundler wrote: On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote: ... No. Proper Linux drivers must support deferred probing mechanism and there should be no assumptions about probing orders. Using other initcall level than module_initcall for particular

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-19 Thread Tomasz Figa
On 19.03.2014 19:37, Grant Grundler wrote: On Wed, Mar 19, 2014 at 10:30 AM, Tomasz Figa wrote: ... As I said, AFAIK the trend is to get rid of ordering by initcalls and make sure that drivers can handle missing dependencies properly, even for "services" such as DMA, GPIO, clocks

Re: [PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

2014-03-19 Thread Tomasz Figa
Hi Sören, On 20.03.2014 00:13, Sören Brinkmann wrote: On Mon, 2014-03-03 at 05:02PM +0100, Tomasz Figa wrote: This patch introduces generic code to perform power domain look-up using device tree and automatically bind devices to their power domains. Generic device tree binding is introduced to

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Tomasz Figa
On 20.03.2014 11:03, Cho KyongHo wrote: On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: On 19.03.2014 10:01, Sachin Kamat wrote: On 19 March 2014 14:29, Cho KyongHo wrote: On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Tomasz Figa
On 20.03.2014 11:22, Cho KyongHo wrote: On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014

Re: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory

2014-02-11 Thread Tomasz Figa
Hi, On 11.02.2014 13:13, Grant Likely wrote: On Tue, 11 Feb 2014 12:45:50 +0100, Marek Szyprowski wrote: Hello, On 2014-02-05 12:05, Grant Likely wrote: On Tue, 04 Feb 2014 13:09:29 +0100, Marek Szyprowski wrote: This patch adds device tree support for contiguous and reserved memory regi

Re: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory

2014-02-11 Thread Tomasz Figa
On 11.02.2014 21:02, Benjamin Herrenschmidt wrote: On Tue, 2014-02-11 at 19:01 +, Grant Likely wrote: except that the former IMHO better suits the definition of memory region, which I see as a single contiguous range of memory and can be simplified to have a single reg entry per region.

Re: [PATCH v2 1/5] drivers: of: add initialization code for reserved memory

2014-02-11 Thread Tomasz Figa
On 11.02.2014 21:19, Josh Cartwright wrote: On Tue, Feb 11, 2014 at 09:04:21PM +0100, Tomasz Figa wrote: On 11.02.2014 21:02, Benjamin Herrenschmidt wrote: On Tue, 2014-02-11 at 19:01 +, Grant Likely wrote: except that the former IMHO better suits the definition of memory region

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-02-13 Thread Tomasz Figa
be expressed in the devicetree. Cc: Chen-Yu Tsai Cc: Tomasz Figa Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel --- This devicetree binding proposal is intended for platforms with Broadcom wireless device in MMC sdio slot. These devices may have

Re: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation

2014-02-13 Thread Tomasz Figa
Hi Alexandre, On 07.02.2014 05:35, Alexandre Courbot wrote: Some firmwares do not put the CPU into idle mode themselves, but still need to be informed that the CPU is about to enter idle mode before this happens. Add a prepare_idle() operation to the firmware_ops structure to handle such cases.

Re: [RFC] dt: bindings: add bindings for Broadcom bcm43xx sdio devices

2014-02-13 Thread Tomasz Figa
On 13.02.2014 13:07, Arend van Spriel wrote: On 02/13/2014 10:13 AM, Tomasz Figa wrote: Hi Arend, On 10.02.2014 20:17, Arend van Spriel wrote: The Broadcom bcm43xx sdio devices are fullmac devices that may be integrated in ARM platforms. Currently, the brcmfmac driver for these devices

Re: [PATCH v1 0/2] exynos_mct driver: fix irq allocation and cleanup

2014-02-13 Thread Tomasz Figa
Hi Tarek, On 13.02.2014 04:08, Tarek Dakhran wrote: exynos4_local_timer_setup called on the secondary cpu before irqs are enabled. request_irq can sleep, which produces next warning: on boot: [0.37] CPU0: thread -1, cpu 0, socket 0, mpidr 8000 [0.37] Setting up static identi

Re: [PATCH v2 10/14] Documentation: mfd: s2mps11: Document support for S2MPS14

2014-02-13 Thread Tomasz Figa
Hi, On 13.02.2014 10:14, Krzysztof Kozlowski wrote: Add bindings documentation for S2MPS14 device to the s2mps11 driver. Signed-off-by: Krzysztof Kozlowski Cc: Mark Brown Cc: Liam Girdwood Cc: Tomasz Figa Cc: devicet...@vger.kernel.org Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc

Re: [PATCH v3 15/15] mfd: max14577: Add device tree bindings document

2014-02-19 Thread Tomasz Figa
Hi, On 17.02.2014 10:05, Krzysztof Kozlowski wrote: Add document describing device tree bindings for MAX14577 MFD drivers: MFD core, extcon, regulator and charger. Both MAX14577 and MAX77836 chipsets are documented. Signed-off-by: Krzysztof Kozlowski Cc: Kyungmin Park Cc: Tomasz Figa Cc

Re: [PATCH v3 15/15] mfd: max14577: Add device tree bindings document

2014-02-19 Thread Tomasz Figa
Hi, On 17.02.2014 10:05, Krzysztof Kozlowski wrote: Add document describing device tree bindings for MAX14577 MFD drivers: MFD core, extcon, regulator and charger. Both MAX14577 and MAX77836 chipsets are documented. Signed-off-by: Krzysztof Kozlowski Cc: Kyungmin Park Cc: Tomasz Figa Cc

Re: [PATCH RFC 04/10] base: power: Add generic OF-based power domain look-up

2014-01-22 Thread Tomasz Figa
Hi Stephen, On 23.01.2014 01:18, Stephen Boyd wrote: On 01/11, Tomasz Figa wrote: + +/** + * of_genpd_lock() - Lock access to of_genpd_providers list + */ +static void of_genpd_lock(void) +{ + mutex_lock(&of_genpd_mutex); +} + +/** + * of_genpd_unlock() - Unlock acces

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-23 Thread Tomasz Figa
On 23.01.2014 19:40, Mark Brown wrote: On Thu, Jan 23, 2014 at 06:04:23PM +, Alan Cox wrote: We can then enable that config option for ARM (and in time for any other architecture that turns out to need/want it). Eventually it can go away (not that its exactly doing any harm if it doesnt).

Re: Arndale Timer Interrupt Question

2014-01-24 Thread Tomasz Figa
On 23.01.2014 07:10, Mj Embd wrote: On 1/10/14, Tomasz Figa wrote: Hi, On 09.01.2014 13:52, Bartlomiej Zolnierkiewicz wrote: added linux-samsung-soc to cc:, it is a better suited list for this question On Thursday, January 09, 2014 10:30:56 AM Mj Embd wrote: I am a bit confused on the

Re: [PATCH 3/8 v4] crypto:s5p-sss: Add support for SSS module on Exynos

2014-01-24 Thread Tomasz Figa
Hi Naveen, On 15.01.2014 10:15, Naveen Krishna Chatradhi wrote: This patch adds new compatible and variant struct to support the SSS module on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) for which 1. AES register are at an offset of 0x200 and 2. hash interrupt is not available [sn

Re: [PATCH 5/8 v4] clk: samsung: exynos5250/5420: Add gate clock for SSS module

2014-01-24 Thread Tomasz Figa
Hi Naveen, Exynos5250 specific part looks good, but I have a little doubt in case of Exynos5420. On 15.01.2014 10:16, Naveen Krishna Chatradhi wrote: This patch adds gating clock for SSS(Security SubSystem) module on Exynos5250/5420. Signed-off-by: Naveen Krishna Chatradhi TO: TO: Tomasz

Re: [PATCH 6/8 v4] ARM: dts: exynos5250/5420: add dt node for sss module

2014-01-24 Thread Tomasz Figa
Hi Naveen, On 15.01.2014 10:16, Naveen Krishna Chatradhi wrote: This patch adds the device tree node for SSS module found on Exynos5420 and Exynos5250 Signed-off-by: Naveen Krishna Chatradhi Reviewed-by: Tomasz Figa TO: CC: Kukjin Kim CC: --- Changes since v3: 1. Modified the SSS clock ID

Re: [PATCH 7/8 v4] crypto:s5p-sss: validate iv before memcpy

2014-01-24 Thread Tomasz Figa
1 deletion(-) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

2014-01-26 Thread Tomasz Figa
Hi Manish, On 26.01.2014 08:15, Manish Badarkhe wrote: Instead of "#if define CONFIG_OF" use "IS_ENABLED(CONFIG_OF)" option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe --- :100644 100644 b4513f2... d353fbc... M drivers/power/max8925_power.c drivers/power/max8925_

Re: linux-next: manual merge of the clk tree with the arm-soc tree

2014-01-26 Thread Tomasz Figa
Hi Stephen, On 13.01.2014 06:06, Stephen Rothwell wrote: Hi Mike, Today's linux-next merge of the clk tree got a conflict in drivers/clk/samsung/clk-exynos4.c between commit 86576fbe201b ("clk: samsung: exynos4: Fix definition of div_mmc_pre4 divider") from the arm-soc tree and commit 2d7382375

Re: linux-next: manual merge of the clk tree with the arm-soc tree

2014-01-26 Thread Tomasz Figa
On 26.01.2014 21:59, Tomasz Figa wrote: Hi Stephen, On 13.01.2014 06:06, Stephen Rothwell wrote: Hi Mike, Today's linux-next merge of the clk tree got a conflict in drivers/clk/samsung/clk-exynos4.c between commit 86576fbe201b ("clk: samsung: exynos4: Fix definition of div_mmc_pr

Re: [PATCH] max8925_power: Use "IS_ENABLED(CONFIG_OF)" for DT code.

2014-01-26 Thread Tomasz Figa
On 26.01.2014 22:45, Dmitry Torokhov wrote: On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa wrote: Hi Manish, On 26.01.2014 08:15, Manish Badarkhe wrote: Instead of "#if d

Re: [PATCH v2 01/11] base: power: Add generic OF-based power domain look-up

2014-04-03 Thread Tomasz Figa
Hi Ulf, On 03.04.2014 14:16, Ulf Hansson wrote: On 3 March 2014 17:02, Tomasz Figa wrote: This patch introduces generic code to perform power domain look-up using device tree and automatically bind devices to their power domains. Generic device tree binding is introduced to specify power

Re: [PATCH v7 3/3] mfd: max14577: Add device tree bindings document

2014-01-07 Thread Tomasz Figa
Hi, On Friday 06 of December 2013 12:32:14 Krzysztof Kozlowski wrote: > Add document describing device tree bindings for MAX14577 MFD driver. > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kyungmin Park > --- > Documentation/devicetree/bindings/mfd/max14577.txt | 65 > +

Re: [PATCH 1/5] crypto:s5p-sss: Use platform_get_irq() instead of _byname()

2014-01-07 Thread Tomasz Figa
Hi Naveen, Please see my comments inline. On Tuesday 07 of January 2014 17:21:45 Naveen Krishna Ch wrote: > This patch uses the platform_get_irq() instead of the > platform_get_irq_byname(). Making feeder control interrupt > as resource "0" and hash interrupt as "1". > > reasons for this change.

Re: [PATCH 2/5] crypto:s5p-sss: Add device tree and Exynos5 support

2014-01-07 Thread Tomasz Figa
Hi Naveen, Please see my comments inline. On Tuesday 07 of January 2014 17:21:46 Naveen Krishna Ch wrote: > This patch adds device tree support along with a new > compatible string to support Exynos5 SoCs (SSS_VER_5). > > Also, Documentation under devicetree/bindings added. > > Signed-off-by: N

Re: [PATCH 3/5] crypto:s5p-sss: Add support for SSS module on Exynos5

2014-01-07 Thread Tomasz Figa
Hi Naveen, Please see my comments inline. On Tuesday 07 of January 2014 17:21:47 Naveen Krishna Ch wrote: > The differences between SSS modules on S5PV210 and Exynos5 > (AFA the driver supports) > 1. AES register are at an offset of 0x200 on Exynos5 > 2. hash interrupt is no longer needed on Exyn

Re: [PATCH 4/5] crypto:s5p-sss: Exynos5 SoCs too can select SSS driver

2014-01-07 Thread Tomasz Figa
On Tuesday 07 of January 2014 17:21:48 Naveen Krishna Ch wrote: > This patch modifies Kconfig such that ARCH_EXYNOS5 SoCs > can also select Samsung SSS(Security SubSystem) driver. > > Signed-off-by: Naveen Krishna Ch > CC: Herbert Xu > CC: David S. Miller > CC: Vladimir Zapolskiy > TO: > CC:

Re: [PATCH 5/5] ARM: exynos5420: add dt node for sss module

2014-01-07 Thread Tomasz Figa
On Tuesday 07 of January 2014 17:21:49 Naveen Krishna Ch wrote: > From: Naveen Krishna Chatradhi > > this patch adds the device tree nodes for SSS module found on Exynos5420 nit: Sentences in English start with a capital letter. Also this patch adds one node, not few of them as the description s

Re: [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support

2014-01-09 Thread Tomasz Figa
Hi Naveen, On 09.01.2014 05:59, Naveen Krishna Chatradhi wrote: This patch adds device tree support to the s5p-sss.c crypto driver. Implements a varient struct to address the changes in SSS hardware on various SoCs from Samsung. Also, Documentation under devicetree/bindings added. Signed-off-b

Re: [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support

2014-01-10 Thread Tomasz Figa
this patchset. It's okay. On 9 January 2014 19:44, Tomasz Figa wrote: Hi Naveen, On 09.01.2014 05:59, Naveen Krishna Chatradhi wrote: This patch adds device tree support to the s5p-sss.c crypto driver. Implements a varient struct to address the changes in SSS hardware on various SoCs fr

Re: [PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-10 Thread Tomasz Figa
Hi Yuvaraj, In general this version looks pretty good, but I have some questions inline. On 10.01.2014 08:00, Yuvaraj Kumar C D wrote: [snip] diff --git a/drivers/phy/phy-exynos5250-sata-i2c.c b/drivers/phy/phy-exynos5250-sata-i2c.c new file mode 100644 index 000..206e337 --- /dev/null +++

Re: [PATCH 1/8 v3] crypto:s5p-sss: Use platform_get_irq() instead of _byname()

2014-01-10 Thread Tomasz Figa
--- Changes since v2: None drivers/crypto/s5p-sss.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 3/8 v3] crypto:s5p-sss: Add support for SSS module on Exynos

2014-01-10 Thread Tomasz Figa
Hi Naveen, Please see my comments inline. On 10.01.2014 12:42, Naveen Krishna Chatradhi wrote: This patch adds new compatible and variant struct to support the SSS module on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) for which 1. AES register are at an offset of 0x200 and 2. hash

Re: [PATCH 4/8 v3] crypto:s5p-sss: Kconfig: Let Exynos SoCs select SSS driver

2014-01-10 Thread Tomasz Figa
Hi Naveen, On 10.01.2014 12:43, Naveen Krishna Chatradhi wrote: From: Naveen Krishna Ch This patch modifies Kconfig such that ARCH_EXYNOS SoCs which includes (Exynos4210, Exynos5250 and Exynos5420) can also select Samsung SSS(Security SubSystem) driver. Signed-off-by: Naveen Krishna Ch CC: H

Re: [PATCH 5/8 v3] clk:exynos-5250: Add gate clock for SSS module

2014-01-10 Thread Tomasz Figa
Hi Naveen, On 10.01.2014 12:43, Naveen Krishna Chatradhi wrote: This patch adds gating clock for SSS(Security SubSystem) module on Exynos5250. Signed-off-by: Naveen Krishna Chatradhi --- Changes since v2: This is a new change to support SSS on Exynos5250 drivers/clk/samsung/clk-exynos5250.c

Re: [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare

2014-01-10 Thread Tomasz Figa
|6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 7/8 v3] crypto:s5p-sss: validate iv before memcpy

2014-01-10 Thread Tomasz Figa
Hi Naveen, On 10.01.2014 12:45, Naveen Krishna Chatradhi wrote: This patch adds code to validate "iv" buffer before trying to memcpy the contents Signed-off-by: Naveen Krishna Chatradhi --- Changes since v2: None drivers/crypto/s5p-sss.c |5 +++-- 1 file changed, 3 insertions(+), 2 del

Re: [PATCH 6/8 v3] ARM: dts: exynos5250/5420: add dt node for sss module

2014-01-10 Thread Tomasz Figa
arch/arm/boot/dts/exynos5250.dtsi |8 arch/arm/boot/dts/exynos5420.dtsi | 10 ++ 2 files changed, 18 insertions(+) Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: Arndale Timer Interrupt Question

2014-01-10 Thread Tomasz Figa
Hi, On 09.01.2014 13:52, Bartlomiej Zolnierkiewicz wrote: added linux-samsung-soc to cc:, it is a better suited list for this question On Thursday, January 09, 2014 10:30:56 AM Mj Embd wrote: I am a bit confused on the interrupt number for CNTVIRQ..CNTHPIRQ. Can you please help here. As per

Re: [PATCH] arm: Add Arm Erratum 773769 for Large data RAM latency.

2014-01-10 Thread Tomasz Figa
Hi, On 08.01.2014 17:21, Doug Anderson wrote: WIll, Thanks for your comments! On Wed, Jan 8, 2014 at 6:35 AM, Will Deacon wrote: On Wed, Jan 08, 2014 at 01:33:11PM +, Vivek Gautam wrote: The erratum-773769 occurs on Arm Coretex-A15 (rev r2p0), when L2 Data Ram latency is set to 4 cycles

[PATCH RFC 10/10] ARM: dts: s3c6410-mini6410: Add support for LCD screen

2014-01-11 Thread Tomasz Figa
This patch adds necessary device tree nodes and properties to enable LCD screen on mini6410 board. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/s3c6410-mini6410.dts | 33 + 1 file changed, 33 insertions(+) diff --git a/arch/arm/boot/dts/s3c6410-mini6410.dts

[PATCH RFC 08/10] ARM: dts: s3c64xx: Add nodes for power domains

2014-01-11 Thread Tomasz Figa
This patch adds device tree nodes for power domains available on S3C64xx SoCs. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/s3c6400.dtsi | 1 + arch/arm/boot/dts/s3c6410.dtsi | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/s3c6400.dtsi b/arch/arm/boot/dts/s3c6400

[PATCH RFC 07/10] ARM: s3c64xx: dt: Enable SoC-level power management

2014-01-11 Thread Tomasz Figa
This patch adds call to s3c64xx_pm_init() from init_machine() callback of mach-s3c64xx-dt to enable SoC-level power management features, such as power domain management and sleep support. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 8 1 file changed, 8

[PATCH RFC 06/10] ARM: s3c64xx: pm: Add device tree based power domain instantiation

2014-01-11 Thread Tomasz Figa
This patch adds support for registering power domains of S3C64xx SoCs and binding devices to them using device tree. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/pm.c | 71 + include/dt-bindings/arm/s3c64xx-power-domains.h | 26 + 2

[PATCH RFC 05/10] ARM: exynos: Move to generic power domain bindings

2014-01-11 Thread Tomasz Figa
This patch moves Exynos power domain code to use the new generic power domain look-up framework introduced by previous patch, allowing the new code to be compiled with CONFIG_ARCH_EXYNOS selected as well. Signed-off-by: Tomasz Figa --- .../bindings/arm/exynos/power_domain.txt | 12

[PATCH RFC 02/10] ARM: s3c64xx: pm: Add always_on field to s3c64xx_pm_domain struct

2014-01-11 Thread Tomasz Figa
This patch adds always_on field to s3c64xx_pm_domain struct to allow handling registration of all domains in the same way, without the need to have separate arrays for normal and always on domains. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/pm.c | 21 - 1 file

[PATCH RFC 09/10] ARM: dts: s3c64xx: Add node for display controller

2014-01-11 Thread Tomasz Figa
This patch adds device tree node for the display controller present on S3C64xx SoCs. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/s3c64xx.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi index 4e3be4d

[PATCH RFC 04/10] base: power: Add generic OF-based power domain look-up

2014-01-11 Thread Tomasz Figa
-specific power domain bindings is provided, but for now the new code is not compiled when CONFIG_ARCH_EXYNOS is selected to avoid collision with legacy code. This will change as soon as Exynos power domain code gets converted to use the generic framework in further patch. Signed-off-by: Tomasz Figa

[PATCH RFC 03/10] ARM: s3c64xx: pm: Add pwr_stat bit for domain G

2014-01-11 Thread Tomasz Figa
There is a status bit for domain G present in BLK_PWR_STAT register, but it is currently not specified in the driver. This patch adds the status bit of domain G to structure describing it. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/pm.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain

2014-01-11 Thread Tomasz Figa
This patch removes name field from private s3c64xx_pm_domain struct and moves domain name to dedicated field of generic_pm_domain struct. When at it, beautify the names a bit, since they are used by genpd core as message prefixes. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/pm.c | 19

[PATCH RFC 00/10] Generic Device Tree based power domain look-up

2014-01-11 Thread Tomasz Figa
splay controller (FIMD) which is a power domain consumer. Successfully tested on S3C6410-based Mini6410 board. Tomasz Figa (10): ARM: s3c64xx: pm: Use name field of generic_pm_domain ARM: s3c64xx: pm: Add always_on field to s3c64xx_pm_domain struct ARM: s3c64xx: pm: Add pwr_stat bit for dom

Re: [PATCH RFC 00/10] Generic Device Tree based power domain look-up

2014-01-11 Thread Tomasz Figa
On Saturday 11 of January 2014 20:42:42 Tomasz Figa wrote: > Up till now there was no single generic method to bind devices to their > power domains using Device Tree. Each platform has been doing this using > its own way, example of which are Exynos power domain bindings [1] and > loo

Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain

2014-01-12 Thread Tomasz Figa
Hi Pavel, On 12.01.2014 12:47, Pavel Machek wrote: On Sat 2014-01-11 20:42:43, Tomasz Figa wrote: This patch removes name field from private s3c64xx_pm_domain struct and moves domain name to dedicated field of generic_pm_domain struct. When at it, beautify the names a bit, since they are used

Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain

2014-01-12 Thread Tomasz Figa
On 12.01.2014 19:53, Pavel Machek wrote: Hi! Could we get some more descriptive names for the domains? They are listed like this in user's manual, e.g. DOMAIN_F, DOMAIN_I, DOMAIN_G, etc. I guessed so. So the manual sucks. Would it be feasible to get it more descriptive (like "Domain_G (GPU)

Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain

2014-01-12 Thread Tomasz Figa
On 12.01.2014 20:20, Mark Brown wrote: On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote: static struct s3c64xx_pm_domain s3c64xx_pm_irom = { - .name = "IROM", .ena = S3C64XX_NORMALCFG_IROM_ON, .pd = { + .name = "domain_i

Re: [PATCH RFC 06/10] ARM: s3c64xx: pm: Add device tree based power domain instantiation

2014-01-12 Thread Tomasz Figa
On 12.01.2014 20:29, Mark Brown wrote: On Sat, Jan 11, 2014 at 08:42:48PM +0100, Tomasz Figa wrote: This patch adds support for registering power domains of S3C64xx SoCs and binding devices to them using device tree. +#ifdef CONFIG_OF +static struct of_device_id s3c64xx_pd_matches

Re: [PATCH RFC 06/10] ARM: s3c64xx: pm: Add device tree based power domain instantiation

2014-01-13 Thread Tomasz Figa
On 13.01.2014 12:09, Mark Brown wrote: On Sun, Jan 12, 2014 at 08:34:10PM +0100, Tomasz Figa wrote: On 12.01.2014 20:29, Mark Brown wrote: On Sat, Jan 11, 2014 at 08:42:48PM +0100, Tomasz Figa wrote: This patch adds support for registering power domains of S3C64xx SoCs and binding devices

Re: [PATCH 1/2] of: irq: Fix interrupt-map entry matching

2013-11-07 Thread Tomasz Figa
On Thursday 07 of November 2013 10:40:16 Rob Herring wrote: > On Thu, Nov 7, 2013 at 5:32 AM, Tomasz Figa wrote: > > Hi Grant, > > > > Could you pick this patch up? It fixes boot-up at least on several > > Exynos based platforms, which use interrupt-map nodes with

Re: [PATCH 03/11] devicetree: bindings: Document qcom,kpss-acc

2013-11-08 Thread Tomasz Figa
On Tuesday 05 of November 2013 11:51:07 Kumar Gala wrote: > On Nov 5, 2013, at 11:44 AM, Stephen Boyd wrote: > > On 11/05/13 09:13, Kumar Gala wrote: > >> On Nov 1, 2013, at 5:08 PM, Stephen Boyd wrote: > >>> diff --git > >>> a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt > >>> b/Doc

Re: [PATCH 01/11] devicetree: bindings: Document cpu enable-method for ARM CPUs

2013-11-08 Thread Tomasz Figa
On Friday 01 of November 2013 15:08:49 Stephen Boyd wrote: > From: Rohit Vaswani > > According to the ePAPR CPUs should have an enable method. On ARM > the enable-method property has not been used so far, so document > this property as an optional property and add the spin-table > method as one v

[PATCH] MAINTAINERS: Add entry for Samsung SoC clock drivers

2013-11-08 Thread Tomasz Figa
From: Tomasz Figa This patch adds an entry for Samsung SoC clock drivers located under drivers/clk/samsung/ directory, with me taking the maintainer role. Signed-off-by: Tomasz Figa Acked-by: Kyungmin Park Acked-by: Mike Turquette Acked-by: Sachin Kamat Acked-by: Sylwester Nawrocki Acked

Re: [PATCH 0/4] Add support for clocks in S5M8767

2013-11-10 Thread Tomasz Figa
+), 7 deletions(-) For the whole series: Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v6] iio: exynos_adc: use wait_for_completion_timeout instead of interruptible

2013-11-10 Thread Tomasz Figa
Hi Naveen, On Tuesday 05 of November 2013 15:15:30 Naveen Krishna Chatradhi wrote: > 1. The irq routine is so simple (just one register read) shouldn't be > long Hence, reduce the timeout to 100milli secs, I believe that the timeout value depends mostly on maximum conversion time and interrupt h

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-10 Thread Tomasz Figa
Hi Vivek, On Thursday 31 of October 2013 13:15:41 Vivek Gautam wrote: > Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. > The new driver uses the generic PHY framework and will interact > with DWC3 controller present on Exynos5 series of SoCs. > > Signed-off-by: Vivek Gautam > --

Re: [PATCH 2/4] dt: exynos5250: Enable support for generic USB 3.0 phy

2013-11-10 Thread Tomasz Figa
Hi Vivek, On Thursday 31 of October 2013 13:15:42 Vivek Gautam wrote: > Update device tree bindings for DWC3 controller and > USB 3.0 phy present on Exynos 5250 SoC, to start using > the phy driver based on generic phy framework. > > Signed-off-by: Vivek Gautam > --- > arch/arm/boot/dts/exynos5

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-10 Thread Tomasz Figa
Hi Kamil, Please see my comments inline. On Tuesday 05 of November 2013 17:13:19 Kamil Debski wrote: > Add a new driver for the Exynos USB PHY. The new driver uses the generic > PHY framework. The driver includes support for the Exynos 4x10 and 4x12 > SoC families. > > Signed-off-by: Kamil Debsk

Re: [PATCH v3 2/3] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-11-10 Thread Tomasz Figa
Hi Kamil, On Tuesday 05 of November 2013 17:13:20 Kamil Debski wrote: > Change the phy provider used from the old usb phy specific to a new one > using the generic phy framework. I believe that until Exynos5250 also gets converted to the new PHY driver, support for the old USB PHY API should rema

Re: [PATCH v3 3/3] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-11-10 Thread Tomasz Figa
Hi Kamil, This patch is changing a DT binding, but you haven't updated relevant documentation. Please remember about it in next version. On Tuesday 05 of November 2013 17:13:21 Kamil Debski wrote: > Change the used phy driver to the new Exynos USB phy driver that uses the > generic phy framework.

Re: [PATCH v3 1/4] ARM: EXYNOS: Add support for EXYNOS5410 SoC

2013-11-10 Thread Tomasz Figa
Hi, On Thursday 07 of November 2013 12:12:46 Vyacheslav Tyrtov wrote: > From: Tarek Dakhran > > EXYNOS5410 is SoC in Samsung's Exynos5 SoC series. > Add initial support for this SoC. In general the patch looks pretty good, however there are several things that I overlooked when reviewing previo

Re: [PATCH v3 2/4] clk: exynos5410: register clocks using common clock framework

2013-11-10 Thread Tomasz Figa
Hi, On Thursday 07 of November 2013 12:12:47 Vyacheslav Tyrtov wrote: > From: Tarek Dakhran > > The EXYNOS5410 clocks are statically listed and registered > using the Samsung specific common clock helper functions. Thanks for keeping up with addressing the comments. However there are still few

Re: [PATCH v3 4/4] ARM: dts: Add initial device tree support for EXYNOS5410

2013-11-10 Thread Tomasz Figa
Hi, Please see my comments inline. On Thursday 07 of November 2013 12:12:49 Vyacheslav Tyrtov wrote: > From: Tarek Dakhran > > Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board. > > Signed-off-by: Tarek Dakhran > Signed-off-by: Vyacheslav Tyrtov > --- > arch/arm/boot/dts/M

Re: [PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq

2013-11-10 Thread Tomasz Figa
Hi Chanwoo, Please add a patch description. Even if trivial, it is good to have one. On Monday 04 of November 2013 10:55:59 Chanwoo Choi wrote: > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos4212.dtsi | 6 ++ > 1 file changed, 6 insertions(+) >

Re: [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer

2013-11-10 Thread Tomasz Figa
Hi Chanwoo, Marek, On Monday 04 of November 2013 10:56:00 Chanwoo Choi wrote: > From: Marek Szyprowski > No patch description? > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos4212.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCHv3 3/3] ARM: dts: exynos4x12: Add gps_alive power domain for exynos4x12

2013-11-10 Thread Tomasz Figa
Hi Chanwoo, On Monday 04 of November 2013 10:56:01 Chanwoo Choi wrote: > This patch gps_alive power domain to exynos4x12.dtsi. Patch description lacks rationale behind the change. > > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos4x12.dtsi | 5 +++

Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs

2013-11-11 Thread Tomasz Figa
On Monday 11 of November 2013 12:33:20 Stephen Warren wrote: > On 11/11/2013 12:17 PM, Gerlando Falauto wrote: > > Hi Stephan, > > > > On 11/11/2013 07:53 PM, Stephen Warren wrote: > >> On 11/11/2013 11:28 AM, Gerlando Falauto wrote: > >>> Hi everyone, > >>> > >>> [jumping in on an old discussion]

Re: [PATCH] clk: s3c64xx: Correct spi bus clock hookups

2013-10-15 Thread Tomasz Figa
Hi Charles, On Tuesday 15 of October 2013 13:26:22 Charles Keepax wrote: > Correct the SPI bus clock hookups to match their state before the switch > to this driver. With out this patch my system (based on an s3c6410) > can't locate any spibus clock. That's right, a patch like this is needed inde

Re: [PATCH] clk: s3c64xx: Correct spi bus clock hookups

2013-10-16 Thread Tomasz Figa
On Wednesday 16 of October 2013 09:10:35 Charles Keepax wrote: > + samsung soc mailing list > > On Wed, Oct 16, 2013 at 12:52:42AM +0200, Tomasz Figa wrote: > > Hi Charles, > > > > On Tuesday 15 of October 2013 13:26:22 Charles Keepax wrote: > > > ALIAS(SCL

<    3   4   5   6   7   8   9   10   11   12   >