[PATCH 13/18] ARM: s3c64xx: clock: Add clkdev lookup for DMA clocks

2013-08-11 Thread Tomasz Figa
This patch adds clkdev lookup entries for clocks used by PL08x DMA driver. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/clock.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx

[PATCH 10/18] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX

2013-08-11 Thread Tomasz Figa
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa Acked-by: Linus Walleij --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b

[PATCH 06/18] dmaengine: PL08x: Add support for different maximum transfer size

2013-08-11 Thread Tomasz Figa
transfer sizes fitting the original bitfield of PL080, but now would overwrite other fields. Signed-off-by: Tomasz Figa Reviewed-by: Linus Walleij Acked by: Vinod Koul --- drivers/dma/amba-pl08x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/dma/amba-pl08x.c b

[PATCH 18/18] ASoC: Samsung: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Tomasz Figa
The legacy S3C64xx DMA driver has been removed, DMA support on S3C64xx is provided only by the generic PL08x driver. This patch modifies the Kconfig entry of Samsung ASoC subsystem, which relies on availability of DMA, to always select the S3C64XX_PL080 symbol. Signed-off-by: Tomasz Figa

[PATCH 16/18] clk: samsung: s3c64xx: Remove clock aliases of old DMA driver

2013-08-11 Thread Tomasz Figa
Since the old DMA driver got removed, these aliases are no longer necessary. Signed-off-by: Tomasz Figa --- drivers/clk/samsung/clk-s3c64xx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/samsung/clk-s3c64xx.c b/drivers/clk/samsung/clk-s3c64xx.c index 79ee9a6..dd47a83 100644

[PATCH 15/18] ARM: s3c64xx: Remove legacy DMA driver

2013-08-11 Thread Tomasz Figa
Since support for generic PL08x DMA engine driver has been added, there is no need to keep the old legacy driver, so this patch removes it. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/Kconfig| 5 - arch/arm/mach-s3c64xx/Makefile | 1 - arch/arm/mach-s3c64xx

[PATCH 12/18] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-08-11 Thread Tomasz Figa
through DMA resource, casted to unsigned long, but this is how Samsung DMA wrappers (used to support both s3c-dma and DMA engine in drivers) are designed. Signed-off-by: Tomasz Figa --- arch/arm/Kconfig | 1 + arch/arm/mach-s3c64xx/Kconfig| 8 +- arch/arm

[PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Tomasz Figa
The legacy S3C64xx DMA driver has been removed, DMA support on S3C64xx is provided only by the generic PL08x driver. This patch modifies the Kconfig entry of spi-s3c64xx driver, which relies on availability of DMA, to always select the S3C64XX_PL080 symbol. Signed-off-by: Tomasz Figa

[PATCH 11/18] ASoC: Samsung: Do not require legacy DMA API in case of S3C64XX

2013-08-11 Thread Tomasz Figa
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa Acked-by: Linus Walleij --- sound/soc/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung

[PATCH 14/18] clk: samsung: s3c64xx: Add aliases for DMA clocks

2013-08-11 Thread Tomasz Figa
This patch adds clkdev aliases for clocks used by PL08x DMA driver. Signed-off-by: Tomasz Figa --- drivers/clk/samsung/clk-s3c64xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/samsung/clk-s3c64xx.c b/drivers/clk/samsung/clk-s3c64xx.c index eeda567..79ee9a6 100644 --- a

[PATCH 08/18] dmaengine: PL08x: Add cyclic transfer support

2013-08-11 Thread Tomasz Figa
.] Signed-off-by: Tomasz Figa Acked-by: Linus Walleij --- drivers/dma/amba-pl08x.c | 147 +-- 1 file changed, 118 insertions(+), 29 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 6b9cba2..cd29434 100644 --- a/drivers

[PATCH 09/18] ASoC: Samsung: Do not queue cyclic buffers multiple times

2013-08-11 Thread Tomasz Figa
offset. This patch fixes this problem by making the legacy S3C-DMA API use the same semantics as DMA engine (the whole cyclic buffer is enqueued at once) and modifying users of Samsung DMA wrappers in cyclic mode to behave appropriately. Signed-off-by: Tomasz Figa Acked-by: Linus Walleij --- arch

[PATCH 07/18] dmaengine: PL08x: Fix reading the byte count in cctl

2013-08-11 Thread Tomasz Figa
From: Alban Bedel There are more fields than just SWIDTH in CH_CONTROL register, so read register value must be masked in addition to shifting. Signed-off-by: Alban Bedel Signed-off-by: Tomasz Figa Reviewed-by: Linus Walleij --- drivers/dma/amba-pl08x.c | 4 1 file changed, 4

[PATCH 05/18] dmaengine: PL08x: Add support for PL080S variant

2013-08-11 Thread Tomasz Figa
PL080S is a modified version of PL080 that can be found on Samsung SoCs, such as S3C6400 and S3C6410. It has different offset of CONFIG register, separate CONTROL1 register that holds transfer size and larger maximum transfer size. Signed-off-by: Tomasz Figa Acked-by: Linus Walleij

[PATCH 04/18] dmaengine: PL08x: Move LLI dumping code into separate function

2013-08-11 Thread Tomasz Figa
-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index d3399c2..1fa05d6 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba

[PATCH 03/18] dmaengine: PL08x: Rework LLI handling to be less fragile

2013-08-11 Thread Tomasz Figa
-bit words, which is just filled with appropriate values in appropriate order and padded with required amount of dummy words (currently zero, but PL080S will make better use of this). Suggested-by: Linus Walleij Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 147

[PATCH 01/18] dmaengine: PL08x: Refactor pl08x_getbytes_chan() to lower indentation

2013-08-11 Thread Tomasz Figa
wherever possible. Signed-off-by: Tomasz Figa Reviewed-by: Linus Walleij --- drivers/dma/amba-pl08x.c | 53 ++-- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 06fe45c..6a12392

[PATCH 00/18] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-08-11 Thread Tomasz Figa
n't suspect any problems. On S3C64xx-based Mini6410 and SMDK6410 boards, with I2S audio playback and capture (including full duplex operation) and also SPI using spidev: Tested-by: Tomasz Figa Changes since RFC v2: - Added clkdev lookups to old clock driver. - Added patches removing the ol

[PATCH 02/18] dmaengine: PL08x: Add support for different offset of CONFIG register

2013-08-11 Thread Tomasz Figa
Some variants of PL08x (namely PL080S, found in Samsung S3C64xx SoCs) have CONFIG register at different offset. This patch makes the driver use offset from vendor data struct. Signed-off-by: Tomasz Figa Reviewed-by: Linus Walleij Acked-by: Vinod Koul --- drivers/dma/amba-pl08x.c | 30

Re: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled

2013-08-11 Thread Tomasz Figa
Hi Mark, On Sunday 11 of August 2013 20:11:40 Mark Brown wrote: > On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote: > > @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ > > > > config SPI_S3C64XX > > > > tristate "Samsung S3C64XX series type

Re: [PATCH 10/18] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX

2013-08-12 Thread Tomasz Figa
On Tuesday 13 of August 2013 00:36:41 Mark Brown wrote: > On Sun, Aug 11, 2013 at 07:59:22PM +0200, Tomasz Figa wrote: > > With support for amba-pl08x driver, on S3C64xx the generic DMA engine > > API can be used instead of the private s3c-dma interface. > > I'm still g

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote: > >>> IMHO we need a lookup method for PHYs, just like for clocks, > >>

Re: [PATCH 12/18] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 18:52:51 Mark Brown wrote: > On Sun, Aug 11, 2013 at 07:59:24PM +0200, Tomasz Figa wrote: > > +#define pl330_filter pl08x_filter_id > > So, this is pretty fun and probably not going to play too nicely for > multiplatform kernels... Yes, this is rea

Re: [PATCH 10/18] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 21:18:16 Mark Brown wrote: > On Tue, Aug 13, 2013 at 07:55:47PM +0100, Mark Brown wrote: > > I'm still debugging what's going on here - the basic refcounting all > > looks OK in the SPI driver, I can see it requesting and releasing with > > the refcounts all going back

Re: [PATCH 12/18] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 21:35:36 Mark Brown wrote: > On Tue, Aug 13, 2013 at 01:10:02PM -0700, Tomasz Figa wrote: > > On Tuesday 13 of August 2013 18:52:51 Mark Brown wrote: > > > On Sun, Aug 11, 2013 at 07:59:24PM +0200, Tomasz Figa wrote: > > > > +#defin

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Tomasz Figa
On Wednesday 14 of August 2013 00:19:28 Sylwester Nawrocki wrote: > W dniu 2013-08-13 14:05, Kishon Vijay Abraham I pisze: > > On Tuesday 13 August 2013 05:07 PM, Tomasz Figa wrote: > >> On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: > >>> On W

Re: [PATCH] usb: gadget: s3c2410: fix clk resource leak and update

2013-05-11 Thread Tomasz Figa
Hi Libo, On Saturday 11 of May 2013 14:28:15 Libo Chen wrote: > From: Libo Chen The patch subject is slightly misleading. It suggests that the patch only changes clock handling, but in fact the biggest part of the patch is conversion to devm_ helpers. I think following subject would suit this

Re: [PATCH] usb: phy: samsung: adding usbphy for Exynos4X12

2013-05-13 Thread Tomasz Figa
Hi Vivek, On Tuesday 14 of May 2013 01:10:32 Vivek Gautam wrote: > Hi Dongjin, > > On Mon, May 13, 2013 at 11:55 PM, Dongjin Kim wrote: > > This patch adds usb host phy (USB 2.0 PHY) support for Samsung > > Exynos4X12 SoC. New functions, > > samsung_exynos4x12_usb2phy_enable/_disable and select

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-14 Thread Tomasz Figa
I guess you might not be working on s3c64xx? Well, I still hope that someone will pick up the work on adapting PL08x driver to support PL080s of S3C64xx as well, but most likely it will end up with me doing it, as a part of DT support for S3C64xx. Best regards, -- Tomasz Figa Sa

Re: [PATCH] clk: Fix race condition between clk_set_parent and clk_enable()

2013-05-14 Thread Tomasz Figa
Hi, On Tuesday 14 of May 2013 11:54:17 Mike Turquette wrote: > Quoting Saravana Kannan (2013-04-30 21:42:08) > > > Without this patch, the following race conditions are possible. > > > > Race condition 1: > > * clk-A has two parents - clk-X and clk-Y. > > * All three are disabled and clk-X is cu

Re: [PATCH] clk: Fix race condition between clk_set_parent and clk_enable()

2013-05-14 Thread Tomasz Figa
On Tuesday 14 of May 2013 15:46:33 Saravana Kannan wrote: > On 05/14/2013 03:10 PM, Tomasz Figa wrote: > > Hi, > > > > On Tuesday 14 of May 2013 11:54:17 Mike Turquette wrote: > >> Quoting Saravana Kannan (2013-04-30 21:42:08) > >> > >>> Wi

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Tomasz Figa
On Wednesday 15 of May 2013 23:48:31 Heiko Stübner wrote: > Am Mittwoch, 15. Mai 2013, 23:20:08 schrieb Sylwester Nawrocki: > > On 05/15/2013 10:31 PM, Heiko Stübner wrote: > > >>> + BUG(); > > >>> > > >> > Isn't that a bit nasty. This macro should be used with care and > > >> > we > > >>

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Tomasz Figa
On Thursday 16 of May 2013 00:45:03 Heiko Stübner wrote: > Am Donnerstag, 16. Mai 2013, 00:02:40 schrieb Tomasz Figa: > > On Wednesday 15 of May 2013 23:48:31 Heiko Stübner wrote: > > > Am Mittwoch, 15. Mai 2013, 23:20:08 schrieb Sylwester Nawrocki: > > > > On 05/1

Re: [PATCH] ARM: dts: fix bad merge of display timing node to exynos5250-smdk5250.dts

2013-04-08 Thread Tomasz Figa
Hi Doug, On Monday 08 of April 2013 12:21:32 Doug Anderson wrote: > Kukjin, > > On Mon, Apr 8, 2013 at 11:29 AM, Kukjin Kim wrote: > > BTW, if any problems on current for-next, please kindly let me know. > > I usually try to check linux-next at least once a week, but sometimes > it's more or le

Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory

2013-05-07 Thread Tomasz Figa
nfig" > > +endmenu > > + > > sorry I know few about arm, > could you tell me the difference between > CONFIG_ARCH_EXYNOS4/CONFIG_ARCH_EXYNOS5 and CONFIG_PLAT_SAMSUNG please, > I do not see the dependency between these in Kconfig file? If those files were kept at t

Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory

2013-05-07 Thread Tomasz Figa
On Tuesday 07 of May 2013 18:48:46 amit daniel kachhap wrote: > Hi Tomasz Figa, > > On Tue, May 7, 2013 at 3:51 PM, Tomasz Figa wrote: > > On Monday 06 of May 2013 23:05:06 Zhang Rui wrote: > >> On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > >>

Re: [PATCH] ARM: exynos: Select PINCTRL_EXYNOS for exynos5

2013-05-09 Thread Tomasz Figa
nctrl. AFAIK, Exynos5440 contains a completely different pin controller block, which is not compatible with pinctrl-samsung driver, so I don't see any point of moving it under PINCTRL_EXYNOS, which is currently used for Exynos 4210, 4x12 and 5250, but will be also extended with driver data fo

Re: [PATCH 17/30] pwm: samsung: repair the worst MMIO abuses

2013-04-12 Thread Tomasz Figa
dereference that. Fixing > > the platform code is much harder, so we'll leave that > > until we have a DT binding for pwm-samsung, which may require > > other changes in this area. Since we are already touching > > every MMIO accessor in this driver, let's also use

Re: [PATCH 0/3] regulator: max8998: Add support for Device Tree

2013-04-15 Thread Tomasz Figa
Hi Mark, On Thursday 04 of April 2013 18:19:20 Tomasz Figa wrote: > This series adds Device Tree support to max8998 MFD driver. > > First patch reworks max8998-irq driver to use IRQ domains. Second patch > prepares platform data structure to ease generating it at runtime from > d

Re: [PATCH 1/2] pinctrl: samsung: fix suspend/resume functionality

2013-05-16 Thread Tomasz Figa
Hi Doug, Thanks for the patch. See my comments inline. On Thursday 16 of May 2013 10:12:31 Doug Anderson wrote: > The GPIO states need to be restored after s2r and this is not currently > supported in the pinctrl driver. This patch saves the gpio states before > suspend and restores them after re

Re: [PATCH 2/2] pinctrl: exynos: fix eint wakeup by using irq_set_wake()

2013-05-16 Thread Tomasz Figa
On Thursday 16 of May 2013 10:12:32 Doug Anderson wrote: > From: Prathyush K > > Add the irq_set_wake function for exynos pinctrl to configure the > external interrupt wakeup mask register. > > [dianders: minor nit fixes; port to ToT] > > Signed-off-by: Prathyush K > Signed-off-by: Doug Anders

Re: [PATCH 1/2] pinctrl: samsung: fix suspend/resume functionality

2013-05-16 Thread Tomasz Figa
On Thursday 16 of May 2013 13:32:48 Doug Anderson wrote: > Tomasz, > > Thanks for the review! I'll get a new patch out either today or > tomorrow... OK. I will be fine to go with your patches, after addressing the comments. In the end it's good that you posted them, as reviewing them allowed me

Re: [PATCH 1/2] pinctrl: samsung: fix suspend/resume functionality

2013-05-16 Thread Tomasz Figa
On Thursday 16 of May 2013 14:51:53 Doug Anderson wrote: > Tomasz, > > On Thu, May 16, 2013 at 2:27 PM, Tomasz Figa wrote: > > OK. I will be fine to go with your patches, after addressing the > > comments. In the end it's good that you posted them, as reviewing > &

Re: [PATCH 2/2] pinctrl: exynos: fix eint wakeup by using irq_set_wake()

2013-05-16 Thread Tomasz Figa
On Thursday 16 of May 2013 15:25:15 Doug Anderson wrote: > Tomasz, > > On Thu, May 16, 2013 at 12:26 PM, Tomasz Figa wrote: > > On Thursday 16 of May 2013 10:12:32 Doug Anderson wrote: > >> From: Prathyush K > >> > >> Add the irq_set_wake fu

Re: [PATCH 1/2] pinctrl: samsung: fix suspend/resume functionality

2013-05-16 Thread Tomasz Figa
On Friday 17 of May 2013 00:30:38 Heiko Stübner wrote: > Am Freitag, 17. Mai 2013, 00:08:34 schrieb Tomasz Figa: > > On Thursday 16 of May 2013 14:51:53 Doug Anderson wrote: > > > Tomasz, > > > > > > On Thu, May 16, 2013 at 2:27 PM, Tomasz Figa > > &

Re: [PATCH v3] pinctrl: samsung: fix suspend/resume functionality

2013-05-17 Thread Tomasz Figa
ctrl/pinctrl-samsung.h | > 5 ++ > 2 files changed, 153 insertions(+) On Exynos4210-based Trats board: Tested-by: Tomasz Figa Acked-by: Tomasz Figa I will send several complementary patches in a while. Best regards, -- Tomasz Figa Linux Kernel Developer Samsung R&D Institute

[PATCH] of: irq: Pass trigger type in IRQ resource flags

2013-05-18 Thread Tomasz Figa
problem, based on the fact that irq_of_parse_and_map() configures the trigger based on DT interrupt specifier, IRQD_TRIGGER_* flags are consistent with IORESOURCE_IRQ_*, and we can get trigger type by calling irqd_get_trigger_type() after mapping the interrupt. Signed-off-by: Tomasz Figa --- drivers/of

Re: [PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver

2013-05-25 Thread Tomasz Figa
Hi Maxime, Overall the driver looks good, just some minor nitpicks inline. On Friday 03 of May 2013 11:17:45 Maxime Ripard wrote: > This patch implements a basic driver for the I2C host driver found on > the Allwinner A10, A13 and A31 SoCs. > > Notable missing feature is 10-bit addressing. > >

Re: [PATCH 0/3] regulator: max8997: minor updates and device tree support

2012-11-23 Thread Tomasz Figa
ate mode 100644 > Documentation/devicetree/bindings/regulator/max8997-regulator.txt > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-samsung-soc" in the body of a message to > majord...@vger.kernel.org > More majordomo info at http://vger.

Re: [PATCH 0/3] pinctrl: exynos: add support for Samsung's Exynos5250

2012-12-14 Thread Tomasz Figa
" in the body of a message to > majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Looks good. For the whole series: Reviewed-by: Tomasz Figa Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Plat

Re: [PATCH] gpio: samsung: remove exynos_gpio_cfg

2012-12-14 Thread Tomasz Figa
gacy GPIO support useless, I think there is no need to extend it. Instead existing boards should be made to use the pinctrl driver. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 4/4] ODROID-X: dts: Add mshc node for ODROID-X board

2012-12-17 Thread Tomasz Figa
amp;gpk0 5 3>, <&gpk0 6 3>, > + <&gpk1 3 4>, <&gpk1 4 4>, > + <&gpk1 5 4>, <&gpk1 6 4>; What is the gpios property for in this node? Pin configuration using legacy GPIO bindings is not sup

Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-01-15 Thread Tomasz Figa
Hi Vivek, On Tuesday 15 of January 2013 19:08:30 Vivek Gautam wrote: > Adding OHCI device tree node for Exynos5250 along with > the device base address. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > Acked-by: Grant Likely > --- > .../devicetree/bindings/usb/exynos-usb.txt |

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-15 Thread Tomasz Figa
Hi Vivek, Don't you need also some clkdev lookup entry to make the clock available in the driver? Best regards, Tomasz On Tuesday 15 of January 2013 19:08:31 Vivek Gautam wrote: > Adding necessary device clock to exynos5 needed for > the DWC3 controller. > > Signed-off-by: Vivek Gautam > ---

Re: [PATCH v4 4/4] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-01-15 Thread Tomasz Figa
Hi Vivek, Same comment as for patch 2. Best regards, Tomasz On Tuesday 15 of January 2013 19:08:32 Vivek Gautam wrote: > Adding DWC3 device tree node for Exynos5250 needed to > parse device tree data. > Also enabling XHCI support on exynos5250. > > Signed-off-by: Vivek Gautam > --- > .../devi

Re: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-01-15 Thread Tomasz Figa
Hi Vivek, Same comment as for patch 2. Best regards, Tomasz On Wednesday 16 of January 2013 11:15:43 Vivek Gautam wrote: > Adding EHCI device tree node for Exynos5250 along with > the device base adress and gpio line for vbus. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > Acked-by:

Re: [PATCH v2 3/7] pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank

2016-09-19 Thread Tomasz Figa
Hi Chanwoo, Sorry for late reply. Yours was quick compared to mine. ;( 2016-09-05 17:08 GMT+09:00 Chanwoo Choi : > Hi Tomasz, > > I'm sorry for late reply. > > On 2016년 08월 25일 23:41, Tomasz Figa wrote: >> 2016-08-25 23:30 GMT+09:00 Tomasz Figa : >>&

Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for SPI3 related clocks

2016-06-20 Thread Tomasz Figa
2016-06-20 14:41 GMT+09:00 Andi Shyti : > Hi Tomasz, > >> >> > The SPI 3 bus uses two clocks, a bus clock and an input clock. >> >> > Do not disable the clocks when unused in order to allow access to >> >> > the SPI 3 device. >> >> >> >> If unused, why would access to SPI 3 device needed? >> > >> >

[PATCH] drm/rockchip: Finish initialization before registering DRM device

2016-06-20 Thread Tomasz Figa
the, now unnecessary, call to drm_connector_register_all() from driver code. Fixes: f706974a69b6 ("drm/rockchip: Drop drm_driver.load/unload callbacks") Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 18 +++--- 1 file changed, 7 inserti

[PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64

2016-06-20 Thread Tomasz Figa
rk_iommu_ops iommu/rockchip: Enable Rockchip IOMMU on ARM64 Tomasz Figa (1): drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 ++-- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 + drivers/gpu/drm/rockchip

[PATCH v4 6/8] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

2016-06-20 Thread Tomasz Figa
not introduce any functional changes until the driver is made to attach subdevices into an IOMMU domain with the generic IOMMU API, which will happen in following patch. Based heavily on GEM implementation of Tegra DRM driver. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip

[PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe

2016-06-20 Thread Tomasz Figa
econstruct to support multi slaves") Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 53fa0d9..8a5ba

[PATCH v4 5/8] iommu/rockchip: Prepare to support generic DMA mapping

2016-06-20 Thread Tomasz Figa
From: Shunqian Zheng Set geometry for allocated domains and fix .domain_alloc() callback to work with IOMMU_DOMAIN_DMA domain type, which is used for implicit domains on ARM64. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 16

[PATCH v4 2/8] iommu/rockchip: Add map_sg callback for rk_iommu_ops

2016-06-20 Thread Tomasz Figa
-review.googlesource.com/346326 Reviewed-by: Douglas Anderson Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 5a9659a..53fa0d9 100644 --- a/drivers/iommu/rockchip-iommu.c +++ b

[PATCH v4 7/8] drm/rockchip: Use common IOMMU API to attach devices

2016-06-20 Thread Tomasz Figa
anymore and this patch wires things to use the new method. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 +++- 1 file changed, 53 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/rockchip

[PATCH v4 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64

2016-06-20 Thread Tomasz Figa
From: Simon Xue This patch makes it possible to compile the rockchip-iommu driver on ARM64, so that it can be used with 64-bit SoCs equipped with this type of IOMMU. Signed-off-by: Simon Xue Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/Kconfig | 2 +- 1 file

[PATCH v4 1/8] iommu/rockchip: Fix devm_{request,free}_irq parameter

2016-06-20 Thread Tomasz Figa
ff-by: Simon Xue Signed-off-by: Shunqian Zheng Reviewed-on: https://chromium-review.googlesource.com/346325 Reviewed-by: Douglas Anderson Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/rockchip-iomm

[PATCH v4 4/8] iommu/rockchip: Use DMA API to manage coherency

2016-06-20 Thread Tomasz Figa
, a simple platform device is registered for each allocated IOMMU domain. With this patch, this driver can be used on both ARM and ARM64 platforms, such as RK3288 and RK3399 respectively. Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa --- drivers/iommu/rockchip-iommu.c | 161

Re: [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64

2016-06-21 Thread Tomasz Figa
Hi Joerg, On Tue, Jun 21, 2016 at 6:17 PM, Joerg Roedel wrote: > > On Tue, Jun 21, 2016 at 01:34:33PM +0900, Tomasz Figa wrote: > > This series intends mostly to enable support for ARM64 architecture > > in the rockchip-iommu driver. On the way to do so, some bugs are also >

[PATCH 1/8] drm/rockchip: Clear interrupt status bits before enabling

2016-09-14 Thread Tomasz Figa
interrupt signalled, we have to clear the old bit before we update the enable register. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip

[PATCH 2/8] drm/rockchip: Get rid of some unnecessary code

2016-09-14 Thread Tomasz Figa
Current code implements prepare_fb and cleanup_fb callbacks only to grab/release fb references, which is already done by atomic framework when creating/destryoing plane state. Let's remove these unused bits. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c

[PATCH 0/8] drm/rockchip: Flip wait clean-up

2016-09-14 Thread Tomasz Figa
-next branch of Sean Paul's dogwood tree: https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=for-next git://people.freedesktop.org/~seanpaul/dogwood Tomasz Figa (8): drm/rockchip: Clear interrupt status bits before enabling drm/rockchip: Get rid of some unnecessary code drm/rockchip:

[PATCH 5/8] drm/rockchip: Replace custom wait_for_vblanks with helper

2016-09-14 Thread Tomasz Figa
pport unreferencing cursor framebuffers asynchronously to the commit, which was what the helper expected. Since both problems have been solved by previous patches, we can now make the driver use the generic helper and remove custom waiting code. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/roc

[PATCH 8/8] drm/rockchip: Kill vop_plane_state

2016-09-14 Thread Tomasz Figa
After changes introduced by last patches, there is no useful data stored in vop_plane_state struct. Let's remove it and make the driver use generic plane state alone. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 94 + 1 file ch

[PATCH 3/8] drm/rockchip: Avoid race with vblank count increment

2016-09-14 Thread Tomasz Figa
hould be relatively low and in practice almost equal to the vop hardirq handler running time. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 34 + 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b

[PATCH 7/8] drm/rockchip: Always signal event in next vblank after cfg_done

2016-09-14 Thread Tomasz Figa
complete FB changes before) and lets us remove the manual window update check. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 54 ++--- 1 file changed, 10 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b

[PATCH 4/8] drm/rockchip: Unreference framebuffers from flip work

2016-09-14 Thread Tomasz Figa
code to unreference any changed framebuffer from a flip work. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip

[PATCH 6/8] drm/rockchip: Do not enable vblank without event

2016-09-14 Thread Tomasz Figa
("drm/rockchip: Enable vblank without event"). Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/roc

Re: [PATCH v2 3/7] pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank

2016-08-25 Thread Tomasz Figa
Hi Chanwoo, 2016-08-24 22:49 GMT+09:00 Chanwoo Choi : > This patch supports the multiple IORESOURCE_MEM resources for one pin-bank. > In the pre-existing Exynos series, the registers of the gpio bank are included > in the one memory map. But, some gpio bank need to support the one more memory > ma

Re: [PATCH v2 4/7] pinctrl: samsung: Add GPF support for Exynos5433

2016-08-25 Thread Tomasz Figa
Hi Chanwoo, Joonyoung, 2016-08-24 22:49 GMT+09:00 Chanwoo Choi : > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > index 37bc692445d4..499fb3484915 100644 > --- a/Documentation/devicetree/bindings/pinct

Re: [PATCH v2 3/7] pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank

2016-08-25 Thread Tomasz Figa
2016-08-25 23:30 GMT+09:00 Tomasz Figa : >> + } >> + >> +#define EXYNOS_PIN_BANK_EINTN_EXT(pins, reg, id, pctl_idx, eint_idx) \ >> + { \ >> + .type = &bank_type_off, \ >&g

Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section

2016-08-25 Thread Tomasz Figa
2016-08-25 16:28 GMT+09:00 Chanwoo Choi : > Hi Stephen, > > On 2016년 08월 25일 09:11, Stephen Boyd wrote: >> On 08/24, Chanwoo Choi wrote: >>> On 2016년 08월 24일 13:43, Stephen Boyd wrote: On 08/23, Sylwester Nawrocki wrote: > So the saving is rather insignificant but the patch doesn't make >>

Re: [PATCH v3] genirq: Check irq disabled & masked states in irq_shutdown

2017-05-27 Thread Tomasz Figa
Hi Thomas, Thank you for your comments. Please see my replies inline. On Sat, May 27, 2017 at 8:12 PM, Thomas Gleixner wrote: > On Sat, 27 May 2017, Jeffy Chen wrote: > >> If a irq is already disabled, irq_shutdown may try to disable it again, >> for example: >> devm_request_irq->irq_startup->ir

Re: [RFC PATCH 0/9] V4L2 Jobs API WIP

2017-10-25 Thread Tomasz Figa
Hi Sakari, On Thu, Oct 19, 2017 at 11:43 PM, Sakari Ailus wrote: > Hi Alexandre, > > On Thu, Sep 28, 2017 at 06:50:18PM +0900, Alexandre Courbot wrote: >> Hi everyone, >> [snip] > > Still it shouldn't be forgotten that if the framework is geared towards > helping drivers "running one job at a tim

Re: [RFC PATCH 0/9] V4L2 Jobs API WIP

2017-10-25 Thread Tomasz Figa
Hi Laurent, On Thu, Oct 26, 2017 at 12:48 AM, Laurent Pinchart wrote: > Hello, > > On Monday, 23 October 2017 11:45:01 EEST Alexandre Courbot wrote: >> On Thu, Oct 19, 2017 at 11:43 PM, Sakari Ailus wrote: >> > On Thu, Sep 28, 2017 at 06:50:18PM +0900, Alexandre Courbot wrote: [snip] >> > Both r

[PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2015-10-15 Thread Tomasz Figa
uffers might be still in processing. Signed-off-by: John Sheu Reviewed-by: Pawel Osciak Reviewed-by: Tomasz Figa Signed-off-by: Tomasz Figa --- drivers/media/v4l2-core/videobuf2-core.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-co

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-08-07 Thread Tomasz Figa
On Mon, Jul 30, 2018 at 9:52 PM Hans Verkuil wrote: > > On 07/24/2018 04:06 PM, Tomasz Figa wrote: > > Due to complexity of the video decoding process, the V4L2 drivers of > > stateful decoder hardware require specific sequences of V4L2 API calls > > to be followed.

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-08-26 Thread Tomasz Figa
Hi Philipp, On Tue, Aug 21, 2018 at 12:34 AM Philipp Zabel wrote: > > On Mon, 2018-08-20 at 23:27 +0900, Tomasz Figa wrote: > [...] > > +3. Start queuing buffers to ``OUTPUT`` queue containing stream data after > > > > > > + the seek until

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-08-26 Thread Tomasz Figa
On Tue, Aug 21, 2018 at 8:29 PM Stanimir Varbanov wrote: > > Hi Tomasz, > > On 08/08/2018 05:55 AM, Tomasz Figa wrote: > > On Tue, Aug 7, 2018 at 4:37 PM Hans Verkuil wrote: > > >>>>>>> +7. If all the following conditions are met, the client may

Re: [PATCH 1/9] CHROMIUM: v4l: Add H264 low-level decoder API compound controls.

2018-08-22 Thread Tomasz Figa
Pawel Osciak > > > Reviewed-by: Wu-cheng Li > > > Tested-by: Tomasz Figa > > > [rebase44(groeck): include linux/types.h in v4l2-controls.h] > > > Signed-off-by: Guenter Roeck > > > Signed-off-by: Maxime Ripard > > > --- > > > > > [..]

Re: [RFT 00/10] pinctrl: samsung: Remove ugly hack for sharing eint_wakeup_mask

2018-07-20 Thread Tomasz Figa
drivers/pinctrl/samsung/pinctrl-samsung.h | 11 +++ > include/linux/soc/samsung/exynos-regs-pmu.h| 8 ++- > 10 files changed, 136 insertions(+), 25 deletions(-) Looking through the series, the idea seems to be very reasonable, so: Acked-by: Tomasz Figa Thanks for cleaning this up! Best regards, Tomasz

Re: [PATCH v13 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-24 Thread Tomasz Figa
off in a system sleep. > > Also add corresponding clock enable path in resume callback. > > > > Signed-off-by: Sricharan R > > Signed-off-by: Archit Taneja > > [vivek: rework for clock and pm ops] > > Signed-off-by: Vivek Gautam > > Reviewed-by: Toma

Re: [PATCH 0/2] Document memory-to-memory video codec interfaces

2018-07-25 Thread Tomasz Figa
Hi Philipp, On Wed, Jul 25, 2018 at 10:28 PM Philipp Zabel wrote: > > Hi Tomasz, > > On Tue, 2018-07-24 at 23:06 +0900, Tomasz Figa wrote: > > This series attempts to add the documentation of what was discussed > > during Media Workshops at LinuxCon Europe 2012 in Barc

Re: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

2018-01-24 Thread Tomasz Figa
On Mon, Jan 22, 2018 at 1:09 PM, JeffyChen wrote: > Hi Randy, > > > On 01/22/2018 10:15 AM, JeffyChen wrote: >> >> Hi Randy, >> >> On 01/22/2018 09:18 AM, Randy Li wrote: >>> Also the power domain driver could manage the clocks as well, I would >>> suggest to use pm_runtime_*. >> >> >> a

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

2018-01-30 Thread Tomasz Figa
Hi Rob, On Wed, Jan 31, 2018 at 2:05 AM, Rob Herring wrote: > On Wed, Jan 24, 2018 at 06:35:11PM +0800, Jeffy Chen wrote: >> From: Tomasz Figa >> >> Current code relies on master driver enabling necessary clocks before >> IOMMU is accessed, however there are cas

Re: [RFC PATCH 0/8] [media] Request API, take three

2018-01-31 Thread Tomasz Figa
Hi Hans, Sorry for joining the party late. On Wed, Jan 31, 2018 at 4:50 PM, Hans Verkuil wrote: > On 01/30/2018 07:31 AM, Alexandre Courbot wrote: >> Hi Hans, >> >> On Mon, Jan 29, 2018 at 8:21 PM, Hans Verkuil wrote: >>> On 01/26/2018 07:02 AM, Alexandre Courbot wrote: Howdy. Here is your

Re: [RFC PATCH 0/8] [media] Request API, take three

2018-01-31 Thread Tomasz Figa
On Wed, Jan 31, 2018 at 5:47 PM, Hans Verkuil wrote: > On 01/31/2018 09:10 AM, Tomasz Figa wrote: >> Hi Hans, >> >> Sorry for joining the party late. >> >> On Wed, Jan 31, 2018 at 4:50 PM, Hans Verkuil wrote: >>> On 01/30/2018 07:31 AM, Alexandre Cou

Re: [PATCH v4 07/13] ARM: dts: rockchip: add clocks in vop iommu nodes

2018-01-18 Thread Tomasz Figa
On Thu, Jan 18, 2018 at 8:52 PM, Jeffy Chen wrote: > Add clocks in vop iommu nodes, since we are going to control clocks in > rockchip iommu driver. > > Signed-off-by: Jeffy Chen > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/rk3036.dtsi | 2 ++ >

Re: [PATCH v4 12/13] iommu/rockchip: Add runtime PM support

2018-01-18 Thread Tomasz Figa
On Thu, Jan 18, 2018 at 8:52 PM, Jeffy Chen wrote: > When the power domain is powered off, the IOMMU cannot be accessed and > register programming must be deferred until the power domain becomes > enabled. > > Add runtime PM support, and use runtime PM device link from IOMMU to > master to startup

Re: [PATCH v4 07/13] ARM: dts: rockchip: add clocks in vop iommu nodes

2018-01-18 Thread Tomasz Figa
On Fri, Jan 19, 2018 at 1:55 PM, JeffyChen wrote: > Hi Tomasz, > > Thanks for your reply. > > > On 01/19/2018 11:23 AM, Tomasz Figa wrote: >> >> On Thu, Jan 18, 2018 at 8:52 PM, Jeffy Chen >> wrote: >>> >>> Add clocks in vop iommu nodes, sinc

<    1   2   3   4   5   6   7   8   9   10   >