Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-08 Thread Tomasz Figa
On Monday 08 of October 2012 12:04:18 Thomas Abraham wrote: > Hi Tomasz, > > On 3 October 2012 19:40, Tomasz Figa wrote: > > Hi Chander, Thomas, > > > > I can see one more problem here. > > > > Based on the fact that sdhci-s3c driver receives only the e

Re: [PATCH v5 2/2] regulator: add device tree support for max8997

2012-10-09 Thread Tomasz Figa
ging this patch? It is a dependency of Samsung Trats board device tree support. Best regards, -- Tomasz Figa Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 00/20] DMA: DMA unmap fixes

2012-11-06 Thread Tomasz Figa
/fsmc_nand.c| 20 ++- > drivers/net/ethernet/micrel/ks8842.c | 6 +- > drivers/spi/spi-dw-mid.c| 4 +- > include/linux/async_tx.h| 4 + > include/linux/dmaengine.h | 34 ++-- > 34 files changed,

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
Hi Doug, On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote: > A level-triggered interrupt should be acked after the interrupt line > becomes inactive and before it is unmasked, or else another interrupt > will be immediately triggered. Acking before or after calling the > handler is not e

Re: [PATCH 1/3] pinctrl: exynos: Add spinlocks to irq_mask and irq_unmask

2013-06-13 Thread Tomasz Figa
ad/modify/write. > Add the spinlock there. Right, that's correct. I always thought that the IRQ core already does some irqchip level locking, but it seems like I got confused by irq_desc spinlock. Thanks for spotting this. Acked-by: Tomasz Figa Best regards, Tomasz > Si

Re: [PATCH 2/3] pinctrl: exynos: reorder xyz_irq_unmask() so future patch can ack

2013-06-13 Thread Tomasz Figa
-- 1 file changed, 26 > insertions(+), 26 deletions(-) IMHO just moving _ack() above _mask() (or _unmask()) would be enough, without touching _mask() and _unmask() in this patch, but have my Acked-by: Tomasz Figa Best regards, Tomasz P.S. I think you might have missed linux-arm-kernel a

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
On Thursday 13 of June 2013 09:34:43 Doug Anderson wrote: > Tomasz, > > On Thu, Jun 13, 2013 at 3:54 AM, Tomasz Figa wrote: > > Hi Doug, > > > > On Wednesday 12 of June 2013 10:33:19 Doug Anderson wrote: > >> A level-triggered interrupt should be acked a

Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
On Thursday 13 of June 2013 09:38:33 Doug Anderson wrote: > Kukjin, > > On Thu, Jun 13, 2013 at 5:04 AM, Kukjin Kim wrote: > > Doug Anderson wrote: > >> A level-triggered interrupt should be acked after the interrupt line > >> becomes inactive and before it is unmasked, or else another interrupt

Re: [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking

2013-06-13 Thread Tomasz Figa
lready applied parts 1 and 2, so not resending. > > drivers/pinctrl/pinctrl-exynos.c | 22 ++ > 1 file changed, 22 insertions(+) Looks good. Thanks. Acked-by: Tomasz Figa Best regards, Tomasz > diff --git a/drivers/pinctrl/pinctrl-exynos.c > b/drivers/p

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
t; > +PIN CONTROLLER - SAMSUNG > +M: Linus Walleij > +M: Kukjin Kim So actually this would be: M: Thomas Abraham M: Tomasz Figa Thomas, do you agree on this? Best regards, Tomasz > +L: linux-arm-ker...@lists.infradead.org (moderated for non- subscribers) > +L

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > Tomasz, > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > >> It's convenient if get_maintainer suggests sending samsung/exynos > >

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: > Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > > > Tomasz, > > > > > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa > > > > > > > wrote: > &g

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: > Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > > > Tomasz, > > > > > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa > > > > > > > wrote: > &g

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Friday 14 of June 2013 07:47:15 Kukjin Kim wrote: > Tomasz Figa wrote: > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > > > It's convenient if get_maintainer suggests sending samsung/exynos > > > pinctrl changes to linux-samsung-soc and to

Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries

2013-06-13 Thread Tomasz Figa
On Friday 14 of June 2013 00:49:08 Tomasz Figa wrote: > On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: > > Tomasz Figa wrote: > > > On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > > > > Tomasz, > > > > > > &

Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

2013-06-15 Thread Tomasz Figa
Hi, Some comments inline. On Saturday 15 of June 2013 01:16:20 Oliver Schinagl wrote: > From: Oliver Schinagl > > Allwinner has electric fuses (efuse) on their line of chips. This driver > reads those fuses, seeds the kernel entropy and exports them as a sysfs > node. > > These fuses are most

[RFC PATCH] ARM: Add .init_platform() callback to machine descriptor

2013-06-15 Thread Tomasz Figa
, this problem has become a bit more inconvenient. This patch tries to solve this issue by introducing new callback called .init_platform(), where any custom low level initialization of platform can be done safely. Signed-off-by: Tomasz Figa --- arch/arm/include/asm/mach/arch.h | 1 + arch/arm

[RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks

2013-06-16 Thread Tomasz Figa
Instead of defining new bool field in vendor_data struct for each quirk, it is more reasonable to use a single flags field and make each quirk use single bits. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 31 +-- 1 file changed, 17 insertions(+), 14

[RFC PATCH 07/11] dmaengine: PL08x: Fix reading the byte count in cctl

2013-06-16 Thread Tomasz Figa
From: Alban Bedel There are more fields than just SWIDTH in CH_CONTROL register, so read register value must be masked in addition to shifting. Signed-off-by: Alban Bedel Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[RFC PATCH 08/11] dmaengine: PL08x: Add cyclic transfer support

2013-06-16 Thread Tomasz Figa
From: Alban Bedel Many audio interface drivers require support of cyclic transfers to work correctly, for example Samsung ASoC DMA driver. This patch adds support for cyclic transfers to the amba-pl08x driver. Signed-off-by: Alban Bedel Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c

[RFC PATCH 11/11] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-06-16 Thread Tomasz Figa
through DMA resource, casted to unsigned long, but this is how Samsung DMA wrappers (used to support both s3c-dma and DMA engine in drivers) is designed. Signed-off-by: Tomasz Figa --- arch/arm/Kconfig | 1 + arch/arm/mach-s3c64xx/Kconfig| 8 +- arch/arm

[RFC PATCH 10/11] ASoC: samsung: Do not require legacy DMA API in case of S3C64XX

2013-06-16 Thread Tomasz Figa
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa --- sound/soc/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/Kconfig b/sound/soc

[RFC PATCH 09/11] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX

2013-06-16 Thread Tomasz Figa
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index

[RFC PATCH 06/11] dma: amba-pl08x: Keep LLIs aligned to 4-word boundary

2013-06-16 Thread Tomasz Figa
PL080 reference manual states that to LLI entries should be aligned to 4-word boundary to make LLI fetches more efficient. This patch adds a 3-word padding to the LLi struct to make this condition true. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 1 + 1 file changed, 1 insertion

[RFC PATCH 03/11] dma: amba-pl08x: Add support for different offset of CONFIG register

2013-06-16 Thread Tomasz Figa
Some variants of PL08x (namely PL080S, found in Samsung S3C64xx SoCs) have CONFIG register at different offset. This patch makes the driver use offset from vendor data struct. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 51 1 file

[RFC PATCH 05/11] dma: amba-pl08x: Add support for different maximum transfer size

2013-06-16 Thread Tomasz Figa
transfer sizes fitting the original bitfield of PL080, but now would overwrite other fields. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index

[RFC PATCH 04/11] dma: amba-pl08x: Add support for PL080S variant

2013-06-16 Thread Tomasz Figa
PL080S is a modified version of PL080 that can be found on Samsung SoCs, such as S3C6400 and S3C6410. It has different offset of CONFIG register, separate CONTROL1 register that holds transfer size and larger maximum transfer size. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 68

[RFC PATCH 02/11] dma: amba-pl08x: Refactor pl08x_getbytes_chan() to lower indentation

2013-06-16 Thread Tomasz Figa
wherever possible. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 51 ++-- 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index d443a68..1e57ded 100644 --- a/drivers/dma/amba

[RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-16 Thread Tomasz Figa
2): dmaengine: PL08x: Fix reading the byte count in cctl dmaengine: PL08x: Add cyclic transfer support Tomasz Figa (9): dma: amba-pl08x: Use bitmap to pass variant specific quirks dma: amba-pl08x: Refactor pl08x_getbytes_chan() to lower indentation dma: amba-pl08x: Add support for diff

Re: [PATCH Resend] pinctrl: exynos: Fix build breakage

2013-06-17 Thread Tomasz Figa
Hi Sachin, On Monday 17 of June 2013 15:08:12 Sachin Kamat wrote: > 'exynos_wkup_irq_ack' should be defined ahead of its call. > > Fixes the following error: > drivers/pinctrl/pinctrl-exynos.c: In function ‘exynos_wkup_irq_mask’: > drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declarati

Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 12:36:47 Oliver Schinagl wrote: > On 15-06-13 12:28, Tomasz Figa wrote: > > Hi, > > > > Some comments inline. > > Thank you You're welcome. :) > > On Saturday 15 of June 2013 01:16:20 Oliver Schinagl wrote: > >> From: Oli

Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 15:10:47 Oliver Schinagl wrote: > On 17-06-13 14:51, Tomasz Figa wrote: > > On Monday 17 of June 2013 12:36:47 Oliver Schinagl wrote: > >> On 15-06-13 12:28, Tomasz Figa wrote: > >>> Hi, > >>> > >>> Some comment

Re: [PATCH] of: irq: Pass trigger type in IRQ resource flags

2013-06-05 Thread Tomasz Figa
Hi, On Sunday 19 of May 2013 00:56:30 Tomasz Figa wrote: > Some drivers might rely on availability of trigger flags in IRQ > resource, for example to configure the hardware for particular interrupt > type. However current code creating IRQ resources from data in device > tree does n

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
Hi Luke, On Wednesday 05 of June 2013 22:15:08 Luke Kenneth Casson Leighton wrote: > [i've just received word, please remove debian-release from > discussions!] > On Wed, Jun 5, 2013 at 9:46 PM, jonsm...@gmail.com wrote: > > Why don't you try converting the sunxi code over to device tree? > > o

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
On Wednesday 05 of June 2013 16:48:27 jonsm...@gmail.com wrote: > On Wed, Jun 5, 2013 at 3:46 PM, Luke Kenneth Casson Leighton > > wrote: > > On Fri, May 31, 2013 at 3:52 AM, Ben Hutchings wrote: > > > The 3.8.y branch is over, so I think we have to move to 3.9, ready > > > or > > > not. I mer

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
On Wednesday 05 of June 2013 22:16:37 Russell King - ARM Linux wrote: > On Wed, Jun 05, 2013 at 03:00:13PM -0600, Stephen Warren wrote: > > 2) Having U-Boot itself read a DT and configure itself, just like the > > kernel does. This is relatively new, and only supported by a few > > boards > > (all

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
On Wednesday 05 of June 2013 23:38:52 Luke Kenneth Casson Leighton wrote: > On Wed, Jun 5, 2013 at 10:52 PM, Tomasz Figa wrote: > > Hi Luke, > > allo tomasz :) > > ok - much of what you say is duplicated by what russell said, so in > effect the same reply is relevan

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Tomasz Figa
On Thursday 06 of June 2013 00:54:02 luke.leighton wrote: > On Thu, Jun 6, 2013 at 12:40 AM, Henrik Nordström > > wrote: > > tor 2013-06-06 klockan 00:26 +0100 skrev luke.leighton: > >> no john - they've only added it to the multiplexed sections of the > >> > >> drivers which they themselves ha

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-06 Thread Tomasz Figa
Hi Thomas, On Thursday 06 of June 2013 11:27:23 Thomas Petazzoni wrote: > Dear Tomasz Figa, > > On Thu, 06 Jun 2013 02:01:14 +0200, Tomasz Figa wrote: > > I don't see any other solution here than moving all the Allwinner > > code to DT (as it has been suggested in

Re: [PATCH] ARM: tegra: add basic SecureOS support

2013-06-06 Thread Tomasz Figa
Hi Alex, On Thursday 06 of June 2013 16:28:07 Alexandre Courbot wrote: > Boot loaders on some Tegra devices can be unlocked but do not let the > system operate without SecureOS. SecureOS prevents access to some > registers and requires the operating system to perform certain > operations through S

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-06 Thread Tomasz Figa
Luke, On Thursday 06 of June 2013 13:24:57 luke.leighton wrote: > On Thu, Jun 6, 2013 at 1:01 AM, Tomasz Figa wrote: > > I don't see any other solution here than moving all the Allwinner code > > to DT (as it has been suggested in this thread several times > > alr

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-06 Thread Tomasz Figa
On Thursday 06 of June 2013 13:49:38 luke.leighton wrote: > On Thu, Jun 6, 2013 at 1:43 PM, Tomasz Figa wrote: > > Luke, > > > > On Thursday 06 of June 2013 13:24:57 luke.leighton wrote: > >> On Thu, Jun 6, 2013 at 1:01 AM, Tomasz Figa > > > > wrote:

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-07 Thread Tomasz Figa
On Friday 07 of June 2013 08:52:43 luke.leighton wrote: > On Thu, Jun 6, 2013 at 2:02 PM, Tomasz Figa wrote: > > On Thursday 06 of June 2013 13:49:38 luke.leighton wrote: > >> On Thu, Jun 6, 2013 at 1:43 PM, Tomasz Figa > > > > wrote: > >> > Luke, >

Re: [RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 19:48:56 Russell King - ARM Linux wrote: > On Sun, Jun 16, 2013 at 10:54:08PM +0200, Tomasz Figa wrote: > > Instead of defining new bool field in vendor_data struct for each > > quirk, it is more reasonable to use a single flags field and make > >

Re: [RFC PATCH 03/11] dma: amba-pl08x: Add support for different offset of CONFIG register

2013-06-17 Thread Tomasz Figa
On Monday 17 of June 2013 19:52:23 Russell King - ARM Linux wrote: > On Sun, Jun 16, 2013 at 10:54:10PM +0200, Tomasz Figa wrote: > > Some variants of PL08x (namely PL080S, found in Samsung S3C64xx SoCs) > > have CONFIG register at different offset. This patch makes the driver >

Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses

2013-06-17 Thread Tomasz Figa
3 files changed, 165 > insertions(+) > create mode 100644 drivers/misc/eeprom/sunxi_sid.c Looks good to me. Have my Reviewed-by: Tomasz Figa Best regards, Tomasz > diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig > index 04f2e1f..c

[PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-18 Thread Tomasz Figa
SoCs on which currently offlining CPUs 2 or 3 caused CPU 1 to be turned off. In addition, bring-up of CPU 2 and 3 is fixed on boards where bootloader powers off secondary cores by default. Cc: sta...@vger.kernel.org Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- arch/arm/mach

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-18 Thread Tomasz Figa
Ccing Arnd and Olof, because I forgot to add them to git send-email... Sorry for the noise. On Tuesday 18 of June 2013 17:26:31 Tomasz Figa wrote: > S5P_ARM_CORE1_* registers affect only core 1. To control further cores > properly another registers must be used. > > This pa

Re: [PATCH 2/2] clk: exynos4: Add alias for cpufreq related clocks

2013-06-19 Thread Tomasz Figa
Hi Tushar, On Wednesday 19 of June 2013 10:20:14 Tushar Behera wrote: > On 06/17/2013 10:20 AM, Tushar Behera wrote: > > On 06/11/2013 12:23 AM, Tomasz Figa wrote: > >> On Monday 10 of June 2013 09:13:11 Tushar Behera wrote: > >>> On 06/08/2013 05:20 PM, Tomasz Fig

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 17:39:21 Chander Kashyap wrote: > On 18 June 2013 23:29, Kukjin Kim wrote: > > On 06/19/13 02:45, Tomasz Figa wrote: > >> Ccing Arnd and Olof, because I forgot to add them to git send-email... > >> > >> Sorry for the noise. > &g

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 14:24:17 Lorenzo Pieralisi wrote: > On Wed, Jun 19, 2013 at 01:50:57PM +0100, Tomasz Figa wrote: > > On Wednesday 19 of June 2013 17:39:21 Chander Kashyap wrote: > > > On 18 June 2013 23:29, Kukjin Kim wrote: > > > > On 06/

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 19:25:27 Chander Kashyap wrote: > On 19 June 2013 19:19, Tomasz Figa wrote: > > On Wednesday 19 of June 2013 14:24:17 Lorenzo Pieralisi wrote: > >> On Wed, Jun 19, 2013 at 01:50:57PM +0100, Tomasz Figa wrote: > >> > On Wednesday 19

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 20:26:50 Chander Kashyap wrote: > On 19 June 2013 19:58, Tomasz Figa wrote: > > On Wednesday 19 of June 2013 19:25:27 Chander Kashyap wrote: > >> On 19 June 2013 19:19, Tomasz Figa wrote: > >> > On Wednesday 19 of June 2013 14

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 18:40:47 Mark Brown wrote: > On Sun, Jun 16, 2013 at 10:54:07PM +0200, Tomasz Figa wrote: > > One of the biggest roadblocks on the way of S3C64xx to DeviceTree > > support is its DMA driver, which is completely platform-specific and > > provides

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 20:22:11 Mark Brown wrote: > On Wed, Jun 19, 2013 at 08:26:12PM +0200, Tomasz Figa wrote: > > On Wednesday 19 of June 2013 18:40:47 Mark Brown wrote: > > > - ret = pd->get_signal(plchan->cd); > > > + ret = (pd->g

Re: [PATCH V6 3/3] ARM: dts: Add pcie controller node for Samsung EXYNOS5440 SoC

2013-06-20 Thread Tomasz Figa
Hi Jingoo, On Thursday 20 of June 2013 16:12:24 Jingoo Han wrote: > Exynos5440 has two PCIe controllers which can be used as root complex > for PCIe interface. > > Signed-off-by: Jingoo Han > --- > arch/arm/boot/dts/exynos5440-ssdk5440.dts |8 ++ > arch/arm/boot/dts/exynos5440.dtsi

Re: [PATCH V6 3/3] ARM: dts: Add pcie controller node for Samsung EXYNOS5440 SoC

2013-06-20 Thread Tomasz Figa
On Thursday 20 of June 2013 17:25:12 Jingoo Han wrote: > On Thursday, June 20, 2013 5:04 PM, Tomasz Figa wrote: > > Hi Jingoo, > > > > On Thursday 20 of June 2013 16:12:24 Jingoo Han wrote: > > > Exynos5440 has two PCIe controllers which can be used as root co

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-20 Thread Tomasz Figa
On Wednesday 19 of June 2013 11:19:30 Nicolas Pitre wrote: > On Wed, 19 Jun 2013, Tomasz Figa wrote: > > On Wednesday 19 of June 2013 20:26:50 Chander Kashyap wrote: > > > On 19 June 2013 19:58, Tomasz Figa wrote: > > > > I mean, calculate register offset bas

Re: [PATCH V6 3/3] ARM: dts: Add pcie controller node for Samsung EXYNOS5440 SoC

2013-06-20 Thread Tomasz Figa
On Thursday 20 of June 2013 20:04:47 Jingoo Han wrote: > On Thursday, June 20, 2013 7:17 PM, Arnd Bergmann wrote: > > On Thursday 20 June 2013, Jingoo Han wrote: > > > 2. patch adding label to the pinctrl node (which is a prerequisite) > > > and > > > > > > board-specific properties of PCIe no

[PATCH v6 6/8] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-06-20 Thread Tomasz Figa
This patch adds basic device tree definitions for Samsung S3C64xx SoCs. Since all the SoCs in the series are very similar, the files are created hierarchically - one file for the whole series and then separate files for particular SoCs including the common one. Signed-off-by: Tomasz Figa

[PATCH v6 7/8] ARM: dts: Add dts file for S3C6410-based Mini6410 board

2013-06-20 Thread Tomasz Figa
This patch adds basic device tree sources for FriendlyARM Mini6410 board based on Samsung S3C6410 SoC. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/s3c6410-mini6410.dts | 199 + 2 files changed, 200 insertions

[PATCH v6 8/8] ARM: dts: Add dts file for S3C6410-based SMDK6410 board

2013-06-20 Thread Tomasz Figa
This patch adds basic device tree sources for SAMSUNG SMDK6410 board based on SAMSUNG S3C6410 SoC. Currently only UARTs, SD channel 0 and 100Mbps ethernet (SMSC911x) are supported. Signed-off-by: Tomasz Figa --- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/s3c6410-smdk6410

[PATCH v6 1/8] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-06-20 Thread Tomasz Figa
This patch extends vic_of_init to parse valid interrupt sources and resume sources masks from device tree. If mask values are not specified in device tree, all sources are assumed to be valid, as before this patch. Signed-off-by: Tomasz Figa --- Documentation/devicetree/bindings/arm/vic.txt

[PATCH v6 3/8] gpio: samsung: Skip legacy GPIO registration if pinctrl-s3c64xx is present

2013-06-20 Thread Tomasz Figa
The new driver handles GPIO on DT-enabled platforms. Signed-off-by: Tomasz Figa --- drivers/gpio/gpio-samsung.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c index a1392f4..8d512b1 100644 --- a/drivers/gpio/gpio

[PATCH v6 5/8] ARM: s3c64xx: Add board file for boot using Device Tree

2013-06-20 Thread Tomasz Figa
This patch adds board file that will be used to boot S3C64xx-based boards using Device Tree. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/Kconfig | 16 +++ arch/arm/mach-s3c64xx/Makefile | 1 + arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 83

[PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-20 Thread Tomasz Figa
, this problem has become a bit more inconvenient. This patch tries to solve this issue by introducing new callback called .init_platform(), where any custom low level initialization of platform can be done safely. Signed-off-by: Tomasz Figa --- arch/arm/include/asm/mach/arch.h | 1 + arch/arm

[PATCH v6 2/8] ARM: s3c64xx: Bypass legacy initialization when booting with DT

2013-06-20 Thread Tomasz Figa
This patch allows bypassing most of legacy initialization when booting an S3C64xx-based board using device tree, by adding conditional checks for DT presence to initcalls which are no longer necessary when booting with DT.. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/common.c | 12

[PATCH v6 0/8] Initial Device Tree support for S3C64xx

2013-06-20 Thread Tomasz Figa
ected VIC interrupt specifiers - Adjusted CPU compatible values and dropped @id Tomasz Figa (8): ARM: common: vic: Parse interrupt and resume masks from device tree ARM: s3c64xx: Bypass legacy initialization when booting with DT gpio: samsung: Skip legacy GPIO registration if pinctrl-s3c64xx i

Re: [PATCH 3/3] ARM: S5P64X0: Remove duplicate uncompress code

2013-06-03 Thread Tomasz Figa
anges? > > Alternately, I can take your patch and do above modifications in them. Unfortunately I'm unlikely to find time to do it myself in nearest future, so feel free to do it. Thanks. Keep in mind, however, that this patch was a dependency of [PATCH 0/6] Samsung watchdog supp

Re: [PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-21 Thread Tomasz Figa
Hi Marc, On Friday 21 of June 2013 11:24:52 Marc Zyngier wrote: > On 21/06/13 01:35, Tomasz Figa wrote: > > Hi Tomasz, > > > Most ARM platforms have parts that should be initialized as early as > > possible, which usually means as soon as memory management (kmalloc, >

[PATCH v2 0/3] regulator: max8998: Add support for Device Tree

2013-06-21 Thread Tomasz Figa
documentation. Tested on Universal C210 board. Changes since v1: - rebased to current for-next of regulator tree Tomasz Figa (3): mfd: Add irq domain support for max8998 interrupts regulator: max8998: Use arrays for specifying voltages in platform data mfd: max8998: Add support for

[PATCH v2 3/3] mfd: max8998: Add support for Device Tree

2013-06-21 Thread Tomasz Figa
This patch adds Device Tree support to max8998 driver. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- Documentation/devicetree/bindings/mfd/max8998.txt | 111 +++ drivers/mfd/max8998.c | 75 +- drivers/regulator/max8998.c

[PATCH v2 1/3] mfd: Add irq domain support for max8998 interrupts

2013-06-21 Thread Tomasz Figa
platform data and max8997 driver private data are removed. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/mfd/Kconfig | 1 + drivers/mfd/max8998-irq.c | 61 ++--- drivers/mfd/max8998.c | 1 - drivers/rtc/rtc

[PATCH v2 2/3] regulator: max8998: Use arrays for specifying voltages in platform data

2013-06-21 Thread Tomasz Figa
. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos/mach-universal_c210.c | 8 +-- arch/arm/mach-s5pv210/mach-aquila.c| 8 +-- arch/arm/mach-s5pv210/mach-goni.c | 8 +-- drivers/regulator/max8998.c| 96

Re: [PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-22 Thread Tomasz Figa
On Friday 21 of June 2013 16:12:15 Arnd Bergmann wrote: > On Friday 21 June 2013, Tomasz Figa wrote: > > > To me, this new hook is strictly equivalent to init_irq. What do we > > > gain exactly? I didn't think init_irq was going away... > > > > > > I

Re: [PATCH v2 0/2] Clock update for EXYNOS4210-CPUFREQ driver

2013-06-22 Thread Tomasz Figa
d to make them available through global alias. > > > > The patches are based on next-20130618. > > > > Patch 1 has not been modified. > > Patch 2 has been updated to include EXYNOS4X12 releated clocks. Looks fine to me. Reviewed-by: Tomasz Figa > Patch and c

[PATCH v7 5/8] ARM: s3c64xx: Add board file for boot using Device Tree

2013-06-22 Thread Tomasz Figa
This patch adds board file that will be used to boot S3C64xx-based boards using Device Tree. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/Kconfig | 16 +++ arch/arm/mach-s3c64xx/Makefile | 1 + arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 85

Re: [PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-22 Thread Tomasz Figa
Hi Kukjin, On Friday 21 of June 2013 02:35:20 Tomasz Figa wrote: > Most ARM platforms have parts that should be initialized as early as > possible, which usually means as soon as memory management (kmalloc, > ioremap) starts to work, > > However, currently there is no appropri

[RFC PATCH v2 00/12] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-22 Thread Tomasz Figa
e count in cctl dmaengine: PL08x: Add cyclic transfer support Tomasz Figa (10): dmaengine: PL08x: Refactor pl08x_getbytes_chan() to lower indentation dmaengine: PL08x: Add support for different offset of CONFIG register dmaengine: PL08x: Rework LLI handling to be less fragile dmaeng

[RFC PATCH v2 01/12] dmaengine: PL08x: Refactor pl08x_getbytes_chan() to lower indentation

2013-06-22 Thread Tomasz Figa
wherever possible. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 53 ++-- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 06fe45c..6a12392 100644 --- a/drivers/dma/amba

[RFC PATCH v2 08/12] ASoC: Samsung: Do not queue cyclic buffers multiple times

2013-06-22 Thread Tomasz Figa
offset. This patch fixes this problem by making the legacy S3C-DMA API use the same semantics as DMA engine (the whole cyclic buffer is enqueued at once) and modifying users of Samsung DMA wrappers in cyclic mode to behave appropriately. Signed-off-by: Tomasz Figa --- arch/arm/plat-samsung/s3c-dma

[RFC PATCH v2 07/12] dmaengine: PL08x: Add cyclic transfer support

2013-06-22 Thread Tomasz Figa
.] Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 147 +-- 1 file changed, 118 insertions(+), 29 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 1eeb911..a3a86dd 100644 --- a/drivers/dma/amba-pl08x.c +++ b

[RFC PATCH v2 06/12] dmaengine: PL08x: Fix reading the byte count in cctl

2013-06-22 Thread Tomasz Figa
From: Alban Bedel There are more fields than just SWIDTH in CH_CONTROL register, so read register value must be masked in addition to shifting. Signed-off-by: Alban Bedel Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[RFC PATCH v2 09/12] clk: samsung: s3c64xx: Add aliases for DMA clocks

2013-06-22 Thread Tomasz Figa
The new amba-pl08x driver requires another set of clock aliases, so this patch adds them. Signed-off-by: Tomasz Figa --- drivers/clk/samsung/clk-s3c64xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/samsung/clk-s3c64xx.c b/drivers/clk/samsung/clk-s3c64xx.c index 253a972

[RFC PATCH v2 10/12] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX

2013-06-22 Thread Tomasz Figa
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa --- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index

[RFC PATCH v2 11/12] ASoC: Samsung: Do not require legacy DMA API in case of S3C64XX

2013-06-22 Thread Tomasz Figa
With support for amba-pl08x driver, on S3C64xx the generic DMA engine API can be used instead of the private s3c-dma interface. Signed-off-by: Tomasz Figa --- sound/soc/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/Kconfig b/sound/soc

[RFC PATCH v2 05/12] dmaengine: PL08x: Add support for different maximum transfer size

2013-06-22 Thread Tomasz Figa
transfer sizes fitting the original bitfield of PL080, but now would overwrite other fields. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 103bc1a..89b8120

[RFC PATCH v2 02/12] dmaengine: PL08x: Add support for different offset of CONFIG register

2013-06-22 Thread Tomasz Figa
Some variants of PL08x (namely PL080S, found in Samsung S3C64xx SoCs) have CONFIG register at different offset. This patch makes the driver use offset from vendor data struct. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 30 ++ 1 file changed, 18

[RFC PATCH v2 03/12] dmaengine: PL08x: Rework LLI handling to be less fragile

2013-06-22 Thread Tomasz Figa
-bit words, which is just filled with appropriate values in appropriate order and padded with required amount of dummy words (currently zero, but PL080S will make better use of this). Suggested-by: Linus Walleij Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 149

[RFC PATCH v2 12/12] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-06-22 Thread Tomasz Figa
through DMA resource, casted to unsigned long, but this is how Samsung DMA wrappers (used to support both s3c-dma and DMA engine in drivers) are designed. Signed-off-by: Tomasz Figa --- arch/arm/Kconfig | 1 + arch/arm/mach-s3c64xx/Kconfig| 8 +- arch/arm

[RFC PATCH v2 04/12] dmaengine: PL08x: Add support for PL080S variant

2013-06-22 Thread Tomasz Figa
PL080S is a modified version of PL080 that can be found on Samsung SoCs, such as S3C6400 and S3C6410. It has different offset of CONFIG register, separate CONTROL1 register that holds transfer size and larger maximum transfer size. Signed-off-by: Tomasz Figa --- drivers/dma/amba-pl08x.c | 73

[PATCH v3 3/3] mfd: max8998: Add support for Device Tree

2013-06-24 Thread Tomasz Figa
This patch adds Device Tree support to max8998 driver. Signed-off-by: Tomasz Figa --- Documentation/devicetree/bindings/mfd/max8998.txt | 108 drivers/mfd/max8998.c | 75 +++- drivers/regulator/max8998.c | 143

[PATCH v3 1/3] mfd: Add irq domain support for max8998 interrupts

2013-06-24 Thread Tomasz Figa
This patch adds irq domain support for max8998 interrupts. To keep both non-DT and DT worlds happy, simple domain is used, which is linear when no explicit IRQ base is specified and legacy, with static mapping, otherwise. Signed-off-by: Tomasz Figa --- drivers/mfd/Kconfig | 1

[PATCH v3 0/3] regulator: max8998: Add support for Device Tree

2013-06-24 Thread Tomasz Figa
bit Changes since v1: - rebased to current for-next of regulator tree Tomasz Figa (3): mfd: Add irq domain support for max8998 interrupts regulator: max8998: Use arrays for specifying voltages in platform data mfd: max8998: Add support for Device Tree Documentation/devicetree/bindings

[PATCH v3 2/3] regulator: max8998: Use arrays for specifying voltages in platform data

2013-06-24 Thread Tomasz Figa
. Signed-off-by: Tomasz Figa --- arch/arm/mach-exynos/mach-universal_c210.c | 8 +-- arch/arm/mach-s5pv210/mach-aquila.c| 8 +-- arch/arm/mach-s5pv210/mach-goni.c | 8 +-- drivers/regulator/max8998.c| 96 +- include/linux/mfd/max8998.h

Re: [RFC PATCH v2 00/12] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-25 Thread Tomasz Figa
Hi Mark, Thanks for testing this series. On Tuesday 25 of June 2013 11:28:18 Mark Brown wrote: > On Sat, Jun 22, 2013 at 10:42:32PM +0200, Tomasz Figa wrote: > > This is another version of my patches extending support of amba-pl08x > > DMA engine driver to PL080S DMA engine (PL

[PATCH v4 3/3] mfd: max8998: Add support for Device Tree

2013-06-25 Thread Tomasz Figa
This patch adds Device Tree support to max8998 driver. Signed-off-by: Tomasz Figa --- Documentation/devicetree/bindings/mfd/max8998.txt | 119 drivers/mfd/max8998.c | 67 ++- drivers/regulator/max8998.c | 130

Re: [PATCH v4 3/3] mfd: max8998: Add support for Device Tree

2013-06-25 Thread Tomasz Figa
Hi, Oops, I have posted wrong patch by mistake. Sorry for the noise. Correct one is on the way. Best regards, Tomasz On Tuesday 25 of June 2013 15:46:45 Tomasz Figa wrote: > This patch adds Device Tree support to max8998 driver. > > Signed-off-by: Tomasz Figa > --- >

[PATCH RESEND v4 3/3] mfd: max8998: Add support for Device Tree

2013-06-25 Thread Tomasz Figa
This patch adds Device Tree support to max8998 driver. Signed-off-by: Tomasz Figa --- Documentation/devicetree/bindings/mfd/max8998.txt | 119 drivers/mfd/max8998.c | 67 ++- drivers/regulator/max8998.c | 131

Re: [RFC PATCH v2 00/12] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-25 Thread Tomasz Figa
On Tuesday 25 of June 2013 16:38:43 Mark Brown wrote: > On Tue, Jun 25, 2013 at 01:22:20PM +0200, Tomasz Figa wrote: > > On Tuesday 25 of June 2013 11:28:18 Mark Brown wrote: > > > On my non-DT s3c64xx system I get this when trying to use SPI for the > > > > >

<    1   2   3   4   5   6   7   8   9   10   >