common and hardware-specific interfaces
> + * @mux_hw: handle between composite and hardware-specifix mux clock
> + * @div_hw: handle between composite and hardware-specifix divider
> clock + * @gate_hw: handle between composite and hardware-specifix gate
> clock + * @mux_ops: clock ops for mux
>
lk/clk-composite.c
> @@ -27,6 +27,9 @@ static u8 clk_composite_get_parent(struct clk_hw *hw)
> const struct clk_ops *mux_ops = composite->mux_ops;
> struct clk_hw *mux_hw = composite->mux_hw;
>
> + if (!mux_hw->clk)
> +return -EINVAL;
gt; kfree(composite);
> > return clk;
> >
> > }
> >
> > diff --git a/include/linux/clk-provider.h
> > b/include/linux/clk-provider.h index f0ac818..bb5d36a 100644
> > --- a/include/linux/clk-provider.h
> > +++ b/include/linux
On Wednesday 06 of February 2013 08:34:32 Prashant Gaikwad wrote:
> On Tuesday 05 February 2013 03:45 PM, Tomasz Figa wrote:
> > Hi Prashant,
> >
> > Thank you for your patch. Please see some comments inline.
> >
> > On Monday 04 of February 2013 13:41:22 Pra
writel(clr & ~clr, sdd->regs + S3C64XX_SPI_PENDING_CLR);
> >
> > Wait, what? clr & ~clr == 0 Always. What are you actually trying
> > to do here?
> The user manual says, wirting 1 to the pending clear register clears
> the interrupt (its not auto clear to
On Thursday 07 of February 2013 09:46:58 Girish KS wrote:
> On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa wrote:
> > Hi Girish,
> >
> > On Wednesday 06 of February 2013 12:12:29 Girish KS wrote:
> >> On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely
> >> >
&
.
Tomasz Figa (2):
regulator: max8952: Separate constraints from platform data struct
regulator: max8952: Add Device Tree support
.../devicetree/bindings/regulator/max8952.txt | 52 +++
arch/arm/mach-exynos/mach-universal_c210.c | 27
drivers/regulator/max8952.c
This patch modifies platform data structure of max8952 driver to
use pointer to regulator_init_data struct instead of embedding it.
This is a prerequisite for adding Device Tree support for the driver.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
arch/arm/mach-exynos/mach
This patch adds Device Tree support to max8952 regulator driver.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
.../devicetree/bindings/regulator/max8952.txt | 52
drivers/regulator/max8952.c| 70 ++
include/linux
documentation.
Tested on Universal C210 board.
Tomasz Figa (3):
mfd: Add irq domain support for max8998 interrupts
regulator: max8998: Use arrays for specifying voltages in platform
data
mfd: max8998: Add support for Device Tree
Documentation/devicetree/bindings/mfd/max8998.txt | 111
platform data and max8997 driver private data
are removed.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
drivers/mfd/Kconfig | 1 +
drivers/mfd/max8998-irq.c | 61 ++---
drivers/mfd/max8998.c | 1 -
drivers/rtc/rtc
.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
arch/arm/mach-exynos/mach-universal_c210.c | 8 +--
arch/arm/mach-s5pv210/mach-aquila.c| 8 +--
arch/arm/mach-s5pv210/mach-goni.c | 8 +--
drivers/regulator/max8998.c| 96
This patch adds Device Tree support to max8998 driver.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
Documentation/devicetree/bindings/mfd/max8998.txt | 111 +++
drivers/mfd/max8998.c | 75 +-
drivers/regulator/max8998.c
Hi,
On Thursday 24 of January 2013 19:19:57 Lars-Peter Clausen wrote:
> On 01/24/2013 05:12 PM, Doug Anderson wrote:
> > Lars,
> >
> > Thank you for your comments / thoughts...
>
> Hi,
>
> > On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen
wrote:
> >> adc: adc@12D1 {
> >>
> >>
Hi Linus,
On Sunday 24 of February 2013 01:16:21 Linus Walleij wrote:
> On Sat, Feb 23, 2013 at 6:57 PM, Heiko Stübner wrote:
> > When pinctrl is not built the fallback functions fail silently
> > and emit either 0 error codes or NULL pinctrl handles.
> >
> > Therefore it's needed to also check
On Sunday 24 of February 2013 01:47:49 Linus Walleij wrote:
> On Sun, Feb 24, 2013 at 1:38 AM, Tomasz Figa
wrote:
> > The driver must know whether pin control is available, because it has
> > to fall back to legacy GPIO-based pin configuration if it is not.
> > This mean
On Sunday 24 of February 2013 02:01:45 Linus Walleij wrote:
> On Sun, Feb 24, 2013 at 1:58 AM, Tomasz Figa
wrote:
> > [Me]
> >
> >> Surely you know this when setting up the pdata from your machine?
> >
> > Cases 2) and 3) are both DT-enabled cases, where the
Hi,
On Monday 25 of February 2013 00:16:49 Heiko Stübner wrote:
> Am Sonntag, 24. Februar 2013, 23:39:44 schrieb Linus Walleij:
> > On Sun, Feb 24, 2013 at 6:00 PM, Tomasz Figa
wrote:
> > >> > Note that we are talking here about a temporary solution. The
> > >
Hi Prashant,
On Thursday 28 of February 2013 11:20:31 Stephen Warren wrote:
> On 02/28/2013 12:58 AM, Prashant Gaikwad wrote:
> > On Wednesday 06 February 2013 03:36 PM, Tomasz Figa wrote:
> >> On Wednesday 06 of February 2013 08:34:32 Prashant Gaikwad wrote:
> >>>
e
support (without auxdata, using OF-based clock lookup), correct me if I'm
wrong. If I'm right, since Exynos SoCs are going to be DT-only, is there
really a point for adding common clock framework support for non-DT
platforms (which are going to be eventually dropped anyway)?
Be
*hw,
> + unsigned long parent_rate)
> +{
> + struct samsung_clk_pll *clk_pll = to_clk_pll(hw);
> +
> + if (clk_pll->get_rate)
> + return to_clk_pll(hw)->get_rate(parent_rate);
> +
> + return 0;
> +}
> +
> +/* round oper
t; + GATECLK("exynos4-sdhci.0", "hsmmc0", "aclk_133", 0,
> + EXYNOS4_CLKGATE_IP_FSYS, 5, "hsmmc"),
> + GATECLK("exynos4-sdhci.1", "hsmmc1", "aclk_133", 0,
> + EXYNOS4_CL
-dt.c | 1 +
> drivers/dma/pl330.c | 15
> ++- 11 files changed, 31 insertions(+), 7 deletions(-)
For all four patches:
Reviewed-by: Tomasz Figa
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Lin
Hi Laurent,
On Tuesday 27 of August 2013 10:02:39 Laurent Pinchart wrote:
> Add DT bindings for the pcf857x-compatible chips and parse the device
> tree node in the driver.
>
> Signed-off-by: Laurent Pinchart
> ---
> .../devicetree/bindings/gpio/gpio-pcf857x.txt | 71
>
On Tuesday 27 of August 2013 14:00:24 Archit Taneja wrote:
> Hi,
>
> On Tuesday 27 August 2013 01:44 PM, Tomasz Figa wrote:
> > Hi Laurent,
> >
> > On Tuesday 27 of August 2013 10:02:39 Laurent Pinchart wrote:
> >> Add DT bindings for the pcf857x-compatible
Hi Mateusz,
Is this a series of 4 patches? Apparently I have received only this one.
On Tuesday 27 of August 2013 11:19:31 Mateusz Krawczuk wrote:
> This patch implements pinctrl for s5pv210 and adds required device tree
> bindings.
This should be wrapped to have lines shorter than 80 characters
Hi Sylwester,
On Tuesday 27 of August 2013 11:30:09 Sylwester Nawrocki wrote:
> Hi,
>
> Just a few nits...
>
> On 08/27/2013 11:19 AM, Mateusz Krawczuk wrote:
> > This patch implements pinctrl for s5pv210 and adds required device tree
> > bindings.
> Would be good to wrap this to not exceed 80 c
ertions(+), 2 deletions(-)
Acked-by: Tomasz Figa
As a side note, please write the PATCH keyword in the topic in upper case
next time.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
On Wednesday 28 of August 2013 09:06:27 Linus Walleij wrote:
> On Sun, Aug 11, 2013 at 7:59 PM, Tomasz Figa
wrote:
> > The legacy S3C-DMA API required every period of a cyclic buffer to be
> > queued separately. After conversion of Samsung ASoC to Samsung DMA
> > wrap
On Wednesday 28 of August 2013 14:51:44 Linus Walleij wrote:
> On Tue, Aug 27, 2013 at 3:08 PM, Mateusz Krawczuk
>
> wrote:
> > This patch implements pinctrl support and adds device tree bindings
> > for s5pv210.
> >
> > Signed-off-by: Mateusz Krawczuk
>
> Oh this one does add bindings, sorry
Hi Mateusz,
On Wednesday 28 of August 2013 18:12:59 Mateusz Krawczuk wrote:
> Replace mxr_dbg, mxr_info and mxr_warn by generic solution.
>
> Signed-off-by: Mateusz Krawczuk
> ---
> drivers/media/platform/s5p-tv/mixer.h | 12 ---
> drivers/media/platform/s5p-tv/mixer_drv.c | 4
Hi Mateusz,
Generally this patch looks good, but I have some minor nitpicks, that I
would like to be fixed.
On Wednesday 28 of August 2013 18:13:00 Mateusz Krawczuk wrote:
> Restore vpll clock rate if start stream fail or stream is off.
>
> Signed-off-by: Mateusz Krawczuk
> ---
> drivers/medi
Hi Mateusz,
On Wednesday 28 of August 2013 18:13:01 Mateusz Krawczuk wrote:
> Replace clk_enable by clock_enable_prepare and clk_disable with
> clk_disable_unprepare. Clock prepare is required by Clock Common
> Framework, and old clock driver didn`t support it. Without it Common
> Clock Framework
On Wednesday 28 of August 2013 18:13:02 Mateusz Krawczuk wrote:
> Replace clk_enable by clock_enable_prepare and clk_disable with
> clk_disable_unprepare. Clock prepare is required by Clock Common
> Framework, and old clock driver didn`t support it. Without it Common
> Clock Framework prints a warn
Hi Mateusz,
On Wednesday 28 of August 2013 18:13:03 Mateusz Krawczuk wrote:
> This patch adds new, Common Clock Framework-based clock driver for
> Samsung S5PV210 SoCs. The driver is just added, without enabling it yet.
>
> Signed-off-by: Mateusz Krawczuk
> ---
> .../bindings/clock/samsung,s5pv
clk-pll.h index cd11037..7679c4c 100644
> --- a/drivers/clk/samsung/clk-pll.h
> +++ b/drivers/clk/samsung/clk-pll.h
> @@ -19,6 +19,8 @@ enum samsung_pll_type {
> pll_2650,
> pll_6552,
> pll_6553,
> + pll_6545a,
> + pll_6522x,
> };
>
> #def
Hi Mateusz,
On Wednesday 28 of August 2013 18:13:04 Mateusz Krawczuk wrote:
> This patch migrates the s5pv210 platform to use new clock driver
> using Common Clock Framework.
>
> Signed-off-by: Mateusz Krawczuk
> ---
> arch/arm/mach-s5pv210/Kconfig | 9 +
> arch/arm/mach-s5pv21
Hi Mateusz,
On Wednesday 28 of August 2013 18:29:16 Mateusz Krawczuk wrote:
> This patch adds new, Common Clock Framework-based clock driver for
> Samsung S5PC100 SoCs. The driver is just added.
>
> Signed-off-by: Mateusz Krawczuk
> ---
> .../bindings/clock/samsung,s5pc100-clock.txt | 72
On Wednesday 28 of August 2013 18:29:17 Mateusz Krawczuk wrote:
> This patch migrates the s5pc100 platform to use new clock driver
> using Common Clock Framework.
>
> Signed-off-by: Mateusz Krawczuk
> ---
> arch/arm/mach-s5pc100/Kconfig | 8
> arch/arm/mach-s5pc100/Makefile
Hi Vyacheslav, Tarek,
On Tuesday 01 of October 2013 20:17:03 Vyacheslav Tyrtov wrote:
> From: Tarek Dakhran
>
> The EXYNOS5410 clocks are statically listed and registered
> using the Samsung specific common clock helper functions.
[snip]
> +Required Properties:
> +
> +- comptible: should be one
Hi Vyacheslav, Tarek,
On Tuesday 01 of October 2013 20:17:05 Vyacheslav Tyrtov wrote:
> From: Tarek Dakhran
>
> Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board.
[snip]
> +/dts-v1/;
> +#include "exynos5410.dtsi"
> +/ {
> + model = "Samsung SMDK5410 board based on EXYNOS541
Hi Vyacheslav, Tarek,
On Tuesday 01 of October 2013 20:17:06 Vyacheslav Tyrtov wrote:
> From: Tarek Dakhran
>
> Configure ARM_NR_BANKS as 16 for EXYNOS SoC.
> Enable cci_control_port_by_index for ACE_PORT.
> Add additional irqs for Exynos MCT.
> Set irq base as 256 for EXYNOS5410 SoC.
>
> Signe
Hi Linus,
On Wednesday 02 of October 2013 12:46:51 Linus Walleij wrote:
> On Sat, Sep 28, 2013 at 8:21 PM, Tomasz Figa
wrote:
> > Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies
> > the gpio-samsung driver to use the proper way of checking for S3C6
7;t see how you could solve this without putting some kind
> > of synchronization mechanism in the USB drivers. So this leaves
> > ehci-s5p and phy-samsung-usb2 as the only possible places, and I chose
> > the latter since all the host-side HSIC initialization is also there
> &g
Hi Benson,
On Friday 13 of September 2013 14:52:40 Benson Leung wrote:
> Allow wakeup_trigger to be defined per gpio button. Currently, all
> gpio buttons are set up as IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING.
> It may be more appropriate to only wake the system on one edge, for
> example if th
On Monday 16 of September 2013 15:48:22 Olof Johansson wrote:
> On Mon, Sep 16, 2013 at 3:46 PM, Benjamin Herrenschmidt
>
> wrote:
> > On Mon, 2013-09-16 at 10:17 -0600, Stephen Warren wrote:
> >> On 09/15/2013 08:57 PM, Benjamin Herrenschmidt wrote:
> >> > [resent to the right list this time aro
Hi José,
Please see my comments below.
On Wednesday 11 of September 2013 11:08:27 José Miguel Gonçalves wrote:
> The Samsung serial driver currently does not support setting the
> RTS pin with an ioctl(TIOCMSET) call. This patch adds this support.
>
> Signed-off-by: José Miguel Gonçalves
> ---
Hi Chander,
On Monday 16 of September 2013 11:01:22 Chander Kashyap wrote:
> Pass '0' in place of hardcoded "irq_base" value as "first_irq" parameter
> to "irq_domain_add_simple" in order to use linear irq domain.
>
> Signed-off-by: Chander Kashyap
> ---
> drivers/irqchip/exynos-combiner.c |
[Ccing Greg and Sylwester]
On Tuesday 17 of September 2013 14:03:35 José Miguel Gonçalves wrote:
> Hi Tomasz,
>
> On 17-09-2013 11:18, Tomasz Figa wrote:
> > Hi José,
> >
> > Please see my comments below.
> >
> > On Wednesday 11 of September 2013 11:08:2
Hi Felipe,
On Tuesday 17 of September 2013 10:36:16 Felipe Balbi wrote:
> Hi,
>
> On Tue, Aug 27, 2013 at 01:27:48PM -0700, Julius Werner wrote:
> > *Ping!*
> >
> > Are there still unanswered concerns left with this patch? I hope my
> > prior mails could clear up why I think that the PMU registe
On Tuesday 17 of September 2013 14:15:52 Olof Johansson wrote:
> On Tue, Sep 17, 2013 at 2:08 PM, Frank Rowand
wrote:
> > On 9/17/2013 9:43 AM, Olof Johansson wrote:
> >> On Tue, Sep 17, 2013 at 09:56:39AM +0200, Tomasz Figa wrote:
> >>> I'm afraid that I
On Tuesday 17 of September 2013 20:08:33 José Miguel Gonçalves wrote:
> On 17-09-2013 16:21, Tomasz Figa wrote:
> > I had the following scenario in mind:
> > 1) enable CRTSCTS,
> > 2) set RTS status using the IOCTL,
> > 3) disable CRTSCTS,
> > 4) do somet
ting in set_termios() also when
>enabling CRTSCTS.
>
> Signed-off-by: José Miguel Gonçalves
> ---
> drivers/tty/serial/samsung.c | 20 +---
> 1 file changed, 17 insertions(+), 3 deletions(-)
Looks good.
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
On Wednesday 04 of September 2013 10:41:31 Josh Boyer wrote:
> On Wed, Sep 4, 2013 at 10:36 AM, Tomasz Figa wrote:
> > Hi Josh,
> >
> > On Wednesday 04 of September 2013 10:13:16 Josh Boyer wrote:
> >> Using Linus' tree as of this morning (v3.11-2654-g458c3
Hi Josh,
On Wednesday 04 of September 2013 10:13:16 Josh Boyer wrote:
> Using Linus' tree as of this morning (v3.11-2654-g458c3f6), the
> exynos-cpufreq driver doesn't build because it includes a file that
> doesn't exist.
>
> + make -s ARCH=arm V=1 -j4 bzImage KALLSYMS_EXTRA_PASS=1
> arch/arm/ke
Hi Tony,
On Wednesday 04 of September 2013 10:59:09 Tony Lindgren wrote:
> * Haojian Zhuang [130903 20:11]:
> > We can see that it'll try to find static mapping. What's the static
> > mapping? If we define iotable in machine driver, we have the static
> > mapping, just like debug_ll. If we parse
On Friday 06 of September 2013 13:01:15 Stephen Warren wrote:
> On 09/06/2013 12:53 AM, Tero Kristo wrote:
> > On 09/05/2013 11:30 PM, Stephen Warren wrote:
> ...
>
> >> 1)
> >>
> >> At least for large SoCs (rather than e.g. a simple clock generator
> >> chip/crystal with 1 or 2 outputs), clock d
Hi Heiko,
First of all, big thanks for you work on this, letting our dream about
getting rid of S3C DMA API get closer to the reality. ;)
Overall the driver looks very good, but let me share some comments inline.
On Wednesday 28 of August 2013 00:13:51 Heiko Stübner wrote:
> This adds a new dri
Hi Alexandre,
Overall this looks good to me, but I have some minor comments.
On Thursday 29 of August 2013 18:57:44 Alexandre Courbot wrote:
> Trusted Foundations is a TrustZone-based secure monitor for ARM that
> can be invoked using a consistent smc-based API on all supported
> platforms. This
cate
> device tree parsing code in arch files
> - Added ability to initialize Trusted Foundations through platform data
> - Changed TF version number to integers
> - Refactored Kconfig menu for more clarity
Except some minor comments to patch 1/5, the series looks good to me.
Revi
w
> > redundant includes.
> >
> > Signed-off-by: Sebastian Hesselbarth
> > ---
>
> Ping,
This patch looks fine to me (as the whole series).
Reviewed-by: Tomasz Figa
I don't see any reason why this series could introduce a regression on
Exynos SoCs, but j
Hi Yadwinder,
I haven't reviewed this series yet, but let me clarify some things from
your comments.
On Thursday 26 of September 2013 17:38:58 Yadwinder Singh Brar wrote:
> > +
> > +/* Helper macros to define clock arrays. */
> > +#define FIXED_RATE_CLOCKS(name)\
> > + stati
All S3C64XX SoCs come with ARM1176JZF-s core, which fully supports
ARMv6K extensions. This patch lets the kernel use them on S3C6410 by
adding selection of CPU_V6K to ARCH_S3C64XX.
Signed-off-by: Tomasz Figa
---
arch/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
the problem, based on the fact that
irq_of_parse_and_map() configures the trigger based on DT interrupt
specifier and IRQD_TRIGGER_* flags are consistent with IORESOURCE_IRQ_*,
and we can get correct trigger flags by calling irqd_get_trigger_type()
after mapping the interrupt.
Signed-off-by: Tomasz
dereference for drivers that do not need any
overrides.
This patch fixes the problem by dereferencing the passed pointer to
ohci_driver_overrides struct only if it is non-NULL.
Signed-off-by: Tomasz Figa
---
drivers/usb/host/ohci-hcd.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions
All other platforms have this condition checked inside their own Kconfig
files, so for consistency this patch makes it this way for mach-s3c64xx
as well.
Signed-off-by: Tomasz Figa
---
arch/arm/Kconfig | 2 --
arch/arm/mach-s3c64xx/Kconfig | 4
2 files changed, 4 insertions
Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies
the Kconfig entry of s3c-camif driver to use the proper way of checking
for S3C64xx support - CONFIG_ARCH_S3C64XX.
Signed-off-by: Tomasz Figa
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1
Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies
the s3c-i2s-v2 driver to use the proper way of checking for S3C64xx
support - CONFIG_ARCH_S3C64XX.
Signed-off-by: Tomasz Figa
---
sound/soc/samsung/s3c-i2s-v2.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
CONFIG_PLAT_S3C64XX has been kept in place way too long since it was
marked as temporary in commit
110d85a ARM: S3C64XX: Eliminate plat-s3c64xx
After fixing all users of it in previous patches, this patch finally
kills this temporary Kconfig entry.
Signed-off-by: Tomasz Figa
---
arch/arm
Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies
the gpio-samsung driver to use the proper way of checking for S3C64xx
support - CONFIG_ARCH_S3C64XX.
Signed-off-by: Tomasz Figa
---
drivers/gpio/gpio-samsung.c | 8
1 file changed, 4 insertions(+), 4 deletions
allowing
positive clock indices and negative error codes to be returned. All
users of this function are adjusted as well to handle the return value
correctly.
Signed-off-by: Tomasz Figa
---
drivers/clk/clk.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff
Instead of calculating sizes of arrays manually, kcalloc() can be used
to allocate arrays of elements with defined size. This is just a cleanup
patch without any functional changes.
Signed-off-by: Tomasz Figa
---
drivers/clk/clk.c | 14 +++---
1 file changed, 7 insertions(+), 7
allocated in the beginning of the function.
Signed-off-by: Tomasz Figa
---
drivers/clk/clk.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 63f9ac1..32e2fed 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
On Friday 27 of September 2013 18:37:56 Yadwinder Singh Brar wrote:
> Hi Tomasz,
>
> On Thu, Sep 26, 2013 at 7:30 PM, Tomasz Figa wrote:
> > Hi Yadwinder,
> >
> > I haven't reviewed this series yet, but let me clarify some things
> > from
> > your co
On Saturday 28 of September 2013 23:00:27 Alan Stern wrote:
> On Sat, 28 Sep 2013, Tomasz Figa wrote:
> > A series of commit starting at
> >
> > 50a97e059b USB: OHCI: make ohci-exynos a separate driver
> >
> > and ending at
> >
> > b8ad5c3706
type to
external GPIO and fixing operation of HSMMC0.
Signed-off-by: Tomasz Figa
---
arch/arm/mach-s3c64xx/mach-mini6410.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/mach-s3c64xx/mach-mini6410.c
b/arch/arm/mach-s3c64xx/mach-mini6410.c
index 58d46a3..97ae470 100644
Hi Andrew,
This patch looks good overall, but I have some minor comments inline.
On Friday 20 of September 2013 14:13:52 Andrew Bresticker wrote:
> The Exynos AudioSS clock controller will later be modified to allow
> input clocks to be specified via device-tree in order to support
> multiple Exy
Hi Andrew,
On Friday 20 of September 2013 14:13:53 Andrew Bresticker wrote:
> This allows the input clocks to the Exynos AudioSS block to be
> specified via device-tree bindings. Default names will be used
> when an input clock is not given.
[snip]
> +Optional Properties:
> +
> +- clocks:
> + -
Hi Andrew,
On Friday 20 of September 2013 14:13:55 Andrew Bresticker wrote:
> The parent of sclk_pcm in the AudioSS block is div_pcm0.
>
> Signed-off-by: Andrew Bresticker
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exy
Hi Andrew,
On Friday 20 of September 2013 14:13:56 Andrew Bresticker wrote:
> The AudioSS block on Exynos 5420 has an additional clock gate for the
> ADMA bus clock.
>
> Signed-off-by: Andrew Bresticker
> ---
> Documentation/devicetree/bindings/clock/clk-exynos-audss.txt | 7
> +-- drivers/c
Hi Andrew,
On Friday 20 of September 2013 14:13:57 Andrew Bresticker wrote:
> The parent of sclk_pcm in the AudioSS block is sclk_maupcm0.
>
> Signed-off-by: Andrew Bresticker
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a
drew Bresticker
> ---
> Documentation/devicetree/bindings/clock/exynos5250-clock.txt | 1 +
> drivers/clk/samsung/clk-exynos5250.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
--
To unsubscribe fr
since v1:
> - Replaced irq_domain_add_simple with irq_domain_add_linear,
> as suggested by Tomasz
>
> drivers/irqchip/exynos-combiner.c | 15 +++
> 1 file changed, 3 insertions(+), 12 deletions(-)
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
--
T
rivers/media/platform/s5p-tv/mixer_vp_layer.c
> | 2 +-
> drivers/media/platform/s5p-tv/sdo_drv.c | 39 +++--
> 7 files changed, 137 insertions(+), 105 deletions(-)
For the whole series:
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
--
To unsubscribe from this list: send
include/dt-bindings/clock/samsung,s5pv210-clock.h
Very nice work. I hope we will be able to finally move S5PV210 to Device
Tree for 3.13 and drop all the legacy code.
Acked-by: Tomasz Figa
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu
Hi Mateusz,
On Monday 23 of September 2013 11:42:59 Mateusz Krawczuk wrote:
> Signed-off-by: Mateusz Krawczuk
> Signed-off-by: Kyungmin Park
> ---
> drivers/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 73
s driver.
>
> Signed-off-by: Mateusz Krawczuk
> Signed-off-by: Kyungmin Park
> ---
> arch/arm/plat-samsung/s5p-irq-eint.c | 4
> 1 file changed, 4 insertions(+)
Otherwise, after fixing commit message:
Acked-by: Tomasz Figa
Best regards,
Tomasz
--
To unsubscribe fro
Hi Mateusz,
On Monday 23 of September 2013 12:14:49 Mateusz Krawczuk wrote:
> It prevents from executing platform code, when booting from device tree.
>
> Signed-off-by: Mateusz Krawczuk
> Signed-off-by: Kyungmin Park
> ---
> arch/arm/plat-samsung/init.c | 3 +++
> 1 file changed, 3 insertions
Hi Mateusz,
On Monday 23 of September 2013 15:06:48 Mateusz Krawczuk wrote:
> This patch add clk and device tree nodes for samsung onenand driver.
>
> since v1:
> Updated Documentation according to Mark Rutland notes.
>
> Signed-off-by: Mateusz Krawczuk
> Signed-off-by: Kyungmin Park
> ---
>
Hi Mark,
On Monday 23 of September 2013 14:50:42 Mark Brown wrote:
> On Mon, Sep 23, 2013 at 11:45:45AM +0200, Mateusz Krawczuk wrote:
> > Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.
>
> > static const struct of_device_id s3c64xx_spi_dt_match[] = {
> > + { .compatible = "s
Hi Andrew,
I'd like to ack this series, but there is one more thing that I think
should be fixed. Please see my comment inline.
On Monday 23 of September 2013 17:21:13 Andrew Bresticker wrote:
> @@ -128,8 +135,53 @@ static void __init exynos_audss_clk_init(struct
> device_node *np)
> #endif
>
; 7 files changed, 58 insertions(+), 13 deletions(-)
>
For the whole series:
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Mateusz, Mark,
On Monday 23 of September 2013 15:08:23 Mark Rutland wrote:
> On Mon, Sep 23, 2013 at 02:06:48PM +0100, Mateusz Krawczuk wrote:
> > +
> > +Required properties:
> > + - compatible: value should be either of the following.
> > + (a) "samsung,s3c6400-onenand",
> > +
100644 drivers/clk/samsung/clk-s5pv210.c
> create mode 100644 include/dt-bindings/clock/samsung,s5pv210-clock.h
For this series:
Acked-by: Tomasz Figa
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tuesday 24 of September 2013 15:58:06 Sylwester Nawrocki wrote:
> Hi,
>
> On 24/09/13 14:50, Mateusz Krawczuk wrote:
> > +++ b/Documentation/devicetree/bindings/clock/samsung,s5pv210-clock.txt
> > @@ -0,0 +1,75 @@
> > +* Samsung S5PC110/S5PV210 Clock Controller
> > +
> > +The S5PV210 clock cont
++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Tomasz Figa
Best regards,
Tomasz
P.S. Please be more careful next time when defining things like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
ges since v1:
> - add clk_unregister() calls to remove callback
> - fixed minor nits from Tomasz
> ---
> drivers/clk/samsung/clk-exynos-audss.c | 109
> +++-- 1 file changed, 90 insertions(+), 19
> deletions(-)
For the whole series:
Acked-by: Tomasz Fi
/plat-samsung/s5p-irq-eint.c | 4
> 1 file changed, 4 insertions(+)
Acked-by: Tomasz Figa
[as a temporary solution until we move all the users of this code to
device tree]
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
Hi Yadwinder,
[resending in plain text, as my mail client somehow reset message
format from plain back to HTML...]
On Wednesday 25 of September 2013 19:25:54 Yadwinder Singh Brar wrote:
> Hi Lukasz,
>
> On Wed, Sep 25, 2013 at 4:52 PM, Lukasz Majewski
> wrote:
> > In the exynos4x12_set_apll()
ed to control status of the regulator is defined using the
gpio property and regulator-fixed driver uses of_get_named_gpio to get the
pin number from device tree.
Is this kind of setup also valid when using your pinctrl driver?
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
--
To
1 - 100 of 1789 matches
Mail list logo
