Re: [PATCH 2/5] arcmsr: Support Hibernation

2013-02-07 Thread Tomas Henzl
On 02/06/2013 09:36 AM, NickCheng wrote: > From: Nick Cheng > > Support hibernation for whole series of RAID controllers > Signed-off-by: Nick Cheng > --- Hi Nick, this patch (2/5) already uses msi-x in the PM part, while the "Support MSI and MSI-X" is added in the patch 3/5. You should switch

[PATCH] block: fix ext_devt_idr handling

2013-01-29 Thread Tomas Henzl
is called after device del. Signed-off-by: Tomas Henzl --- block/genhd.c | 6 +- block/partition-generic.c | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 9cf5583..9433636 100644 --- a/block/genhd.c +++ b/block/genhd.c @@

Re: [PATCH 1/3] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284

2013-08-26 Thread Tomas Henzl
On 08/26/2013 06:14 AM, 黃清隆 wrote: > From: Ching > > Support Areca new SATA Raid adapter ARC1214/1224/1264/1284. > Modify maximum outstanding command number, notify command complete with auto > request sense > Signed-off-by: Ching Hi Ching, +static bool +arcmsr_hbaD_get_config(struct AdapterCo

[PATCH v4 Repost 1/2] block: factor out vector mergeable decision to a, helper function

2013-09-27 Thread Tomas Henzl
From: Jan Vesely Export the function so it can be used to predict segment counts without calling the recalc function. This will be used in the next patch. Signed-off-by: Jan Vesely Signed-off-by: Tomas Henzl --- block/blk-merge.c | 52

[PATCH v4 Repost 2/2] block: modify __bio_add_page check to accept pages, that don't start a new segment

2013-09-27 Thread Tomas Henzl
: Jan Vesely Signed-off-by: Tomas Henzl --- fs/bio.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/fs/bio.c b/fs/bio.c index ea5035d..419bdd6 100644 --- a/fs/bio.c +++ b/fs/bio.c @@ -603,7 +603,6 @@ static int __bio_add_page(struct request_queue

Re: [PATCH v2] scsi: megaraid: check kzalloc

2013-06-04 Thread Tomas Henzl
On 06/04/2013 11:33 AM, Libo Chen wrote: > we should check kzalloc, avoid to hit oops > > Change from v1: > - put kzalloc outside of mutex > > Signed-off-by: Libo Chen Your patch looks fine to me: Acked-by: Tomas Henzl Cheers, Tomas -- To unsubscribe from this list: send the

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-29 Thread Tomas Henzl
On 05/24/2013 11:40 AM, Libo Chen wrote: > we should check kzalloc, avoid to hit oops > > Signed-off-by: Libo Chen > --- > drivers/scsi/megaraid.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > instead of checking scmd->device, sdev is more appropriate. > > diff --git a/drive

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-29 Thread Tomas Henzl
On 05/24/2013 11:40 AM, Libo Chen wrote: > we should check kzalloc, avoid to hit oops > > Signed-off-by: Libo Chen > --- > drivers/scsi/megaraid.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > instead of checking scmd->device, sdev is more appropriate. > > diff --git a/drive

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-30 Thread Tomas Henzl
On 05/30/2013 04:32 AM, Libo Chen wrote: > On 2013/5/30 9:38, Libo Chen wrote: >> On 2013/5/29 23:03, Tomas Henzl wrote: >>> On 05/24/2013 11:40 AM, Libo Chen wrote: >>>> we should check kzalloc, avoid to hit oops >>>> >>>> Signed-off-by: Li

Re: [PATCH 1/1] cciss: set max scatter gather entries to 32 on P600

2013-08-15 Thread Tomas Henzl
the P600 to use >> only 32 scatter gather elements. Other controllers are not affected. >> >> Signed-off-by: Mike Miller >> Signed-off-by: Dwight (Bud) Brown >> Signed-off-by: Tomas Henzl >> Acked-by: Stephen M. Cameron > I don't quite understand the s

Re: [PATCH] cciss: use lun reset not target reset

2013-04-10 Thread Tomas Henzl
almost the same patch has been accepted for hpsa so Acked-by: Tomas Henzl On 01/07/2013 05:30 PM, Stephen M. Cameron wrote: > From: Stephen M. Cameron > > In the scsi part of the driver (for tape drives and medium changers) > the device reset error handler attempts to use a target

Re: [PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-16 Thread Tomas Henzl
On 06/12/2015 11:42 AM, Sreekanth Reddy wrote: > Driver initialization fails if driver tries to send IOC facts request message > when the IOC is in reset or in a fault state. > > This patch will make sure that > 1.Driver to send IOC facts request message only if HBA is in operational or > ready

Re: [PATCH v1 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-17 Thread Tomas Henzl
he driver. > > Changes in v1: >If PCI Recovery is on then return with -EFAULT in the function > _base_wait_for_iocstate(). > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-05 Thread Tomas Henzl
On 3/4/21 6:00 PM, don.br...@microchip.com wrote: > -Original Message- > From: Sergei Trofimovich [mailto:sly...@gmail.com] > Sent: Wednesday, March 3, 2021 4:04 PM > To: Don Brace - C33706 > Cc: glaub...@physik.fu-berlin.de; storagedev ; > linux-s...@vger.kernel.org; linux-i...@vger.ker

Re: [PATCH] cciss: return 0 from driver probe function on success, not 1

2013-11-01 Thread Tomas Henzl
On 10/31/2013 11:06 PM, Andrew Morton wrote: > On Thu, 31 Oct 2013 16:54:44 -0500 scame...@beardog.cce.hp.com wrote: > How did this ever work? >>> Beats me. local_pci_probe() does >>> >>> rc = pci_drv->probe(pci_dev, ddi->id); >>> if (rc) { >>> pci_dev->driver = NULL; >>>

Re: [PATCH] cciss: return 0 from driver probe function on success, not 1

2013-11-01 Thread Tomas Henzl
On 11/01/2013 03:08 PM, scame...@beardog.cce.hp.com wrote: > On Fri, Nov 01, 2013 at 06:31:10AM -0700, Andrew Morton wrote: >> On Fri, 01 Nov 2013 14:06:45 +0100 Tomas Henzl wrote: >> >>> The problem in kernel is that the error handling in local_pci_probe >>&

Re: [PATCH 1/15] block copy: initial XCOPY offload support

2014-07-18 Thread Tomas Henzl
On 07/15/2014 09:34 PM, Mikulas Patocka wrote: > This is Martin Petersen's xcopy patch > (https://git.kernel.org/cgit/linux/kernel/git/mkp/linux.git/commit/?h=xcopy&id=0bdeed274e16b3038a851552188512071974eea8) > with some bug fixes, ported to the current kernel. > > This patch makes it possible to

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Tomas Henzl
Hi, patch looks good. A correction in pm8001_request_irq might be added too to allow the INT-X path when pm8001_setup_msix fails, but that is not part of this fix. Tomas Reviewed-by: Tomas Henzl On 07/16/2014 08:05 PM, Alexander Gordeev wrote: > When a call to request_irq() fai

Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

2014-07-29 Thread Tomas Henzl
On 07/29/2014 03:20 PM, Christoph Hellwig wrote: > On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote: >> Hi, >> patch looks good. >> >> A correction in pm8001_request_irq might be added too to allow >> the INT-X path when pm8001_setup_msix fails, but

Re: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Tomas Henzl
On 01/16/2014 08:51 PM, Mike Miller wrote: > From: Mike Miller > > This patch has every ID we have in our svn repository. Some controllers were > cancelled, others added, now the cancelled ones are back. Apparently the > debate rages on about which controllers are cancelled, which are not, > whate

Re: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Tomas Henzl
On 01/17/2014 04:31 PM, Hannes Reinecke wrote: > On 01/17/2014 04:17 PM, Miller, Mike (OS Dev) wrote: >> >>> -Original Message----- >>> From: Tomas Henzl [mailto:the...@redhat.com] >>> Sent: Friday, January 17, 2014 9:14 AM >>> To: Miller, Mike (

Re: [PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-24 Thread Tomas Henzl
tindex; > + int32_t wqbuf_putIndex; > /* last of write buffer */ > uint8_t > devstate[ARCMSR_MAX_TARGETID][ARCMSR_MAX_TARGETLUN]; > /* id0 . id15, lun0...lun7 */ The comments I've added are not directly r

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-11 Thread Tomas Henzl
On 09/11/2014 05:59 AM, Ching Huang wrote: > On Wed, 2014-09-10 at 11:58 +0200, Tomas Henzl wrote: >> On 09/09/2014 06:30 PM, Christoph Hellwig wrote: >>> Ching, >>> >>> do you have a chance to address Thomas second concern below? As >>> far as I ca

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-12 Thread Tomas Henzl
On 09/12/2014 09:29 AM, Ching Huang wrote: > From: Ching Huang > > This patch is to modify previous patch 13/17 and it is relative to > http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr > > change in v4: > 1. for readability, rename firstindex to getIndex,

Re: [PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-12 Thread Tomas Henzl
On 09/12/2014 10:22 AM, Ching Huang wrote: > From: Ching Huang > > This patch is to modify previous patch 16/17 and it is relative to > http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr > > change in v4: > 1. clean up of duplicate variable declaration in s

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Tomas Henzl
On 09/15/2014 04:56 AM, Ching Huang wrote: > On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: >> On 09/12/2014 09:29 AM, Ching Huang wrote: >>> From: Ching Huang >>> >>> This patch is to modify previous patch 13/17 and it is relative to >>> http

Re: [PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Tomas Henzl
On 09/15/2014 06:34 AM, Ching Huang wrote: > On Fri, 2014-09-12 at 16:05 +0200, Tomas Henzl wrote: >> On 09/12/2014 10:22 AM, Ching Huang wrote: >>> From: Ching Huang >>> >>> This patch is to modify previous patch 16/17 and it is relative to >>> http

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Tomas Henzl
On 09/15/2014 12:36 PM, Ching Huang wrote: > On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: >> On 09/15/2014 04:56 AM, Ching Huang wrote: >>> On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: >>>> On 09/12/2014 09:29 AM, Ching Huang wrote: >>>>&

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-15 Thread Tomas Henzl
On 09/10/2014 11:58 AM, Tomas Henzl wrote: > On 09/09/2014 06:30 PM, Christoph Hellwig wrote: >> Ching, >> >> do you have a chance to address Thomas second concern below? As >> far as I can tell (Thomas, please correct me) that's the last >> outstanding con

Re: [PATCH v5 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Tomas Henzl
; 1. add spin_lock in arcmsr_done4abort_postqueue for protect doneq_index. > 2. fix spinlock area in arcmsr_hbaD_polling_ccbdone. You might have kept the previous change log here too, it's probably better when merged with the 16/17. I have no more concerns, so Reviewed-by: Tomas Henzl -- To unsubscribe

Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-16 Thread Tomas Henzl
er calling flush_work instead > of flush_scheduled_work. Yes, I think now this is correct, I have no more objections. Thanks, Tomas, > > > On Thu, 2014-05-15 at 13:52 +0200, Tomas Henzl wrote: >> On 05/15/2014 12:49 PM, ching wrote: >>> Hi Tomas, >>> >>&g

Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-14 Thread Tomas Henzl
On 05/14/2014 01:55 PM, ching wrote: > From: Ching > > This is a new patch after patch v1.1 series. > > Fixed calling scsi_scan_host until all initialization are done. > And fixed error path free allocated resource. > > Signed-off-by: Ching > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c >

Re: [PATCH v1.2 17/16] arcmsr: fixed calling scsi_scan_host after all initialization done

2014-05-15 Thread Tomas Henzl
rces means that you use the global queue. If that is true, flush_scheduled_work is the right choice. > > On Wed, 2014-05-14 at 14:53 +0200, Tomas Henzl wrote: >> On 05/14/2014 01:55 PM, ching wrote: >>> From: Ching >>> >>> This is a new patch after patch v1.1

Re: [PATCH v1.1 2/16 update 3] arcmsr: Adding code to support MSI-X interrupt

2014-05-09 Thread Tomas Henzl
arcmsr_flush_adapter_cache(acb); > +scsi_host_remove: > + scsi_remove_host(host); > +free_ccb_pool: > arcmsr_free_ccb_pool(acb); > free_hbb_mu: > arcmsr_free_mu(acb); > > > > On Wed, 2014-05-07 at 16:31 +0200, Tomas Henzl wrote: >> On 05/07

Re: [PATCH v1.1 2/16 update 3] arcmsr: Adding code to support MSI-X interrupt

2014-05-12 Thread Tomas Henzl
; free_hbb_mu: > arcmsr_free_mu(acb); > > > > On Fri, 2014-05-09 at 13:15 +0200, Tomas Henzl wrote: >> On 05/08/2014 01:37 PM, ching wrote: >>> Hi Tomas, >>> >>> Thanks for your suggestion. >>> I will add a new patch 17/17 at last. >

Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

2014-05-28 Thread Tomas Henzl
On 05/28/2014 01:28 PM, Christoph Hellwig wrote: > On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote: >> There is otherwise a risk of a possible null pointer dereference. >> >> Was largely found by using a static code analysis program called cppcheck. > I can't see how dev->lldd_d

Re: [PATCH v1.1 2/16 update] arcmsr: Adding code to support MSI-X interrupt

2014-05-05 Thread Tomas Henzl
On 05/05/2014 01:15 PM, ching wrote: > From: Ching > > Adding code for supporting MSI-X interrupt. > > This update is for fixing bug of previous [PATCH v1.1 2/16]. > > Signed-off-by: Ching > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h > --- a/drivers/scsi/arcmsr

Re: [PATCH v1.1 2/16 update 2] arcmsr: Adding code to support MSI-X interrupt

2014-05-06 Thread Tomas Henzl
On 05/06/2014 10:17 AM, ching wrote: > From: Ching > > Adding code to support MSI-X interrupt. > > This update has modification by Tomas' suggestion. > And I add a msix_vector_count for free_irq. > > Signed-off-by: Ching > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcm

Re: [PATCH v1.1 2/16 update 3] arcmsr: Adding code to support MSI-X interrupt

2014-05-07 Thread Tomas Henzl
On 05/07/2014 01:52 PM, ching wrote: > From: Ching > > Adding code to support MSI-X interrupt. > > This update has made change by Tomas' and Alexander's suggestion. > > Signed-off-by: Ching > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h > --- a/drivers/scsi/arcms

Re: [PATCH v3 13/13] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-21 Thread Tomas Henzl
xact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. Patch looks good. Reviewed-by: Tomas Henzl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [PATCH v3 12/13] pmcraid: Get rid of a redundant assignment

2014-08-21 Thread Tomas Henzl
vector = pdev->irq; > pinstance->num_hrrq = 1; > - rc = 0; > > rc = request_irq(pdev->irq, pmcraid_isr, IRQF_SHARED, >PMCRAID_DRIVER_NAME, &pinstance->hrrq_vector[0]); Patch looks good to me. Reviewed-by: Tomas Henzl -- To uns

Re: [PATCH v3 11/13] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-21 Thread Tomas Henzl
On 08/21/2014 01:32 PM, Tomas Henzl wrote: > On 08/18/2014 08:01 AM, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interfaces need to be upda

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-22 Thread Tomas Henzl
On 08/19/2014 09:17 AM, Ching Huang wrote: > From: Ching Huang > > Rewrite ioctl entry and its relate function. > This patch fix ioctl data read/write error and change data I/O access from > byte to Dword. > > Signed-off-by: Ching Huang > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c >

Re: [PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-22 Thread Tomas Henzl
On 08/19/2014 05:02 PM, Christoph Hellwig wrote: > Hi Ching, > > I've fixed up various checkpatch errors and fixed up some descriptions > and applied the patches to a branch. This includes patch 4, so please > send a fix for this and any other patches relative to the branch. > > Please find the br

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Tomas Henzl
On 08/25/2014 07:59 PM, Ching Huang wrote: > On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: >> On 08/19/2014 09:17 AM, Ching Huang wrote: >>> From: Ching Huang >>> >>> Rewrite ioctl entry and its relate function. >>> This patch fix ioctl dat

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Tomas Henzl
On 08/25/2014 12:29 PM, Tomas Henzl wrote: > On 08/25/2014 07:59 PM, Ching Huang wrote: >> On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: >>> On 08/19/2014 09:17 AM, Ching Huang wrote: >>>> From: Ching Huang >>>> >>>> Rewrite ioctl en

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-26 Thread Tomas Henzl
On 08/26/2014 10:27 PM, Ching Huang wrote: > On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: >> On 08/25/2014 07:59 PM, Ching Huang wrote: >>> On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: >>>> On 08/19/2014 09:17 AM, Ching Huang wrote: >>>&g

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Tomas Henzl
On 08/27/2014 10:19 PM, Ching Huang wrote: > On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: >> On 08/26/2014 10:27 PM, Ching Huang wrote: >>> On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: >>>> On 08/25/2014 07:59 PM, Ching Huang wrote: >>>>

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-27 Thread Tomas Henzl
On 08/19/2014 09:25 AM, Ching Huang wrote: > From: Ching Huang > > Add code for supporting Areca new Raid adapter ARC12x4 series. > > Signed-off-by: Ching Huang > --- Hi Ching, please look at the comments below - > } > @@ -1039,7 +1147,60 @@ static void arcmsr_done4abort_postqueue( >

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-28 Thread Tomas Henzl
On 08/28/2014 05:46 PM, Ching Huang wrote: > On Wed, 2014-08-27 at 16:00 +0200, Tomas Henzl wrote: >> On 08/19/2014 09:25 AM, Ching Huang wrote: >>> From: Ching Huang >>> >>> Add code for supporting Areca new Raid adapter ARC12x4 series. >>> >&g

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-10 Thread Tomas Henzl
On 09/09/2014 06:30 PM, Christoph Hellwig wrote: > Ching, > > do you have a chance to address Thomas second concern below? As > far as I can tell (Thomas, please correct me) that's the last > outstanding concern, and I'd really like to merge the arcmsr updates > for the Linux 3.18 merge window. C

Re: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range()

2014-08-21 Thread Tomas Henzl
> interfaces. Patch looks good to me. Reviewed-by: Tomas Henzl > Signed-off-by: Alexander Gordeev > Cc: Jayamohan Kallickal > Cc: linux-s...@vger.kernel.org > Cc: linux-...@vger.kernel.org > --- > drivers/scsi/be2iscsi/be_main.c | 6 +++--- > 1 file changed, 3 insertio

Re: [PATCH v3 09/13] csiostor: Remove superfluous call to pci_disable_msix()

2014-08-21 Thread Tomas Henzl
On 08/18/2014 08:01 AM, Alexander Gordeev wrote: > There is no need to call pci_disable_msix() in case > the previous call to pci_enable_msix() failed Patch looks good to me. Reviewed-by: Tomas Henzl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v3 10/13] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-21 Thread Tomas Henzl
xact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. Patch looks good to me. Reviewed-by: Tomas Henzl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 11/13] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-21 Thread Tomas Henzl
On 08/18/2014 08:01 AM, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enabl

Re: [RESEND][PATCH 7/8][SCSI]mpt3sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-08-06 Thread Tomas Henzl
On 08/05/2014 06:41 PM, Sreekanth Reddy wrote: > Hi Tomas, > > Can you please review this updated patch, Hi Sreekanth, the patch is mangled so a resend is needed anyway and I think you will probably also want implement the changes you were asked for in the mpt2sas sibling of this patch. Thanks, To

Re: [PATCH v1.3 1/18] arcmsr: Revised interrupt service routine relate function to fix bug

2014-08-07 Thread Tomas Henzl
> + (ARCMSR_HBCMU_OUTBOUND_POSTQUEUE_ISR | > + ARCMSR_HBCMU_OUTBOUND_DOORBELL_ISR); > + if (!host_interrupt_status) > + return IRQ_NONE; > + do { > + if (host_interrupt_status & ARCMSR_HBCMU_OUTBOUND_DOORBELL_ISR) > +

Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-07 Thread Tomas Henzl
On 08/04/2014 06:00 AM, Ching Huang wrote: > On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote: >>> @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru >>> arcmsr_handle_virtual_command(acb, cmd); >>> return 0; >>> } >>> - if (atomic_read(&acb->ccbo

Re: [PATCH v1.3 3/18] arcmsr: Add code to support system hibernation

2014-08-07 Thread Tomas Henzl
On 08/01/2014 10:36 AM, Ching Huang wrote: > This patch adds code to support system hibernation. > > Signed-off-by: Ching > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c > b/drivers/scsi/arcmsr/arcmsr_hba.c > --- a/drivers/scsi/arcmsr/arcmsr_hba.c2014-08-01 11:03:00.0 > +0

Re: [PATCH v2 3/17] arcmsr: Add code to support system hibernation

2014-08-08 Thread Tomas Henzl
On 08/08/2014 02:05 PM, Ching Huang wrote: > From: Ching Huang > > This patch adds code to support system hibernation. > > Changes in v2 of 3/17: > * merge patch 18/18 to this patch Thanks, and please mark the the 18/18 as obsolete - add a comment there In my previous response were other commen

Re: [PATCH v2 RESEND 16/23] mpt3sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-08-11 Thread Tomas Henzl
xact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Signed-off-by: Alexander Gordeev > Cc: Nagalakshmi Nandigama > Cc: Sreekanth Reddy > Cc: supp...@lsi.com > Cc: dl-mptfusionli...@lsi.com > Cc: linux-s...@vger.kernel.org > Cc: linux-...@vger.

Re: [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-08-11 Thread Tomas Henzl
xact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Signed-off-by: Alexander Gordeev > Cc: Nagalakshmi Nandigama > Cc: Sreekanth Reddy > Cc: supp...@lsi.com > Cc: dl-mptfusionli...@lsi.com > Cc: linux-s...@vger.kernel.org > Cc: linux-...@vger.

Re: [RESEND][PATCH 7/8][SCSI]mpt3sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-08-05 Thread Tomas Henzl
On 06/25/2014 12:41 PM, Reddy, Sreekanth wrote: > Up to now, Driver allocates a single contiguous block of memory > pool for all reply queues and passes down a single address in the > ReplyDescriptorPostQueueAddress field of the IOC Init Request > Message to the firmware. > > When firmware receives

Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

2016-05-10 Thread Tomas Henzl
On 6.5.2016 10:59, Chaitra P B wrote: > Replaced mpt3sas_base_flush_reply_queues()with > mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() > skips over reply queues that are currently busy (i.e. being handled > by interrupt processing in another core). If a reply queue is busy, >

Re: [PATCH 1/6] mpt3sas: Update MPI header to 2.00.42

2016-05-11 Thread Tomas Henzl
A_ACTIVE_CABLE_EXCEPT > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 3/6] mpt3sas: Fix initial Reference tag field for 4K PI drives.

2016-05-11 Thread Tomas Henzl
On 6.5.2016 10:59, Chaitra P B wrote: > Modified driver code to use scsi_prot_ref_tag() API instead of > scsi_get_lba(), while initializing reference tag field in the CDB. > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 2/6] mpt3sas: Handle active cable exception event

2016-05-11 Thread Tomas Henzl
connected to this active cable will not be seen. This active > cable requires of power" > > This event is only for Intruder/Cutlass HBAs. > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 4/6] mpt3sas: Updating mpt3sas driver version to 13.100.00.00

2016-05-11 Thread Tomas Henzl
R_VERSION "13.100.00.00" > +#define MPT3SAS_MAJOR_VERSION13 > #define MPT3SAS_MINOR_VERSION 100 > #define MPT3SAS_BUILD_VERSION0 > #define MPT3SAS_RELEASE_VERSION 00 Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 5/6] mpt3sas: Set maximum transfer length per IO to 4MB for VDs

2016-05-11 Thread Tomas Henzl
On 6.5.2016 10:59, Chaitra P B wrote: > Set maximum transfer length per IO on RAID volumes > to 4MB by setting VD's queue's max_sector to 8192. > > Signed-off-by: Chaitra P B Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

2016-05-11 Thread Tomas Henzl
On 11.5.2016 05:53, Sreekanth Reddy wrote: > On Tue, May 10, 2016 at 6:41 PM, Tomas Henzl wrote: >> On 6.5.2016 10:59, Chaitra P B wrote: >>> Replaced mpt3sas_base_flush_reply_queues()with >>> mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() >>&

Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

2015-11-13 Thread Tomas Henzl
driver's > 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch. > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

Re: [PATCH 1/3] arcmsr: modify codes for more readable

2015-11-27 Thread Tomas Henzl
On 26.11.2015 12:33, Ching Huang wrote: > From: Ching Huang > > modify codes for more readable > > Signed-of-by: Ching Huang Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH 2/3] arcmsr: Split dma resource allocation to a new function

2015-11-27 Thread Tomas Henzl
gt;> acb->host->host_no); >>> + return false; >>> + } >>> + memset(dma_coherent, 0, acb->roundup_ccbsize); >>> >> There is a dma_zalloc_coherent >> >> (and even more trivially) >> >> Most all o

Re: [PATCH 3/3] arcmsr: change driver version to v1.30.00.22-20151126

2015-11-27 Thread Tomas Henzl
On 26.11.2015 12:44, Ching Huang wrote: > From: Ching Huang > > change driver version to v1.30.00.22-20151126 > > Signed-of-by: Ching Huang Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-25 Thread Tomas Henzl
On 25.11.2015 12:41, Ching Huang wrote: > From: Ching Huang > > Releasing allocated resource if get configuration data failed. > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c > b/drivers/scsi/arcmsr/arcmsr_hba.c > --- a/drivers/scsi/arcmsr/arcmsr_hba.c

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-26 Thread Tomas Henzl
On 26.11.2015 08:32, Ching Huang wrote: > On Wed, 2015-11-25 at 14:55 +0100, Tomas Henzl wrote: >> On 25.11.2015 12:41, Ching Huang wrote: >>> From: Ching Huang >>> >>> Releasing allocated resource if get configuration data failed. >>> >>> Sig

Re: [PATCH] scsi: mvsas: fix indenting on return error code

2016-01-05 Thread Tomas Henzl
_IS_GONE() failure. > > The incorrect indenting was introduced by commit > 0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support > for Task collector mode and fixed relative bugs") > > No functional change, just a minor code reformatting clean up. > >

Re: [PATCH 1/2] mpt3sas: Deallocate resources before trying reallocation of the same in _base_allocate_memory_pools()

2016-02-17 Thread Tomas Henzl
ools(struct MPT3SAS_ADAPTER >> *ioc, int sleep_flag) >> goto out; >> retry_sz += 64; >> ioc->hba_queue_depth = max_request_credit - retry_sz; >> +_base_release_memory_pools(ioc); >> goto retry_allocation; Thanks for posting Reviewed-by: Tomas Henzl

Re: [PATCH] fusion-mptbase: handle failed allocation for workqueue

2016-02-17 Thread Tomas Henzl
On 16.2.2016 21:52, Ewan Milne wrote: > On Tue, 2016-02-16 at 13:33 -0500, Insu Yun wrote: >> >> On Tue, Feb 16, 2016 at 1:18 PM, Ewan Milne wrote: >> On Mon, 2016-02-15 at 21:50 -0500, Insu Yun wrote: >> > the failure of ioc->reset_work_q is checked, >> > but not ioc->fw_e

Re: [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.

2016-02-18 Thread Tomas Henzl
_base_release_memory_pools(ioc); > goto retry_allocation; > } > Reviewed-by: Tomas Henzl

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-19 Thread Tomas Henzl
On 18.2.2016 17:55, Ewan Milne wrote: > On Thu, 2016-02-18 at 11:40 -0500, Ewan Milne wrote: >> It also appears to me upon further inspection that the existing code has >> other problems. In particular, once mpt_mapresources() has returned >> with a nonzero error code, it looks like iounmap() shou

Re: [mpt3sas driver 06/10] mpt3sas: Added smp_affinity_enable module parameter.

2016-02-08 Thread Tomas Henzl
umask_var. --tm > > We incorporated other review comments for freeing reply_q and > cpumask_var in this patch and sending it soon. > > Thanks, > Suganath prabu S > > On Thu, Feb 4, 2016 at 8:31 PM, Tomas Henzl wrote: >> On 28.1.2016 07:37, Suganath prabu Subarama

Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable Chain Frame Size

2016-02-08 Thread Tomas Henzl
On 5.2.2016 08:56, Sreekanth Reddy wrote: > On Thu, Feb 4, 2016 at 8:35 PM, Tomas Henzl wrote: >> On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >>> From: Suganath prabu Subramani >>> >>> Added support for configurable Chain Frame Size. Calculate the &

Re: [mpt3sas driver V1 6/10] mpt3sas: Added smp_affinity_enable module parameter.

2016-02-09 Thread Tomas Henzl
gt; - cpumask_clear(reply_q->affinity_hint); > + if (smp_affinity_enable) { > + if (!zalloc_cpumask_var(&reply_q->affinity_hint, GFP_KERNEL)) { > + kfree(reply_q); > + return -ENOMEM; > + } > + cpumask_clear(reply_q->affinity_hint); I think, that with zalloc_cpumask_var we no more need the cpumask_clear here Please remove it in next patchset. Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 0/2] mpt{2,3}sas remove disconnected phys on topology change

2014-12-02 Thread Tomas Henzl
revert back these > patch set changes. > > Regards, > Sreekanth > >> -Original Message- >> From: Jan Vesely [mailto:jves...@redhat.com] >> Sent: Thursday, August 01, 2013 3:31 PM >> To: linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org >> Cc:

Re: [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change."

2014-12-03 Thread Tomas Henzl
sue which the original patch should have fixed, so it's fine to remove it. Reviewed-by: Tomas Henzl > Cc: > Cc: Tomas Henzl > Signed-off-by: Sreekanth Reddy > --- > drivers/scsi/mpt2sas/mpt2sas_transport.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) &

Re: [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change"

2014-12-03 Thread Tomas Henzl
rives connected Enclosure/Expander will unregister with > SCSI Transport Layer, if any one remove and add expander > cable with in DMD (Device Missing Delay) time period or > even any one power-off and power-on the Enclosure with in > the DMD period. Reviewed-by: Tomas Henzl > >

Re: [PATCH] mpt2sas: mpt3sas: Fix memory corruption during initialization

2015-05-05 Thread Tomas Henzl
On 05/04/2015 05:05 PM, Sreekanth Reddy wrote: > I have applied this patch on the latest upstream mpt3sas driver, then I have > compiled and loaded the driver. > In the driver logs I didn't see any attached drives are added to the OS, > 'fdisk -l' command also doesn't list > the drives which are

[PATCH 1/2] cciss: remove duplicate entries from board_type struct

2015-02-17 Thread Tomas Henzl
and devices not supported by this driver from unresettable list Signed-off-by: Tomas Henzl --- drivers/block/cciss.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index ff20f192b0..48498220cd 100644 --- a/drivers/block/cciss.c +++ b/drivers

[PATCH 2/2] cciss: correct the non-resettable board list

2015-02-17 Thread Tomas Henzl
The hpsa driver carries a more recent version, copy the table from there. Signed-off-by: Tomas Henzl --- drivers/block/cciss.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 48498220cd..0ca65b25ef

Re: [PATCH V3 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

2016-12-06 Thread Tomas Henzl
On 5.12.2016 17:27, Sasikumar Chandrasekaran wrote: > This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 11 ++- > drivers/scsi/megaraid/megaraid_sas_base.c | 20

Re: [PATCH V4 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

2016-12-08 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers > > V4: Removed the not supported PCI Device Ids > > Signed-off-by: Sasikumar Chandrasekaran The V4 does not panic my machine like the V3. Rev

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-08 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X > vectors, > resulting in the need to support 128 reply queues > > This patch is depending on patch 1 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/sc

Re: [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers

2016-12-08 Thread Tomas Henzl
or PI types 1 > and 2. > A value of 3 should be set to disable all PI checks if the Logical Block > Application > Tag is 0x and the Logical Block Reference Tag is 0x for PI type 3. > > This patch is depending on patch 2 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-08 Thread Tomas Henzl
w. Reviewed-by: Tomas Henzl Tomas

Re: [PATCH] scsi: aic94xx: Add a missing call to kfree

2016-11-22 Thread Tomas Henzl
On 19.11.2016 18:40, Quentin Lambert wrote: > Most error branches following the call to kzalloc contain > a call to kfree. This patch add these calls where they are > missing. > > This issue was found with Hector. Hi Quentin, most error branches also do set the freed pointer to NULL, please do the

Re: [PATCH] scsi: pmcraid: Add missing resource releases

2016-11-22 Thread Tomas Henzl
ain > a call to class_destroy. This patch add these calls where they are > missing. > > This issue was found with Hector. > > Signed-off-by: Quentin Lambert Looks good, Reviewed-by: Tomas Henzl Tomas > > --- > drivers/scsi/pmcraid.c | 10 +++--- > 1 file chang

Re: [PATCH v2] scsi: aic94xx: Add a missing call to kfree

2016-11-28 Thread Tomas Henzl
entin Lambert Looks good, Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:50, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:43 PM > To: 'Tomas Henzl&#x

Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:49 PM > To: 'Tomas Henzl&#x

  1   2   >