Hi Hans,
On 18.08.2017 10:45, Hans Verkuil wrote:
> Hi Todor,
>
> A few small comments below:
>
> On 08/08/2017 03:30 PM, Todor Tomov wrote:
>> Add a document to describe Qualcomm Camera Subsystem driver.
>>
>> Signed-off-by: Todor Tomov
>>
Add abbreviations explanation at the top header blocks in source files.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss-8x16/camss-csid.c | 2 +-
drivers/media/platform/qcom/camss-8x16/camss-csid.h | 2 +-
drivers/media/platform/qcom/camss-8x16/camss-ispif.c | 2 +-
drivers
Add explanations for VFE's PIX and RDI interfaces.
Signed-off-by: Todor Tomov
---
Documentation/media/v4l-drivers/qcom_camss.rst | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/media/v4l-drivers/qcom_camss.rst
b/Documentation/media/v4l-dr
> [auto build test ERROR on linuxtv-media/master]
> [also build test ERROR on v4.12-rc6 next-20170620]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Todor-To
Hi Daniel,
On 16.10.2017 18:01, Daniel Mack wrote:
> Hi,
>
> On 28.08.2017 09:10, Todor Tomov wrote:
>> On 25.08.2017 17:10, Daniel Mack wrote:
>>> Could you explain how ISPIF, CSID and CSIPHY are related?
>>>
>>> I have a userspace test setup
ISPIF hardware modules on 8x16 and 8x96 are similar. However on
8x96 the ISPIF routes data to two VFE hardware modules. Add
separate interrupt handler for 8x96 to handle the additional
interrupts.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-ispif.c | 76
Update the document to describe the support of Camera Subsystem
on MSM8996/APQ8096.
Signed-off-by: Todor Tomov
---
Documentation/media/v4l-drivers/qcom_camss.rst | 93 +++---
.../media/v4l-drivers/qcom_camss_8x96_graph.dot| 104 +
2 files changed, 164
Restructure lane configuration so it is simpler and will allow
similar (although not the same) handling for different hardware
versions.
Signed-off-by: Todor Tomov
---
.../platform/qcom/camss/camss-csiphy-2ph-1-0.c | 48 --
drivers/media/platform/qcom/camss/camss
The new format will be called V4L2_PIX_FMT_Y10P.
It is similar to the V4L2_PIX_FMT_SBGGR10P family formats
but V4L2_PIX_FMT_Y10P is a grayscale format.
Signed-off-by: Todor Tomov
---
Documentation/media/uapi/v4l/pixfmt-y10p.rst | 33
Documentation/media/uapi/v4l/yuv
The code will be called MEDIA_BUS_FMT_Y10_2X8_PADHI_LE.
It is similar to MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE
but MEDIA_BUS_FMT_Y10_2X8_PADHI_LE describes grayscale
data.
Signed-off-by: Todor Tomov
---
Documentation/media/uapi/v4l/subdev-formats.rst | 72 +
include/uapi
From: Sakari Ailus
These formats are compressed 14-bit raw bayer formats with four different
pixel orders. They are similar to 10-bit variants. The formats added by
this patch are
V4L2_PIX_FMT_SBGGR14P
V4L2_PIX_FMT_SGBRG14P
V4L2_PIX_FMT_SGRBG14P
V4L2_PIX_FMT_SRGGB
Hi Sakari,
Thank you for review.
On 24.07.2018 15:49, Sakari Ailus wrote:
> Hi Todor,
>
> On Mon, Jul 23, 2018 at 02:02:35PM +0300, Todor Tomov wrote:
>> There is a PM domain for each of the VFE hardware modules. Add
>> support for basic runtime PM support to be able
On 24.07.2018 15:21, Sakari Ailus wrote:
> Hi Todor,
>
> On Mon, Jul 23, 2018 at 02:02:34PM +0300, Todor Tomov wrote:
> ...
>> @@ -61,7 +59,8 @@ struct ispif_device {
>> struct mutex power_lock;
>> struct ispif_intf_cmd_reg intf_cmd[MSM_ISPIF_VFE_NUM];
&g
Hi Sakari,
Thanks for review.
On 24.07.2018 15:52, Sakari Ailus wrote:
> Hi Todor,
>
> On Mon, Jul 23, 2018 at 02:02:52PM +0300, Todor Tomov wrote:
>> This removes warning "Unknown pixelformat" for the following formats:
>> V4L2_PIX_FMT_SBGGR14P
&
V4L2_PIX_FMT_SRGGB14P
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Signed-off-by: Todor Tomov
---
Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 +
Documentation/media/uapi/v4l/pixfmt-srggb14p.rst | 127 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 4 +
include/uapi
and
independent control of the PM domains.
Suspend/Resume is still not supported.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 13 -
drivers/media/platform/qcom/camss/camss-csiphy.c | 15 +-
drivers/media/platform/qcom/camss/camss-ispif.c | 26
Update the document to describe the support of Camera Subsystem
on MSM8996/APQ8096.
Signed-off-by: Todor Tomov
---
Documentation/media/v4l-drivers/qcom_camss.rst | 93 +++---
.../media/v4l-drivers/qcom_camss_8x96_graph.dot| 104 +
2 files changed, 164
Simplify getting of the line pointer by using the container_of
macro instead of traversing media controller links.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-vfe.c | 38 +++
1 file changed, 4 insertions(+), 34 deletions(-)
diff --git a
Add support for RAW MIPI14 format for RDI mode on 8x96.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 30
drivers/media/platform/qcom/camss/camss-csiphy.c | 4
drivers/media/platform/qcom/camss/camss-ispif.c | 4
drivers
This will allow to add support for different hardware.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/Makefile|1 +
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 1006 +++
drivers/media/platform/qcom/camss/camss-vfe.c | 1074
Add structs with 8x96 resources. As the number of CSIPHY, CSID
and VFE hardware modules is different on 8x16 and 8x96 select
the number at runtime and allocate needed structures
dynamically.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 20 +-
drivers/media
Changing a user control value can trigger an event to other
users. Add support for that.
Signed-off-by: Todor Tomov
Acked-by: Sakari Ailus
---
drivers/media/platform/qcom/camss/camss-csid.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom
Add support to output UYVY formats from the VFE (via the PIX interface).
A configuration for the realign module in the VFE is added. As the
realign module is present on 8x96 but not on 8x16, this is supported
on 8x96 only.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss
Add VFE hardware dependent part for 8x96.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/Makefile | 1 +
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 6 +
.../camss/{camss-vfe-4-1.c => camss-vfe-4-7.c} | 347 -
drivers/media/platf
As the 8x16 and 8x96 support different formats, separate the
arrays which contain the supported formats. For the VFE also
add separate arrays for RDI and PIX subdevices.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 196 +++
drivers/media
Add CSIPHY hardware dependent part for 8x96.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/Makefile | 1 +
.../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 256 +
drivers/media/platform/qcom/camss/camss-csiphy.c | 2 +
drivers/media
be when the format conversions
are implemented.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 69 +-
1 file changed, 56 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csid.c
b/drivers/media/platform
Add support for 10-bit packed V4L2_PIX_FMT_Y10P (on 8x16 and 8x96)
and unpacked V4L2_PIX_FMT_Y10 (on 8x96 only) pixel formats.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 50 +++-
drivers/media/platform/qcom/camss/camss-csiphy.c | 2
Rework the format selection on the source pad. Make the format
on the source pad selectable amongst a list of formats. This
list can be different for each sink pad format.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-vfe.c | 172 --
1 file
Use tabs.
CC: Rob Herring
CC: Mark Rutland
CC: devicet...@vger.kernel.org
Signed-off-by: Todor Tomov
Reviewed-by: Rob Herring
---
.../devicetree/bindings/media/qcom,camss.txt | 92 +++---
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git a/Documentation
This will allow to add support for different hardware.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/Makefile | 1 +
.../platform/qcom/camss/camss-csiphy-2ph-1-0.c | 173 +
drivers/media/platform/qcom/camss/camss-csiphy.c | 171
Use the PRDI mode on 8x96 to allow to configure RAW MIPI10
to Plain16 format conversion.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 33 -
drivers/media/platform/qcom/camss/camss-ispif.c | 64 +
drivers/media/platform/qcom
CSID hardware modules on 8x16 and 8x96 are similar. There is no
need to duplicate the code by adding separate versions. Just
update the register macros to return the correct register
addresses.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 60
Use the member name which is "line" instead of the pointer argument.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c
b/drivers/media/pla
ISPIF hardware modules on 8x16 and 8x96 are similar. However on
8x96 the ISPIF routes data to two VFE hardware modules. Add
separate interrupt handler for 8x96 to handle the additional
interrupts.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-ispif.c | 76
pe: Unknown V4L2
Sub-Device, DevPath: /dev/v4l-subdev15)
Entity: 0x0049 (Name: 'msm_vfe1_video0', Type: V4L2 I/O,
DevPath: /dev/video4)
Entity: 0x004f (Name: 'msm_vfe1_rdi1', Type: Unknown V4L2
Sub-Device, DevPath: /dev/v4l-subdev16)
The CSID decodes the input data stream. When the input comes from
the Test Generator the format of the stream is set on the source
media pad. When the input comes from the CSIPHY the format is the
one on the sink media pad. Use the proper format for each case.
Signed-off-by: Todor Tomov
Update binding document for MSM8996.
CC: Rob Herring
CC: Mark Rutland
CC: devicet...@vger.kernel.org
Signed-off-by: Todor Tomov
Reviewed-by: Rob Herring
---
.../devicetree/bindings/media/qcom,camss.txt | 44 +++---
1 file changed, 38 insertions(+), 6 deletions(-)
diff
Restructure lane configuration so it is simpler and will allow
similar (although not the same) handling for different hardware
versions.
Signed-off-by: Todor Tomov
---
.../platform/qcom/camss/camss-csiphy-2ph-1-0.c | 48 --
drivers/media/platform/qcom/camss/camss
: devicet...@vger.kernel.org
Signed-off-by: Todor Tomov
---
.../devicetree/bindings/media/qcom,camss.txt | 24 +++---
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,camss.txt
b/Documentation/devicetree/bindings/media
Use "no change" value when clearing CAMIF status and make sure
this is done before configuring the new command.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-vfe.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/
Use SPDX license headers for all files of the Qualcomm CAMSS driver.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csid.c | 10 +-
drivers/media/platform/qcom/camss/camss-csid.h | 10 +-
drivers/media/platform/qcom/camss/camss-csiphy.c | 10
Add a write memory barier after clock mux config and before the rest
of the csiphy config.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csiphy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c
b/drivers/media
Support for camera subsystem on QComm MSM8996/APQ8096 is to be added
so remove hardware version from CAMSS driver's path.
Signed-off-by: Todor Tomov
---
MAINTAINERS | 2 +-
drivers/media/platform/Kconfig
of_graph_get_next_endpoint increases the refcount of the returned
node and decreases the refcount of the passed node. Take this into
account and use of_node_put properly.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss.c | 5 +++--
1 file changed, 3 insertions(+), 2
Update settle count calculation as per specification.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss/camss-csiphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c
b/drivers/media/platform/qcom/camss/camss
Use more logical clock names - similar to the names in documentation.
This will allow better handling of the clocks in the driver when support
for more hardware versions is added - equivalent clocks on different
hardware versions will have the same name.
Signed-off-by: Todor Tomov
---
drivers
The new format will be called V4L2_PIX_FMT_Y10P.
It is similar to the V4L2_PIX_FMT_SBGGR10P family formats
but V4L2_PIX_FMT_Y10P is a grayscale format.
Signed-off-by: Todor Tomov
---
Documentation/media/uapi/v4l/pixfmt-y10p.rst | 33
Documentation/media/uapi/v4l/yuv
The code will be called MEDIA_BUS_FMT_Y10_2X8_PADHI_LE.
It is similar to MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE
but MEDIA_BUS_FMT_Y10_2X8_PADHI_LE describes grayscale
data.
Signed-off-by: Todor Tomov
---
Documentation/media/uapi/v4l/subdev-formats.rst | 72 +
include/uapi
e was partly detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
> ---
>
> v3:
> Laurent Pinchart and Todor Tomov requested a few adjustments.
> Updates were rebased on source files from Linux next-20180308.
>
> v2:
> Hans Verkuil insis
nal clock value.
------
Todor Tomov (2):
dt-bindings: media: Binding document for OV7251 camera sensor
media: Add a driver for the ov7251 camera sensor
.../devicetree/bindings/media/i2c/ov7251.txt | 51 +
drivers/
nal clock value.
------
Todor Tomov (2):
dt-bindings: media: Binding document for OV7251 camera sensor
media: Add a driver for the ov7251 camera sensor
.../devicetree/bindings/media/i2c/ov7251.txt | 51 +
drivers/
Add the document for ov7251 device tree binding.
CC: Rob Herring
CC: Mark Rutland
CC: devicet...@vger.kernel.org
Signed-off-by: Todor Tomov
Reviewed-by: Rob Herring
---
.../devicetree/bindings/media/i2c/ov7251.txt | 51 ++
1 file changed, 51 insertions(+)
create
gain;
- horizontal and vertical flip;
- test pattern.
Signed-off-by: Todor Tomov
---
drivers/media/i2c/Kconfig | 13 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/ov7251.c | 1494
3 files changed, 1508 insertions(+)
create mode 100644 dri
Add a node for the Camera Subsystem present on the Qualcomm
MSM8996 SoC.
Signed-off-by: Todor Tomov
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 135 ++
1 file changed, 135 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi
b/arch/arm64/boot/dts
Add VFE SMMU node.
Signed-off-by: Todor Tomov
---
This patch depends on patchset:
https://lore.kernel.org/patchwork/cover/1013166/
arch/arm64/boot/dts/qcom/msm8996.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi
b/arch/arm64
Add pinctrls required for camera sensors:
- power down signal;
- reset signal;
- camera external clock.
Signed-off-by: Todor Tomov
---
arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 64
arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 96 ++
2 files
Add pinctrls required for Camera Control Interface.
Signed-off-by: Todor Tomov
---
arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 12
arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 24
2 files changed, 36 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom
Add IOMMU sub-node for VFE secure context bank.
Signed-off-by: Todor Tomov
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi
b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index d302d8d..da9867b 100644
--- a/arch
Add a node for the Camera Subsystem present on the Qualcomm
MSM8916 SoC.
Signed-off-by: Todor Tomov
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 80 +++
1 file changed, 80 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi
b/arch/arm64/boot/dts
On Fri, Mar 23, 2018 at 12:14:20PM +0800, Todor Tomov wrote:
>> The ov7251 sensor is a 1/7.5-Inch B&W VGA (640x480) CMOS Digital Image
>> Sensor from Omnivision.
>>
>> The driver supports the following modes:
>> - 640x480 30fps
>> - 640x480 60fps
>> -
Hi Sakari
On 29.03.2018 11:29, Sakari Ailus wrote:
> Hi Todor and Jacopo,
>
> On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote:
> ...
>>>> +static const struct of_device_id ov7251_of_match[] = {
>>>> + { .compatible = &q
The code will be called MEDIA_BUS_FMT_Y10_2X8_PADHI_LE.
It is similar to MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE
but MEDIA_BUS_FMT_Y10_2X8_PADHI_LE describes grayscale
data.
Signed-off-by: Todor Tomov
---
Documentation/media/uapi/v4l/subdev-formats.rst | 72 +
include/uapi
The following two patches add one new media bus code and one new pixel format.
Both are for 10bit grayscale data. They will be used by the future version of
the QComm CAMSS driver when receiving the frame data from the OV7251 grayscale
camera sensor.
Todor Tomov (2):
media: v4l: Add new 2X8 10
The new format will be called V4L2_PIX_FMT_Y10P.
It is similar to the V4L2_PIX_FMT_SBGGR10P family formats
but V4L2_PIX_FMT_Y10P is a grayscale format.
Signed-off-by: Todor Tomov
---
Documentation/media/uapi/v4l/pixfmt-y10p.rst | 31
Documentation/media/uapi/v4l/yuv
Hi,
On 25.04.2018 13:54, Sakari Ailus wrote:
> Hi Todor,
>
> Thanks for the update. Just a few minor comments below.
Thanks for the review again, Sakari.
I'm preparing the next version.
Best regards,
Todor
controls for:
- exposure and gain;
- horizontal and vertical flip;
- test pattern.
Signed-off-by: Todor Tomov
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/Kconfig | 12 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/ov7251.c | 1503
Add the document for ov7251 device tree binding.
CC: Rob Herring
CC: Mark Rutland
CC: devicet...@vger.kernel.org
Signed-off-by: Todor Tomov
Reviewed-by: Rob Herring
---
.../devicetree/bindings/media/i2c/ov7251.txt | 52 ++
1 file changed, 52 insertions(+)
create
ock value.
------
Todor Tomov (2):
dt-bindings: media: Binding document for OV7251 camera sensor
media: Add a driver for the ov7251 camera sensor
.../devicetree/bindings/media/i2c/ov7251.txt | 52 +
drivers/media/i2
Hi Sakari,
On 26.04.2018 09:50, Sakari Ailus wrote:
> Hi Todor,
>
> On Wed, Apr 25, 2018 at 07:20:46PM +0300, Todor Tomov wrote:
> ...
>> +static int ov7251_write_reg(struct ov7251 *ov7251, u16 reg, u8 val)
>> +{
>> +u8 regbuf[3];
>> +int re
On 26.04.2018 15:04, Sakari Ailus wrote:
> On Thu, Apr 26, 2018 at 10:16:56AM +0300, Sakari Ailus wrote:
>> On Thu, Apr 26, 2018 at 10:04:25AM +0300, Todor Tomov wrote:
>>> Hi Sakari,
>>>
>>> On 26.04.2018 09:50, Sakari Ailus wrote:
>>>> Hi Todor,
&g
My @linaro.org email address doesn't exist anymore so add a
mailmap entry to map it to my @gmail.com address.
Signed-off-by: Todor Tomov
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index 45d358534ac5..9ad06d88190c 100644
--- a/.mailmap
+++ b/.ma
Hi Sakari,
On 17.04.2018 23:10, Sakari Ailus wrote:
> Hi Todor,
>
> On Tue, Apr 17, 2018 at 06:32:07PM +0300, Todor Tomov wrote:
> ...
>>>> +static int ov7251_regulators_enable(struct ov7251 *ov7251)
>>>> +{
>>>> + int ret;
>>&g
Add the document for ov7251 device tree binding.
CC: Rob Herring
CC: Mark Rutland
CC: devicet...@vger.kernel.org
Signed-off-by: Todor Tomov
Reviewed-by: Rob Herring
---
.../devicetree/bindings/media/i2c/ov7251.txt | 52 ++
1 file changed, 52 insertions(+)
create
omment in driver about external clock value.
------
Todor Tomov (2):
dt-bindings: media: Binding document for OV7251 camera sensor
media: Add a driver for the ov7251 camera sensor
.../devicetree/bindings/media/i2c/ov7251.txt
controls for:
- exposure and gain;
- horizontal and vertical flip;
- test pattern.
Signed-off-by: Todor Tomov
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/Kconfig | 13 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/ov7251.c | 1501
* GPIO_8, LSEC pin 30 */
> + "TP93", /* GPIO_9 */
> + "GPIO-G", /* GPIO_10, LSEC pin 29 */
> + "[MDP_VSYNC_S]", /* GPIO_11, P HSEC pin 55 */
> + "NC", /* GPIO_12 */
> + "[CSI0_MCLK]", /* GPIO_13, P HSEC pin 15 */
> + "[CAM_MCLK1]", /* GPIO_14, J14 pin 11 */
> + "[CSI1_MCLK]", /* GPIO_15, P HSEC pin 17 */
This could be a little misleading.
96Board name / schametic name:
CSI0_MCLK / CAM_MCLK0
- / CAM_MCLK1
CSI1_MCLK / CAM_MCLK2
--
Best regards,
Todor Tomov
ames to the comments.
You can have my:
Reviewed-by: Todor Tomov
> ---
> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 239
> +++
> 1 file changed, 239 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi
> b/arch/arm64/boot/dts/q
t ov5645_probe(struct i2c_client *client,
>>
>> power_down:
>> ov5645_s_power(&ov5645->sd, false);
>> +ret = -ENODEV;
>
> I don't think this is where people would expect you to set the error code
> in general. It should rather take place before goto, not after it. That'd
> mean another variable, and I'm not convinced the result would improve the
> driver.
I agree with Sakari.
>
>> free_entity:
>> media_entity_cleanup(&ov5645->sd.entity);
>> free_ctrl:
>
--
Best regards,
Todor Tomov
Hi Sakari,
On 7.05.2018 13:59, Sakari Ailus wrote:
> Hi Todor,
>
> On Fri, Apr 27, 2018 at 02:40:39PM +0300, Todor Tomov wrote:
>> The new format will be called V4L2_PIX_FMT_Y10P.
>> It is similar to the V4L2_PIX_FMT_SBGGR10P family formats
>> but V4L2_PIX_FMT
The new format will be called V4L2_PIX_FMT_Y10P.
It is similar to the V4L2_PIX_FMT_SBGGR10P family formats
but V4L2_PIX_FMT_Y10P is a grayscale format.
Signed-off-by: Todor Tomov
---
v2:
- doc: improved bit-packed representation: added bit positions for LSB bits;
- doc: improved bit-packed
Hi Sakari,
Thank you for the review.
On 29.03.2018 14:51, Sakari Ailus wrote:
> Hi Todor,
>
> Thanks for the patch. A few quick comments below...
>
> On Fri, Mar 23, 2018 at 12:14:20PM +0800, Todor Tomov wrote:
>> The ov7251 sensor is a 1/7.5-Inch B&W VGA (640x480) CMO
Hi Laurent,
Thank you for the detailed review.
On 12/05/2016 05:22 PM, Laurent Pinchart wrote:
> Hi Todor,
>
> Thank you for the patch.
>
> On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote:
>> These files handle the video device nodes of the camss driver.
>
> cams
d this is the first thing to do - go
over the comments received.
I'll reply for each of them.
Thank you for your notification and the also for the review done!
Best regards,
Todor
>
> Regards,
>
> Hans
>
> On 11/25/2016 03:56 PM, Todor Tomov wrote:
>> Th
Hi Rob,
Happy new year,
And thank you for the review.
On 12/01/2016 12:03 AM, Rob Herring wrote:
> On Fri, Nov 25, 2016 at 04:56:53PM +0200, Todor Tomov wrote:
>> Add DT binding document for Qualcomm Camera subsystem driver.
>>
>> Signed-off-by: Todor Tomov
>> ---
Hi Hans,
Thank you for the extensive review.
On 12/05/2016 03:44 PM, Hans Verkuil wrote:
> A few comments below:
>
> On 11/25/2016 03:57 PM, Todor Tomov wrote:
>> These files handle the video device nodes of the camss driver.
>>
>> Signed-off-by: Todor Tomov
>&g
Hi Laurent, Hans,
On 12/05/2016 05:25 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> On Monday 05 Dec 2016 16:02:55 Hans Verkuil wrote:
>> On 12/05/2016 03:45 PM, Laurent Pinchart wrote:
>>> On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote:
>>>> On 11
/lists/linux-media/msg104013.html
Todor Tomov (10):
doc: DT: camss: Binding document for Qualcomm Camera subsystem driver
MAINTAINERS: Add Qualcomm Camera subsystem driver
doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document
media: camss: Add CSIPHY files
media: camss: Add
Add DT binding document for Qualcomm Camera subsystem driver.
Signed-off-by: Todor Tomov
---
.../devicetree/bindings/media/qcom,camss.txt | 196 +
1 file changed, 196 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/qcom,camss.txt
diff --git a
Add an entry for Qualcomm Camera subsystem driver.
Signed-off-by: Todor Tomov
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 411e3b8..0740aee 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9971,6 +9971,14 @@ T: git
git
These files control the CSIPHY modules which are responsible for the physical
layer of the CSI2 receivers.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss-8x16/csiphy.c | 685
drivers/media/platform/qcom/camss-8x16/csiphy.h | 77 +++
2 files changed
Add a document to describe Qualcomm Camera Subsystem driver.
Signed-off-by: Todor Tomov
---
Documentation/media/v4l-drivers/index.rst | 1 +
Documentation/media/v4l-drivers/qcom_camss.rst | 124 +
2 files changed, 125 insertions(+)
create mode 100644
memory.
RDI interfaces are supported in this version. PIX interface is not supported.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss-8x16/vfe.c | 1877 ++
drivers/media/platform/qcom/camss-8x16/vfe.h | 112 ++
2 files changed, 1989 insertions(+)
create
These files control the ISPIF module which handles the routing of the data
streams from the CSIDs to the inputs of the VFE.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss-8x16/ispif.c | 1105
drivers/media/platform/qcom/camss-8x16/ispif.h | 85 ++
2
These files implement the platform driver code.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss-8x16/camss.c | 603 +
drivers/media/platform/qcom/camss-8x16/camss.h | 93
2 files changed, 696 insertions(+)
create mode 100644 drivers/media/platform
These files handle the video device nodes of the camss driver.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss-8x16/video.c | 597 +
drivers/media/platform/qcom/camss-8x16/video.h | 67 +++
2 files changed, 664 insertions(+)
create mode 100644 drivers
These files control the CSID modules which handle the protocol and application
layer of the CSI2 receivers.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/camss-8x16/csid.c | 1071 +
drivers/media/platform/qcom/camss-8x16/csid.h | 82 ++
2 files changed
Add Makefiles and Kconfig files to build the camss driver.
Signed-off-by: Todor Tomov
---
drivers/media/platform/qcom/Kconfig | 5 +
drivers/media/platform/qcom/Makefile| 1 +
drivers/media/platform/qcom/camss-8x16/Makefile | 12
3 files changed, 18
Add the document for ov5645 device tree binding.
Signed-off-by: Todor Tomov
Reviewed-by: Laurent Pinchart
---
.../devicetree/bindings/media/i2c/ov5645.txt | 54 ++
1 file changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5645
The ov5645 sensor from Omnivision supports up to 2592x1944
and CSI2 interface.
The driver adds support for the following modes:
- 1280x960
- 1920x1080
- 2592x1944
Output format is packed 8bit UYVY.
Signed-off-by: Todor Tomov
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/Kconfig | 12
1 - 100 of 219 matches
Mail list logo
