On Wed, Nov 08, 2017 at 11:10:56PM +1100, Michael Ellerman wrote:
> "Tobin C. Harding" writes:
[snip]
Hi Michael,
I'm working an adding support for ppc64 to leaking_addresses.pl, I've
added the kernel address regular expression that you suggested. I'd like
to add the
On Wed, Nov 08, 2017 at 11:42:21AM +0100, Petr Mladek wrote:
> On Wed 2017-11-08 14:37:36, Tobin C. Harding wrote:
> > Currently script just dumps all results found. Potentially, this risks
> > loosing single results among multiple duplicate results. We need some
> > way of r
On Wed, Nov 08, 2017 at 12:51:20PM +0100, Greg KH wrote:
> On Wed, Nov 08, 2017 at 11:16:43AM +0100, Petr Mladek wrote:
> > On Wed 2017-11-08 14:37:37, Tobin C. Harding wrote:
> > > Developers may not have the time (or inclination) to investigate script
> > > output. T
Currently if a pointer is printed using %p[ssB] and the symbol is not
found (kallsyms_lookup() fails) then we print the actual address. This
leaks kernel addresses. We should instead print something _safe_.
Print "" instead of kernel address.
Signed-off-by: Tobin C. Harding
-
On Thu, Nov 09, 2017 at 11:49:52AM +1100, Michael Ellerman wrote:
> "Tobin C. Harding" writes:
>
> > On Wed, Nov 08, 2017 at 11:10:56PM +1100, Michael Ellerman wrote:
> >> "Tobin C. Harding" writes:
> > [snip]
> >
> > Hi
:
- Basically everything except the summary reporting, including re-write
of the cover-letter.
Tobin C. Harding (8):
scripts/leaking_addresses: use tabs not spaces
scripts/leaking_addresses: remove dead code
scripts/leaking_addresses: remove command line options
scripts/leaking_addresses: fix
Current code uses spaces instead of tabs in places.
Use tabs instead of spaces.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 54 ++--
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/scripts/leaking_addresses.pl b
There are a couple more files that cause the script to stall.
/sys/firmware/devicetree and its symlink /proc/device-tree, reported by
Michael Ellerman.
usbmon should be skipped were ever it appears. Reported by Kees Cook
Add files to be excluded from parsing.
Signed-off-by: Tobin C. Harding
the process by writing the
results to file for subsequent viewing.
Add command line options to enable summary reporting, including options
to write to and read from file.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 191 ++-
1 file
Currently script accepts files to skip. This was added to make running
the script faster (for repeat runs). We can remove this functionality in
preparation for adding sub commands (scan and format) to the script.
Remove command line options.
Signed-off-by: Tobin C. Harding
---
scripts
Currently script is targeted at x86_64. We can support other
architectures by using the correct regular expressions for each
architecture.
Add the infrastructure to support multiple architectures. Add support
for ppc64.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 66
: Kees Cook
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index 1d6ab7f1b10c..6efd1fdb7d25 100755
--- a/scripts
Fix typo in comment string.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index 719ed0aaede7..3f8c6e230962 100755
--- a/scripts/leaking_addresses.pl
debug_arrays is not called. Also, %seen hash is not used. We should
remove unused code.
Remove dead code.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 9 -
1 file changed, 9 deletions(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
On Wed, Nov 08, 2017 at 10:35:55PM -0500, Steven Rostedt wrote:
> On Thu, 9 Nov 2017 12:50:29 +1100
> "Tobin C. Harding" wrote:
>
> > Currently if a pointer is printed using %p[ssB] and the symbol is not
> > found (kallsyms_lookup() fails) then we print the actual
On Fri, Nov 10, 2017 at 07:26:34PM +0530, kaiwan.billimo...@gmail.com wrote:
> On Tue, 2017-11-07 at 21:32 +1100, Tobin C. Harding wrote:
[snip]
> Finally, unsure if am working against the latest ver of your script Tobin,
> apologies if not.
The latest version of leaking_addresses.pl
On Thu, Nov 16, 2017 at 01:16:28PM +1100, Michael Ellerman wrote:
> "Tobin C. Harding" writes:
>
> > Clearly I am unable to use email.
> >
> > Adding to CC: Greg, Steve, Paul - kernel developers CC'd on leaking
> > addresses stuff that may know my
On Wed, Nov 15, 2017 at 04:09:32PM +0200, Jani Nikula wrote:
> On Wed, 15 Nov 2017, "Tobin C. Harding" wrote:
> > On Tue, Nov 14, 2017 at 04:48:16PM -0700, Jonathan Corbet wrote:
> >
> > Awesome comments Jon, I knew there would be more to writing docs than
> &g
On Wed, Nov 29, 2017 at 09:59:59AM +0200, Alexander Kapshuk wrote:
> On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrote:
> > On Tue, Nov 28, 2017 at 03:16:24PM +0200, Alexander Kapshuk wrote:
> >> On Tue, Nov 28, 2017 at 8:32 AM, Tobin C. Harding wrote
On Wed, Nov 29, 2017 at 04:32:54PM +0530, Kaiwan N Billimoria wrote:
> Hi,
>
> On Wed, Nov 29, 2017 at 3:46 PM, Tobin C. Harding wrote:
> > On Wed, Nov 29, 2017 at 09:59:59AM +0200, Alexander Kapshuk wrote:
> >> On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrot
On Wed, Nov 29, 2017 at 11:22:29AM -0800, Linus Torvalds wrote:
> On Tue, Nov 28, 2017 at 8:59 PM, Tobin C. Harding wrote:
> >
> > git://github.com/tcharding/linux.git tags/printk-hash-pointer-4.15-rc2
>
> Bah.
Sorry for creating extra work for you.
> What I di
On Wed, Nov 29, 2017 at 01:14:38PM -0800, Linus Torvalds wrote:
> On Wed, Nov 29, 2017 at 1:08 PM, Tobin C. Harding wrote:
> >
> > If you haven't wasted enough time on this can you tell me what you mean
> > by 'completely breaks %pK'?
>
> The whole p
On Wed, Nov 29, 2017 at 03:20:58PM -0800, Andrew Morton wrote:
> On Wed, 29 Nov 2017 13:05:04 +1100 "Tobin C. Harding" wrote:
>
> > printk specifier %p now hashes all addresses before printing. Sometimes
> > we need to see the actual unmodified address. This can b
On Wed, Nov 29, 2017 at 03:20:40PM -0800, Andrew Morton wrote:
> On Wed, 29 Nov 2017 13:05:00 +1100 "Tobin C. Harding" wrote:
>
> > Currently there exist approximately 14 000 places in the Kernel where
> > addresses are being printed using an unadorned %p. This pot
e can always revert this patch if it turns
out to be worthless, right?
Patch 1 was created using
for file in $(git grep -l '%pK')
do
perl -pi -e 's/%pK/%p/g' $file
done
thanks,
Tobin.
Tobin C. Harding (2):
tree-wide: replace all users of %pK with %p
printk: add
e %pK (and kptr_restrict).
Search and replace all uses of %pK with %p.
Signed-off-by: Tobin C. Harding
---
arch/arm/mm/physaddr.c | 2 +-
arch/arm64/mm/physaddr.c | 2 +-
arch/mips/kernel/relocate.c| 10 +--
arch/mip
C. Harding
---
Documentation/printk-formats.txt | 11 +++
lib/vsprintf.c | 18 ++
2 files changed, 29 insertions(+)
diff --git a/Documentation/printk-formats.txt b/Documentation/printk-formats.txt
index aa0a776c817a..f88b06485378 100644
--- a
On Tue, Nov 28, 2017 at 08:58:44AM +0530, Kaiwan N Billimoria wrote:
> On Tue, Nov 28, 2017 at 7:20 AM, Tobin C. Harding wrote:
> >
> > Noob question: how do we _know_ this. In other words how do we know no
> > userland tools rely on the current behaviour? No stress to answe
I reordered the To's and CC's, I hope this doesn't break
threading. (clearly I haven't groked email yet :( )
On Tue, Nov 28, 2017 at 09:30:17AM +1100, Tobin C. Harding wrote:
> Currently if kallsyms_lookup() fails to find the symbol then the address
> is printed. This p
d at the start of one of the
chapters and the original email thread is referenced in
'pull-requests.rst'.
Signed-off-by: Tobin C. Harding
Reviewed-by: Greg Kroah-Hartman
---
v3:
- Modified details for branch and tag naming, suggested by Mauro
Carvalho Chehab.
- Added example email
On Wed, Nov 29, 2017 at 07:58:26PM -0800, Joe Perches wrote:
> On Thu, 2017-11-30 at 10:26 +1100, Tobin C. Harding wrote:
> > On Wed, Nov 29, 2017 at 03:20:58PM -0800, Andrew Morton wrote:
> > > On Wed, 29 Nov 2017 13:05:04 +1100 "Tobin C. Harding"
> > > wrot
On Wed, Nov 29, 2017 at 08:41:36PM -0800, Joe Perches wrote:
> On Thu, 2017-11-30 at 15:18 +1100, Tobin C. Harding wrote:
> > On Wed, Nov 29, 2017 at 07:58:26PM -0800, Joe Perches wrote:
> > > On Thu, 2017-11-30 at 10:26 +1100, Tobin C. Harding wrote:
> > > > On W
On Thu, Nov 30, 2017 at 07:01:19AM -0200, Mauro Carvalho Chehab wrote:
> Em Thu, 30 Nov 2017 12:55:07 +1100
> "Tobin C. Harding" escreveu:
>
> > There is currently very little documentation in the kernel on maintainer
> > level tasks. In particular there ar
saved to file to expedite repeated formatting/viewing of
output.
Signed-off-by: Tobin C. Harding
---
This version outputs a report instead of the raw results by default. Designing
this proved to be non-trivial, the reason being that it is not immediately clear
what constitutes a duplicate entry
On Tue, Nov 07, 2017 at 04:51:29PM +0100, Petr Mladek wrote:
> On Tue 2017-11-07 21:32:11, Tobin C. Harding wrote:
> > Currently we are leaking addresses from the kernel to user space. This
> > script is an attempt to find some of those leakages. Script parses
> > `dmesg` outp
On Tue, Nov 07, 2017 at 11:50:27AM +0100, Greg KH wrote:
> On Tue, Nov 07, 2017 at 09:32:11PM +1100, Tobin C. Harding wrote:
> > Currently we are leaking addresses from the kernel to user space. This
> > script is an attempt to find some of those leakages. Script parses
> &g
On Tue, Nov 07, 2017 at 01:56:05PM +, David Laight wrote:
> From: Tobin C. Harding
> > Sent: 07 November 2017 10:32
> >
> > Currently we are leaking addresses from the kernel to user space. This
> > script is an attempt to find some of those leakages. Script parses
&
On Tue, Nov 07, 2017 at 03:36:06PM -0800, Laura Abbott wrote:
> On 11/07/2017 02:32 AM, Tobin C. Harding wrote:
> >Currently we are leaking addresses from the kernel to user space. This
> >script is an attempt to find some of those leakages. Script parses
> >`dmesg` output and
Hi Kees,
It seems I over looked your suggestions when submitting v4. My mistake.
On Tue, Nov 07, 2017 at 01:22:13PM -0800, Kees Cook wrote:
> On Mon, Nov 6, 2017 at 9:27 AM, Linus Torvalds
> wrote:
> > On Sun, Nov 5, 2017 at 9:19 PM, Tobin C. Harding wrote:
> >> Cur
On Tue, Nov 07, 2017 at 01:44:01PM -0800, Linus Torvalds wrote:
> On Tue, Nov 7, 2017 at 1:22 PM, Kees Cook wrote:
> >
> > Linus, what do you have in mind for the root-only "yes we really need
> > the actual address output" exceptions?
>
> I am convinced that absolutely none of them should use '%
On Mon, Nov 06, 2017 at 09:27:09AM -0800, Linus Torvalds wrote:
> On Sun, Nov 5, 2017 at 9:19 PM, Tobin C. Harding wrote:
> > Currently we are leaking addresses from the kernel to user space. This
> > script is an attempt to find some of those leakages. Script parses
> > `dm
.
thanks,
Tobin.
Tobin C. Harding (7):
scripts/leaking_addresses: use tabs not spaces
scripts/leaking_addresses: remove dead code
scripts/leaking_addresses: remove command line options
scripts/leaking_addresses: add reporting
scripts/leaking_addresses: add emailing results
scripts
Current code uses spaces instead of tabs in places.
Use tabs instead of spaces.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 54 ++--
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/scripts/leaking_addresses.pl b
Developers may not have the time (or inclination) to investigate script
output. This information is, however, useful. If we add functionality to
the script to email results for further investigation.
Add --send-report flag to email scan results (to Tobin C. Harding).
Signed-off-by: Tobin C
Currently script accepts files to skip. This was added to make running
the script faster (for repeat runs). We can remove this functionality in
preparation for adding sub commands (scan and format) to the script.
Remove command line options.
Signed-off-by: Tobin C. Harding
---
scripts
file 'usbmon' causes script to hang.
Add usbmon to files to skip under any sub directory.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresse
Fix typo in comment string.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index e43105662306..0671aac894be 100644
--- a/scripts/leaking_addresses.pl
-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 201 ---
1 file changed, 187 insertions(+), 14 deletions(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index 719ed0aaede7..4c31e935319b 100755
--- a/scripts
debug_arrays is not called. Also, %seen hash is not used. We should
remove unused code.
Remove dead code.
Signed-off-by: Tobin C. Harding
---
scripts/leaking_addresses.pl | 9 -
1 file changed, 9 deletions(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
On Tue, Nov 07, 2017 at 01:22:13PM -0800, Kees Cook wrote:
> On Mon, Nov 6, 2017 at 9:27 AM, Linus Torvalds
> wrote:
[snip]
> And for my kernels, I needed to exclude usbmon or the script would
> hang (perhaps add a read timeout to the script to detect stalling
> files?)
Bother. I submitted the pa
On Fri, Dec 08, 2017 at 09:27:54AM +1100, Tobin C. Harding wrote:
[snip]
New comments have come in from Kees Cook in thread for previous
version. Please drop this set so Kees's suggestions can be implemented.
thanks,
Tobin.
On Thu, Dec 07, 2017 at 02:50:42PM -0800, Kees Cook wrote:
> On Tue, Dec 5, 2017 at 5:45 PM, Tobin C. Harding wrote:
> > Documentation/printk-formats.txt is a candidate for conversion to
> > ReStructuredText format. Some effort has already been made to do this
> > conver
On Thu, Dec 07, 2017 at 04:01:46PM -0700, Jonathan Corbet wrote:
> On Thu, 7 Dec 2017 14:50:42 -0800
> Kees Cook wrote:
>
> > > +These guides contain general information useful when writing kernel code.
> > > +
> > > +.. toctree::
> > > + :maxdepth: 1
> > > +
> > > + printk-formats
> >
> >
On Thu, Dec 07, 2017 at 04:19:56PM -0800, Kees Cook wrote:
> On Thu, Dec 7, 2017 at 3:44 PM, Tobin C. Harding wrote:
> > Cheers Kees. FTR, changes to implement are:
> >
> > - Fix the capitalization of 'kernel'.
>
> I don't really have an opinion abou
On Fri, Dec 08, 2017 at 08:42:52AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 08, 2017 at 10:27:51AM +1100, Tobin C. Harding wrote:
> > From: Joe Perches
> >
> > Recently signature tag Co-Developed-by was added to the
> > kernel (Documentation/process/5.Posting.
On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote:
> On Fri, 2017-12-08 at 13:06 -0800, Kees Cook wrote:
> > Well ... my sense is that lib/vsprintf.c should remain the canonical
> > documentation.
>
> I agree.
>
> > Anyone working on the code has the docs all together in
> > one file. I
[Adding Laura]
On Fri, Dec 08, 2017 at 06:18:45PM -0800, Joe Perches wrote:
> On Sat, 2017-12-09 at 12:27 +1100, Tobin C. Harding wrote:
> > On Fri, Dec 08, 2017 at 01:22:37PM -0800, Joe Perches wrote:
>
> > > Outside of the documentation, what could be useful is for
> &
On Thu, Nov 23, 2017 at 02:51:38PM +0300, Dan Carpenter wrote:
> On Thu, Nov 23, 2017 at 03:59:26PM +1100, Tobin C. Harding wrote:
> > On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote:
> > > Fixed some signedness warnings from sparse on lustre.
> > &
On Wed, Nov 22, 2017 at 09:01:45AM +0100, Salvatore Mesoraca wrote:
Please take these comments in all humility, my English is a long way
from perfect. These are English grammar comments only. If this is viewed
as trivial please stop reading now and ignore.
> Disallows open of FIFOs or regular fil
On Wed, Nov 22, 2017 at 09:01:46AM +0100, Salvatore Mesoraca wrote:
Same caveat about this being English language comments only as for patch
1/2. Please ignore if this is too trivial. My grammar is a long way from
perfect, especially please feel free to ignore my placement of commas,
they are ofte
Once it is in the tree no feed back will be possible.
> Signed-off-by: Kaiwan N Billimoria
> ---
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index 865c07649dff..0566f8055ec5 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addre
On Thu, Nov 23, 2017 at 10:45:31AM +0530, kaiwan.billimo...@gmail.com wrote:
> The current leaking_addresses.pl script only supports showing "leaked"
> 64-bit kernel virtual addresses. This patch modifies the "help" screen in the
> following manner:
> - the '--raw', '--suppress-dmesg', '--squash-by
On Fri, Nov 24, 2017 at 12:51:34PM +0530, Kaiwan N Billimoria wrote:
> On Fri, Nov 24, 2017 at 11:29 AM, Tobin C. Harding wrote:
>
> > Neither of these patches applies to my tree. Are you editing the diff's
> > by hand? I noticed the patches don't end with the versi
On Fri, Nov 24, 2017 at 11:02:49AM -0800, Dan Williams wrote:
> On Tue, Nov 21, 2017 at 2:39 PM, Tobin C. Harding wrote:
> > There is currently very little documentation in the kernel on maintainer
> > level tasks. In particular there are no documents on creating pull
> >
On Fri, Nov 24, 2017 at 04:02:09PM +0300, Dan Carpenter wrote:
> On Fri, Nov 24, 2017 at 09:20:20AM +1100, Tobin C. Harding wrote:
> > My current favourite review of all time was done by you on a what was
> > at the time a pretty hard patch for me. It was
> >
> > No
d at the start of one of the
chapters and the original email thread is referenced in
'pull-requests.rst'.
Signed-off-by: Tobin C. Harding
---
v2:
- Change title of book, suggested by Dan Williams.
thanks,
Tobin.
Documentation/index.rst| 1 +
Documentation/maintain
On Sat, Nov 25, 2017 at 08:56:23AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Nov 25, 2017 at 08:44:19AM +1100, Tobin C. Harding wrote:
> > There is currently very little documentation in the kernel on maintainer
> > level tasks. In particular there are no documents on creating pu
Commit-ID: 8bf7ab9c79f3d1a5f02ebac369f656de9ec0aca8
Gitweb: https://git.kernel.org/tip/8bf7ab9c79f3d1a5f02ebac369f656de9ec0aca8
Author: Tobin C. Harding
AuthorDate: Tue, 30 Apr 2019 10:11:44 +1000
Committer: Ingo Molnar
CommitDate: Tue, 30 Apr 2019 06:24:09 +0200
sched/cpufreq: Fix
Commit-ID: 9a4f26cc98d81b67ecc23b890c28e2df324e29f3
Gitweb: https://git.kernel.org/tip/9a4f26cc98d81b67ecc23b890c28e2df324e29f3
Author: Tobin C. Harding
AuthorDate: Tue, 30 Apr 2019 10:11:44 +1000
Committer: Ingo Molnar
CommitDate: Tue, 30 Apr 2019 07:57:23 +0200
sched/cpufreq: Fix
Commit-ID: 72042a8c7b01048a36ece216aaf206b7d60ca661
Gitweb: http://git.kernel.org/tip/72042a8c7b01048a36ece216aaf206b7d60ca661
Author: Tobin C. Harding
AuthorDate: Mon, 20 Feb 2017 10:12:35 +1100
Committer: Thomas Gleixner
CommitDate: Wed, 1 Mar 2017 11:27:26 +0100
x86/purgatory: Make
Commit-ID: e98fe5127b9cc8ab33d1094b81c19deb1f9082bf
Gitweb: http://git.kernel.org/tip/e98fe5127b9cc8ab33d1094b81c19deb1f9082bf
Author: Tobin C. Harding
AuthorDate: Mon, 20 Feb 2017 10:12:36 +1100
Committer: Thomas Gleixner
CommitDate: Wed, 1 Mar 2017 11:27:26 +0100
x86/purgatory: Fix
901 - 971 of 971 matches
Mail list logo
