Current document includes the path to an RST doc file. Since this is an
RST file we can make this a link. Keeps the path as the link title
since that what the original author wrote.
Use reference to link to rst file.
Signed-off-by: Tobin C. Harding
---
Documentation/vm/numa.rst | 4 ++--
1
On Thu, Mar 07, 2019 at 08:49:34AM +1100, Tobin C. Harding wrote:
> On Thu, Mar 07, 2019 at 08:42:19AM +1100, Tobin C. Harding wrote:
> > Hi,
>
> Man, I didn't see the merge window was open, I thought rc8 only came out
> on Sunday.
>
> Sorry, please ignore this. Wi
: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
mm/slub.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index dc61b6b7..69164aa7cbbf 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -5009,13 +5009,18 @@ static ssize_t cpu_partial_store
-F lists caches that support object migration.
-C lists caches that use a ctor.
Add command line options to show caches with a constructor and caches
with that are migratable (i.e. have isolate and migrate functions).
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
-by: Tobin C. Harding
---
include/linux/slab.h | 1 +
mm/slub.c| 266 +++
2 files changed, 194 insertions(+), 73 deletions(-)
diff --git a/include/linux/slab.h b/include/linux/slab.h
index 22e87c41b8a4..b9b46bc9937e 100644
--- a/include/linux/sla
array.c:1961:13: note: did you mean to dereference the pointer?
if (!xa || xa == XA_FREE_MARK)
Perhaps you will put me out of my misery Willy and just tell me what its
supposed to be.
Patch 14 and 15 are particularly early stage (I hacked those :)
thanks,
Tobin.
Tobin C. Harding (15):
slu
Add output line for NUMA remote node defrag ratio.
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index 6ba8ffb4ea50..9cdccdaca349 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm
: Tobin C. Harding
---
mm/slub.c | 85 +++
1 file changed, 85 insertions(+)
diff --git a/mm/slub.c b/mm/slub.c
index 0133168d1089..6ce866b420f1 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -4325,6 +4325,91 @@ int __kmem_cache_create(struct kmem_cache *s
SLAB/SLOB. The API is generic so it could be
theoretically implemented for these allocators as well.
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
include/linux/slab.h | 69
include/linux/slub_def.h | 3 ++
mm/slab_common.c
ll : 1 Redzoning : On Used :1120
SlabSiz:8192 Partial: 0 Poisoning : On Loss :7072
Loss : 336 CpuSlab: 0 Tracking : On Lalig:6720
Align : 8 Objects: 20 Tracing : Off Lpadd: 352
Signed-off-by: Tobin
Implement functions to migrate objects. This is based on
initial code by Matthew Wilcox and was modified to work with
slab object migration.
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
lib/radix-tree.c | 13 +
lib/xarray.c | 44
from N1 -> to N2):
echo "N1 N2" > move
This also enables shrinking slabs on a specific node:
echo "N1 N1" > move
Signed-off-by: Tobin C. Harding
---
mm/Kconfig | 7 ++
mm/slub.c | 249 +
2 files c
e triggers balance, no other value accepted.
This feature relies on SMO being enable for the cache, this is done with
a call to, after the isolate/migrate functions have been defined.
kmem_cache_setup_mobility(s, isolate, migrate)
Signed-off-by: Tobin C. Harding
---
mm/sl
he
remaining objects.
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
Documentation/ABI/testing/sysfs-kernel-slab | 14
include/linux/slub_def.h| 7 ++
mm/slub.c | 24 +
3 files ch
remaining partial slab.
Signed-off-by: Tobin C. Harding
---
tools/testing/slab/Makefile | 2 +-
tools/testing/slab/slub_defrag_xarray.c | 211
2 files changed, 212 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/slab/slub_defrag_xarray.c
di
It is advantageous to have all defragmentable slabs together at the
beginning of the list of slabs so that there is no need to scan the
complete list. Put defragmentable caches first when adding a slab cache
and others last.
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
ling movable objects ...
verified movable slabs are shrinkable
Removing module slub_defrag ...
Signed-off-by: Tobin C. Harding
---
tools/testing/slab/slub_defrag.c | 1 +
tools/testing/slab/slub_defrag.py | 451 ++
2 files changed, 452 insertions(+)
create mode 10075
Add output for the newly added defrag_used_ratio sysfs knob.
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 4
1 file changed, 4 insertions(+)
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index 9cdccdaca349..8cf3bbd061e2 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm
On Thu, Mar 07, 2019 at 07:42:03PM -0800, Randy Dunlap wrote:
> On 3/7/19 1:11 PM, Tobin C. Harding wrote:
> > Sphinx emits a bunch of 'Title underline too short' warnings. We can
> > fix these by using the correct length underlines.
> >
> > Fix Title un
On Thu, Mar 07, 2019 at 07:40:14PM -0800, Randy Dunlap wrote:
> On 3/7/19 1:11 PM, Tobin C. Harding wrote:
> > Sphinx uses a star not a hyphen for lists.
> >
> > Use correct list markup character.
> >
> > Signed-off-by: Tobin C. Harding
>
> Hi Tobin,
>
On Thu, Mar 07, 2019 at 02:43:57PM -0800, Kees Cook wrote:
> On Thu, Mar 7, 2019 at 1:19 PM Tobin C. Harding wrote:
> >
> > On Thu, Mar 07, 2019 at 08:49:34AM +1100, Tobin C. Harding wrote:
> > > On Thu, Mar 07, 2019 at 08:42:19AM +1100, Tobin C. Harding wrote:
> &
On Thu, Jun 07, 2018 at 10:00:02AM -0400, Theodore Y. Ts'o wrote:
> On Thu, Jun 07, 2018 at 09:31:04AM +1000, Tobin C. Harding wrote:
> > > I'm also happy to take the whole patch series through the random tree
> > > if everyone else is OK with it.
> >
> &g
as originally suggested by Kees).
- Add command line option to use cryptographically insecure hashing.
If debug_early_boot is enabled use hash_long() instead of siphash
(as requested by Steve, and solves original problem for Anna-Maria).
- Added Acked-by tag from Ted (patch 1 and 2)
Tobin C. H
There are a couple of whitespace issues around the function
get_random_bytes_arch(). In preparation for patching this function
let's clean them up.
Signed-off-by: Tobin C. Harding
Acked-by: Theodore Ts'o
---
drivers/char/random.c | 3 +--
1 file changed, 1 insertion(+), 2 deletion
Currently we must wait for enough entropy to become available before
hashed pointers can be printed. We can remove this wait by using the
hw RNG if available.
Use hw RNG to get keying material.
Cc: Steven Rostedt (VMware)
Suggested-by: Kees Cook
Signed-off-by: Tobin C. Harding
---
lib
Cc: Steven Rostedt
Cc: Randy Dunlap
Signed-off-by: Tobin C. Harding
---
Documentation/admin-guide/kernel-parameters.txt | 9 +
lib/vsprintf.c | 18 ++
2 files changed, 27 insertions(+)
diff --git a/Documentation/admin-guide/kernel-paramet
bytes_arch().
Only get random bytes from the hw RNG, make function return the number
of bytes retrieved from the hw RNG.
Signed-off-by: Tobin C. Harding
Acked-by: Theodore Ts'o
Reviewed-by: Steven Rostedt (VMware)
---
drivers/char/random.c | 16 +---
include/linux/random.h |
ruption bug,
causing this code to execute, the extra address is probably not making
the situation any worse.
(I am in no way a security expert.)
> Signed-off-by: Matthew Wilcox
Reviewed-by: Tobin C. Harding
> diff --git a/lib/list_debug.c b/lib/list_debug.c
> index a34db8d27667..5d5424b51b
On Fri, Mar 02, 2018 at 12:05:03PM +0300, Dan Carpenter wrote:
> There are so many rules for kernel developers to deal with. Is it worse
> to go over the 80 character limit or align the parameters properly? Is
> it OK to start the subject with a lower case letter? I get in trouble
> for using th
r the
new tag.
Cc: Greg Kroah-Hartman
Reviewed-by: Greg Kroah-Hartman
Signed-off-by: Tobin C. Harding
---
scripts/checkpatch.pl | 58 +++
1 file changed, 35 insertions(+), 23 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
are a)
duplicative and b) out of sync
Also, there has been comment over the use of the second capitalized
character 'D'.
This patch set attempts to either resolve this issue or bury it for
good.
May the bike shedding begin :)
Joe Perches (1):
checkpatch: add check for tag Co-Developed-by
Tobi
When Co-Developed-by tag was added, docs were only added to
Documention/process/5.Posting.rst and were not added to
Documention/process/submitting-patches.rst
Add documentation to Documention/process/submitting-patches.rst
Signed-off-by: Tobin C. Harding
---
The text in this patch is copied
Currently we must wait for enough entropy to become available before
hashed pointers can be printed. We can remove this wait by using the
hw RNG if available.
Use hw RNG to get keying material.
Suggested-by: Kees Cook
Signed-off-by: Tobin C. Harding
---
lib/vsprintf.c | 19
_long() instead of siphash
(as requested by Steve, and solves original problem for Anna-Maria).
Tobin C. Harding (4):
random: Fix whitespace pre random-bytes work
random: Return nbytes filled from hw RNG
vsprintf: Use hw RNG for ptr_key
vsprintf: Add command line option debug_early_boot
There are a couple of whitespace issues around the function
get_random_bytes_arch(). In preparation for patching this function
let's clean them up.
Signed-off-by: Tobin C. Harding
Acked-by: Theodore Ts'o
---
drivers/char/random.c | 3 +--
1 file changed, 1 insertion(+), 2 deletion
ned-off-by: Tobin C. Harding
---
Documentation/admin-guide/kernel-parameters.txt | 8
lib/vsprintf.c | 18 ++
2 files changed, 26 insertions(+)
diff --git a/Documentation/admin-guide/kernel-parameters.txt
b/Documentation/admin-gu
bytes_arch().
Only get random bytes from the hw RNG, make function return the number
of bytes retrieved from the hw RNG.
Signed-off-by: Tobin C. Harding
Acked-by: Theodore Ts'o
Signed-off-by: Tobin C. Harding
---
drivers/char/random.c | 16 +---
include/linux/random.h | 2 +-
On Thu, May 03, 2018 at 10:23:49PM -0400, Theodore Y. Ts'o wrote:
> On Fri, May 04, 2018 at 09:07:37AM +1000, Tobin C. Harding wrote:
> > Currently if an attempt is made to print a pointer before there is
> > enough entropy then '(ptrval)' is printed. This ma
On Fri, May 04, 2018 at 04:54:37PM -0400, Richard Guy Briggs wrote:
> Recognizing that the audit context is an internal audit value, use an
> access function to set the audit context pointer for the task
> rather than reaching directly into the task struct to set it.
>
> Signed-off-by: Richard Guy
On Wed, May 09, 2018 at 12:30:18AM -0500, Wenwen Wang wrote:
> Hello
>
> Could you please review this patch? We need a confirmation because we
> are working on an approaching deadline.
I didn't know 'we' had deadlines :)
Tobin
On Wed, Mar 14, 2018 at 11:19:53AM +0200, Kalle Valo wrote:
> "Tobin C. Harding" writes:
>
> > Added Konstantin in case he is in charge of administering
> > patchwork.kernel.org?
> >
> > On Tue, Mar 13, 2018 at 07:53:34PM -0700, Kees Cook wrote:
>
ed on initialization
(and re-initialization) so this overhead should not degrade performance.
[1] https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Tobin C. Harding
---
This applies onto tip of wireless-drivers next, commit
(28bf8312a983 mwifiex: get_channel from firmware
v2:
- Use k
On Sat, May 05, 2018 at 11:34:45PM +0200, Andrea Greco wrote:
> From: Andrea Greco
Hi Andrea,
Here are some (mostly stylistic) suggestions to help you get your driver merged.
> Add support for com20022I/com20020, memory mapped chip version.
> Support bus: Intel 80xx and Motorola 68xx.
> Bus siz
On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote:
> From: Andrea Greco
>
> If com20020 clock is major of 40Mhz SLOWARB bit is requested.
>
> Signed-off-by: Andrea Greco
> ---
> drivers/net/arcnet/com20020.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/a
On Sat, May 05, 2018 at 11:35:29PM +0200, Andrea Greco wrote:
> From: Andrea Greco
>
> Setup ethtols for export com20020 diag register
>
> Signed-off-by: Andrea Greco
> ---
> drivers/net/arcnet/com20020-isa.c| 1 +
> drivers/net/arcnet/com20020-membus.c | 1 +
> drivers/net/arcnet/com200
On Tue, May 08, 2018 at 11:36:51AM +0200, Andrea Greco wrote:
> On 05/07/2018 04:55 AM, Tobin C. Harding wrote:
> >On Sat, May 05, 2018 at 11:34:45PM +0200, Andrea Greco wrote:
> >>From: Andrea Greco
> >
> >Hi Andrea,
> >
> >Here are some (mostly stylisti
On Wed, Apr 18, 2018 at 09:14:36AM +0200, Thomas Richter wrote:
> Reading file /proc/modules shows the correct address:
> [root@s35lp76 ~]# cat /proc/modules | egrep '^qeth_l2'
> qeth_l2 94208 1 - Live 0x03ff80401000
>
> and reading file /sys/module/qeth_l2/sections/.text
> [root@s35lp76 ~]# c
From: Tobin C Harding
Patch fixes sparse warning: Using plain integer as NULL pointer. Replaces
assignment of 0 to pointer with NULL assignment.
Signed-off-by: Tobin C Harding
---
mm/memory.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
From: Tobin C Harding
Patch fixes whitespace checkpatch warnings.
Signed-off-by: Tobin C Harding
---
mm/memory.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index cc5fa12..3562314 100644
--- a/mm/memory.c
+++ b/mm/memory.c
From: Tobin C Harding
Patch fixes whitespace checkpatch errors.
Signed-off-by: Tobin C Harding
---
mm/memory.c | 42 +-
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 3562314..35fb8b2 100644
--- a/mm
From: Tobin C Harding
This patchset fixes trivial sparse and checkpatch errors/warnings. The
majority of the changes are whitespace only. The only code changes are
replace 0 with NULL, and remove extraneous braces around single statement.
Patchset aims to only make changes when they objectively
From: Tobin C Harding
Patch fixes checkpatch warning on use of braces around a single
statement.
Signed-off-by: Tobin C Harding
---
mm/memory.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 35fb8b2..654e6f4 100644
--- a/mm/memory.c
+++ b
On Wed, Mar 22, 2017 at 07:29:50AM +1300, Derek Robson wrote:
> On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote:
> > On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote:
> > > Fixed style of all block comments across whole driver
> > > Found by checkpatch
> > >
> > > Signed-off-by
On Tue, Mar 14, 2017 at 04:12:31PM +0100, Shiva Kerdel wrote:
> Hello Tobin,
>
> I missed the other files because they did not show up using the checkpatch
> script.
> Next time I will do a recursive search through the files before committing
> the changes to avoid this situation.
>
> Before I
On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote:
> Wrapping all complex macros with parentheses to resolve checkpatch
> errors. This change, along with the preceding changes in this change
> set, resolves all checkpatch warnings and errors for the file.
>
> Signed-off-by: Matthew Gi
Various functions take as parameter an optional pointer. Pointer
should be guarded with non-NULL check before dereferencing.
Add non-NULL check before dereference of pointer.
Signed-off-by: Tobin C. Harding
---
drivers/mmc/core/sdio_io.c | 12
1 file changed, 8 insertions(+), 4
applied and built on x86_64 and PowerPC
Tobin C. Harding (2):
mmc: core: guard dereference of optional parameter
mmc: core: simplify return code
drivers/mmc/core/sdio_io.c | 54 ++
1 file changed, 21 insertions(+), 33 deletions(-)
--
2.7.4
: Tobin C. Harding
---
drivers/mmc/core/sdio_io.c | 42 +-
1 file changed, 13 insertions(+), 29 deletions(-)
diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c
index 3482314..d40744b 100644
--- a/drivers/mmc/core/sdio_io.c
+++ b/drivers/mmc
.llong is an undocumented PPC specific directive. The generic
equivalent is .quad, but even better (because it's self describing) is
.8byte.
Convert directives .llong -> .8byte
Signed-off-by: Tobin C. Harding
---
Fixes: issue #33 (github)
Patch is not tested. Has been built on Power8
On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote:
> On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> > > On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > >
> > > > Greetings,
> > > >
> > > > I bisected kdump breakage to $subject
es .llong -> .8byte
> >
> > Signed-off-by: Tobin C. Harding
> > ---
> >
> > Fixes: issue #33 (github)
>
> Thanks for tackling these!
>
> I have applied your patch to my local tree. I ran `git grep '\.llong'`,
> and found:
>
> tools/
> >> .8byte.
> >>
> >> Convert directives .llong -> .8byte
> >>
> >> Signed-off-by: Tobin C. Harding
> >> ---
> >>
> >> Fixes: issue #33 (github)
> >
> > Thanks for tackling these!
> >
> >
On Sun, Mar 12, 2017 at 03:29:59AM +0100, Shiva Kerdel wrote:
> Fix prefer kernel type 'u8' over 'uint8_t' checks.
>
> Signed-off-by: Shiva Kerdel
> ---
> drivers/staging/ks7010/ks_hostif.c | 4 +-
> drivers/staging/ks7010/ks_hostif.h | 114
> +--
> drivers
Checkpatch may be giving a false positive of type CONST_STRUCT when
parsing files in drivers/staging/comedi/drivers.
$ pwd
build/kernel/linux-trees/gregKH/staging/
$ cd drivers/staging/comedi/drivers
$ checkpatch --terse --show-types *.c | grep CONST_STRUCT
addi_apci_3501.c:97: WARNING:CONST_STR
On Tue, Feb 21, 2017 at 03:19:22PM -0800, Joe Perches wrote:
> On Wed, 2017-02-22 at 10:01 +1100, Tobin C. Harding wrote:
> > Checkpatch may be giving a false positive of type CONST_STRUCT when
> > parsing files in drivers/staging/comedi/drivers.
> >
> > $ pwd
> >
Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct ncp_inode_info *) is useless.
Remove unnecessary cast.
Signed-off-by: Tobin C. Harding
---
fs/ncpfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ncpfs/inode.c b/fs/ncpfs
Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct v9fs_inode *) is useless.
Remove unnecessary cast.
Signed-off-by: Tobin C. Harding
---
fs/9p/vfs_inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/9p/vfs_inode.c b/fs/9p
Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct proc_inode *) is useless.
Remove unnecessary cast.
Signed-off-by: Tobin C. Harding
---
fs/proc/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/inode.c b/fs/proc/inode.c
Coccinelle emits multiple WARNING: casting value returned by memory allocation
function to (u_int32_t __user *) is useless.
Remove unnecessary cast.
Signed-off-by: Tobin C. Harding
---
sound/pci/emu10k1/emufx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound
On Wed, Feb 22, 2017 at 07:59:57AM +0100, Takashi Iwai wrote:
> On Wed, 22 Feb 2017 07:47:16 +0100,
> Tobin C. Harding wrote:
> >
> > Coccinelle emits multiple WARNING: casting value returned by memory
> > allocation
> > function to (u_int32_t __user *) is useles
Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct ncp_inode_info *) is useless.
Remove unnecessary cast.
Changes since v1:
- Fix up typo
Signed-off-by: Tobin C. Harding
---
Kernel built successfully with patch applied.
fs/ncpfs/inode.c | 2 +-
1 file
Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct ncp_inode_info *) is useless.
Remove unnecessary cast.
Signed-off-by: Tobin C. Harding
---
Changes since v2:
- Put version amendment comments in correct place within patch email.
Changes since v1
Please use the imperative mood in the subject line i.e the short form
of git commit log.
A couple of example Subjects::
Subject: [PATCH 2/5] ext2: improve scalability of bitmap searching
Subject: [PATCH v2 01/27] x86: fix eflags tracking
Awesome work on you patches!
thanks,
Tobin.
ermination checks with checks for truncated string. Add log message
if string is truncated but do not return an error code.
Signed-off-by: Tobin C. Harding
---
drivers/staging/greybus/fw-management.c | 59 +++--
1 file changed, 19 insertions(+), 40 deletions(-)
diff --git
Module copies a user supplied string (module parameter) into a buffer
using strncpy() and does not check that the buffer is null terminated.
Replace call to strncpy() with call to strlcpy() ensuring that the
buffer is null terminated.
Signed-off-by: Tobin C. Harding
---
drivers/staging/fbtft
Current call to strncmp() uses a magic number. There is a compile
time constant defined for this buffer, included and used already at
other sites in the file.
Remove magic number. Replace with pre-existing compile time constant.
Signed-off-by: Tobin C. Harding
---
drivers/staging/fbtft
Module copies a user supplied string (module parameter) into a buffer
using strncpy() and does not check that the buffer is null terminated.
Replace call to strncpy() with call to strlcpy() ensuring that the
buffer is null terminated.
Signed-off-by: Tobin C. Harding
---
drivers/staging/fbtft
return value from call to strlcpy(). If source string is
truncated call pr_warn() to notify user.
Signed-off-by: Tobin C. Harding
---
drivers/staging/fbtft/fbtft_device.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers
.
Check return value of call to strlcpy() and throw warning if source
string is truncated.
v1 was a single patch. v2 adds 2 extra patches while retaining the
original v1 patch as the first of the series.
v2:
- Replace magic number
- Check return value of call to strlcpy()
Tobin C. Harding (3
-append "root=/dev/sda console=ttyS0" --enable-kvm --nographic -m 12G
Current implementation
#define NDEVICES 3
[ 134.376741] tm: Total milliseconds: 127152
Patched version
#define NDEVICES 3
[ 226.960212] tm: Total milliseconds: 220756
#define NDEVICES 35000
[
lacement to the page based
bitmap. This has the effect of simplifying the code and removing
the upper limit.
Signed-off-by: Tobin C. Harding
---
net/core/dev.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 29101c9.
This patch fixes two trivial whitespace messages (ERROR/WARNING).
Fixes trailing whitespace ERROR and fixes space before tabs WARNING.
Signed-off-by: Tobin C. Harding
---
include/linux/idr.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/idr.h b/include
This patch adds function declaration in order to quiet sparse symbol
not declared warning.
Signed-off-by: Tobin C. Harding
---
Unsure why adding declaration quiets sparse. This may not be the
correct solution. Only testing done is building and booting kernel.
Since 'purgatory' is c
This series fixes multiple occurences of sparse warning, 'symbol
is not declared. Should it be static?'. Initial patch adds 'static'
keyword to variable declarations. Second patch declares function in
order to clear same warning.
Tobin C. Harding (2):
arch/x86: Fix spars
This patch adds static declaration to a number of variables. Fixes
sparse symbol was not declared warnings.
Signed-off-by: Tobin C. Harding
---
arch/x86/purgatory/purgatory.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/purgatory/purgatory.c b/arch/x86
e C source file defining the function
in order to fix the sparse warning. Include the header file in ASM
file containing the call site thereby adding documentation of usage.
Tobin C. Harding (2):
x86/purgatory: Fix sparse warning, symbol not declared
x86/purgatory: Fix sparse warning, symbol no
Sparse emits several 'symbol not declared' warnings for various
functions and variables.
Add static keyword to functions and variables which have file scope
only.
Signed-off-by: Tobin C. Harding
---
arch/x86/purgatory/purgatory.c | 10 +-
1 file changed, 5 insertions(+), 5
to fix the sparse warning. Include the header file in ASM file
containing the call site thereby adding documentation of usage.
Signed-off-by: Tobin C. Harding
---
arch/x86/purgatory/purgatory.c| 1 +
arch/x86/purgatory/purgatory.h| 7 +++
arch/x86/purgatory/setup-x86_64.S | 3 ++-
3 fil
the
sparse warning. Include the header file in ASM file to document the
usage. Use preprocessor guard to enable C header file to be included
in ASM.
Signed-off-by: Tobin C. Harding
---
arch/x86/purgatory/purgatory.c| 1 +
arch/x86/purgatory/purgatory.h| 10 ++
arch/x86/purgatory/se
in C file contianing function
definition.
V3:
* Add preprocessor guard.
V2:
* Add header file.
Tobin C. Harding (2):
x86/purgatory: Fix sparse warning, symbol not declared
x86/purgatory: Fix sparse warning, symbol not declared
arch/x86/purgatory/purgatory.c| 11 ++-
arch/x86
Sparse emits several 'symbol not declared' warnings for various
functions and variables.
Add static keyword to functions and variables which have file scope
only. Remove definition to zero for each variable declared static
in accord with kernel standard.
Signed-off-by: Tobin
to fix the sparse warning. Include the header file in ASM file
containing the call site to document the usage.
Signed-off-by: Tobin C. Harding
---
arch/x86/purgatory/purgatory.c| 1 +
arch/x86/purgatory/purgatory.h| 12
arch/x86/purgatory/setup-x86_64.S | 4 ++--
3 files c
Sparse emits several 'symbol not declared' warnings for various
functions and variables.
Add static keyword to functions and variables which have file scope
only.
Signed-off-by: Tobin C. Harding
---
arch/x86/purgatory/purgatory.c | 10 +-
1 file changed, 5 insertions(+), 5
in C file contianing function
definition.
Changes since v3:
- Put preprocessor directives in correct order.
Changes since v2:
- Add preprocessor guard.
Changes since v1:
- Add header file.
Tobin C. Harding (2):
x86/purgatory: Fix sparse warning, symbol not declared
x86/purgatory: Fix sparse warni
On Sun, Feb 26, 2017 at 06:00:19PM -0800, Matthew Giassa wrote:
> ---
> drivers/staging/ks7010/ks_wlan_ioctl.h | 64
> +-
> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
> b/drivers/staging/ks7010/ks_wla
On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote:
>
>
> On Mon, 27 Feb 2017, Arushi Singhal wrote:
>
> >
> >
> > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH wrote:
> > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> > > Commenting Code Is a Bad Idea.
> >
Fix multiple occurrences of checkpatch warning. WARNING: Block
comments use * on subsequent lines. Also make comment blocks
more uniform.
Signed-off-by: Tobin C. Harding
---
net/core/dev.c | 65 +-
1 file changed, 33 insertions(+), 32
This patch fixes two trivial whitespace errors. Brace should be
on the previous line and trailing statements should be on next line.
Signed-off-by: Tobin C. Harding
---
net/core/dev.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a
This patch fixes multiple occurrences of checkpatch WARNING: Missing
a blank line after declarations.
Signed-off-by: Tobin C. Harding
---
net/core/dev.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 6a076a1..fa63485 100644
--- a/net
This patch fixes multiple occurrences of space before tabs warnings.
More lines of code were moved than required to keep kernel-doc
comments uniform.
Signed-off-by: Tobin C. Harding
---
net/core/dev.c | 142 -
1 file changed, 71 insertions
501 - 600 of 971 matches
Mail list logo
