On Mon, Apr 29, 2019, at 02:15, Greg Kroah-Hartman wrote:
> On Sun, Apr 28, 2019 at 11:19:57AM +1000, Tobin C. Harding wrote:
> > On Sat, Apr 27, 2019 at 09:28:09PM +0200, Greg Kroah-Hartman wrote:
> > > On Sat, Apr 27, 2019 at 06:13:30PM +1000, Tobin C. Harding wrote:
> >
Currently error return from kobject_init_and_add() is not followed by a
call to kobject_put(). This means there is a memory leak.
Add call to kobject_put() in error path of kobject_init_and_add().
---
kernel/sched/cpufreq_schedutil.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/sch
Currently error return from kobject_init_and_add() is not followed by a
call to kobject_put(). This means there is a memory leak.
Add call to kobject_put() in error path of kobject_init_and_add().
Signed-off-by: Tobin C. Harding
---
kernel/livepatch/core.c | 12 +---
1 file changed, 9
of an effort to check/fix all callsites of
kobject_init_and_add().
This set fixes all callsites under kernel/livepatch/
thanks,
Tobin.
Tobin C. Harding (2):
livepatch: Fix kobject memleak
livepatch: Use correct kobject cleanup function
kernel/livepatch/core.c | 20
1
The correct cleanup function after a call to kobject_init_and_add() has
succeeded is kobject_del() _not_ kobject_put(). kobject_del() calls
kobject_put().
Use correct cleanup function when removing a kobject.
Signed-off-by: Tobin C. Harding
---
kernel/livepatch/core.c | 8 +++-
1 file
Currently error return from kobject_init_and_add() is not followed by a
call to kobject_put(). This means there is a memory leak.
Add call to kobject_put() in error path of kobject_init_and_add().
Signed-off-by: Tobin C. Harding
---
Resend with SOB tag.
kernel/sched/cpufreq_schedutil.c | 1
ng with 'isolate' and 'migrate'
callbacks.
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
include/linux/slab.h | 70
include/linux/slub_def.h | 3 ++
mm/slub.c| 59 ++
est effort', results
vary. This is as is expected. We are trying to unobtrusively shrink
the dentry cache.
thanks,
Tobin.
Tobin C. Harding (15):
slub: Add isolate() and migrate() methods
tools/vm/slabinfo: Add support for -C and -M options
slub: Sort slab cache list
slub: Slab defrag
It is advantageous to have all defragmentable slabs together at the
beginning of the list of slabs so that there is no need to scan the
complete list. Put defragmentable caches first when adding a slab cache
and others last.
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
-C lists caches that use a ctor.
-M lists caches that support object migration.
Add command line options to show caches with a constructor and caches
that are movable (i.e. have migrate function).
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 40
to the
recently added function:
void kmem_cache_setup_mobility(struct kmem_cache *,
kmem_cache_isolate_func,
kmem_cache_migrate_func);
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Hard
Add output line for NUMA remote node defrag ratio.
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index cbfc56c44c2f..d2c22f9ee2d8 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm
g : Off Lpadd: 352
We can run the stress tests (with the default number of objects):
# cd /sys/kernel/debug/smo
# echo 'test' > callfn
[3.576617] smo: test using nr_objs: 1000 keep: 10
[3.580169] smo: Module tests completed successfully
Signed-off-by: Tobin
Add output for the newly added defrag_used_ratio sysfs knob.
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 4
1 file changed, 4 insertions(+)
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index d2c22f9ee2d8..ef4ff93df4cc 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm
remaining partial slab.
Signed-off-by: Tobin C. Harding
---
tools/testing/slab/Makefile | 2 +-
tools/testing/slab/slub_defrag_xarray.c | 211
2 files changed, 212 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/slab/slub_defrag_xarray.c
di
ache (thanks Matthew).
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
lib/radix-tree.c | 13 +
lib/xarray.c | 49
2 files changed, 62 insertions(+)
diff --git a/lib/radix-tree.c b/lib/radix-tree.c
i
ling movable objects ...
verified movable slabs are shrinkable
Removing module slub_defrag ...
Signed-off-by: Tobin C. Harding
---
tools/testing/slab/slub_defrag.c | 1 +
tools/testing/slab/slub_defrag.py | 451 ++
2 files changed, 452 insertions(+)
create mode 10075
node (from N1 -> to N2):
echo "N1 N2" > move
This also enables shrinking slabs on a specific node:
echo "N1 N1" > move
Signed-off-by: Tobin C. Harding
---
mm/Kconfig | 7 ++
mm/slub.c | 249 +
2 file
rs balance, no other value accepted.
This feature relies on SMO being enable for the cache, this is done with
a call to, after the isolate/migrate functions have been defined.
kmem_cache_setup_mobility(s, isolate, migrate)
Signed-off-by: Tobin C. Harding
---
mm/sl
plicit that no reallocation is done.
Implement isolate and 'migrate' functions for the dentry slab cache.
Signed-off-by: Tobin C. Harding
---
fs/dcache.c | 76 +
1 file changed, 76 insertions(+)
diff --git a/fs/dcache.c b/fs/dcache.c
ind
obility is enabled and the isolate/migrate functions are built in.
Add CONFIG_DCACHE_SMO to guard the partial shrinking of the dcache via
Slab Movable Objects infrastructure.
Signed-off-by: Tobin C. Harding
---
fs/dcache.c | 4
mm/Kconfig | 7 +++
2 files changed, 11 insertions(+)
diff
In order to support object migration on the dentry cache we need to have
a determined object state at all times. Without a constructor the object
would have a random state after allocation.
Provide a dentry constructor.
Signed-off-by: Tobin C. Harding
---
fs/dcache.c | 30
On Tue, Apr 30, 2019 at 06:24:43AM +0200, Ingo Molnar wrote:
>
> * Tobin C. Harding wrote:
>
> > Currently error return from kobject_init_and_add() is not followed by a
> > call to kobject_put(). This means there is a memory leak.
> >
> > Add call
On Tue, Apr 30, 2019 at 11:26:27AM +0530, Viresh Kumar wrote:
> On 29-04-19, 22:52, tip-bot for Tobin C. Harding wrote:
> > Commit-ID: 8bf7ab9c79f3d1a5f02ebac369f656de9ec0aca8
> > Gitweb:
> > https://git.kernel.org/tip/8bf7ab9c79f3d1a5f02ebac369f656de9ec0aca8
> > A
e error path of
> kobject_init_and_add().
>
> Signed-off-by: Viresh Kumar
> ---
> Tobin fixed this for schedutil already.
For what its worth:
Reviewed-by: Tobin C. Harding
Thanks Viresh, one less for me to do!
Tobin
On Tue, Apr 30, 2019 at 05:08:11PM +0200, Petr Mladek wrote:
> On Tue 2019-04-30 10:15:34, Tobin C. Harding wrote:
> > The correct cleanup function after a call to kobject_init_and_add() has
> > succeeded is kobject_del() _not_ kobject_put(). kobject_del() calls
> > kobject_
On Tue, Apr 30, 2019 at 01:00:05PM +0200, Miroslav Benes wrote:
> On Tue, 30 Apr 2019, Tobin C. Harding wrote:
>
> > The correct cleanup function after a call to kobject_init_and_add() has
> > succeeded is kobject_del() _not_ kobject_put(). kobject_del() calls
> > kob
On Tue, Apr 30, 2019 at 10:28:15AM +1000, Tobin C. Harding wrote:
[snip]
Please do not consider this series for merge. There is a bit of
confusion here.
There are a few of theses patches live on various LKML lists. Have to
consolidate all the knowledge. When I _actually_ know how to use
On Tue, Apr 30, 2019 at 12:44:55PM +0200, Miroslav Benes wrote:
> On Tue, 30 Apr 2019, Greg Kroah-Hartman wrote:
>
> > On Tue, Apr 30, 2019 at 10:15:33AM +1000, Tobin C. Harding wrote:
> > > Currently error return from kobject_init_and_add() is not followed by a
> > >
On Sun, Apr 28, 2019 at 09:40:00AM +1000, Tobin C. Harding wrote:
> Currently error return from kobject_init_and_add() is not followed by a
> call to kobject_put(). This means there is a memory leak.
>
> Add call to kobject_put() in error path of kobject_init_and_add().
>
> Si
Hi,
Looks like I've created a bit of confusion trying to fix memleaks in
calls to kobject_init_and_add(). Its spread over various patches and
mailing lists so I'm starting a new thread and CC'ing anyone that
commented on one of those patches.
If there is a better way to go about this discussion
On Wed, May 01, 2019 at 09:54:16AM +0200, Rafael J. Wysocki wrote:
> On Wed, May 1, 2019 at 1:38 AM Tobin C. Harding wrote:
> >
> > Hi,
> >
> > Looks like I've created a bit of confusion trying to fix memleaks in
> > calls to kobject_init_and_add()
On Sat, Apr 27, 2019 at 09:28:09PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 27, 2019 at 06:13:30PM +1000, Tobin C. Harding wrote:
> > (Note at bottom on reasons for 'To' list 'Cc' list)
> >
> > Hi,
> >
> > kobject_init_and_add()
On Wed, May 01, 2019 at 01:10:22PM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 01, 2019 at 09:38:03AM +1000, Tobin C. Harding wrote:
> > Hi,
> >
> > Looks like I've created a bit of confusion trying to fix memleaks in
> > calls to kobject_init_and_add(). Its
Currently the docstring for kobject_get_path() mentions 'kset'. The
kset is not used in the function callchain starting from this function.
Remove docstring reference to kset from the function kobject_get_path().
Signed-off-by: Tobin C. Harding
---
lib/kobject.c | 5 ++---
1 file
->state_initialized.
Signed-off-by: Tobin C. Harding
---
include/linux/kobject.h | 2 ++
lib/kobject.c | 12
2 files changed, 14 insertions(+)
diff --git a/include/linux/kobject.h b/include/linux/kobject.h
index 1ab0d624fb36..65a317b65d9c 100644
--- a/include/linux/kobject.h
++
present.
Signed-off-by: Tobin C. Harding
---
lib/kobject.c | 43 ++-
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/lib/kobject.c b/lib/kobject.c
index 3eacd5b4643f..0181f102cd1c 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -18,7 +18,7
Currently error return from kobject_init_and_add() is not followed by a
call to kobject_put(). This means there is a memory leak.
Add call to kobject_put() in error path of kobject_init_and_add().
Signed-off-by: Tobin C. Harding
---
kernel/livepatch/core.c | 12 +---
1 file changed, 9
Currently we use custom logic to track kobject initialization. Recently
a predicate function was added to the kobject API so we now no longer
need to do this.
Use kobject API to check for initialized state of kobjects instead of
using custom logic to track state.
Signed-off-by: Tobin C. Harding
Ftrace, it
appears to crash during this. Was hoping to run the livepatch tests but
not sure how to at this moment. Is dynamic Ftrace and livepatch testing
something that can even be done in a VM or do I need to do this or
baremetal?
Thanks for taking the time to look at this.
Tobin
Tobin
On Thu, May 02, 2019 at 09:28:08AM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 02, 2019 at 09:17:42AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, May 02, 2019 at 07:56:16AM +1000, Tobin C. Harding wrote:
> > > On Sat, Apr 27, 2019 at 09:28:09PM +0200, Greg Kroah-Hartman wro
Adding Jon to CC
On Thu, May 02, 2019 at 09:38:23AM +0200, Johan Hovold wrote:
> On Thu, May 02, 2019 at 12:31:40PM +1000, Tobin C. Harding wrote:
> > kernel-doc comments have a prescribed format. This includes parenthesis
> > on the function name. To be _particularly_ correct
On Thu, May 02, 2019 at 09:30:44AM +0200, Petr Mladek wrote:
> On Thu 2019-05-02 09:12:32, Greg Kroah-Hartman wrote:
> > On Thu, May 02, 2019 at 12:31:42PM +1000, Tobin C. Harding wrote:
> > > Currently we use custom logic to track kobject initialization. Recently
> > &g
On Thu, May 02, 2019 at 10:34:12AM +0200, Petr Mladek wrote:
> On Wed 2019-05-01 09:38:03, Tobin C. Harding wrote:
> > Hi,
> >
> > Looks like I've created a bit of confusion trying to fix memleaks in
> > calls to kobject_init_and_add(). Its spread over various
ly be more explicit
> as to exactly what needs to happen here once you register a kobject with the
> kobject core.
>
> Cc: Tobin C. Harding
> Fixes: 1fd7c3b438a2 ("kobject: Improve doc clarity kobject_init_and_add()")
> Signed-off-by: Greg Kroah-Hartman
>
&g
On Thu, May 02, 2019 at 10:39:22AM +0200, Johan Hovold wrote:
> On Thu, May 02, 2019 at 06:25:39PM +1000, Tobin C. Harding wrote: > Adding
> Jon to CC
> >
> > On Thu, May 02, 2019 at 09:38:23AM +0200, Johan Hovold wrote:
> > > On Thu, May 02, 2019 at 12:31:40PM
On Sat, Jun 29, 2019 at 08:06:24PM +0100, Al Viro wrote:
> On Sat, Jun 29, 2019 at 05:38:03AM +0100, Al Viro wrote:
>
> > PS: the problem is not gone in the next iteration of the patchset in
> > question. The patch I'm proposing (including dput_to_list() and _ONLY_
> > compile-tested) follows. C
On Fri, Mar 08, 2019 at 09:22:37AM -0700, Tycho Andersen wrote:
> On Fri, Mar 08, 2019 at 04:15:46PM +, Christopher Lameter wrote:
> > On Fri, 8 Mar 2019, Tycho Andersen wrote:
> >
> > > On Fri, Mar 08, 2019 at 03:14:13PM +1100, Tobin C. Harding wrote:
> > >
On Fri, Mar 08, 2019 at 09:40:03AM +0100, Markus Heiser wrote:
>
> Am 07.03.19 um 22:11 schrieb Tobin C. Harding:
> > Hi,
> >
> > I had a few hours to spare so I thought I'd clear some Sphinx build
> > warnings/errors. There isn't anything too controversi
of
slabs.
Signed-off-by: Tobin C. Harding
---
mm/slob.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/mm/slob.c b/mm/slob.c
index 307c2c9feb44..ee68ff2a2833 100644
--- a/mm/slob.c
+++ b/mm/slob.c
@@ -112,13 +112,13 @@ static inline int slob_page_free(struct page
of
slabs.
Signed-off-by: Tobin C. Harding
---
mm/slab.c | 49 +
1 file changed, 25 insertions(+), 24 deletions(-)
diff --git a/mm/slab.c b/mm/slab.c
index 28652e4218e0..09cc64ef9613 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1710,8 +1710,8 @@ sta
of
slabs.
Signed-off-by: Tobin C. Harding
---
mm/slub.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index b282e22885cd..d692b5e0163d 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1023,7 +1023,7 @@ static v
#ifdef CONFIG_FOO
...
#endif /* CONFIG_FOO */
Add comments to endif pre-processor macros if ifdef/endif pair is not
immediately apparent.
Signed-off-by: Tobin C. Harding
---
mm/slub.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/mm/slub.c
makes no code changes, adds comments to #endif statements.
Final 3 patches do changes as a patch per allocator, tested by building
and booting (in Qemu) after configuring kernel to use appropriate
allocator. Also build and boot with debug options enabled (for slab
and slub).
thanks,
Tobin.
Tobin
On Fri, Mar 08, 2019 at 09:01:51AM -0700, Tycho Andersen wrote:
> On Fri, Mar 08, 2019 at 03:14:18PM +1100, Tobin C. Harding wrote:
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -3642,6 +3642,7 @@ static int kmem_cache_open(struct kmem_cache *s,
&
On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote:
> On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote:
> > The patchset looks good to me, however I'd add some clarifications
> > why switching from lru to slab_list is safe.
> >
> > My understanding is that the slab_list f
On Tue, Mar 12, 2019 at 12:22:23AM +, Roman Gushchin wrote:
> On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote:
> > On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote:
> > > The patchset looks good to me, however I'd add some clarifications
> > > why switching from lru
On Mon, Mar 11, 2019 at 09:51:09PM +, Roman Gushchin wrote:
> On Fri, Mar 08, 2019 at 03:14:13PM +1100, Tobin C. Harding wrote:
> > Add the two methods needed for moving objects and enable the display of
> > the callbacks via the /sys/kernel/slab interface.
> >
On Mon, Mar 11, 2019 at 09:23:27PM +, Roman Gushchin wrote:
> On Fri, Mar 08, 2019 at 03:14:12PM +1100, Tobin C. Harding wrote:
> > Create an ops field in /sys/slab/*/ops to contain all the callback
> > operations defined for a slab cache. This will be used to display
>
On Mon, Mar 11, 2019 at 09:54:17PM +, Roman Gushchin wrote:
> On Fri, Mar 08, 2019 at 03:14:14PM +1100, Tobin C. Harding wrote:
> > -F lists caches that support object migration.
>
> Maybe -M?
Seems reasonable, will use in v2, thanks.
Tobin.
On Mon, Mar 11, 2019 at 10:48:45PM +, Roman Gushchin wrote:
> On Fri, Mar 08, 2019 at 03:14:15PM +1100, Tobin C. Harding wrote:
> > We have now in place a mechanism for adding callbacks to a cache in
> > order to be able to implement object migration.
> >
> > A
On Tue, Mar 12, 2019 at 12:09:31AM +, Roman Gushchin wrote:
> On Fri, Mar 08, 2019 at 03:14:11PM +1100, Tobin C. Harding wrote:
> > Hi,
> >
> > Here is a patch set implementing movable objects within the SLUB
> > allocator. This is work based on Christopher&#
On Mon, Mar 11, 2019 at 11:35:29PM +, Roman Gushchin wrote:
> On Fri, Mar 08, 2019 at 03:14:20PM +1100, Tobin C. Harding wrote:
> > If many objects are allocated with the slab allocator and freed in an
> > arbitrary order then the slab caches can become internally fragmented.
&
On Tue, Mar 12, 2019 at 12:16:07AM +, Roman Gushchin wrote:
> On Fri, Mar 08, 2019 at 03:14:23PM +1100, Tobin C. Harding wrote:
> > Implement functions to migrate objects. This is based on
> > initial code by Matthew Wilcox and was modified to work with
> > slab object m
On Tue, Mar 12, 2019 at 12:22:23AM +, Roman Gushchin wrote:
> On Mon, Mar 11, 2019 at 04:16:33PM -0700, Matthew Wilcox wrote:
> > On Mon, Mar 11, 2019 at 08:49:23PM +, Roman Gushchin wrote:
> > > The patchset looks good to me, however I'd add some clarifications
> > > why switching from lru
On Mon, Mar 11, 2019 at 07:38:28PM -0700, Matthew Wilcox wrote:
> On Tue, Mar 12, 2019 at 12:05:54PM +1100, Tobin C. Harding wrote:
> > > slab_list and lru are in the same bits. Once this patch set is in,
> > > we can remove the enigmatic 'uses lru' comment that I a
thing *thing;
unsigned long index;
xa_for_each(&things, index, thing)
xa_erase(&things, index);
}
Document this feature explicitly in the docs and also for the macro
definition.
Signed-off-by: Tobin C. Harding
---
Changes
On Tue, Feb 12, 2019 at 06:29:58PM +1100, Tobin C. Harding wrote:
> The XArray is, in a way, a replacement data structure for linked lists,
> as such, on first use developers may wonder if it is safe to remove
> items while iterating over the array.
>
> For exampl
On Wed, Feb 13, 2019 at 03:56:47PM +, David Laight wrote:
> From: Tobin C. Harding
> > Sent: 07 February 2019 22:50
> >
> > Currently if user passes an output file to the script via
> > --output-raw we do not handle expansion of tilde.
> >
> > Use
slowing this one down with my poor
knowledge of how kselftest works it seems better to do this separately.
thanks for looking at this,
Tobin.
Tobin C. Harding (1):
lib/string: Add strscpy_pad() function
include/linux/string.h | 4 +
lib/Kconfig.debug | 3 +
lib/Makefile
functionality. This is a chore, and also leaves us open to
off by one errors unnecessarily.
Add a function that calls strscpy() then memset()s the tail to zero if
the source string is shorter than the destination buffer.
Add test module for the new code.
Signed-off-by: Tobin C. Harding
---
include
gt;
> While I still think co-developed-by: is unnecessary and
> almost none of the existing uses of this have this
> sequence of "Co-developed-by: " followed directly
> by "Signed-off-by: ", here's a possible
> checkpatch addition for it.
Tested-by: Tobin C. Harding
Catches missing SOB of co-developer.
Hope this helps,
Tobin.
functionality. This is a chore, and also leaves us open to
off by one errors unnecessarily.
Add a function that calls strscpy() then memset()s the tail to zero if
the source string is shorter than the destination buffer.
Add testing via kselftest.
Signed-off-by: Tobin C. Harding
---
include/linux
left non-null terminated.
Signed-off-by: Tobin C. Harding
---
lib/strncpy_from_user.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/lib/strncpy_from_user.c b/lib/strncpy_from_user.c
index 58eacd41526c..11fe9a4a00fd 100644
--- a/lib/strncpy_from_user.c
Currently the docstring comments for strscpy() are not in the correct
format. Prior to working on this file fix up the docstring.
Use correct docstring format for strscpy().
Signed-off-by: Tobin C. Harding
---
lib/string.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions
graph that describes the
config symbol fully
I couldn't work out if this is a false positive or not? Does the new
config option CONFIG_TEST_STRING need more documentation? I don't see
where extra docs should be added and it seems self explanatory as is.
thanks,
Tobin.
Tobin C. Hardi
execution with the user string
truncated.
Add a function strscpy_from_user() that guarantees the string written is
null-terminated. If user string is longer than destination buffer
truncates the string. Returns the number of characters written
excluding the null-terminator.
Signed-off-by: Tobin C
w' documentation for under filled buffer.
Signed-off-by: Tobin C. Harding
---
lib/string.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/string.c b/lib/string.c
index 38e4ca08e757..7f1d72db53c5 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -173,8 +173,8 @@
Currently we have a test module but it is not tied into the kselftest
infrastructure. In preparation for adding string manipulation functions
and testing we should enable kselftest to utilize the test module.
Enable string testing via kselftest infrastructure.
Signed-off-by: Tobin C. Harding
On Mon, Mar 25, 2019 at 10:33:33AM -0600, Jonathan Corbet wrote:
> On Fri, 8 Mar 2019 08:11:44 +1100
> "Tobin C. Harding" wrote:
>
> > I had a few hours to spare so I thought I'd clear some Sphinx build
> > warnings/errors.
>
> So there were comments
On Tue, Feb 05, 2019 at 11:30:53AM +0530, Bharath Vedartham wrote:
> Hi all,
>
> I am unable to execute make modules_install install.
> I get the following error:
Could you show the complete commands you are trying please
thanks,
Tobin.
Currently the test_printf module does not have an exit function, this
prevents the module from being unloaded. If we cannot unload the
module we cannot run the tests a second time.
Add an empty exit function.
Signed-off-by: Tobin C. Harding
---
lib/test_printf.c | 6 ++
1 file changed, 6
testing/selfests/lib?
Thanks for looking at this,
Tobin.
Tobin C. Harding (7):
lib/test_printf: Add empty module_exit function
kselftest: Add test runner creation script
kselftest/lib: Use new shell runner to define tests
kselftest: Add test module framework header
lib: Use new kselftest head
.
Signed-off-by: Tobin C. Harding
---
Documentation/dev-tools/kselftest.rst | 108 -
tools/testing/selftests/kselftest_module.h | 48 +
2 files changed, 154 insertions(+), 2 deletions(-)
create mode 100644 tools/testing/selftests/kselftest_module.h
diff --git a
functionality. This is a chore, and also leaves us open to
off by one errors unnecessarily.
Add a function that calls strscpy() then memset()s the tail to zero if
the source string is shorter than the destination buffer.
Signed-off-by: Tobin C. Harding
---
include/linux/string.h | 4
lib
handle building/running tests with
the O=/path/to/out make option.
Add test runner creation script.
Signed-off-by: Tobin C. Harding
---
tools/testing/selftests/kselftest_module.sh | 75 +
1 file changed, 75 insertions(+)
create mode 100755 tools/testing/selftests
We just added a new C header file for use with test modules that are
intended to be run with kselftest. We can reduce code duplication by
using this header.
Use new kselftest header to reduce code duplication in test_printf and
test_bitmap test modules.
Signed-off-by: Tobin C. Harding
---
lib
/kselftest_module.sh to
define test runner scripts.
Signed-off-by: Tobin C. Harding
---
tools/testing/selftests/lib/bitmap.sh| 25 ++--
tools/testing/selftests/lib/prime_numbers.sh | 23 +-
tools/testing/selftests/lib/printf.sh| 25 ++--
3 files
Add a test module for the new strscpy_pad() function. Tie it into the
kselftest infrastructure for lib/ tests.
Signed-off-by: Tobin C. Harding
---
lib/Kconfig.debug | 3 +
lib/Makefile | 1 +
lib/test_strscpy.c | 150
On Thu, Mar 07, 2019 at 08:42:19AM +1100, Tobin C. Harding wrote:
> Hi,
Man, I didn't see the merge window was open, I thought rc8 only came out
on Sunday.
Sorry, please ignore this. Will re-send again later in the cycle.
thanks,
Tobin.
gging output which is
currently broken in a bunch of places, the other removes the --version
command line option.
Both patches have been tested and sitting in linux-next tree for a month
or so.
Signed-off-by: Tobin C. Harding
To
do you have a script by any chance that does a clean build of
the docs, saves stderr output, applies a patch, cleanly re-builds the
docs and then diffs the two outputs? Then rinse-and-repeat for a whole
patch series. Thought I'd ask before I write one.
thanks,
Tobin.
Tobin C. Harding (9):
Documentation contains a spelling mistake / typo.
s/descibed/described/
Fix spelling mistake.
Signed-off-by: Tobin C. Harding
---
Documentation/process/howto.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/process/howto.rst b/Documentation/process
Sphinx uses a star not a hyphen for lists.
Use correct list markup character.
Signed-off-by: Tobin C. Harding
---
Documentation/driver-api/gpio/board.rst | 5 +++--
Documentation/laptops/lg-laptop.rst | 12 ++--
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a
Labels that precede a heading use the heading as the link title.
Explicitly adding the link title defeats the purpose of this feature
i.e. makes the reference less maintainable.
Remove unnecessary reference link title.
Signed-off-by: Tobin C. Harding
---
Documentation/admin-guide/mm
Current RST file contains an unknown directive causing Sphinx to emit
ERROR: Unexpected indentation.
Use normal language construct instead.
Signed-off-by: Tobin C. Harding
---
Documentation/driver-api/dmaengine/dmatest.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Sphinx emits a bunch of 'Title underline too short' warnings. We can
fix these by using the correct length underlines.
Fix Title underline too short warning by amending heading underline.
Signed-off-by: Tobin C. Harding
---
Documentation/filesystems/path-looku
Sphinx emits warning
WARNING: Explicit markup ends without a blank line; unexpected
unindent.
This is caused by a missing line after the SPDX license identifier.
Add blank line after SPDX licence identifier.
Signed-off-by: Tobin C. Harding
---
Documentation/laptops/lg
Sphinx emits:
WARNING: Inline interpreted text or phrase reference
start-string without end-string.
This is caused by a spurious backtick.
Replace backtick with apostrophe.
Signed-off-by: Tobin C. Harding
---
include/linux/kernel.h | 2 +-
1 file changed, 1 insertion(+), 1
without a blank line; unexpected unindent.
Add the colon, clearing sphinx warnings.
Signed-off-by: Tobin C. Harding
---
Documentation/vm/slub.rst | 2 +-
include/linux/wait.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/vm/slub.rst b/Documentation/vm
401 - 500 of 971 matches
Mail list logo
