On 25.06.2018 10:02, Christian Borntraeger wrote:
>
>
> On 06/25/2018 09:27 AM, Christian Borntraeger wrote:
>> Also adding QEMU.
>>
>> On 06/25/2018 09:10 AM, Christian Borntraeger wrote:
>>>
>>>
>>> On 06/22/2018 09:47 PM, Guenter Roeck wrote:
Hi,
starting with commit 's390/boot:
On 25.01.2018 16:47, Farhan Ali wrote:
> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")'
> added the HAS_IOMEM dependecy for "Graphics support". This disabled the
> "Graphics support" menu for S390. But if we enable VT layer for S390,
> we would also need to enable th
On 25.01.2018 16:47, Farhan Ali wrote:
> The Opencores framebuffer device uses I/O memory and with
> CONFIG_HAS_IOMEM disabled will lead to build errors:
>
> ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined!
>
> Fix this by adding HAS_IOMEM dependency for FB_OPENCORES.
>
>
CONFIG_I2C. These two patches now refactor the DRM code a little bit
so that we can compile it also without CONFIG_HDMI and CONFIG_I2C.
Thomas Huth (2):
drivers/gpu/drm: Move CONFIG_HDMI-dependent code to a separate file
drivers/gpu/drm: Make the DRM code compilable without CONFIG_I2C
drivers
ove the related code to a separate file for this.
Signed-off-by: Thomas Huth
---
drivers/gpu/drm/Kconfig | 2 +-
drivers/gpu/drm/Makefile| 1 +
drivers/gpu/drm/drm_crtc_internal.h | 2 +
drivers/gpu/drm/drm_edid.c | 163 +---
akefile to only compile the affected files
with CONFIG_I2C=y and disable some I2C-related code in drm_edid.c.
Signed-off-by: Thomas Huth
---
drivers/gpu/drm/Kconfig| 4 ++--
drivers/gpu/drm/Makefile | 16 +---
drivers/gpu/drm/drm_edid.c | 10 +++---
3 files changed, 18 inserti
On 13.04.2018 16:32, Daniel Vetter wrote:
> On Fri, Apr 13, 2018 at 11:40 AM, Thomas Huth wrote:
>> By enabling the DRM code for virtio-gpu on S390, you currently also get
>> all the code that is enabled by CONFIG_HDMI and CONFIG_I2C automatically.
>> This is quite ugly, si
suggetions?
Closes: https://issues.redhat.com/browse/RHEL-39983
?
Anyway, I've tested the patch and it indeed fixes the problem with
virtio-balloon and the link state for me:
Tested-by: Thomas Huth
Am Thu, 23 Apr 2015 17:26:20 +0200
schrieb Greg Kurz :
> Signed-off-by: Greg Kurz
> ---
> include/linux/virtio_config.h | 17 +++--
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
> index ca3ed78..bd
Am Thu, 23 Apr 2015 19:22:15 +0200
schrieb Thomas Huth :
> Am Thu, 23 Apr 2015 17:26:20 +0200
> schrieb Greg Kurz :
>
> > Signed-off-by: Greg Kurz
> > ---
> > include/linux/virtio_config.h | 17 +++--
> > 1 file changed, 11 insertions(+), 6 d
, val);
> }
>
> static inline __virtio64 cpu_to_virtio64(struct virtio_device *vdev, u64 val)
> {
> - return __cpu_to_virtio64(virtio_has_feature(vdev, VIRTIO_F_VERSION_1),
> val);
> + return __cpu_to_virtio64(virtio_is_little_endian(vdev), val);
> }
Reviewed-by: Thoma
val)
> {
> - return __cpu_to_virtio16(tun->flags & TUN_VNET_LE, val);
> + return __cpu_to_virtio16(tun_is_little_endian(tun), val);
> }
Reviewed-by: Thomas Huth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
inline __virtio16 cpu_to_macvtap16(struct macvtap_queue *q, u16 val)
> {
> - return __cpu_to_virtio16(q->flags & MACVTAP_VNET_LE, val);
> + return __cpu_to_virtio16(macvtap_is_little_endian(q), val);
> }
Reviewed-by: Thomas Huth
--
To unsubscribe from this list: send the line &
virtio64_to_cpu(vringh_is_little_endian(vrh), val);
> }
>
> static inline __virtio64 cpu_to_vringh64(const struct vringh *vrh, u64 val)
> {
> - return __cpu_to_virtio64(vrh->little_endian, val);
> + return __cpu_to_virtio64(vringh_is_little_endian(vrh),
static inline __virtio64 cpu_to_vhost64(struct vhost_virtqueue *vq, u64 val)
> {
> - return __cpu_to_virtio64(vhost_has_feature(vq, VIRTIO_F_VERSION_1),
> val);
> + return __cpu_to_virtio64(vhost_is_little_endian(vq), val);
> }
> #endif
Reviewed-by: Thomas Huth
--
To unsubs
On Thu, 23 Apr 2015 17:29:06 +0200
Greg Kurz wrote:
> The current memory accessors logic is:
> - little endian if little_endian
> - native endian (i.e. no byteswap) if !little_endian
>
> If we want to fully support cross-endian vhost, we also need to be
> able to convert to big endian.
>
> Inst
Am Tue, 21 Apr 2015 10:41:51 +1000
schrieb David Gibson :
> On POWER, storage caching is usually configured via the MMU - attributes
> such as cache-inhibited are stored in the TLB and the hashed page table.
>
> This makes correctly performing cache inhibited IO accesses awkward when
> the MMU is
Am Tue, 21 Apr 2015 16:51:21 +1000
schrieb David Gibson :
> On Tue, Apr 21, 2015 at 08:37:02AM +0200, Thomas Huth wrote:
> > Am Tue, 21 Apr 2015 10:41:51 +1000
> > schrieb David Gibson :
> >
> > > On POWER, storage caching is usually configured via the MMU -
On 08/04/2019 09.09, David Hildenbrand wrote:
> On 07.04.19 14:55, Thomas Huth wrote:
>> If CONFIG_PGSTE is not set (e.g. when compiling without KVM), GCC complains:
>>
>> CC arch/s390/mm/pgtable.o
>> arch/s390/mm/pgtable.c:413:15: warning: ‘pmd_alloc_map’ defined
hile (READ_ONCE(vcpu_last_completed_iteration[vcpu_id])
+ != iteration)
+ ;
}
ts_diff = timespec_elapsed(start);
Reviewed-by: Thomas Huth
On 12/01/2021 22.42, Ben Gardon wrote:
In order to add an iteration -1 to indicate that the memory population
phase has not yet completed, convert the interations counters to ints.
No functional change intended.
Reviewed-by: Jacob Xu
Signed-off-by: Ben Gardon
---
.../selftests/kvm/dirty_lo
On 05/11/2020 09.18, Chenyi Qiang wrote:
This unit-test is intended to test the KVM support for Protection Keys
for Supervisor Pages (PKS). If CR4.PKS is set in long mode, supervisor
pkeys are checked in addition to normal paging protections and Access or
Write can be disabled via a MSR update wi
_kvm_s390_real_to_abs(u32 prefix, unsigned long
gra)
Just a matter of taste, but maybe this could be named differently?
kvm_s390_real2abs_prefix() ? kvm_s390_prefix_real_to_abs()?
Anyway:
Reviewed-by: Thomas Huth
On Thu, 2 Jul 2015 11:32:52 +0200
"Michael S. Tsirkin" wrote:
> On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote:
> > On Thu, 2 Jul 2015 08:01:28 +0200
> > "Michael S. Tsirkin" wrote:
...
> > > Yea, well - support for legacy BE guests on the new LE hosts is
> > > exactly the motivation
The option for supporting cross-endianness legacy guests in
the vhost and tun code should only be available on systems
that support cross-endian guests.
Signed-off-by: Thomas Huth
---
arch/arm/kvm/Kconfig | 1 +
arch/arm64/kvm/Kconfig | 1 +
arch/powerpc/kvm/Kconfig | 1 +
drivers/net
On Thu, 9 Jul 2015 16:07:47 +0300
"Michael S. Tsirkin" wrote:
> On Thu, Jul 09, 2015 at 02:57:33PM +0200, Paolo Bonzini wrote:
> >
> >
> > On 09/07/2015 11:48, Laurent Vivier wrote:
> > >
> > >
> > > On 09/07/2015 09:49, Thomas Hut
On 21.04.2016 11:25, Thomas Huth wrote:
> On 15.03.2016 21:18, Laurent Vivier wrote:
>> While writing some instruction tests for kvm-unit-tests for powerpc,
>> I've found that illegal instructions are not managed correctly with kvm-pr,
>> while it is fine with kvm
; 1 file changed, 14 insertions(+), 5 deletions(-)
By the way, same is true for device UNplugging: When unplugging devices
in QEMU while the firmware is still running, they are never properly
removed from the guest. I've checked it, and your patch fixes this
problem as well! Great :-)
Tested-by: Thomas Huth
On 17.05.2016 19:49, Laurent Vivier wrote:
>
>
> On 17/05/2016 10:37, Alexander Graf wrote:
>> On 05/17/2016 10:35 AM, Laurent Vivier wrote:
>>>
>>> On 12/05/2016 16:23, Laurent Vivier wrote:
On 12/05/2016 11:27, Alexander Graf wrote:
> On 05/12/2016 11:10 AM, Laurent Vivier wrote:
On 18.05.2016 12:18, Thomas Huth wrote:
> On 17.05.2016 19:49, Laurent Vivier wrote:
>>
>>
>> On 17/05/2016 10:37, Alexander Graf wrote:
>>> On 05/17/2016 10:35 AM, Laurent Vivier wrote:
>>>>
>>>> On 12/05/2016 16:23, Laurent Vivier wrote:
On 18.05.2016 12:53, Thomas Huth wrote:
> On 18.05.2016 12:18, Thomas Huth wrote:
>> On 17.05.2016 19:49, Laurent Vivier wrote:
>>>
>>>
>>> On 17/05/2016 10:37, Alexander Graf wrote:
>>>> On 05/17/2016 10:35 AM, Laurent Vivier wrote:
>&
>
> - bits = min_t(unsigned, feature_len,
> - sizeof(vdev->features)) * 8;
> + bits = min_t(unsigned, feature_len, sizeof(features)) * 8;
> for (i = 0; i < bits; i++)
> if (ioread8(&in_features[i / 8]) & (BIT(i % 8)))
>
need to re-setup the ccw, but we do it
> for clarity.
>
> Based on patches by Rusty, Thomas Huth and Cornelia.
>
> Signed-off-by: Rusty Russell
> Signed-off-by: Cornelia Huck
> Signed-off-by: Michael S. Tsirkin
> Reviewed-by: David Hildebrand
> ---
> drivers/s
On Thu, 14 May 2015 13:53:57 +1000
Alexey Kardashevskiy wrote:
> On 05/14/2015 01:00 AM, Thomas Huth wrote:
> > On Tue, 12 May 2015 01:39:12 +1000
> > Alexey Kardashevskiy wrote:
...
> >> -/*
> >> - * hwaddr is a kernel virtual address here (0xc... bazillion),
On Wed, 13 May 2015 16:30:16 +1000
Alexey Kardashevskiy wrote:
> On 05/13/2015 03:33 PM, Gavin Shan wrote:
> > On Tue, May 12, 2015 at 01:38:54AM +1000, Alexey Kardashevskiy wrote:
> >> At the moment iommu_free_table() only releases memory if
> >> the table was initialized for the platform code u
On Tue, 12 May 2015 01:39:12 +1000
Alexey Kardashevskiy wrote:
> At the moment writing new TCE value to the IOMMU table fails with EBUSY
> if there is a valid entry already. However PAPR specification allows
> the guest to write new TCE value without clearing it first.
>
> Another problem this p
ort
> > http://article.gmane.org/gmane.linux.kernel.virtualization/24846
> > for a fuller explanation.
> >
> > To fix, rewrite using wait_woken.
> >
> > Cc: sta...@vger.kernel.org
> > Reported-by: Thomas Huth
> > Signed-off-by: Michael S. T
> kvmppc_set_gpr(vcpu, 3, EV_UNIMPLEMENTED);
> kvmppc_set_pc(vcpu, kvmppc_get_pc(vcpu) + 4);
> emulated = EMULATE_DONE;
> + } else {
> + kvmppc_core_queue_program(vcpu, SRR1_PROGILL);
> + emulated = EMULATE_AGAIN;
> }
> break;
> case 19:
>
Tested-by: Thomas Huth
On 22.03.2016 15:53, Laurent Vivier wrote:
> Until now, when we connect gdb to the QEMU gdb-server, the
> single-step mode is not managed.
>
> This patch adds this, only for kvm-pr:
>
> If KVM_GUESTDBG_SINGLESTEP is set, we enable single-step trace bit in the
> MSR (MSR_SE) just before the __kvmp
On 08.04.2016 08:58, Laurent Vivier wrote:
>
>
> On 08/04/2016 08:23, Thomas Huth wrote:
>> On 22.03.2016 15:53, Laurent Vivier wrote:
>>> Until now, when we connect gdb to the QEMU gdb-server, the
>>> single-step mode is not managed.
>>>
>>>
OK3S_INTERRUPT_TRACE
>
> arch/powerpc/kvm/book3s_pr.c | 32 +++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
Reviewed-by: Thomas Huth
The virtio_ring.h header is used in userspace programs (ie. QEMU),
too. Here we can not assume that sizeof(pointer) is the same as
sizeof(long), e.g. when compiling for Windows, so the typecast in
vring_init() should be done with (uintptr_t) instead of (unsigned long).
Signed-off-by: Thomas Huth
Check that we can write and read the guest memory with this s390x
ioctl, and that some error cases are handled correctly.
Signed-off-by: Thomas Huth
---
This test uses the ucall() interface, so this patch needs to be applied
on top of my "Implement ucall() for s390x" patch (which is
ng on a check somewhere deep down
the calling chain, so let's add another check to kvm_s390_guest_mem_op()
directly.
Signed-off-by: Thomas Huth
---
arch/s390/kvm/kvm-s390.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
On 29/08/2019 13.18, Cornelia Huck wrote:
[...]
>
> Btw: should Documentation/virt/kvm/api.txt spell out the valid range
> for ar explicitly?
>
That certainly would not hurt. Care to send a patch, or shall I assemble
one?
Thomas
On 29/08/2019 13.15, Janosch Frank wrote:
[...]
> By the way, I think we want to check mop->size for 0 before giving it to
> vmalloc and working with it.
You're right! This currently triggers a kernel warning message with a
Call Trace! I'll add a check to my new memop selftest and send a patch...
Check that we can write and read the guest memory with this s390x
ioctl, and that some error cases are handled correctly.
Signed-off-by: Thomas Huth
---
v2: Check the ioctl also with "size" set to 0
tools/testing/selftests/kvm/Makefile | 1 +
tools/testing/selftests/kvm/s39
and this will cause a kernel warning.
Signed-off-by: Thomas Huth
---
v2: Check mop->size to be non-zero
arch/s390/kvm/kvm-s390.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index f329dcb3f44c..49d779ae 100644
On 29/08/2019 14.21, Janosch Frank wrote:
> On 8/29/19 2:14 PM, Thomas Huth wrote:
>> Check that we can write and read the guest memory with this s390x
>> ioctl, and that some error cases are handled correctly.
>>
>> Signed-off-by: Thomas Huth
>> ---
>> v
n to for
> +KVM_S390_MEMOP_LOGICAL_READ, or where the data that should be written is
> +stored for a KVM_S390_MEMOP_LOGICAL_WRITE. When KVM_S390_MEMOP_F_CHECK_ONLY
> +is specified, "buf" is unused and can be NULL. "ar" designates the access
> +register number to be used; the valid range is 0..15.
>
> The "reserved" field is meant for future extensions. It is not used by
> KVM with the currently defined set of flags.
>
Reviewed-by: Thomas Huth
Check that we can write and read the guest memory with this s390x
ioctl, and that some error cases are handled correctly.
Signed-off-by: Thomas Huth
---
v3:
- Replaced wrong copy-n-pasted report string with a proper one
- Check for errno after calling the ioctl with size = 0
tools/testing
On 29/08/2019 15.26, Christian Borntraeger wrote:
>
>
> On 29.08.19 15:07, Thomas Huth wrote:
>> Check that we can write and read the guest memory with this s390x
>> ioctl, and that some error cases are handled correctly.
>>
>> Signed-off-by: Thomas Huth
>>
, too.
Signed-off-by: Thomas Huth
---
arch/s390/include/uapi/asm/kvm.h | 6
arch/s390/kvm/kvm-s390.c | 4 +++
.../selftests/kvm/s390x/sync_regs_test.c | 30 +++
3 files changed, 40 insertions(+)
diff --git a/arch/s390/include/uapi/asm/kvm.h b
Huck
Signed-off-by: Thomas Huth
---
.../selftests/kvm/s390x/sync_regs_test.c | 30 +++
1 file changed, 30 insertions(+)
diff --git a/tools/testing/selftests/kvm/s390x/sync_regs_test.c
b/tools/testing/selftests/kvm/s390x/sync_regs_test.c
index bbc93094519b..d5290b4ad636 100644
Avoid invalid bits in kvm_valid_regs and kvm_dirty_regs on s390x.
v2:
- Split the single patch from v1 into two separate patches
(I've kept the Reviewed-bys from v1, but if you don't agree with the
patch description of the 2nd patch, please complain)
Thomas Huth (2):
stian Borntraeger
Reviewed-by: Cornelia Huck
Signed-off-by: Thomas Huth
---
arch/s390/include/uapi/asm/kvm.h | 6 ++
arch/s390/kvm/kvm-s390.c | 4
2 files changed, 10 insertions(+)
diff --git a/arch/s390/include/uapi/asm/kvm.h b/arch/s390/include/uapi/asm/kvm.h
index 47104e5
On 04/09/2019 11.05, David Hildenbrand wrote:
> On 04.09.19 10:51, Thomas Huth wrote:
>> If unknown bits are set in kvm_valid_regs or kvm_dirty_regs, this
>> clearly indicates that something went wrong in the KVM userspace
>> application. The x86 variant of KVM already contai
On 04/09/2019 11.15, David Hildenbrand wrote:
> On 04.09.19 11:11, Christian Borntraeger wrote:
>>
>>
>> On 04.09.19 11:05, David Hildenbrand wrote:
>>> On 04.09.19 10:51, Thomas Huth wrote:
>>>> If unknown bits are set in kvm_valid_regs or kvm_di
The FSF does not reside in "675 Mass Ave, Cambridge" anymore...
let's simply use proper SPDX identifiers instead.
Signed-off-by: Thomas Huth
---
arch/powerpc/include/uapi/asm/spu_info.h | 14 --
arch/powerpc/kernel/eeh_driver.c | 18 +
On 26/08/2019 09.57, Peter Xu wrote:
> The dirty_log_test is failing on some old machines like Xeon E3-1220
> with tripple faults when writting to the tracked memory region:
>
> Test iterations: 32, interval: 10 (ms)
> Testing guest mode: PA-bits:52, VA-bits:48, 4K pages
> guest physical tes
After the kfree()s haven been removed in the previous
commit 9798f4ea71ea ("fix rollback when kvmppc_xive_create fails"),
the code can be simplified even more to simply always "return ret"
now.
Signed-off-by: Thomas Huth
---
arch/powerpc/kvm/book3s_xive.c| 5 +--
It's not required, so drop it to make it clear that this interrupt
does not have any extra parameters.
Signed-off-by: Thomas Huth
---
arch/s390/kvm/interrupt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
in s390int_to_s390irq(), too.
And while we're at it, make sure that s390int_to_s390irq() now
directly returns -EINVAL for unknown interrupt types, so that we
do not run into this problem again in case we add more interrupt
types to do_inject_vcpu() sometime in the future.
Signed-off-by: Thomas
On 12/09/2019 11.14, David Hildenbrand wrote:
> On 12.09.19 11:00, Thomas Huth wrote:
>> When the userspace program runs the KVM_S390_INTERRUPT ioctl to inject
>> an interrupt, we convert them from the legacy struct kvm_s390_interrupt
>> to the new struct kvm_s390_irq via t
On 12/09/2019 12.47, Christian Borntraeger wrote:
>
>
> On 12.09.19 11:00, Thomas Huth wrote:
>> When the userspace program runs the KVM_S390_INTERRUPT ioctl to inject
>> an interrupt, we convert them from the legacy struct kvm_s390_interrupt
>> to the new
On 12/09/2019 12.52, Christian Borntraeger wrote:
>
>
> On 12.09.19 11:20, Thomas Huth wrote:
>> On 12/09/2019 11.14, David Hildenbrand wrote:
>>> On 12.09.19 11:00, Thomas Huth wrote:
>>>> When the userspace program runs the KVM_S390_INTERRUPT ioctl to injec
ypes, so that we
immediately get a proper error code in case we add more interrupt
types to do_inject_vcpu() without updating s390int_to_s390irq()
sometime in the future.
Cc: sta...@vger.kernel.org
Reviewed-by: David Hildenbrand
Reviewed-by: Christian Borntraeger
Signed-off-by: Thomas Huth
---
a
On 13/09/2019 09.20, Cornelia Huck wrote:
> On Thu, 12 Sep 2019 13:23:38 +0200
> Thomas Huth wrote:
>
>> Hmm, we already talked about deprecating support for pre-3.15 kernel
>> stuff in the past (see
>> https://wiki.qemu.org/ChangeLog/2.12#Future_incompatible_change
On 13/09/2019 09.37, David Hildenbrand wrote:
> On 13.09.19 09:34, Thomas Huth wrote:
>> On 13/09/2019 09.20, Cornelia Huck wrote:
>>> On Thu, 12 Sep 2019 13:23:38 +0200
>>> Thomas Huth wrote:
>>>
>>>> Hmm, we already talked about deprecating su
On 18/09/2019 22.54, Greg Kurz wrote:
> On Wed, 18 Sep 2019 18:44:36 +0200
> Greg Kurz wrote:
>
>> On Wed, 11 Sep 2019 21:52:35 +0200
>> Thomas Huth wrote:
>>
>>> After the kfree()s haven been removed in the previous
>>> commit 9798f4ea71ea
the vCPUs.
Signed-off-by: Thomas Huth
---
RFC since the stubs are a little bit ugly (does someone here like
to implement them?), and since it's a little bit annoying that
you have to raise the ulimit for this test in case the kernel provides
more vCPUs than the default ulimit...
tools/te
When reading the "See below" here, I'd expect to find some further
description of "Odd Fixes" a little bit later in the file. However,
as far as I can see, there is no further description available. Thus
let's simply remove these deceptive two words.
Signed-off-by: T
struct kvm_nested_state is only available on x86 so far. To be able
to compile the code on other architectures as well, we need to wrap
the related code with #ifdefs.
Signed-off-by: Thomas Huth
---
tools/testing/selftests/kvm/include/kvm_util.h | 2 ++
tools/testing/selftests/kvm/lib/kvm_util.c
On 23/05/2019 12.56, Andrew Jones wrote:
> On Thu, May 16, 2019 at 01:12:53PM +0200, Thomas Huth wrote:
>> The test is an adaption of the same test for x86. Note that there
>> are some differences in the way how s390x deals with the kvm_valid_regs
>> in struct kvm_run, so som
On 22/05/2019 20.19, Aaro Koskinen wrote:
> Hi,
>
> On Wed, May 22, 2019 at 11:33:41AM +0200, Corentin Labbe wrote:
>> qemu-system-arm -M help |grep OMAP
>> cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310)
>> n800 Nokia N800 tablet aka. RX-34 (OMAP2420)
>> n810
rew Jones (1):
kvm: selftests: aarch64: fix default vm mode
Thomas Huth (8):
KVM: selftests: Wrap vcpu_nested_state_get/set functions with x86
guard
KVM: selftests: Guard struct kvm_vcpu_events with
__KVM_HAVE_VCPU_EVENTS
KVM: selftests: Introduce a VM_MODE_DEFAULT macro for the defa
struct kvm_nested_state is only available on x86 so far. To be able
to compile the code on other architectures as well, we need to wrap
the related code with #ifdefs.
Reviewed-by: Andrew Jones
Signed-off-by: Thomas Huth
---
tools/testing/selftests/kvm/include/kvm_util.h | 2 ++
tools/testing
The struct kvm_vcpu_events code is only available on certain architectures
(arm, arm64 and x86). To be able to compile kvm_util.c also for other
architectures, we have to fence the code with __KVM_HAVE_VCPU_EVENTS.
Reviewed-by: David Hildenbrand
Signed-off-by: Thomas Huth
---
tools/testing
7;s good to get it fixed in advance.)
Reported-by: Thomas Huth
Signed-off-by: Andrew Jones
---
tools/testing/selftests/kvm/lib/aarch64/processor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kvm/lib/aarch64/processor.c
b/tools/testing/selftests/
This will be required later for tests like the kvm_create_max_vcpus
test that do not use the vm_create_default() function.
Signed-off-by: Thomas Huth
---
tools/testing/selftests/kvm/include/kvm_util.h | 6 ++
tools/testing/selftests/kvm/lib/aarch64/processor.c | 2 +-
tools/testing
Code that takes care of basic CPU setup, page table walking, etc.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 +
tools/testing/selftests/kvm/Makefile | 1 +
.../selftests/kvm/include/s390x/processor.h | 22 ++
.../selftests/kvm/lib/s390x
On s390x, there is a constraint that memory regions have to be aligned
to 1M (or running the VM will fail). Introduce a new "alignment" variable
in the vm_userspace_mem_region_add() function which now can be used for
both, huge page and s390x alignment requirements.
Signed-off-by: T
-off-by: Thomas Huth
---
arch/mips/kvm/mips.c | 3 +++
arch/powerpc/kvm/powerpc.c | 3 +++
arch/s390/kvm/kvm-s390.c | 1 +
arch/x86/kvm/x86.c | 3 +++
virt/kvm/arm/arm.c | 3 +++
virt/kvm/kvm_main.c| 2 --
6 files changed, 13 insertions(+), 2 deletions(-)
diff --git
usable on s390x), so it simply drops out of the VM with
a diag 0x501 breakpoint instead.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 +
tools/testing/selftests/kvm/Makefile | 2 +
.../selftests/kvm/s390x/sync_regs_test.c | 151
There is nothing x86-specific in the test apart from the VM_MODE_P52V48_4K
which we can now replace with VM_MODE_DEFAULT. Thus let's move the file to
the main folder and enable it for aarch64 and s390x, too.
Signed-off-by: Thomas Huth
---
tools/testing/selftests/kvm/Mak
On 20/05/2019 09.12, Christian Borntraeger wrote:
>
> On 16.05.19 13:12, Thomas Huth wrote:
>> The struct kvm_vcpu_events code is only available on certain architectures
>> (arm, arm64 and x86). To be able to compile kvm_util.c also for other
>> architectures, we'
The check for entry->index == 0 is done twice. One time should
be sufficient.
Suggested-by: Vitaly Kuznetsov
Signed-off-by: Thomas Huth
---
Vitaly already noticed this in his review to the "Fix a condition
in test_hv_cpuid()" patch a couple of days ago, but so far I haven'
On 20/05/2019 13.20, Paolo Bonzini wrote:
> On 16/05/19 13:12, Thomas Huth wrote:
>> This patch series enables the KVM selftests for s390x. As a first
>> test, the sync_regs from x86 has been adapted to s390x.
>>
>> Please note that the ucall() interface is not used y
@@ -75,7 +75,7 @@ void set_revision_id_for_vmcs12(struct kvm_nested_state
> *state,
> u32 vmcs12_revision)
> {
> /* Set revision_id in vmcs12 to vmcs12_revision. */
> - *(u32 *)(state->data) = vmcs12_revision;
> + memcpy(state->data, &vmcs12_revision, sizeof(u32));
> }
>
> void set_default_state(struct kvm_nested_state *state)
>
Reviewed-by: Thomas Huth
On 24/05/2019 10.29, Christian Borntraeger wrote:
>
>
> On 23.05.19 19:40, Andrew Jones wrote:
>> On Thu, May 23, 2019 at 06:43:05PM +0200, Thomas Huth wrote:
>>> On s390x, there is a constraint that memory regions have to be aligned
>>> to 1M (or running t
On 24/05/2019 20.59, Aaro Koskinen wrote:
> Hi,
>
> On Fri, May 24, 2019 at 06:00:18PM +0300, Aaro Koskinen wrote:
>> Please don't delete OMAP boards quite yet :) In the mainline kernel
>> they are not orphaned, they frequently get tested using actual hardware,
>> and QEMU would help in additional
We already provide the LGPL-2.0 text in LICENSES/preferred/LGPL-2.0,
so there is no need for this additional copy here.
Signed-off-by: Thomas Huth
---
arch/sparc/lib/COPYING.LIB | 481 -
1 file changed, 481 deletions(-)
delete mode 100644 arch/sparc/lib
)
^
Wrap the function with "#ifdef CONFIG_PGSTE" to silence the warning.
Signed-off-by: Thomas Huth
---
arch/s390/mm/pgtable.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/s390/mm/pgtable.c b/arch/s390/mm/pgtable.c
index 8485d6dc2754..9ebd01219812 100644
--- a/ar
The blackfin architecture has been removed a while ago, so there is
no more need to declare uclinux_ram_map as a global structure.
Signed-off-by: Thomas Huth
---
drivers/mtd/maps/uclinux.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/mtd/maps/uclinux.c b
On 31/07/2019 12.28, Andrew Jones wrote:
> On Wed, Jul 31, 2019 at 11:43:16AM +0200, Thomas Huth wrote:
>> On 30/07/2019 12.48, Andrew Jones wrote:
>>> On Tue, Jul 30, 2019 at 12:01:11PM +0200, Thomas Huth wrote:
>>>> On s390x, we can neither exit via PIO nor
area.
0xc000 seems to be a good alternative that should work on x86
and aarch64, too.
Acked-by: Paolo Bonzini
Signed-off-by: Thomas Huth
---
tools/testing/selftests/kvm/Makefile | 1 +
tools/testing/selftests/kvm/dirty_log_test.c | 59 +---
2 files changed, 53
de in ucall.c currently looks more complex than
required. Let's split this up into architecture specific ucall.c
files instead, so we can get rid of the #ifdefs and the unnecessary
ucall_type_t handling.
Signed-off-by: Thomas Huth
---
tools/testing/selftests/kvm/Makefile | 6 +-
too
On s390x, we can neither exit via PIO nor MMIO, but have to use an
instruction like DIAGNOSE. Now that ucall() is implemented, we can
use it in the sync_reg_test on s390x, too.
Signed-off-by: Thomas Huth
---
tools/testing/selftests/kvm/Makefile | 2 +-
tools/testing/selftests/kvm/lib
Implement the ucall() interface on s390x to be able to use the
dirty_log_test KVM selftest on s390x, too.
v2:
- Split up ucall.c into architecture specific files
- Removed some #ifdef __s390x__ in the dirty_log patch
Thomas Huth (3):
KVM: selftests: Split ucall.c into architecture specific
On 31/07/2019 15.32, Thomas Huth wrote:
> Implement the ucall() interface on s390x to be able to use the
> dirty_log_test KVM selftest on s390x, too.
>
> v2:
> - Split up ucall.c into architecture specific files
> - Removed some #ifdef __s390x__ in the dirty_log patch
&
1 - 100 of 153 matches
Mail list logo
