Re: [PATCH] net/ipv6: lower the level of "link is not ready" messages

2019-01-21 Thread Thomas Haller
rt, not when it > does > not. Let's lower its level. > > Signed-off-by: Lubomir Rintel Hi, a NetworkManager maintainer here. Acked-By: Thomas Haller > --- > net/ipv6/addrconf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net

Re: [PATCH net-next v2 3/3] netlink: add validation of NLA_F_NESTED flag

2019-07-23 Thread Thomas Haller
On Thu, 2019-05-02 at 16:15 +0200, Michal Kubecek wrote: > Add new validation flag NL_VALIDATE_NESTED which adds three > consistency > checks of NLA_F_NESTED_FLAG: > > - the flag is set on attributes with NLA_NESTED{,_ARRAY} policy > - the flag is not set on attributes with other policies exce

Re: [PATCH net-next v2 3/3] netlink: add validation of NLA_F_NESTED flag

2019-07-23 Thread Thomas Haller
On Tue, 2019-07-23 at 11:09 +0200, Michal Kubecek wrote: > On Tue, Jul 23, 2019 at 10:57:54AM +0200, Thomas Haller wrote: > > Does this flag and strict validation really provide any value? > > Commonly a netlink message is a plain TLV blob, and the meaning > > depends e