Re: [PATCH V2 3/5] arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay" for crypto

2020-11-12 Thread Tero Kristo
b366b2409c97 ("arm64: dts: ti: k3-am6: Add crypto accelarator node") Signed-off-by: Nishanth Menon Cc: Keerthy Acked-by: Tero Kristo --- Changes since V1: - No change. V1: https://lore.kernel.org/linux-arm-kernel/20201104224356.18040-4...@ti.com/ arch/arm64/boot/dts/ti/k3-am65-m

Re: [PATCH] soc: ti/ti_sci_protocol.h: drop a duplicated word + clarify

2020-07-20 Thread Tero Kristo
On 19/07/2020 03:31, Randy Dunlap wrote: Drop the repeated word "an" in a comment. Insert "and" between "source" and "destination" as is done a few lines earlier. Signed-off-by: Randy Dunlap Cc: Nishanth Menon Cc: Tero Kristo Cc: Santosh Shilimkar

Re: [PATCH] firmware: ti_sci: Replace HTTP links with HTTPS ones

2020-07-20 Thread Tero Kristo
Hi Alexander, One comment below. On 18/07/2020 13:55, Alexander A. Klimov wrote: Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If does

Re: [PATCH] EDAC-TI: Replace HTTP links with HTTPS ones

2020-07-13 Thread Tero Kristo
limov Looks fine to me. Acked-by: Tero Kristo --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master (Actually letting a shell for loop submit all this stuff for me.) If there are any URLs to be removed c

Re: [PATCH] Replace HTTP links with HTTPS ones: TI KEYSTONE MULTICORE NAVIGATOR DRIVERS

2020-07-17 Thread Tero Kristo
limov Acked-by: Tero Kristo Santosh, are you going to pick this up? -Tero --- Continuing my work started at 93431e0607e5. See also: git log --oneline '--author=Alexander A. Klimov ' v5.7..master (Actually letting a shell for loop submit all this stuff for me.) If there are

Re: [PATCH v2 0/2] arm64: dts: ti: k3-j721e-common-proc-board: Enable audio support

2020-07-17 Thread Tero Kristo
On 03/07/2020 10:44, Peter Ujfalusi wrote: Hi, Change since v1: - not including dt-bindings/sound/ti-mcasp.h as it is not needed the DT binding document and the driver is now in linux-next: https://lore.kernel.org/lkml/159364215574.10630.2058528286314798186.b4...@kernel.org/ Before adding the

Re: [PATCH 0/2] Add support for SD card on on AM65x-evm

2020-07-17 Thread Tero Kristo
On 10/07/2020 22:02, Faiz Abbas wrote: The following patches add support for SD card node in am654x-evm Because of fundamental interface issues (see patch 2 for details), SD card was never enabled for silicon revision 1.0 These issues have been fixed with SR2.0 but boards with SR1.0 are recomme

Re: [PATCH] arm64: dts: ti: k3-*: Replace HTTP links with HTTPS ones

2020-07-17 Thread Tero Kristo
On 13/07/2020 13:14, Alexander A. Klimov wrote: Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: F

Re: [PATCH 3/3] arm64: dts: ti: k3-j721e-main: rename smmu node to iommu

2020-07-17 Thread Tero Kristo
On 26/06/2020 21:40, Suman Anna wrote: On 6/26/20 1:36 PM, Grygorii Strashko wrote: On 26/06/2020 21:35, Grygorii Strashko wrote: Rename smmu node to iommu to fix dtbs_check warning:   k3-j721e-common-proc-board.dt.yaml: smmu@3660: $nodename:0: 'smmu@3660' does not match '^iommu@[0-9

Re: [PATCH] arm64: dts: ti: k3-am65/j721e-main: rename gic-its node to msi-controller

2020-07-17 Thread Tero Kristo
On 26/06/2020 21:34, Grygorii Strashko wrote: The preferable name for gic-its is msi-controller, so rename it to fix dtbs_check warning: k3-j721e-common-proc-board.dt.yaml: interrupt-controller@180: gic-its@182: False schema does not allow {'compatible': ['arm,gic-v3-its'], 'reg': [[0, 2

Re: [PATCH v4 0/6] arm64: ti: k3-j721e: Add SERDES PHY and USB3.0 support

2020-07-17 Thread Tero Kristo
On 29/06/2020 15:52, Roger Quadros wrote: Hi Tero, This series adds SERDES PHY support and Type-C USB Super-Speed support to the J721E EVM. Please queue this for -next. Thanks. Queued up for 5.9, thanks. -Tero cheers, -roger Changelog: v4: - Removed redundant patch - used compaible strin

Re: [PATCH 7/7] arm64: defconfig: Enable AM654x SDHCI controller

2020-07-17 Thread Tero Kristo
On 17/07/2020 11:38, Faiz Abbas wrote: Hi, On 16/07/20 11:58 pm, Arnd Bergmann wrote: On Thu, Jul 16, 2020 at 3:25 PM Sekhar Nori wrote: On 7/16/20 5:49 PM, Faiz Abbas wrote: Hi, On 19/06/20 6:28 pm, Faiz Abbas wrote: Enable CONFIG_SDHCI_AM654 to Support AM65x sdhci controller. Signed-of

[PATCHv4 2/4] watchdog: add support for adjusting last known HW keepalive time

2020-07-17 Thread Tero Kristo
timer, so add a new driver API for this purpose. Signed-off-by: Tero Kristo --- .../watchdog/watchdog-kernel-api.rst | 12 drivers/watchdog/watchdog_dev.c | 30 +++ include/linux/watchdog.h | 2 ++ 3 files changed, 44

[PATCHv4 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-17 Thread Tero Kristo
If the RTI watchdog is running already during probe, the driver must configure itself to match the HW. Window size and timeout is probed from hardware, and the last keepalive ping is adjusted to match it also. Signed-off-by: Tero Kristo --- drivers/watchdog/rti_wdt.c | 112

[PATCHv4 4/4] watchdog: rti-wdt: balance pm runtime enable calls

2020-07-17 Thread Tero Kristo
PM runtime should be disabled in the fail path of probe and when the driver is removed. Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support") Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck --- drivers/watchdog/rti_wdt.c | 2 ++ 1 file changed, 2 insertions(+) di

[PATCHv4 1/4] watchdog: use __watchdog_ping in startup

2020-07-17 Thread Tero Kristo
__watchdog_ping handle the bookkeeping for the worker and last keepalive times. Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck --- drivers/watchdog/watchdog_dev.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/watchdog/watchdog_dev.c b

[PATCHv4 0/4] watchdog: rti-wdt: attach to running timer

2020-07-17 Thread Tero Kristo
Hi, V4 of this series only fixes 32bit compile issue with patch #3. Appears to be compiling now fine with ARM32 allmodconfig. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCH 7/7] arm64: defconfig: Enable AM654x SDHCI controller

2020-07-17 Thread Tero Kristo
On 17/07/2020 16:09, Arnd Bergmann wrote: On Fri, Jul 17, 2020 at 1:20 PM Tero Kristo wrote: On 17/07/2020 11:38, Faiz Abbas wrote: On 16/07/20 11:58 pm, Arnd Bergmann wrote: On Thu, Jul 16, 2020 at 3:25 PM Sekhar Nori wrote: I tend to ignore individual patches to the defconfig file unless

Re: [PATCH] arm64: arch_k3: enable chipid driver

2020-07-17 Thread Tero Kristo
On 15/07/2020 13:03, Grygorii Strashko wrote: Hi All, On 07/07/2020 10:02, Peter Ujfalusi wrote: On 01/07/2020 13.18, Grygorii Strashko wrote: On 19/06/2020 19:25, Grygorii Strashko wrote: Select TI chip id driver for TI's SoCs based on K3 architecture to provide this information to user spac

Re: [PATCH 2/2] watchdog: rti: tweak min_hw_heartbeat_ms to match initial allowed window

2020-06-30 Thread Tero Kristo
On 30/06/2020 23:23, Guenter Roeck wrote: On Thu, Jun 25, 2020 at 08:04:50PM +0300, Tero Kristo wrote: On 25/06/2020 16:35, Guenter Roeck wrote: On 6/25/20 1:32 AM, Tero Kristo wrote: On 24/06/2020 18:24, Jan Kiszka wrote: On 24.06.20 13:45, Tero Kristo wrote: If the RTI watchdog has been

Re: [PATCH 2/2] watchdog: rti: tweak min_hw_heartbeat_ms to match initial allowed window

2020-07-01 Thread Tero Kristo
On 01/07/2020 16:34, Guenter Roeck wrote: On 6/30/20 10:50 PM, Tero Kristo wrote: [ ... ] Hardware supports changing the timeout value, however it only updates this during the next window (preload values are picked once user pings the watchdog.) The current driver doesn't support o

Re: [PATCH] arm64: arch_k3: Fix kconfig dependency warning

2019-06-04 Thread Tero Kristo
Sorry, this has sort of slipped through. I can pick this up and queue towards 5.2-rc fixes. -Tero On 04/06/2019 11:33, Yuehaibing wrote: Hi all, Friendly ping: Who can take this? On 2019/5/10 11:52, YueHaibing wrote: Fix Kbuild warning when SOC_TI is not set WARNING: unmet direct dependen

Re: [PATCH v6 06/12] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2019-04-12 Thread Tero Kristo
On 12/04/2019 07:24, Lokesh Vutla wrote: On 11/04/19 8:30 PM, Tony Lindgren wrote: Hi, * Lokesh Vutla [190410 04:15]: +Example: + +The following example demonstrates both interrupt router node and the consumer +node(main gpio) on the AM654 SoC: + +main_intr: interrupt-controller0 {

Re: [PATCH] crypto: sa2ul: fix odd_ptr_err.cocci warnings

2020-06-18 Thread Tero Kristo
On 18/06/2020 10:28, Herbert Xu wrote: On Fri, Jun 12, 2020 at 11:22:02PM +0200, Julia Lawall wrote: From: kernel test robot PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 5b8516f3bedb ("crypto: sa2ul: Add crypto

Re: [PATCH v2 2/2] soc: ti: add k3 platforms chipid module driver

2020-05-07 Thread Tero Kristo
On 05/05/2020 22:34, Grygorii Strashko wrote: The Texas Instruments K3 Multicore SoC platforms have chipid module which is represented by CTRLMMR_xxx_JTAGID register and contains information about SoC id and revision. Bits: 31-28 VARIANT Device variant 27-12 PARTNO Part number 11-1 M

Re: [PATCH v2 0/2] soc: ti: add k3 platforms chipid module driver

2020-05-07 Thread Tero Kristo
a minor comments on patch #2, other than that looks fine to me. Once that is fixed, for whole series: Reviewed-by: Tero Kristo -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCHv4 1/4] dt-bindings: watchdog: Add support for TI K3 RTI watchdog

2020-06-21 Thread Tero Kristo
On 18/06/2020 19:09, Jan Kiszka wrote: On 12.03.20 10:58, Tero Kristo wrote: TI K3 SoCs contain an RTI (Real Time Interrupt) module which can be used to implement a windowed watchdog functionality. Windowed watchdog will generate an error if it is petted outside the time window, either too

Re: [PATCH 0/2] arm64: dts: ti: k3: add platforms chipid module nodes

2020-06-22 Thread Tero Kristo
On 19/06/2020 19:26, Grygorii Strashko wrote: On 15/06/2020 10:47, Peter Ujfalusi wrote: Hi Grygorii, On 13/06/2020 19.43, Grygorii Strashko wrote: Hi Tero, Hence k3 platforms chipid module driver was merged, there is follow up series to add corresponding DT chipid nodes. [1] https://lkm

Re: [PATCH v3] arm64: dts: ti: k3-am654-main: Update otap-del-sel values

2020-06-22 Thread Tero Kristo
On 19/05/2020 11:20, Faiz Abbas wrote: According to the latest AM65x Data Manual[1], a different output tap delay value is optimum for a given speed mode. Update these values. [1] http://www.ti.com/lit/gpn/am6526 Signed-off-by: Faiz Abbas Queued up for 5.9, thanks. -Tero --- v3: Updated v

[PATCH 1/2] watchdog: use __watchdog_ping in startup

2020-06-24 Thread Tero Kristo
__watchdog_ping handle the bookkeeping for the worker and last keepalive times. Signed-off-by: Tero Kristo --- drivers/watchdog/watchdog_dev.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c

[PATCH 0/2] watchdog: rti: adjust initial ping for attach

2020-06-24 Thread Tero Kristo
Hi, This series fixes attaching the RTI watchdog driver to an already running timer; it can be started by boot loader for example. In this case, we must read the current remaining timeout, and adjust the min_hw_heartbeat based on that so that we don't attempt to either pet the watchdog too early,

[PATCH 2/2] watchdog: rti: tweak min_hw_heartbeat_ms to match initial allowed window

2020-06-24 Thread Tero Kristo
If the RTI watchdog has been started by someone (like bootloader) when the driver probes, we must adjust the initial ping timeout to match the currently running watchdog window to avoid generating watchdog reset. Signed-off-by: Tero Kristo --- drivers/watchdog/rti_wdt.c | 25

Re: [PATCH] clk: Add functions to save and restore clock/dpll context en-masse

2017-04-18 Thread Tero Kristo
On 18/04/17 08:12, Keerthy wrote: From: Russ Dill The clock/dpll registers are in the WKUP power domain. Under both RTC-only suspend and hibernation, these registers are lost. Hence save/restore them accordingly. Signed-off-by: Russ Dill Signed-off-by: Keerthy I think the core support shou

Re: [PATCH] clk: ti: fix linker error with !SOC_OMAP4

2017-04-20 Thread Tero Kristo
e is masked in the testing I did locally so far. Fixes: 0565fb168d63 ("clk: ti: dpll: move omap3 DPLL functionality to clock driver") However, I believe the fixes tag should point to this one in linux-next: commit 473adbf4e02857a6b78dfb3d9fcf752638bbadb9 Author: Tero Kristo Dat

Re: [PATCH] clk: ti: fix linker error with !SOC_OMAP4

2017-04-20 Thread Tero Kristo
On 20/04/17 18:06, Arnd Bergmann wrote: On Thu, Apr 20, 2017 at 4:57 PM, Tero Kristo wrote: On 20/04/17 00:43, Arnd Bergmann wrote: When none of the OMAP4-generation SoCs are enabled, we run into a link error for am43xx/am43xx: drivers/clk/ti/dpll.o: In function `of_ti_am3_dpll_x2_setup

Re: [PATCH 2/2] clk: ti: fix building without legacy omap3

2017-04-20 Thread Tero Kristo
f-by: Arnd Bergmann This one is clear... I think I should start running the single SoC build testing script again before posting stuff, this is an area where I seem to fail repeatedly... sorry about that. Acked-by: Tero Kristo --- drivers/clk/ti/clk.c | 12 ++-- 1 file change

Re: [PATCH 1/2] clk: ti: divider: try to fix ti_clk_register_divider

2017-04-20 Thread Tero Kristo
the address from div->reg.ptr instead. Actually, I believe the code you are fixing works before this commit: commit 6c0afb503937a12a8d20a805fcf263e31afa9871 Author: Tero Kristo Date: Thu Feb 9 11:24:37 2017 +0200 clk: ti: convert to use proper register definition for all accesses ..

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-12 Thread Tero Kristo
On 12/04/17 20:24, Eduardo Valentin wrote: On Wed, Apr 12, 2017 at 10:41:00PM +0530, Keerthy wrote: On Wednesday 12 April 2017 10:38 PM, Grygorii Strashko wrote: On 04/12/2017 11:44 AM, Keerthy wrote: On Wednesday 12 April 2017 10:01 PM, Grygorii Strashko wrote: On 04/12/2017 10:44 AM

[PATCH] clk: keystone: sci-clk: add support for dynamically probing clocks

2018-02-13 Thread Tero Kristo
messages during boot, basically one extra for each device that exists on the SoC; on K2G this is approx 80. Signed-off-by: Tero Kristo --- drivers/clk/keystone/sci-clk.c | 380 ++--- 1 file changed, 90 insertions(+), 290 deletions(-) diff --git a/drivers/clk

Re: [PATCH] clk: ti: make clk_ops const

2017-08-23 Thread Tero Kristo
Looks fine. Acked-by: Tero Kristo --- drivers/clk/ti/adpll.c | 2 +- drivers/clk/ti/apll.c | 2 +- drivers/clk/ti/fapll.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c index 255cafb..d5c6db4 100644 --- a/drivers/clk

Re: [PATCH] clk: ti: dra7xx: Reset the mcasp3_ahclkx_mux clock value

2017-09-06 Thread Tero Kristo
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 06/09/17 13:36, Keerthy wrote: Reset the mcasp3_ahclkx_mux to abe_24m_fclk. This is needed in case of kexec where the reset values might be wiped off. Signed-off-

Re: [PATCH 1/3] ARM: dts: omap4: add missing des_fck

2017-06-12 Thread Tero Kristo
On 10/06/17 02:12, Sebastian Reichel wrote: Add missing functional clock for DES3DES IP core. This is documented in the TRM as CM_L4SEC_DES3DES_CLKCTRL. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arc

Re: [PATCH 3/3] ARM: OMAP4: hwmod data: add des

2017-06-12 Thread Tero Kristo
On 10/06/17 02:12, Sebastian Reichel wrote: This fixes the following error during kernel boot: platform 480a5000.des: Cannot lookup hwmod 'des' Unfortunately the DES module is only documented partly in the OMAP4430 TRM. I found an old patch from Joel, which I took over and updated for currently

Re: [PATCH 2/3] ARM: OMAP4: hwmod data: add aes

2017-06-12 Thread Tero Kristo
On 10/06/17 02:12, Sebastian Reichel wrote: This fixes the following error during kernel boot: platform 4b501000.aes: Cannot lookup hwmod 'aes' Unfortunately the AES module is only documented partly in the OMAP4430 TRM. I found an old patch from Joel, which I took over and updated for currently

Re: [PATCH] clk: Add functions to save and restore clock/dpll context en-masse

2017-05-04 Thread Tero Kristo
On 04/05/17 10:51, Peter De Schrijver wrote: On Tue, Apr 18, 2017 at 10:42:49AM +0530, Keerthy wrote: From: Russ Dill The clock/dpll registers are in the WKUP power domain. Under both RTC-only suspend and hibernation, these registers are lost. Hence save/restore them accordingly. This won't

Re: [PATCH] clk: Add functions to save and restore clock/dpll context en-masse

2017-05-04 Thread Tero Kristo
On 03/05/17 21:52, Russell King - ARM Linux wrote: On Tue, Apr 18, 2017 at 10:42:49AM +0530, Keerthy wrote: From: Russ Dill The clock/dpll registers are in the WKUP power domain. Under both RTC-only suspend and hibernation, these registers are lost. Hence save/restore them accordingly. This

Re: [PATCHv2 0/5] OMAP4: crypto support

2017-06-13 Thread Tero Kristo
sham accelerator also. The dts data should be applied first if you want to avoid any issues with hwmod core complaining about missing DT data, so the sequencing of this series and mine need to be done carefully. The patches themselves in this series look fine now, so: Acked-by: Tero Kristo

Re: [PATCHv2 0/5] OMAP4: crypto support

2017-06-13 Thread Tero Kristo
On 13/06/17 17:24, Sebastian Reichel wrote: Hi, On Tue, Jun 13, 2017 at 04:49:18PM +0300, Tero Kristo wrote: On 13/06/17 12:28, Sebastian Reichel wrote: This adds crypto support for OMAP4, which was missing for some reason. This fixes error about missing hwmod on Droid 4. IP-Cores for AES and

Re: [PATCH] dt-bindings: Drop k2g genpd device ID macros

2017-06-14 Thread Tero Kristo
On 13/06/17 23:32, Santosh Shilimkar wrote: On 6/13/2017 1:16 PM, Dave Gerlach wrote: Santosh, On 05/31/2017 11:28 AM, Rob Herring wrote: On Mon, May 22, 2017 at 01:37:37PM -0500, Dave Gerlach wrote: [...] [1] https://www.spinics.net/lists/arm-kernel/msg577079.html .../devicetree/bindings

Re: [PATCH] regulator: lp873x: Update the enable mask for LDOs and BUCKs

2017-10-09 Thread Tero Kristo
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 09/10/17 17:20, Mark Brown wrote: On Wed, Sep 27, 2017 at 05:55:40PM +0530, Keerthy wrote: The reset value of the EN_PIN_CTRL bit fields of LDOs and BUCKs need no

Re: [PATCH][next] clk: ti: check for null return in strrchr to avoid null dereferencing

2017-07-26 Thread Tero Kristo
f (postfix && strlen(postfix) > 1) { if (strlen(postfix) > ADPLL_MAX_CON_ID) dev_warn(d->dev, "clock %s con_id lookup may fail\n", name); Looks fine to me. Acked-by: Tero Kristo

Re: [RFT][PATCH v2 0/2] PM / QoS: Device resume latency framework fix

2017-11-08 Thread Tero Kristo
Thank you. Thanks! Rafael The latest patches (#1 v3 and #2 v4) seem to work fine in my sanity tests also. Tested-by: Tero Kristo -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCH V2 1/5] Documentation: Add support for TI System Control Interface (TI-SCI) protocol

2016-09-05 Thread Tero Kristo
On 02/09/16 23:27, Dave Gerlach wrote: On 09/02/2016 12:07 PM, Nishanth Menon wrote: Rob, On Fri, Sep 2, 2016 at 10:06 AM, Rob Herring wrote: On Tue, Aug 30, 2016 at 08:06:43AM -0500, Nishanth Menon wrote: [...] + +TI-SCI Client Device Node: + + +Client nodes refer t

<    1   2   3   4