How to online remove an error scsi disk from the system?

2013-01-31 Thread Tao Ma
Hi All, In our product system, we have several sata disks attached to one machine. So when one of the disk fails, the jbd2(yes, we use ext4) will hang forever and we will get something in /var/log/messages like below. It seems to me that the io sent to the scsi layer is never returned back

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 03:54 PM, Bart Van Assche wrote: > On 02/01/13 07:13, Tao Ma wrote: >> In our product system, we have several sata disks attached to one >> machine. So when one of the disk fails, the jbd2(yes, we use ext4) will >> hang forever and we will get something in /

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 04:50 PM, Jack Wang wrote: > Hi All, > In our product system, we have several sata disks attached to one > machine. So when one of the disk fails, the jbd2(yes, we use ext4) will hang > forever and we will get something in /var/log/messages like below. > It seems to me that the

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 05:24 PM, Jack Wang wrote: > > On 02/01/2013 04:50 PM, Jack Wang wrote: >> Hi All, >> In our product system, we have several sata disks attached to one >> machine. So when one of the disk fails, the jbd2(yes, we use ext4) >> will hang forever and we will get something in /var/

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 05:52 PM, Bryn M. Reeves wrote: > On 02/01/2013 07:54 AM, Bart Van Assche wrote: >> * proc_scsi_write - handle writes to /proc/scsi/scsi >> * @file: not used >> * @buf: buffer to write >> * @length: length of buf, at most PAGE_SIZE >> * @ppos: not used >> * >> * Descript

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Tao Ma
On 02/01/2013 06:07 PM, Bryn M. Reeves wrote: > On 02/01/2013 09:59 AM, Tao Ma wrote: >> yes, but the result is the same. It will do some IO first which will >> cause this command hang. > > You seem to have a problem with either the device/adapter or in the > driver.

[PATCH] block/throttle: Call throtl_update_dispatch_stats with throtl_grp directly.

2012-08-30 Thread Tao Ma
From: Tao Ma All callers of throtl_update_dispatch_stats uses tg_to_blkg and then in this function we use blkg_to_tg again to change it back. So remove all these useless conversion and use throtl_grp directly to call throtl_update_dispatch_stats. Cc: Tejun Heo Cc: Vivek Goyal Cc: Jens Axboe

[PATCH V2] block/throttle: Add IO throttled information in blkio.throttle.

2012-08-30 Thread Tao Ma
From: Tao Ma Currently, if the IO is throttled by io-throttle, the SA has no idea of the situation and can't report it to the real application user about that he/she has to do something. So this patch adds a new interface named blkio.throttle.io_queued which indicates how many IOs are curr

Re: [PATCH V2] block/throttle: Add IO throttled information in blkio.throttle.

2012-09-01 Thread Tao Ma
Hi Tejun, On 09/01/2012 09:05 AM, Tejun Heo wrote: > On Fri, Aug 31, 2012 at 01:15:09PM +0800, Tao Ma wrote: >> From: Tao Ma >> >> Currently, if the IO is throttled by io-throttle, the SA has no idea of > > What's SA? system admin. > >> the situation an

Re: [PATCH V2] block/throttle: Add IO throttled information in blkio.throttle.

2012-09-04 Thread Tao Ma
On 09/04/2012 09:35 PM, Vivek Goyal wrote: > On Fri, Aug 31, 2012 at 01:15:09PM +0800, Tao Ma wrote: > > [..] >> diff --git a/block/blk-throttle.c b/block/blk-throttle.c >> index 1588c2d..9317d71 100644 >> --- a/block/blk-throttle.c >> +++ b/block/blk-throt

Re: linux-next: build failure after merge of the final tree (ext4 tree related)

2012-12-04 Thread Tao Ma
Hi Stephen, Thanks for the report. the corresponding fix is already sent to Ted in the patch named "ext4: Fix inline data build warning found by kernel build testing.", but it seems that Ted hasn't pushed it into ext4dev yet. Thanks Tao On 12/04/2012 02:13 PM, Stephen Rothwell wro

Re: next: ext4 build failure

2012-12-04 Thread Tao Ma
Hi Ted, On 12/04/2012 09:27 PM, Theodore Ts'o wrote: > On Tue, Dec 04, 2012 at 10:29:00AM +0100, Jiri Slaby wrote: >> Hi, >> >> commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa >> Author: Tao Ma >> Date: Sun Dec 2 20:30:52 2012 -0500 >> >>

Re: next: ext4 build failure

2012-12-04 Thread Tao Ma
On 12/04/2012 09:40 PM, Tao Ma wrote: > Hi Ted, > On 12/04/2012 09:27 PM, Theodore Ts'o wrote: >> On Tue, Dec 04, 2012 at 10:29:00AM +0100, Jiri Slaby wrote: >>> Hi, >>> >>> commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa >>> Auth

Re: next: ext4 build failure

2012-12-04 Thread Tao Ma
t; Hi, > > commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa > Author: Tao Ma > Date: Sun Dec 2 20:30:52 2012 -0500 > > ext4: let fallocate handle inline data correctly > > added > > static int int ext4_convert_inline_data(struct inode *inode) > >

[PATCH] cgroup: set 'start' with the right value in cgroup_path.

2012-11-08 Thread Tao Ma
From: Tao Ma 'start' is set to buf + buflen and do the '--' immediately. Just set it to 'buf + buflen - 1' directly. Cc: Tejun Heo Cc: Li Zefan --- kernel/cgroup.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup.c b

[PATCH 0/5] Remove all the reference to feature-removal-schedule.

2012-11-08 Thread Tao Ma
In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation, but there are still some reference to this file. So remove all of them. Thanks Tao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

[PATCH 1/5] Documentation: Remove reference to feature-removal-schedule.txt.

2012-11-08 Thread Tao Ma
From: Tao Ma In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation, but there is still some reference to this file. So remove them. Cc: Andrew Morton Cc: Rob Landley Cc: Linus Torvalds Signed-off-by: Tao Ma --- Documentation/00-INDEX |2 -- Documentation/ABI

[PATCH 2/5] kernel: Remove reference to feature-removal-schedule.txt.

2012-11-08 Thread Tao Ma
From: Tao Ma In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation, but there is still some reference to this file. So remove them. Cc: Andrew Morton Cc: Linus Torvalds Signed-off-by: Tao Ma --- kernel/cgroup.c |1 - kernel/module.c |3 --- 2 files changed, 0

[PATCH 3/5] checkpatch: Remove reference to feature-removal-schedule.txt.

2012-11-08 Thread Tao Ma
From: Tao Ma In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation, but there is still some reference to this file. So remove them. Cc: Andrew Morton Cc: Andy Whitcroft Cc: Linus Torvalds Signed-off-by: Tao Ma --- scripts/checkpatch.pl | 44

[PATCH 5/5] drivers: Remove reference to feature-removal-schedule.txt.

2012-11-08 Thread Tao Ma
From: Tao Ma In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation, but there is still some reference to this file. So remove them. Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Linus Torvalds Signed-off-by: Tao Ma --- drivers/mmc/host/Kconfig |4 +--- drivers

[PATCH 4/5] sound: Remove reference to feature-removal-schedule.txt.

2012-11-08 Thread Tao Ma
From: Tao Ma In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation, but there is still some reference to this file. So remove them. Cc: Andrew Morton Cc: Takashi Iwai Cc: Linus Torvalds Signed-off-by: Tao Ma --- sound/Kconfig |3 --- sound/sound_core.c |3

Re: [PATCH] cgroup: set 'start' with the right value in cgroup_path.

2012-11-08 Thread Tao Ma
On 11/08/2012 10:24 PM, Tejun Heo wrote: > Hello, > > On Thu, Nov 08, 2012 at 09:36:38PM +0800, Tao Ma wrote: >> From: Tao Ma >> >> 'start' is set to buf + buflen and do the '--' immediately. >> Just set it to 'buf + buflen - 1' dire

[PATCH V2 3/5] checkpatch: Remove reference to feature-removal-schedule.txt.

2012-11-08 Thread Tao Ma
From: Tao Ma In 9c0ece069, Linus removes feature-removal-schedule.txt from Documentation, but there is still some reference to this file. So remove them. Cc: Andrew Morton Cc: Andy Whitcroft Signed-off-by: Tao Ma --- scripts/checkpatch.pl | 37 - 1

[PATCH] cgroup: remove obsolete guarantee from cgroup_task_migrate.

2012-11-20 Thread Tao Ma
From: Tao Ma 'guarantee' is already removed from cgroup_task_migrate, so remove the corresponding comments. Some other typos in cgroup are also changed. Cc: Tejun Heo Cc: Li Zefan Signed-off-by: Tao Ma --- include/linux/cgroup.h |4 ++-- kernel/cgroup.c|8 +++

[PATCH] bond: Don't set skb->queue_mapping in netpoll.

2013-08-15 Thread Tao Ma
From: Tao Ma When we are using netpoll, we don't go through the normal transmit process. In this case, bond_select_queue is not called and qdisc_skb_cb(skb)->slave_dev_queue_mapping isn't set. So when netpoll_send_skb_on_dev calls ndo_start_xmit and we enter bond_dev_queue_xmit, we

Re: [PATCH, 3.7-rc7, RESEND] fs: revert commit bbdd6808 to fallocate UAPI

2012-11-25 Thread Tao Ma
Hi Dave, On 11/26/2012 10:55 AM, Theodore Ts'o wrote: > On Mon, Nov 26, 2012 at 11:28:14AM +1100, Dave Chinner wrote: >> fs: revert commit bbdd6808 to fallocate UAPI >> >> From: Dave Chinner >> >> Commit bbdd6808 ("fs: reserve fallocate flag codepoint") changes the >> fallocate(2) syscall interfac

Re: [PATCH] ext4: Fix memory leak in ext4_init_new_dir

2013-01-11 Thread Tao Ma
Hi Mel, Thanks for the report. This bug is already spotted by Guo Chao and the patch has been accepted by Ted already. Thanks, Tao On 01/11/2013 06:06 PM, Mel Gorman wrote: > Commit a774f9c2 "ext4: make ext4_init_dot_dotdot for inline dir usage" > is a preparation cleanup for later ext4 patches