Re: [PATCH] fat: Replaced 11 magic to MSDOS_NAME for volume label

Thanks for the reply and sorry for my noob question: Wasn't I supposed to send this patch also to the FAT maintainer, OGAWA Hirofumi? His name wasn't on the get_maintainer output, and I think that this specific file isn't listed anywhere under the maintainers file. On Mon, Nov 26, 2018 at 9:58 AM

Re: [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12)

Thanks a lot for the comments, I'll work on V2 to fix them. I just want to make sure, is there a reason why I shouldn't delete FAT_FIRST_ENT, as Joe Perches commented? On Fri, Dec 14, 2018 at 5:16 AM OGAWA Hirofumi wrote: > > Joe Perches writes: > > >> > >> -#define FAT_FIRST_ENT(s, x) ((MSD

Re: [PATCH v2 3/3] fat: New inline functions to determine the FAT variant (32, 16 or 12)

Sure. Published v3 with lower case chars. Fixed in both relevant patches. On Sat, Dec 15, 2018 at 9:10 PM OGAWA Hirofumi wrote: > > Carmeli Tamir writes: > > > This patch introduces 3 new inline functions - IS_FAT12, IS_FAT16 and > > IS_FAT32, and replaces every occurrence in the code in which t

Re: [PATCH 1/2] Use list.h instead of file_system_type next

I just found it weird that there is a proprietary implementation of a linked list while surely the kernel already offers well established data structures. IMO, the current code is a bit hard to understand, especially the addition of a new struct to the list in the line "*p = fs" after find_filesyst

Re: [PATCH] fs/binfmt: Changed order of elf and misc to prevent privilege escalation

Hi, I'd appreciate feedback on the patch. Seems like we can solve a stupid "hiding" technique, more "advanced" than just marking an executable with suid, that leads to privilege escalation. Please tell me if I miss something. On Mon, Jun 17, 2019 at 9:58 PM Carmeli Tamir wrote: > > The misc form