Re: switcheroo registration vs switching race...

2012-11-28 Thread Takashi Iwai
At Wed, 28 Nov 2012 11:45:07 +0800, Daniel J Blueman wrote: > > Hi Seth, Dave, Takashi, > > If I power down the unused discrete GPU before lightdm starts by > fiddling with the sysfs file [1] in the upstart script, I see a race > manifesting as the discrete GPU's HDA controller timing out to > co

Re: [PATCH] Revert "drm/i915: try to train DP even harder"

2013-03-18 Thread Takashi Iwai
At Sun, 17 Mar 2013 22:59:22 +0100, Daniel Vetter wrote: > > On Mon, Mar 11, 2013 at 06:40:16PM +0100, Takashi Iwai wrote: > > This reverts commit 0d71068835e2610576d369d6d4cbf90e0f802a71. > > > > Not only that the commit introduces a bogus check (voltage_tries == 5 &g

Re: [PATCH 2/2] drm/i915: Use the fixed pixel clock for eDP in intel_dp_set_m_n()

2013-03-18 Thread Takashi Iwai
At Sun, 17 Mar 2013 23:12:03 +0100, Daniel Vetter wrote: > > On Tue, Mar 12, 2013 at 04:32:28PM +0100, Takashi Iwai wrote: > > The eDP output on HP Z1 is still broken when X is started even after > > fixing the infinite link-train loop. The regression was introduced in

[PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
, there is no impact on the existing behavior. Signed-off-by: Takashi Iwai --- drivers/pci/hotplug/pciehp.h | 3 ++- drivers/pci/hotplug/pciehp_core.c | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h ind

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 09:33:18 -0700, Randy Dunlap wrote: > > On 03/20/13 07:02, Takashi Iwai wrote: > > We encountered a problem that on some HP machines the Realtek PCI-e > > card reader device appears only when you inserted a card before the > > cold boot. While debug

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 12:09:13 -0600, Alex Williamson wrote: > > On Wed, 2013-03-20 at 15:02 +0100, Takashi Iwai wrote: > > We encountered a problem that on some HP machines the Realtek PCI-e > > card reader device appears only when you inserted a card before the > > cold bo

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 17:52:34 +, Matthew Garrett wrote: > > On Wed, Mar 20, 2013 at 03:02:01PM +0100, Takashi Iwai wrote: > > We encountered a problem that on some HP machines the Realtek PCI-e > > card reader device appears only when you inserted a card before the >

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
he PCI discovery or pciehp code... > Would be nice if you look into any of my previous emails to linux-pci and > with your current knowledge comment whether here or there I faced a same > problem. Looks like. Disabling the hotplug is a no go for me, I need hotplug > for my ExpressCards

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 19:12:50 +, Matthew Garrett wrote: > > On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote: > > At Wed, 20 Mar 2013 17:52:34 +, > > Matthew Garrett wrote: > > > Well that just sounds like a bug. What's the downside to just ign

Re: [PATCH 0/9] Add blockconsole version 1.1 (try 2)

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 23:52:31 +0100, Borislav Petkov wrote: > > Hi Andrew, > > On Thu, Feb 28, 2013 at 04:39:53PM -0500, Joern Engel wrote: > > Blockconsole is a console driver very roughly similar to netconsole. > > Instead of sending messages out via UDP, they are written to a block > > device.

Re: 3.8-rc1 patch_cirrus 4.0 regression...

2013-02-05 Thread Takashi Iwai
, but the problem still occurs with only [2] reverted). > > How can I help to debug this and find the right approach? > > Thanks, > Daniel > > --- [1] > > commit f37bc7a88d374448a1f4bba9267d308606d78bf2 > Author: Takashi Iwai > Date: Thu Nov 8 15:59:23 2

Re: 3.8-rc1 patch_cirrus 4.0 regression...

2013-02-05 Thread Takashi Iwai
At Wed, 6 Feb 2013 00:29:54 +0800, Daniel J Blueman wrote: > > On 6 February 2013 00:16, Takashi Iwai wrote: > > At Wed, 6 Feb 2013 00:10:30 +0800, > > Daniel J Blueman wrote: > >> > >> Hi Takashi, > >> > >> The v3.8-rc kernels have regress

Re: 3.8-rc1 patch_cirrus 4.0 regression...

2013-02-05 Thread Takashi Iwai
At Tue, 05 Feb 2013 17:16:32 +0100, Takashi Iwai wrote: > > At Wed, 6 Feb 2013 00:10:30 +0800, > Daniel J Blueman wrote: > > > > Hi Takashi, > > > > The v3.8-rc kernels have regressed from v3.7 with the quad-speaker > > arrangement on my Macbook Pro 10,1 -

Re: 3.8-rc1 patch_cirrus 4.0 regression...

2013-02-05 Thread Takashi Iwai
At Tue, 05 Feb 2013 17:34:15 +0100, Takashi Iwai wrote: > > At Wed, 6 Feb 2013 00:29:54 +0800, > Daniel J Blueman wrote: > > > > On 6 February 2013 00:16, Takashi Iwai wrote: > > > At Wed, 6 Feb 2013 00:10:30 +0800, > > > Daniel J Blueman wrote: > >

Re: 3.8-rc1 patch_cirrus 4.0 regression...

2013-02-05 Thread Takashi Iwai
At Wed, 6 Feb 2013 08:47:41 +0800, Daniel J Blueman wrote: > > On 6 February 2013 01:40, Takashi Iwai wrote: > > At Tue, 05 Feb 2013 17:34:15 +0100, > > Takashi Iwai wrote: > >> > >> At Wed, 6 Feb 2013 00:29:54 +0800, > >> Daniel J Blueman wrote: &g

Re: [PATCH 12/15] sound: add missing HAS_IOPORT and GENERIC_HARDIRQS dependencies

2013-02-06 Thread Takashi Iwai
sound/soc/codecs/wm8903.c:1954:9: error: implicit declaration of function > ‘irq_get_irq_data’ Ditto, how about defining #ifndef CONFIG_GENERIC_HARDIRQS #define irq_get_irq_data(x) NULL #endif somewhere appropriately? Takashi > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Si

Re: [PATCH 12/15] sound: add missing HAS_IOPORT and GENERIC_HARDIRQS dependencies

2013-02-06 Thread Takashi Iwai
At Thu, 07 Feb 2013 02:13:19 +0100, Arnd Bergmann wrote: > > On Wednesday 06 February 2013 18:05:14 Takashi Iwai wrote: > > At Wed, 6 Feb 2013 17:24:00 +0100, > > Heiko Carstens wrote: > > > > > > Fix these two compile errors on s390 which does not have H

[GIT PULL] Sound fixes for 3.8-rc7

2013-02-06 Thread Takashi Iwai
ule" ASoC: fsl: fix snd-soc-imx-pcm module build Takashi Iwai (1): Merge branch 'fix/fsl' of git://git.kernel.org/.../broonie/sound into for-linus-uncursed sound/soc/fsl/Kconfig | 9 +++-- sound/soc/fsl/Makefile | 5 + sound/soc/fsl/imx-pcm-dma.

Re: mmotm 2013-02-06-17-13 uploaded (alsa)

2013-02-07 Thread Takashi Iwai
At Wed, 06 Feb 2013 21:59:37 -0800, Randy Dunlap wrote: > > On 02/06/13 17:14, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2013-02-06-17-13 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment

Re: [PATCH 11/11] sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers

2013-02-07 Thread Takashi Iwai
At Wed, 6 Feb 2013 15:32:50 -0700, H Hartley Sweeten wrote: > > Use the new module_pcmcia_driver() macro to remove the boilerplate > module init/exit code in the pcmcia drivers. > > Signed-off-by: H Hartley Sweeten Acked-by: Takashi Iwai (But please add subsystem maintaine

Re: [PATCH 12/15] sound: add missing HAS_IOPORT and GENERIC_HARDIRQS dependencies

2013-02-07 Thread Takashi Iwai
At Thu, 7 Feb 2013 14:32:06 +0100, Heiko Carstens wrote: > > On Wed, Feb 06, 2013 at 09:56:55PM +, Arnd Bergmann wrote: > > On Wednesday 06 February 2013, Heiko Carstens wrote: > > > On Wed, Feb 06, 2013 at 06:26:02PM +0100, Takashi Iwai wrote: > > > > A

Re: [PATCH 2/5] hda_intel: Add Device IDs for Intel Wellsburg PCH

2013-02-10 Thread Takashi Iwai
At Fri, 8 Feb 2013 17:29:40 -0800, James Ralston wrote: > > This patch adds the HD Audio Device IDs for the Intel Wellsburg PCH > > Signed-off-by: James Ralston Thanks, applied. Takashi > --- > sound/pci/hda/hda_intel.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > >

Re: [PATCH] [ALSA] sound: rme32.c irq enabling after spin_lock_irq

2013-02-11 Thread Takashi Iwai
At Mon, 11 Feb 2013 19:04:06 +0400, Denis Efremov wrote: > > According to the other code in this driver and similar > code in rme96 it seems, that spin_lock_irq in > snd_rme32_capture_close function should be paired > with spin_unlock_irq. > > Found by Linux Driver Verification project (linuxtest

Re: [PATCH] ALSA: ali5451: remove irq enabling in pointer callback

2013-02-11 Thread Takashi Iwai
At Mon, 11 Feb 2013 19:49:48 +0400, Denis Efremov wrote: > > snd_ali_pointer function is called with local > interrupts disabled. However it seems very strange to > reenable them in such way. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Denis Efremov Th

Re: [PATCH 1/3] ALSA: hda - Workaround for silent output on Sony Vaio VGC-LN51JGB with ALC889

2013-02-12 Thread Takashi Iwai
At Tue, 12 Feb 2013 16:47:44 +0900, Fernando Luis Vázquez Cao wrote: > > Some Vaio all-in-one desktop PCs (for example VGC-LN51JGB) are affected by > the same issue that caused Vaio Z laptops to become silent: the speaker pin > must be connected to the first DAC even though the codec itself advert

Re: [PATCH 2/3] ALSA: hda - update documentation for no-primary-hp fixup

2013-02-12 Thread Takashi Iwai
At Tue, 12 Feb 2013 16:49:46 +0900, Fernando Luis Vázquez Cao wrote: > > The problem addressed by this fixup is not specific to Vaio Z, affecting > some Vaio all-in-one desktop PCs too. Update the code comments accordingly. > > Cc: sta...@vger.kernel.org > Cc: alsa-de...@alsa-project.org > Signed

Re: [PATCH 2/3] ALSA: hda - no-primary-hp is a quirk for model ALC889 not ALC882

2013-02-12 Thread Takashi Iwai
At Tue, 12 Feb 2013 16:54:16 +0900, Fernando Luis Vázquez Cao wrote: > > Substitute ALC889 for ALC882 in macro and function names. > > Cc: sta...@vger.kernel.org > Cc: alsa-de...@alsa-project.org > Signed-off-by: Fernando Luis Vazquez Cao This fixup can work generically to all ALC882 variants,

Re: [PATCH] sound: oss: uart401: Used kmemdup instead of kmalloc and memcpy

2013-04-02 Thread Takashi Iwai
At Mon, 25 Mar 2013 15:46:49 +0200, Alexandru Gheorghiu wrote: > > Used kmemdup instead of replicating it's behaviour with kmalloc followed > by memcpy. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu Thanks, applied. Takashi > --- > sound/oss/uart401.c | 11 +++

Re: [PATCH] sound: oss: sb_common: Used kmemdup instead of kmalloc and memcpy

2013-04-02 Thread Takashi Iwai
At Mon, 25 Mar 2013 15:50:34 +0200, Alexandru Gheorghiu wrote: > > Used kmemdup instead of replicating it's behaviour with kmalloc followed > by memcpy. > Patch found using coccinelle. > > Signed-off-by: Alexandru Gheorghiu Thanks, applied. Takashi > --- > sound/oss/sb_common.c |3 +--

Re: ALSA: problems setting up usb devices using kernel 3.9.0-rc4+

2013-04-02 Thread Takashi Iwai
At Mon, 25 Mar 2013 22:53:02 +0100, Florian Scholz wrote: > > Hi Jarsolav and Takashi, > > I'm experiencing some ALSA problems during the set up of my Creative X-Fi HD > USB sound card and the device isn't in the device list. The kernel is > 3.9.0-rc4+ (GIT) > > ... > [ 39.949914] ALSA soun

Re: [alsa-devel] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010, IP: [] snd_info_get_line+0x3b/0xf0

2013-04-02 Thread Takashi Iwai
At Fri, 8 Mar 2013 22:21:26 +0200, Tommi Rantala wrote: > > Hello, > > Saw this while fuzzing with trinity in a qemu virtual machine: > > [6026] Random reseed: 625996896 > [watchdog] 7640111 iterations. [F:6650299 S:989808] > [6026] Random reseed: 472197910 > [ 459.365417] misc rfkill: uevent:

[PATCH] nfsd4: Fix NULL dereference in legacy_recdir_name_error()

2013-04-03 Thread Takashi Iwai
7/0x70 [nfsd] RSP CR2: 07a8 ---[ end trace 5dd4307598e98cef ]--- This patch fixes it by passing the proper net instance instead of NULL. Signed-off-by: Takashi Iwai Cc: [v3.8+] --- fs/nfsd/nfs4recover.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --gi

Re: [PATCH 3/5] SOUND: hda_generic, fix uninitialized variable

2013-04-04 Thread Takashi Iwai
At Thu, 4 Apr 2013 22:32:10 +0200, Jiri Slaby wrote: > > changed is not initialized in path_power_down_sync, but it is expected > to be false in case no change happened in the loop. So set it to > false. > > Signed-off-by: Jiri Slaby > Cc: Jaroslav Kysela > Cc: Takash

[GIT PULL] Sound fixes for 3.9-rc6

2013-04-05 Thread Takashi Iwai
: core: fix invalid free of devm_ allocated data Takashi Iwai (1): Revert "ALSA: hda - Allow power_save_controller option override DCAPS" Torstein Hegge (1): ALSA: usb: Work around CM6631 sample rate change bug Wei Yongjun (2): ASoC: wm_adsp: fix possible memo

Re: [GIT PULL] Sound fixes for 3.9-rc6

2013-04-05 Thread Takashi Iwai
At Fri, 5 Apr 2013 09:06:43 -0700, Linus Torvalds wrote: > > On Fri, Apr 5, 2013 at 12:46 AM, Takashi Iwai wrote: > > > > please pull sound fixes for v3.9-rc6 from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus > > Argh,

Re: [PATCH 1/2] drm/cirrus: Correct register values for 16bpp

2013-01-29 Thread Takashi Iwai
Hi Dave, any chance to take a look at this problem? thanks, Takashi At Fri, 25 Jan 2013 17:21:54 +0100, Takashi Iwai wrote: > > When the mode is set with 16bpp on QEMU, the output gets totally > broken. The culprit is the bogus register values set for 16bpp, > which was likely

[PATCH] drm/cirrus: Add bpp option

2013-01-29 Thread Takashi Iwai
Add a new option, bpp, to specify the default bpp value. Signed-off-by: Takashi Iwai --- This patch is applied on the top of previous two patches. I couldn't find an easy way to specify the default bpp, so I cooked the driver quickly. If there is any other convenient way to achieve this

Re: [PATCH] drm/cirrus: Add bpp option

2013-01-29 Thread Takashi Iwai
At Tue, 29 Jan 2013 10:53:50 +0100, Daniel Vetter wrote: > > On Tue, Jan 29, 2013 at 09:29:17AM +0100, Takashi Iwai wrote: > > Add a new option, bpp, to specify the default bpp value. > > > > Signed-off-by: Takashi Iwai > > --- > > > > This patch is

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-29 Thread Takashi Iwai
At Tue, 29 Jan 2013 18:24:04 +0800, Ming Lei wrote: > > Hi Takashi, > > On Sat, Jan 26, 2013 at 12:05 AM, Takashi Iwai wrote: > > Since 3.7 kernel, the firmware loader can read the firmware files > > directly, and the traditional user-mode helper is invoked only as a &

[PATCH 2/4] firmware: Make user-mode helper optional

2013-01-29 Thread Takashi Iwai
This patch adds a new kconfig, CONFIG_FW_LOADER_USER_HELPER, and guards the user-helper codes in firmware_class.c with ifdefs. Yeah, yeah, there are lots of ifdefs in this patch. The further clean-up with code shuffling follows in the next. Signed-off-by: Takashi Iwai --- drivers/base/Kconfig

[PATCH 4/4] firmware: Ignore abort check when no user-helper is used

2013-01-29 Thread Takashi Iwai
FW_STATUS_ABORT can be set only during the user-helper invocation, thus we can ignore the check when CONFIG_HW_LOADER_USER_HELPER is disabled. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 0/4] firmware: Make user-mode helper optional (v3)

2013-01-29 Thread Takashi Iwai
Hi Ming, here is the revised patch series after your review. In addition to points you suggested, I changed the return value of _request_firmware_prepare() to be more naturally processed, and fixed one forgotten unbalanced put_device() call. The rest are same as the former version, just adapted th

[PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-29 Thread Takashi Iwai
that: refactor the code for splitting user-mode helper stuff more easily. No functional change. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 290 +++--- 1 file changed, 157 insertions(+), 133 deletions(-) diff --git a/drivers/base

[PATCH 3/4] firmware: Reduce ifdef CONFIG_FW_LOADER_USER_HELPER

2013-01-29 Thread Takashi Iwai
By shuffling the code, reduce a few ifdefs in firmware_class.c. Also, firmware_buf fmt field is changed to is_pages_buf boolean for simplification. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 369 -- 1 file changed, 179 insertions

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-29 Thread Takashi Iwai
At Wed, 30 Jan 2013 11:37:30 +0800, Ming Lei wrote: > > On Tue, Jan 29, 2013 at 10:46 PM, Takashi Iwai wrote: > > Since 3.7 kernel, the firmware loader can read the firmware files > > directly, and the traditional user-mode helper is invoked only as a > > fallback. T

[GIT PULL] Sound fixes for 3.8-rc6

2013-01-30 Thread Takashi Iwai
init_module Takashi Iwai (3): ALSA: hda - Add a fixup for Packard-Bell desktop with ALC880 ALSA: hda - Enable LPIB delay count for Poulsbo / Oaktrail ALSA: hda - Fix non-snoop page handling --- sound/pci/hda/hda_intel.c | 49 ++- sound/pci

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
At Wed, 30 Jan 2013 18:25:20 +0800, Ming Lei wrote: > > On Wed, Jan 30, 2013 at 3:17 PM, Takashi Iwai wrote: > >> The above usermodehelper_read_lock thing may be a functional change, > >> and looks not what you claimed in commit log, :-). The lock is currently > >

[PATCH 4/4] firmware: Ignore abort check when no user-helper is used

2013-01-30 Thread Takashi Iwai
FW_STATUS_ABORT can be set only during the user-helper invocation, thus we can ignore the check when CONFIG_HW_LOADER_USER_HELPER is disabled. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 0/4] firmware: Make user-mode helper optional (v4)

2013-01-30 Thread Takashi Iwai
Hi Ming, this is again revised patch series. The usermodehelper lock is applied again for the direct loading case, the wrongly removed put_device() is revived again (with a comment). I have a patch on top of this for moving usermodehelper lock out of the direct loading case, but let's discuss abo

[PATCH 3/4] firmware: Reduce ifdef CONFIG_FW_LOADER_USER_HELPER

2013-01-30 Thread Takashi Iwai
By shuffling the code, reduce a few ifdefs in firmware_class.c. Also, firmware_buf fmt field is changed to is_pages_buf boolean for simplification. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 313 -- 1 file changed, 151 insertions

[PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
that: refactor the code for splitting user-mode helper stuff more easily. No functional change. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 288 +++--- 1 file changed, 155 insertions(+), 133 deletions(-) diff --git a/drivers/base

[PATCH 2/4] firmware: Make user-mode helper optional

2013-01-30 Thread Takashi Iwai
This patch adds a new kconfig, CONFIG_FW_LOADER_USER_HELPER, and guards the user-helper codes in firmware_class.c with ifdefs. Yeah, yeah, there are lots of ifdefs in this patch. The further clean-up with code shuffling follows in the next. Signed-off-by: Takashi Iwai --- drivers/base/Kconfig

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
At Wed, 30 Jan 2013 18:50:05 +0800, Ming Lei wrote: > > On Wed, Jan 30, 2013 at 6:31 PM, Takashi Iwai wrote: > > > > But it's supposed to be cached, no? > > Generally it will be cached, but some crazy devices might come as new > device during resume, so we st

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
At Wed, 30 Jan 2013 11:53:14 +0100, Takashi Iwai wrote: > > At Wed, 30 Jan 2013 18:50:05 +0800, > Ming Lei wrote: > > > > On Wed, Jan 30, 2013 at 6:31 PM, Takashi Iwai wrote: > > > > > > But it's supposed to be cached, no? > > > > Genera

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
At Wed, 30 Jan 2013 19:48:15 +0800, Ming Lei wrote: > > On Wed, Jan 30, 2013 at 7:08 PM, Takashi Iwai wrote: > > At Wed, 30 Jan 2013 11:53:14 +0100, > > Takashi Iwai wrote: > >> > >> At Wed, 30 Jan 2013 18:50:05 +0800, > >> Ming Lei wrote: > >

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-31 Thread Takashi Iwai
At Thu, 31 Jan 2013 17:48:34 +0800, Ming Lei wrote: > (snip) > > +/* called from request_firmware() and request_firmware_work_func() */ > > +static int > > +_request_firmware(const struct firmware **firmware_p, const char *name, > > + struct device *device, bool uevent, bool nowait

[PATCH 0/4] firmware: Make user-mode helper optional (v5)

2013-01-31 Thread Takashi Iwai
Hi, this is a series of revised patches for making the user-mode helper call in the firmware loader optional. Hopefully all things settled down now. v4->v5: fix invalid call of usermodehelper_unlock() thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

[PATCH 4/4] firmware: Ignore abort check when no user-helper is used

2013-01-31 Thread Takashi Iwai
FW_STATUS_ABORT can be set only during the user-helper invocation, thus we can ignore the check when CONFIG_HW_LOADER_USER_HELPER is disabled. Acked-by: Ming Lei Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions

[PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-31 Thread Takashi Iwai
that: refactor the code for splitting user-mode helper stuff more easily. No functional change. Acked-by: Ming Lei Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 287 ++ 1 file changed, 154 insertions(+), 133 deletions(-) diff --git a

[PATCH 2/4] firmware: Make user-mode helper optional

2013-01-31 Thread Takashi Iwai
This patch adds a new kconfig, CONFIG_FW_LOADER_USER_HELPER, and guards the user-helper codes in firmware_class.c with ifdefs. Yeah, yeah, there are lots of ifdefs in this patch. The further clean-up with code shuffling follows in the next. Acked-by: Ming Lei Signed-off-by: Takashi Iwai

[PATCH 3/4] firmware: Reduce ifdef CONFIG_FW_LOADER_USER_HELPER

2013-01-31 Thread Takashi Iwai
By shuffling the code, reduce a few ifdefs in firmware_class.c. Also, firmware_buf fmt field is changed to is_pages_buf boolean for simplification. Acked-by: Ming Lei Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 313 -- 1 file changed

Re: [PATCH next-20130124] Sound: pci: Fix unused variable warning in patch_sigmatel.c

2013-01-25 Thread Takashi Iwai
At Fri, 25 Jan 2013 00:38:06 +0200, Stratos Karafotis wrote: > > Fix the following build warnings > > sound/pci/hda/patch_sigmatel.c: In function ‘stac92hd71bxx_fixup_hp’: > sound/pci/hda/patch_sigmatel.c:2434:24: warning: unused variable ‘spec’ > [-Wunused-variable] Thanks for catching. But s

Re: [PATCH next-20130124] Sound: pci: Fix unused variable warning in patch_sigmatel.c

2013-01-25 Thread Takashi Iwai
At Fri, 25 Jan 2013 02:03:16 -0800, Joe Perches wrote: > > On Fri, 2013-01-25 at 10:09 +0100, Takashi Iwai wrote: > > At Fri, 25 Jan 2013 00:38:06 +0200, > > Stratos Karafotis wrote: > > > Fix the following build warnings > > > sound/pci/hda/patch_sigmatel.c:

Re: [PATCH] firmware: Make user-mode helper optional

2013-01-25 Thread Takashi Iwai
At Fri, 25 Jan 2013 11:12:03 +0800, Ming Lei wrote: > > On Tue, Jan 22, 2013 at 7:51 PM, Takashi Iwai wrote: > > Since 3.7 kernel, the firmware loader can read the firmware files > > directly, and the traditional user-mode helper is invoked only as a > > fallback. This s

[PATCH 0/4] firmware: Make user-mode helper optional (v2)

2013-01-25 Thread Takashi Iwai
Hi Ming, this is a series of revised patches to make the user-mode helper in the firmware loader optional. A few bugs (typos) have been fixed during this rewrite, and a small optimization was added in the last patch. I hope this would be good enough for review. thanks, Takashi -- To unsubscrib

[PATCH 2/4] firmware: Make user-mode helper optional

2013-01-25 Thread Takashi Iwai
This patch adds a new kconfig, CONFIG_FW_LOADER_USER_HELPER, and guards the user-helper codes in firmware_class.c with ifdefs. Yeah, yeah, there are lots of ifdefs in this patch. The further clean-up with code shuffling follows in the next. Signed-off-by: Takashi Iwai --- drivers/base/Kconfig

[PATCH 4/4] firmware: Ignore abort check when no user-helper is used

2013-01-25 Thread Takashi Iwai
FW_STATUS_ABORT can be set only during the user-helper invocation, thus we can ignore the check when CONFIG_HW_LOADER_USER_HELPER is disabled. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 3/4] firmware: Reduce ifdef CONFIG_FW_LOADER_USER_HELPER

2013-01-25 Thread Takashi Iwai
By shuffling the code, reduce a few ifdefs in firmware_class.c. Also, firmware_buf fmt field is changed to is_pages_buf boolean for simplification. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 377 +- 1 file changed, 184 insertions

[PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-25 Thread Takashi Iwai
that: refactor the code for splitting user-mode helper stuff more easily. No functional change. Signed-off-by: Takashi Iwai --- drivers/base/firmware_class.c | 286 +++--- 1 file changed, 159 insertions(+), 127 deletions(-) diff --git a/drivers/base

[PATCH 2/2] drm/cirrus: Use 16bpp as default

2013-01-25 Thread Takashi Iwai
om/show_bug.cgi?id=799216 Signed-off-by: Takashi Iwai --- drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 +- drivers/gpu/drm/cirrus/cirrus_mode.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b/drivers/gpu/drm/cirrus/cirrus_fbdev.c inde

[PATCH 1/2] drm/cirrus: Correct register values for 16bpp

2013-01-25 Thread Takashi Iwai
When the mode is set with 16bpp on QEMU, the output gets totally broken. The culprit is the bogus register values set for 16bpp, which was likely copied from from a wrong place. Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=799216 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm

Re: [PATCH 3/3] ALSA: intel8x0: Check return value before assigning

2013-01-28 Thread Takashi Iwai
At Sun, 27 Jan 2013 17:40:02 +0100, Emil Goode wrote: > > The first patch in this series changes the return type of function > kvm_para_available to bool. In the function snd_intel8x0_inside_vm > we now need to check it's return value before assigning a value to > the result variable. > > Signed-

Re: 3.7 HDMI channel map regression

2013-01-28 Thread Takashi Iwai
At Sun, 27 Jan 2013 19:18:27 -0600, Shawn Bohrer wrote: > > Hi Takashi, > > I recently updated my HTPC from 3.6.11 to 3.7.2 and this caused my RL > and FC channels to swap, and my RR and LFE channels to swap for PCM > audio. Doing a git bisect identified > d45e6889ee69456a4d5b1bbb32252f460cd48fa

[PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

2013-02-26 Thread Takashi Iwai
The DriveGuard chips on the new HP laptops are with a new PnP ID "HPQ6007". It should be compatible with older chips. Signed-off-by: Takashi Iwai --- drivers/platform/x86/hp_accel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/hp_accel.c b/drivers/pl

[GIT PULL] Sound fixes for 3.9-rc1

2013-02-27 Thread Takashi Iwai
tz (1): ALSA: emu10k1: Load firmware when it was already cached Jonas Petersen (1): ALSA: ice1724: M-Audio Audiophile192: Fix SPDIF input Mihail Zenkov (2): ALSA: emu10k1: Fix regression in emu1010 firmware loading ALSA: emu10k1: Allow to switch hardware sampe rate on EMU Ta

Re: [PATCH] ALSA: usb: Fix Processing Unit Descriptor parsers

2013-02-21 Thread Takashi Iwai
At Thu, 21 Feb 2013 01:55:50 +, Pawel Moll wrote: > > Commit 99fc86450c439039d2ef88d06b222fd51a779176 "ALSA: usb-mixer: > parse descriptors with structs" introduced a set of useful parsers > for descriptors. Unfortunately the parses for the Processing Unit > Descriptor came with a very subtle

Re: [PATCH] ALSA: usb: Fix Processing Unit Descriptor parsers

2013-02-21 Thread Takashi Iwai
At Thu, 21 Feb 2013 13:10:16 +0100, Daniel Mack wrote: > > On 21.02.2013 10:03, Takashi Iwai wrote: > > At Thu, 21 Feb 2013 01:55:50 +, > > Pawel Moll wrote: > >> > >> Commit 99fc86450c439039d2ef88d06b222fd51a779176 "ALSA: usb-mixer: > >> p

[GIT PULL] Sound updates for 3.9-rc1

2013-02-21 Thread Takashi Iwai
cpdm: Remove useless ressource get. Stephen Rothwell (1): ASoC: ak4642: remove __devinitconst annotation Takashi Iwai (245): ALSA: hda - Add new DSP loader callback routines ALSA: hda - Fix NULL dereference in error path of patch_ca0132.c ALSA: hda - Remove superfluous zer

[PATCH 1/2] Revert "drm/i915: try to train DP even harder"

2013-03-12 Thread Takashi Iwai
check for the intended purpose of that commit, but let's revert the wrong "fix" at first. Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/

[PATCH 2/2] drm/i915: Use the fixed pixel clock for eDP in intel_dp_set_m_n()

2013-03-12 Thread Takashi Iwai
-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 7d250aa..ddbf50f 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915

[PATCH 0/2] Fix eDP breakages on HP Z1 desktop

2013-03-12 Thread Takashi Iwai
Hi, this is a patch series to fix the breakages of eDP output on HP Z1 desktop machine with IvyBridge since 3.6 kernel. The first patch is identical as what I already sent yesterday, reverting a bogus check in the dp train loop. The second one is the patch I cooked today, for using the correct p

Regression: HSW eDP broken on 3.9-rc[12]

2013-03-14 Thread Takashi Iwai
Hi, I noticed that a Haswell desktop machine with eDP gets only the blank screen on the latest Linus tree. It works fine with 3.8, so it's a regression since 3.9-rc1. Actually, it's not a regression. It's three regressions in a shot! (I had to do painful bisections three times...) c464b2a17c59

[GIT PULL] Sound fixes for 3.9-rc3

2013-03-15 Thread Takashi Iwai
DSP. ALSA: hda/ca0132 - Remove extra setting of dsp_state. Takashi Iwai (3): ALSA: seq: Fix missing error handling in snd_seq_timer_open() ALSA: hda - Fix snd_hda_get_num_raw_conns() to return a correct value ALSA: hda - Fix missing EAPD/GPIO setup for Cirrus codecs Wei Yongjun

Re: [PATCH] documentation: alsa: Fix typo in Documentation/sound

2013-03-17 Thread Takashi Iwai
At Sun, 17 Mar 2013 02:57:28 +0900, Masanari Iida wrote: > > Correct spelling typos in Documentation/sound/alsa > > Signed-off-by: Masanari Iida Thanks, applied. Takashi > --- > Documentation/sound/alsa/ALSA-Configuration.txt | 2 +- > Documentation/sound/alsa/seq_oss.html | 2 +-

Re: [PATCHv2] sound: fix emu8000 DRAM sized 512 KiB too small

2012-08-28 Thread Takashi Iwai
At Mon, 27 Aug 2012 22:25:21 -0400, David Flater wrote: > > v2: Fixed result still wrong in the case of 512 KiB DRAM. Oops. > > Applicable to 3.5.3 mainline. > > In emu8000.c, size_dram determines the amount of memory on the sound card by > doing write/readback tests starting at 512 KiB and in

Re: Logitech USB headset not working in 3.6-rc3

2012-08-29 Thread Takashi Iwai
At Wed, 29 Aug 2012 13:26:25 +0200, Daniel Mack wrote: > > [1 ] > On 25.08.2012 14:17, Josh Boyer wrote: > > On Sat, Aug 25, 2012 at 02:13:58PM +0200, Daniel Mack wrote: > >> On 25.08.2012 14:07, Bruno Wolff III wrote: > >>> On Sat, Aug 25, 2012 at 14:02:51 +0200, > >>>Daniel Mack wrote: > >

Re: Logitech USB headset not working in 3.6-rc3

2012-08-29 Thread Takashi Iwai
At Wed, 29 Aug 2012 15:32:34 +0200, Daniel Mack wrote: > > [1 ] > On 29.08.2012 15:29, Takashi Iwai wrote: > > At Wed, 29 Aug 2012 13:26:25 +0200, > > Daniel Mack wrote: > >> > >> [1 ] > >> On 25.08.2012 14:17, Josh Boyer wrote: > >>>

Re: Logitech USB headset not working in 3.6-rc3

2012-08-29 Thread Takashi Iwai
At Wed, 29 Aug 2012 16:25:46 +0200, Daniel Mack wrote: > > On 29.08.2012 16:14, Takashi Iwai wrote: > > At Wed, 29 Aug 2012 15:32:34 +0200, > > Daniel Mack wrote: > >> > >> [1 ] > >> On 29.08.2012 15:29, Takashi Iwai wrote: > >>> At

Re: Logitech USB headset not working in 3.6-rc3

2012-08-30 Thread Takashi Iwai
At Wed, 29 Aug 2012 15:32:34 +0200, Daniel Mack wrote: > > On 29.08.2012 15:29, Takashi Iwai wrote: > > At Wed, 29 Aug 2012 13:26:25 +0200, > > Daniel Mack wrote: > >> > >> [1 ] > >> On 25.08.2012 14:17, Josh Boyer wrote: > >>> On

Re: crash dump memory reservation regression

2012-08-31 Thread Takashi Iwai
At Fri, 31 Aug 2012 09:37:05 -0700, H. Peter Anvin wrote: > > Kernel Summit is this week... people are away. I (as a person who asked the revert) don't mind now to set the good_end back for 64bit again. On 3.5/3.6 kernels, there seems more other places breaking the hibernation on the machines hi

Re: [PATCH] ALSA: fix possible memory leak in snd_mixer_oss_build_input()

2012-09-03 Thread Takashi Iwai
At Sun, 2 Sep 2012 22:10:27 +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > uinfo has been allocated in this function and should be > freed before leaving from the error handling cases. > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signe

Re: [PATCH] sound: Remove the last mention of SNDRV_MAIN_OBJECT_FILE

2012-09-03 Thread Takashi Iwai
At Sun, 2 Sep 2012 20:04:17 -0700, Josh Triplett wrote: > > SNDRV_MAIN_OBJECT_FILE hasn't done anything since the pre-git days, and > the only remaining reference occurs as a #define in sound/last.c. Drop > that last mention of it. > > Signed-off-by: Josh Triplett Applied now. Thanks. Takas

A workaround for request_firmware() stuck in module_init

2012-09-04 Thread Takashi Iwai
;t happen unless any new driver binding occurs.) As an example implementation, the patch contains the fix for sound/pci/rme9652/hdsp.c, too. Signed-off-by: Takashi Iwai --- drivers/base/base.h | 6 ++ drivers/base/dd.c| 25 + include/linux/firmware.h

[GIT PULL] sound fixes for 3.6-rc5

2012-09-04 Thread Takashi Iwai
list_for_each_safe for endpoint resources Takashi Iwai (2): ALSA: hda - Avoid unnecessary parameter read for EPSS ALSA: hda - Don't trust codec EPSS bit for IDT 92HD83xx & co sound/pci/hda/hda_codec.c | 10 +-- sound/pci/hda/hda_codec.h | 1 + sound/pci/hda/patch_sigmat

Re: A workaround for request_firmware() stuck in module_init

2012-09-04 Thread Takashi Iwai
At Tue, 4 Sep 2012 23:52:15 +0800, Ming Lei wrote: > > On Tue, Sep 4, 2012 at 9:06 PM, Takashi Iwai wrote: > > Hi, > > > > as I've got recently a few bug reports regarding the stuck with > > request_firmware() in module_init of some sound drivers, I started &

Re: A workaround for request_firmware() stuck in module_init

2012-09-04 Thread Takashi Iwai
At Wed, 5 Sep 2012 09:15:34 +0800, Ming Lei wrote: > > On Wed, Sep 5, 2012 at 12:10 AM, Takashi Iwai wrote: > > At Tue, 4 Sep 2012 23:52:15 +0800, > > Ming Lei wrote: > >> > >> On Tue, Sep 4, 2012 at 9:06 PM, Takashi Iwai wrote: > >> > Hi, >

Re: [PATCH] ALSA: use list_move_tail instead of list_del/list_add_tail

2012-09-05 Thread Takashi Iwai
At Wed, 5 Sep 2012 14:33:21 +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > Using list_move_tail() instead of list_del() + list_add_tail(). > > Signed-off-by: Wei Yongjun Thanks, applied. Takashi > --- > sound/drivers/opl4/opl4_synth.c | 9 +++-- > 1 file changed, 3 insertions(+),

Re: [PATCH] ALSA: use list_move_tail instead of list_del/list_add_tail

2012-09-05 Thread Takashi Iwai
At Wed, 5 Sep 2012 15:00:15 +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > Using list_move_tail() instead of list_del() + list_add_tail(). > > Signed-off-by: Wei Yongjun Applied this one, too. Thanks. Takashi > --- > sound/pci/emu10k1/memory.c | 4 ++-- > 1 file changed, 2 insertio

Re: [alsa-devel] [PATCH 11/11] ASoC: omap-pcm: Convert to use dmaengine

2012-09-12 Thread Takashi Iwai
At Wed, 12 Sep 2012 13:00:28 +0100, Russell King - ARM Linux wrote: > > On Wed, Sep 12, 2012 at 02:47:07PM +0300, Peter Ujfalusi wrote: > > 2. Pause/Resume > >OMAP DMA engine backend does not support pausing and resuming > >an in-progress transfer. It is unclear from the specs what > >

[GIT PULL] sound fixes for 3.6-rc6

2012-09-13 Thread Takashi Iwai
AK4396 volume control. Takashi Iwai (3): ALSA: hda - Fix missing Master volume for STAC9200/925x ALSA: usb-audio: Fix bogus error messages for delay accounting ALSA: hda - Fix Oops at codec reset/reconfig sound/core/compress_offload.c| 8 +++- sound/pci/hda/hda_codec.c

  1   2   3   4   5   6   7   8   9   10   >