[PATCH v2 2/9] perf annotate: Properly rename 'sum' to 'total_samples' in struct sym_hist

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/gtk/annotate.c | 2 +- tools/perf/util/annotate.c | 22 +++--- tools/perf/util/annotate.h | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/perf/ui/gtk/annotate.c b

[PATCH v2 5/9] perf anntoate browser: Fix the toggle total period view to show period, not number of samples

$0x38,%rsp 2204022 │ mov%rax,(%rsp) 2207405 │ mov%rcx,0x8(%rsp) Reported-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/t

Re: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view

Hi, On 06/29/2017 04:11 PM, Namhyung Kim wrote: Hello, On Wed, Jun 28, 2017 at 11:53:22AM +0200, Milian Wolff wrote: On Wednesday, June 28, 2017 5:18:08 AM CEST Taeung Song wrote: Hi, The --source-only option and new source code TUI view can show the result of performance analysis based on

Re: [PATCH/RFC 1/4] perf annotate: Add --source-only option

Thank you for detailed review. On 06/30/2017 12:18 AM, Namhyung Kim wrote: Resend with a proper mail address.. On Fri, Jun 30, 2017 at 12:14 AM, Namhyung Kim wrote: Hi Taeung, Thanks for doing this work! On Wed, Jun 28, 2017 at 12:14 PM, Taeung Song wrote: The option can show the result

Re: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view

I'm late.. On 06/28/2017 06:53 PM, Milian Wolff wrote: On Wednesday, June 28, 2017 5:18:08 AM CEST Taeung Song wrote: Hi, The --source-only option and new source code TUI view can show the result of performance analysis based on full source code per symbol(function). (Namhyung Kim to

[PATCH 2/4] perf anntoate browser: Fix the toggle total period view to show period, not number of samples

ow. Event count│ │ │ │Disassembly of section .text: │ │00109a90 <_mcount@@GLIBC_2.2.5>: │ sub$0x38,%rsp 2204022 │ mov%rax,(%rsp) 2207405 │ mov%rcx,0x8(%rsp) Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa

[PATCH 4/4] perf annotate browser: Support the toggle number of samples

Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 0ddc3b2..237903d

[PATCH 0/4] perf annotate: Fix --show-total-period and support --show-nr-samples

otate stdio and TUI browser. And support --show-nr-samples into perf-anntate so that it correpond with perf-report's. The code is available on 'perf/ann-fix-period' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung Taeung Song (4): perf annotate: Fix wrong --sh

[PATCH 3/4] perf annotate: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Additionally h->sum is properly renamed h->nr_samples. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/ui/gtk/anno

[PATCH 1/4] perf annotate: Fix wrong --show-total-period option showing number of samples

(84813704 event count) -- : : : : Disassembly of section .text: : : 00400816 : : knapsack(): 743737 :400816: push %rbp Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song

[QUESTION] perf annotate: how do we fix the 'total period' feature ?

Hi, Two problems of perf-annotate were mentioned in recent PATCH reviews by Milian and Namhyung. Currently perf-annotate has a '--show-total-period' option and a 't' key "Toggle total period view" on TUI browser. However, they actually show the number of samples, not period(Raw number of event

Re: [QUESTION] perf annotate: how do we fix the 'total period' feature ?

Hi Namhyung :) On 07/05/2017 03:07 PM, Namhyung Kim wrote: Hi Taeung, On Wed, Jul 5, 2017 at 2:47 PM, Taeung Song wrote: Hi, Two problems of perf-annotate were mentioned in recent PATCH reviews by Milian and Namhyung. Currently perf-annotate has a '--show-total-period' option and

Re: [PATCH v2 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples

Hi Namhyung, I'm late. Thanks for your review. On 07/19/2017 01:07 AM, Namhyung Kim wrote: Hi Taeung, On Fri, Jul 14, 2017 at 02:45:44AM +0900, Taeung Song wrote: Hello, Currently the --show-total-period option of perf-annotate is different from perf-report's. It has two problem

Re: [PATCH v2 8/9] perf annotate browser: Support the toggle number of samples with a 'e' hotkey

On 07/19/2017 01:18 AM, Namhyung Kim wrote: On Fri, Jul 14, 2017 at 02:46:16AM +0900, Taeung Song wrote: Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song Hmm.. IIUC there're 3 modes of annotation view: percent, period and sample, right? The existing '

Re: [PATCH v2 9/9] perf annotate: Use the sample period when calculating the percentage

On 07/19/2017 01:23 AM, Namhyung Kim wrote: On Fri, Jul 14, 2017 at 02:46:20AM +0900, Taeung Song wrote: Currently the percentages of perf-annotate are calculated with number of samples, not the sample period. So fix it to correspond with perf-report using the sample period for the

[PATCH v3 1/9] perf annotate: Introduce struct sym_hist_entry

struct sym_hist has addr[] but it should have not only number of samples but also the sample period. So use new struct symhist_entry for that. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 6 +++--- tools/perf/ui/gtk/annotate.c | 4

[PATCH v3 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples

I browser (Arnaldo) - Calculate the percentage with 'period', not number of samples Taeung Song (9): perf annotate: Introduce struct sym_hist_entry perf annotate: Properly rename 'sum' to 'total_samples' in struct sym_hist perf annotate: Fix wrong --show-total

[PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

section .text: : : 00400816 : : knapsack(): 743737 :400816: push %rbp Reported-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 4 +--- tools/perf/builtin-report.c | 13 ++---

[PATCH v3 6/9] perf annotate browser: Show the proper header when using --show-total-period

Currently a first column is only "Percent", so fix it to show correct column name based on given options. (e.g. if using --show-total-period or a 't' hotkey, show "Event count" as a first column) Reported-by: Milian Wolff Cc: Namhyung Kim Cc: Jiri Olsa Signed-o

[PATCH v3 8/9] perf annotate browser: Circulate percent, total period, samples view

Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 7800fe2..8ecc519 100644 --- a/tools/perf/ui/browsers/ann

[PATCH v3 9/9] perf annotate: Use the sample period when calculating the percentage

Currently the percentages of perf-annotate are calculated with number of samples, not the sample period. So fix it to correspond with perf-report using the sample period for the calculation. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 23

[PATCH v3 5/9] perf anntoate browser: Fix the toggle total period view to show period, not number of samples

$0x38,%rsp 2204022 │ mov%rax,(%rsp) 2207405 │ mov%rcx,0x8(%rsp) Reported-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/t

[PATCH v3 7/9] perf annotate: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH v3 4/9] perf annotate: Show the proper header when using --show-total-period

Currently a first column is only "Percent", so fix it to show correct column name based on given options. (e.g. if using --show-total-period, show "Event count" as a first column) Reported-by: Milian Wolff Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song

[PATCH v3 2/9] perf annotate: Properly rename 'sum' to 'total_samples' in struct sym_hist

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/gtk/annotate.c | 2 +- tools/perf/util/annotate.c | 22 +++--- tools/perf/util/annotate.h | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/perf/ui/gtk/annotate.c b

[RESEND PATCH v3 9/9] perf annotate: Calculate the percentage with period or number of samples

To correspond with perf-report using the sample period for the percentage calculation, calculate the percentage with period. But if --show-nr-samples was used, figure out the percentage by number of samples. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util

Re: [PATCH v3 2/9] perf annotate: Properly rename 'sum' to 'total_samples' in struct sym_hist

Hi Arnaldo, On 07/21/2017 04:13 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 20, 2017 at 06:36:51AM +0900, Taeung Song escreveu: Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song Better to rename it to symhist->nr_samples, to be consistent with the per address nr_samples,

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu: Currently the --show-total-period option of perf-annotate is different from perf-report's. For example, perf-report ordinarily shows period and number of sa

Re: [PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

Thank you !! :) - Taeung On 09/08/2017 11:36 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Sep 07, 2017 at 12:18:56PM +0900, Taeung Song escreveu: When there isn't a config file (e.g. ~/.perfconfig) or it has nothing, the config set wasn't created. If the config set not exists, a c

[PATCH v5 2/3] perf config: Once write a config file in the end, not a repeat

ff-by: Taeung Song --- tools/perf/builtin-config.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index a1d82e3..b89417d 100644 --- a/tools/perf/builtin-config.c +++ b/tools/perf/builtin-config.c @@

[PATCH v5 0/3] perf config: Simple bugfixes & refactoring

(Aranaldo) - return -1 if show_spec_config() cannot show the config - initialize 'ret' with -1 instead of 0 for more compact code in cmd_config() - Add a error message when perf_config_set__new() failed in cmd_config() v2: - there is no need to consider empty config file (Arnaldo) Taeung Song

[PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

f cmd_config(). Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/config.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index bc75596..d2b6983 100644 --- a/tools/perf/util/config.c

[PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's

Currently only section->from_system_config is being checked multiple times. items->from_system_config should be also checked, so fix it. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v3 1/5] perf annotate stdio: Support --show-nr-samples option

On 08/18/2017 10:33 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:46:48PM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So, at this point I tried to test it and forgot this was just about --stdio, which

Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

On 08/18/2017 11:17 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu: Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song Ok, now that check for !--stdio is lifted and replaced with: - if (symbol_conf.show_nr_samples

Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu: With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below:

Re: [PATCH] perf probe: Fix examples section of documentation

Hi SeongJae, Nice to see you :) On 05/07/2017 07:36 PM, SeongJae Park wrote: An example in perf-probe documentation for pattern of function name based probe addition is not providing example command for the case. This commit fixes the example to give appropriate example command. Signed-off-by:

[PATCH v2 0/4] perf config: Bugfixes & Refactoring

eed to consider empty config file (Arnaldo) Taeung Song (4): perf config: Invert a if statement to reduce nesting in cmd_config() perf config: Finally write changed configs on config file at a time perf config: Correctly check whether it is from system config perf config: Automatically create

[PATCH v2 3/4] perf config: Correctly check whether it is from system config

Currently section's from_system_config was checked twice. So adjust it in order to correctly check not only section's but also item's from_system_config. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1

[PATCH v2 4/4] perf config: Automatically create config file if not exists when setting config

t__init() failed, it'll be freed at the tail end (i.e. by perf_config_set__delete() at the end of cmd_config()). Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/config.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/conf

[PATCH v2 1/4] perf config: Invert a if statement to reduce nesting in cmd_config()

Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 44 +++- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index 80668fa..7545966 100644

[PATCH v2 2/4] perf config: Finally write changed configs on config file at a time

Currently set_config() can be repeatedly called for each input config on the below case: $ perf config kmem.default=slab report.children=false ... But it's a waste, so finally write changed configs at a time. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/bu

Re: [PATCH v2 3/4] perf config: Correctly check whether it is from system config

Hi Arnaldo, On 05/09/2017 01:39 AM, Arnaldo Carvalho de Melo wrote: Em Mon, May 08, 2017 at 08:07:45PM +0900, Taeung Song escreveu: Currently section's from_system_config was checked twice. you mean: "The item->from_system_config is not being checked when iterating over s

Re: [PATCH v2 2/4] perf config: Finally write changed configs on config file at a time

On 05/09/2017 01:37 AM, Arnaldo Carvalho de Melo wrote: Em Mon, May 08, 2017 at 08:07:40PM +0900, Taeung Song escreveu: Currently set_config() can be repeatedly called for each input config on the below case: $ perf config kmem.default=slab report.children=false ... But it's a wast

Re: [PATCH v2 4/4] perf config: Automatically create config file if not exists when setting config

On 05/09/2017 01:41 AM, Arnaldo Carvalho de Melo wrote: Em Mon, May 08, 2017 at 08:07:49PM +0900, Taeung Song escreveu: When setting config key-value pairs, if user or system config files are nonexistent, currently perf-config's setting didn't work right. "currently doesn&#

[PATCH v3 2/7] perf config: Refactor the code using 'ret' variable in cmd_config()

To simplify the code related to 'ret' variable in cmd_config(), initialize 'ret' with -1 instead of 0 and use goto statement 'out_err'. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 30 +-

[PATCH v3 4/7] perf config: Add a error message when perf_config_set__new() failed in cmd_config()

Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index 6a4d8cd..e9fe673 100644 --- a/tools/perf/builtin-config.c +++ b/tools

[PATCH v3 1/7] perf config: Handle errors from {show_spec, set}_config() in the loop

show_spec_config() and set_config() in the loop in cmd_config() and if the return value means a error, handle it. Cc: Jiri Olsa Cc: Namhyung Kim Reported-by: Arnaldo Carvalho de Melo Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 17 +++-- 1 file changed, 15 insertions(+), 2

[PATCH v3 0/7] perf config: Bugfixes & Refactoring

fig_set__new() failed in cmd_config() v2: - there is no need to consider empty config file (Arnaldo) Taeung Song (7): perf config: Handle errors from {show_spec, set}_config() in the loop perf config: Refactor the code using 'ret' variable in cmd_config() perf config: Return -1 if sho

[PATCH v3 3/7] perf config: Return -1 if show_spec_config() cannot show the config

If the config isn't found in the config set, show_spec_config() cannot show the config. But it return 0 on the situation though, so fix it. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 5/7] perf config: Finally write changed configs on config file at a time

Currently set_config() can be repeatedly called for each input config on the below case: $ perf config kmem.default=slab report.children=false ... But it's a waste, so finally write changed configs at a time. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/bu

[PATCH v3 6/7] perf config: Check whether items are from system config in set_config()

ng Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index f62cc2d..34ebe83 100644 --- a/tools/perf/builtin-config.c +++ b/tools/perf/builtin-config.c @@ -56,7

[PATCH v3 7/7] perf config: Support autogeneration of config file when setting configs

auto-generated. [report] children = false NOTE: The config set will be freed at the tail end. (i.e. by perf_config_set__delete() at the end of cmd_config()) Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/config.c | 5 + 1 file changed, 1 insertio

Re: [PATCH 2/7] perf config: Check list empty before showing configs

Hi Arnaldo, On 05/03/2017 12:12 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Apr 26, 2017 at 09:21:03PM +0900, Taeung Song escreveu: If existent config files contains nothing, the sections list in config_set can be empty. So check not only NULL pointer of config_set but also the list in

[PATCH] perf record: Remove a disused option '-l'

Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-record.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 68a1ffb..5a626ef 100644 --- a/tools/perf

[PATCH RESEND] perf record: Fix documentation for a disused option '-l'

Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-record.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 68a1ffb..5a626ef 100644 --- a/tools/perf

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

Hi Arnaldo, Sorry, I'm too late. On 07/21/2017 08:24 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu: On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu: Currentl

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

On 07/25/2017 02:37 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jul 24, 2017 at 10:51:58AM +0900, Taeung Song escreveu: Hi Arnaldo, Sorry, I'm too late. On 07/21/2017 08:24 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu: On 07/21/20

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

Hi Arnaldo, On 07/25/2017 11:42 PM, Arnaldo Carvalho de Melo wrote: Em Tue, Jul 25, 2017 at 06:28:42AM +0900, Taeung Song escreveu: On 07/25/2017 02:37 AM, Arnaldo Carvalho de Melo wrote: The one above, look further down, from 896bccd3cb8d to 0321d0281cbb, there are some more missing, but the

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So this is not that intuitive, i.e. if one ask for: perf annotate --show-total

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So this is not that intuitive, i.e. if one ask for: perf annotate --show-total

Re: [PATCH v4 3/9] perf anntoate browser: Fix the toggle total period view showing number of samples

On 07/28/2017 01:57 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:02AM +0900, Taeung Song escreveu: Currently the toggle total period view on the annotate TUI shows the number of samples, not period like below. So fix the toggle total period view on the annotate TUI like

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

Hi Arnaldo, On 08/01/2017 03:24 PM, Taeung Song wrote: On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So this is not that

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

On 08/15/2017 01:31 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Aug 14, 2017 at 07:42:07PM +0900, Taeung Song escreveu: On 08/01/2017 03:24 PM, Taeung Song wrote: On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add

[PATCH v2 2/4] perf annotate: Period and samples view can't be used at the same time

If users give two options --show-total-period and --show-nr-samples, show their proper usage because the two options can not be used at the same time. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v2 3/4] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

[PATCH v2 0/4] perf annotate: Support --show-nr-samples and circulating view

7;d appreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung v2: - period and nr-samples view can't be used at the same time (Arnaldo) Taeung Song (4): perf annotate stdio: Sup

[PATCH v2 1/4] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH v2 4/4] perf annotate browser: Circulate percent, total period and samples view

With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-

[PATCH 2/3] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

[PATCH 3/3] perf annotate browser: Circulate percent, total period and samples view

With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-

[PATCH 1/3] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH 0/3] perf annotate: Support --show-nr-samples and circulating view

7;d appreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung Taeung Song (3): perf annotate stdio: Support --show-nr-samples option perf annotate browser: Support --show-nr-sample

[PATCH v4 5/5] perf config: Autogenerate a config file if it does not exist on setting feature.

. (i.e. by perf_config_set__delete() at the end of cmd_config()) Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/config.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 8d724f0..1cc5d80

[PATCH v4 4/5] perf config: Check not only section->from_system_config but also item's

Currently only section->from_system_config is being checked multiple times. items->from_system_config should be also checked, so fix it. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v4 3/5] perf config: Finally write changed configs on config file at a time

Currently set_config() can be repeatedly called for each input config on the below case: $ perf config kmem.default=slab report.children=false ... But it's a waste, so finally write changed configs at a time. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/bu

[PATCH v4 2/5] perf config: Refactor the code using 'ret' variable in cmd_config()

To simplify the code related to 'ret' variable in cmd_config(), initialize 'ret' with -1 instead of 0. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 30 +- 1 file changed, 13 insertions(+), 17 deleti

[PATCH v4 1/5] perf config: Check error cases of {show_spec, set}_config()

show_spec_config() and set_config() can be called multiple times in the loop in cmd_config(). However, The error cases of them wasn't checked, so fix it. Reported-by: Arnaldo Carvalho de Melo Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c

[PATCH v4 0/5] perf config: Bugfixes & Refactoring

#x27; with -1 instead of 0 for more compact code in cmd_config() - Add a error message when perf_config_set__new() failed in cmd_config() v2: - there is no need to consider empty config file (Arnaldo) Taeung Song (5): perf config: Check error cases of {show_spec, set}_config() perf config: Ref

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

Hello Arnaldo :) On 07/26/2017 01:17 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Jul 26, 2017 at 12:53:28AM +0900, Taeung Song escreveu: On 07/25/2017 11:42 PM, Arnaldo Carvalho de Melo wrote: Moreover there is the below case that is not aligned due to big period values. So, that "mor

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

On 07/27/2017 05:17 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Jul 26, 2017 at 08:57:13PM +0900, Taeung Song escreveu: On 07/26/2017 01:17 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Jul 26, 2017 at 12:53:28AM +0900, Taeung Song escreveu: On 07/25/2017 11:42 PM, Arnaldo Carvalho de Melo

[PATCH v4 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples

27;t switch 'the total period view' to 'the number of samples view' on the annotate TUI browser (Arnaldo) - Calculate the percentage with 'period', not number of samples Taeung Song (9): perf annotate: Widen "Event count" column when using --show-total-per

[PATCH v4 1/9] perf annotate: Widen "Event count" column when using --show-total-period

Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index c2b4b00..5963764 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf

[PATCH v4 3/9] perf anntoate browser: Fix the toggle total period view showing number of samples

$0x38,%rsp 2204022 │ mov%rax,(%rsp) 2207405 │ mov%rcx,0x8(%rsp) Reported-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/t

[PATCH v4 4/9] perf annotate browser: Show the proper header when using --show-total-period

Currently a first column is only "Percent", so fix it to show correct column name based on given options. (e.g. if using --show-total-period or a 't' hotkey, show "Event count" as a first column) Reported-by: Milian Wolff Cc: Namhyung Kim Cc: Jiri Olsa Signed-o

[PATCH v4 2/9] perf annotate: Initialize proper width for first column

When using --show-total-period or not, set the width value for first column. Suggested-by: Arnaldo Carvalho de Melo Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util

[PATCH v4 6/9] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 9fd4413..6b57e87 100644 --- a/tools

[PATCH v4 7/9] perf annotate browser: Circulate percent, total period, samples view

Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 6b57e87..6c4db1d 100644 --- a/tools/perf/ui/browsers/annotate.c

[PATCH v4 9/9] perf annotate: Calculate the percentage with period or number of samples

To correspond with perf-report using the sample period for the percentage calculation, calculate the percentage with period. But if --show-nr-samples was used, figure out the percentage by number of samples. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util

[PATCH v4 8/9] perf annotate: Check total period before calculating percent

Before calculating percent, checking total period is clear and safer than checking just number of samples. So fix it. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf

[PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH v8 1/7] perf config: Introduce default_config_section and default_config_item for default config key-value pairs

lt perf config values at one spot (i.e. util/config.c) with default config arrays and it could be easy and simple to modify existing default config values or add default values for new config item. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hira

[PATCH v8 0/7] perf config: Introduce default config key-value pairs arrays

__config_colors' (Arnaldo) - change 'ground colors' to '{back, fore}ground colors' (Arnaldo) - use strtok + ltrim instead of strchr and while (isspace(*++bg)); (Arnaldo) Taeung Song (7): perf config: Introduce default_config_section and default_config_item for defau

[PATCH v8 4/7] perf config: Use combined {fore,back}ground colors value instead of each two color

(as just one). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 53 +++-- 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui

[PATCH v8 7/7] perf config: Initialize annotate_browser__opts with default config items

Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 16 tools/perf/util/config.h | 3 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b

[PATCH v8 2/7] perf config: Add macros assigning key-value pairs to default_config_item

: Masami Hiramatsu Signed-off-by: Taeung Song --- tools/perf/util/config.h | 20 1 file changed, 20 insertions(+) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 1fd8e4c..613900f 100644 --- a/tools/perf/util/config.h +++ b/tools/perf/util/config.h

[PATCH v8 5/7] perf config: Initialize ui_browser__colorsets with default config items

Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 1c80f00..5caa7e4 100644 --- a/tools/perf/ui

[PATCH v8 6/7] perf config: Add default section and item arrays for 'annotate' config

annoate.c because of setting default values of actual variables for 'annotate' config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/util/config.c | 11 +++ tools/perf/util/config.h | 11 +++ 2 files c

[PATCH v8 3/7] perf config: Add default section and item arrays for 'colors' config

be used on ui/browser.c because of setting default values of actual variables for 'colors' config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/util/config.c | 15 +++ tools/perf/util/config.h | 17

[tip:perf/core] perf config: Refactor the code using 'ret' variable in cmd_config()

Commit-ID: dfe1c6d7efa8ead6878b73216d4c891a28207528 Gitweb: http://git.kernel.org/tip/dfe1c6d7efa8ead6878b73216d4c891a28207528 Author: Taeung Song AuthorDate: Sat, 17 Jun 2017 12:46:42 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 19 Jun 2017 22:05:55 -0300 perf config

<    3   4   5   6   7   8   9   >