[PATCH v7 7/7] perf config: Initialize annotate_browser__opts with default config items

Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 16 tools/perf/util/config.h | 3 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b

[PATCH v7 1/7] perf config: Introduce default_config_section and default_config_item for default config key-value pairs

lt perf config values at one spot (i.e. util/config.c) with default config arrays and it could be easy and simple to modify existing default config values or add default values for new config item. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hira

[PATCH v7 2/7] perf config: Add macros assigning key-value pairs to default_config_item

: Masami Hiramatsu Signed-off-by: Taeung Song --- tools/perf/util/config.h | 20 1 file changed, 20 insertions(+) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 1fd8e4c..613900f 100644 --- a/tools/perf/util/config.h +++ b/tools/perf/util/config.h

[PATCH v7 5/7] perf config: Initialize ui_browser__colorsets with default config items

Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 1c80f00..5caa7e4 100644 --- a/tools/perf/ui

[PATCH v6 RESEND 1/7] perf config: Introduce default_config_section and default_config_item for default config key-value pairs

lt perf config values at one spot (i.e. util/config.c) with default config arrays and it could be easy and simple to modify existing default config values or add default values for new config item. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hira

[PATCH v6 RESEND 0/7] perf config: Introduce default config key-value pairs arrays

erf_default_config_init() that call all default_*_config_init() for each config section v2: - rename 'ui_browser__config_gcolors' to 'ui_browser__config_colors' (Arnaldo) - change 'ground colors' to '{back, fore}ground colors' (Arnaldo) - use strtok + ltr

[PATCH v6 RESEND 2/7] perf config: Add macros assigning key-value pairs to default_config_item

: Masami Hiramatsu Signed-off-by: Taeung Song --- tools/perf/util/config.h | 20 1 file changed, 20 insertions(+) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 1fd8e4c..613900f 100644 --- a/tools/perf/util/config.h +++ b/tools/perf/util/config.h

[PATCH v6 RESEND 5/7] perf config: Initialize ui_browser__colorsets with default config items

Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 31e2028..598f434 100644 --- a/tools/perf/ui

[PATCH v6 RESEND 6/7] perf config: Add default section and item arrays for 'annotate' config

annoate.c because of setting default values of actual variables for 'annotate' config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/util/config.c | 11 +++ tools/perf/util/config.h | 11 +++ 2 files changed,

[PATCH v6 RESEND 3/7] perf config: Add default section and item arrays for 'colors' config

ui/browser.c because of setting default values of actual variables for 'colors' config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/util/config.c | 15 +++ tools/perf/util/config.h | 17 +

[PATCH v6 RESEND 4/7] perf config: Use combined {fore,back}ground colors value instead of each two color

f values (as just one). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 53 +++-- 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/tools/perf/ui/browser.c b/tools

[PATCH v6 RESEND 7/7] perf config: Initialize annotate_browser__opts with default config items

Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 16 tools/perf/util/config.h | 3 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b

Re: [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

On 06/07/2016 05:23 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jun 06, 2016 at 07:52:53PM +0900, Taeung Song escreveu: Because of die() at perf_parse_file() a config set was freed in collect_config(), if failed. But it is natural to free a config set after collect_config() is done when some

[BUGFIX][RESEND PATCH v6] perf config: If collect_config() is failed, finally free a config set after it is done

set in collect_config(). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index

Re: [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

On 06/07/2016 06:37 AM, Taeung Song wrote: On 06/07/2016 05:23 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jun 06, 2016 at 07:52:53PM +0900, Taeung Song escreveu: Because of die() at perf_parse_file() a config set was freed in collect_config(), if failed. But it is natural to free a config

[RFC][PATCH v7 0/9] perf config: Reimplement perf_config() using perf_config_set__inter()

t config set when only 'config' sub-commaned work because of options for config file location Taeung Song (7): perf config: If collect_config() is failed, finally free a config set after it is done perf config: Use new perf_config_set__init() to initialize c

[PATCH v7 5/7] perf config: Reimplement perf_config() using perf_config_set__iter()

Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/perf.c| 1 + tools/perf/util/cache.h | 1 + tools/perf/util/config.c | 86 +++- 3 files changed, 43 insertions(+

[PATCH v7 6/7] perf config: Reset the config set at only 'config' sub-command

th the options, the config set should be reset at the very beginning at cmd_config() Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/perf/builti

[PATCH v7 7/7] perf config: Reimplement show_config() using perf_config()

: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index 4dab41e..b6ae8ea 100644 --- a/tools/perf/builtin

[PATCH v7 3/7] perf config: Add global variable 'config_set'

handled in perf_config() and other functions at util/config.c Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 9 - tools/perf/util/config.c| 1 + tools/perf/util/config.h| 2 ++ 3 files changed

[BUGFIX][PATCH v7 1/7] perf config: If collect_config() is failed, finally free a config set after it is done

set in collect_config(). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index

[PATCH v7 4/7] perf config: Use zfree() instead of free() at perf_config_set__delete()

#x27;struct perf_config_set *'. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- tools/perf/util/config.c| 11 +++ tools/perf/util/config.h| 2 +- 3 files changed, 9 insertion

[PATCH v7 2/7] perf config: Use new perf_config_set__init() to initialize config set

config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 47 ++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/config.c b/tools/perf

Re: [PATCH v7 3/7] perf config: Add global variable 'config_set'

Good afternoon :) On 06/07/2016 11:05 PM, Arnaldo Carvalho de Melo wrote: Em Tue, Jun 07, 2016 at 06:26:13PM +0900, Taeung Song escreveu: The config set is prepared by collecting all configs from config files (i.e. user config ~/.perfconfig and system config $(sysconfdir)/perfconfig) so the

Re: [GIT PULL 00/24] perf/core improvements and fixes

rastructure: - Make tools/lib/bpf use the IS_ERR return facility consistently and also stop using the _get_ term for non-reference count methods (Arnaldo Carvalho de Melo) - 'perf config' refactorings (Taeung Song) Signed-off-by: Arnaldo Carvalho de Melo -

Re: [RFC PATCH v5 0/7] perf config: Introduce default config key-value pairs arrays

ems' instead of using 'struct list_head items') could you agree this way ? Thanks, Taeung On 07/06/2016 02:20 PM, Taeung Song wrote: Hello, :) When initializing default perf config values, we currently use values of actual type(int, bool, char *, etc.). But I suggest using d

Re: [RFC PATCH v5 0/7] perf config: Introduce default config key-value pairs arrays

On 07/12/2016 02:37 PM, Namhyung Kim wrote: Hi Taeung, On Tue, Jul 12, 2016 at 01:20:35PM +0900, Taeung Song wrote: Hi, Namhyung :) As you know, the patch work from v3 to v4 took too long time because of a patchset refactoring perf_config(). So I guess it is hard for you to recall this

Re: [PATCH v5 5/7] perf config: Initialize ui_browser__colorsets with default config items

On 07/12/2016 02:39 PM, Namhyung Kim wrote: On Wed, Jul 06, 2016 at 02:20:21PM +0900, Taeung Song wrote: Set default config values for 'colors' section with 'colors_config_items[]' instead of actual const char * type values. (e.g. using colors_config_item[CONFIG_COLORS_T

Re: [PATCH v5 7/7] perf config: Initialize annotate_browser__opts with default config items

On 07/12/2016 02:47 PM, Namhyung Kim wrote: On Wed, Jul 06, 2016 at 02:20:23PM +0900, Taeung Song wrote: Set default config values for 'annotate' section with 'annotate_config_items[]' instead of actual bool type values. (e.g. using annotate_config_items[CONFIG_ANNOTA

[PATCH v6 2/7] perf config: Add macros assigning key-value pairs to default_config_item

: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.h | 20 1 file changed, 20 insertions(+) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 1fd8e4c..613900f 100644 --- a/tools/perf/util/config.h +++ b/tools

[RFC PATCH v6 0/7] perf config: Introduce default config key-value pairs arrays

hat call all default_*_config_init() for each config section v2: - rename 'ui_browser__config_gcolors' to 'ui_browser__config_colors' (Arnaldo) - change 'ground colors' to '{back, fore}ground colors' (Arnaldo) - use strtok + ltrim instead of strchr and while (isspac

[PATCH v6 3/7] perf config: Add default section and item arrays for 'colors' config

ui/browser.c because of setting default values of actual variables for 'colors' config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 15 +++ tools/perf/util/con

[PATCH v6 4/7] perf config: Use combined {fore,back}ground colors value instead of each two color

f values (as just one). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 53 +++-- 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/too

[PATCH v6 1/7] perf config: Introduce default_config_section and default_config_item for default config key-value pairs

amatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.h | 29 + 1 file changed, 29 insertions(+) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 6f813d4..1fd8e4c 100644 --- a/tools/perf/util/config.h +++ b/too

[PATCH v6 5/7] perf config: Initialize ui_browser__colorsets with default config items

Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/ui/browser.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c index 31e2028..598f434 10

[PATCH v6 7/7] perf config: Initialize annotate_browser__opts with default config items

Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 16 tools/perf/util/config.h | 3 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tools/perf

[PATCH v6 6/7] perf config: Add default section and item arrays for 'annotate' config

annoate.c because of setting default values of actual variables for 'annotate' config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Wang Nan Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 11 +++ tools/perf/util/config.h | 11 ++

Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

Good evening :) On 06/11/2016 04:06 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jun 10, 2016 at 03:20:43PM +0900, Taeung Song escreveu: On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote: +++ b/tools/perf/util/cache.h @@ -7,6 +7,7 @@ #include +#include "config.h" Why have

Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

do, I'd individually send patches for this problem.) Thanks, Taeung On 06/11/2016 09:59 AM, Taeung Song wrote: Good evening :) On 06/11/2016 04:06 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jun 10, 2016 at 03:20:43PM +0900, Taeung Song escreveu: On 06/09/2016 10:29 PM, Arnaldo Carval

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

a sub-command work. And the config set that is made by perf_config_set__new() would be reused when we initialize all actual config variables and then if using is is finished, we could free the config set. Thanks, Taeung On 06/10/2016 07:58 PM, Taeung Song wrote: On 06/09/2016 10:34 PM, Arnaldo

[PATCH v6 4/9] perf config: Use new perf_config_set__init() to initialize config set

config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 49 +++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/config.c b/tools/perf

[RFC][PATCH v6 0/9] perf config: Reimplement perf_config() using perf_config_set__inter()

rf_config_set__delete using global variable 'config_set' - reset config set when only 'config' sub-commaned work because of options for config file location Taeung Song (9): perf config: Fix the problem of abnormal termination at perf_parse_file() perf config: If collec

[BUGFIX][PATCH v6 1/9] perf config: Fix the problem of abnormal termination at perf_parse_file()

nfig values. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index dad7d

[PATCH v6 6/9] perf config: Use zfree() instead of free() at perf_config_set__delete()

#x27;struct perf_config_set *'. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- tools/perf/util/config.c| 11 +++ tools/perf/util/config.h| 2 +- 3 files changed, 9 insertion

[PATCH v6 7/9] perf config: Reimplement perf_config() using perf_config_set__iter()

Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/perf.c| 1 + tools/perf/util/cache.h | 1 + tools/perf/util/config.c | 86 +++- 3 files changed, 43 insertions(+

[PATCH v6 8/9] perf config: Reset the config set at only 'config' sub-command

th the options, the config set should be reset at the very beginning at cmd_config() Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/perf/builti

[PATCH v6 9/9] perf config: Reimplement show_config() using perf_config()

: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index 4dab41e..b6ae8ea 100644 --- a/tools/perf/builtin

[BUGFIX][PATCH v6 3/9] perf config: Handle the error when config set is NULL at collect_config()

Signed-off-by: Taeung Song --- tools/perf/util/config.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index d013f90..062eeb8 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -607,8 +607,12 @@

[PATCH v6 5/9] perf config: Add global variable 'config_set'

handled in perf_config() and other functions at util/config.c Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 9 - tools/perf/util/config.c| 1 + tools/perf/util/config.h| 2 ++ 3 files changed

[BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

set in collect_config(). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index b500737

Re: [PATCH v4 1/6] perf config: Use new perf_config_set__init() to initialize config set

Hi, Arnaldo :) Did you have a nice weekend? I sent this mail for nothing else but to tell the reason of v6 to you. On 06/01/2016 01:52 AM, Taeung Song wrote: On 05/31/2016 10:43 PM, Arnaldo Carvalho de Melo wrote: Em Tue, May 31, 2016 at 10:13:43AM +0900, Taeung Song escreveu: Instead of

Re: [RFC][PATCH] perf config: Introduce perf_config_set class

Hi, Namhyung On 03/11/2016 11:11 PM, Namhyung Kim wrote: Hi Taeung, On Thu, Mar 10, 2016 at 11:04:27PM +0900, Taeung Song wrote: In order to variously handle config key-value pairs, prepare all default configs and collect config key-value pairs from user and system config files (i.e user wide

Re: [RFC][PATCH] perf config: Introduce perf_config_set class

On 03/12/2016 05:45 PM, Namhyung Kim wrote: Hi Taeung, On Sat, Mar 12, 2016 at 12:08:52AM +0900, Taeung Song wrote: Hi, Namhyung On 03/11/2016 11:11 PM, Namhyung Kim wrote: Also I think it'd be better just keeping a single config value instead of 3 kinds. Maybe you can read system

[PATCH v2 1/5] perf config: Introduce perf_config_set class

ff-by: Taeung Song --- tools/perf/builtin-config.c | 1 + tools/perf/util/config.c| 123 tools/perf/util/config.h| 21 3 files changed, 145 insertions(+) create mode 100644 tools/perf/util/config.h diff --git a/tools/perf/builtin-confi

[RFC][PATCH v2 0/5] perf config: Introduce perf_config_set class

, etc. Taeung Song (5): perf config: Introduce perf_config_set class perf config: Let show_config() work with perf_config_set perf config: Prepare all default configs perf config: Initialize perf_config_set with all default configs perf config: Add 'list-all' option to show all perf

[PATCH v2 2/5] perf config: Let show_config() work with perf_config_set

config --user --list top.children=false # perf config --system --list top.children=true # perf config --list top.children=false Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 31 --- 1 file changed, 24

[PATCH v2 4/5] perf config: Initialize perf_config_set with all default configs

correct type of a config variable in the near future. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 11 +++ tools/perf/util/config.c| 27 ++- tools/perf/util/config.h| 6 ++ 3 files changed, 35

[PATCH v2 5/5] perf config: Add 'list-all' option to show all perf's configs

..(omitted).. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 +++ tools/perf/builtin-config.c | 69 +++- 2 files changed, 74 insertions(+), 1 deletion(-) diff --git a/tools/perf

[PATCH v2 3/5] perf config: Prepare all default configs

g Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/config.c | 54 ++--- tools/perf/util/config.h | 89 ++-- 2 files changed, 137 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf

[PATCH] perf subcmd: Bugfix exactly compare long name of options to avoid repeat output.

potential probe-able functions. -l, --list <[GROUP:]EVENT> list up probe events # perf config --list-all --list Error: option `list' cannot be used with list-all Usage: perf config [] [options] -l, --listshow current

Re: [PATCH v11 17/24] perf config: Collect configs to handle config variables

7; 5) 'configset' 6) 'config_set' ... :-\ It is trivial question, but I wanna know a opinion of other people. :-) Thanks, Taeung On 11/18/2015 02:15 PM, Namhyung Kim wrote: On Tue, Nov 17, 2015 at 10:53:37PM +0900, Taeung Song wrote: Collecting configs into list because of tw

Re: [PATCH v11 17/24] perf config: Collect configs to handle config variables

On 03/04/2016 10:58 PM, Namhyung Kim wrote: Hi Taeung, On Fri, Mar 04, 2016 at 09:45:44PM +0900, Taeung Song wrote: Hi, Namhyung and all (I'm modifying this patch to be tidy) I have a mere question about name of a variable for current config list that contains section list which ha

[PATCH v2] perf subcmd: Bugfix more exactly handle the error about 'PARSE_OPT_EXCLUSIVE'

nfig --list-all --list Error: option `list' cannot be used with list-all Usage: perf config [] [options] -l, --listshow current config variables -a, --list-allshow current and all possible config variables with default values Cc: Namhyung Kim Cc: J

Re: [PATCH] perf config: Tidy up the code setting buildid dir

Hi, jirka Thank you for your review :-) On 03/27/2016 08:16 PM, Jiri Olsa wrote: On Thu, Mar 24, 2016 at 04:49:33PM +0900, Taeung Song wrote: Add new perf_buildid_config() into perf_default_config, bring set_buildid_dir() next to perf_default_config, rename some variable name as more readable

[PATCH 2/3] perf config: Rework buildid_dir_command_config to perf_buildid_config

To avoid repeated calling perf_config() remove buildid_dir_command_config() and add new perf_buildid_config into perf_default_config. Because perf_config() is already called with perf_default_config at main(). Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Signed-off-by: Taeung Song --- tools

[PATCH 3/3] perf config: Rename 'v' to 'home' at set_buildid_dir

Change a variable name 'v' to 'home' to be more readable name. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/config.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/co

[PATCH 1/3] perf config: Remove duplicated the code calling set_buildid_dir

Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/perf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/perf.c b/tools/perf/perf.c index aaee0a7..7b2df2b 100644 --- a/tools/perf/perf.c +++ b/tools/perf/perf.c @@ -549,6 +549,7 @@ int main

Re: [PATCH 1/3] perf config: Remove duplicated the code calling set_buildid_dir

Hi, jirka and Arnaldo On 03/29/2016 05:59 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Mar 28, 2016 at 09:52:42PM +0200, Jiri Olsa escreveu: On Mon, Mar 28, 2016 at 02:22:18AM +0900, Taeung Song wrote: Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song for the patchset: Acked-by

Re: [PATCH v3 1/4] perf config: Introduce perf_config_set class

On 03/29/2016 06:06 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Mar 24, 2016 at 03:46:00PM +0900, Taeung Song escreveu: Hi, Namhyung On 03/24/2016 03:07 PM, Namhyung Kim wrote: Hi Taeung, On Thu, Mar 24, 2016 at 05:16:30AM +0900, Taeung Song wrote: This infrastructure code was designed

[PATCH v4 1/4] perf config: Introduce perf_config_set class

ff-by: Taeung Song --- tools/perf/util/config.c | 171 +++ tools/perf/util/config.h | 26 +++ 2 files changed, 197 insertions(+) create mode 100644 tools/perf/util/config.h diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 4e

[PATCH v4 0/4] Infrastructure code for perf-config

etc. (Namhyung) - separate this patch as several patches (Namhyung) - fix typing errors, etc. Taeung Song (4): perf config: Introduce perf_config_set class perf config: Let show_config() work with perf_config_set perf config: Prepare all default configs perf config: Initialize perf_config_set w

[PATCH v4 2/4] perf config: Let show_config() work with perf_config_set

config --user --list top.children=false # perf config --system --list top.children=true # perf config --list top.children=false Acked-by: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 35 --- 1 file

[PATCH v4 3/4] perf config: Prepare all default configs

ed-by: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/config.c | 110 ++- tools/perf/util/config.h | 62 +- 2 files changed, 168 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/config.c b/tools

[PATCH v4 4/4] perf config: Initialize perf_config_set with all default configs

correct type of a config variable in the near future. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 11 +++ tools/perf/util/config.c| 40 ++-- tools/perf/util/config.h| 7 +++ 3 files changed

[PATCH v3 1/4] perf config: Introduce perf_config_set class

ff-by: Taeung Song --- tools/perf/util/config.c | 169 +++ tools/perf/util/config.h | 26 2 files changed, 195 insertions(+) create mode 100644 tools/perf/util/config.h diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 4e

[RFC][PATCH v3 0/4] perf config: Infrastructure code for perf-config

x27;--list-all' option from this patchset v2: - remove perf_config_kind (user, system or both config files) and needless at this time, etc. (Namhyung) - separate this patch as several patches (Namhyung) - fix typing errors, etc. Taeung Song (4): perf config: Introduce perf_config_set clas

[PATCH v3 2/4] perf config: Let show_config() work with perf_config_set

config --user --list top.children=false # perf config --system --list top.children=true # perf config --list top.children=false Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 35 --- 1 file changed

[PATCH v3 4/4] perf config: Initialize perf_config_set with all default configs

correct type of a config variable in the near future. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 11 +++ tools/perf/util/config.c| 35 +-- tools/perf/util/config.h| 6 ++ 3 files changed, 42

[PATCH v3 3/4] perf config: Prepare all default configs

g Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/config.c | 110 ++- tools/perf/util/config.h | 62 +- 2 files changed, 168 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf

Re: [PATCH v3 1/4] perf config: Introduce perf_config_set class

Hi, Namhyung On 03/24/2016 03:07 PM, Namhyung Kim wrote: Hi Taeung, On Thu, Mar 24, 2016 at 05:16:30AM +0900, Taeung Song wrote: This infrastructure code was designed for upcoming features of perf-config. That collect config key-value pairs from user and system config files (i.e. user wide

Re: [PATCH v3 4/4] perf config: Initialize perf_config_set with all default configs

On 03/24/2016 03:13 PM, Namhyung Kim wrote: On Thu, Mar 24, 2016 at 05:16:33AM +0900, Taeung Song wrote: To avoid duplicated config variables and use perf_config_set classifying between standard perf config variables and unknown or new config variables other than them, initialize

[RESEND][PATCH v3 1/4] perf config: Introduce perf_config_set class

ff-by: Taeung Song --- tools/perf/util/config.c | 171 +++ tools/perf/util/config.h | 26 +++ 2 files changed, 197 insertions(+) create mode 100644 tools/perf/util/config.h diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 4e

[RESEND][PATCH v3 4/4] perf config: Initialize perf_config_set with all default configs

correct type of a config variable in the near future. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 11 +++ tools/perf/util/config.c| 40 ++-- tools/perf/util/config.h| 7 +++ 3 files changed

[PATCH] perf config: Tidy up the code setting buildid dir

Add new perf_buildid_config() into perf_default_config, bring set_buildid_dir() next to perf_default_config, rename some variable name as more readable name and etc in order to clean up code about buildid dir. Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Signed-off-by: Taeung Song --- tools

Re: [PATCH v2 1/5] perf config: Introduce perf_config_set class

Hi, Namhyung On 03/17/2016 09:31 PM, Namhyung Kim wrote: Hi Taeung, On Mon, Mar 14, 2016 at 09:16:05PM +0900, Taeung Song wrote: This infrastructure code was designed for upcoming features of perf-config. That collect config key-value pairs from user and system config files (i.e. user wide

[PATCHSET v16 0/8] perf config: Add several functionalities into perf-config

e of it. - simplify parsing arguments as arguments is just divided by '=' and then in front of '.' is a section, between '.' and '=' is a name, and behind '=' is a value. - if run perf-config command without any option

[PATCH v16 7/8] perf config: normalize a value depending on default type of it

g Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 54 - 1 file changed, 49 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index d2587c5..bad8182 100644 --- a/tools

[PATCH v16 1/8] perf config: Collect configs to handle config variables

collected configs list. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 150 ++-- tools/perf/util/cache.h | 13 2 files changed, 158 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-config

[PATCH v16 3/8] perf config: Add a option 'skel' to perf-config

--skel > ~/.perfconfig Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 ++ tools/perf/builtin-config.c | 32 +++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/tools/p

[PATCH v16 6/8] perf config: Add 'set' functionality

-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 2 +- tools/perf/builtin-config.c | 122 +-- tools/perf/util/cache.h | 5 +- tools/perf/util/config.c | 27 ++- 4 files changed, 131 insertions(+), 25

[PATCH v16 8/8] perf config: Add a option 'remove' to perf-config

A option 'remove' is to remove specific config variables. For the syntax examples, # perf config [] -r | --remove [section.name ...] Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 ++ tools/perf/builti

[PATCH v16 5/8] perf config: Add 'get' functionality

--verbose option to show the config description, i.e. # perf config -v report.queue-size Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 2 + tools/perf/builtin-config.c | 87 ++-- tools/perf

[PATCH v16 2/8] perf config: Add 'list-all' option to perf-config

Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 + tools/perf/builtin-config.c | 231 ++- 2 files changed, 235 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Doc

[PATCH v16 4/8] perf config: Add --verbose option for showing config description

current config variables with descriptions # perf config -vl | --verbose --list # perf config -va | --verbose --list-all Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 4 + tools/perf/builtin-config.c | 186 ++

[PATCH v15 1/9] perf config: Add '--system' and '--user' options to select which config file is used

config --user | --system or both user and system config file. # perf config Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 14 +- tools/perf/builtin-config.c | 27 ---

[PATCHSET v15 0/9] perf config: Add several options into perf-config

ariables with default values instead of using a 'util/PERFCONFIG-DEFAULT' file. - Add a function to normalize a value and check data type of it. - Simplify parsing arguments as arguments is just divided by '=' and then in front of '.' is a se

[PATCH v15 3/9] perf config: Add 'list-all' option to perf-config

Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 + tools/perf/builtin-config.c | 231 ++- 2 files changed, 235 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Doc

[PATCH v15 5/9] perf config: Add --verbose option for showing config description

current config variables with descriptions # perf config -vl | --verbose --list # perf config -va | --verbose --list-all Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 4 + tools/perf/builtin-config.c | 186 ++

[PATCH v15 6/9] perf config: Add 'get' functionality

--verbose option to show the config description, i.e. # perf config -v report.queue-size Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 2 + tools/perf/builtin-config.c | 87 ++-- tools/perf

[PATCH v15 9/9] perf config: Add a option 'remove' to perf-config

A option 'remove' is to remove specific config variables. For the syntax examples, # perf config [] -r | --remove [section.name ...] Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-config.txt | 6 ++ tools/perf/builti

<    1   2   3   4   5   6   7   8   9   >