Re: [PATCH v2] vmscan: add trace events for lru_gen

2023-09-21 Thread T.J. Mercier
On Wed, Sep 20, 2023 at 11:19 PM Jaewon Kim wrote: > > As the legacy lru provides, the lru_gen needs some trace events for > debugging. > Hi Jaewon, thanks for adding this. > This commit introduces 2 trace events. > trace_mm_vmscan_lru_gen_scan > trace_mm_vmscan_lru_gen_evict > > Each event i

Re: [PATCH v2] vmscan: add trace events for lru_gen

2023-09-23 Thread T.J. Mercier
On Thu, Sep 21, 2023 at 7:27 PM 김재원 wrote: > > >On Thu, 21 Sep 2023 09:12:30 -0700 > >"T.J. Mercier" wrote: > > > >> > + TP_fast_assign( > >> > + __entry->nid = nid; > >> > + __entry->nr_

Re: [PATCH v1 3/3] selftests: pid_namespace: add missing sys/mount.h include in pid_max.c

2025-04-09 Thread T.J. Mercier
n ‘mount’ > [-Wimplicit-function-declaration] > 42 | ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0); > | ^~~~~ > > Signed-off-by: Peter Seiderer Reviewed-by: T.J. Mercier

Re: [PATCH v2] selftests: pid_namespace: Add missing sys/mount.h

2025-04-09 Thread T.J. Mercier
On Wed, Apr 9, 2025 at 1:53 AM Peter Seiderer wrote: > > Hello T.J., > > On Tue, 8 Apr 2025 23:02:02 +, "T.J. Mercier" > wrote: > > > pid_max.c: In function ‘pid_max_cb’: > > pid_max.c:42:15: error:

Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h

2025-04-08 Thread T.J. Mercier
On Tue, Apr 8, 2025 at 3:48 PM Shuah Khan wrote: > > On 4/7/25 16:59, T.J. Mercier wrote: > > pid_max.c: In function ‘pid_max_cb’: > > pid_max.c:42:15: error: implicit declaration of function ‘mount’ > > [-Wimplicit-function

[PATCH v2] selftests: pid_namespace: Add missing sys/mount.h

2025-04-08 Thread T.J. Mercier
function) 48 | umount2("/proc", MNT_DETACH); Fixes: 615ab43b838b ("tests/pid_namespace: add pid_max tests") Signed-off-by: T.J. Mercier --- tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+

Re: [PATCH v1 2/3] selftests: pidfd: add missing sys/ioctl.h include in pidfd_setns_test.c

2025-04-30 Thread T.J. Mercier
implicit declaration of function ‘ioctl’ > [-Wimplicit-function-declaration] > 172 | self->child_pidfd_derived_nsfds[i] = > ioctl(self->pidfd, info->pidfd_ioctl, 0); > | ^ > > Signed

Re: [PATCH v1 1/3] selftests: pidfd: add missing sys/mount.h include in pidfd_fdinfo_test.c

2025-04-30 Thread T.J. Mercier
implicit declaration of function ‘mount’ > [-Wimplicit-function-declaration] > 230 | r = mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, 0); > | ^ > > Signed-off-by: Peter Seiderer Reviewed-by: T.J. Mercier > --- > tools/test

[PATCH] tests/pid_namespace: Add missing sys/mount.h

2025-04-10 Thread T.J. Mercier
function) 48 | umount2("/proc", MNT_DETACH); Fixes: 615ab43b838b ("tests/pid_namespace: add pid_max tests") Signed-off-by: T.J. Mercier --- tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+

Re: [PATCH] selftests/bpf: Fix kmem_cache iterator draining

2025-04-28 Thread T.J. Mercier
On Mon, Apr 28, 2025 at 1:06 PM Namhyung Kim wrote: > > Hello, > > On Mon, Apr 28, 2025 at 06:02:54PM +, T.J. Mercier wrote: > > The closing parentheses around the read syscall is misplaced, causing > > single byte reads from the iterator instead of buf sized reads.

[PATCH] selftests/bpf: Fix kmem_cache iterator draining

2025-04-28 Thread T.J. Mercier
" 145/1 kmem_cache_iter/check_task_struct:OK 145/2 kmem_cache_iter/check_slabinfo:OK 145/3 kmem_cache_iter/open_coded_iter:OK 145 kmem_cache_iter:OK Summary: 1/3 PASSED, 0 SKIPPED, 0 FAILED Fixes: a496d0cdc84d ("selftests/bpf: Add a test for kmem_cache_iter") Signed-

Re: [RESEND PATCH] selftests/bpf: Fix bpf selftest build error

2025-06-03 Thread T.J. Mercier
On Tue, Jun 3, 2025 at 10:50 AM Song Liu wrote: > > On Tue, Jun 3, 2025 at 10:33 AM T.J. Mercier wrote: > > > > On Mon, May 12, 2025 at 2:12 AM Saket Kumar Bhaskar > > wrote: > > > > > > On linux-next, build for bpf selftest displays an error due

Re: [RESEND PATCH] selftests/bpf: Fix bpf selftest build error

2025-06-03 Thread T.J. Mercier
On Mon, May 12, 2025 at 2:12 AM Saket Kumar Bhaskar wrote: > > On linux-next, build for bpf selftest displays an error due to > mismatch in the expected function signature of bpf_testmod_test_read > and bpf_testmod_test_write. > > Commit 97d06802d10a ("sysfs: constify bin_attribute argument of >