Re: [PATCH 4/6] usb: musb: dsps: simplify platform_get_resource_byname/devm_ioremap_resource

2013-08-19 Thread Svenning Sørensen
On 19-08-2013 10:51, Julia Lawall wrote: diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 4ffbaac..f2f9710 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -357,9 +357,6 @@ static int dsps_musb_init(struct musb *musb) u32 rev, v

Re: [PATCH 4/6] usb: musb: dsps: simplify platform_get_resource_byname/devm_ioremap_resource

2013-08-19 Thread Svenning Sørensen
On 19-08-2013 13:35, Julia Lawall wrote: reg_base = devm_ioremap_resource(dev, r); if (!musb->ctrl_base) return -EINVAL; Not really related to Julia's patch, apart from making it more obvious that there's a bug here. I believe it is reg_base that needs to be chec

[PATCH] IPC: bugfix for msgrcv with msgtyp < 0

2013-08-24 Thread Svenning Sørensen
According to 'man msgrcv': "If msgtyp is less than 0, the first message of the lowest type that is less than or equal to the absolute value of msgtyp shall be received." Bug: The kernel only returns a message if its type is 1; other messages with type < abs(msgtype) will never get returned. Fix:

[PATCH] net: guard against coalescing packets from buggy network drivers

2014-04-25 Thread Svenning Sørensen
This patch adds a guard against coalescing packets received by buggy network drivers that don't initialize skb->tail properly. Coalescing such packets will corrupt data in a way that makes it hard to track down the real cause of the problem. Observed symptoms are a flood of WARNs by tcp_recvmsg a

Re: [PATCH] net: guard against coalescing packets from buggy network drivers

2014-04-25 Thread Svenning Sørensen
On 25-04-2014 17:43, Eric Dumazet wrote: If you want a debugging patch, this should happen way before TCP stack or even IP stack. Say you want to use this buggy driver on a router, this code path will never bit hit. You are right, of course, there are more effective ways to catch buggy drive

Re: [PATCH] net: guard against coalescing packets from buggy network drivers

2014-04-25 Thread Svenning Sørensen
On 25-04-2014 18:49, Eric Dumazet wrote: On Fri, 2014-04-25 at 18:01 +0200, Svenning Sørensen wrote: You are right, of course, there are more effective ways to catch buggy drivers. But they will probably also be much more expensive. This one is very cheap, being in a relatively cold path