[PATCH] perf/powerpc: Fix compile warnings

2013-02-05 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu Date: Tue, 5 Feb 2013 15:04:49 -0800 Subject: [PATCH] perf/powerpc: Fix compile warnings Fix compile errors like those below: CC arch/powerpc/perf/power7-pmu.o /home/git/linux/arch/powerpc/perf/power7-pmu.c:397:2: error: initialization from incompatible pointer

Re: [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format

2013-02-26 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Jan 22, 2013 at 10:26:13PM -0800, Sukadev Bhattiprolu wrote: | > | > [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format | > | > Create a sysfs entry, '/sys/bus/event_source/devices/cpu/format/event

[PATCH] perf: powerpc: Use uapi/unistd.h to fix build error

2012-11-02 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu Date: Wed, 31 Oct 2012 11:21:28 -0700 Subject: [PATCH] perf: powerpc: Use uapi/unistd.h to fix build error Use the 'unistd.h' from arch/powerpc/include/uapi to build the perf tool. Signed-off-by: Sukadev Bhattiprolu --- tools/perf/perf.h |2 +- 1 fil

[PATCH] perf: x86 filter_events() - use hw event id ?

2012-10-30 Thread Sukadev Bhattiprolu
>From c3b53a5733fdea35807f4513255bca05e3aee5c5 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Tue, 30 Oct 2012 23:05:05 -0700 Subject: [PATCH] perf: x86 filter_events() - use hw event id ? The ->event_map() operation expects to index through the _hardware event id_. But filter_

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-30 Thread Sukadev Bhattiprolu
Peter Zijlstra [pet...@infradead.org] wrote: | On Tue, 2012-10-16 at 11:31 -0700, Sukadev Bhattiprolu wrote: | > On a side note, how does the kernel on x86 use the 'config' information in | > say /sys/bus/event_source/devices/cpu/format/cccr ? On Power7, the raw | > code enco

[PATCH 4/9][v5] powerpc: Rename branch_opcode() to instr_opcode()

2013-10-01 Thread Sukadev Bhattiprolu
The logic used in branch_opcode() to extract the opcode for an instruction applies to non branch instructions also. So rename to instr_opcode(). Signed-off-by: Sukadev Bhattiprolu Reviewed-by: Anshuman Khandual --- arch/powerpc/lib/code-patching.c |6 +++--- 1 file changed, 3 insertions

[no subject]

2013-10-01 Thread Sukadev Bhattiprolu
. Thanks to input from Stephane Eranian, Michael Ellerman, Michael Neuling and Anshuman Khandual. Sukadev Bhattiprolu (9): powerpc/perf: Rename Power8 macros to start with PME powerpc/perf: Export Power8 generic events in sysfs powerpc/perf: Add Power8 event PM_MRK_GRP_CMPL to sysfs. powerpc

[PATCH 1/9][v5] powerpc/perf: Rename Power8 macros to start with PME

2013-10-01 Thread Sukadev Bhattiprolu
We use helpers like GENERIC_EVENT_ATTR() to list the generic events in sysfs. To avoid name collisions, GENERIC_EVENT_ATTR() requires the perf event macros to start with PME. Signed-off-by: Sukadev Bhattiprolu Reviewed-by: Anshuman Khandual --- arch/powerpc/perf/power8-pmu.c | 24

[PATCH 3/9][v5] powerpc/perf: Add Power8 event PM_MRK_GRP_CMPL to sysfs.

2013-10-01 Thread Sukadev Bhattiprolu
The perf event PM_MRK_GRP_CMPL is useful in analyzing memory hierarchy of applications. Signed-off-by: Sukadev Bhattiprolu Reviewed-by: Anshuman Khandual --- arch/powerpc/perf/power8-pmu.c |5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc

[PATCH 7/9][v5] powerpc/perf: Export Power8 memory hierarchy info to user space.

2013-10-01 Thread Sukadev Bhattiprolu
t be implemented on Power, we don't implement 'perf mem' on Power for now. Thanks to input from Stephane Eranian, Michael Ellerman and Michael Neuling. Cc: Stephane Eranian Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu Reviewed-by: Anshuman Khandual --- Changelog[v2]:

[PATCH 9/9][v5] powerpc/perf: Update perf-mem man page for Power

2013-10-01 Thread Sukadev Bhattiprolu
Add a few lines to the perf-mem man page to indicate: - its dependence on the mem-loads and mem-stores events - how to use the feature on Power architecture. Signed-off-by: Sukadev Bhattiprolu --- tools/perf/Documentation/perf-mem.txt | 11 +++ 1 file changed, 11

[PATCH 2/9][v5] powerpc/perf: Export Power8 generic events in sysfs

2013-10-01 Thread Sukadev Bhattiprolu
Export generic perf events for Power8 in sysfs. Signed-off-by: Sukadev Bhattiprolu Reviewed-by: Anshuman Khandual --- arch/powerpc/perf/power8-pmu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c

[PATCH 6/9][v5] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-01 Thread Sukadev Bhattiprolu
perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For this to work on big endian platforms, we also need a big-endian represenation of perf_mem_data_src. Cc: Stephane Eranian Cc: Michael Ellerman Signed-off-by: Sukadev Bhattipr

[PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-01 Thread Sukadev Bhattiprolu
Implement is_instr_load_store() to detect whether a given instruction is one of the fixed-point or floating-point load/store instructions. This function will be used in a follow-on patch to save memory hierarchy information of the load/store. Signed-off-by: Sukadev Bhattiprolu Reviewed-by

[PATCH 8/9][v5] powerpc/perf: Export Power7 memory hierarchy info to user space.

2013-10-01 Thread Sukadev Bhattiprolu
, Michael Ellerman and Michael Neuling. Cc: Stephane Eranian Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu Reviewed-by: Anshuman Khandual --- Changelog[v4]: Drop support for 'perf mem' for Power (use perf-record and perf-report directly) Changelog[v3]:

Re: [PATCH 6/9][v5] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-02 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:07PM -0700, Sukadev Bhattiprolu wrote: | > perf_mem_data_src is an union that is initialized via the ->val field | > and accessed via the bitmap fields. For this to work on big endian | > platforms, we als

Re: [PATCH 6/9][v5] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-03 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:07PM -0700, Sukadev Bhattiprolu wrote: | > perf_mem_data_src is an union that is initialized via the ->val field | > and accessed via the bitmap fields. For this to work on big endian | > platforms, we als

Re: [PATCH 2/9][v5] powerpc/perf: Export Power8 generic events in sysfs

2013-10-03 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:03PM -0700, Sukadev Bhattiprolu wrote: | > Export generic perf events for Power8 in sysfs. | > | > Signed-off-by: Sukadev Bhattiprolu | > Reviewed-by: Anshuman Khandual | > --- | > arch/powerpc

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-03 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:06PM -0700, Sukadev Bhattiprolu wrote: | > Implement is_instr_load_store() to detect whether a given instruction | > is one of the fixed-point or floating-point load/store instructions. | > This function wil

Re: [PATCH 6/9][v5] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-04 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:07PM -0700, Sukadev Bhattiprolu wrote: | > perf_mem_data_src is an union that is initialized via the ->val field | > and accessed via the bitmap fields. For this to work on big endian | > platforms, we als

[PATCH 2/8][v4] powerpc/perf: Export Power8 generic events in sysfs

2013-09-13 Thread Sukadev Bhattiprolu
Export generic perf events for Power8 in sysfs. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/perf/power8-pmu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c index 30c6b12..ff98fb8 100644

[PATCH 5/8][v4] powerpc/perf: Export Power8 memory hierarchy info to user space.

2013-09-13 Thread Sukadev Bhattiprolu
t be implemented on Power, we don't implement 'perf mem' on Power for now. Thanks to input from Stephane Eranian, Michael Ellerman and Michael Neuling. Cc: Stephane Eranian Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu --- Changelog[v4]: Drop support fo

[PATCH 4/8][v4] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-09-13 Thread Sukadev Bhattiprolu
perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For this to work on big endian platforms, we also need a big-endian represenation of perf_mem_data_src. Cc: Stephane Eranian Cc: Michael Ellerman Signed-off-by: Sukadev Bhattipr

[PATCH 8/8][v4] powerpc/perf: Export Power7 memory hierarchy info to user space.

2013-09-13 Thread Sukadev Bhattiprolu
, Michael Ellerman and Michael Neuling. Cc: Stephane Eranian Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu --- Changelog[v4]: Drop support for 'perf mem' for Power (use perf-record and perf-report directly) Changelog[v3]: [Michael Ellerman] If newe

[PATCH 7/8][v4] power: implement is_instr_load_store().

2013-09-13 Thread Sukadev Bhattiprolu
Implement is_instr_load_store() to detect whether a given instruction is one of the fixed-point or floating-point load/store instructions. This function will be used in a follow-on patch to save memory hierarchy information of the load/store. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc

[PATCH 3/8][v4] powerpc/perf: Add PM_MRK_GRP_CMPL event to sysfs.

2013-09-13 Thread Sukadev Bhattiprolu
The perf event PM_MRK_GRP_CMPL is useful in analyzing memory hierarchy of applications. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/perf/power8-pmu.c |5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c index ff98fb8

[PATCH 6/8][v4] powerpc: Rename branch_opcode() to instr_opcode()

2013-09-13 Thread Sukadev Bhattiprolu
The logic used in branch_opcode() to extract the opcode for an instruction applies to non branch instructions also. So rename to instr_opcode(). Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/lib/code-patching.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 0/8][v4] powerpc/perf: Export memory hierarchy level in Power7/8.

2013-09-13 Thread Sukadev Bhattiprolu
Power7 and Power8 processors save the memory hierarchy level (eg: L2, L3) from which a load or store instruction was satisfied. Export this hierarchy information to the user via the perf_mem_data_src object. Thanks to input from Stephane Eranian, Michael Ellerman, Michael Neuling. Sukadev

[PATCH 1/8][v4] powerpc/perf: Rename Power8 macros to start with PME

2013-09-13 Thread Sukadev Bhattiprolu
We use helpers like GENERIC_EVENT_ATTR() to list the generic events in sysfs. To avoid name collisions, GENERIC_EVENT_ATTR() requires the perf event macros to start with PME. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/perf/power8-pmu.c | 24 1 file changed

Re: [PATCH] perf mem: add priv level filtering support

2013-09-05 Thread Sukadev Bhattiprolu
Arnaldo Carvalho de Melo [a...@redhat.com] wrote: | Em Wed, Aug 28, 2013 at 03:38:28PM +0200, Stephane Eranian escreveu: | > On Wed, Aug 28, 2013 at 3:27 PM, Arnaldo Carvalho de Melo wrote: | > > So perhaps we should change both to (and add this to 'report' as well): | > > | > > -U, --hide_ke

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-08 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | bool is_load_store(int ext_opcode) | { | upper = ext_opcode >> 5; | lower = ext_opcode & 0x1f; | | /* Short circuit as many misses as we can */ | if (lower < 3 || lower > 23) | return false; I see some

Re: [PATCH 8/8][v4] powerpc/perf: Export Power7 memory hierarchy info to user space.

2013-09-24 Thread Sukadev Bhattiprolu
Anshuman Khandual [khand...@linux.vnet.ibm.com] wrote: | On 09/14/2013 06:19 AM, Sukadev Bhattiprolu wrote: | > +static void power7_get_mem_data_src(union perf_mem_data_src *dsrc, | > + struct pt_regs *regs) | > +{ | > + u64 idx; | > + u64 mmcra = regs->

Re: [PATCH 05/21] perf: Add event toggle sys_perf_event_open interface

2013-09-25 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | Adding perf interface that allows to create 'toggle' events, | which can enable or disable another event. Whenever the toggle | event is triggered (has overflow), it toggles another event | state and either starts or stops it. Nice idea. It would be very usefu

Re: [PATCH 08/21] perf: Add new 'paused' attribute

2013-09-25 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | Adding new 'paused' perf_event_attr attribute bit. It sets | the initial event state as paused, so it wont get started | until it's triggered by toggling mechanism. There is a attr->disabled field which also leaves the event off by default. Some comments dist

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-19 Thread Sukadev Bhattiprolu
Stephane Eranian [eran...@google.com] wrote: | So all in all, I think this is not a very good idea. You have to put | this into the tool or a library that auto-detects the | host CPU and programs the right set of events. | | We've had that discussion many times. Just reiterating my personal | opin

Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs

2012-11-14 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Wed, Nov 07, 2012 at 11:19:28AM -0800, Sukadev Bhattiprolu wrote: | | SNIP | | > +struct perf_pmu_events_attr { | > + struct device_attribute attr; | > + u64 id; | > +}; | > + | > +extern ssize_t power_events_sysfs_show(

[PATCH 1/4] perf/powerpc: Use uapi/unistd.h to fix build error

2012-11-07 Thread Sukadev Bhattiprolu
>From b8beef080260c1625c8f801105504a82005295e5 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Wed, 31 Oct 2012 11:21:28 -0700 Subject: [PATCH 1/4] perf/powerpc: Use uapi/unistd.h to fix build error Use the 'unistd.h' from arch/powerpc/include/uapi to build the perf tool

[PATCH 2/4] perf/Power7: Use macros to identify perf events

2012-11-07 Thread Sukadev Bhattiprolu
>From 8a0dbd8f3fce2834292efa50c15ca64d4f6a6536 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Wed, 7 Nov 2012 09:36:14 -0800 Subject: [PATCH 2/4] perf/Power7: Use macros to identify perf events Define and use macros to identify perf events codes This would make it easier and m

[PATCH 3/4] perf/POWER7: Make event translations available in sysfs

2012-11-07 Thread Sukadev Bhattiprolu
>From d05d1ce6d55bf339eee6230ded9f5dd1351f60e5 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Tue, 6 Nov 2012 14:07:36 -0800 Subject: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs Make the perf events supported by POWER7 available via sysfs. $ ls /

[PATCH 4/4] perf: Create a sysfs entry for Power event format

2012-11-07 Thread Sukadev Bhattiprolu
>From bafc551c31ce23c1cba0b75d23de6c46aba90f26 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Tue, 6 Nov 2012 16:30:28 -0800 Subject: [PATCH 4/4] perf: Create a sysfs entry for Power event format Create a sysfs entry, '/sys/bus/event_source/devices/cpu/format/event' wh

perf: POWER-event translation questions

2012-11-07 Thread Sukadev Bhattiprolu
Looking for feedback on this prototype for making POWER-specific event translations available in sysfs. It is based on the patchset: https://lkml.org/lkml/2012/11/7/402 which makes the translations for _generic_ events in POWER available in sysfs: Since this is in POWER7 specific code

Re: [PATCH 2/5] perf: Make EVENT_ATTR and EVENT_PTR global

2013-01-04 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Tue, Dec 18, 2012 at 11:28:02PM -0800, Sukadev Bhattiprolu wrote: | > | > Rename EVENT_ATTR() and EVENT_PTR() PMU_EVENT_ATTR() and PMU_EVENT_PTR(). | > Make them global so they are available to all architectures. | > | > Further to allo

[PATCH 1/5] perf/Power7: Use macros to identify perf events

2012-12-18 Thread Sukadev Bhattiprolu
Define and use macros to identify perf events codes This would make it easier and more readable when these event codes need to be used in more than one place. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/perf/power7-pmu.c | 28 1 files changed, 20

[PATCH 2/5] perf: Make EVENT_ATTR and EVENT_PTR global

2012-12-18 Thread Sukadev Bhattiprolu
Rename EVENT_ATTR() and EVENT_PTR() PMU_EVENT_ATTR() and PMU_EVENT_PTR(). Make them global so they are available to all architectures. Further to allow architectures flexibility, have PMU_EVENT_PTR() pass in the variable name as a parameter. Signed-off-by: Sukadev Bhattiprolu --- arch/x86

[PATCH 3/5] perf/POWER7: Make generic event translations available in sysfs

2012-12-18 Thread Sukadev Bhattiprolu
a47473939db20e3961b200eb00acf5fcf084d755 Author: Jiri Olsa Date: Wed Oct 10 14:53:11 2012 +0200 perf/x86: Make hardware event translations available in sysfs Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/include/asm/perf_event_server.h | 25 +++ arch/powerpc/perf

[PATCH 4/5] perf/POWER7: Make some POWER7 events available in sysfs

2012-12-18 Thread Sukadev Bhattiprolu
able users to specify these events with their symbolic names rather than with their raw code. perf stat -e 'cpu/PM_CYC' ... Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/include/asm/perf_event_server.h |2 ++ arch/powerpc/perf/power7-pmu.c | 18 +++

[PATCH 5/5] perf: Create a sysfs entry for Power event format

2012-12-18 Thread Sukadev Bhattiprolu
s based on corresponding code in x86. Changelog[v2]: [Jiri Osla] Use PMU_FORMAT_ATTR() rather than duplicating it. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/include/asm/perf_event_server.h |6 ++ arch/powerpc/perf/core-book3s.c | 12 arch/powerpc/perf/po

Re: [PATCH 3/5] perf/POWER7: Make generic event translations available in sysfs

2012-12-19 Thread Sukadev Bhattiprolu
Greg KH [g...@kroah.com] wrote: | On Tue, Dec 18, 2012 at 11:28:49PM -0800, Sukadev Bhattiprolu wrote: | > | > [PATCH 3/5] perf/POWER7: Make generic event translations available in sysfs | | As you are adding new sysfs files, you must also add new | Documentation/ABI entries at the sam

Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs

2012-11-16 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | > | > Can we remove the assumption that the event id is a generic event that | > has PERF_COUNT_HW_ prefix and also let the architectures pass in a "show" | > function ? This would allow architectures to display any arch specific | > events that don't yet have

Re: [PATCH] perf: Power7: Make CPI stack events available in sysfs

2013-04-22 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Sat, Apr 06, 2013 at 09:48:03AM -0700, Sukadev Bhattiprolu wrote: | > From bdeacf7175241f6c79b5b2be0fa6b20b0d0b7d1c Mon Sep 17 00:00:00 2001 | > From: Sukadev Bhattiprolu | > Date: Sat, 6 Apr 2013 08:48:26 -0700 | > Subject:

Re: [PATCH 1/2] perf/Power7: Save dcache_src fields in sample record.

2013-06-18 Thread Sukadev Bhattiprolu
Michael Neuling [mi...@neuling.org] wrote: | Suka, | | One of these two patches breaks pmac32_defconfig and I suspect all other | 32 bit configs (against mainline) | | arch/powerpc/perf/core-book3s.c: In function 'record_and_restart': | arch/powerpc/perf/core-book3s.c:1632:4: error: passing argum

Re: [PATCH 2/2] perf tools: Make Power7 events available for perf

2013-06-19 Thread Sukadev Bhattiprolu
31112 0 45563b1fb arch/powerpc/perf/power7-pmu.o | | Signed-off-by: Runzhen Wang Reviewed-by: Sukadev Bhattiprolu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH 1/2] perf tools: fix a typo of a Power7 event name

2013-06-19 Thread Sukadev Bhattiprolu
| documentation accordingly. | | Signed-off-by: Runzhen Wang Reviewed-by: Sukadev Bhattiprolu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

Re: [PATCH 1/2] perf tools: fix a typo of a Power7 event name

2013-06-19 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Wed, 2013-06-19 at 17:15 +0800, Runzhen Wang wrote: | > In the Power7 PMU guide: | > https://www.power.org/documentation/commonly-used-metrics-for-performance-analysis/ | > PM_BRU_MPRED is referred to as PM_BR_MPRED. | > | > This patch fix the

[RFC][PATCH 1/3][v2] perf: Move PERF_MEM*SHIFT macros up the block

2013-06-26 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu Date: Fri, 21 Jun 2013 14:03:01 -0700 Subject: [RFC][PATCH 1/3][v2] perf: Move PERF_MEM*SHIFT macros up the block Values for the PERF_MEM_*SHIFT macros depend on the block before them, so it would be more readable if they are in the beginning of the block. Signed-off

[RFC][PATCH 3/3] perf/Power7: Export DCACHE_SRC field to userspace

2013-06-26 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu Date: Tue, 25 Jun 2013 17:12:02 -0700 Subject: [RFC][PATCH 3/3] perf/Power7: Export DCACHE_SRC field to userspace On Power7, the DCACHE_SRC field (bits 9..12), in the MMCRA register identify the source from which a data-cache-miss for a marked instruction was

[RFC][PATCH 2/3][v2] perf/Power7: Export MDTLB_SRC fields to userspace

2013-06-26 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu Date: Tue, 25 Jun 2013 15:50:18 -0700 Subject: [RFC][PATCH 2/3][v2] perf/Power7: Export MDTLB_SRC fields to userspace Power7 saves the "perf-event vector" information in the mmcra register. Included in this event vector is a "marked-data-TLB source&quo

[PATCH 1/2] perf/Power7: Save dcache_src fields in sample record.

2013-06-07 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu Date: Wed, 8 May 2013 22:59:29 -0700 Subject: [PATCH 1/2] perf/Power7: Save dcache_src fields in sample record. Power7 saves the "perf-event vector" information in the mmcra register. Included in this event vector is a "data-cache source" field which

[PATCH 2/2] perf: Add support for the mem_xlvl field.

2013-06-07 Thread Sukadev Bhattiprolu
>From 9f1a8a16e0ef36447e343d1cd4797c2b6a81225f Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Fri, 7 Jun 2013 13:26:31 -0700 Subject: [PATCH 2/2] perf: Add support for the mem_xlvl field. A follow-on patch to adding perf_mem_data_src support for Power7. At this point, this is o

Re: [PATCH 1/2] perf/Power7: Save dcache_src fields in sample record.

2013-06-10 Thread Sukadev Bhattiprolu
Anshuman Khandual [khand...@linux.vnet.ibm.com] wrote: | > The former approach seems less confusing and this patch uses that approach. | > | | Yeah, the former approach is simpler and makes sense. Ok. Seems to make sense at least on Power. | > + * We use the table, dcache_src_map, to map this

Re: [PATCH 1/2] perf/Power7: Save dcache_src fields in sample record.

2013-06-10 Thread Sukadev Bhattiprolu
Stephane Eranian [eran...@google.com] wrote: | > Further, in the above REM_CCE1 case, Power7 can also identify if the data came | > from the L2 or L3 cache of another core on the same chip. To describe this to | > user space, we propose to set ->mem_lvl to: | > | > PERF_MEM_LVL_REM_CCE1|P

Re: [PATCH] perf: ARM: Record the user-mode PC in the call chain.

2013-06-28 Thread Sukadev Bhattiprolu
Will Deacon [will.dea...@arm.com] wrote: | On Thu, Jun 20, 2013 at 04:17:06AM +0100, Jed Davis wrote: | > On Tue, Jun 18, 2013 at 02:13:19PM +0100, Will Deacon wrote: | > > On Fri, Jun 14, 2013 at 12:21:11AM +0100, Jed Davis wrote: | > > > With this change, we no longer lose the innermost entry in

Re: [PATCH 1/3] perf record: support duration option to run during specified time

2013-06-28 Thread Sukadev Bhattiprolu
Joonsoo Kim [iamjoonsoo@lge.com] wrote: | Currently, there is no method to quit at specified time later. | We are used to using 'sleep N' as command argument if we need it, | but explicitly supporting this feature maybe makes sense. | | Cc: Namhyung Kim | Signed-off-by: Joonsoo Kim | | diff

[PATCH 4/7] powerpc/perf: Create mem-loads/mem-stores events for Power7

2013-08-10 Thread Sukadev Bhattiprolu
M_MRK_GRP_CMPL is strictly not restricted to loads and stores, that seems to be a close/resonable match. Cc: Stephane Eranian Cc: Paul Mckerras Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/perf/power7-pmu.c | 16 1 files changed, 16 insertions(+), 0 d

[PATCH 1/7] powerpc/perf: Rename Power8 macros to start with PME

2013-08-10 Thread Sukadev Bhattiprolu
: Sukadev Bhattiprolu --- arch/powerpc/perf/power8-pmu.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c index 96a64d6..30c6b12 100644 --- a/arch/powerpc/perf/power8-pmu.c +++ b/arch

[PATCH 0/7]: Enable 'perf mem' command for Power

2013-08-10 Thread Sukadev Bhattiprolu
t I am unable to verify the build on few other configs due to a problem unrleated to this patchset. That is being discussed in a separate thread. I would like some feedback on this patchset in the meanwhile. Sukadev Bhattiprolu (7): powerpc/perf: Rename Power8 macros to start with PME po

[PATCH 2/7] powerpc/perf: Export Power8 generic events in sysfs

2013-08-10 Thread Sukadev Bhattiprolu
[PATCH 2/7] powerpc/perf: Export Power8 generic events in sysfs Export existing Power8 generic events in sysfs. Cc: Paul Mckerras Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/perf/power8-pmu.c | 23 +++ 1 files changed, 23 insertions(+), 0

[PATCH 3/7] powerpc/perf: Create mem-loads/mem-stores events for Power8

2013-08-10 Thread Sukadev Bhattiprolu
M_MRK_GRP_CMPL is strictly not restricted to loads and stores, that seems to be a close/resonable match. Cc: Stephane Eranian Cc: Paul Mckerras Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/perf/power8-pmu.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-)

[PATCH 7/7] powerpc/perf: Export Power7 memory hierarchy info to user space

2013-08-10 Thread Sukadev Bhattiprolu
Stephane Eranian Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu --- Thanks to input from Stephane Eranian and Michael Ellerman. Changelog[v3]: [Michael Ellerman] If newer levels that we defined in [v2] are not needed for Power8, ignore the new levels for Power7 also, and

[PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-10 Thread Sukadev Bhattiprolu
ane Eranian Cc: Paul Mckerras Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu --- Thanks to input from Stephane Eranian and Michael Ellerman. include/uapi/linux/perf_event.h | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) diff --gi

[PATCH 6/7] powerpc/perf: Export Power8 memory hierarchy info to user space

2013-08-10 Thread Sukadev Bhattiprolu
AD, MEM_LVL_HIT, MEM_LVL_L2 (i.e load hit L2). Cc: Stephane Eranian Cc: Paul Mckerras Cc: Michael Ellerman Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/include/asm/perf_event_server.h |2 + arch/powerpc/perf/core-book3s.c | 11 + arch/powerp

Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-11 Thread Sukadev Bhattiprolu
Vince Weaver [vi...@deater.net] wrote: | On Sat, 10 Aug 2013, Sukadev Bhattiprolu wrote: | | > | > include/uapi/linux/perf_event.h | 55 +++ | > 1 files changed, 55 insertions(+), 0 deletions(-) | | > +#define __PERF_LE 1234 | > +#define

Re: [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format

2013-03-05 Thread Sukadev Bhattiprolu
from one place ? Sukadev --- >From 50c7a46f14083c0ed10d66b7aed66ba76e798550 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Tue, 5 Mar 2013 21:20:56 -0800 Subject: [PATCH] [PATCH 5/6][v4]: perf Create a sysfs format entry for Power7 events Create a sysfs entry, '/sys/bus/even

Re: [PATCH] perf: Power7: Make CPI stack events available in sysfs

2013-05-11 Thread Sukadev Bhattiprolu
Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | Michael Ellerman [mich...@ellerman.id.au] wrote: | | On Sat, Apr 06, 2013 at 09:48:03AM -0700, Sukadev Bhattiprolu wrote: | | > From bdeacf7175241f6c79b5b2be0fa6b20b0d0b7d1c Mon Sep 17 00:00:00 2001 | | > From: Sukadev Bhatt

[PATCH] perf: Add --objdump option to perf top

2013-05-14 Thread Sukadev Bhattiprolu
perf: Add objdump option to 'perf top' Like with 'perf annotate' add the --objdump option to perf top so users can specify an alternate path to the /usr/bin/objdump binary. Reported-by: David A. Gilbert Signed-off-by: Sukadev Bhattiprolu --- tools/perf/builtin-top.c |

[PATCH] perf: Power7: Make CPI stack events available in sysfs

2013-04-06 Thread Sukadev Bhattiprolu
>From bdeacf7175241f6c79b5b2be0fa6b20b0d0b7d1c Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Sat, 6 Apr 2013 08:48:26 -0700 Subject: [PATCH] perf: Power7: Make CPI stack events available in sysfs A set of Power7 events are often used for Cycles Per Instruction (CPI) stack analy

[PATCH] perf: Power7 Update testing ABI to list CPI-stack events

2013-04-06 Thread Sukadev Bhattiprolu
>From 03a785f9d19249d2e524f31d8ead539f15d28a9f Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Sat, 6 Apr 2013 09:52:05 -0700 Subject: [PATCH] perf: Power7 Update testing ABI to list CPI-stack events Following patch added several Power7 events into /sys/devices/cpu/events. Docum

perf --version inconsistency

2013-04-09 Thread Sukadev Bhattiprolu
Following commit replaced 'git describe' with 'git tag -l | tail -1' to speed up the build: commit acddedfba0df1e47fa99035a04661082b679ee9c Author: Ingo Molnar Date: Tue Oct 30 09:46:00 2012 +0100 perf tools: Speed up the perf build time by simplifying the perf

[PATCH] perf: powerpc: Fix compile errors in bp_signal files

2013-04-26 Thread Sukadev Bhattiprolu
>From 0e27e218def9ae630cc07efbd21664c150a3727a Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Fri, 26 Apr 2013 10:17:56 -0700 Subject: [PATCH] perf: powerpc: Fix compile errors in bp_signal files When building on powerpc, we get compile errors in bp_signal.c and bp_signal_overflo

[PATCH] perf: Rename cpu_map__all() to cpu_map__empty()

2013-05-22 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu Date: Wed, 22 May 2013 17:42:38 -0700 Subject: [PATCH] Rename cpu_map__all() to cpu_map__empty(). The CPU map is in an "empty" (or not-applicable) state when monitoring specific threads. cpu_map__all() returns true if the CPU map is in this empty state (i

perf test failures on Power

2013-03-28 Thread Sukadev Bhattiprolu
The 'perf' tool has some built-in test cases and one of them checks to see if the symbols in vmlinux match those in /proc/kallsyms. This test is failing on Power for several reasons. I fixed a couple of them (described briefly at the end of the mail) and these fixes take the test further. One p

Re: [PATCH v2] perf: add callgrind conversion tool

2013-03-28 Thread Sukadev Bhattiprolu
Roberto Vitillo [raviti...@lbl.gov] wrote: | The proposed patch adds the convert tool to perf which allows to convert a | perf.data file to a set of callgrind data files which can subsequently be | displayed with kcachegrind. Sounds interesting and useful. My only comment is that 'convert' is a ge

[PATCH] perf: fix bug in isupper() and islower()

2013-03-29 Thread Sukadev Bhattiprolu
>From fd349681226bf7b27c9d0f72b0f3941b5aa94f78 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Fri, 29 Mar 2013 12:14:43 -0700 Subject: [PATCH] perf: fix bug in isupper() and islower() One of the reasons 'perf test' is failing on Power appears to be due to a bug in isupper(

Re: [PATCH] perf: Fix compile warnings in tests/attr.c

2013-01-21 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Fri, Jan 18, 2013 at 05:30:52PM -0800, Sukadev Bhattiprolu wrote: | > From 4d266e5040c33103f5d226b0d16b89f8ef79e3ad Mon Sep 17 00:00:00 2001 | > From: Sukadev Bhattiprolu | > Date: Fri, 18 Jan 2013 11:14:28 -0800 | > Subject: [PATCH] perf:

[PATCH 0/6][v4]: perf: Make POWER7 events available in sysfs

2013-01-22 Thread Sukadev Bhattiprolu
nation/ABI Changelog[v2]: [Jiri Olsa] Use PMU_FORMAT_ATTR() rather than duplicating code. Sukadev Bhattiprolu (6): perf/Power7: Use macros to identify perf events perf: Make EVENT_ATTR global perf/POWER7: Make generic event translations available in sysfs perf/POWER7: Make some POWER

[PATCH 1/6][v4]: perf/Power7: Use macros to identify perf events

2013-01-22 Thread Sukadev Bhattiprolu
[PATCH 1/6][v4]: perf/Power7: Use macros to identify perf events Define and use macros to identify perf events codes This would make it easier and more readable when these event codes need to be used in more than one place. Signed-off-by: Sukadev Bhattiprolu Acked-by: Jiri Olsa --- arch

[PATCH 2/6][v4]: perf: Make EVENT_ATTR global

2013-01-22 Thread Sukadev Bhattiprolu
need to define PMU_EVENT_PTR() Signed-off-by: Sukadev Bhattiprolu Acked-by: Jiri Olsa --- arch/x86/kernel/cpu/perf_event.c | 13 +++-- include/linux/perf_event.h | 11 +++ 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/cpu/perf_event.c b

[PATCH 3/6][v4]: perf/POWER7: Make generic event translations available in sysfs

2013-01-22 Thread Sukadev Bhattiprolu
a47473939db20e3961b200eb00acf5fcf084d755 Author: Jiri Olsa Date: Wed Oct 10 14:53:11 2012 +0200 perf/x86: Make hardware event translations available in sysfs Changelog:[v2] [Jiri Osla] Drop EVENT_ID() macro since it is only used once. Signed-off-by: Sukadev Bhattiprolu

[PATCH 4/6][v4]: perf/POWER7: Make some POWER7 events available in sysfs

2013-01-22 Thread Sukadev Bhattiprolu
are POWER specific and the others are the generic events. This will enable users to specify these events with their symbolic names rather than with their raw code. perf stat -e 'cpu/PM_CYC' ... Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/include/asm/perf_event_serv

[PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format

2013-01-22 Thread Sukadev Bhattiprolu
change is common in the code common to POWER cpus. This code is based on corresponding code in x86. Changelog[v2]: [Jiri Osla] Use PMU_FORMAT_ATTR() rather than duplicating it. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/include/asm/perf_event_server.h |6 ++ arch/powerpc/perf/cor

[PATCH 6/6][v4]: perf: Document the ABI of perf sysfs entries

2013-01-22 Thread Sukadev Bhattiprolu
testing/' Changelog[v3]: [Greg KH] Include ABI documentation. Signed-off-by: Sukadev Bhattiprolu Acked-by: Jiri Olsa --- .../testing/sysfs-bus-event_source-devices-events | 62 1 files changed, 62 insertions(+), 0 deletions(-) delete mode 100644 Documenta

Re: [PATCH] perf: Fix compile warnings in tests/attr.c

2013-01-23 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | > | make: *** [tests/attr.o] Error 1 | > | | > | i386 compiles fine | > | > __u64 is 'unsigned long long' on x86 and PRIu64 is 'llu' which is fine. | > | > __u64 is 'unsigned long' on Power and PRIu64 is 'lu' which is again fine. | > | > But __

[PATCH][v2] perf tools, powerpc: Fix compile warnings in tests/attr.c

2013-01-23 Thread Sukadev Bhattiprolu
o '-Werror'. By defining __SANE_USERSPACE_TYPES__ we include and define __u64 as unsigned long long. Changelog[v2]: [Michael Ellerman] Use __SANE_USERSPACE_TYPES__ and avoid PRIu64 format specifier - which as Jiri Olsa pointed out, breaks on x86-64. Signed-off-by: Sukadev

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-15 Thread Sukadev Bhattiprolu
> > * Stephane Eranian wrote: > > > This patch adds PERF_SAMPLE_DSRC. > > > > PERF_SAMPLE_DSRC collects the data source, i.e., where > > did the data associated with the sampled instruction > > come from. Information is stored in a perf_mem_dsrc > > structure. It contains opcode, mem level, tlb

[RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-11 Thread Sukadev Bhattiprolu
>From 89cb6a25b9f714e55a379467a832ee015014ed11 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Tue, 18 Sep 2012 10:59:01 -0700 Subject: [PATCH] perf: Add a few generic stalled-cycles events The existing generic event 'stalled-cycles-backend' corresponds to PM_CMPLU_S

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-16 Thread Sukadev Bhattiprolu
Robert Richter [robert.rich...@amd.com] wrote: | Sukadev, | | On 15.10.12 17:55:34, Robert Richter wrote: | > On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: | > > + { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, | > > + { .type = PER

Re: [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries

2013-01-16 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Tue, Jan 15, 2013 at 03:57:59PM -0300, Arnaldo Carvalho de Melo wrote: | > Em Wed, Jan 09, 2013 at 05:07:03PM -0800, Sukadev Bhattiprolu escreveu: | > > [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries | > > | > > This p

[PATCH] perf: Fix PMU format parsing test failure

2013-01-17 Thread Sukadev Bhattiprolu
>From 776e6d7942754f139c27753213c9cf4617536618 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Thu, 17 Jan 2013 09:11:30 -0800 Subject: [PATCH] perf; Fix PMU format parsing test failure On POWER, the 'perf format parsing' test always fails. Looks like it is because mems

Re: [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries

2013-01-18 Thread Sukadev Bhattiprolu
the updated patch. --- >From 1e3cc6b3ef87f533985b10574af472361e39eecd Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Tue, 8 Jan 2013 22:31:49 -0800 Subject: [PATCH] perf: Document the ABI of perf sysfs entries This patchset addes two new sets of files to sysfs for POWER architecture. - perf event config format

[PATCH] perf: Fix compile warnings in tests/attr.c

2013-01-18 Thread Sukadev Bhattiprolu
>From 4d266e5040c33103f5d226b0d16b89f8ef79e3ad Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Fri, 18 Jan 2013 11:14:28 -0800 Subject: [PATCH] perf: Fix compile warnings in tests/attr.c Replace '%llu' in printf()s with 'PRIu64' in 'tools/perf/tests/att

  1   2   3   4   5   6   7   8   9   >