On Monday 20 June 2016 07:05 AM, Stephen Rothwell wrote:
Hi all,
Changes since 20160617:
I just started trying gcc 6.1.0 for mips and mips allmodconfig is
failing with the error:
{standard input}: Assembler messages:
{standard input}:147: Error: number (0x90008000) larger than 32 bi
On Tuesday 21 June 2016 06:46 AM, Stephen Rothwell wrote:
Hi all,
Changes since 20160620:
tilepro defconfig is failing while doing "make prepare" and bisect shows
the first bad commit as:
1af5de9af138 ("locking/atomic, arch/tile: Implement
atomic{,64}_fetch_{add,sub,and,or,xor}()")
You c
On Sunday 19 June 2016 05:15 AM, kbuild test robot wrote:
Hi,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: c141afd1a28793c08c88325aa64b773be6f79ccf
commit: 420520766a796d3607639ba1e4fb1aadeadd [media] media:
On Tue, Jun 21, 2016 at 09:58:28AM +0200, Peter Zijlstra wrote:
> On Tue, Jun 21, 2016 at 08:01:36AM +0100, Sudip Mukherjee wrote:
>
> > tilepro defconfig is failing while doing "make prepare" and bisect shows the
> > first bad commit as:
> >
> >
On Tue, Jun 21, 2016 at 04:14:35PM +0200, Peter Zijlstra wrote:
> On Tue, Jun 21, 2016 at 04:04:08PM +0200, Peter Zijlstra wrote:
> > > I'm not sure who builds the toolchains, but tilepro is in upstream
> > > gcc/binutils/etc
> > > so should be easy enough to include. There's also a cross-toolcha
The irq was disabled before reading from the gameport. After reading
we should enable it. Instead we were restoring it back to the previous
state before starting the do-while loop.
Signed-off-by: Sudip Mukherjee
---
drivers/input/joystick/analog.c | 2 +-
1 file changed, 1 insertion(+), 1
xoffset and yoffset of struct fb_var_screeninfo are unsigned and so
they can never be less than 0.
Signed-off-by: Sudip Mukherjee
---
drivers/video/fbdev/intelfb/intelfbdrv.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c
b/drivers/video/fbdev
Use proper error code instead of using -1 on failure to allocate
memory. We may use the error code later in the caller.
Signed-off-by: Sudip Mukherjee
---
drivers/hid/usbhid/usbkbd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/usbhid/usbkbd.c b
telfb: new maintainer")
Signed-off-by: Sudip Mukherjee
---
I think I have the hardware. Will test tomorrow.
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d8e81b1..72280d5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6148
definition
#define SMC_outb(v, a, r) outb(v, ((u32)a) + (r))
Signed-off-by: Sudip Mukherjee
---
m32r allmodconfig build of next-20160825 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/154943795
drivers/net/ethernet/smsc/smc91x.h | 7 +++
1 file changed, 7 insertions(+)
diff
On Wednesday 31 August 2016 10:03 PM, Fabio Estevam wrote:
On Wed, Aug 31, 2016 at 1:28 PM, Sudip Mukherjee
wrote:
Use proper error code instead of using -1 on failure to allocate
memory. We may use the error code later in the caller.
Signed-off-by: Sudip Mukherjee
---
drivers/hid/usbhid
On Thursday 01 September 2016 02:35 AM, kernel test robot wrote:
FYI, we noticed the following commit:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
char-misc-testing
commit 8b7d3a9d903ee1d1f5febc8e74223e4e72720e35 ("ppdev: use new parport device
model")
in testcase: b
On Thursday 01 September 2016 04:51 PM, Jiri Kosina wrote:
On Wed, 31 Aug 2016, Sudip Mukherjee wrote:
Use proper error code instead of using -1 on failure to allocate
memory. We may use the error code later in the caller.
But we don't. usb_kbd_probe() returns -ENOMEM in
if it is still not claimed then mmc_host->claim_cnt will be 0
and mmc_release_host() will do "if (--host->claim_cnt)" and thus the
condition will become true.
Lets just return the value on allocation failure instead of trying to
release the host before claiming it.
Signed-off-by: Sudi
If the firmware request failed we were just returning but we missed
freeing the memory and releasing the MMC Host.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b
On Wed, Aug 24, 2016 at 03:56:32AM +0700, Didik Setiawan wrote:
> Fix checkpatch.pl warning about "Alignment should match open parenthesis".
> ---
you missed the Signed-off-by: line.
regards
sudip
On Thursday 04 August 2016 06:55 PM, Max Filippov wrote:
Hi Guenter,
On Thu, Aug 4, 2016 at 9:30 AM, Guenter Roeck wrote:
Hi Max,
I see the following build errors when building xtensa images in
next-20160804.
Error log:
arch/xtensa/kernel/built-in.o: In function `fast_alloca':
(.text+0x99a):
On Thu, Aug 25, 2016 at 09:59:46PM +0800, Ming-Chia Chung wrote:
> On Tue, Aug 23, 2016 at 12:01:36PM +0530, Sudip Mukherjee wrote:
> > On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote:
> > > On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote:
>
hw->DACreg has a size of 80 bytes and MGADACbpp32 has 21. So when
memcpy copies MGADACbpp32 to hw->DACreg it copies 80 bytes but
only 21 bytes are valid.
Signed-off-by: Sudip Mukherjee
---
drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Mon, Jun 19, 2017 at 11:47:20PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee
> wrote:
>
>
> > +#ifdef CONFIG_X86
> > + primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> > +
Hi Dan,
On Tue, Jun 20, 2017 at 11:20:55PM +0300, Dan Carpenter wrote:
> That's totally bogus. Just say you don't know. It's never a
> reguirement that people fix AMD drivers before they can review code...
Yes, I don't know how drm drivers work, so I blindly follow what has
been done there. And
On Tue, Jun 20, 2017 at 11:40:59PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 20, 2017 at 11:20 PM, Dan Carpenter
> wrote:
> > That's totally bogus. Just say you don't know. It's never a
> > reguirement that people fix AMD drivers before they can review code...
>
> Agree. It's not a cargo cult
Hi Bartlomiej,
On Wed, Jun 14, 2017 at 12:54:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Monday, May 08, 2017 08:11:16 AM Christophe JAILLET wrote:
> > According to surrounding goto, it is likely that 'goto err_probed_panel' is
> > expected here.
> > This change is just done in o
On Sat, Aug 19, 2017 at 10:38:41PM +0530, Arvind Yadav wrote:
> parisc_device_id are not supposed to change at runtime. All functions
> working with parisc_device_id provided by work
> with
> const parisc_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav
> ---
>
Modify baycom driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
Not tested on real hardware, only tested on kvm with 32 bit guest and
verified that the device is binding to the driver properly in par96_open
but then unbinding as the device was not found
From: Bhumika Goyal
Make this const as it is only used during a copy operation. This usage
is inside init function and the structure is not referenced after
initialisation, so make it __initconst too.
Signed-off-by: Bhumika Goyal
Signed-off-by: Sudip Mukherjee
---
drivers/parport
ng.
Fixes: 77f55f3809d4 ("block: remove __bio_kmap_atomic")
Signed-off-by: Sudip Mukherjee
---
The build log of next-20171110 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/38449
arch/xtensa/platforms/iss/simdisk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
There are cases when panel and crt both are not defined and only one of
them is defined and initialized. In such cases, while removing the
device deallocate the colormap only if that particular fb is defined.
Signed-off-by: Sudip Mukherjee
---
drivers/video/fbdev/sm501fb.c | 3 +++
1 file
There are cases when panel and crt both are not defined and only one of
them is defined and initialized. In such cases, suspend or resume it
only if it is defined.
Signed-off-by: Sudip Mukherjee
---
drivers/video/fbdev/sm501fb.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers
There are cases when panel and crt both are not defined and only one of
them is defined and initialized. In such cases, while removing the
device, unregister the framebuffer only if it was registered.
Signed-off-by: Sudip Mukherjee
---
drivers/video/fbdev/sm501fb.c | 6 --
1 file changed, 4
On Thu, Sep 24, 2015 at 12:31:01PM +0530, Sudip Mukherjee wrote:
> On Wed, Sep 23, 2015 at 12:48:25PM -0500, Dimitri Sivanich wrote:
> > Sudip,
> >
> > I can take a look at the Jack Steiner patches. Was there anything in the
> > set
> > of 3 patches that y
On Mon, Oct 05, 2015 at 05:32:05PM -0700, Dmitry Torokhov wrote:
> On Sat, Oct 03, 2015 at 02:54:56PM +0530, Sudip Mukherjee wrote:
> > The variable i is used to check the port to attach to and we are
> > supposed to save the reference of struct db9 in the location given by
>
On Mon, Oct 05, 2015 at 12:38:55PM +0200, Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.3-rc4[1] compared to v4.2[2].
>
> 8 improvements:
> - /home/kisskb/slave/src/drivers/net/ethernet/via/via-rhine.c: error:
> implicit declaration of fu
ev but the argument that it received was named
as "d". Declare dev and fix the build fail.
Fixes: 9a47354fe63a ("pwm: Add Broadcom BCM7038 PWM controller support")
Signed-off-by: Sudip Mukherjee
---
drivers/pwm/pwm-brcmstb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
Lindgren
Cc: Austin Schuh
Cc: Grygorii Strashko
Cc: Santosh Shilimkar
Signed-off-by: Sudip Mukherjee
---
Same problem for pinctrl was fixed by
5ba341604a054294aeb812603349bba024d716ee
And for your reference:
https://lkml.org/lkml/2014/2/25/278
drivers/gpio/Kconfig | 2 +-
1 file change
On Tue, Oct 06, 2015 at 06:25:22PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20151002:
The build for cris allmodconfig is failing with the error:
net/sched/sch_dsmark.c: In function 'dsmark_dequeue':
net/sched/sch_dsmark.c:316:1: error: unrecognizable insn:
(insn 245 244 119 15
is released.
While at it the error labels are also renamed to give a meaningful
name.
Cc: Patrik Jakobsson
Signed-off-by: Sudip Mukherjee
---
Hi Patrik,
If you donot like the labels I will change them according to what you
have suggested.
drivers/gpu/drm/gma500/framebuffer.c | 13 -
On Tue, Oct 06, 2015 at 04:46:53PM +0200, Hans-Peter Nilsson wrote:
> > From: Sudip Mukherjee
> > Date: Tue, 6 Oct 2015 14:33:46 +0200
>
> > On Tue, Oct 06, 2015 at 06:25:22PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Cha
On Tue, Oct 06, 2015 at 03:45:07PM -0500, Grygorii Strashko wrote:
> On 10/06/2015 07:01 AM, Sudip Mukherjee wrote:
> > While building arm allmodconfig the build fails with the error:
> > ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
> >
> >
so no need to typecast a bool
to (u32 *).
Signed-off-by: Sudip Mukherjee
---
drivers/base/power/opp/debugfs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/base/power/opp/debugfs.c b/drivers/base/power/opp/debugfs.c
index 865cbfa..251966b 100644
--- a/drivers/
ntroduce function to lock
regulators and its supplies") says there will be future users, but as of
now there is no user and is creating build warnings.
Signed-off-by: Sudip Mukherjee
---
drivers/regulator/core.c | 39 ---
1 file changed, 39 deletions(-)
We were getting build warning about "Section mismatch".
dmi_platform_intel_broadwell is being referenced from the probe function
rt5645_i2c_probe(), but dmi_platform_intel_broadwell was marked with
__initdata.
Signed-off-by: Sudip Mukherjee
---
sound/soc/codecs/rt5645.c | 2 +-
1 fi
We were getting build warning about unused variable 'err'.
The commit a3c29b099829 has removed the use of err but missed removing
the variable which is unused now.
Fixes: a3c29b099829 ("mfd: rtsx: Simplify function return logic")
Signed-off-by: Sudip Mukherjee
---
driver
We were getting build warning about unused variable 'ret'.
The commit c749db571dcf has removed the use of ret but missed removing
the variable which is unused now.
Fixes: c749db571dcf ("mfd: lm3533: Simplify function return logic")
Signed-off-by: Sudip Mukherjee
---
drive
On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> Hi Sudip,
>
> [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please
> ignore]
v4.3-rc4 is not appropriate base. Please use next-20151007 for both.
regards
sudip
--
To unsubscribe from this list: send the line
On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> On Wed, Oct 07, 2015 at 06:16:52PM +0530, Sudip Mukherjee wrote:
> > On Wed, Oct 07, 2015 at 08:40:37PM +0800, kbuild test robot wrote:
> > > Hi Sudip,
> > >
> > > [auto build test ERROR on v4
On Thu, Oct 08, 2015 at 07:30:22AM +0100, Greg KH wrote:
> On Thu, Oct 08, 2015 at 08:56:38AM +0800, Fengguang Wu wrote:
> > On Wed, Oct 07, 2015 at 09:11:25PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Oct 07, 2015 at 09:48:16PM +0800, Fengguang Wu wrote:
> > > >
On Wed, Oct 07, 2015 at 03:05:27PM +0100, Mark Brown wrote:
> On Wed, Oct 07, 2015 at 05:52:12PM +0530, Sudip Mukherjee wrote:
> > We were getting build warning about "Section mismatch".
> > dmi_platform_intel_broadwell is being referenced from the probe function
&g
On Mon, Aug 17, 2015 at 12:59:34PM +0530, Sudip Mukherjee wrote:
> On Fri, Aug 14, 2015 at 09:05:55AM +0200, Pali Rohár wrote:
> > On Friday 14 August 2015 12:25:42 Sudip Mukherjee wrote:
> > > On Thu, Aug 13, 2015 at 09:26:02AM -0700, Dmitry Torokhov wrote:
> > > >
On Mon, Aug 31, 2015 at 03:55:58PM +0200, Pali Rohár wrote:
> > > Sorry for the delay in replying. The change in parallel port code was
> > > merged in 4.2, so you can test it againt 4.2-rc*.
> > Hi Pali,
> > Now that 4.2 is released you can test on it. And do you also have any
> > option to test t
We were aborting if the kzalloc of img_swap fails but without freeing the
already allocated out. Similarly we were aborting if spi_sync fails
without releasing out and img_swap.
Signed-off-by: Sudip Mukherjee
---
sound/soc/codecs/wm0010.c | 8 +++-
1 file changed, 7 insertions(+), 1
b_ipath.ko] undefined!
ERROR: "ib_wq" [drivers/staging/ipath/ib_ipath.ko] undefined!
Config at: https://lkml.org/lkml/2015/8/31/328
Reported-by: Jim Davis
Signed-off-by: Sudip Mukherjee
---
drivers/staging/ipath/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/stagin
On Tue, Sep 01, 2015 at 04:27:24PM +0300, Tomi Valkeinen wrote:
>
>
> On 18/07/15 07:08, Sudip Mukherjee wrote:
> > Now since all cleanups are done and the code is ready to be merged lets
> > move it out of staging into fbdev location.
>
> Have you considered writing
If wrong option is given then we are returning but we missed releasing
the workqueue and pstore.
Add an error path and use it to correctly release resources on failure.
Fixes: b0d3cc011e53 ("dm snapshot: add new persistent store option to support
overflow")
Signed-off-by: Sudip
Instead of using goto and jumping to a label and then returning from
there, lets return directly. The label out: is not used from anywhere
else in the code.
Signed-off-by: Sudip Mukherjee
---
crypto/ccm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/crypto/ccm.c b
p2p_ij.
Signed-off-by: Sudip Mukherjee
---
One sudip sending patch to another sudeep... :)
drivers/misc/mic/scif/scif_nodeqp.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/mic/scif/scif_nodeqp.c
b/drivers/misc/mic/scif/scif_nodeqp.c
index
.
Signed-off-by: Sudip Mukherjee
---
I personally faced this multiple times and faced again just now while
sending another patch for misc. Greg can also confirm about the missing
patches. But this maybe a problem with getmaintainer.pl file also.
So adding Joe Perches to Cc list.
MAINTAINERS | 4
p2p_ij.
Signed-off-by: Sudip Mukherjee
---
missed making the function as static in v1. reportd by kbuild test
robot.
drivers/misc/mic/scif/scif_nodeqp.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/mic/scif/scif_nodeqp.c
b/drivers/misc/mic
On Tue, Oct 13, 2015 at 05:50:12PM +0800, kbuild test robot wrote:
> Hi Sudip,
>
> [auto build test WARNING on char-misc/char-misc-next -- if it's inappropriate
> base, please suggest rules for selecting the more suitable base]
>
> url:
> https://github.com/0
p2p_ij.
Signed-off-by: Sudip Mukherjee
---
v3: added unmapping the aperture
v2: missed making the function as static
drivers/misc/mic/scif/scif_nodeqp.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/mic/scif/scif_nodeqp.c
b/drivers/misc/mic
On Tue, Oct 13, 2015 at 09:34:21AM -0700, Sudeep Dutt wrote:
> On Tue, 2015-10-13 at 14:38 +0530, Sudip Mukherjee wrote:
> > + struct scif_hw_dev *sdev = scifdev->sdev;
> > +
> > + dma_unmap_sg(&sdev->dev, p2p->ppi_sg[SCIF_PPI_MMIO],
> > +
On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote:
> On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> > Greg and Arnd are supporter of char and misc drivers. While using
> > getmaintainer.pl on any patch or any file in these directories their
> > names
On Tue, Oct 13, 2015 at 10:39:47AM -0700, Greg Kroah-Hartman wrote:
> On Tue, Oct 13, 2015 at 10:49:24PM +0530, Sudip Mukherjee wrote:
> > On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote:
> > > On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote:
> &g
On Mon, Oct 05, 2015 at 10:18:32AM -0500, Dimitri Sivanich wrote:
> On Mon, Oct 05, 2015 at 08:43:07PM +0530, Sudip Mukherjee wrote:
> > On Thu, Sep 24, 2015 at 12:31:01PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Sep 23, 2015 at 12:48:25PM -0500, Dimitri Sivanich wr
On Thu, Oct 08, 2015 at 03:22:20PM +0100, Emil Velikov wrote:
> On 8 October 2015 at 14:00, Sudip Mukherjee
> wrote:
> > On Thu, Oct 01, 2015 at 04:40:59PM +1000, Ben Skeggs wrote:
> >> On 09/25/2015 01:59 AM, Sudip Mukherjee wrote:
> >> > On Fri, Sep 11
Using strcpy() is a security risk as the destination buffer size is not
checked and we may over-run the buffer. Use strncpy() instead, while
mentioning the buffer size leaving place for the NULL termination.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/fbtft/fbtft_device.c | 3 ++-
1 file
Using magic numbers are not good coding practise. Use
FBTFT_GPIO_NAME_SIZE as defined in the header files.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/fbtft/fbtft_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers
Instead of defining DRVNAME and using it in all calls to pr_* family of
macros lets start using pr_fmt.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/fbtft/fbtft_device.c | 79
1 file changed, 35 insertions(+), 44 deletions(-)
diff --git a/drivers
On Sat, Sep 05, 2015 at 07:24:38PM +, Mike Dupuis wrote:
> This is a patch to the ieee80211_softmac_wx.c file that corrects instances
> where open braces appear on the incorrect line as identified by checkpatch.pl
>
> Signed-off-by: Mike Dupuis
> ---
This patch will not apply because of:
143
On Sat, Sep 05, 2015 at 07:29:14PM +, Mike Dupuis wrote:
> This is a patch to add spaces around assignment operators as identifed by
> checkpatch.pl
>
> Signed-off-by: Mike Dupuis
> ---
same problem as in 10/15
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux
If drm_fb_helper_alloc_fbi() fails then we were directly returning
without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but
mgag200_framebuffer_init() fails then we were not releasing sysram and
we were not releasing fbi helper also.
Signed-off-by: Sudip Mukherjee
---
drivers/gpu
We were successfully requesting the firmware but on error it was not
being released.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/gdm72xx/usb_boot.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/usb_boot.c
b/drivers/staging/gdm72xx
checkpatch complains if NULL comparison is done as if (var == NULL)
Signed-off-by: Sudip Mukherjee
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_sdio.c | 20 ++--
drivers/staging/gdm72xx/gdm_usb.c | 16
drivers/staging/gdm72xx
On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote:
> On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote:
> > The platform driver core will set the owner value, we do not need to do
> > it in the module.
> >
> > Signed-off-by: Sudip Mukh
r=implicit-int]
arch/tile/kernel/usb.c:70:1: warning: parameter names (without types) in
function declaration [enabled by default]
arch/tile/kernel/usb.c:63:19: warning: 'tilegx_usb_init' defined but not used
[-Wunused-function]
Include linux/module.h to resolve the build failure.
and at the end of
the series, allmodconfig builds.
Only build tested with allmodconfig, common_defconfig, iss_defconfig on
next-20150908.
Sudip Mukherjee (4):
xtensa: fix error with dma_{alloc,free}_{attrs,coherent}
xtensa: fix error with dma_supported
xtensa: fix errors with dma_supported
x
rrors
like:
error: redefinition of 'dma_alloc_attrs'
error: redefinition of 'dma_free_attrs'
while building with allmodconfig.
Signed-off-by: Sudip Mukherjee
---
arch/xtensa/include/asm/dma-mapping.h | 31 ---
1 file changed, 31 deletions(-)
diff --git
ike:
error: redefinition of 'dma_supported'
while building with allmodconfig.
Signed-off-by: Sudip Mukherjee
---
arch/xtensa/include/asm/dma-mapping.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/xtensa/include/asm/dma-mapping.h
b/arch/xtensa/include/asm
#x27;
while building with allmodconfig.
Signed-off-by: Sudip Mukherjee
---
arch/xtensa/include/asm/dma-mapping.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/arch/xtensa/include/asm/dma-mapping.h
b/arch/xtensa/include/asm/dma-mapping.h
index 019a94a..15992a3 100644
--- a/arc
ng_error'
while building with allmodconfig.
Signed-off-by: Sudip Mukherjee
---
arch/xtensa/include/asm/dma-mapping.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/arch/xtensa/include/asm/dma-mapping.h
b/arch/xtensa/include/asm/dma-mapping.h
index bf24c90..5762d8d 100644
--- a
The member qc_idx of struct if_quotactl is unsigned and hence it can
never be less than zero.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/lustre/lustre/lov/lov_obd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c
b/drivers
.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/lustre/lustre/lov/lov_io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/lustre/lustre/lov/lov_io.c
b/drivers/staging/lustre/lustre/lov/lov_io.c
index bf36291..b5b2580 100644
--- a/drivers/staging/lustre/lustre/lov
On Tue, Sep 08, 2015 at 09:53:09AM -0700, Joe Perches wrote:
> On Tue, 2015-09-08 at 21:53 +0530, Sudip Mukherjee wrote:
> > if (qctl->qc_valid == QC_OSTIDX) {
> > - if (qctl->qc_idx < 0 || count <= qctl->qc_idx)
> > +
On Tue, Sep 08, 2015 at 08:34:56PM +0300, Max Filippov wrote:
> Sudip,
>
> On Tue, Sep 8, 2015 at 4:18 PM, Sudip Mukherjee
> wrote:
> > While building with allmodconfig the build failed with different dma
> > related errors. It turned out that the dma functions were move
If backing->stolen is true then we were freeing backing by calling
psb_gtt_free_range() but we called it again after unlocking the mutex.
Lets make it NULL after freeing in psb_gtt_free_range() and check for
NULL before calling the function for the second time.
Signed-off-by: Sudip Mukher
On Wed, Sep 09, 2015 at 03:52:11PM +0300, Max Filippov wrote:
> On Wed, Sep 9, 2015 at 10:11 AM, Sudip Mukherjee
> wrote:
> > On Tue, Sep 08, 2015 at 08:34:56PM +0300, Max Filippov wrote:
> >> Sudip,
> >>
> >> On Tue, Sep 8, 2015 at 4:18 PM, Sudip Mukherjee
coverity.com reported that memset was using a buffer of size 0, on
checking the code it turned out that the function was not being used. So
remove it.
Signed-off-by: Sudip Mukherjee
---
drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h | 2 --
drivers/gpu/drm/nouveau/nvkm/subdev/bios
We were taking the exit path after checking ue->flags and return value
of setup_routing_entry(), but 'e' was not freed incase of a failure.
Signed-off-by: Sudip Mukherjee
---
virt/kvm/irqchip.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/virt/kvm/irq
We were checking rdev->supply for NULL after dereferencing it. Lets
check for rdev->supply along with _regulator_is_enabled() and call
regulator_enable() only if rdev->supply is not NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/regulator/core.c | 5 ++---
1 file changed, 2 inserti
gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should
not dereference it if it has returned error. And incase it has returned
error then just downgrade the write lock and exit.
Signed-off-by: Sudip Mukherjee
---
drivers/misc/sgi-gru/grukservices.c | 3 +++
1 file changed, 3
These variables were only assigned some value and were never used.
Signed-off-by: Sudip Mukherjee
---
I have removed the variables in the functions gru_dump_tfm() and
gru_dump_tgh() but it appeared that the intended logic might have been
something like:
bytes = GRU_NUM_TFM
The member gid in struct gru_dump_chiplet_state_req is unsigned int. So
it can never be less than 0.
Signed-off-by: Sudip Mukherjee
---
drivers/misc/sgi-gru/grukdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru
The functions gru_get_cb_exception_detail_str() and gru_abort() were
only called locally from that file. We can make them static.
Signed-off-by: Sudip Mukherjee
---
drivers/misc/sgi-gru/grukservices.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/sgi-gru
On Wed, Sep 02, 2015 at 02:58:19PM +0300, Tomi Valkeinen wrote:
> On 01/09/15 16:55, Sudip Mukherjee wrote:
> > On Tue, Sep 01, 2015 at 04:27:24PM +0300, Tomi Valkeinen wrote:
> >> On 18/07/15 07:08, Sudip Mukherjee wrote:
> >>> Now since all cleanups are done and
On Wed, Sep 02, 2015 at 09:42:04AM -0500, Dimitri Sivanich wrote:
> On Wed, Sep 02, 2015 at 04:54:55PM +0530, Sudip Mukherjee wrote:
> > These variables were only assigned some value and were never used.
> >
> > Signed-off-by: Sudip Mukherjee
> > ---
> >
dev_get_by_name() will increment the usage count if the matching device
is found. But we were not decrementing the count if we have got the
device and the device is non-active.
Signed-off-by: Sudip Mukherjee
---
drivers/net/wan/sbni.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
If the buffer is too small then return the error and in the process
remove the variables which became unused.
Signed-off-by: Sudip Mukherjee
---
v1: only removed variables.
drivers/misc/sgi-gru/grukdump.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a
dw was only assigned some value and was never reused.
Signed-off-by: Sudip Mukherjee
---
v2: It was part of first patch in v1. But since one logical change in
one patch so it had to be removed from first patch and became separate.
drivers/misc/sgi-gru/grukservices.c | 2 --
1 file changed, 2
gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should
not dereference it if it has returned error. And incase it has returned
error then wait for some time and try again.
Signed-off-by: Sudip Mukherjee
---
v2: on error retry after msleep(1).
v1: returned error.
drivers/misc
The member gid in struct gru_dump_chiplet_state_req is unsigned int. So
it can never be less than 0.
Signed-off-by: Sudip Mukherjee
Acked-by: Dimitri Sivanich
---
v2: no change, sent as a part of the series.
drivers/misc/sgi-gru/grukdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
1 - 100 of 2348 matches
Mail list logo
