Re: [PATCH] audit: create explicit AUDIT_SECCOMP event type

2012-11-28 Thread Steve Grubb
On Monday, November 26, 2012 09:45:56 AM Kees Cook wrote: > On Mon, Nov 26, 2012 at 6:14 AM, Steve Grubb wrote: > > On Monday, November 19, 2012 01:56:53 PM Kees Cook wrote: > >> The seccomp path was using AUDIT_ANOM_ABEND from when seccomp mode 1 > >> could only kil

Re: [PATCH 7/8] audit: clean up AUDIT_GET/SET local variables and future-proof API

2013-09-19 Thread Steve Grubb
On Wednesday, September 18, 2013 03:06:52 PM Richard Guy Briggs wrote: > Re-named confusing local variable names (status_set and status_get didn't > agree with their command type name) and reduced their scope. > > Future-proof API changes by not depending on the exact size of the > audit_status st

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-09-13 Thread Steve Grubb
On Tuesday, September 10, 2013 07:20:33 PM Oleg Nesterov wrote: > On 09/08, Oleg Nesterov wrote: > > First of all, I do not pretend I understand this code. This was mostly > > the question, and in fact I mostly asked about audit_bprm() in 0/1. > > > > However, > >

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-09-13 Thread Steve Grubb
On Sunday, September 08, 2013 05:54:35 PM Oleg Nesterov wrote: > Sorry for delay, vacation. > > First of all, I do not pretend I understand this code. This was mostly > the question, and in fact I mostly asked about audit_bprm() in 0/1. > > However, > > On 08/30, S

Re: audit looks unmaintained? [was: Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid]

2013-08-30 Thread Steve Grubb
On Friday, August 30, 2013 03:06:46 PM Richard Guy Briggs wrote: > On Tue, Aug 27, 2013 at 07:11:34PM +0200, Oleg Nesterov wrote: > > Btw. audit looks unmaintained... if you are going to take care of > > this code, perhaps you can look at > > > > http://marc.info/?l=linux-kernel&m=137589907108

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-04-09 Thread Steve Grubb
On Tuesday, April 09, 2013 02:39:32 AM Eric W. Biederman wrote: > Andrew Morton writes: > > On Wed, 20 Mar 2013 15:18:17 -0400 Richard Guy Briggs wrote: > >> audit rule additions containing "-F auid!=4294967295" were failing with > >> EINVAL. > >> > >> UID_INVALID (and GID_INVALID) is actually

Re: [PATCH] [BZ905179] audit: omit check for uid and gid validity in audit rules and data

2013-05-09 Thread Steve Grubb
f a Signed-off-by: is appropriate > for me in this case, but I'll throw in a: > > Tested-by: Richard Guy Briggs > > and recommend a: > > Reported-By: Steve Grubb If this is the approved patch, can it be put in stable? The audit system hasn't worked as intended s

Re: [PATCH] audit: create explicit AUDIT_SECCOMP event type

2012-11-26 Thread Steve Grubb
On Monday, November 19, 2012 01:56:53 PM Kees Cook wrote: > The seccomp path was using AUDIT_ANOM_ABEND from when seccomp mode 1 > could only kill a process. While we still want to make sure an audit > record is forced on a kill, this should use a separate record type since > seccomp mode 2 introdu

Re: asm/unistd.h

2001-04-05 Thread Steve Grubb
gcc_4.html#SEC92 Or perhaps type checking macro arguments would be another fertile area for the Stanford Checker... Cheers, Steve Grubb - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://

[PATCH] minor do_syslog cleanup

2000-11-30 Thread Steve Grubb
Hello, This patch removes extra setting of the error value in the do_syslog function. The patch is against 2.2.16, but printk.c seems to have changed little so it probably applies against other kernels. See Ya, Steve Grubb --- printk.orig Thu Nov 30 07:58:58 2000

[Patch] performance enhancement for simple_strtoul

2000-12-20 Thread Steve Grubb
ply a test application that demonstrates the performance gain. This patch was generated against 2.2.16, but should apply to 2.2.19 cleanly. In 2.4.0-test9, simple_strtoul starts on line 19 rather than 17, hopefully that's not a problem. Cheers, Steve Grubb - --- lib/vs

[Test Case] performance enhancement for simple_strtoul

2000-12-20 Thread Steve Grubb
base value with this define to 8, 10, or 16 to see the speed change for each numeric representation: #define BASE 10 Have fun, Steve Grubb --strtoul_test.c-- #include #include #include #include #include #include struct timeval last_stopwatch_time; void stopwatch() { s

Re: [Patch] performance enhancement for simple_strtoul

2000-12-20 Thread Steve Grubb
me. Just say the word & I'll gen up another patch...but it will be more bytes. Cheers, Steve Grubb - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: [Patch] performance enhancement for simple_strtoul

2000-12-20 Thread Steve Grubb
ts 2 lines later. Cheers, Steve Grubb -- --- lib/vsprintf.orig Fri Dec 1 08:58:02 2000 +++ lib/vsprintf.c Wed Dec 20 13:14:13 2000 @@ -14,10 +14,13 @@ #include #include +/* +* This function converts base 8, 10, or 16 only - Steve Grubb +*/ unsigned

Re: [PATCH] audit: file system auditing based on location and name

2005-07-06 Thread Steve Grubb
ents would indicate the path from the perspective of the app generating the events, but since we added the /var/chroot key, we can see that it really came from the chroot dir. Hope this helps... -Steve Grubb - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

Re: [PATCH] audit: file system auditing based on location and name

2005-07-07 Thread Steve Grubb
On Thursday 07 July 2005 14:15, Greg KH wrote: > I fail to see any refactoring here, why not make your patch rely on > theirs? At the time this code was developed, inotify was not in the kernel. We would be patching against another patch that's not in the kernel. > > The whole rest of it is diff

Re: [PATCH] audit: file system auditing based on location and name

2005-07-07 Thread Steve Grubb
On Thursday 07 July 2005 15:04, Greg KH wrote: > You are adding auditfs, a new userspace access, right? Not sure what you mean. This is using the same netlink interface that all the rest of the audit system is using for command and control. Nothing has changed here. What is different is the mess

Re: [patch] Syscall auditing - move "name=" field to the end

2005-03-17 Thread Steve Grubb
dit daemon can switch to another format (binary data ?) which might be more efficient. I haven't spent anytime looking at what makes sense for a binary format, nor do we have time for that right now. But I'd like to look at that in the future. -Steve Grubb - To unsubscribe from this l

Re: [patch 1/1] SELinux AVC audit log ipaddr field support (for task_struct->curr_ip)

2005-03-10 Thread Steve Grubb
or two for everyone to look over. -Steve Grubb - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] audit: clear thread flag for new children

2007-10-27 Thread Steve Grubb
On Friday 26 October 2007 04:42:28 pm Tony Jones wrote: > Thread flag TIF_SYSCALL_AUDIT is not cleared for new children when audit > context creation has been disabled (auditctl -e0). This can cause new > children forked from a parent created when audit was enabled to not take > the fastest syscall

Re: [PATCH] audit: clear thread flag for new children

2007-10-29 Thread Steve Grubb
On Monday 29 October 2007 01:20:58 pm Tony Jones wrote: > > The problem is that removing that flag makes the children unauditable in > > the future. The only place that flag gets set is during fork. > > I don't see this. If the child does not have the TIF_SYSCALL_AUDIT flag, it never goes into au

Re: [PATCH] audit: clear thread flag for new children

2007-11-01 Thread Steve Grubb
On Monday 29 October 2007 07:15:30 pm Tony Jones wrote: > On Mon, Oct 29, 2007 at 06:04:31PM -0400, Steve Grubb wrote: > > So when audit is re-enabled, how do you make that task auditable? > > No idea. How do you do it currently? HINT: current->audit_context == NULL >

Re: [PATCH] audit: clear thread flag for new children

2007-11-01 Thread Steve Grubb
On Thursday 01 November 2007 01:23:24 pm Tony Jones wrote: > > We are looking into this - at one time it did. Someone should follow up > > with a path correcting this soon. But I doubt the audit system will work > > correctly if the flag gets removed as there is no good way to add it > > again late

Re: [2.6 patch] kernel/audit.c: change the exports to EXPORT_SYMBOL_GPL

2007-07-30 Thread Steve Grubb
On Sunday 29 July 2007 11:02:33 Adrian Bunk wrote: > They are still completely unused, but hopefully some of the theoretical > code that might use it will appear in the kernel in the near future... > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Acked-by: Steve Grubb <

Re: [patch] audit support for SH

2007-11-07 Thread Steve Grubb
On Wednesday 07 November 2007 12:04:46 am Yuichi Nakamura wrote: > I found syscall audit does not work on SH(SuperH). > I made patch to support syscall audit for SH. I think this is close, but it looks like you missed the syscall classification piece. You can find an example here: arch/x86_64/ke

Re: [PATCH] Audit: Add TTY input auditing

2007-06-07 Thread Steve Grubb
On Thursday 07 June 2007 04:13:42 Jan Engelhardt wrote: > >Add TTY input auditing, used to audit system administrator's actions. > > _What_ exactly does it audit? In theory, it should audit the actions performed by the sysadmin. This patch doesn't cover actions done via X windows interface. > An

Re: [PATCH] Audit: Add TTY input auditing

2007-06-07 Thread Steve Grubb
On Thursday 07 June 2007 11:42, Casey Schaufler wrote: > > tools like rootsh, but that is too easy to detect and defeat. And then it > > does not put its data into the audit system where its correlated with > > other system events. > > The evaluation teams that I have worked with (OrangeBook and CC

Re: RFC(v2): Audit Kernel Container IDs

2017-10-16 Thread Steve Grubb
On Monday, October 16, 2017 8:33:40 PM EDT Richard Guy Briggs wrote: > On 2017-10-12 16:33, Casey Schaufler wrote: > > On 10/12/2017 7:14 AM, Richard Guy Briggs wrote: > > > Containers are a userspace concept. The kernel knows nothing of them. > > > > > > The Linux audit system needs a way to be

Re: RFC(v2): Audit Kernel Container IDs

2017-10-17 Thread Steve Grubb
On Tuesday, October 17, 2017 12:43:18 PM EDT Casey Schaufler wrote: > > The idea is that processes spawned into a container would be labelled > > by the container orchestration system. It's unclear what should happen > > to processes using nsenter after the fact, but policy for that should > > be

Re: RFC(v2): Audit Kernel Container IDs

2017-10-17 Thread Steve Grubb
On Tuesday, October 17, 2017 1:57:43 PM EDT James Bottomley wrote: > > > > The idea is that processes spawned into a container would be > > > > labelled by the container orchestration system. It's unclear > > > > what should happen to processes using nsenter after the fact, but > > > > policy for

Re: [PATCH ALT4 V3 1/2] audit: show fstype:pathname for entries with anonymous parents

2017-11-13 Thread Steve Grubb
On Thursday, November 9, 2017 3:52:46 PM EST Richard Guy Briggs wrote: > > >> > It might be simplest to just apply a corrective patch over top of > > >> > this one so that you don't have to muck about with git branches and > > >> > commit messages. > > >> > > >> A quick note on the "corrective pat

Re: RFC(v2): Audit Kernel Container IDs

2017-10-19 Thread Steve Grubb
On Thursday, October 19, 2017 7:11:33 PM EDT Aleksa Sarai wrote: > >>> The registration is a pseudo filesystem (proc, since PID tree already > >>> exists) write of a u8[16] UUID representing the container ID to a file > >>> representing a process that will become the first process in a new > >>> co

[PATCH 1/1] fanotify: pre-approve listener's OPEN_PERM access requests

2015-10-12 Thread Steve Grubb
Hello, If a daemon using FANOTIFY needs to open a file on a watched filesystem and its wanting OPEN_PERM events, we get deadlock. (This could happen because of a library the daemon is using suddenly decides it needs to look in a new file.) Even though the man page says that the daemon should appro

Re: Should audit_seccomp check audit_enabled?

2015-10-23 Thread Steve Grubb
te and people really don't want to see anything in their > logs, I suppose we could always add a sysctl knob to turn off the > message completely (we would still need to do whatever audit records > are required, see below). > > Wearing my audit hat, I want to make sure we tick off

Re: [PATCH] audit: set TIF_AUDIT_SYSCALL only if audit filter has been populated

2018-03-10 Thread Steve Grubb
On Wed, 7 Mar 2018 18:43:42 -0500 Paul Moore wrote: > ... and I just realized that linux-audit isn't on the To/CC line, > adding them now. > > Link to the patch is below. > > * https://marc.info/?t=15204188763&r=1&w=2 Yes...I wished I was in on the beginning of this discussion. Here's the p

Re: [PATCH ghak21 V2 0/4] audit: address ANOM_LINK excess records

2018-03-12 Thread Steve Grubb
On Mon, 12 Mar 2018 02:31:16 -0400 Richard Guy Briggs wrote: > Audit link denied events were being unexpectedly produced in a > disjoint way when audit was disabled, and when they were expected, > there were duplicate PATH records. This patchset addresses both > issues for symlinks and hardlinks

Re: [PATCH ghak21 V2 3/4] audit: add refused symlink to audit_names

2018-03-13 Thread Steve Grubb
On Mon, 12 Mar 2018 11:52:56 -0400 Richard Guy Briggs wrote: > On 2018-03-12 11:53, Paul Moore wrote: > > On Mon, Mar 12, 2018 at 11:26 AM, Richard Guy Briggs > > wrote: > > > On 2018-03-12 11:12, Paul Moore wrote: > > >> On Mon, Mar 12, 2018 at 2:31 AM, Richard Guy Briggs > > >> wrote: >

Re: [PATCH ghak21 V2 3/4] audit: add refused symlink to audit_names

2018-03-13 Thread Steve Grubb
On Tue, 13 Mar 2018 06:11:08 -0400 Richard Guy Briggs wrote: > On 2018-03-13 09:35, Steve Grubb wrote: > > On Mon, 12 Mar 2018 11:52:56 -0400 > > Richard Guy Briggs wrote: > > > > > On 2018-03-12 11:53, Paul Moore wrote: > > > > On Mon, Ma

Re: [PATCH ghak21 V2 3/4] audit: add refused symlink to audit_names

2018-03-13 Thread Steve Grubb
On Tue, 13 Mar 2018 06:52:51 -0400 Richard Guy Briggs wrote: > On 2018-03-13 11:38, Steve Grubb wrote: > > On Tue, 13 Mar 2018 06:11:08 -0400 > > Richard Guy Briggs wrote: > > > > > On 2018-03-13 09:35, Steve Grubb wrote: > > > > On Mon, 12 M

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-05-17 Thread Steve Grubb
On Fri, 16 Mar 2018 05:00:28 -0400 Richard Guy Briggs wrote: > Implement the proc fs write to set the audit container ID of a > process, emitting an AUDIT_CONTAINER record to document the event. > > This is a write from the container orchestrator task to a proc entry > of the form /proc/PID/cont

Re: [RFC PATCH ghak32 V2 03/13] audit: log container info of syscalls

2018-05-17 Thread Steve Grubb
On Fri, 16 Mar 2018 05:00:30 -0400 Richard Guy Briggs wrote: > Create a new audit record AUDIT_CONTAINER_INFO to document the > container ID of a process if it is present. As mentioned in a previous email, I think AUDIT_CONTAINER is more suitable for the container record. One more comment below.

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-05-18 Thread Steve Grubb
On Thu, 17 May 2018 17:56:00 -0400 Richard Guy Briggs wrote: > > During syscall events, the path info is returned in a a record > > simply called AUDIT_PATH, cwd info is returned in AUDIT_CWD. So, > > rather than calling the record that gets attached to everything > > AUDIT_CONTAINER_INFO, how ab

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

2018-05-18 Thread Steve Grubb
On Fri, 18 May 2018 11:21:06 -0400 Richard Guy Briggs wrote: > On 2018-05-18 09:56, Steve Grubb wrote: > > On Thu, 17 May 2018 17:56:00 -0400 > > Richard Guy Briggs wrote: > > > > > > During syscall events, the path info is returned in a a record > > &g

Re: [PATCH] TaskTracker : Simplified thread information tracker.

2015-01-12 Thread Steve Grubb
On Monday, January 12, 2015 03:13:12 PM Tetsuo Handa wrote: > Thank you for comments. > > Richard Guy Briggs wrote: > > Steve already mentioned any user-influenced fields need to be escaped, > > so I'd recommend audit_log_untrustedstring() as being much simpler from > > your perspective and much b

Re: [PATCH] audit: add containerid support for IMA-audit

2018-05-22 Thread Steve Grubb
On Monday, May 21, 2018 5:57:29 PM EDT Stefan Berger wrote: > Should some of the fields from INTEGRITY_PCR also appear in > INTEGRITY_RULE? If so, which ones? > >>> > >>> pid, uid, auid, tty, session, subj, comm, exe, res. <- these are > >>> required to be searchable > >>> > We co

Re: [PATCH] audit: add containerid support for IMA-audit

2018-05-22 Thread Steve Grubb
On Tuesday, May 22, 2018 9:43:46 AM EDT Richard Guy Briggs wrote: > On 2018-05-21 17:57, Stefan Berger wrote: > > On 05/21/2018 02:30 PM, Steve Grubb wrote: > > > Hello Stefan, > > > > > > On Monday, May 21, 2018 1:53:04 PM EDT Stefan Berger wrote: > &g

Re: [PATCH 2/3] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-01 Thread Steve Grubb
t; > Writing the string "log log errno trace kill_process kill_thread", which > > is unordered and contains the log action twice, results in the same > > > > value as the previous example for the actions field: > > type=CONFIG_CHANGE msg=audit(

Re: [PATCH v2 3/4] seccomp: Audit attempts to modify the actions_logged sysctl

2018-05-02 Thread Steve Grubb
hich is unordered and contains the log action twice, > it results in the same actions value as the previous record: > > type=CONFIG_CHANGE msg=audit(1525275325.613:142): op=seccomp-logging > actions=kill_process,kill_thread,errno,trace,log > old-actions=kill_process,kill_thread,er

Re: [RFC PATCH v1 1/5] fs: Add support for an O_MAYEXEC flag on sys_open()

2019-04-16 Thread Steve Grubb
On Tuesday, April 16, 2019 7:49:39 AM EDT Florian Weimer wrote: > * Steve Grubb: > > This flag that is being proposed means that you would have to patch all > > interpreters to use it. If you are sure that upstreams will accept that, > > why not just change the policy to i

Re: [PATCH ghak124 v3] audit: log nftables configuration change events

2021-02-11 Thread Steve Grubb
On Thursday, February 11, 2021 11:29:34 AM EST Paul Moore wrote: > > If I'm not mistaken, iptables emits a single audit log per table, ipset > > doesn't support audit at all. So I wonder how much audit logging is > > required at all (for certification or whatever reason). How much > > granularity i

Re: [PATCH ghak25 v6] audit: add subj creds to NETFILTER_CFG record to cover async unregister

2020-05-20 Thread Steve Grubb
On Wednesday, May 20, 2020 2:40:45 PM EDT Paul Moore wrote: > On Wed, May 20, 2020 at 12:55 PM Richard Guy Briggs wrote: > > On 2020-05-20 12:51, Richard Guy Briggs wrote: > > > Some table unregister actions seem to be initiated by the kernel to > > > garbage collect unused tables that are not ini

Re: race in audit_log_untrusted_string for task_struct::comm

2014-03-17 Thread Steve Grubb
On Saturday, March 15, 2014 07:28:46 PM Richard Guy Briggs wrote: > I'm inclined to go get_task_comm() in all 5 locations, but if we care > more about locking overhead, I'll switch to memcpy(). > > Steve, do we care about the integrity of the comm field? In the case of interpreters, its about the

Re: [RFC][PATCH] audit: Simplify by assuming the callers socket buffer is large enough

2014-03-05 Thread Steve Grubb
On Tuesday, March 04, 2014 07:21:52 PM David Miller wrote: > From: ebied...@xmission.com (Eric W. Biederman) > Date: Tue, 04 Mar 2014 14:41:16 -0800 > > > If we really want the ability to always appened to the queue of skb's > > is to just have a version of netlink_send_skb that ignores the queued

Re: [PATCH v3] audit: Turn off TIF_SYSCALL_AUDIT when there are no rules

2014-02-10 Thread Steve Grubb
On Monday, February 10, 2014 09:29:19 AM Andy Lutomirski wrote: > Grr. Why is all this crap tied up with syscall auditing anyway? ISTM > it would have been a lot nicer if audit calls just immediately emitted > audit records, completely independently of the syscall machinery. Because the majority

Re: [PATCH v3] audit: Turn off TIF_SYSCALL_AUDIT when there are no rules

2014-02-10 Thread Steve Grubb
On Monday, February 10, 2014 11:01:36 AM Andy Lutomirski wrote: > >> And I still think this needs more changes. Once again, I do not think > >> that, say, __audit_log_bprm_fcaps() should populate context->aux if > >> !TIF_SYSCALL_AUDIT, this list can grow indefinitely. Or > >> __audit_signal_info()

Re: [PATCH] audit: add arch field to seccomp event log

2014-02-18 Thread Steve Grubb
On Tuesday, February 18, 2014 03:50:44 PM Richard Guy Briggs wrote: > > missing '=' but this isn't what audit_get_context() does... it's > > crappy naming...I'd think a combo of audit_dummy_context() and > > current->audit_context would be most appropriate. > > Ok. I think I finally under

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Steve Grubb
Hello Mimi, On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: > This change is already being upstreamed as commit 73a6b44 "Integrity: > Pass commname via get_task_comm()". While I was looking at Richard's patch, I noticed a few places where cause and op are logged and the string isn't t

Re: [PATCH v3 3/3] audit: Audit proc cmdline value

2014-01-15 Thread Steve Grubb
On Wednesday, January 15, 2014 01:02:14 PM William Roberts wrote: > During an audit event, cache and print the value of the process's > cmdline value (proc//cmdline). This is useful in situations > where processes are started via fork'd virtual machines where the > comm field is incorrect. Often ti

Re: [PATCH v3 3/3] audit: Audit proc cmdline value

2014-01-15 Thread Steve Grubb
On Wednesday, January 15, 2014 05:08:13 PM William Roberts wrote: > On Wed, Jan 15, 2014 at 4:54 PM, Steve Grubb wrote: > > On Wednesday, January 15, 2014 01:02:14 PM William Roberts wrote: > >> During an audit event, cache and print the value of the process's > >&

Re: [PATCH 0/6][v2] audit: implement multicast socket for journald

2014-04-22 Thread Steve Grubb
On Tuesday, April 22, 2014 09:31:52 PM Richard Guy Briggs wrote: > This is a patch set Eric Paris and I have been working on to add a > restricted capability read-only netlink multicast socket to kernel audit to > enable userspace clients such as systemd/journald to receive audit logs, in > additio

Re: [PATCH v3 3/3] audit: Audit proc cmdline value

2014-01-15 Thread Steve Grubb
On Wednesday, January 15, 2014 05:44:29 PM William Roberts wrote: > On Wed, Jan 15, 2014 at 5:33 PM, Steve Grubb wrote: > > On Wednesday, January 15, 2014 05:08:13 PM William Roberts wrote: > >> On Wed, Jan 15, 2014 at 4:54 PM, Steve Grubb wrote: > >> > On Wednesday

Re: [PATCH v3 3/3] audit: Audit proc cmdline value

2014-01-16 Thread Steve Grubb
On Wednesday, January 15, 2014 09:08:39 PM William Roberts wrote: > >> > Try this, > >> > > >> > cp /bin/ls 'test test test' > >> > auditctll -a always,exit -F arch=b64 -S stat -k test > >> > ./test\ test\ test './test\ test\ test' > >> > auditctl -D > >> > ausearch --start recent --key test > >>

Re: [PATCH v3 3/3] audit: Audit proc cmdline value

2014-01-16 Thread Steve Grubb
On Thursday, January 16, 2014 07:03:34 AM William Roberts wrote: > On Thu, Jan 16, 2014 at 6:02 AM, Steve Grubb wrote: > > On Wednesday, January 15, 2014 09:08:39 PM William Roberts wrote: > >> >> > Try this, > >> >> > > >> >> > cp

Re: [RFC][PATCH] audit: Simplify by assuming the callers socket buffer is large enough

2014-03-07 Thread Steve Grubb
On Friday, March 07, 2014 07:48:01 PM David Miller wrote: > From: Eric Paris > Date: Fri, 07 Mar 2014 17:52:02 -0500 > > > Audit is non-tolerant to failure and loss. > > Netlink is not a loss-less transport. Perhaps. But in all our testing over the years its been very good. -Steve -- To unsubs

Re: [PATCH for v3.14] AUDIT: Allow login in non-init namespaces

2014-04-09 Thread Steve Grubb
On Sunday, March 30, 2014 07:07:54 PM Eric Paris wrote: > It its possible to configure your PAM stack to refuse login if > audit messages (about the login) were unable to be sent. This is common > in many distros and thus normal configuration of many containers. The > PAM modules determine if audi

Re: [PATCH v2 2/2] audit: Mark CONFIG_AUDITSYSCALL BROKEN and update help text

2014-05-29 Thread Steve Grubb
On Wednesday, May 28, 2014 07:40:57 PM Andy Lutomirski wrote: > >> - It assumes that syscall numbers are between 0 and 2048. > >> > > There could well be a bug here. Not questioning that. Although that > > would be patch 1/2 > > Even with patch 1, it still doesn't handle large syscall numbers -

Re: [PATCH v2 2/2] audit: Mark CONFIG_AUDITSYSCALL BROKEN and update help text

2014-05-29 Thread Steve Grubb
On Thursday, May 29, 2014 09:04:10 AM Andy Lutomirski wrote: > On Thu, May 29, 2014 at 6:05 AM, Steve Grubb wrote: > > On Wednesday, May 28, 2014 07:40:57 PM Andy Lutomirski wrote: > >> >> - It assumes that syscall numbers are between 0 and 2048. > >> >>

Re: Why is syscall auditing on with no rules?

2014-02-03 Thread Steve Grubb
On Saturday, February 01, 2014 06:51:56 PM Andy Lutomirski wrote: > On Sat, Feb 1, 2014 at 6:32 PM, Andy Lutomirski wrote: > > On a stock Fedora installation: > > > > $ sudo auditctl -l > > No rules What rules would you want? The audit package ships with several which affects performance to var

Re: [PATCH] audit: Only use the syscall slowpath when syscall audit rules exist

2014-02-03 Thread Steve Grubb
On Monday, February 03, 2014 09:53:23 AM Andy Lutomirski wrote: > This toggles TIF_SYSCALL_AUDIT as needed when rules change instead of > leaving it set whenever rules might be set in the future. This reduces > syscall latency from >60ns to closer to 40ns on my laptop. Does this mean that we have

Re: [PATCH v5 3/3] audit: Audit proc//cmdline aka proctitle

2014-02-06 Thread Steve Grubb
On Thursday, February 06, 2014 10:15:28 AM William Roberts wrote: > During an audit event, cache and print the value of the process's > proctitle value (proc//cmdline). This is useful in situations > where processes are started via fork'd virtual machines where the > comm field is incorrect. Often

Re: [RFC][PATCH] audit: log join and part events to the read-only multicast log socket

2014-10-21 Thread Steve Grubb
On Tuesday, October 07, 2014 03:03:14 PM Eric Paris wrote: > On Tue, 2014-10-07 at 14:23 -0400, Richard Guy Briggs wrote: > > Log the event when a client attempts to connect to the netlink audit > > multicast socket, requiring CAP_AUDIT_READ capability, binding to the > > AUDIT_NLGRP_READLOG group.

Re: [RFC][PATCH] audit: log join and part events to the read-only multicast log socket

2014-10-21 Thread Steve Grubb
On Tuesday, October 21, 2014 05:08:22 PM Richard Guy Briggs wrote: > On 14/10/21, Steve Grubb wrote: > > > super crazy yuck. audit_log_task_info() ?? > > > > audit_log_task_info logs too much information for typical use. There are > > times when you might want t

Re: [PATCH V5 0/5] audit by executable name

2014-10-21 Thread Steve Grubb
On Tuesday, October 21, 2014 05:56:36 PM Paul Moore wrote: > On Monday, October 20, 2014 07:33:39 PM Steve Grubb wrote: > > On Monday, October 20, 2014 07:02:33 PM Paul Moore wrote: > > > On Monday, October 20, 2014 06:47:27 PM Eric Paris wrote: > > > > On Mon, 20

Re: [PATCH V4 (was V6)] audit: use macros for unset inode and device values

2015-08-05 Thread Steve Grubb
On Wednesday, August 05, 2015 03:16:58 PM Paul Moore wrote: > On Wednesday, August 05, 2015 02:30:14 AM Richard Guy Briggs wrote: > > On 15/08/04, Paul Moore wrote: > > > On Saturday, August 01, 2015 03:42:23 PM Richard Guy Briggs wrote: > > > > Signed-off-by: Richard Guy Briggs > > > > --- > > >

Re: [PATCH V9 3/3] audit: add audit by children of executable path

2015-08-06 Thread Steve Grubb
On Thursday, August 06, 2015 04:24:58 PM Paul Moore wrote: > On Wednesday, August 05, 2015 04:29:38 PM Richard Guy Briggs wrote: > > This adds the ability to audit the actions of children of a > > not-yet-running > > process. > > > > > > > > This is a split-out of a heavily modified version of a p

Re: [PATCH V2 1/2] audit: stop an old auditd being starved out by a new auditd

2015-12-16 Thread Steve Grubb
Hello Richard, Public reply this time. :-) On Wednesday, December 16, 2015 10:42:32 AM Richard Guy Briggs wrote: > Nothing prevents a new auditd starting up and replacing a valid > audit_pid when an old auditd is still running, effectively starving out > the old auditd since audit_pid no longer

Re: [PATCH] audit: convert status version to a feature bitmap

2014-11-13 Thread Steve Grubb
hich is 0x0002. > > I think you meant to ask about AUDIT_VERSION_LATEST, which would become 3. > > You *did* already ask that question in a previous thread, and there > didn't seem to be a concern. Steve Grubb could likely answer this > question better than me. The

Re: [PATCH V5 0/5] audit by executable name

2014-10-20 Thread Steve Grubb
On Thursday, October 02, 2014 11:06:51 PM Richard Guy Briggs wrote: > This is a part of Peter Moody, my and Eric Paris' work to implement > audit by executable name. Does this patch set define an AUDIT_VERSION_SOMETHING and then set AUDIT_VERSION_LATEST to it? If not, I need one to tell if the ke

Re: [PATCH V5 0/5] audit by executable name

2014-10-20 Thread Steve Grubb
On Monday, October 20, 2014 07:02:33 PM Paul Moore wrote: > On Monday, October 20, 2014 06:47:27 PM Eric Paris wrote: > > On Mon, 2014-10-20 at 16:25 -0400, Steve Grubb wrote: > > > On Thursday, October 02, 2014 11:06:51 PM Richard Guy Briggs wrote: > > > > This is

Re: [PATCH V5 0/5] audit by executable name

2014-10-20 Thread Steve Grubb
On Monday, October 20, 2014 07:33:39 PM Steve Grubb wrote: > On Monday, October 20, 2014 07:02:33 PM Paul Moore wrote: > > On Monday, October 20, 2014 06:47:27 PM Eric Paris wrote: > > > On Mon, 2014-10-20 at 16:25 -0400, Steve Grubb wrote: > > > > On Thursday, Octobe

Re: [RFC][PATCH] audit: log join and part events to the read-only multicast log socket

2014-10-11 Thread Steve Grubb
On Tue, 07 Oct 2014 18:06:51 -0400 Paul Moore wrote: > On Tuesday, October 07, 2014 03:39:51 PM Richard Guy Briggs wrote: > > I also thought of moving audit_log_task() from auditsc.c to audit.c > > and using that. For that matter, both audit_log_task() and > > audit_log_task_info() could use aud

Re: [PATCH V6 05/10] audit: log creation and deletion of namespace instances

2015-05-14 Thread Steve Grubb
On Tuesday, May 12, 2015 03:57:59 PM Richard Guy Briggs wrote: > On 15/05/05, Steve Grubb wrote: > > I think there needs to be some more discussion around this. It seems like > > this is not exactly recording things that are useful for audit. > > It seems to me that either

Re: [PATCH V6 05/10] audit: log creation and deletion of namespace instances

2015-05-14 Thread Steve Grubb
On Thursday, May 14, 2015 10:42:38 AM Eric W. Biederman wrote: > Steve Grubb writes: > > On Tuesday, May 12, 2015 03:57:59 PM Richard Guy Briggs wrote: > >> On 15/05/05, Steve Grubb wrote: > >> > I think there needs to be some more discussion around this. It seems

Re: [PATCH V6 05/10] audit: log creation and deletion of namespace instances

2015-05-15 Thread Steve Grubb
On Thursday, May 14, 2015 11:23:09 PM Andy Lutomirski wrote: > On Thu, May 14, 2015 at 7:32 PM, Richard Guy Briggs wrote: > > On 15/05/14, Paul Moore wrote: > >> * Look at our existing audit records to determine which records should > >> have > >> namespace and container ID tokens added. We may o

Re: [PATCH V6 05/10] audit: log creation and deletion of namespace instances

2015-05-15 Thread Steve Grubb
On Thursday, May 14, 2015 08:31:45 PM Eric W. Biederman wrote: > Paul Moore writes: > > As Eric, and others, have stated, the container concept is a userspace > > idea, not a kernel idea; the kernel only knows, and cares about, > > namespaces. This is unlikely to change. > > > > However, as Stev

Re: [PATCH V6 05/10] audit: log creation and deletion of namespace instances

2015-05-05 Thread Steve Grubb
On Tuesday, May 05, 2015 09:56:03 AM Eric W. Biederman wrote: > Steve Grubb writes: > > The requirements for auditing of containers should be derived from VPP. In > > it, it asks for selectable auditing, selective audit, and selective audit > > review. What this mean

Re: [PATCH V6 05/10] audit: log creation and deletion of namespace instances

2015-05-05 Thread Steve Grubb
On Tuesday, May 05, 2015 10:31:20 AM Aristeu Rozanski wrote: > Hi Steve, > > On Tue, May 05, 2015 at 10:22:32AM -0400, Steve Grubb wrote: > > The requirements for auditing of containers should be derived from VPP. In > > it, it asks for selectable auditing, selective audit

Re: [PATCH V6 05/10] audit: log creation and deletion of namespace instances

2015-05-05 Thread Steve Grubb
Hello, I think there needs to be some more discussion around this. It seems like this is not exactly recording things that are useful for audit. On Friday, April 17, 2015 03:35:52 AM Richard Guy Briggs wrote: > Log the creation and deletion of namespace instances in all 6 types of > namespaces.

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-22 Thread Steve Grubb
On Thursday, April 21, 2016 09:29:57 PM Paul Moore wrote: > On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: > > The tty field was missing from AUDIT_LOGIN events. > > > > Refactor code to create a new function audit_get_tty(), using it to > > replace the call in audit_log_task_info() a

Re: [RFC] Create an audit record of USB specific details

2016-04-05 Thread Steve Grubb
On Tuesday, April 05, 2016 07:02:48 PM Oliver Neukum wrote: > On Tue, 2016-04-05 at 18:40 +1000, Wade Mealing wrote: > > Consider the following scenario. Currently we have device drivers > > that emit text via a printk request which is eventually picked up by > > syslog like implementation (not th

Re: [RFC] Create an audit record of USB specific details

2016-04-04 Thread Steve Grubb
On Monday, April 04, 2016 05:56:26 AM Greg KH wrote: > On Mon, Apr 04, 2016 at 12:02:42AM -0400, wmealing wrote: > > From: Wade Mealing > > > > Gday, > > > > I'm looking to create an audit trail for when devices are added or removed > > from the system. > > Then please do it in userspace, as I

Re: [RFC] Create an audit record of USB specific details

2016-04-04 Thread Steve Grubb
On Monday, April 04, 2016 12:02:42 AM wmealing wrote: > I'm looking to create an audit trail for when devices are added or removed > from the system. > > The audit subsystem is a logging subsystem in kernel space that can be > used to create advanced filters on generated events. It has partnered

Re: [PATCH v2 0/5] Add support for O_MAYEXEC

2019-09-06 Thread Steve Grubb
On Friday, September 6, 2019 11:24:50 AM EDT Mickaël Salaün wrote: > The goal of this patch series is to control script interpretation. A > new O_MAYEXEC flag used by sys_open() is added to enable userspace > script interpreter to delegate to the kernel (and thus the system > security policy) the

Re: [PATCH v2 0/5] Add support for O_MAYEXEC

2019-09-06 Thread Steve Grubb
On Friday, September 6, 2019 2:57:00 PM EDT Florian Weimer wrote: > * Steve Grubb: > > Now with LD_AUDIT > > $ LD_AUDIT=/home/sgrubb/test/openflags/strip-flags.so.0 strace ./test > > 2>&1 | grep passwd openat(3, "passwd", O_RDONLY) = 4 > > >

Re: [PATCH ghak25 v4 3/3] audit: add subj creds to NETFILTER_CFG record to cover async unregister

2020-04-29 Thread Steve Grubb
On Wednesday, April 29, 2020 10:31:46 AM EDT Richard Guy Briggs wrote: > On 2020-04-28 18:25, Paul Moore wrote: > > On Wed, Apr 22, 2020 at 5:40 PM Richard Guy Briggs wrote: > > > Some table unregister actions seem to be initiated by the kernel to > > > garbage collect unused tables that are not

Re: [PATCH] audit: always enable syscall auditing when supported and audit is enabled

2019-01-28 Thread Steve Grubb
On Mon, 28 Jan 2019 11:26:51 -0500 Paul Moore wrote: > On Mon, Jan 28, 2019 at 10:38 AM Sverdlin, Alexander (Nokia - DE/Ulm) > wrote: > > Hello Paul, > > > > On 28/01/2019 15:52, Paul Moore wrote: > > > time also enables syscall auditing; this patch simplifies the > > > Kconfig menus b

Re: [PATCH] audit: always enable syscall auditing when supported and audit is enabled

2019-01-28 Thread Steve Grubb
On Mon, 28 Jan 2019 15:08:56 -0500 Paul Moore wrote: > On Mon, Jan 28, 2019 at 3:03 PM Steve Grubb wrote: > > On Mon, 28 Jan 2019 11:26:51 -0500 > > Paul Moore wrote: > > > > > On Mon, Jan 28, 2019 at 10:38 AM Sverdlin, Alexander (Nokia - > > &g

Re: [PATCH ghak59 V3 2/4] audit: add syscall information to CONFIG_CHANGE records

2019-01-17 Thread Steve Grubb
On Mon, 14 Jan 2019 17:58:58 -0500 Paul Moore wrote: > On Mon, Dec 10, 2018 at 5:18 PM Richard Guy Briggs > wrote: > > > > Tie syscall information to all CONFIG_CHANGE calls since they are > > all a result of user actions. Please don't tie syscall information to this. The syscall will be sendto

Re: [PATCH ghak59 V3 2/4] audit: add syscall information to CONFIG_CHANGE records

2019-01-17 Thread Steve Grubb
On Thu, 17 Jan 2019 08:21:40 -0500 Paul Moore wrote: > On Thu, Jan 17, 2019 at 4:33 AM Steve Grubb wrote: > > On Mon, 14 Jan 2019 17:58:58 -0500 > > Paul Moore wrote: > > > > > On Mon, Dec 10, 2018 at 5:18 PM Richard Guy Briggs > > > wrote: > &g

Re: [RFC PATCH ghak10 v6 1/2] timekeeping: Audit clock adjustments

2019-03-08 Thread Steve Grubb
On Thursday, March 7, 2019 7:32:53 AM EST Ondrej Mosnacek wrote: > Emit an audit record whenever the system clock is changed (i.e. shifted > by a non-zero offset) by a syscall from userspace. The syscalls than can > (at the time of writing) trigger such record are: > - settimeofday(2), stime(2),

  1   2   >