Re: [PATCH v7 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ Firmware bindings

2018-08-03 Thread Stephen Boyd
Quoting Taniya Das (2018-07-24 03:42:49) > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt > b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt > new file mode 100644 > index 000..22d4355 > --- /dev/null > +++ b/Documentation/devicetree/bindings/cpufreq/

[PATCH] firmware: coreboot: Let OF core populate platform device

2018-08-06 Thread Stephen Boyd
DT node created during module init. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Cc: Thierry Escande Signed-off-by: Stephen Boyd --- drivers/firmware/google/coreboot_table-of.c | 39 + 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/d

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

2018-08-06 Thread Stephen Boyd
Quoting Brian Norris (2018-08-06 10:38:08) > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > > Now that the /firmware/coreboot node in DT is populated by the core DT > > platform code with commit 3aa0582fdb82 ("of: platform: populate >

Re: [PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs

2018-08-07 Thread Stephen Boyd
Quoting Songjun Wu (2018-08-02 20:02:21) > From: Yixin Zhu > > This driver provides PLL clock registration as well as various clock > branches, e.g. MUX clock, gate clock, divider clock and so on. > > PLLs that provide clock to DDR, CPU and peripherals are shown below: > > +---

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-07 Thread Stephen Boyd
Quoting Jordan Crouse (2018-08-06 08:04:37) > On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > > On 2018-08-03 04:14, Stephen Boyd wrote: > > >Quoting Amit Nischal (2018-07-30 04:28:56) > > >>On 2018-07-25 12:28, Stephen Boyd wrote: > > >>&g

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

2018-08-07 Thread Stephen Boyd
Quoting Brian Norris (2018-08-07 14:41:04) > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > > diff --git a/drivers/firmware/google/coreboot_table-of.c > > b/drivers/firmware/google/coreboot_table-of.c > > index f15bf404c579..270f112bdc54 100644 > > --

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-07 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-02 05:58:27) > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > >Sure. But once woken up (GIC *and* TLMM), the gpio line (which I > >assume is level) is still high at the TLMM input. So why isn't it > >registering that state once it has been woken up? > > > >

Re: [PATCH v7 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ Firmware bindings

2018-08-07 Thread Stephen Boyd
Quoting Taniya Das (2018-08-07 19:46:01) > > > On 8/8/2018 12:54 AM, skan...@codeaurora.org wrote: > > On 2018-08-07 04:12, Sudeep Holla wrote: > >> On Mon, Aug 06, 2018 at 01:54:24PM -0700, skan...@codeaurora.org wrote: > >>> On 2018-08-03 16:46, Stephen B

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-07 Thread Stephen Boyd
Quoting skan...@codeaurora.org (2018-08-06 13:46:05) > On 2018-08-03 15:24, Stephen Boyd wrote: > > Quoting skan...@codeaurora.org (2018-08-03 12:52:48) > >> On 2018-08-03 12:40, Evan Green wrote: > >> > Hi Taniya, > >> > > >>

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-21 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-06-19 23:45:09) > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > @@ -647,6 +660,10 @@ static void msm_gpio_irq_unmask(struct irq_data *d) > > raw_spin_lock_irqsave(&pctrl->lock, flags); > > > > val = r

[PATCH v2] HID: i2c-hid: Add vddl regulator control

2018-06-21 Thread Stephen Boyd
sable. Cc: Benjamin Tissoires Cc: Hans de Goede Cc: Andy Shevchenko Cc: Dmitry Torokhov Cc: Doug Anderson Acked-by: Rob Herring Cc: Signed-off-by: Stephen Boyd --- Changes from v1: * Use the bulk regulator APIs instead of open coding it (Dmitry) .../bindings/input/hid-over-i2c.txt

Re: [PATCH v2] HID: i2c-hid: Add vddl regulator control

2018-06-21 Thread Stephen Boyd
Quoting Dmitry Torokhov (2018-06-21 16:58:31) > On Thu, Jun 21, 2018 at 4:41 PM Stephen Boyd wrote: > > > > Some wacom w9013 devices have a vddl supply for "low valtage" > > requirements. Add support in this driver to turn on this low voltage > > supply

[PATCH v3 2/2] HID: i2c-hid: Add vddl regulator control

2018-06-21 Thread Stephen Boyd
sable. Cc: Benjamin Tissoires Cc: Hans de Goede Cc: Andy Shevchenko Cc: Dmitry Torokhov Cc: Doug Anderson Acked-by: Rob Herring Cc: Signed-off-by: Stephen Boyd --- .../bindings/input/hid-over-i2c.txt | 3 +- drivers/hid/i2c-hid/i2c-hid.c | 48 +-- inc

[PATCH v3 1/2] HID: i2c-hid: Use devm to allocate i2c_hid struct

2018-06-21 Thread Stephen Boyd
o Cc: Dmitry Torokhov Cc: Doug Anderson Signed-off-by: Stephen Boyd --- drivers/hid/i2c-hid/i2c-hid.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index c1652bb7bd15..c7d6738dc524 100644 --- a/drivers/hi

[PATCH v3 0/2] Add another regulator to i2c-hid

2018-06-21 Thread Stephen Boyd
allocation into another patch (Dmitry) * Drop errant error print that snuck in across port Cc: Benjamin Tissoires Cc: Hans de Goede Cc: Andy Shevchenko Cc: Dmitry Torokhov Cc: Doug Anderson Stephen Boyd (2): HID: i2c-hid: Use devm to allocate i2c_hid struct HID: i2c-hid: Add vddl regulator

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-06-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-06-22 09:54:54) > On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote: > > > This macro doesn't work, because it hides a local variable inside of the > > macro to hold the version and that variable name is called 'ver' and > > &#x

Re: [PATCH 1/2] slimbus: stream: add stream support

2018-06-25 Thread Stephen Boyd
Quoting Srinivas Kandagatla (2018-06-21 06:40:08) > new file mode 100644 > index ..f8af9474d286 > --- /dev/null > +++ b/drivers/slimbus/stream.c > @@ -0,0 +1,493 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (c) 2018, Linaro Limited > + > +#include > +#include > +#include

Re: [PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs

2018-08-27 Thread Stephen Boyd
Quoting yixin zhu (2018-08-08 01:52:20) > On 8/8/2018 1:50 PM, Stephen Boyd wrote: > > Quoting Songjun Wu (2018-08-02 20:02:21) > >> + struct clk *clk; > >> + int idx; > >> + > >> + for (idx = 0; idx < nr_clks; idx++,

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-27 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-24 10:14:32) > On Fri, Aug 24 2018 at 02:22 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2018-08-17 12:10:23) > >> During suspend the system may power down some of the system rails. As a > >> result, the TLMM hw block may not be ope

Re: [PATCH v4 0/2] clk: qcom: Add support for RCG to register for DFS

2018-08-27 Thread Stephen Boyd
Quoting Stephen Boyd (2018-08-23 11:25:41) > Quoting Taniya Das (2018-08-22 03:28:31) > > > > > > > > H. Ok. That won't work then. recalc_rate() better not try to > > > populate the frequency table then or it will not work. So I suppose it > > &

Re: [PATCH v3 2/2] clk: qcom: Add lpass clock controller driver for SDM845

2018-08-27 Thread Stephen Boyd
Quoting Taniya Das (2018-08-03 05:21:14) > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index 2b69cf2..7bd940d 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -254,6 +254,15 @@ config SDM_VIDEOCC_845 > Say Y if you want to support video

Re: [PATCH v3 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings

2018-08-27 Thread Stephen Boyd
Quoting Taniya Das (2018-08-03 05:21:13) > Add device tree bindings for Low Power Audio subsystem clock controller for > Qualcomm Technology Inc's SDM845 SoCs. > > Signed-off-by: Taniya Das > --- > .../devicetree/bindings/clock/qcom,gcc.txt | 2 ++ > .../devicetree/bindings/clock/qcom,l

Re: [PATCH 1/3] clk: max77686: Add SPDX license identifiers

2018-08-27 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2018-08-07 09:17:11) > Replace GPL v2.0 and v2.0+ license statements with SPDX license > identifiers. > > Signed-off-by: Krzysztof Kozlowski > --- Applied to clk-next

Re: [PATCH 2/3] clk: s2mps11,s3c64xx: Add SPDX license identifiers

2018-08-27 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2018-08-07 09:17:12) > Replace GPL v2.0 and v2.0+ license statements with SPDX license > identifiers. > > Signed-off-by: Krzysztof Kozlowski > --- Applied to clk-next

Re: [PATCH 3/3] clk: s2mps11: Use existing defines from bindings for clock IDs

2018-08-27 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2018-08-07 09:17:13) > The clock IDs must match between DeviceTree bindings and the driver. > There is already a header file used by DeviceTree sources so include it > in the driver to remove duplicated symbols. > > Signed-off-by: Krzysztof Kozlowski > --- Applied to

Re: [PATCH] clk: npcm7xx: fix memory allocation

2018-08-28 Thread Stephen Boyd
Quoting Gustavo A. R. Silva (2018-08-23 16:06:54) > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int

Re: [PATCH] clk: x86: Set default parent to 48Mhz

2018-08-28 Thread Stephen Boyd
Quoting Akshu Agrawal (2018-08-20 23:51:57) > System clk provided in ST soc can be set to: > 48Mhz, non-spread > 25Mhz, spread > To get accurate rate, we need it to set it at non-spread > option which is 48Mhz. > > Signed-off-by: Akshu Agrawal Does this need to go to 4.18 stable trees? I don't s

Re: [PATCH] clk: ti: fix OF child-node lookup

2018-08-28 Thread Stephen Boyd
Quoting Johan Hovold (2018-08-22 02:03:19) > Fix child-node lookup which by using the wrong OF helper was searching > the whole tree depth-first, something which could end up matching an > unrelated node. > > Also fix the related node-reference leaks. > > Fixes: 5b385a45e001 ("clk: ti: add suppor

Re: [PATCH 3/5] drivers: clk-qoriq: Add clockgen support for lx2160a

2018-08-28 Thread Stephen Boyd
gesh Gaur > Signed-off-by: Vabhav Sharma > --- Acked-by: Stephen Boyd

Re: [PATCH v2] clk: qcom: Add some missing gcc clks for msm8996

2018-08-28 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-08-13 11:43:51) > On Fri 10 Aug 08:11 PDT 2018, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2018-08-09 15:01:19) > > > From: Rajendra Nayak > > > > > > Add a few missing gcc clks for msm8996 > > > > &g

Re: [PATCH v3 1/2] clk: qcom: Add qspi (Quad SPI) clock defines for sdm845 to header

2018-08-28 Thread Stephen Boyd
Quoting Douglas Anderson (2018-07-24 10:45:12) > These clocks will need to be defined in the clock driver and > referenced in device tree files. > > Signed-off-by: Douglas Anderson > --- Applied to clk-next

Re: [PATCH v3 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-08-28 Thread Stephen Boyd
Quoting Douglas Anderson (2018-07-24 10:45:13) > Add both the interface and core clock. > > Signed-off-by: Douglas Anderson > (am from https://lore.kernel.org/patchwork/patch/966680/mbox) > > --- Applied to clk-next

RE: [PATCH V3 0/4] clk: new APIs to handle all available clocks

2018-08-28 Thread Stephen Boyd
Quoting A.s. Dong (2018-08-16 19:33:52) > Hi Stephen, > > Do you want me to resend this series for review? > It seems have been pending for quite a long time. > > Thor just pinged me for its status as he wants to use it. > I was waiting for someone to try them out or review them. Good that it h

[PATCH v2 0/2] firmware: coreboot: Fix probe and simplify code

2018-08-08 Thread Stephen Boyd
DT based platforms. Stephen Boyd (2): firmware: coreboot: Let OF core populate platform device firmware: coreboot: Collapse platform drivers into bus core drivers/firmware/google/Kconfig | 28 +++--- drivers/firmware/google/Makefile | 2 - drivers/firmware/google

[PATCH v2 1/2] firmware: coreboot: Let OF core populate platform device

2018-08-08 Thread Stephen Boyd
/firmware/ node from of_platform_default_populate_init()") Signed-off-by: Stephen Boyd --- drivers/firmware/google/coreboot_table-of.c | 28 +++-- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/firmware/google/coreboot_table-of.c b/drivers/firmware/google/coreboot_table-of.c index f

[PATCH v2 2/2] firmware: coreboot: Collapse platform drivers into bus core

2018-08-08 Thread Stephen Boyd
old hidden configs. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Cc: Sudeep Holla Signed-off-by: Stephen Boyd --- drivers/firmware/google/Kconfig | 28 +++--- drivers/firmware/google/Makefile | 2 - drivers/firmware/google/coreboot_table-a

Re: [PATCH v2 2/2] firmware: coreboot: Collapse platform drivers into bus core

2018-08-08 Thread Stephen Boyd
Quoting Julius Werner (2018-08-08 12:07:30) > > +config GOOGLE_COREBOOT_TABLE_ACPI > > + tristate > > + default GOOGLE_COREBOOT_TABLE > > I don't think this helps in upgrading (as your commit message says) > unless you also keep the 'select GOOGLE_COREBOOT_TABLE' here, right? Oh yes s

Re: [PATCH v1 2/3] dt-bindings: i3c: Document Qualcomm GENI I3C master bindings

2018-08-09 Thread Stephen Boyd
Quoting Mike Shettel (2018-07-31 22:39:01) > Signed-off-by: Mike Shettel You need to write some commit text here. Otherwise we don't know why we want to even look at the patch. > diff --git a/Documentation/devicetree/bindings/i3c/qcom,geni-i3c.txt > b/Documentation/devicetree/bindings/i3c/qcom,

Re: [PATCH v1 1/3] i3c: master: Add a driver for Qualcomm GENI I3C master IP

2018-08-09 Thread Stephen Boyd
Quoting Mike Shettel (2018-07-31 22:39:00) > Signed-off-by: Mike Shettel Some commit text please. > --- > This patch is to be applied on top of the I3C subsystem patchset v6. > drivers/i3c/master/Kconfig| 13 + > drivers/i3c/master/Makefile |1 + > drivers/i3

[PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
y the memory mapping at the same time to keep error paths simpler. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Suggested-by: Julius Werner Signed-off-by: Stephen Boyd --- drivers/firmware/google/coreboot_table.c | 66 +++- 1 file changed, 29 inser

[PATCH v3 5/7] firmware: coreboot: Remap RAM with memremap() instead of ioremap()

2018-08-09 Thread Stephen Boyd
emap_cache() like is being done here already. This also nicely silences the sparse warnings in this code and reduces the need to copy anything around anymore. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Signed-off-by: Stephen Boyd --- drivers/firmware/google/c

[PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Stephen Boyd
g Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Signed-off-by: Stephen Boyd --- drivers/firmware/google/coreboot_table.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/google/coreboot_ta

[PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric

2018-08-09 Thread Stephen Boyd
#x27;s move the registration to the coreboot_table_init() function so that it matches the exit path. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Signed-off-by: Stephen Boyd --- drivers/firmware/google/coreboot_table.c | 14 +++--- 1 file changed, 7 i

[PATCH v3 2/7] firmware: coreboot: Unmap ioregion on failure

2018-08-09 Thread Stephen Boyd
. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Fixes: 570d30c2823f ("firmware: coreboot: Expose the coreboot table as a bus") Signed-off-by: Stephen Boyd --- drivers/firmware/google/coreboot_table.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dri

[PATCH v3 4/7] firmware: coreboot: Collapse platform drivers into bus core

2018-08-09 Thread Stephen Boyd
en configs. Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Signed-off-by: Stephen Boyd --- drivers/firmware/google/Kconfig | 26 +++--- drivers/firmware/google/Makefile | 2 - drivers/firmware/google/coreboot_table-a

[PATCH v3 1/7] firmware: coreboot: Let OF core populate platform device

2018-08-09 Thread Stephen Boyd
/firmware/ node from of_platform_default_populate_init()") Signed-off-by: Stephen Boyd --- drivers/firmware/google/coreboot_table-of.c | 28 +++-- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/firmware/google/coreboot_table-of.c b/drivers/firmware/google/coreboot_tabl

[PATCH v3 0/7] firmware: coreboot: Fix probe and simplify code

2018-08-09 Thread Stephen Boyd
usive access to table region * Pull out table signature check to driver probe Changes from v1: * Split out fixlet for DT based driver from platform driver change Cc: Wei-Ning Huang Cc: Julius Werner Cc: Brian Norris Cc: Samuel Holland Stephen Boyd (7): firmware: coreboot: Let OF core pop

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-09 Thread Stephen Boyd
Quoting Marc Zyngier (2018-08-07 23:26:32) > On Tue, 07 Aug 2018 23:05:07 -0700 > Stephen Boyd wrote: > > > Quoting Lina Iyer (2018-08-02 05:58:27) > > > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > > > > > >Sure. But once w

Re: [PATCH v3 2/7] firmware: coreboot: Unmap ioregion on failure

2018-08-09 Thread Stephen Boyd
Quoting Brian Norris (2018-08-09 10:49:38) > On Thu, Aug 09, 2018 at 10:17:17AM -0700, Stephen Boyd wrote: > > Both callers of coreboot_table_init() ioremap the pointer that comes in > > but they don't unmap the memory on failure. Both of them also fail probe > > immedia

Re: [PATCH v3 5/7] firmware: coreboot: Remap RAM with memremap() instead of ioremap()

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 11:24:29) > One thing to note is that we still want this space to be mappable by > userspace applications via /dev/mem, so we need to make sure that > there's no weird memory type mismatch that causes problems with that. > Adding Aaron to see if he has any concerns

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:07:31) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > > > Call request_mem_region() on the entire coreboot table to make sure > > other devices don't attempt to map the coreboot table in their drivers. > > If driver

Re: [PATCH v3 2/7] firmware: coreboot: Unmap ioregion on failure

2018-08-09 Thread Stephen Boyd
Quoting Brian Norris (2018-08-09 12:52:13) > Hi, > > On Thu, Aug 09, 2018 at 12:40:31PM -0700, Stephen Boyd wrote: > > Quoting Brian Norris (2018-08-09 10:49:38) > > > On Thu, Aug 09, 2018 at 10:17:17AM -0700, Stephen Boyd wrote: > > > > Both callers of coreb

Re: [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 11:10:42) > > @@ -138,8 +136,10 @@ int coreboot_table_init(struct device *dev, void > > __iomem *ptr) > > ptr_entry += entry.size; > > } > > > > - if (ret) > > + if (ret) { > > + bus_unregister(&coreboot_bus_type);

Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:02:53) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > @@ -162,26 +143,37 @@ static int coreboot_table_probe(struct > > platform_device *pdev) > > if (!res->start || !len) > > return -EINVAL; &g

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Stephen Boyd
What's with the top posting? ;-) Quoting Julius Werner (2018-08-09 16:44:43) > Actually, looking at what IO_STRICT_DEVMEM really does, would it > really prevent userspace accesses to these areas? Because it seems > that it only prevents accesses to areas marked as IORESOURCE_BUSY, and > while I ca

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-10 Thread Stephen Boyd
Quoting Marc Zyngier (2018-08-10 00:45:12) > On Thu, 09 Aug 2018 18:30:53 +0100, > Stephen Boyd wrote: > > > > Quoting Marc Zyngier (2018-08-07 23:26:32) > > > > > > Level interrupts should be taken care of without doing anything, by the > > > very n

Re: [PATCH v2] clk: qcom: Add some missing gcc clks for msm8996

2018-08-10 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-08-09 15:01:19) > From: Rajendra Nayak > > Add a few missing gcc clks for msm8996 > > Signed-off-by: Rajendra Nayak > [bjorn: omit aggre0_noc_qosgen_extref_clk] > Signed-off-by: Bjorn Andersson > --- This is still going on?! I'm going to ignore Rob's auto email o

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-10 Thread Stephen Boyd
Quoting Stephen Boyd (2018-08-09 19:54:27) > What's with the top posting? ;-) > > Quoting Julius Werner (2018-08-09 16:44:43) > > Actually, looking at what IO_STRICT_DEVMEM really does, would it > > really prevent userspace accesses to these areas? Because it seems

Re: [PATCH v4 0/2] clk: qcom: Add support for RCG to register for DFS

2018-08-21 Thread Stephen Boyd
Quoting Taniya Das (2018-08-21 04:36:20) > On 8/18/2018 11:31 PM, Taniya Das wrote: > > Hello Stephen, > > > > I will test these changes and get back. > > > > On 8/18/2018 7:42 AM, Stephen Boyd wrote: > >> Quoting Taniya Das (2018-08-10 18:53:54) >

Re: [PATCH v4 0/2] clk: qcom: Add support for RCG to register for DFS

2018-08-23 Thread Stephen Boyd
Quoting Taniya Das (2018-08-22 03:28:31) > > > > > H. Ok. That won't work then. recalc_rate() better not try to > > populate the frequency table then or it will not work. So I suppose it > > needs to fallback to reading the registers and assuming the parent_rate > > coming in is the actual fr

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-23 Thread Stephen Boyd
Quoting Taniya Das (2018-08-08 03:15:26) > > > On 8/8/2018 11:52 AM, Stephen Boyd wrote: > >> > >> Binding describes hardware controllable by the OS. That's the reality. > >> Let's not add mandatory clock bindings for clocks that the OS can't

Re: [PATCH v1 1/1] Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990

2018-08-23 Thread Stephen Boyd
Quoting Balakrishna Godavarthi (2018-08-23 04:29:35) > This patch enables power off support for hci down and power on support > for hci up. As wcn3990 power sources are ignited by regulators, we will > turn off them during hci down, i.e. an complete power off of wcn3990. > So while hci up, we will

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-24 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-17 12:10:23) > During suspend the system may power down some of the system rails. As a > result, the TLMM hw block may not be operational anymore and wakeup > capable GPIOs will not be detected. The PDC however will be operational > and the GPIOs that are routed to the PD

Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-24 Thread Stephen Boyd
Quoting Venkata Narendra Kumar Gutta (2018-08-17 17:08:34) > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig > index 57304b2..da8f150 100644 > --- a/drivers/edac/Kconfig > +++ b/drivers/edac/Kconfig > @@ -460,4 +460,32 @@ config EDAC_TI > Support for error detection and correctio

Re: [PATCH v3 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-08-24 Thread Stephen Boyd
Quoting Douglas Anderson (2018-08-22 10:36:27) > From: Manu Gautam > > This adds nodes for USB and related PHYs. > > Signed-off-by: Manu Gautam > [dianders: reworked quite a bit] > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 2/3] arm64: dts: qcom: sdm845-mtp: Add RPMh VRM/XOB regulators

2018-08-24 Thread Stephen Boyd
on one originally shared to me by > David Collins. > > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 3/3] arm64: dts: qcom: sdm845-mtp: Add nodes for USB

2018-08-24 Thread Stephen Boyd
r > left things configured enough for us. Apparently the magic for that > is is to do these writes on pmi8998: > - pm_comm_write_byte(2, 0x1153, 0x2C, 0); > - pm_comm_write_byte(2, 0x1152, 0x07, 0); > - pm_comm_write_byte(2, 0x1140, 0x00, 0); > - pm_comm_write_byte(2, 0x1140, 0x01, 0); > > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [PATCH] clk: tegra: probe deferral error reporting

2018-07-26 Thread Stephen Boyd
Quoting Peter Geis (2018-07-25 16:42:34) > On 7/25/2018 7:24 PM, Stephen Boyd wrote: > > Quoting Marcel Ziswiler (2018-07-20 00:54:22) > >> From: Marcel Ziswiler > >> > >> Actually report the error code from devm_regulator_get() which may as > >> we

Re: [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable

2018-07-26 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2018-07-18 12:56:20) > Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning: > > drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning: > 'mout_user_aclk400_mcuisp_p4x12' defined but not used > [-Wunused-const-variable=] > > Signed

Re: [PATCH v3 2/2] clk: meson: add sub MMC clock controller driver

2018-07-26 Thread Stephen Boyd
Quoting Yixun Lan (2018-07-12 14:12:44) > diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c > new file mode 100644 > index ..36c4c7cd69a6 > --- /dev/null > +++ b/drivers/clk/meson/mmc-clkc.c > @@ -0,0 +1,367 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/

Re: [Linux-kernel] tegra clock updates and fixes

2018-07-26 Thread Stephen Boyd
Quoting Ben Dooks (2018-07-26 06:32:29) > On 2018-07-20 14:45, Ben Dooks wrote: > > Hi, this is a set of clock updates and fixes we did when developing > > the tegra20/tegra30 auto support. The audio change is due to using > > the tegra in clock-slave mode (this hasn't been done before) > > > > We

RE: [PATCH] clk: clk-fixed-factor: Clear OF_POPULATED flag in case of failure

2018-07-26 Thread Stephen Boyd
Quoting Rajan Vaja (2018-07-26 06:03:16) > Hi Stephen, > > > -Original Message- > > From: Stephen Boyd [mailto:sb...@kernel.org] > > Sent: 25 July 2018 10:11 PM > > To: Rajan Vaja ; mturque...@baylibre.com > > Cc: linux-...@vger.kernel.org; linu

Re: [PATCH v10 00/10] drivers: Introduce firmware dnd clock river for ZynqMP core

2018-07-26 Thread Stephen Boyd
via my tree and arm-soc tree. > >> > >> I have applied 01-08 here > >> https://github.com/Xilinx/linux-xlnx/commits/zynqmp/soc > >> > >> Thanks, > >> Michal > > > > > > Thanks for merging the patches. > > By mis

Re: [PATCH] clk: tegra: probe deferral error reporting

2018-07-26 Thread Stephen Boyd
Quoting Stefan Agner (2018-07-26 00:55:16) > On 26.07.2018 09:31, Stephen Boyd wrote: > > Quoting Peter Geis (2018-07-25 16:42:34) > >> On 7/25/2018 7:24 PM, Stephen Boyd wrote: > >> > Quoting Marcel Ziswiler (2018-07-20 00:54:22) > >> >> From: Marcel

Re: [PATCH 2/2] clk: qcom: Add camera clock controller driver for SDM845

2018-07-26 Thread Stephen Boyd
Quoting Amit Nischal (2018-07-23 04:26:33) > diff --git a/drivers/clk/qcom/camcc-sdm845.c b/drivers/clk/qcom/camcc-sdm845.c > new file mode 100644 > index 000..61e5ec2 > --- /dev/null > +++ b/drivers/clk/qcom/camcc-sdm845.c > @@ -0,0 +1,1736 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + *

Re: [PATCH 1/2] dt-bindings: clock: Introduce QCOM Camera clock bindings

2018-07-26 Thread Stephen Boyd
Quoting Amit Nischal (2018-07-23 04:26:32) > Add device tree bindings for camera clock controller for > Qualcomm Technology Inc's SDM845 SoCs. > > Signed-off-by: Amit Nischal > --- Applied to clk-next

Re: [PATCH v3 1/2] clk: qcom: Add support for RCG to register for DFS

2018-07-26 Thread Stephen Boyd
Quoting Taniya Das (2018-07-15 22:37:47) > diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c > index 52208d4..f8f1417 100644 > --- a/drivers/clk/qcom/clk-rcg2.c > +++ b/drivers/clk/qcom/clk-rcg2.c > @@ -929,3 +938,167 @@ static void clk_rcg2_shared_disable(struct clk_hw *hw) >

Re: [PATCH v5] clk: qcom: Add display clock controller driver for SDM845

2018-07-26 Thread Stephen Boyd
Quoting Taniya Das (2018-07-23 03:54:35) > Add support for the display clock controller found on SDM845 > based devices. This would allow display drivers to probe and > control their clocks. > > Signed-off-by: Taniya Das > --- This is fine to merge as long as you're ok with removing the no rate

Re: [PATCH] clk: scmi: Fix the rounding of clock rate

2018-07-27 Thread Stephen Boyd
Quoting Amit Daniel Kachhap (2018-07-27 07:01:52) > This fix rounds the clock rate properly by using quotient and not > remainder in the calculation. This issue was found while testing HDMI > in the Juno platform. > > Signed-off-by: Amit Daniel Kachhap Any Fixes: tag here? > --- > drivers/clk/

Re: [PATCH v3 2/2] clk: meson: add sub MMC clock controller driver

2018-07-27 Thread Stephen Boyd
Quoting Yixun Lan (2018-07-27 07:52:23) > HI Stephen: > > On 07/26/2018 11:20 PM, Stephen Boyd wrote: > > Quoting Yixun Lan (2018-07-12 14:12:44) > >> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c > >> new file mode 100644 >

Re: [PATCH v3 2/2] clk: meson: add sub MMC clock controller driver

2018-07-27 Thread Stephen Boyd
Quoting Stephen Boyd (2018-07-27 09:41:40) > Quoting Yixun Lan (2018-07-27 07:52:23) > > HI Stephen: > > > > On 07/26/2018 11:20 PM, Stephen Boyd wrote: > > > Quoting Yixun Lan (2018-07-12 14:12:44) > > >> diff --git a/drivers/clk/meson/mmc-clkc.c b/dr

RE: [PATCH] clk: Add functions to get optional clocks

2018-07-27 Thread Stephen Boyd
Quoting Phil Edworthy (2018-07-27 08:38:12) > On 25 July 2018 23:37, Stephen Boyd wrote: > > Short answer is they don't. I'd still prefer we have this API though. > > > > Can you rework this patch to be a little more invasive into the > > clk_get() path, perh

Re: [PATCH] clk: mvebu: armada-37xx-periph: Remove unused var num_parents

2018-07-27 Thread Stephen Boyd
Quoting Anders Roxell (2018-07-26 15:27:21) > When building armada-37xx-periph, num_parents isn't used in function > clk_pm_cpu_get_parent: > drivers/clk/mvebu/armada-37xx-periph.c: In function ‘clk_pm_cpu_get_parent’: > drivers/clk/mvebu/armada-37xx-periph.c:419:6: warning: unused variable > ‘num

Re: [PATCH 00/16] clk: at91: Rework DT bindings

2018-07-27 Thread Stephen Boyd
Quoting Alexandre Belloni (2018-07-17 15:27:41) > This is the promised rework of the at91 PMC clocks driver. It is mainly > necessary to remove the DTC warnings but it also complies with the CCF > rule that there should be one node per controller instead of one node > per clock. > > This only hand

Re: [PATCH] clk: scmi: Fix the rounding of clock rate

2018-07-30 Thread Stephen Boyd
Quoting Sudeep Holla (2018-07-30 04:40:56) > On Mon, Jul 30, 2018 at 11:03:51AM +0530, Amit Daniel Kachhap wrote: > > Hi, > > > > On Fri, Jul 27, 2018 at 10:07 PM, Stephen Boyd wrote: > > > Quoting Amit Daniel Kachhap (2018-07-27 07:01:52) > > >> This f

Re: [PATCH] power: reset: msm: Add support for download-mode control

2018-07-20 Thread Stephen Boyd
Quoting Rajendra Nayak (2018-07-18 23:59:20) > > > On 7/19/2018 11:12 AM, Bjorn Andersson wrote: > > On Wed 18 Jul 22:18 PDT 2018, Rajendra Nayak wrote: > > > >> commit '8c1b7dc9b: firmware: qcom: scm: Expose download-mode control' > >> added support for download-mode control using the scm firmw

Re: [PATCH v5] clk: qcom: Add display clock controller driver for SDM845

2018-08-01 Thread Stephen Boyd
Quoting Taniya Das (2018-07-23 03:54:35) > Add support for the display clock controller found on SDM845 > based devices. This would allow display drivers to probe and > control their clocks. > > Signed-off-by: Taniya Das > --- Applied to clk-next with removal of the rate cache flag.

Re: [PATCH v2 5/5] clk: RK808: add RK809 and RK817 support.

2018-08-01 Thread Stephen Boyd
Quoting Tony Xie (2018-07-31 01:00:29) > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 721572a..fc1427c 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -46,11 +46,11 @@ config COMMON_CLK_MAX77686 > clock. > > config COMMON_CLK_RK808 > - trista

Re: [PATCH v3 3/3] clk: qcom: Add display clock controller driver for SDM845

2018-07-24 Thread Stephen Boyd
Quoting spa...@codeaurora.org (2018-07-13 01:25:49) > On 2018-07-13 01:11, Stephen Boyd wrote: > > Quoting Taniya Das (2018-07-12 10:21:33) > >> ++ Display driver team, > >> > >> On 7/9/2018 8:36 PM, Stephen Boyd wrote: > >> > Quoting Taniya Das (2

Re: [PATCH v1 01/04] clk: actions: Add Actions Semi S500 SoC clock support

2018-07-24 Thread Stephen Boyd
Quoting Edgar Bernardi Righi (2018-07-18 08:32:34) > Add Actions Semi S500 SoC clock support. > Basic clock support for S500 SoC was implemented using the Actions > Semi Owl clock driver. > Tested on a Lemaker Guitar board. > > This patch depends on patch "[PATCH v6 1/5] clk: actions: Add missing

Re: [PATCH 1/4] clk: qcom: gdsc: Add support to enable/disable the clocks with GDSC

2018-07-24 Thread Stephen Boyd
Quoting Amit Nischal (2018-07-12 05:23:48) > On 2018-07-09 11:04, Stephen Boyd wrote: > > Quoting Amit Nischal (2018-06-06 04:41:45) > >> For some of the GDSCs, there is a requirement to enable/disable the > >> few clocks before turning on/off the gdsc power domain.

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-24 Thread Stephen Boyd
Quoting Amit Nischal (2018-07-12 05:30:21) > On 2018-07-09 11:45, Stephen Boyd wrote: > > Quoting Amit Nischal (2018-06-06 04:41:46) > >> To turn on the gpu_gx_gdsc, there is a hardware requirement to > >> turn on the root clock (GFX3D RCG) first which would be the turn

Re: [PATCH] clk: qcom: Update SPDX headers for common files

2018-07-25 Thread Stephen Boyd
Quoting Taniya Das (2018-07-15 22:54:32) > SPDX headers updated for common/branch/pll/regmap files. > > Signed-off-by: Taniya Das > --- Applied to clk-next

Re: [PATCH] clk: core: Potentially free connection id

2018-07-25 Thread Stephen Boyd
Quoting Mikko Perttunen (2018-07-11 01:21:04) > Patch "clk: core: Copy connection id" made it so that the connector > id (con_id) is kstrdup_const'ed to cater to drivers that pass non- > constant connection ids. The patch added the corresponding kfree_const > to __clk_free_clk, but struct clk's can

Re: [PATCH] clk: clk-fixed-factor: Clear OF_POPULATED flag in case of failure

2018-07-25 Thread Stephen Boyd
Quoting Rajan Vaja (2018-07-17 06:17:00) > Fixed factor clock has two initializations at of_clk_init() time > and during platform driver probe. Before of_clk_init() call, > node is marked as populated and so its probe never gets called. > > During of_clk_init() fixed factor clock registration may

Re: [PATCH] clk: clk-fixed-factor: Clear OF_POPULATED flag in case of failure

2018-07-25 Thread Stephen Boyd
Quoting Rajan Vaja (2018-07-17 06:17:00) > Fixed factor clock has two initializations at of_clk_init() time > and during platform driver probe. Before of_clk_init() call, > node is marked as populated and so its probe never gets called. > > During of_clk_init() fixed factor clock registration may

Re: [PATCH] clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent

2018-07-25 Thread Stephen Boyd
Quoting Gregory CLEMENT (2018-07-13 03:27:26) > The return value of the get_parent operation is a u8, whereas a -EINVAL > was returned. This wrong value was return if the value was bigger that > the number of parent but this case was already handled by the core. > > So we can just remove this chun

Re: [PATCH V2 1/2] clk: imx: add ocram_s clock for i.mx6sx

2018-07-25 Thread Stephen Boyd
Quoting Anson Huang (2018-07-10 17:58:58) > i.MX6SX has a 16KB always-on ocram bank called > ocram_s, and its clock gate in CCM CCGR1 CG14 > needs to be enabled before access, add it to > clock tree. > > Signed-off-by: Anson Huang > --- Applied to clk-next

RE: [PATCH v9 10/10] drivers: clk: Add ZynqMP clock driver

2018-07-25 Thread Stephen Boyd
Quoting Jolly Shah (2018-07-17 13:09:01) > Hi Stephen, > > Thanks for the review, > > > -Original Message- > > From: Stephen Boyd [mailto:sb...@kernel.org] > > Sent: Sunday, July 08, 2018 10:27 PM > > To: Jolly Shah ; ard.biesheu...@linaro.org

Re: [PATCH] clk: imx6ul: fix missing of_node_put()

2018-07-25 Thread Stephen Boyd
Quoting Nicholas Mc Guire (2018-07-13 04:13:20) > of_find_compatible_node() is returning a device node with refcount > incremented and must be explicitly decremented after the last use > which is right after the us in of_iomap() here. > > Signed-off-by: Nicholas Mc Guire > Fixes: commit 787b4271a

<    8   9   10   11   12   13   14   15   16   17   >