Re: [PATCH 8/9] dasd: Add 'timeout' attribute

2013-01-29 Thread Stefan Weinhuber
+ > + blk_queue_rq_timeout(q, device->blk_timeout * HZ); > + spin_unlock_irqrestore(&device->block->request_queue_lock, flags); > + > + dasd_put_device(device); > + return count; > +} > + [..] Mit freundlichen Grüßen / Kind regards Stefan Weinhube

Re: [PATCH 0/9][v2] dasd: implement block timeout

2013-01-30 Thread Stefan Weinhuber
- > drivers/s390/block/dasd_eckd.c| 15 - > drivers/s390/block/dasd_erp.c |8 +++ > drivers/s390/block/dasd_fba.c | 10 +++- > drivers/s390/block/dasd_int.h | 10 +++ > drivers/s390/block/dasd_ioctl.c | 59 +++++++ > 11 files changed, 313 insert

Re: [PATCH 5/5] s390:block:fix up ENOIOCTLCMD error handling

2012-08-27 Thread Stefan Weinhuber
- if (rc == -ENOIOCTLCMD) > -rc = -EINVAL; > - } else > - rc = -EINVAL; > } > dasd_put_device(base); > return rc; > -- > 1.7.11.5 > The patch is looking fine to me, thanks. Mit freundlichen Grüßen / Kind regards Stefan Wei

Re: [PATCH] s390: Fix me in dasd_eer.c

2014-07-28 Thread Stefan Weinhuber
one is better. But today I say that the 'Operation not permitted' is more to the point. An FBA device has no (changable) medium, so what could be wrong about its type? Could be confusing. >From your patch description I do not really get why you want to change the return code. Why do you