Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK

2015-03-20 Thread Stefan Hengelein
Would it be reasonable to add an entry (or expand entry 8) in Documentation/SubmitChecklist to point to the script? "If your patch has changed conditions in Kconfig, run "python scripts/checkkconfigsymbols.py --commit $your_commit"" ? 2015-03-20 11:52 GMT+01:00 Paul Bolle : > On Fri, 2015-03-20 at

Re: Abuse of CONFIG_FOO's as feature selectors

2015-04-23 Thread Stefan Hengelein
2015-04-22 20:56 GMT+02:00 Andreas Ruprecht : > Hi, > > On 22.04.2015 20:20, Denys Vlasenko wrote: >> Hi, >> >> Kernel has a growing number of CONFIG items which are not >> user-selectable features of their particular kernel builds, >> but simply booleans controlled by other CONFIGs. >> Example: >>

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Stefan Hengelein
2015-04-10 23:25 GMT+02:00 Paul Bolle : > [Removed Yann. Added the people that I hope might actually understand > what this is all about.] > > On Wed, 2015-04-08 at 16:56 -0700, Gregory Fong wrote: >> get_symbol_str() was assuming that symbols would only have a single >> property for the purpose of

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Stefan Hengelein
2015-04-11 20:56 GMT+02:00 Paul Bolle : > On Sat, 2015-04-11 at 18:36 +0200, Stefan Hengelein wrote: >> If you're reading the dependency list as "what do i have to enable to >> be able to choose a value for FRAME_POINTER" and think, THUMB2_KERNEL >> would be a g

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Stefan Hengelein
2015-04-11 22:23 GMT+02:00 Paul Bolle : > On Sat, 2015-04-11 at 21:58 +0200, Stefan Hengelein wrote: >> 2015-04-11 20:56 GMT+02:00 Paul Bolle : >> > On Sat, 2015-04-11 at 18:36 +0200, Stefan Hengelein wrote: >> What i meant to say, you won't get a prompt (or for mconf

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-12 Thread Stefan Hengelein
> Let's focus, for example, on m32r and FRAME_POINTER. The m32r entry for > that symbol reads: > config FRAME_POINTER > bool "Compile the kernel with frame pointers" > help > If you say Y here [...] > > 0) If one is building for m32r is that

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-13 Thread Stefan Hengelein
>> > The search facility shows the first one that is found, you see the >> > complicated depends on but i think the text shown might not be >> > explicit enough to clarify you don't need to satisfy these complicated >> > conditions to actually choose a value. >> > >> >> Well, the thing is, you do n

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-13 Thread Stefan Hengelein
er than I > did in the commit message. yes, i missed where and how it was used in your commit message. > > On Sun, Apr 12, 2015 at 8:02 AM, Stefan Hengelein > wrote: >>> Let's focus, for example, on m32r and FRAME_POINTER. The m32r entry for >>> t

Re: unnecessary #ifdefs

2015-05-27 Thread Stefan Hengelein
2015-05-27 2:17 GMT+02:00 Wu, Feng : >> Sent: Wednesday, May 27, 2015 2:19 AM >> To: Wu, Feng >> Cc: Valentin Rothberg; Paul Bolle; Andreas Ruprecht; t...@linutronix.de; >> x...@kernel.org; linux-kernel@vger.kernel.org; ru...@rustcorp.com.au; >> mi...@redhat.com >> Subject: unnecessary #ifdefs >> >

[PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice

2014-08-29 Thread Stefan Hengelein
i.e. on arch/frv) or RCU_NOCB_CPU is not defined. Signed-off-by: Stefan Hengelein Signed-off-by: Andreas Ruprecht --- init/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index 197b563..d604000 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -72

Re: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice

2014-09-02 Thread Stefan Hengelein
2014-09-02 19:07 GMT+02:00 Paul E. McKenney : > On Fri, Aug 29, 2014 at 03:08:20PM +0200, Stefan Hengelein wrote: >> Every choice item of the "Build-forced no-CBs CPUs" choice had a >> dependency to RCU_NOCB_CPU. It's more comprehensible if the choice >> itself

[ANNOUNCE] undertaker 1.6

2014-10-13 Thread stefan . hengelein
er = CADOS at the Linux Plumbers Conference http://www.linuxplumbersconf.org = There will be two talks at the 'development tools' microconference at the Linux Plumbers Conference. Valentin Rothberg will show the functionality of the new undertaker-checkpatch tool ( http://www.linuxplumbersconf.org/2014/oc

Re: [PATCH] arm: dma-mapping: fix compilation error when CONFIG_MMU is not present

2014-10-24 Thread Stefan Hengelein
MMU would probably also solve the problem. Is there any situation where it would make sense to use an IOMMU without an MMU? Best Regards, Stefan Hengelein 2014-10-23 10:15 GMT+02:00 Marek Szyprowski : > Hello, > > > On 2014-10-21 02:05, Laura Abbott wrote: >> >> On 10/20/20

[PATCH] arm: dma-mapping: fix compilation error when CONFIG_MMU is not present

2014-10-19 Thread Stefan Hengelein
mpyr. Signed-off-by: Stefan Hengelein --- arch/arm/mm/dma-mapping.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index c245d90..7d04cf7 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -573,12 +573,14 @@ st

[PATCH] MIPS: ath79: fix compilation error when CONFIG_PCI is disabled

2014-10-19 Thread Stefan Hengelein
When CONFIG_PCI is disabled, 'db120_pci_init()' had a different signature than when was enabled. Therefore, compilation failed when CONFIG_PCI was not present. arch/mips/ath79/mach-db120.c:132: error: too many arguments to function 'db120_pci_init' Signed-off-by: Stefan

[PATCH] ARM: ixp4xx: remove compilation warnings in io.h

2014-10-19 Thread Stefan Hengelein
ing and semantics are preserved. This warning was found with vampyr. Signed-off-by: Stefan Hengelein --- arch/arm/mach-ixp4xx/include/mach/io.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-ixp4xx/include/mach/io.h b/arch/arm/mach-ixp4xx/include/mach/io.h

[PATCH] MIPS: MSP71xx: remove compilation error

2014-10-19 Thread Stefan Hengelein
nd with vampyr. Signed-off-by: Stefan Hengelein --- arch/mips/pmcs-msp71xx/msp_irq_cic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/pmcs-msp71xx/msp_irq_cic.c b/arch/mips/pmcs-msp71xx/msp_irq_cic.c index b8df2f7..1207ec4 100644 --- a/arch/mips/pmcs-msp71xx/m

[PATCH] MIPS: ath79: fix compilation error when CONFIG_PCI is disabled

2014-10-20 Thread Stefan Hengelein
vampyr. Signed-off-by: Stefan Hengelein --- Changelog: v2: fix prototype instead of removing the caller --- arch/mips/ath79/mach-db120.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/ath79/mach-db120.c b/arch/mips/ath79/mach-db120.c index 4d661a1..9423f5a 100644 -

[PATCH] MIPS: MSP71xx: remove compilation error when CONFIG_MIPS_MT is present

2014-10-20 Thread Stefan Hengelein
x27; This error was found with vampyr. Signed-off-by: Stefan Hengelein --- arch/mips/pmcs-msp71xx/msp_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/pmcs-msp71xx/msp_irq.c b/arch/mips/pmcs-msp71xx/msp_irq.c index f914c75..8d53d7a 100644 --- a/arch/mips/pmcs-msp71xx/msp_i

unnecessary #ifdefs

2015-05-26 Thread Stefan Hengelein
Hi Feng Wu, your commits f6b3c72c23661e55 ("x86/irq: Define a global vector for VT-d Posted-Interrupts") 501b32653ebf49114c ("x86/irq: Show statistics information for posted-interrupts") showed up in linux-next today (i.e. next-20150526). Both commits add "#ifdef CONFIG_HAVE_KVM" blocks to eith

Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-19 Thread Stefan Hengelein
tübner : > Hi Stefan, > > Am Donnerstag, 18. Dezember 2014, 14:43:01 schrieb Stefan Hengelein: >> So you actually tested the code I removed in the patch? can you >> provide a configuration that compiles that piece of code? > > Yep, one of my boards (Asus eeeReader DR-900) was ac

Dead Kconfig Option OMAP4_ERRATA_I688

2015-02-25 Thread Stefan Hengelein
During the research for my masters thesis i came across the OMAP4_ERRATA_I688 option and realized, it is never possible to enable this option. The a62a6e98 commit added the "&& !ARCH_MULTIPLATFORM" dependency to disable this option for multiplatforms. However, because of enclosing dependencies, th

[PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688

2015-02-25 Thread Stefan Hengelein
s dead and can be removed. This (logical) defect has been found with the undertaker tool. (https://undertaker.cs.fau.de) Signed-off-by: Stefan Hengelein --- Tony Lindgren suggested to remove the code since nobody complained for a few years and Santosh Shilimkar agreed. https://lkml.org/lkml/2015

[PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-17 Thread Stefan Hengelein
fined(CONFIG_S3C24XX_DMAC)" cannot be enabled at the same time with the surrounding block "#ifdef CONFIG_S3C64XX_DEV_SPI0" and therefore is dead. This (logical) defect has been found with the undertaker tool (https://undertaker.cs.fau.de) Signed-off-by: Stefan Hengelein --- a

Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-18 Thread Stefan Hengelein
So you actually tested the code I removed in the patch? can you provide a configuration that compiles that piece of code? 2014-12-17 17:16 GMT+01:00 Heiko Stübner : > Am Mittwoch, 17. Dezember 2014, 16:52:40 schrieb Arnd Bergmann: >> On Wednesday 17 December 2014 16:40:37 Stefan Hengel

Re: Kconfig: '+config' valid syntax?

2015-07-03 Thread Stefan Hengelein
2015-07-03 12:51 GMT+02:00 Valentin Rothberg : >>> >>> The output looks like this: >>> scripts/kconfig/conf --allyesconfig Kconfig >>> arch/x86/Kconfig:4:warning: ignoring unsupported character '-' >>> arch/x86/Kconfig:4:warning: ignoring unsupported character '-' >>> arch/x86/Kconfig:4:warning: i

Re: Kconfig: '+config' valid syntax?

2015-07-03 Thread Stefan Hengelein
2015-07-03 12:56 GMT+02:00 Stefan Hengelein : > 2015-07-03 12:51 GMT+02:00 Valentin Rothberg : >>>> >>>> The output looks like this: >>>> scripts/kconfig/conf --allyesconfig Kconfig >>>> arch/x86/Kconfig:4:warning: ignoring unsupported char