Re: [2/3] iio: adc: ina2xx: Adhere to documented ABI, use Ohm instead of uOhm

2017-10-14 Thread Stefan Bruens
On Montag, 9. Oktober 2017 11:29:43 CEST Maciej Purski wrote: > On 10/01/2017 09:48 PM, Stefan Brüns wrote: > > According to the ABI documentation, the shunt resistor value should be > > specificied in Ohm. As this is also used/documented for the MAX9611, > > use the same for the INA2xx driver. > >

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

2017-02-15 Thread Stefan Bruens
Hi Antti, first thanks for for the review. Note the t230c_attach is mostly a copy of the t330_attach (which is very similar to the t680c_attach), so any of your comments should probably applied to the other attach functions to have a common coding style. On Mittwoch, 15. Februar 2017 10:27:09

Re: [PATCH 1/2] iio: adc: Fix integration time/averaging for INA219/220

2017-04-17 Thread Stefan Bruens
On Freitag, 14. April 2017 17:02:33 CEST Jonathan Cameron wrote: > On 12/04/17 04:01, Stefan Brüns wrote: > > INA226/230/231 has integration times per voltage channel and common > > averaging setting for both channels, while the INA219/220 only has a > > combined integration time/averaging setting

Re: [PATCH 2/2] iio: adc: Allow setting Shunt Voltage PGA gain and Bus Voltage range

2017-04-17 Thread Stefan Bruens
On Freitag, 14. April 2017 17:12:03 CEST Jonathan Cameron wrote: > On 12/04/17 04:01, Stefan Brüns wrote: > > Reducing shunt and bus voltage range improves the accuracy, so allow > > altering the default settings. > > > > Signed-off-by: Stefan Brüns > > Hi Stefan, > > There is new userspace ABI

Re: [PATCH 2/2] iio: adc: Allow setting Shunt Voltage PGA gain and Bus Voltage range

2017-07-16 Thread Stefan Bruens
On Sonntag, 30. April 2017 18:19:39 CEST Jonathan Cameron wrote: > On 29/04/17 21:37, Stefan Bruens wrote: > > On Mittwoch, 26. April 2017 08:59:47 CEST Jonathan Cameron wrote: > >> On 26/04/17 07:19, Jonathan Cameron wrote: > >>> On 17/04/17 23:08, Stefan Bruen

Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

2017-08-31 Thread Stefan Bruens
On Freitag, 1. September 2017 02:31:35 CEST Andre Przywara wrote: > Hi, > > On 31/08/17 00:36, Stefan Brüns wrote: > > The A64 SoC has the same dma engine as the H3 (sun8i), with a > > reduced amount of physical channels. Add the proper config data > > and compatible string to support it. > > ...

Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3

2017-08-31 Thread Stefan Bruens
On Donnerstag, 31. August 2017 16:51:35 CEST Maxime Ripard wrote: > Hi, > > On Thu, Aug 31, 2017 at 01:36:07AM +0200, Stefan Brüns wrote: > > +/* Between SoC generations, there are some significant differences: > > + * - A23 added a clock gate register > > + * - the H3 burst length field has a dif

Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

2017-09-01 Thread Stefan Bruens
On Samstag, 2. September 2017 00:32:50 CEST André Przywara wrote: > Hi, > > On 01/09/17 02:19, Stefan Bruens wrote: > > On Freitag, 1. September 2017 02:31:35 CEST Andre Przywara wrote: > >> Hi, > >> > >> On 31/08/17 00:36, Stefan Brüns wrote: [...] >

Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

2017-09-01 Thread Stefan Bruens
On Samstag, 2. September 2017 00:32:50 CEST André Przywara wrote: > Hi, > > On 01/09/17 02:19, Stefan Bruens wrote: > > On Freitag, 1. September 2017 02:31:35 CEST Andre Przywara wrote: > >> Hi, > >> > >> On 31/08/17 00:36, Stefan Brüns wrote: > >

Re: [PATCH 07/10] dmaengine: sun6i: Retrieve channel count/max request from devicetree

2017-09-03 Thread Stefan Bruens
On Montag, 4. September 2017 01:44:54 CEST André Przywara wrote: > Hi, > > On 03/09/17 23:40, Stefan Brüns wrote: > > To avoid introduction of a new compatible for each small SoC/DMA > > controller > > variation, move the definition of the channel count to the devicetree. > > > > The number of vc

Re: [PATCH 08/10] dmaengine: sun6i: Add support for Allwinner A64 and compatibles

2017-09-03 Thread Stefan Bruens
On Montag, 4. September 2017 01:37:58 CEST André Przywara wrote: > > @@ -1090,6 +1101,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match); > > > > static int sun6i_dma_probe(struct platform_device *pdev) > > { > > > > const struct of_device_id *device; > > > > + struct device_node *np = pdev

Re: [PATCH 2/2] iio: adc: Allow setting Shunt Voltage PGA gain and Bus Voltage range

2017-04-29 Thread Stefan Bruens
On Mittwoch, 26. April 2017 08:59:47 CEST Jonathan Cameron wrote: > On 26/04/17 07:19, Jonathan Cameron wrote: > > On 17/04/17 23:08, Stefan Bruens wrote: > >> On Freitag, 14. April 2017 17:12:03 CEST Jonathan Cameron wrote: [...] > > > >> 4. Any user of the gain

Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller

2017-09-23 Thread Stefan Bruens
On Mittwoch, 20. September 2017 22:53:00 CEST Rob Herring wrote: > On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote: > > The A64 is register compatible with the H3, but has a different number > > of dma channels and request ports. > > > > Attach additional properties to the node to all

Re: [PATCH v2 07/10] dmaengine: sun6i: Retrieve channel count/max request from devicetree

2017-09-27 Thread Stefan Bruens
On Mittwoch, 27. September 2017 11:09:22 CEST Maxime Ripard wrote: > On Sat, Sep 23, 2017 at 12:00:15AM +, Brüns, Stefan wrote: > > On Freitag, 22. September 2017 23:30:27 CEST Maxime Ripard wrote: > > > On Tue, Sep 19, 2017 at 04:17:59PM +, Brüns, Stefan wrote: > > > > On Dienstag, 19. Sep