[PATCH] perf build: fix -lbfd feature check

2018-11-15 Thread Stanislav Fomichev
for bpftool which is currently broken on debian (libbfd feature shows OFF, but we still unconditionally link against -lbfd and it works). Tested on debian with only -lbfd installed (without -liberty); I'd appreciate if somebody on the other systems can test this new detection method. Signed-off

Re: [PATCH] perf build: fix -lbfd feature check

2018-12-18 Thread Stanislav Fomichev
On Fri, Nov 16, 2018 at 5:34 AM Jiri Olsa wrote: > > On Thu, Nov 15, 2018 at 04:32:01PM -0800, Stanislav Fomichev wrote: > > Current libbfd feature test unconditionally links against -liberty and -lz. > > While it's required on some systems (e.g. opensuse), it's compl

Re: [PATCH bpf-next 0/2] selftests/bpf: Add uprobe pid filter test

2024-08-30 Thread Stanislav Fomichev
send another patchset for that. Not sure whether Oleg or Andrii plan to take a look, but LGTM: Acked-by: Stanislav Fomichev

Re: [PATCH net v2 2/2] bpf: selftests: send packet to devmap redirect XDP

2024-09-06 Thread Stanislav Fomichev
On 09/06, Florian Kauer wrote: > The current xdp_devmap_attach test attaches a program > that redirects to another program via devmap. > > It is, however, never executed, so do that to catch > any bugs that might occur during execution. > > Also, execute the same for a veth pair so that we > also

Re: [PATCH net v2 2/2] bpf: selftests: send packet to devmap redirect XDP

2024-09-06 Thread Stanislav Fomichev
On 09/06, Stanislav Fomichev wrote: > On 09/06, Florian Kauer wrote: > > The current xdp_devmap_attach test attaches a program > > that redirects to another program via devmap. > > > > It is, however, never executed, so do that to catch > > any bugs

Re: [PATCH v2] hrtimers: calculate expires_next after all timers are executed

2014-12-29 Thread Stanislav Fomichev
No, Thomas didn't yet push the fix. 27.12.2014, 02:34, "Stephen Boyd" : > On 06/22/2014 07:46 AM, Thomas Gleixner wrote: >>>  + for (i = 0; i < HRTIMER_MAX_CLOCK_BASES; i++) { >>>  + ktime_t expires; >>  So this adds the third incarnation of finding the next expiring timer >>  to the code. Not rea

Re: [PATCH 02/12] perf tools: Separate generic code in dso_cache__read

2019-04-16 Thread Stanislav Fomichev
On 04/16, Jiri Olsa wrote: > Moving file specific code in dso_cache__read function > into separate file_read function. I'll add bpf specific > code in following patches. > > Link: http://lkml.kernel.org/n/tip-7f7d717uzrqt5ka2xp29i...@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/u

Re: linux-next: manual merge of the bpf-next tree with the net-next tree

2021-01-25 Thread Stanislav Fomichev
Thanks, the merge resolution looks good to me! On Sun, Jan 24, 2021 at 4:12 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the bpf-next tree got a conflict in: > > net/ipv4/tcp.c > > between commit: > > 7eeba1706eba ("tcp: Add receive timestamp support for receive zero

Re: [PATCH] perf timechart record: fix off-by-one error in argv

2014-03-17 Thread Stanislav Fomichev
; Workload failed: No such file or directory > > This happens because of an off-by-one error while preparing the argv for > cmd_record(): it attempts to execute the command 'status' and complains > that it doesn't exist. Fix this error. > > Cc: Stanislav Fomichev

[PATCH] hrtimers: calculate expires_next after all timers are executed

2014-03-17 Thread Stanislav Fomichev
find next expiry time for all clocks. Signed-off-by: Stanislav Fomichev --- kernel/hrtimer.c | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index 09094361dce5..63805f9f9531 100644 --- a/kernel/hrtim

[PATCH v2] hrtimers: calculate expires_next after all timers are executed

2014-03-19 Thread Stanislav Fomichev
find next expiry time for all clocks. Signed-off-by: Stanislav Fomichev --- include/linux/hrtimer.h | 2 ++ kernel/hrtimer.c| 41 +++-- 2 files changed, 33 insertions(+), 10 deletions(-) diff --git a/include/linux/hrtimer.h b/include/linux/hrtim

Re: [PATCH] ioat: fix tasklet tear down

2014-02-20 Thread Stanislav Fomichev
> Passes my testing, but would appreciate a tested-by. Tested-by: Stanislav Fomichev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pl

Re: [PATCH] perf timechart: remove lock_depth from trace_entry

2013-11-26 Thread Stanislav Fomichev
> This makes the new tool stop processing old files, can you try the patch > attached instead? I see two downsides to your approach: 1) with your patch I'm now required to run 'perf timechart record' and 'perf timechart' on the same machine (otherwise, on the 'perf timechart' machine we may have wr

Re: [PATCH] perf timechart: remove lock_depth from trace_entry

2013-11-26 Thread Stanislav Fomichev
> Se above, if before this patch the format_field info was obtained from > the perf.data file, why should it now get it from the local machine? Yes, sorry for confusion, I didn't know that we can obtain trace events format from the perf.data. I hence have no concerns regarding your implementation :

[PATCH] perf timechart: dynamically determine event data offset

2013-11-26 Thread Stanislav Fomichev
continue working with old perf.data. Instead, we now calculate event data offset dynamically using offset of first non-common event field in the perf.data. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 56 +++--- tools/perf/util/evsel.c

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Stanislav Fomichev
> Nacked-by: Namhyung Kim Thanks for a review. I'll try to convert all binary structures to perf_evsel__intval() and perf_evsel__strval() and will rebase on Arnaldo's perf/core branch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

[PATCH] perf timechart: dynamically determine event fields offset

2013-11-27 Thread Stanislav Fomichev
coded copy of fields layout from the kernel. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 119 +++-- 1 file changed, 42 insertions(+), 77 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.

Re: [PATCH 1/6] perf timechart: always try to print at least 15 tasks

2013-10-29 Thread Stanislav Fomichev
> 1. introduce while loop: it's a behavioral change so that it can be a > separate patch. But it seems not checking the process filter - in that > case the loop is almost useless IMHO. Could you please elaborate on 'not checking the process filter'? This loop is for the case when process filter i

Re: [PATCH 2/6] perf timechart: use proc_num to implement --power-only

2013-10-29 Thread Stanislav Fomichev
> I don't see how it does same thing. You mean it by skipping > draw_process_bars() and draw_wakeups() on patch 1? It'd be better > changelog explains the details. Yes, it depends on the previous patch, I'll add more info to the changelog. > And I'd like to keep it as BOOLEAN option - it's simpl

Re: [PATCH 3/6] perf timechart: add support for displaying only tasks related data

2013-10-29 Thread Stanislav Fomichev
> Hmm.. double negation is always confusing to me. :-/ How about making > it a boolean option that sets "task_only" variable? Ok. > Also need to update the doc. And what if user gives -P and -T options > at the same time? Is something like this is enough (or you'd like some printout with error d

Re: [PATCH 4/6] perf timechart: group figures and add title with details

2013-10-29 Thread Stanislav Fomichev
> For consistency, wouldn't it be better renaming svg_sample() to > svg_running()? Makes sense. I'll resend the whole series with updates later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH 5/6] perf timechart: add support for -P and -T in timechart recording

2013-10-29 Thread Stanislav Fomichev
> It should be ARRAY_SIZE(old_power_args). Thanks :-) > Do we really need to separate the option and usage for record? AFAICS > it does exactly same thing.. Yes, we do. Some options which are defined for timechart are undefined for record (like -i, -o, etc), so we want to get an error in case of

[PATCH 6/7] perf timechart: add support for -P and -T in timechart recording

2013-11-01 Thread Stanislav Fomichev
If we don't want either power or task events we may use -T or -P with the `perf timechart record` command to filter out events while recording to keep perf.data small. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 15 - tools/perf/builtin-timech

[PATCH 3/7] perf timechart: use proc_num to implement --power-only

2013-11-01 Thread Stanislav Fomichev
Don't use special flag to indicate power-only mode, just set proc_num to 0. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c

[PATCH v2 0/7] perf timechart improvements

2013-11-01 Thread Stanislav Fomichev
ted out by Namhyung Kim Stanislav Fomichev (7): perf timechart: always try to print at least 15 tasks perf timechart: add option to limit number of tasks perf timechart: use proc_num to implement --power-only perf timechart: add support for displaying only tasks related data perf timech

[PATCH 7/7] perf timechart: add backtrace support

2013-11-01 Thread Stanislav Fomichev
Add -g flag to `perf timechart record` which saves callchain info in the perf.data. When generating SVG, add backtrace information to the figure details, so now it's possible to see which code path woke up the task and why some task went to sleep. Signed-off-by: Stanislav Fomichev ---

[PATCH 1/7] perf timechart: always try to print at least 15 tasks

2013-11-01 Thread Stanislav Fomichev
Always try to print at least 15 tasks no matter how long they run. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index

[PATCH 4/7] perf timechart: add support for displaying only tasks related data

2013-11-01 Thread Stanislav Fomichev
In order to make SVG smaller and faster to browse add possibility to switch off power related information with -T switch. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 3 +++ tools/perf/builtin-timechart.c | 11 ++- 2 files changed, 13

[PATCH 2/7] perf timechart: add option to limit number of tasks

2013-11-01 Thread Stanislav Fomichev
Add -n option to specify min. number of tasks to print. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 4 tools/perf/builtin-timechart.c | 5 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/perf/Documentation/perf

[PATCH 5/7] perf timechart: group figures and add title with details

2013-11-01 Thread Stanislav Fomichev
tails. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 6 ++--- tools/perf/util/svghelper.c| 56 -- tools/perf/util/svghelper.h| 5 ++-- 3 files changed, 60 insertions(+), 7 deletions(-) diff --git a/tools/perf/bu

[PATCH] perf tools: bring back old behavior when NO_DEMAGLE doesn't link with libbfd

2013-12-02 Thread Stanislav Fomichev
ils (hence miss required libbfd version) and I still want an option to build perf which works on any machine regardless of binutils version. Signed-off-by: Stanislav Fomichev --- tools/perf/config/Makefile | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/perf/config/M

[PATCH 2/5] perf timechart: print pid along the name

2013-12-02 Thread Stanislav Fomichev
Add PID to the figures of CPU usage timechart. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 1 + tools/perf/util/svghelper.c| 4 ++-- tools/perf/util/svghelper.h| 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin

[PATCH 0/5] perf timechart improvements part 2

2013-12-02 Thread Stanislav Fomichev
on to sort CPUs (on the CPU overview chart) topologically (draw adjacent SMT threads next to each other) - adds '-e' option to highlight long events on the CPU overview chart Stanislav Fomichev (5): perf timechart: add backtrace support to CPU info perf timechart: print pid a

[PATCH 4/5] perf timechart: add support for topology

2013-12-02 Thread Stanislav Fomichev
Add -t switch to sort CPUs topologically. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 3 + tools/perf/builtin-timechart.c | 17 +++- tools/perf/util/svghelper.c | 132 +++- tools/perf/util

[PATCH 1/5] perf timechart: add backtrace support to CPU info

2013-12-02 Thread Stanislav Fomichev
Add backtrace info to the CPU usage timechart. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 10 -- tools/perf/util/svghelper.c| 4 +++- tools/perf/util/svghelper.h| 2 +- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/tools/perf

[PATCH 3/5] perf timechart: get number of CPUs from perf header

2013-12-02 Thread Stanislav Fomichev
Print all CPUs, even if there were no events (use perf header to get number of CPUs). This is required to support topology in the next patch. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions

[PATCH] perf util: free cpu_map in perf_session__cpu_bitmap

2013-12-02 Thread Stanislav Fomichev
Free previously allocated map. Signed-off-by: Stanislav Fomichev --- tools/perf/util/session.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 4ce146bae552..ee717ee9ca3a 100644 --- a/tools/perf/util/session.c +++ b/tools/perf

[PATCH 5/5] perf timechart: add emphasize option

2013-12-17 Thread Stanislav Fomichev
This option highlights tasks (using different color) that run more than given duration or tasks with given name. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 4 tools/perf/builtin-timechart.c | 21 - tools/perf/util

Re: [PATCH 5/5 v2] perf timechart: add emphasize option

2013-12-17 Thread Stanislav Fomichev
umentation. Attached new patch below. --- This option highlights tasks (using different color) that run more than given duration or tasks with given name. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 14 ++ tools/perf/builtin-timechart.c |

Re: [PATCH 5/5 v2] perf timechart: add emphasize option

2013-12-17 Thread Stanislav Fomichev
t color) that run more than given duration or tasks with given name. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c | 21 - tools/perf/util/svghelper.c

Re: [PATCHv4] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-18 Thread Stanislav Fomichev
graph tracer we register handler which reinitializes tracer depending on tracing_thresh. Signed-off-by: Stanislav Fomichev --- kernel/trace/trace.c | 65 kernel/trace/trace.h | 2 ++ kernel/trace/trace_functions_graph.c | 7 ++

[PATCH 2/3] perf util: free cpu_map in perf_session__cpu_bitmap

2014-01-20 Thread Stanislav Fomichev
Signed-off-by: Stanislav Fomichev --- tools/perf/util/session.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 7acc03e8f3b2..03815af30b16 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1600,6 +1600,7

[PATCH 1/3] perf timechart: fix wrong SVG height

2014-01-20 Thread Stanislav Fomichev
If we call perf timechart with -p 0 arguments, it means we don't want any tasks related data. It works, but space for tasks data is reserved in the generated SVG. Remove this unused empty space via passing 0 as count to the open_svg. Signed-off-by: Stanislav Fomichev --- tools/perf/bu

[PATCH 3/3] perf tools: bring back old behavior when NO_DEMAGLE doesn't link with libbfd

2014-01-20 Thread Stanislav Fomichev
ils (hence miss required libbfd version) and I still want an option to build perf which works on any machine regardless of binutils version. Signed-off-by: Stanislav Fomichev --- tools/perf/config/Makefile | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/perf/config/M

[PATCH 0/3] perf fixes

2014-01-20 Thread Stanislav Fomichev
without libbfd (because on 3.10 lts NO_DEMANGLE=1 does not link with libbfd and I'd like to preserve this behavior). Stanislav Fomichev (3): perf timechart: fix wrong SVG height perf util: free cpu_map in perf_session__cpu_bitmap perf tools: bring back old behavior when NO_DEMAG

Re: [PATCH v2] hrtimers: calculate expires_next after all timers are executed

2014-03-24 Thread Stanislav Fomichev
Hi, Any comment on the v2? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 4/5] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-18 Thread Stanislav Fomichev
It will be reused by perf trace in the following commit. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-kvm.c | 88 +++ tools/perf/util/session.c | 85 + tools/perf/util/session.h | 5 +++ 3

[PATCH 3/5] perf trace: add possibility to switch off syscall events

2014-06-18 Thread Stanislav Fomichev
Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-trace.txt | 7 ++ tools/perf/builtin-trace.c | 39 ++--- 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf

[RFC PATCH 0/5] perf trace pagefaults

2014-06-18 Thread Stanislav Fomichev
cept, and I'd like to get some comments about where and what I got wrong and what additional useful information I can expose in the trace. Stanislav Fomichev (5): perf trace: add support for pagefault tracing perf trace: add pagefault statistics perf trace: add possibility to switch off s

[PATCH 5/5] perf trace: add events cache

2014-06-18 Thread Stanislav Fomichev
Use session to cache and order events from all CPUs so we get correct ordering of comms/mmaps and faults. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 117 ++--- 1 file changed, 46 insertions(+), 71 deletions(-) diff --git a/tools

[PATCH 2/5] perf trace: add pagefault statistics

2014-06-18 Thread Stanislav Fomichev
Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 6c7ae048db59..535f0b504950 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c

[PATCH 1/5] perf trace: add support for pagefault tracing

2014-06-18 Thread Stanislav Fomichev
Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-trace.txt | 12 ++ tools/perf/builtin-trace.c | 198 ++-- 2 files changed, 176 insertions(+), 34 deletions(-) diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf

Re: [PATCH 1/5] perf trace: add support for pagefault tracing

2014-06-18 Thread Stanislav Fomichev
> I try, when possible, to not use short options that are used in > 'strace', so what if we use 'F' here? Agreed, will change. > And: > >trace --pgfaults --pgfaults > > for major and min page faults looks ugly, what if we instead use --pf > for both, and allow passing min or maj as args? >

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-19 Thread Stanislav Fomichev
> Hmm.. it looks like an unrelated issue. I can see the bars in inkscape, > but still see empty grey bars in firefox. I'll try to have a look; maybe I'm writing some non-standard svg instructions which fail on (probably) standard-compliant firefox and work on more robust inkscape. -- To unsubscrib

Re: [PATCH 1/5] perf trace: add support for pagefault tracing

2014-06-19 Thread Stanislav Fomichev
> So make it default to the most common case :-) Ok, agreed, will make --pf=all|maj|min and will default it to maj. > That is my expectation, yes, if I ask for the map where address N is, it > should return just that, where have you found this bug? > > The thread__find_addr_map will end up callin

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-19 Thread Stanislav Fomichev
> > Hmm.. it looks like an unrelated issue. I can see the bars in inkscape, > > but still see empty grey bars in firefox. > I'll try to have a look; maybe I'm writing some non-standard svg > instructions which fail on (probably) standard-compliant firefox and > work on more robust inkscape. Found

[PATCH 3/3] perf timechart: add more options to IO mode

2014-06-19 Thread Stanislav Fomichev
--io-skip-eagain - don't show EAGAIN errors --io-min-time- make small io bursts visible --io-merge-dist - merge adjacent events Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c

[PATCH v3 0/3] perf timechart io mode

2014-06-19 Thread Stanislav Fomichev
start_time fix into distinct commit - separated --io-xyz options into distinct commit - fixed 'error' shadowing - initialized variables in declaration when possible - removed assert usage - fprintf -> pr_err - removed wrongly placed __maybe_unused Stanislav Fomichev (3): p

[PATCH 2/3] perf timechart: conditionally update start_time on fork

2014-06-19 Thread Stanislav Fomichev
We don't need to overwrite current task start_time on fork, so update it only if it's zero. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-t

[PATCH 1/3] perf timechart: implement IO mode

2014-06-19 Thread Stanislav Fomichev
In IO mode timechart shows any disk/network activity. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 613 +++- tools/perf/util/svghelper.c | 98 - tools/perf

Re: [PATCH 1/3] perf timechart: implement IO mode

2014-06-20 Thread Stanislav Fomichev
> It (and others below) should be 'rec_argc -= 4' - i.e. I still see the > segfault. :) Damn, stupid me. > Looks like this change should be applied to the exsting (for cpu and > power events) boxes too. Care to send it as a separate fix? Yes, will add it as a first patch to the series, so it can

[PATCH 4/4] perf timechart: add more options to IO mode

2014-06-20 Thread Stanislav Fomichev
--io-skip-eagain - don't show EAGAIN errors --io-min-time- make small io bursts visible --io-merge-dist - merge adjacent events Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c

[PATCH 3/4] perf timechart: conditionally update start_time on fork

2014-06-20 Thread Stanislav Fomichev
We don't need to overwrite current task start_time on fork, so update it only if it's zero. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-t

[PATCH 1/4] perf timechart: fix rendering in Firefox

2014-06-20 Thread Stanislav Fomichev
Firefox doesn't correctly handle cases where we specify number in quotes and have some padding around the number, like the following: In this case, it doesn't draw the figure. This patch removes 'field width' component from fprintf strings to fix it. Signed-off-by: Stanislav

[PATCH v4 0/4] perf timechart io mode

2014-06-20 Thread Stanislav Fomichev
n possible - removed assert usage - fprintf -> pr_err - removed wrongly placed __maybe_unused Stanislav Fomichev (4): perf timechart: fix rendering in Firefox perf timechart: implement IO mode perf timechart: conditionally update start_time on fork perf timechart: add more options to IO

[PATCH 2/4] perf timechart: implement IO mode

2014-06-20 Thread Stanislav Fomichev
In IO mode timechart shows any disk/network activity. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 613 +++- tools/perf/util/svghelper.c | 98 - tools/perf

[PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-20 Thread Stanislav Fomichev
It will be reused by perf trace in the following commit. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-kvm.c | 88 +++ tools/perf/util/session.c | 85 + tools/perf/util/session.h | 5 +++ 3

[PATCH 4/7] perf trace: add pagefault statistics

2014-06-20 Thread Stanislav Fomichev
'perf trace' can show summary of events using -S option. This commit also reports number of major/minor pagefault events in this summary. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/perf/built

[PATCH 2/7] perf trace: add support for pagefault tracing

2014-06-20 Thread Stanislav Fomichev
( 0.000 ms): curl/5937 majfault [0x7fa7261978b6] => /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0+0x85288 (d.) 1862866.036 ( 0.000 ms): wget/8460 majfault [__clear_user+0x3f] => 0x659cb4 (?k) Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-trace.txt | 12 tools/perf

[PATCH 1/7] perf trace: add perf_event parameter to tracepoint_handler

2014-06-20 Thread Stanislav Fomichev
It will be used by next pagefault tracing patches in the series. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index f954c26de231

[PATCH 3/7] perf trace: add pagefaults record and replay support

2014-06-20 Thread Stanislav Fomichev
Previous commit added live pagefault trace support, this one adds record and replay support. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 63 +- 1 file changed, 45 insertions(+), 18 deletions(-) diff --git a/tools/perf/builtin

[PATCH 5/7] perf trace: add possibility to switch off syscall events

2014-06-20 Thread Stanislav Fomichev
Currently, we may either trace syscalls or syscalls+pagefaults. We'd like to be able to trace *only* pagefaults and this commit implements this feature. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-trace.txt | 7 tools/perf/builtin-trace.c

[PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Stanislav Fomichev
into additional patch - separated record/replay into additional patch - other fixes pointed out by Arnaldo Carvalho de Melo Stanislav Fomichev (7): perf trace: add perf_event parameter to tracepoint_handler perf trace: add support for pagefault tracing perf trace: add pagefaults record

[PATCH 7/7] perf trace: add events cache

2014-06-20 Thread Stanislav Fomichev
Use session to cache and order events from all CPUs so we get correct ordering of comms/mmaps and faults. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 117 ++--- 1 file changed, 46 insertions(+), 71 deletions(-) diff --git a/tools

Re: [PATCH 6/7] perf kvm: move perf_kvm__mmap_read into session utils

2014-06-20 Thread Stanislav Fomichev
> I.e. what we need from perf_session is just the ordered_samples bits, > perhaps in its current form, perhaps rewritten, see (renewed) discussion > involving David Ahern and Jiri Olsa. Do you mean you want to pull (at some point) Jiri's patches and want to use just event ordering part in perf trac

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Stanislav Fomichev
> Just to clarify here, those slides came from slides I made and in turn > the whole idea about pagefaults tracing I got from the trace prototype > that Thomas Gleixner implemented in his 'trace' utility, described > here: > > Announcing a new utility: 'trace' > http://lwn.net/Articles/415728

Re: [PATCH 2/7] perf trace: add support for pagefault tracing

2014-06-20 Thread Stanislav Fomichev
> > 1756272.905 ( 0.000 ms): curl/5937 majfault [0x7fa7261978b6] => > > /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0+0x85288 (d.) > > Things like the above may be better expressed using dso@symbol+offset, > even more when the symbol is not resolved within a DSO, due to > insufficient expressivity

Re: [PATCH v2 0/7] perf trace pagefaults

2014-06-20 Thread Stanislav Fomichev
> Hey, haven't you seen the vfs_getname probe? Idea is to hook on where > the relevant copy_from_user is done and insert that into the ring > buffer, as we already do for mapping fd -> pathname. I saw it but didn't actually try because it needs all the debugging stuff enabled and in place. > I.e.

Re: [PATCHv2] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-15 Thread Stanislav Fomichev
Hi Steven, Did you have some spare time to check why I'm getting triple fault with the jump labels inside function tracers? Or will you just pull my another patch without them? On Thu, Jun 05, 2014 at 11:38:39AM +0400, Stanislav Fomichev wrote: > > You mean inside the function trace

[PATCH 4/4] perf timechart: add more options to IO mode

2014-06-26 Thread Stanislav Fomichev
--io-skip-eagain - don't show EAGAIN errors --io-min-time- make small io bursts visible --io-merge-dist - merge adjacent events Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c

[PATCH 2/4] perf timechart: implement IO mode

2014-06-26 Thread Stanislav Fomichev
polls). Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 613 +++- tools/perf/util/svghelper.c | 98 - tools/perf/util/svghelper.h | 6 +- 4 files ch

[PATCH v5 0/4] perf timechart io mode

2014-06-26 Thread Stanislav Fomichev
e fix into distinct commit - separated --io-xyz options into distinct commit - fixed 'error' shadowing - initialized variables in declaration when possible - removed assert usage - fprintf -> pr_err - removed wrongly placed __maybe_unused Stanislav Fomichev (4): perf time

[PATCH 1/4] perf timechart: fix rendering in Firefox

2014-06-26 Thread Stanislav Fomichev
Firefox doesn't correctly handle cases where we specify number in quotes and have some padding around the number, like the following: In this case, it doesn't draw the figure. This patch removes 'field width' component from fprintf strings to fix it. Signed-off-by: Stanislav

[PATCH 3/4] perf timechart: conditionally update start_time on fork

2014-06-26 Thread Stanislav Fomichev
We don't need to overwrite current task start_time on fork, so update it only if it's zero. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-t

[PATCH 5/5] perf trace: add possibility to switch off syscall events

2014-06-26 Thread Stanislav Fomichev
Currently, we may either trace syscalls or syscalls+pagefaults. We'd like to be able to trace *only* pagefaults and this commit implements this feature. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-trace.txt | 7 tools/perf/builtin-trace.c

[PATCH 3/5] perf trace: add pagefaults record and replay support

2014-06-26 Thread Stanislav Fomichev
Previous commit added live pagefault trace support, this one adds record and replay support. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 63 +- 1 file changed, 45 insertions(+), 18 deletions(-) diff --git a/tools/perf/builtin

[PATCH 4/5] perf trace: add pagefault statistics

2014-06-26 Thread Stanislav Fomichev
'perf trace' can show summary of events using -S option. This commit also reports number of major/minor pagefault events in this summary. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/perf/built

[PATCH 1/5] perf trace: add perf_event parameter to tracepoint_handler

2014-06-26 Thread Stanislav Fomichev
It will be used by next pagefault tracing patches in the series. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index f954c26de231

[PATCH 2/5] perf trace: add support for pagefault tracing

2014-06-26 Thread Stanislav Fomichev
( 0.000 ms): curl/5937 majfault [0x7fa7261978b6] => /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0@0x85288 (d.) 1862866.036 ( 0.000 ms): wget/8460 majfault [__clear_user+0x3f] => 0x659cb4 (?k) Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-trace.txt | 37 ++ to

[PATCH v3 0/5] perf trace pagefaults

2014-06-26 Thread Stanislav Fomichev
-pf=[all|min|maj]) - separated tracepoint_handler changes into additional patch - separated record/replay into additional patch - other fixes pointed out by Arnaldo Carvalho de Melo Stanislav Fomichev (5): perf trace: add perf_event parameter to tracepoint_handler perf trace: add suppo

Re: [PATCH 4/5] perf trace: add pagefault statistics

2014-06-27 Thread Stanislav Fomichev
> Where is it? > usleep (19155), 151 events, 84.4%, 0:68 faults, 0.000 msec ^^^ maj:min -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

Re: [PATCH 4/5] perf trace: add pagefault statistics

2014-06-27 Thread Stanislav Fomichev
On Fri, Jun 27, 2014 at 10:53:30AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 27, 2014 at 12:43:07PM +0400, Stanislav Fomichev escreveu: > > > Where is it? > > > usleep (19155), 151 events, 84.4%, 0:

[PATCH 3/4] perf timechart: conditionally update start_time on fork

2014-07-08 Thread Stanislav Fomichev
We don't need to overwrite current task start_time on fork, so update it only if it's zero. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-t

[PATCH v4 0/4] perf timechart io mode

2014-07-08 Thread Stanislav Fomichev
t commit - fixed 'error' shadowing - initialized variables in declaration when possible - removed assert usage - fprintf -> pr_err - removed wrongly placed __maybe_unused Stanislav Fomichev (4): perf timechart: fix rendering in Firefox perf timechart: implement IO mode

[PATCH 1/4] perf timechart: fix rendering in Firefox

2014-07-08 Thread Stanislav Fomichev
Firefox doesn't correctly handle cases where we specify number in quotes and have some padding around the number, like the following: In this case, it doesn't draw the figure. This patch removes 'field width' component from fprintf strings to fix it. Signed-off-by: Stanislav

[PATCH 4/4] perf timechart: add more options to IO mode

2014-07-08 Thread Stanislav Fomichev
--io-skip-eagain - don't show EAGAIN errors --io-min-time- make small io bursts visible --io-merge-dist - merge adjacent events Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c

[PATCH 2/4] perf timechart: implement IO mode

2014-07-08 Thread Stanislav Fomichev
polls). Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 620 +++- tools/perf/util/svghelper.c | 98 - tools/perf/util/svghelper.h | 6 +- 4 files ch

[PATCH] perf trace: add pagefault statistics

2014-07-08 Thread Stanislav Fomichev
0.000 0.033 0.246 91.00% arch_prctl 1 0.001 0.001 0.001 0.00% Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-tra

Re: [PATCHv3] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-15 Thread Stanislav Fomichev
graph tracer we register handler which reinitializes tracer depending on tracing_thresh. Signed-off-by: Stanislav Fomichev --- kernel/trace/trace.c | 65 kernel/trace/trace.h | 2 ++ kernel/trace/trace_functions_graph.c

[PATCH 0/2] perf timechart fix & io mode

2014-06-09 Thread Stanislav Fomichev
perf timechart: fix documentation moves misplaced options into appropriate place perf timechart: implement IO mode adds io mode, instead of process time we record io syscalls and then draw timechart of writes/reads/tx/rx/polls Stanislav Fomichev (2): perf timechart: fix documentation

  1   2   3   4   >