Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-24 Thread Stanimir Varbanov
Hi Malathi, On 1/21/19 1:20 PM, mgot...@codeaurora.org wrote: > On 2019-01-17 21:50, Stanimir Varbanov wrote: >> This refactored code for start/stop streaming vb2 operations and >> adds a state machine handling similar to the one in stateful codec >> API documentation. One

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-24 Thread Stanimir Varbanov
Hi Alex, Thanks for the comments! On 1/24/19 10:44 AM, Alexandre Courbot wrote: > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov > wrote: >> >> This refactored code for start/stop streaming vb2 operations and > > s/refactored/refactors? Ack. > >> adds a

Re: [PATCH v3] arm64: dts: sdm845: add video nodes

2019-01-25 Thread Stanimir Varbanov
Hi Alex, On 1/25/19 9:46 AM, Alexandre Courbot wrote: > On Thu, Jan 17, 2019 at 8:58 PM Stanimir Varbanov > wrote: >> >> Hi Malathi, >> >> On 12/20/18 9:47 AM, Malathi Gottam wrote: >>> This adds video nodes to sdm845 based on the examples >>>

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-25 Thread Stanimir Varbanov
Hi Tomasz, Thanks for the comments! On 1/25/19 9:59 AM, Tomasz Figa wrote: > .Hi Stan, > > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov > wrote: >> >> This refactored code for start/stop streaming vb2 operations and >> adds a state machine handling simila

Re: [PATCH 00/10] Venus stateful Codec API

2019-01-25 Thread Stanimir Varbanov
Hi Alex, On 1/25/19 7:34 AM, Alexandre Courbot wrote: > On Thu, Jan 24, 2019 at 7:13 PM Stanimir Varbanov > wrote: >> >> Hi Alex, >> >> Thank you for review and valuable comments! >> >> On 1/24/19 10:43 AM, Alexandre Courbot wrote: >>> H

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-05-20 Thread Stanimir Varbanov
Hi Tomasz, On 4/24/19 3:39 PM, Tomasz Figa wrote: > On Wed, Apr 24, 2019 at 9:15 PM Stanimir Varbanov > wrote: >> >> Hi Hans, >> >> On 2/15/19 3:44 PM, Hans Verkuil wrote: >>> Hi Stanimir, >>> >>> I never paid much attention to this patch

Re: [PATCH v5] PCI: qcom: Use default config space read function

2019-03-29 Thread Stanimir Varbanov
-- > drivers/pci/controller/dwc/pcie-qcom.c | 23 ++- > 1 file changed, 6 insertions(+), 17 deletions(-) Acked-by: Stanimir Varbanov -- regards, Stan

Re: [PATCH v2] media/doc: Allow sizeimage to be set by v4l clients

2019-05-07 Thread Stanimir Varbanov
Hi Mauro, Thanks for comments! On 5/2/19 4:29 PM, Mauro Carvalho Chehab wrote: > Em Thu, 2 May 2019 15:16:54 +0200 > Hans Verkuil escreveu: > >> On 5/2/19 2:55 PM, Mauro Carvalho Chehab wrote: >>> Em Fri, 12 Apr 2019 18:59:15 +0300 >>> Stanimir Varbanov e

[PATCH 1/2] venus: use on-chip interconnect API

2019-08-14 Thread Stanimir Varbanov
This aims to add a requests for bandwidth scaling depending on the resolution and framerate (macroblocks per second). The exact value ff the requested bandwidth is get from a pre-calculated tables for encoder and decoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus

[PATCH 0/2] Venus interconnect support for sdm845

2019-08-14 Thread Stanimir Varbanov
Hello, Here are two patches which adds interconnect bandwidth requests depending on the resolution (macroblocks) in order to lower bandwidth pressure on the interconnect and memory. regards, Stan Stanimir Varbanov (2): venus: use on-chip interconnect API arm64: dts: sdm845: Add interconnect

[PATCH 2/2] arm64: dts: sdm845: Add interconnect properties for Venus

2019-08-14 Thread Stanimir Varbanov
Populate Venus DT node with interconnect properties. Signed-off-by: Stanimir Varbanov --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 0323e3da190a..567bfc89bd77

[PATCH] arm64: dts: qcom: msm8996: Add Venus video codec DT node

2019-07-25 Thread Stanimir Varbanov
This adds Qualcomm Venus video codec DT node for the video codec hardware found in MSM8996 platforms. Signed-off-by: Stanimir Varbanov --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 68 +++ 1 file changed, 68 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi

Re: [PATCH] Revert "media: hfi_parser: don't trick gcc with a wrong expected size"

2019-06-06 Thread Stanimir Varbanov
Hi Jonathan, I sent a fix for that here [1] and Mauro already taken it. regards, Stan [1] https://patchwork.kernel.org/patch/10963369/ On 5.06.19 г. 23:19 ч., Jonathan Marek wrote: This reverts commit ded716267196862809e5926072adc962a611a1e3. This change doesn't make any sense and breaks the

[PATCH v2 04/11] venus: hfi: export few HFI functions

2019-06-28 Thread Stanimir Varbanov
Export few HFI functions to use them from decoder to implement more granular control needed for stateful Codec API compliance. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/qcom/venus

[PATCH v2 02/11] venus: helpers: export few helper functions

2019-06-28 Thread Stanimir Varbanov
Here we export few helper function to use them from decoder to implement more granular control needed for stateful Codec API compliance. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 29 - drivers/media/platform/qcom/venus/helpers.h | 6

[PATCH v2 07/11] venus: vdec_ctrls: get real minimum buffers for capture

2019-06-28 Thread Stanimir Varbanov
: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec_ctrls.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/vdec_ctrls.c b/drivers/media/platform/qcom/venus/vdec_ctrls.c index 300350bfe8bd..3a963cbd342a 100644 --- a/drivers/media

[PATCH v2 00/11] Venus stateful Codec API

2019-06-28 Thread Stanimir Varbanov
aurora.org/T/ Malathi Gottam (1): venus: venc: amend buffer size for bitstream plane Stanimir Varbanov (10): venus: helpers: export few helper functions venus: hfi: add type argument to hfi flush function venus: hfi: export few HFI functions venus: hfi: return an error if session_init

[PATCH v2 01/11] venus: venc: amend buffer size for bitstream plane

2019-06-28 Thread Stanimir Varbanov
From: Malathi Gottam Accept the buffer size requested by client and compare it against driver calculated size and set the maximum to bitstream plane. Signed-off-by: Malathi Gottam Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/venc.c | 13 + 1 file changed

[PATCH v2 10/11] venus: helpers: handle correctly vbuf field

2019-06-28 Thread Stanimir Varbanov
Correct handling of OUTPUT buffers field and make v4l2-compliance happy. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom

[PATCH v2 11/11] venus: dec: populate properly timestamps and flags for capture buffers

2019-06-28 Thread Stanimir Varbanov
Cache flags, timestamps and timecode structure of OUTPUT buffers in per-instance structure array and fill correctly the same when the CAPTURE buffers are done. This will make v4l2-compliance decoder streaming test happy. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus

[PATCH v2 09/11] venus: make decoder compliant with stateful codec API

2019-06-28 Thread Stanimir Varbanov
,OUT) just flush buffers but doesn't stop the session. The other major change is that now the capture and output queues are completely separated. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 24 +- drivers/media/platform/qcom/venus/helpers.c | 23 +- dr

[PATCH v2 06/11] venus: helpers: add three more helper functions

2019-06-28 Thread Stanimir Varbanov
This adds three more helper functions: * for internal buffers reallocation, applicable when we are doing dynamic resolution change * for initial buffer processing of capture and output queue buffer types All of them will be needed for stateful Codec API support. Signed-off-by: Stanimir

[PATCH v2 08/11] venus: vdec: allow bigger sizeimage set by clients

2019-06-28 Thread Stanimir Varbanov
In most of the cases the client will know better what could be the maximum size for compressed data buffers. Change the driver to permit the user to set bigger size for the compressed buffer but make reasonable sanitation. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus

[PATCH v2 05/11] venus: hfi: return an error if session_init is already called

2019-06-28 Thread Stanimir Varbanov
This makes hfi_session_init to return an error when it is already called without a call to hfi_session_deinit. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers

[PATCH v2 03/11] venus: hfi: add type argument to hfi flush function

2019-06-28 Thread Stanimir Varbanov
Make hfi_flush function to receive an argument for the type of flush. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c | 4 ++-- drivers/media/platform/qcom/venus/hfi.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom

Re: [PATCH v2 00/11] Venus stateful Codec API

2019-06-28 Thread Stanimir Varbanov
Hi Hans, On 6/28/19 4:37 PM, Hans Verkuil wrote: > On 6/28/19 2:59 PM, Stanimir Varbanov wrote: >> Hello, >> >> Here is v2 of the Venus transition to stateful codec API >> compliance. The v2 can be found at [1]. >> >> Changes since v1: >> * codec_stat

Re: [PATCH v3 1/4] media: venus: Add codec data table

2019-07-01 Thread Stanimir Varbanov
On 6/25/19 7:27 PM, Aniket Masule wrote: > Add vpp cycles for for different types of codec > It indicates the cycles required by video hardware > to process each macroblock. Initialize the codec > data with core resources. > > Signed-off-by: Aniket Masule > --- > drivers/media/platform/qcom/v

Re: [PATCH v3 2/4] media: venus: Update clock scaling

2019-07-01 Thread Stanimir Varbanov
On 6/25/19 7:27 PM, Aniket Masule wrote: > Current clock scaling calculations are same for vpu4 and > previous versions. For vpu4, Clock scaling calculations > are updated with cycles/mb. This helps in getting precise > clock required. > > Signed-off-by: Aniket Masule > --- > drivers/media/pl

Re: [PATCH v3 3/4] media: venus: Add interface for load per core

2019-07-01 Thread Stanimir Varbanov
Hi Aniket, On 6/25/19 7:27 PM, Aniket Masule wrote: > Add and interface to calculate load per core. Also, > add an interface to get maximum cores available with > video. This interface is preparation for updating core > selection. > > Signed-off-by: Aniket Masule > --- > drivers/media/platform/

Re: [PATCH v3 4/4] media: venus: Update core selection

2019-07-01 Thread Stanimir Varbanov
Hi, On 6/25/19 7:27 PM, Aniket Masule wrote: > Present core assignment is static. Introduced load balancing > across the cores. Load on earch core is calculated and core > with minimum load is assigned to given instance. > > Signed-off-by: Aniket Masule > --- > drivers/media/platform/qcom/venus

Re: [PATCH] media: venus: Update to bitrate based clock scaling

2019-07-01 Thread Stanimir Varbanov
Hi Aniket, On 6/26/19 11:23 AM, Aniket Masule wrote: > This patch introduces bitrate based clock scaling. Also, clock scaling is now > triggered before buffer being queued to the device. This checks for frequency > requirement throughout the session and updates clock with correct frequency > only

Re: [PATCH] media: venus: Update to bitrate based clock scaling

2019-07-01 Thread Stanimir Varbanov
Hi Aniket, On 6/26/19 11:23 AM, Aniket Masule wrote: > Introduced clock scaling using bitrate, current > calculations consider only the cycles per mb. > Also, clock scaling is now triggered before every > buffer being queued to the device. This helps in > deciding precise clock cycles required. >

[PATCH 0/4] Venus various fixes

2019-01-09 Thread Stanimir Varbanov
Hello, Here are four various fixes for venus driver. Comments are welcome! regards, Stan Stanimir Varbanov (4): venus: firmware: check fw size against DT memory region size venus: core: corect maximum hardware load for sdm845 venus: core: correct frequency table for sdm845 venus

[PATCH 3/4] venus: core: correct frequency table for sdm845

2019-01-09 Thread Stanimir Varbanov
This corrects clock frequency table rates to be in sync with video clock controller frequency table. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/qcom/venus

[PATCH 4/4] venus: helpers: drop setting of timestap invalid flag

2019-01-09 Thread Stanimir Varbanov
The zero timestap is really a valid so not sure why I discarded it. Fix that mistake by drop the code which checks for zero timestamp. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/platform

[PATCH 1/4] venus: firmware: check fw size against DT memory region size

2019-01-09 Thread Stanimir Varbanov
firmware size is smaller than provided by DT memory region. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/firmware.c | 54 +++- 2 files changed, 31 insertions(+), 24 deletions(-) diff --git a/drivers

[PATCH 2/4] venus: core: corect maximum hardware load for sdm845

2019-01-09 Thread Stanimir Varbanov
This corects maximum hardware load constant in per SoC resources for sdm845 aka Venus v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media

Re: [PATCH v4] PCI: qcom: Use default config space read function

2019-03-25 Thread Stanimir Varbanov
Hi Marc, On 3/25/19 2:11 PM, Marc Gonzalez wrote: > Stanimir, > > Is v4 good enough for Bjorn to pick up? Yes it is good but to avoid breaking another SoCs could you add fixups for the following SoCs: SoC device ID ipq4019 0x1001 ipq8064 0x101 ipq8074 0x108

Re: [PATCH] venus: vdec: fix decoded data size

2018-10-02 Thread Stanimir Varbanov
Hi, On 09/19/2018 06:02 PM, Stanimir Varbanov wrote: > Hi Alex, > > On 09/19/2018 01:32 PM, Alexandre Courbot wrote: >> On Mon, Sep 17, 2018 at 11:33 PM Hans Verkuil wrote: >>> >>> On 09/17/2018 04:30 PM, Stanimir Varbanov wrote: >>>> Hi Hans, &

Re: [PATCH v2 07/29] venus: hfi_venus: add halt AXI support for Venus 4xx

2018-05-21 Thread Stanimir Varbanov
Hi Tomasz, On 05/18/2018 05:23 PM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:12 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> Add AXI halt support for version 4xx by using venus wrapper >> registers. > >> Signed-off-by: Stanimir

Re: [PATCH v2 08/29] venus: hfi_venus: fix suspend function for venus 3xx versions

2018-05-21 Thread Stanimir Varbanov
Hi Tomasz, On 05/18/2018 06:14 PM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:11 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> This fixes the suspend function for Venus 3xx versions by >> add a check for WFI (wait for interrupt) bit. This bi

Re: [PATCH v2 02/29] venus: hfi: preparation to support venus 4xx

2018-05-21 Thread Stanimir Varbanov
Hi Tomasz, Thanks for the comments! On 05/18/2018 12:44 PM, Tomasz Figa wrote: > Hi Stanimir, > > On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> This covers the differences between 1xx,3xx and 4xx. > >&

Re: [PATCH v2 03/29] venus: hfi: update sequence event to handle more properties

2018-05-21 Thread Stanimir Varbanov
Hi Tomasz, On 05/18/2018 04:53 PM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> HFI version 4xx can pass more properties in the sequence change >> event, extend the event structure with them. &g

Re: [PATCH v2 04/29] venus: hfi_cmds: add set_properties for 4xx version

2018-05-21 Thread Stanimir Varbanov
Hi Tomasz, On 05/18/2018 05:16 PM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:13 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> Adds set_properties method to handle newer 4xx properties and >> fall-back to 3xx for the rest. > >&

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

2018-04-02 Thread Stanimir Varbanov
Hi, Please adjust your mail client to drop on new line on 80 column! On 03/29/2018 08:55 PM, Channa wrote: > On 2018-03-29 01:08, Stanimir Varbanov wrote: >> Hi, >> >> On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: >>> LLCC (Last Level Cache Controller) provides

[PATCH 00/28] Venus updates

2018-04-24 Thread Stanimir Varbanov
are welcome! regards, Stan Stanimir Varbanov (28): venus: hfi_msgs: correct pointer increment venus: hfi: preparation to support venus 4xx venus: hfi: update sequence event to handle more properties venus: hfi_cmds: add set_properties for 4xx version venus: hfi: support session continue

[PATCH 01/28] venus: hfi_msgs: correct pointer increment

2018-04-24 Thread Stanimir Varbanov
Data pointer should be incremented by size of the structure not the size of a pointer, correct the mistake. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus

[PATCH 04/28] venus: hfi_cmds: add set_properties for 4xx version

2018-04-24 Thread Stanimir Varbanov
Adds set_properties method to handle newer 4xx properties and fall-back to 3xx for the rest. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_cmds.c | 64 +++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform

[PATCH 05/28] venus: hfi: support session continue for 4xx version

2018-04-24 Thread Stanimir Varbanov
This makes possible to handle session_continue for 4xx as well. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers/media/platform/qcom/venus/hfi.c

[PATCH 24/28] venus: vdec: new function for output configuration

2018-04-24 Thread Stanimir Varbanov
Make a new function vdec_output_conf() for decoder output configuration. vdec_output_conf() will set properties via HFI interface related to the output configuration, and keep vdec_set_properties() which will set properties related to decoding parameters. Signed-off-by: Stanimir Varbanov

[PATCH 25/28] venus: move frame size calculations in common place

2018-04-24 Thread Stanimir Varbanov
move calculations of raw and compressed in a common helper and make it identical for encoder and decoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 98 + drivers/media/platform/qcom/venus/helpers.h | 2 + drivers/media

[PATCH 15/28] venus: add a helper function to set dynamic buffer mode

2018-04-24 Thread Stanimir Varbanov
Adds a new helper function to set dymaic buffer mode if it is supported by current HFI version. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 22 ++ drivers/media/platform/qcom/venus/helpers.h | 1 + drivers/media/platform/qcom/venus

[PATCH 27/28] venus: add sdm845 compatible and resource data

2018-04-24 Thread Stanimir Varbanov
This adds sdm845 DT compatible string with it's resource data table. Cc: devicet...@vger.kernel.org Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/media/qcom,venus.txt | 1 + drivers/media/platform/qcom/venus/core.c | 22 ++ 2 files change

[PATCH 23/28] venus: vdec: get required input buffers as well

2018-04-24 Thread Stanimir Varbanov
Rework and rename vdec_cap_num_buffers() to get the number of input buffers too. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec.c | 41 +++- 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/drivers/media/platform/qcom/venus

[PATCH 28/28] venus: add HEVC codec support

2018-04-24 Thread Stanimir Varbanov
This add HEVC codec support for venus versions 3xx and 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 3 +++ drivers/media/platform/qcom/venus/hfi.c | 2 ++ drivers/media/platform/qcom/venus/vdec.c| 4 drivers/media/platform/qcom/venus

[PATCH 26/28] venus: implementing multi-stream support

2018-04-24 Thread Stanimir Varbanov
This is implementing a multi-stream decoder support. The multi stream gives an option to use the secondary decoder output with different raw format (or the same in case of crop). Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 1 + drivers/media/platform

[PATCH 17/28] venus: delete no longer used bufmode flag from instance

2018-04-24 Thread Stanimir Varbanov
Delete no longer used flag cap_bufs_mode_dynamic from instance structure. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 -- drivers/media/platform/qcom/venus/hfi_parser.c | 6 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers

[PATCH 16/28] venus: add helper function to set actual buffer size

2018-04-24 Thread Stanimir Varbanov
Add and use a helper function to set actual buffer size for particular buffer type. This is also preparation to use the second decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 12 drivers/media/platform/qcom/venus/helpers.h | 1

[PATCH 14/28] venus: helpers: rename a helper function and use buffer mode from caps

2018-04-24 Thread Stanimir Varbanov
Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and use buffer mode from enumerated per codec capabilities. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH 13/28] venus: core: delete not used flag for buffer mode

2018-04-24 Thread Stanimir Varbanov
Delete not used flag for capture buffer allocation mode. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h index fe2d2b9e8af8

[PATCH 19/28] venus: helpers: add a new helper to set raw format

2018-04-24 Thread Stanimir Varbanov
The new helper will has one more argument for buffer type, that way the decoder can configure the format on it's secondary output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 52 ++--- drivers/media/platform/qcom/venus/help

[PATCH 18/28] venus: helpers: add buffer type argument to a helper

2018-04-24 Thread Stanimir Varbanov
This adds one more function argument to pass buffer type to set_output_resolution() helper function. That is a preparation to support secondary decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 5 +++-- drivers/media/platform/qcom/venus/helpers.h

[PATCH 20/28] venus: helpers,vdec,venc: add helpers to set work mode and core usage

2018-04-24 Thread Stanimir Varbanov
These are new properties applicable to Venus version 4xx. Add the helpers and call them from decoder and encoder drivers. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 28 drivers/media/platform/qcom/venus/helpers.h | 2

[PATCH 21/28] venus: helpers: extend set_num_bufs helper with one more argument

2018-04-24 Thread Stanimir Varbanov
Extend venus_helper_set_num_bufs() helper function with one more argument to set number of output buffers for the secondary decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 16 ++-- drivers/media/platform/qcom/venus/helpers.h | 3

[PATCH 22/28] venus: helpers: add a helper to return opb buffer sizes

2018-04-24 Thread Stanimir Varbanov
Add a helper function to return current output picture buffer size. OPB sizes can vary depending on the selected decoder output(s). Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 10 ++ drivers/media/platform/qcom/venus/helpers.c | 15

[PATCH 12/28] venus: helpers: make a commmon function for power_enable

2018-04-24 Thread Stanimir Varbanov
Make common function which will enable power when enabling/disabling clocks and also covers Venus 3xx/4xx versions. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 51 + drivers/media/platform/qcom/venus/helpers.h | 2 ++ drivers

[PATCH 11/28] venus: add common capability parser

2018-04-24 Thread Stanimir Varbanov
This adds common capability parser for all supported Venus versions. Having it will help to enumerate better the supported raw formars and codecs and also the capabilities for every codec like max/min width/height, framerate, bitrate and so on. Signed-off-by: Stanimir Varbanov --- drivers/media

[PATCH 09/28] venus: venc,vdec: adds clocks needed for venus 4xx

2018-04-24 Thread Stanimir Varbanov
This extends the clocks number to support suspend and resume on Venus version 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 4 +-- drivers/media/platform/qcom/venus/vdec.c | 42 ++-- drivers/media/platform/qcom/venus/venc.c

[PATCH 10/28] venus: vdec: call session_continue in insufficient event

2018-04-24 Thread Stanimir Varbanov
Call session_continue for Venus 4xx version even when the event says that the buffer resources are not sufficient. Leaving a comment with more information about the workaround. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec.c | 8 1 file changed, 8

[PATCH 07/28] venus: hfi_venus: add halt AXI support for Venus 4xx

2018-04-24 Thread Stanimir Varbanov
Add AXI halt support for version 4xx by using venus wrapper registers. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media

[PATCH 06/28] venus: hfi: handle buffer output2 type as well

2018-04-24 Thread Stanimir Varbanov
This adds handling of buffers of type OUTPUT2 which is needed to support Venus 4xx version. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c | 3 ++- drivers/media/platform/qcom/venus/hfi_msgs.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

2018-04-24 Thread Stanimir Varbanov
This adds suspend (power collapse) function with slightly different order of calls comparing with Venus 3xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 52 +++ 1 file changed, 52 insertions(+) diff --git a/drivers/media/platform

[PATCH 02/28] venus: hfi: preparation to support venus 4xx

2018-04-24 Thread Stanimir Varbanov
This covers the differences between 1xx,3xx and 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 4 ++ drivers/media/platform/qcom/venus/helpers.c | 37 +++ drivers/media/platform/qcom/venus/hfi_helper.h | 84

[PATCH 03/28] venus: hfi: update sequence event to handle more properties

2018-04-24 Thread Stanimir Varbanov
HFI version 4xx can pass more properties in the sequence change event, extend the event structure with them. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.h | 9 ++ drivers/media/platform/qcom/venus/hfi_msgs.c | 46 2 files

Re: [PATCH 10/28] venus: vdec: call session_continue in insufficient event

2018-05-03 Thread Stanimir Varbanov
Hi Vikash, Thanks for the comments! On 2.05.2018 09:26, Vikash Garodia wrote: Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: Call session_continue for Venus 4xx version even when the event says that the buffer resources are not sufficient. Leaving a comment with more

Re: [PATCH 10/28] venus: vdec: call session_continue in insufficient event

2018-05-09 Thread Stanimir Varbanov
Hi Vikash, On 05/04/2018 02:09 PM, Vikash Garodia wrote: > Hi Stanimir, > > On 2018-05-03 17:06, Stanimir Varbanov wrote: >> Hi Vikash, >> >> Thanks for the comments! >> >> On  2.05.2018 09:26, Vikash Garodia wrote: >>> Hello Stanimir, >

Re: [PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

2018-05-09 Thread Stanimir Varbanov
Hi Vikash, On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote: > Hello Stanimir, > > On 2018-04-24 18:14, Stanimir Varbanov wrote: >> This adds suspend (power collapse) function with slightly >> different order of calls comparing with Venus 3xx. >> >>

Re: [PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

2018-05-09 Thread Stanimir Varbanov
Hi, On 05/09/2018 05:14 PM, Vikash Garodia wrote: > Hi Stanimir, > > On 2018-05-09 16:45, Stanimir Varbanov wrote: >> Hi Vikash, >> >> On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote: >>> Hello Stanimir, >>> >>> On 2018-04-24 18:14,

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

2018-05-09 Thread Stanimir Varbanov
Hi, On 9.05.2018 07:51, Shawn Guo wrote: Hi Bjorn, On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote: ... + return ret; + } + } + + pci->pp.root_bus_nr = -1; Setting root_bus_nr looks like an unrelated change that should be in a se

Re: [PATCH] venus: vdec: fix format enumeration

2018-03-15 Thread Stanimir Varbanov
Hi Alex, Thanks for the patch! On 13.03.2018 11:11, Alexandre Courbot wrote: > find_format_by_index() stops enumerating formats as soon as the index > matches, and returns NULL if venus_helper_check_codec() finds out that > the format is not supported. This prevents formats to be properly > enume

Re: [PATCH 28/28] venus: add HEVC codec support

2018-05-07 Thread Stanimir Varbanov
Hi Hans, On 7.05.2018 13:39, Hans Verkuil wrote: On 24/04/18 14:44, Stanimir Varbanov wrote: This add HEVC codec support for venus versions 3xx and 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 3 +++ drivers/media/platform/qcom/venus/hfi.c

Re: [PATCH 00/28] Venus updates

2018-05-07 Thread Stanimir Varbanov
Hi Hans, On 7.05.2018 13:41, Hans Verkuil wrote: On 24/04/18 14:44, Stanimir Varbanov wrote: Hello, This patch set aims to: * add initial support for Venus version 4xx (found on sdm845). * introduce a common capability parser to enumerate better supported uncompressed formats

[PATCH 2/3] remoteproc: add empty remoteproc API functions in header

2016-11-22 Thread Stanimir Varbanov
With this addition in place the drivers which uses remote processor APIs will be able to be compile tested on different architectures with COMPILE_TEST Kconfig option. Signed-off-by: Stanimir Varbanov --- include/linux/remoteproc.h | 24 1 file changed, 24 insertions

[PATCH 3/3] firmware: qcom: scm: Add empty functions to help compile testing

2016-11-22 Thread Stanimir Varbanov
This will help to compile testing drivers which depends on scm functions with COMPILE_TEST Kconfig option. Signed-off-by: Stanimir Varbanov --- include/linux/qcom_scm.h | 53 +--- 1 file changed, 37 insertions(+), 16 deletions(-) diff --git a/include

[PATCH 1/3] remoteproc: qcom: mdt_loader: add include for sizes

2016-11-22 Thread Stanimir Varbanov
/remoteproc/qcom_mdt_loader.c:18: drivers/remoteproc/qcom_mdt_loader.c: In function ‘qcom_mdt_parse’: drivers/remoteproc/qcom_mdt_loader.c:90:52: error: ‘SZ_4K’ undeclared (first use in this function) Signed-off-by: Stanimir Varbanov --- drivers/remoteproc/qcom_mdt_loader.c | 1 + 1 file changed, 1

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-24 Thread Stanimir Varbanov
Hi Nicolas, On 11/23/2016 10:24 PM, Nicolas Dufresne wrote: > Le lundi 21 novembre 2016 à 18:09 +0200, Stanimir Varbanov a écrit : >>>> Meanwhile I have found bigger obstacle - I cannot run multiple >> instances >>>> simultaneously. By m2m design it can exe

Re: [PATCH V2 1/2] clk: qcom: gdsc: Add support for gdscs with HW control

2017-01-09 Thread Stanimir Varbanov
Hi Sricharan, On 11/18/2016 02:28 PM, Sricharan R wrote: > From: Rajendra Nayak > > Some GDSCs might support a HW control mode, where in the power > domain (gdsc) is brought in and out of low power state (while > unsued) without any SW assistance, saving power. > Such GDSCs can be configured in

Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable

2017-01-10 Thread Stanimir Varbanov
reflects its 'on' before force disabling it > in software. > > Reported-by: Stanimir Varbanov > Signed-off-by: Rajendra Nayak > --- > > Stan, > If there was a specific issue you saw with venus because of the missing > delay and poll, can you

Re: [PATCH v4 8/9] media: venus: hfi: add Venus HFI files

2017-01-10 Thread Stanimir Varbanov
Hi Hans, On 01/09/2017 03:04 PM, Hans Verkuil wrote: > On 12/05/2016 01:20 PM, Stanimir Varbanov wrote: >> Hi Hans, >> >> On 12/05/2016 02:05 PM, Hans Verkuil wrote: >>> On 12/01/2016 10:03 AM, Stanimir Varbanov wrote: >>>> Here is the implement

Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable

2017-01-10 Thread Stanimir Varbanov
;on' before force disabling it > in software. > > Reported-by: Stanimir Varbanov > Signed-off-by: Rajendra Nayak > --- > > Stan, > If there was a specific issue you saw with venus because of the missing > delay and poll, can you check if this fixes any of that. Somet

Re: [PATCH v2] clk: qcom: gdsc: Fix handling of hw control enable/disable

2017-01-26 Thread Stanimir Varbanov
n software. Reported-by: Stanimir Varbanov Signed-off-by: Rajendra Nayak --- drivers/clk/qcom/gdsc.c | 58 ++--- 1 file changed, 45 insertions(+), 13 deletions(-) Reviewed and Tested-by: Stanimir Varbanov regards, Stan

[PATCH v3 0/2] Venus remoteproc driver

2017-01-27 Thread Stanimir Varbanov
Changes since v2: - addressed comments in dt-binding document - added MODULE_DEVICE_TABLE and deleted unused define regards, Stan Stanimir Varbanov (2): dt-binding: remoteproc: venus rproc dt binding document remoteproc: qcom: add Venus video core firmware loader driver

[PATCH v3 2/2] remoteproc: qcom: add Venus video core firmware loader driver

2017-01-27 Thread Stanimir Varbanov
This driver will load and authenticate the Venus firmware and bringing it core out of reset. Those two functionalities are via secure monitor calls to trusted environment. Signed-off-by: Stanimir Varbanov --- drivers/remoteproc/Kconfig | 12 +++ drivers/remoteproc/Makefile

[PATCH v3 1/2] dt-binding: remoteproc: venus rproc dt binding document

2017-01-27 Thread Stanimir Varbanov
Add devicetree binding document for Venus remote processor. Acked-by: Rob Herring Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/remoteproc/qcom,venus.txt | 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v2 1/3] firmware: qcom: scm: add a video command for state setting

2016-11-07 Thread Stanimir Varbanov
This scm call is used to change the video core state, more specifically it is used to suspend and resume the core. Signed-off-by: Stanimir Varbanov --- drivers/firmware/qcom_scm-32.c | 18 ++ drivers/firmware/qcom_scm-64.c | 16 drivers/firmware/qcom_scm.c

[PATCH v2 0/3] Venus remoteproc driver

2016-11-07 Thread Stanimir Varbanov
Hi, here is v2 of the Venus remoteproc driver, the changes are: - removed page table size and page table init SCM calls. regards, Stan Stanimir Varbanov (3): firmware: qcom: scm: add a video command for state setting dt-binding: remoteproc: venus rproc dt binding document

[PATCH v3 8/9] media: venus: add Makefiles and Kconfig files

2016-11-07 Thread Stanimir Varbanov
Makefile and Kconfig files to build the Venus video codec driver. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/Kconfig| 7 +++ drivers/media/platform/qcom/Makefile | 1 + drivers/media/platform/qcom/venus/Makefile | 15 +++ 3 files changed, 23

[PATCH v3 7/9] media: venus: hfi: add Venus HFI files

2016-11-07 Thread Stanimir Varbanov
Here is the implementation of Venus video accelerator low-level functionality. It contanins code which setup the registers and startup uthe processor, allocate and manipulates with the shared memory used for sending commands and receiving messages. Signed-off-by: Stanimir Varbanov --- drivers

[PATCH v3 6/9] media: venus: hfi: add Host Firmware Interface (HFI)

2016-11-07 Thread Stanimir Varbanov
session and core initialisation. - hfi_cmds has packetization operations which preparing packets to be send from host to firmware. - hfi_msgs takes care of messages sent from firmware to the host. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c| 604

[PATCH v3 5/9] media: venus: venc: add video encoder files

2016-11-07 Thread Stanimir Varbanov
This adds encoder part of the driver plus encoder controls. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/venc.c | 1212 drivers/media/platform/qcom/venus/venc.h | 32 + drivers/media/platform/qcom/venus/venc_ctrls.c | 396

<    2   3   4   5   6   7   8   9   10   11   >