Re: [PATCH 3/9] crypto: qce: Add dma and sg helpers

2014-04-04 Thread Stanimir Varbanov
Hi Courtney, Thanks for the comments! On 04/04/2014 02:15 AM, Courtney Cavin wrote: > On Thu, Apr 03, 2014 at 06:18:00PM +0200, Stanimir Varbanov wrote: >> This adds dmaengine and sg-list helper functions used by >> other parts of the crypto driver. >> >> Signe

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-04 Thread Stanimir Varbanov
Hi Josh, Thanks for the comments! On 04/03/2014 09:19 PM, Josh Cartwright wrote: > Hey Stanimir- > > Just a few comments/questions from a quick scan of your patchset: > > On Thu, Apr 03, 2014 at 07:17:58PM +0300, Stanimir Varbanov wrote: > [..] >> +++ b/d

[PATCH v2 0/2] Add support for Qualcomm's PRNG

2013-10-11 Thread Stanimir Varbanov
sfuly probe the driver and the second patch adds the driver. Comments are welecome! Stanimir Varbanov (2): ARM: DT: msm: Add Qualcomm's PRNG driver binding document hwrng: msm: Add PRNG support for MSM SoC's .../devicetree/bindings/rng/qcom,prng.txt

[PATCH v2 1/2] ARM: DT: msm: Add Qualcomm's PRNG driver binding document

2013-10-11 Thread Stanimir Varbanov
This adds Qualcomm PRNG driver device tree binding documentation to use as an example in dts trees. Signed-off-by: Stanimir Varbanov --- Documentation/devicetree/bindings/rng/qcom,prng.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-11 Thread Stanimir Varbanov
This adds a driver for hardware random number generator present on Qualcomm MSM SoC's. Signed-off-by: Stanimir Varbanov --- drivers/char/hw_random/Kconfig | 12 +++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/msm-rng.c | 195 +

Re: [PATCH v2 1/2] ARM: DT: msm: Add Qualcomm's PRNG driver binding document

2013-10-14 Thread Stanimir Varbanov
Hi Stephen, Thanks for the review. On 10/11/2013 11:46 PM, Stephen Boyd wrote: > On 10/11, Stanimir Varbanov wrote: >> This adds Qualcomm PRNG driver device tree binding documentation >> to use as an example in dts trees. >> >> Signed-off-by: Stanimir Varbano

Re: [PATCH v2 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-14 Thread Stanimir Varbanov
Hi Stephen, Thanks for the review. On 10/11/2013 11:37 PM, Stephen Boyd wrote: > On 10/11, Stanimir Varbanov wrote: >> This adds a driver for hardware random number generator present >> on Qualcomm MSM SoC's. >> >> Signed-off-by: Stanimir Varbanov >> ---

[PATCH v3 1/2] ARM: DT: msm: Add Qualcomm's PRNG driver binding document

2013-10-15 Thread Stanimir Varbanov
This adds Qualcomm PRNG driver device tree binding documentation to use as an example in dts trees. Signed-off-by: Stanimir Varbanov --- Documentation/devicetree/bindings/rng/qcom,prng.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v3 0/2] Add support for Qualcomm's PRNG

2013-10-15 Thread Stanimir Varbanov
= This patch set adds hardware RNG driver wich is used to control the Qualcomm's PRNG hardware block. The first patch document the DT bindings needed to sucessfuly probe the driver and the second patch adds the driver. Comments are welecome! Stanimir V

[PATCH v3 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-15 Thread Stanimir Varbanov
This adds a driver for hardware random number generator present on Qualcomm MSM SoC's. Signed-off-by: Stanimir Varbanov --- drivers/char/hw_random/Kconfig | 12 +++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/msm-rng.c | 197 +

[PATCH v2 0/4] Support for Qualcomm QPNP PMIC's

2014-07-17 Thread Stanimir Varbanov
inconvenience in the peripheral drivers to define internally the SPMI base addresses depending on the compatible property i.e. PMIC version. Comments are welcome! regards, Stan [1] https://lkml.org/lkml/2014/7/8/428 Josh Cartwright (1): mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs Stanimir

[PATCH v2 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs

2014-07-17 Thread Stanimir Varbanov
From: Josh Cartwright The Qualcomm SPMI PMIC chips are components used with the Snapdragon 800 series SoC family. This driver exists largely as a glue mfd component, it exists to be an owner of an SPMI regmap for children devices described in device tree. Signed-off-by: Stanimir Varbanov

[PATCH v2 3/4] ARM: DT: qcom: add pm8941 and pm8841 device nodes

2014-07-17 Thread Stanimir Varbanov
The pm8941 and pm8841 spmi devicetree nodes are childrens of spmi pmic arbiter. The msm8974 SoC uses two PMIC chips pm8941 and pm8841. Every PMIC chip has two spmi bus slave id's. Signed-off-by: Stanimir Varbanov --- arch/arm/boot/dts/qcom-msm8974.dtsi |

[PATCH v2 4/4] mfd: pm8921: rename pm8921-core driver

2014-07-17 Thread Stanimir Varbanov
The pm8921-core driver presently supports pm8921 and pm8058 Qualcomm PMICs. To avoid confusion with new generation PMICs (like pm8941) rename the pm8921-core driver to more appropriate name pm8xxx-ssbi, which reflects better that those chips use SSBI interface. Signed-off-by: Stanimir Varbanov

[PATCH v2 2/4] mfd: pm8xxx-spmi: document DT bindings for Qualcomm SPMI PMICs

2014-07-17 Thread Stanimir Varbanov
Document DT bindings used to describe the Qualcomm SPMI PMICs. Currently the SPMI PMICs supported are pm8941, pm8841 and pma8084. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/mfd/qcom,pm8xxx-spmi.txt | 49 1 files changed, 49 insertions(+), 0 deletions

Re: [PATCH v2 0/4] Support for Qualcomm QPNP PMIC's

2014-07-18 Thread Stanimir Varbanov
On 07/18/2014 02:10 AM, Stephen Boyd wrote: > On 07/17/14 09:17, Stanimir Varbanov wrote: >> Hello everyone, >> >> Here is the continuation of patch sets sent recently about Qualcomm >> QPNP SPMI PMICs. >> >> The previous version of the patch set can

use IORESOURCE_REG resource type for non-translatable addresses in DT

2014-07-29 Thread Stanimir Varbanov
Hi, While looking in MFD drivers I saw that few of them (88pm860x-core, max8925-core and wm831x-core) allow use of IORESOURCE_REG as resource type when calling platform_get_resource() by their child drivers. The resources for these child devices are filled by core MFD driver manually and then pas

Re: use IORESOURCE_REG resource type for non-translatable addresses in DT

2014-07-29 Thread Stanimir Varbanov
Arnd, thanks for the comments. On 07/29/2014 03:00 PM, Arnd Bergmann wrote: > On Tuesday 29 July 2014 14:42:31 Stanimir Varbanov wrote: >> taddr = of_translate_address(dev, addrp); >> - if (taddr == OF_BAD_ADDR) >> - return -EINVAL; >> +

Re: [PATCH v3 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs

2014-07-31 Thread Stanimir Varbanov
Hi David, Thanks for the comments! On 07/30/2014 12:54 AM, David Collins wrote: > On 07/24/2014 05:45 AM, Stanimir Varbanov wrote: >> From: Josh Cartwright >> >> The Qualcomm SPMI PMIC chips are components used with the >> Snapdragon 800 series SoC family. This dr

Re: [PATCH v3 2/4] mfd: pm8xxx-spmi: document DT bindings for Qualcomm SPMI PMICs

2014-07-31 Thread Stanimir Varbanov
On 07/30/2014 01:23 AM, David Collins wrote: > On 07/24/2014 05:45 AM, Stanimir Varbanov wrote: >> Document DT bindings used to describe the Qualcomm SPMI PMICs. >> Currently the SPMI PMICs supported are pm8941, pm8841 and pma8084. >> >> Signed-off-by: Stanimir Varban

Re: [PATCH v3 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs

2014-08-01 Thread Stanimir Varbanov
On 07/31/2014 11:48 AM, Stanimir Varbanov wrote: > Hi David, > > Thanks for the comments! > > On 07/30/2014 12:54 AM, David Collins wrote: >> On 07/24/2014 05:45 AM, Stanimir Varbanov wrote: >>> From: Josh Cartwright >>> >>> The Qualc

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-18 Thread Stanimir Varbanov
Hi Jonathan, On 09/15/2014 07:11 PM, Jonathan Cameron wrote: > > > On September 15, 2014 3:12:50 PM GMT+01:00, Stanimir Varbanov > wrote: >> Hi Jonathan, >> >> Thanks for the review! >> >> On 09/13/2014 08:27 PM, Jonathan Cameron wrote: &

Re: [PATCH] rtc: pm8xxx: rework to support pm8941 rtc

2014-09-23 Thread Stanimir Varbanov
On 09/20/2014 02:03 AM, Andrew Morton wrote: > On Fri, 12 Sep 2014 12:44:04 +0300 Stanimir Varbanov > wrote: > >> Adds support for RTC device inside PM8941 PMIC. The RTC >> in this PMIC have two register spaces. Thus the rtc-pm8xxx >> is slightly reworked to reflect t

Re: [PATCH] rtc: pm8xxx: rework to support pm8941 rtc

2014-09-23 Thread Stanimir Varbanov
Hi Paul, On 09/23/2014 11:50 AM, Paul Bolle wrote: > Hi Stanimar, > > On Fri, 2014-09-12 at 12:44 +0300, Stanimir Varbanov wrote: >> Adds support for RTC device inside PM8941 PMIC. The RTC >> in this PMIC have two register spaces. Thus the rtc-pm8xxx >> is slightl

Re: [PATCH v4 0/3] Support for Qualcomm QPNP PMIC's

2014-09-23 Thread Stanimir Varbanov
Hi Lee, There are no comments on this set for more then month, could you queue up 1/3 and 2/3 for 3.18 merge window? On 08/01/2014 05:30 PM, Stanimir Varbanov wrote: > Hello all, > > Changes since v3: > - rename the driver to qcom-spmi-pmic - suggested by David Collins > - spm

[PATCH] DT: mfd: pm8xxx: Add new compatible string

2014-09-23 Thread Stanimir Varbanov
The rtc driver now supports PM8941 PMIC device, reflect this in the binding document. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/mfd/qcom,pm8xxx.txt|1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/qcom

[PATCH v3 0/2] Intial support for voltage ADC

2014-09-24 Thread Stanimir Varbanov
t for VADC inside Qualcomm SPMI PMICs. The vadc driver is reworked version of the same downstream driver but now it is implemented through Industrial IO core. Stanimir Varbanov (2): iio: vadc: Qualcomm SPMI PMIC voltage ADC driver DT: iio: vadc: document dt binding .../devicetree/bindings/ii

[PATCH v3 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-24 Thread Stanimir Varbanov
The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has 15bits resolution and register space inside PMIC accessible across SPMI bus. The vadc driver registers itself through IIO interface. Signed-off-by: Stanimir Varbanov Signed-off-by: Ivan T. Ivanov --- drivers/iio/adc/Kconfig

[PATCH v3 2/2] DT: iio: vadc: document dt binding

2014-09-24 Thread Stanimir Varbanov
Document DT binding for Qualcomm SPMI PMIC voltage ADC driver. Signed-off-by: Stanimir Varbanov Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 130 1 files changed, 130 insertions(+), 0 deletions(-) create mode 100644 Documentation

Re: [PATCH v3 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-25 Thread Stanimir Varbanov
Hi Ivan, On 09/25/2014 03:47 PM, Ivan T. Ivanov wrote: > > Hi Stan, few comment bellow. > > On Wed, 2014-09-24 at 15:56 +0300, Stanimir Varbanov wrote: >> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has >> 15bits resolution and register space insid

[PATCH v2 0/2] Intial support for voltage ADC

2014-09-11 Thread Stanimir Varbanov
downstream driver but now it is implemented through Industrial IO core. Comments are welcome! Stanimir Varbanov (2): iio: vadc: Qualcomm SPMI PMIC voltage ADC driver DT: iio: vadc: document dt binding .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 123 +++ drivers/iio/a

[PATCH v2 2/2] DT: iio: vadc: document dt binding

2014-09-11 Thread Stanimir Varbanov
Document DT binding for Qualcomm SPMI PMIC voltage ADC driver. Signed-off-by: Stanimir Varbanov Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 123 1 files changed, 123 insertions(+), 0 deletions(-) create mode 100644 Documentation

[PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-11 Thread Stanimir Varbanov
The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has 15bits resolution and register space inside PMIC accessible across SPMI bus. The vadc driver registers itself through IIO interface. Signed-off-by: Stanimir Varbanov Signed-off-by: Ivan T. Ivanov --- drivers/iio/adc/Kconfig

[PATCH] rtc: pm8xxx: rework to support pm8941 rtc

2014-09-12 Thread Stanimir Varbanov
Adds support for RTC device inside PM8941 PMIC. The RTC in this PMIC have two register spaces. Thus the rtc-pm8xxx is slightly reworked to reflect these differences. The register set for different PMIC chips are selected on DT compatible string base. Signed-off-by: Stanimir Varbanov

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-15 Thread Stanimir Varbanov
Hi Jonathan, Thanks for the review! On 09/13/2014 08:27 PM, Jonathan Cameron wrote: > On 13/09/14 00:27, Hartmut Knaack wrote: >> Stanimir Varbanov schrieb, Am 11.09.2014 17:13: >>> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has >>> 15bits resolutio

Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-15 Thread Stanimir Varbanov
Thanks for the comments! On 09/13/2014 02:27 AM, Hartmut Knaack wrote: > Stanimir Varbanov schrieb, Am 11.09.2014 17:13: >> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has >> 15bits resolution and register space inside PMIC accessible across >> SPMI bus.

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-29 Thread Stanimir Varbanov
Thanks for the review! On 04/28/2014 11:00 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: >> >> +if (IS_AES(flags)) { >> +switch (keylen) { >> +case AES_KEYSIZE_128: >>

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-29 Thread Stanimir Varbanov
Thanks for the review! On 04/28/2014 11:18 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: >> >> +} else if (IS_DES(flags)) { >> +u32 tmp[DES_EXPKEY_WORDS]; >> + >> +if (keylen != QCE_DES_KEY_S

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-29 Thread Stanimir Varbanov
Thanks for the review! On 04/28/2014 11:50 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: >> >> +if (backlog) >> +backlog->complete(backlog, -EINPROGRESS); > > The completion function needs to be called

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-30 Thread Stanimir Varbanov
Hi Herbert, On 04/28/2014 11:59 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: >> >> +#define QCE_MAJOR_VERSION5 0x05 >> +#define QCE_QUEUE_LENGTH50 > > What is the purpose of this software queue? Why can't you dir

Re: [PATCH 3/9] crypto: qce: Add dma and sg helpers

2014-04-08 Thread Stanimir Varbanov
Hi On 04/08/2014 01:42 AM, Courtney Cavin wrote: > On Fri, Apr 04, 2014 at 03:07:13PM +0200, Stanimir Varbanov wrote: >>>> diff --git a/drivers/crypto/qce/dma.h b/drivers/crypto/qce/dma.h >>>> new file mode 100644 >>>> index ..932b02fd8f25 >&

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-08 Thread Stanimir Varbanov
Hi Courtney, Thanks for the review! On 04/04/2014 02:38 AM, Courtney Cavin wrote: > On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: >> This adds core driver files. The core part is implementing a >> platform driver probe and remove callbaks, the probe enables &g

Re: [PATCH 5/9] crypto: qce: Adds sha and hmac transforms

2014-04-10 Thread Stanimir Varbanov
Hi Stephen, thanks for the comments. On 04/09/2014 03:09 AM, Stephen Boyd wrote: > On 04/03, Stanimir Varbanov wrote: >> +static void qce_ahash_dma_done(void *data) >> +{ >> +struct crypto_async_request *async_req = data; >> +struct ahash_request *req = a

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-14 Thread Stanimir Varbanov
Hi Courtney, On 04/09/2014 01:00 AM, Courtney Cavin wrote: > On Tue, Apr 08, 2014 at 06:26:44PM +0200, Stanimir Varbanov wrote: >> On 04/04/2014 02:38 AM, Courtney Cavin wrote: >>> On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: >>>> This adds co

Re: [PATCH 5/9] crypto: qce: Adds sha and hmac transforms

2014-04-14 Thread Stanimir Varbanov
Hi Stephen, On 04/11/2014 11:12 PM, Stephen Boyd wrote: > On 04/10, Stanimir Varbanov wrote: >> On 04/09/2014 03:09 AM, Stephen Boyd wrote: >>> On 04/03, Stanimir Varbanov wrote: >>> >>>> + >>>> + return 0; >>>> +} >>>>

[RFC PATCH v2 0/9] Add Qualcomm crypto driver

2014-04-14 Thread Stanimir Varbanov
river more readable and easier for review, hope I done well. I'll appreciate any review comments which will help me to make this code clear and ready for mainline kernel. Stanimir Varbanov (9): crypto: qce: Add core driver implementation crypto: qce: Add register defines crypto: qce: Add dma

[RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-14 Thread Stanimir Varbanov
: Stanimir Varbanov --- drivers/crypto/qce/core.c | 295 ++ drivers/crypto/qce/core.h | 73 2 files changed, 368 insertions(+) create mode 100644 drivers/crypto/qce/core.c create mode 100644 drivers/crypto/qce/core.h diff --git a/drivers

[RFC PATCH v2 3/9] crypto: qce: Add dma and sg helpers

2014-04-14 Thread Stanimir Varbanov
This adds dmaengine and sg-list helper functions used by other parts of the crypto driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/dma.c | 188 +++ drivers/crypto/qce/dma.h | 58 +++ 2 files changed, 246 insertions

[RFC PATCH v2 2/9] crypto: qce: Add register defines

2014-04-14 Thread Stanimir Varbanov
Here are all register addresses and bit/masks used by the driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/regs-v5.h | 331 +++ 1 file changed, 331 insertions(+) create mode 100644 drivers/crypto/qce/regs-v5.h diff --git a/drivers/crypto

[RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-14 Thread Stanimir Varbanov
Here is the implementation of AES, DES and 3DES crypto API callbacks, the crypto register alg function, the async request handler and its dma done callback function. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/ablkcipher.c | 403 drivers

[RFC PATCH v2 5/9] crypto: qce: Adds sha and hmac transforms

2014-04-14 Thread Stanimir Varbanov
Here is the implementation and registration of ahash crypto type. It includes sha1, sha256, hmac(sha1) and hmac(sha256). Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/sha.c | 591 +++ drivers/crypto/qce/sha.h | 81 +++ 2 files changed

[RFC PATCH v2 6/9] crypto: qce: Adds infrastructure to setup the crypto block

2014-04-14 Thread Stanimir Varbanov
Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/common.c | 438 drivers/crypto/qce/common.h | 104 +++ 2 files changed, 542 insertions(+) create mode 100644 drivers/crypto/qce/common.c create mode 100644 drivers/crypto/qce/common.h diff

[RFC PATCH v2 7/9] crypto: qce: Adds Makefile to build the driver

2014-04-14 Thread Stanimir Varbanov
Adds Makefile needed to build the driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/Makefile | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 drivers/crypto/qce/Makefile diff --git a/drivers/crypto/qce/Makefile b/drivers/crypto/qce/Makefile new file mode 100644

[RFC PATCH v2 8/9] crypto: qce: Build Qualcomm qce driver

2014-04-14 Thread Stanimir Varbanov
Modify crypto Kconfig and Makefile in order to build the qce driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/Kconfig | 10 ++ drivers/crypto/Makefile | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 03ccdb0ccf9e

[RFC PATCH v2 9/9] ARM: DT: qcom: Add Qualcomm crypto driver binding document

2014-04-14 Thread Stanimir Varbanov
Here is Qualcomm crypto driver device tree binding documentation to be used as a reference example. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/crypto/qcom-qce.txt| 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree

Re: [RFC PATCH v2 0/9] Add Qualcomm crypto driver

2014-04-16 Thread Stanimir Varbanov
/2014 03:48 PM, Stanimir Varbanov wrote: > Hi, > > Here is the second version of the patch set. This time tagged > as an RFC to avoid confusions. The driver is splitted by files > and is buildable at the last patch. When the review has finished > 1/9 to 7/9 could be squashed in o

Re: [PATCH v3 0/4] Support for Qualcomm QPNP PMIC's

2014-07-28 Thread Stanimir Varbanov
Hi all, On 07/24/2014 03:45 PM, Stanimir Varbanov wrote: > Hello all, > > Changes since v2: > - 1/4 - added new line, signed-off-by / acked-by and module_authors. > - 3/4 - the subject has been changed. > > The previous v2 can be found at [1]. > > I'm still

Re: [RFC PATCH v2 1/5] mfd: qpnp: add support for Qualcomm QPNP PMICs

2014-07-14 Thread Stanimir Varbanov
Hi Lee, On 07/11/2014 12:07 PM, Lee Jones wrote: > On Thu, 10 Jul 2014, Stanimir Varbanov wrote: >>>>>> The Qualcomm QPNP PMIC chips are components used with the >>>>>> Snapdragon 800 series SoC family. This driver exists >>>>>> largely as

Re: [RFC PATCH v2 1/5] mfd: qpnp: add support for Qualcomm QPNP PMICs

2014-07-15 Thread Stanimir Varbanov
On 07/14/2014 05:03 PM, Lee Jones wrote: > On Mon, 14 Jul 2014, Stanimir Varbanov wrote: >> On 07/11/2014 12:07 PM, Lee Jones wrote: >>> On Thu, 10 Jul 2014, Stanimir Varbanov wrote: >>>>>>>> The Qualcomm QPNP PMIC chips are components used with the >&g

Re: [RFC PATCH v2 3/5] rtc: add qpnp rtc driver

2014-07-15 Thread Stanimir Varbanov
Hi Bjorn, On 07/10/2014 06:43 PM, Stanimir Varbanov wrote: > On 07/10/2014 04:08 PM, Bjorn Andersson wrote: >> On Thu, Jul 3, 2014 at 6:14 AM, Stanimir Varbanov >> wrote: >> [...] >>> +static const struct of_device_id qpnp_rtc_table[] = { >>>

[RFC PATCH v2 0/5] Support for Qualcomm QPNP PMIC's

2014-07-03 Thread Stanimir Varbanov
PMICs Stanimir Varbanov (3): rtc: add qpnp rtc driver dt: msm8974: add qpnp rtc device node dt: rtc: add binding document for qpnp rtc .../devicetree/bindings/rtc/qcom,rtc-qpnp.txt | 24 + arch/arm/boot/dts/qcom-msm8974.dtsi| 53 +++ drivers/mfd/Kc

[RFC PATCH v2 1/5] mfd: qpnp: add support for Qualcomm QPNP PMICs

2014-07-03 Thread Stanimir Varbanov
-off-by: Stanimir Varbanov --- drivers/mfd/Kconfig | 15 ++ drivers/mfd/Makefile|1 + drivers/mfd/qpnp-spmi.c | 129 +++ 3 files changed, 145 insertions(+), 0 deletions(-) create mode 100644 drivers/mfd/qpnp-spmi.c diff --git a

[RFC PATCH v2 2/5] dt: qcom: msm8974: add qpnp-spmi device nodes

2014-07-03 Thread Stanimir Varbanov
From: Ivan T. Ivanov The qpnp-spmi device nodes are childrens of spmi pmic arbiter. msm8974 SoC using two pmic chips pm8941 and pm8841. Every chip has two spmi-qpnp bus id's. Signed-off-by: Stanimir Varbanov --- arch/arm/boot/dts/qcom-msm8974.dtsi | 45 +

[RFC PATCH v2 3/5] rtc: add qpnp rtc driver

2014-07-03 Thread Stanimir Varbanov
childrens of QPNP SPMI bus. They use regmap to read/write to its registers into PMIC. Signed-off-by: Stanimir Varbanov --- drivers/rtc/Kconfig|8 + drivers/rtc/Makefile |1 + drivers/rtc/rtc-qpnp.c | 489 3 files changed, 498

[RFC PATCH v2 4/5] dt: msm8974: add qpnp rtc device node

2014-07-03 Thread Stanimir Varbanov
Add QPNP RTC device tree node. The RTC device resides into pm8941 and is attached on usid0. Signed-off-by: Stanimir Varbanov --- arch/arm/boot/dts/qcom-msm8974.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm

[RFC PATCH v2 5/5] dt: rtc: add binding document for qpnp rtc

2014-07-03 Thread Stanimir Varbanov
Add devicetree binding document which describes the qpnp-rtc. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/rtc/qcom,rtc-qpnp.txt | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/rtc/qcom,rtc

[PATCH 0/3] Support for Qualcomm QPNP PMIC's

2014-07-08 Thread Stanimir Varbanov
Hello to all, Here is patch set which adds Qualcomm QPNP PMIC's support. I've removed RFC tag and sending as regular set hoping that this time more comments will come out. The link to the RFCv2 at [1]. The first patch in the set implements an *of* based parsing of PMIC peripheral resources and ad

[PATCH 1/3] mfd: qpnp-spmi: add support for Qualcomm QPNP PMICs

2014-07-08 Thread Stanimir Varbanov
From: Josh Cartwright The Qualcomm QPNP PMIC chips are components used with the Snapdragon 800 series SoC family. This driver exists largely as a glue mfd component, it exists to be an owner of an SPMI regmap for children devices described in device tree. Signed-off-by: Stanimir Varbanov

[PATCH 3/3] dt: qcom: msm8974: add qpnp-spmi device nodes

2014-07-08 Thread Stanimir Varbanov
From: Ivan T. Ivanov The qpnp-spmi device nodes are childrens of spmi pmic arbiter. msm8974 SoC using two pmic chips pm8941 and pm8841. Every chip has two spmi-qpnp bus id's. Signed-off-by: Stanimir Varbanov --- arch/arm/boot/dts/qcom-msm8974.dtsi | 45 +

[PATCH 2/3] mfd: qpnp-spmi: document DT bindings for Qualcomm QPNP PMICs

2014-07-08 Thread Stanimir Varbanov
From: Ivan T. Ivanov Document DT bindings used to describe the Qualcomm QPNP PMICs. Signed-off-by: Ivan T. Ivanov Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/qpnp/qcom,qpnp-spmi.txt| 53 1 files changed, 53 insertions(+), 0 deletions(-) create

Re: [RFC PATCH v2 1/5] mfd: qpnp: add support for Qualcomm QPNP PMICs

2014-07-09 Thread Stanimir Varbanov
Hi Lee, Thanks for the comments. On 07/09/2014 05:34 PM, Lee Jones wrote: > On Thu, 03 Jul 2014, Stanimir Varbanov wrote: >> From: Josh Cartwright >> >> The Qualcomm QPNP PMIC chips are components used with the >> Snapdragon 800 series SoC family. This driver exis

Re: [RFC PATCH v2 2/5] dt: qcom: msm8974: add qpnp-spmi device nodes

2014-07-09 Thread Stanimir Varbanov
On 07/09/2014 05:10 PM, Lee Jones wrote: > On Thu, 03 Jul 2014, Stanimir Varbanov wrote: > >> From: Ivan T. Ivanov >> >> The qpnp-spmi device nodes are childrens of spmi pmic arbiter. >> msm8974 SoC using two pmic chips pm8941 and pm8841. Every chip >> has

Re: [RFC PATCH v2 3/5] rtc: add qpnp rtc driver

2014-07-10 Thread Stanimir Varbanov
Hi Stephen, On 07/09/2014 09:07 PM, Stephen Boyd wrote: > On 07/03/14 06:14, Stanimir Varbanov wrote: >> A 32bits RTC is housed inside PMIC. The RTC driver uses QPNP >> SPMI interface to communicate with the PMIC RTC module. >> >> The RTC device is divided into two sub-

Re: [RFC PATCH v2 1/5] mfd: qpnp: add support for Qualcomm QPNP PMICs

2014-07-10 Thread Stanimir Varbanov
of an SPMI regmap for children devices described in >>>> device tree. >>>> >>>> Signed-off-by: Josh Cartwright >>>> Signed-off-by: Stanimir Varbanov >>>> --- >>>> drivers/mfd/Kconfig | 15 ++ >>>> drive

Re: [RFC PATCH v2 3/5] rtc: add qpnp rtc driver

2014-07-10 Thread Stanimir Varbanov
On 07/10/2014 04:08 PM, Bjorn Andersson wrote: > On Thu, Jul 3, 2014 at 6:14 AM, Stanimir Varbanov > wrote: > [...] >> +static const struct of_device_id qpnp_rtc_table[] = { >> + { .compatible = "qcom,qpnp-rtc", }, >> + {} >> +}; >>

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
Hi, > > Signed-off-by: Pramod Gurav > CC: Josh Cartwright > CC: Mark Brown > --- > This was found when I enabled support for Qualcomm QPNP PMICs and was > compiling it. It selects REGMAP_SPMI and hence the crash. > > drivers/base/regmap/Kconfig |1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
>>> >>> config REGMAP_SPMI >>> + select SPMI >> >> NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and >> multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example. >> > > I am using multi_v7_defconfig but its not enabling it. I ran qcom_defconfig > which does. yes, it seems

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
> > Thanks. > I misunderstood the Kconfig documentation which says, "Reverse dependencies > can only be used with boolean or tristate symbols". In the note following > this statement doc says, "In general use select only for non-visible symbols". > > The CONFIG_SPMI option is visible in menuc

[PATCH 0/2] crypto: qce: fix few sparse warnings

2014-07-04 Thread Stanimir Varbanov
Hi Herbert, Here are sparse fixes for Qualcomm crypto driver reported here [1]. The patches are based on cryptodev-2.6 tree. regards, Stan [1] https://lists.01.org/pipermail/kbuild-all/2014-July/005429.html Stanimir Varbanov (2): crypto: qce: fix sparse warnings crypto: qce: add dependancy

[PATCH 2/2] crypto: qce: add dependancy to Kconfig

2014-07-04 Thread Stanimir Varbanov
Make qce crypto driver depend on ARCH_QCOM and make possible to test driver compilation. Signed-off-by: Stanimir Varbanov --- drivers/crypto/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 3e5186e..5ef9ec9

[PATCH 1/2] crypto: qce: fix sparse warnings

2014-07-04 Thread Stanimir Varbanov
Fix few sparse warnings of type: - sparse: incorrect type in argument - sparse: incorrect type in initializer Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/common.c | 15 +-- drivers/crypto/qce/common.h |2 +- drivers/crypto/qce/sha.c| 20

Re: [PATCH v2 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs

2014-07-22 Thread Stanimir Varbanov
On 07/22/2014 02:03 PM, Lee Jones wrote: > On Thu, 17 Jul 2014, Stanimir Varbanov wrote: > >> From: Josh Cartwright >> >> The Qualcomm SPMI PMIC chips are components used with the >> Snapdragon 800 series SoC family. This driver exists >> largely as a gl

Re: [PATCH v2 4/4] mfd: pm8921: rename pm8921-core driver

2014-07-22 Thread Stanimir Varbanov
On 07/22/2014 01:32 PM, Lee Jones wrote: > On Thu, 17 Jul 2014, Stanimir Varbanov wrote: > >> The pm8921-core driver presently supports pm8921 and pm8058 >> Qualcomm PMICs. To avoid confusion with new generation PMICs >> (like pm8941) rename the pm8921-core driver to

[PATCH v3 2/4] mfd: pm8xxx-spmi: document DT bindings for Qualcomm SPMI PMICs

2014-07-24 Thread Stanimir Varbanov
Document DT bindings used to describe the Qualcomm SPMI PMICs. Currently the SPMI PMICs supported are pm8941, pm8841 and pma8084. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/mfd/qcom,pm8xxx-spmi.txt | 49 1 files changed, 49 insertions(+), 0 deletions

[PATCH v3 0/4] Support for Qualcomm QPNP PMIC's

2014-07-24 Thread Stanimir Varbanov
efine internally the SPMI base addresses depending on the compatible property i.e. PMIC version. Comments are welcome! [1] https://lkml.org/lkml/2014/7/8/428 Josh Cartwright (1): mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs Stanimir Varbanov (3): mfd: pm8xxx-spmi: document DT bin

[PATCH v3 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs

2014-07-24 Thread Stanimir Varbanov
-off-by: Stanimir Varbanov Acked-by: Lee Jones --- drivers/mfd/Kconfig | 16 +++ drivers/mfd/Makefile |1 + drivers/mfd/pm8xxx-spmi.c | 65 + 3 files changed, 82 insertions(+), 0 deletions(-) create mode 100644 drivers/mfd

[PATCH v3 3/4] ARM: dts: qcom: add pm8941 and pm8841 PMICs device nodes

2014-07-24 Thread Stanimir Varbanov
The pm8941 and pm8841 spmi devicetree nodes are childrens of spmi pmic arbiter. The msm8974 SoC uses two PMIC chips pm8941 and pm8841. Every PMIC chip has two spmi bus slave id's. Signed-off-by: Stanimir Varbanov --- arch/arm/boot/dts/qcom-msm8974.dtsi |

[PATCH v3 4/4] mfd: pm8921: rename pm8921-core driver

2014-07-24 Thread Stanimir Varbanov
The pm8921-core driver presently supports pm8921 and pm8058 Qualcomm PMICs. To avoid confusion with new generation PMICs (like pm8941) rename the pm8921-core driver to more appropriate name pm8xxx-ssbi, which reflects better that those chips use SSBI interface. Signed-off-by: Stanimir Varbanov

[PATCH v3 0/3] Add Qualcomm crypto driver

2014-06-09 Thread Stanimir Varbanov
long - move blocksize boundary check on function begging and clear BYTECOUNT registers on first processing block This driver is based on Codeaurora's driver found at [1] [1] https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/crypto/msm?h=msm-3.10 Stanimir Varban

[PATCH v3 2/3] crypto: qce: Build Qualcomm crypto driver

2014-06-09 Thread Stanimir Varbanov
Modify crypto Kconfig and Makefile in order to build the qce driver and adds qce Makefile as well. Signed-off-by: Stanimir Varbanov --- drivers/crypto/Kconfig | 15 +++ drivers/crypto/Makefile |1 + drivers/crypto/qce/Makefile |6 ++ 3 files changed, 22

[PATCH v3 3/3] ARM: DT: qcom: Add Qualcomm crypto driver binding document

2014-06-09 Thread Stanimir Varbanov
Here is Qualcomm crypto driver device tree binding documentation to used as a reference example. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/crypto/qcom-qce.txt| 25 1 files changed, 25 insertions(+), 0 deletions(-) create mode 100644

Re: [PATCH v3 1/3] crypto: qce: Qualcomm crypto engine driver

2014-06-10 Thread Stanimir Varbanov
Hi Joe, On 06/09/2014 07:46 PM, Joe Perches wrote: > On Mon, 2014-06-09 at 15:08 +0300, Stanimir Varbanov wrote: >> The driver is separated by functional parts. The core part >> implements a platform driver probe and remove callbaks. >> The probe enables clocks, checks crypt

Re: [PATCH 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver

2014-06-13 Thread Stanimir Varbanov
Hi Kumar, > + > +static struct platform_driver qcom_ahci_driver = { > + .probe = qcom_ahci_probe, > + .remove = ata_platform_remove_one, > + .driver = { > + .name = "qcom_ahci_qcom", > + .owner = THIS_MODULE, > + .of_match_table = qcom_ahci_of_match,

Re: [PATCH 0/3] Qualcomm Resource Power Manager driver

2014-06-02 Thread Stanimir Varbanov
Hi Bjorn, Thanks for the patches. > Lately I've been working on rpm, rpm-smd, smem, smd, smsm, smp2p > patches for mainline. > It could be argued that smd is a bus and should go in drivers/bus, but > for the rest I fear that we just created drivers/soc/qcom as another > dumping ground for thing

[PATCH v4 0/3] Add Qualcomm crypto driver

2014-06-25 Thread Stanimir Varbanov
This driver is based on Codeaurora's driver found at [1] [1] https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/crypto/msm?h=msm-3.10 Stanimir Varbanov (3): crypto: qce: Qualcomm crypto engine driver crypto: qce: Build Qualcomm crypto driver ARM: DT: qcom: Add Qua

[PATCH v4 2/3] crypto: qce: Build Qualcomm crypto driver

2014-06-25 Thread Stanimir Varbanov
Modify crypto Kconfig and Makefile in order to build the qce driver and adds qce Makefile as well. Signed-off-by: Stanimir Varbanov --- drivers/crypto/Kconfig | 15 +++ drivers/crypto/Makefile |1 + drivers/crypto/qce/Makefile |6 ++ 3 files changed, 22

[PATCH v4 3/3] ARM: DT: qcom: Add Qualcomm crypto driver binding document

2014-06-25 Thread Stanimir Varbanov
Here is Qualcomm crypto driver device tree binding documentation to used as a reference example. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/crypto/qcom-qce.txt| 25 1 files changed, 25 insertions(+), 0 deletions(-) create mode 100644

Re: [PATCH v3 1/2] ARM: DT: msm: Add Qualcomm's PRNG driver binding document

2013-10-23 Thread Stanimir Varbanov
On 10/15/2013 05:11 PM, Stanimir Varbanov wrote: > This adds Qualcomm PRNG driver device tree binding documentation > to use as an example in dts trees. > > Signed-off-by: Stanimir Varbanov Dear DT binding maintainers, I'd like to receive some comments or maybe an Ack to this

Re: [PATCH v3 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-23 Thread Stanimir Varbanov
On 10/15/2013 05:11 PM, Stanimir Varbanov wrote: > This adds a driver for hardware random number generator present > on Qualcomm MSM SoC's. > > Signed-off-by: Stanimir Varbanov Hi Matt, Herbert, Sorry for the noise but this patch staying for a while in mailing list and I&#

Re: [PATCH v3 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-25 Thread Stanimir Varbanov
Hi Herbert, On 10/23/2013 12:45 PM, Herbert Xu wrote: > On Wed, Oct 23, 2013 at 12:41:10PM +0300, Stanimir Varbanov wrote: >> On 10/15/2013 05:11 PM, Stanimir Varbanov wrote: >>> This adds a driver for hardware random number generator present >>> on Qualcomm MSM S

<    1   2   3   4   5   6   7   8   9   10   >