[PATCH v6 5/5] venus: venc: Add support for CLL and Mastering display controls

2021-03-23 Thread Stanimir Varbanov
Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

[PATCH v6 1/5] v4l: Add new Colorimetry Class

2021-03-23 Thread Stanimir Varbanov
Add Colorimetry control class for colorimetry controls Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++- include/uapi/linux/v4l2-controls.h | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b

[PATCH v6 0/5] HDR10 static metadata

2021-03-23 Thread Stanimir Varbanov
Hello, Changes since v5: * added Reviewed-by tags * 3/5 - added a comment (Hans) * 4/5 - drop "coded" word in documentation (Hans) regards, Stan Stanimir Varbanov (5): v4l: Add new Colorimetry Class docs: Document colorimetry class v4l: Add HDR10 static metadata contr

[PATCH] v4l2-ctrls: Fix h264 hierarchical coding type menu ctrl

2021-03-02 Thread Stanimir Varbanov
Add a name of the menu and fill control type. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 016cf6204cbb..5d99e2294335

Re: [PATCH v5 3/5] v4l: Add HDR10 static metadata controls

2021-03-22 Thread Stanimir Varbanov
Hi Hans, On 3/16/21 2:16 PM, Hans Verkuil wrote: > On 09/02/2021 17:24, Stanimir Varbanov wrote: >> Introduce Content light level and Mastering display colour >> volume Colorimetry compound controls with relevant payload >> structures and validation. >> >>

Re: [PATCH v2 0/2] Add decoder conceal color ctrl

2021-03-16 Thread Stanimir Varbanov
Hans, any comments ? On 3/2/21 1:44 PM, Stanimir Varbanov wrote: > Hi, > > The changes in v2 includes: > * reformat the table in documetation to define Bits for different >bit-depths of color formats. > > regards, > Stan > > Stanimir Varbanov (2): > v4l

Re: [PATCH v5 0/5] HDR10 static metadata

2021-03-16 Thread Stanimir Varbanov
Hans, any comments? On 2/9/21 6:24 PM, Stanimir Varbanov wrote: > Changes since v4: > * 1/5 - fixed a typo (Hans) > * 2/5 - add some mode info about new colorimetry class (Hans) > * 4/5 - correct cd/m2 -> cd/m\ :sup:`2` > - change to US spelling for color wo

Re: [PATCH v3 0/2] Intra-refresh period control

2021-04-13 Thread Stanimir Varbanov
Hi Hans, Any comments? On 3/2/21 11:53 AM, Stanimir Varbanov wrote: > Hi, > > This series add a new intra-refresh period control for encoders. The > series is a continuation of [1]. Comments addressed: > * A typo in .rst (Hans) > * Clarified the relationship with CYCLIC_INTR

[PATCH] venus: core: Fix kerneldoc warnings

2021-04-07 Thread Stanimir Varbanov
Fix kerneldoc warnings in description of venus_core and venus_inst structures Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 40 ++-- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.h b

[PATCH] venus: core: Fix a warning in register offsets

2021-04-07 Thread Stanimir Varbanov
Fix the following sparse warnings: core.c:227:41: warning: Using plain integer as NULL pointer core.c:228:34: warning: Using plain integer as NULL pointer Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH] venus: hfi_venus: Fix a warning in venus ISR

2021-04-07 Thread Stanimir Varbanov
Fix the following smatch warning: hfi_venus.c:1100 venus_isr() warn: variable dereferenced before check 'hdev' (see line 1097) Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] media: venus: use NULL instead of zero for pointers

2021-04-09 Thread Stanimir Varbanov
++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Stanimir Varbanov > > diff --git a/drivers/media/platform/qcom/venus/core.c > b/drivers/media/platform/qcom/venus/core.c > index f5b88b96f5f7..4451e3c11bc0 100644 > --- a/drivers/media/platform/qcom/venus/core.c

Re: [PATCH 3/3] media: venus: don't de-reference NULL pointers at IRQ time

2021-04-09 Thread Stanimir Varbanov
auro Carvalho Chehab > --- > drivers/media/platform/qcom/venus/hfi_venus.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Acked-by: Stanimir Varbanov > > diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c > b/drivers/media/platform/qcom/venus/

[PATCH 0/3] Venus encoder improvements

2020-11-19 Thread Stanimir Varbanov
are welcome! regards, Stan Stanimir Varbanov (2): venus: venc: Init the session only once in queue_setup venus: Limit HFI sessions to the maximum supported Vikash Garodia (1): media: hfi_venus: Request interrupt for sync cmds drivers/media/platform/qcom/venus/core.h | 1 + drivers

[PATCH 1/3] venus: venc: Init the session only once in queue_setup

2020-11-19 Thread Stanimir Varbanov
Init the hfi session only once in queue_setup and also cover that with inst->lock. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/venc.c | 98 ++-- 1 file changed, 73 insertions(+), 25 deletions(-) diff --git a/drivers/media/platform/qcom/ve

[PATCH 3/3] media: hfi_venus: Request interrupt for sync cmds

2020-11-19 Thread Stanimir Varbanov
From: Vikash Garodia For synchronous commands, update the message queue variable. This would inform video firmware to raise interrupt on host CPU whenever there is a response for such commands. Signed-off-by: Vikash Garodia Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom

[PATCH 2/3] venus: Limit HFI sessions to the maximum supported

2020-11-19 Thread Stanimir Varbanov
error when we reach maximum count of sessions and thus refuse open. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/hfi.c | 19 +++ .../media/platform/qcom/venus/hfi_parser.c| 3 +++ 3 files

[PATCH 0/4] Add random IR and AUD encoder controls

2020-11-30 Thread Stanimir Varbanov
Hi, Here we introduce two new v4l2 controls for encoders: * V4L2_CID_MPEG_VIDEO_RANDOM_INTRA_REFRESH_MB * V4L2_CID_MPEG_VIDEO_AU_DELIMITER The patchset also includes implementation in Venus driver. Comments are welcome! regards, Stan Stanimir Varbanov (4): media: v4l2-ctrls: Add random

[PATCH 3/4] media: v4l2-ctrls: Add control for AUD generation

2020-11-30 Thread Stanimir Varbanov
Add a control to enable inserting of AUD NALU into encoded bitstream. Signed-off-by: Stanimir Varbanov --- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 5 + drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2-controls.h

[PATCH 2/4] venus: venc: Add support for intra-refresh modes

2020-11-30 Thread Stanimir Varbanov
Add support for random intra-refresh mode and number of macroblocks. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/platform/qcom/venus/venc.c | 12 drivers/media/platform/qcom/venus/venc_ctrls.c | 10 +- 3

[PATCH 4/4] venus: venc: Add support for AUD NALU control

2020-11-30 Thread Stanimir Varbanov
Add support for Access Unit Delimiter control into encoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 14 ++ drivers/media/platform/qcom/venus/venc_ctrls.c | 8 +++- 3 files

[PATCH 1/4] media: v4l2-ctrls: Add random intra-refresh control

2020-11-30 Thread Stanimir Varbanov
Add a control to configure number of macroblocks for random intra-refresh mode. Signed-off-by: Stanimir Varbanov --- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 6 ++ drivers/media/v4l2-core/v4l2-ctrls.c | 1 + include/uapi/linux/v4l2-controls.h

Re: [PATCH] venus: core: add support to dump FW region

2020-11-30 Thread Stanimir Varbanov
On 11/30/20 7:36 AM, Dikshita Agarwal wrote: > Add support to dump video FW region during FW crash > using devcoredump helpers. > > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/venus/core.c | 47 > > 1 file changed, 47 insertions(+) >

Re: [PATCH 15/17] arm64: dts: sdm845: Add interconnect properties for Venus

2020-11-30 Thread Stanimir Varbanov
Bjorn, could you take this for v5.11. On 11/2/20 2:07 PM, Georgi Djakov wrote: > Hi Stan, > > On 11/2/20 13:35, Stanimir Varbanov wrote: >> Populate Venus DT node with interconnect properties. >> >> Signed-off-by: Stanimir Varbanov > > Reviewed-by: Geo

[PATCH v2 0/3] HDR10 static metadata

2020-11-23 Thread Stanimir Varbanov
. What you think? Comments are welcome! regards, Stan Stanimir Varbanov (3): v4l: Add HDR10 static metadata controls docs: media: Document CLL and Mastering display venus: venc: Add support for CLL and Mastering display controls .../media/v4l/ext-ctrls-codec.rst | 71

[PATCH v2 3/3] venus: venc: Add support for CLL and Mastering display controls

2020-11-23 Thread Stanimir Varbanov
Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 3 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

[PATCH v2 1/3] v4l: Add HDR10 static metadata controls

2020-11-23 Thread Stanimir Varbanov
Add Content light level and Mastering display colour volume v4l2 compounf controls, relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 62 include/media/hdr10-ctrls.h | 55

[PATCH v2 2/3] docs: media: Document CLL and Mastering display

2020-11-23 Thread Stanimir Varbanov
Document Content light level and Mastering display colour volume. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-codec.rst | 71 +++ 1 file changed, 71 insertions(+) diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b

[PATCH v2 1/4] venus: venc: Init the session only once in queue_setup

2020-12-04 Thread Stanimir Varbanov
Init the hfi session only once in queue_setup and also cover that with inst->lock. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/venc.c | 85 ++-- 1 file changed, 64 insertions(+), 21 deletions(-) diff --git a/drivers/media/platform/qcom/ve

[PATCH v2 0/4] Venus encoder improvements

2020-12-04 Thread Stanimir Varbanov
triggering soft interrupt (Alex) * Add one more patch 4/4 to address comments for hfi_session_init EINVAL return error code (Alex) The v1 can be found at [1]. regards, Stan [1] https://www.spinics.net/lists/linux-media/msg181634.html Stanimir Varbanov (3): venus: venc: Init the session

[PATCH v2 3/4] media: venus: request for interrupt from venus

2020-12-04 Thread Stanimir Varbanov
From: Vikash Garodia For synchronous commands, update the message queue variable. This would inform video firmware to raise interrupt on host CPU whenever there is a response for such commands. Signed-off-by: Vikash Garodia Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom

[PATCH v2 2/4] venus: Limit HFI sessions to the maximum supported

2020-12-04 Thread Stanimir Varbanov
error when we reach maximum count of sessions and thus refuse open. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/hfi.c| 16 +--- drivers/media/platform/qcom/venus/hfi_parser.c | 3 +++ 3 files

[PATCH v2 4/4] venus: hfi: Correct session init return error

2020-12-04 Thread Stanimir Varbanov
The hfi_session_init can be called many times and it returns EINVAL when the session was already initialized. This error code (EINVAL) is confusing for the callers. Change hfi_session_init to return EALREADY error code when the session has been already initialized. Signed-off-by: Stanimir

Re: [PATCH 1/4] v4l2-ctrl: Make display delay and display enable std controls

2020-12-04 Thread Stanimir Varbanov
On 12/2/20 4:09 PM, Hans Verkuil wrote: > On 09/11/2020 18:35, Stanimir Varbanov wrote: >> Make display delay and display delay enable MFC controls standard v4l >> controls. This will allow reuse of the controls for other decoder >> drivers. Also the new proposed controls a

[PATCH v2 1/4] media: v4l2-ctrls: Add intra-refresh period control

2020-12-06 Thread Stanimir Varbanov
Add a control to set intra-refresh period. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/ext-ctrls-codec.rst | 11 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2-controls.h| 1 + 3 files changed

[PATCH v2 2/4] venus: venc: Add support for intra-refresh period

2020-12-06 Thread Stanimir Varbanov
Add support for intra-refresh period v4l2 control. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 28 +++ .../media/platform/qcom/venus/venc_ctrls.c| 9 +- 3 files changed, 37

[PATCH v2 0/4] Add random IR and AUD encoder controls

2020-12-06 Thread Stanimir Varbanov
Hi, The changes in the second version of the series are: * change the sematics of the random intra-refresh control to intra-refresh period, see 1/1 for more info. * incorporate review comments for AUD NALU control (Hans) regards, Stan Stanimir Varbanov (4): media: v4l2-ctrls: Add intra

[PATCH v2 4/4] venus: venc: Add support for AUD NALU control

2020-12-06 Thread Stanimir Varbanov
Add support for Access Unit Delimiter control into encoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 14 ++ drivers/media/platform/qcom/venus/venc_ctrls.c | 8 +++- 3 files

[PATCH v2 3/4] media: v4l2-ctrls: Add control for AUD generation

2020-12-06 Thread Stanimir Varbanov
Add a control to enable inserting of AUD NALU into encoded bitstream. Signed-off-by: Stanimir Varbanov --- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 5 + drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2-controls.h

Re: [PATCH 2/3] venus: Limit HFI sessions to the maximum supported

2020-11-25 Thread Stanimir Varbanov
On 11/25/20 5:46 AM, Alexandre Courbot wrote: > On Fri, Nov 20, 2020 at 9:12 AM Stanimir Varbanov > wrote: >> >> Currently we rely on firmware to return error when we reach the maximum >> supported number of sessions. But this errors are happened at reqbuf >>

Re: [PATCH 3/3] media: hfi_venus: Request interrupt for sync cmds

2020-11-25 Thread Stanimir Varbanov
On 11/25/20 10:08 AM, Alexandre Courbot wrote: > On Fri, Nov 20, 2020 at 9:12 AM Stanimir Varbanov > wrote: >> >> From: Vikash Garodia >> >> For synchronous commands, update the message queue variable. >> This would inform video firmware to raise interrup

Re: [PATCH] media: venus: preserve DRC state across seeks

2020-12-17 Thread Stanimir Varbanov
Hi Alex, On 12/2/20 7:34 AM, Alexandre Courbot wrote: > DRC events can happen virtually at anytime, including when we are > starting a seek. Should this happen, we must make sure to return to the > DRC state, otherwise the firmware will expect buffers of the new > resolution whereas userspace wil

[PATCH v2 1/5] venus: vdec: Fix non reliable setting of LAST flag

2020-12-20 Thread Stanimir Varbanov
. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 5 +-- drivers/media/platform/qcom/venus/helpers.c | 6 +++ drivers/media/platform/qcom/venus/vdec.c| 45 - 3 files changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/media

[PATCH v2 0/5] Venus dynamic resolution change fixes

2020-12-20 Thread Stanimir Varbanov
regards, Stan Alexandre Courbot (1): media: venus: preserve DRC state across seeks Fritz Koenig (1): venus: vdec: Handle DRC after drain Stanimir Varbanov (3): venus: vdec: Fix non reliable setting of LAST flag venus: vdec: Make decoder return LAST flag for sufficient event venus

[PATCH v2 4/5] media: venus: preserve DRC state across seeks

2020-12-20 Thread Stanimir Varbanov
. Returning to the DRC state upon resume for seeking makes sure that the client will get the DRC event and will reallocate the buffers to fit the firmware's expectations. Signed-off-by: Alexandre Courbot Signed-off-by: Stanimir Varbanov --- No changes since v1. drivers/media/platform/qcom/

[PATCH v2 5/5] venus: vdec: Handle DRC after drain

2020-12-20 Thread Stanimir Varbanov
: Fritz Koenig Signed-off-by: Stanimir Varbanov --- Changes since v2 (from Fritz): - moved state transition from vdec_event_notify to vdec_event_change. drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/vdec.c | 14 -- 2 files changed, 13 insertions

[PATCH v2 3/5] venus: helpers: Lock outside of buffer queue helper

2020-12-20 Thread Stanimir Varbanov
After adding more logic in vdec buf_queue vb2 op it is not practical to have two lock/unlock for one decoder buf_queue. So move the instance lock in encoder and decoder vb2 buf_queue operations. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 11

[PATCH v2 2/5] venus: vdec: Make decoder return LAST flag for sufficient event

2020-12-20 Thread Stanimir Varbanov
This makes the decoder to behaives equally for sufficient and insufficient events. After this change the LAST buffer flag will be set when the new resolution (in dynamic-resolution-change state) is smaller then the old bitstream resolution. Signed-off-by: Stanimir Varbanov --- drivers/media

Re: [PATCH v2] venus: vdec: Handle DRC after drain

2020-12-01 Thread Stanimir Varbanov
Hi Fritz, On 12/1/20 6:23 AM, Fritz Koenig wrote: > If the DRC is near the end of the stream the client > may send a V4L2_DEC_CMD_STOP before the DRC occurs. > V4L2_DEC_CMD_STOP puts the driver into the > VENUS_DEC_STATE_DRAIN state. DRC must be aware so > that after the DRC event the state can b

Re: [PATCH] media: venus: preserve DRC state across seeks

2020-12-02 Thread Stanimir Varbanov
Hi, On 12/2/20 12:24 PM, Alexandre Courbot wrote: > On Wed, Dec 2, 2020 at 2:34 PM Alexandre Courbot > wrote: >> >> DRC events can happen virtually at anytime, including when we are >> starting a seek. Should this happen, we must make sure to return to the >> DRC state, otherwise the firmware wi

Re: [PATCH 1/4] media: v4l2-ctrls: Add random intra-refresh control

2020-12-02 Thread Stanimir Varbanov
Hi, On 11/30/20 11:08 AM, Stanimir Varbanov wrote: > Add a control to configure number of macroblocks for random > intra-refresh mode. > > Signed-off-by: Stanimir Varbanov > --- > Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 6 ++ > drivers/media/v

Re: [PATCH] media: venus: use contig vb2 ops

2021-03-01 Thread Stanimir Varbanov
On 3/1/21 11:23 AM, Tomasz Figa wrote: > Hi Alex, Stanimir, > > On Wed, Dec 16, 2020 at 12:15 PM Tomasz Figa wrote: >> >> On Wed, Dec 16, 2020 at 4:21 AM Nicolas Dufresne >> wrote: >>> >>> Le mardi 15 décembre 2020 à 15:54 +0200, Stanimir Varba

[PATCH v4 1/5] v4l: Add new Colorimetry Class

2021-01-20 Thread Stanimir Varbanov
Add Colorimetry control class for colorimetry controls Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 5 + include/uapi/linux/v4l2-controls.h | 4 2 files changed, 9 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2

[PATCH v4 2/5] docs: Document colorimetry class

2021-01-20 Thread Stanimir Varbanov
Add a document for ext control colorimetry class. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/common.rst| 1 + .../media/v4l/ext-ctrls-colorimetry.rst | 19 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 4 3 files changed, 24

[PATCH v4 5/5] venus: venc: Add support for CLL and Mastering display controls

2021-01-20 Thread Stanimir Varbanov
Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

[PATCH v4 3/5] v4l: Add HDR10 static metadata controls

2021-01-20 Thread Stanimir Varbanov
Introduce Content light level and Mastering display colour volume Colorimetry compound controls with relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 67 include/media/v4l2-ctrls.h | 4

[PATCH v4 0/5] HDR10 static metadata

2021-01-20 Thread Stanimir Varbanov
Hello, Changes in v4: * reorder and split patches (Hans) * fixed typos in documentation patches (Hans) v3 can be found at [1]. regards, Stan [1] https://patchwork.linuxtv.org/project/linux-media/cover/20201208145931.6187-1-stanimir.varba...@linaro.org/ Stanimir Varbanov (5): v4l: Add

[PATCH v4 4/5] docs: Document CLL and Mastering display colorimetry controls

2021-01-20 Thread Stanimir Varbanov
Document Content Light Level and Mastering Display v4l2 colorimetry controls. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-colorimetry.rst | 71 +++ .../media/videodev2.h.rst.exceptions | 2 + 2 files changed, 73 insertions(+) diff --git a

[PATCH v3 0/2] Intra-refresh period control

2021-03-02 Thread Stanimir Varbanov
-media/msg183019.html Stanimir Varbanov (2): media: v4l2-ctrls: Add intra-refresh period control venus: venc: Add support for intra-refresh period .../media/v4l/ext-ctrls-codec.rst | 12 drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus

[PATCH v3 1/2] media: v4l2-ctrls: Add intra-refresh period control

2021-03-02 Thread Stanimir Varbanov
Add a control to set intra-refresh period. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/ext-ctrls-codec.rst | 12 drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2-controls.h | 1 + 3 files changed, 15

[PATCH v3 2/2] venus: venc: Add support for intra-refresh period

2021-03-02 Thread Stanimir Varbanov
Add support for intra-refresh period v4l2 control and drop cyclic intra-refresh macroblock control in the same time. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 28 +++ .../media

[PATCH v2 1/2] v4l2-ctrl: Add decoder conceal color control

2021-03-02 Thread Stanimir Varbanov
Add decoder v4l2 control to set conceal color. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-codec.rst | 33 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 9 + include/uapi/linux/v4l2-controls.h| 1 + 3 files changed, 43

[PATCH v2 0/2] Add decoder conceal color ctrl

2021-03-02 Thread Stanimir Varbanov
Hi, The changes in v2 includes: * reformat the table in documetation to define Bits for different bit-depths of color formats. regards, Stan Stanimir Varbanov (2): v4l2-ctrl: Add decoder conceal color control venus: vdec: Add support for conceal control .../media/v4l/ext-ctrls

[PATCH v2 2/2] venus: vdec: Add support for conceal control

2021-03-02 Thread Stanimir Varbanov
Adds support for decoder conceal color control. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/hfi_cmds.c | 18 -- drivers/media/platform/qcom/venus/hfi_helper.h | 10 ++ drivers/media

[PATCH 0/5] Venus msm8916 fixes

2021-03-08 Thread Stanimir Varbanov
Hello, Here are few fixes for msm8916 (Venus v1x): * Two fixes in hfi_parser * One fix related to opp_set_clk_rate * Default header-mode for encoder is changed to join-with-1st-frame * Added support for actual-plane-info for v1x too regards, Stan Stanimir Varbanov (5): venus: hfi_parser

[PATCH 1/5] venus: hfi_parser: Don't initialize parser on v1

2021-03-08 Thread Stanimir Varbanov
venus: parser: Prepare parser for multiple invocations") Cc: sta...@vger.kernel.org # v5.10+ Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_parser.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_parser.

[PATCH 3/5] venus: pm_helpers: Set opp clock name for v1

2021-03-08 Thread Stanimir Varbanov
ned-off-by: Stanimir Varbanov --- .../media/platform/qcom/venus/pm_helpers.c| 20 ++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c index 43c4e3d9e281..12f6d3ab89ff 10

[PATCH 4/5] venus: venc_ctrls: Change default header mode

2021-03-08 Thread Stanimir Varbanov
It is observed that on Venus v1 the default header-mode is producing a bitstream which is not playble. Change the default header-mode to joined with 1st frame. Fixes: 002c22bd360e ("media: venus: venc: set inband mode property to FW.") Cc: sta...@vger.kernel.org # v5.12+ Signed-off-by

[PATCH 2/5] venus: hfi_parser: Check for instance after hfi platform get

2021-03-08 Thread Stanimir Varbanov
;) Cc: sta...@vger.kernel.org # v5.12+ Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_parser.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media/platform/qcom/venus/hfi_parser.c index ce

[PATCH 5/5] venus: hfi_cmds: Support plane-actual-info property from v1

2021-03-08 Thread Stanimir Varbanov
The property is supported from v1 and upwards. So move it to set_property_1x. Fixes: 01e869e78756 ("media: venus: venc: fix handlig of S_SELECTION and G_SELECTION") Cc: sta...@vger.kernel.org # v5.12+ Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_c

Re: [PATCH v2 0/4] MFC private ctrls to std ctrls

2021-01-26 Thread Stanimir Varbanov
Hans, any comments ? On 1/15/21 11:26 AM, Stanimir Varbanov wrote: > Hello, > > Changes in v2: > > * use _DEC_ instead of _DECODER_ in the name of the new controls (Hans) > * rebase on top of media master branch > > v1 can be found at [1] > > reg

Re: [PATCH v2 3/9] clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver

2021-01-26 Thread Stanimir Varbanov
On 1/13/21 8:38 PM, AngeloGioacchino Del Regno wrote: > From: Martin Botka > > Add a driver for the multimedia clock controller found on SDM660 > based devices. This should allow most multimedia device drivers > to probe and control their clocks. > > Signed-off-by: Martin Botka > Co-develope

[PATCH] venus: core: Parse firmware-name DT property

2021-01-26 Thread Stanimir Varbanov
predefined path from driver resource structure. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/firmware.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c

Re: [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct

2021-01-26 Thread Stanimir Varbanov
On 1/25/21 5:01 PM, Hans Verkuil wrote: > On 25/01/2021 15:51, AngeloGioacchino Del Regno wrote: >> Il 25/01/21 11:40, Hans Verkuil ha scritto: >>> On 18/01/2021 18:45, AngeloGioacchino Del Regno wrote: >>>> Il 18/01/21 18:21, Stanimir Varbanov ha scritto: >&

Re: [PATCH v2 1/4] media: v4l2-ctrls: Add intra-refresh period control

2021-01-18 Thread Stanimir Varbanov
On 1/12/21 12:05 PM, Hans Verkuil wrote: > On 06/12/2020 11:27, Stanimir Varbanov wrote: >> Add a control to set intra-refresh period. >> >> Signed-off-by: Stanimir Varbanov >> --- >> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 11 +++

Re: [PATCH v2 7/8] venus: venc: Handle reset encoder state

2021-01-07 Thread Stanimir Varbanov
art_streaming| substantially. This patch > implements |venc_stop_streaming|, but maybe that is not needed with > the newer patch? Can this one just be dropped, or does it need > rework? > > -Fritz > > [1]: https://lore.kernel.org/patchwork/patch/1349416/ > &

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Stanimir Varbanov
Hi Tomasz, On 12/15/20 1:47 PM, Tomasz Figa wrote: > On Tue, Dec 15, 2020 at 8:16 PM Stanimir Varbanov > wrote: >> >> Hi, >> >> Cc: Robin >> >> On 12/14/20 2:57 PM, Alexandre Courbot wrote: >>> This driver uses the SG vb2 ops, but effective

Re: [PATCH v4] venus: core: add support to dump FW region

2020-12-14 Thread Stanimir Varbanov
ia/platform/qcom/venus/firmware.c > @@ -201,6 +201,9 @@ int venus_boot(struct venus_core *core) > return -EINVAL; > } > > + core->fw.mem_size = mem_size; > + core->fw.mem_phys = mem_phys; > + > if (core->use_tz) > ret = qcom_scm_pas_auth_and_reset(VENUS_PAS_ID); > else > With those fixes: Reviewed-by: Stanimir Varbanov -- regards, Stan

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Stanimir Varbanov
Hi, Cc: Robin On 12/14/20 2:57 PM, Alexandre Courbot wrote: > This driver uses the SG vb2 ops, but effectively only ever accesses the > first entry of the SG table, indicating that it expects a flat layout. > Switch it to use the contiguous ops to make sure this expected invariant Under what cir

Re: [PATCH 2/3] venus: Limit HFI sessions to the maximum supported

2020-11-26 Thread Stanimir Varbanov
On 11/26/20 8:28 AM, Alexandre Courbot wrote: > On Wed, Nov 25, 2020 at 10:01 PM Stanimir Varbanov > wrote: >> >> >> >> On 11/25/20 5:46 AM, Alexandre Courbot wrote: >>> On Fri, Nov 20, 2020 at 9:12 AM Stanimir Varbanov >>> wrote: >>>

Re: [PATCH 1/3] venus: venc: Init the session only once in queue_setup

2020-11-26 Thread Stanimir Varbanov
On 11/25/20 5:13 AM, Alexandre Courbot wrote: > Hi Stan, > > On Fri, Nov 20, 2020 at 9:12 AM Stanimir Varbanov > wrote: >> >> Init the hfi session only once in queue_setup and also cover that >> with inst->lock. >> >> Signed-off-by: Stanimir Var

Re: [PATCH v2 4/8] venus: helpers: Calculate properly compressed buffer size

2020-11-29 Thread Stanimir Varbanov
On 11/29/20 8:07 AM, Fritz Koenig wrote: > On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov > wrote: >> >> For resolutions below 720p the size of the compressed buffer must >> be bigger. Correct this by checking the resolution when calculating >> buffer size

Re: [PATCH v2 0/8] Venus stateful encoder compliance

2020-11-29 Thread Stanimir Varbanov
ry_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd, > made an attempt at that here: > https://www.spinics.net/lists/linux-media/msg182319.html > > On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov > wrote: >> >> Hello, >> >> Here is v2 of the subject patchset. >

Re: [PATCH 2/3] venus: Limit HFI sessions to the maximum supported

2020-11-22 Thread Stanimir Varbanov
On 11/21/20 3:14 AM, Fritz Koenig wrote: > On Thu, Nov 19, 2020 at 4:12 PM Stanimir Varbanov > wrote: >> >> Currently we rely on firmware to return error when we reach the maximum >> supported number of sessions. But this errors are happened at reqbuf >> time

Re: [PATCH 3/3] media: hfi_venus: Request interrupt for sync cmds

2020-11-22 Thread Stanimir Varbanov
On 11/21/20 3:02 AM, Fritz Koenig wrote: > On Thu, Nov 19, 2020 at 4:12 PM Stanimir Varbanov > wrote: >> >> From: Vikash Garodia >> >> For synchronous commands, update the message queue variable. >> This would inform video firmware to raise interrup

Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver

2014-02-26 Thread Stanimir Varbanov
Hi Andy, Thanks for the patch. On 02/25/2014 01:11 AM, Andy Gross wrote: > Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller > found in the MSM 8x74 platforms. > > Each BAM DMA device is associated with a specific on-chip peripheral. Each > channel provides a uni-di

Re: [PATCH] hwrng: msm: switch Kconfig to ARCH_QCOM depends

2014-02-12 Thread Stanimir Varbanov
kernel-side support for the Random Number > Generator hardware found on Qualcomm MSM SoCs. > IMO, after this change the "MSM" abbreviation in help clause is irrelevant, could you remove it? Reviewed-by: Stanimir Varbanov regards, Stan -- To unsubscribe from this list: send the l

[PATCH 0/9] Add Qualcomm crypto driver

2014-04-03 Thread Stanimir Varbanov
e and easier for review, hope I done well. I'll appreciate any review comments which will help me to make this code clear and ready for mainline kernel. regards, Stan Stanimir Varbanov (9): crypto: qce: Add core driver implementation crypto: qce: Add register defines crypto: qce: Add

[PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-03 Thread Stanimir Varbanov
: Stanimir Varbanov --- drivers/crypto/qce/core.c | 333 ++ drivers/crypto/qce/core.h | 69 ++ 2 files changed, 402 insertions(+) create mode 100644 drivers/crypto/qce/core.c create mode 100644 drivers/crypto/qce/core.h diff --git a/drivers

[PATCH 3/9] crypto: qce: Add dma and sg helpers

2014-04-03 Thread Stanimir Varbanov
This adds dmaengine and sg-list helper functions used by other parts of the crypto driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/dma.c | 201 +++ drivers/crypto/qce/dma.h | 57 ++ 2 files changed, 258 insertions

[PATCH 2/9] crypto: qce: Add register defines

2014-04-03 Thread Stanimir Varbanov
Here are all register addresses and bit/masks used by the driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/regs-v5.h | 327 +++ 1 file changed, 327 insertions(+) create mode 100644 drivers/crypto/qce/regs-v5.h diff --git a/drivers/crypto

[PATCH 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-03 Thread Stanimir Varbanov
Here is the implementation of AES, DES and 3DES crypto API callbacks, the crypto register alg function, the async request handler and its dma done callback function. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/ablkcipher.c | 397 drivers

[PATCH 5/9] crypto: qce: Adds sha and hmac transforms

2014-04-03 Thread Stanimir Varbanov
Here is the implementation and registration of ahash crypto type. It includes sha1, sha256, hmac(sha1) and hmac(sha256). Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/sha.c | 595 +++ drivers/crypto/qce/sha.h | 74 ++ 2 files changed

[PATCH 7/9] crypto: qce: Adds Makefile to build the driver

2014-04-03 Thread Stanimir Varbanov
Adds Makefile needed to build the driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/Makefile | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 drivers/crypto/qce/Makefile diff --git a/drivers/crypto/qce/Makefile b/drivers/crypto/qce/Makefile new file mode 100644

[PATCH 6/9] crypto: qce: Adds infrastructure to setup the crypto block

2014-04-03 Thread Stanimir Varbanov
Signed-off-by: Stanimir Varbanov --- drivers/crypto/qce/common.c | 424 drivers/crypto/qce/common.h | 111 2 files changed, 535 insertions(+) create mode 100644 drivers/crypto/qce/common.c create mode 100644 drivers/crypto/qce/common.h diff

[PATCH 8/9] crypto: qce: Build Qualcomm qce driver

2014-04-03 Thread Stanimir Varbanov
Modify crypto Kconfig and Makefile in order to build the qce driver. Signed-off-by: Stanimir Varbanov --- drivers/crypto/Kconfig | 10 ++ drivers/crypto/Makefile | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 03ccdb0ccf9e

[PATCH 9/9] ARM: DT: qcom: Add Qualcomm crypto driver binding document

2014-04-03 Thread Stanimir Varbanov
Here is Qualcomm crypto driver device tree binding documentation to used as a reference example. Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/crypto/qcom-qce.txt| 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH 2/9] crypto: qce: Add register defines

2014-04-03 Thread Stanimir Varbanov
Hi, On 04/03/2014 07:24 PM, Kumar Gala wrote: > > On Apr 3, 2014, at 11:17 AM, Stanimir Varbanov wrote: > >> Here are all register addresses and bit/masks used by the driver. >> >> Signed-off-by: Stanimir Varbanov >> --- >

Re: [Patch v9 2/2] dmaengine: add Qualcomm BAM dma driver

2014-04-03 Thread Stanimir Varbanov
Signed-off-by: Andy Gross I tested this driver during wake up of the crypto driver. With your additions to bam_start_dma() in regards to EOT interrupts I successfully passed the crypto framework test vectors for the implemented algorithms. Tested-by: Stanimir Varbanov regards, Stan -- To unsub

Re: [PATCH 3/9] crypto: qce: Add dma and sg helpers

2014-04-04 Thread Stanimir Varbanov
On 04/03/2014 09:25 PM, Josh Cartwright wrote: > Nitworthy comments :). > > On Thu, Apr 03, 2014 at 07:18:00PM +0300, Stanimir Varbanov wrote: > [..] >> +++ b/drivers/crypto/qce/dma.c > [..] >> +int qce_dma_request(struct device *dev, struct qce_dma_data *dma) >>

<    1   2   3   4   5   6   7   8   9   10   >