[PATCH v2 25/29] venus: vdec: new function for output configuration

2018-05-15 Thread Stanimir Varbanov
Make a new function vdec_output_conf() for decoder output configuration. vdec_output_conf() will set properties via HFI interface related to the output configuration, and keep vdec_set_properties() which will set properties related to decoding parameters. Signed-off-by: Stanimir Varbanov

[PATCH v2 27/29] venus: implementing multi-stream support

2018-05-15 Thread Stanimir Varbanov
This is implementing a multi-stream decoder support. The multi stream gives an option to use the secondary decoder output with different raw format (or the same in case of crop). Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 1 + drivers/media/platform

[PATCH v2 28/29] venus: add sdm845 compatible and resource data

2018-05-15 Thread Stanimir Varbanov
This adds sdm845 DT compatible string with it's resource data table. Reviewed-by: Rob Herring Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/media/qcom,venus.txt | 1 + drivers/media/platform/qcom/venus/core.c | 22 ++ 2 files change

[PATCH v2 29/29] venus: add HEVC codec support

2018-05-15 Thread Stanimir Varbanov
This add HEVC codec support for venus versions 3xx and 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 2 ++ drivers/media/platform/qcom/venus/helpers.c | 3 ++ drivers/media/platform/qcom/venus/hfi.c | 2 ++ drivers/media/platform/qcom/venus

[PATCH v2 26/29] venus: move frame size calculations in common place

2018-05-15 Thread Stanimir Varbanov
move calculations of raw and compressed in a common helper and make it identical for encoder and decoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 98 + drivers/media/platform/qcom/venus/helpers.h | 2 + drivers/media

[PATCH v2 24/29] venus: vdec: get required input buffers as well

2018-05-15 Thread Stanimir Varbanov
Rework and rename vdec_cap_num_buffers() to get the number of input buffers too. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec.c | 41 +++- 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/drivers/media/platform/qcom/venus

[PATCH v2 16/29] venus: add a helper function to set dynamic buffer mode

2018-05-15 Thread Stanimir Varbanov
Adds a new helper function to set dynamic buffer mode if it is supported by current HFI version. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 22 ++ drivers/media/platform/qcom/venus/helpers.h | 1 + drivers/media/platform/qcom/venus

[PATCH v2 23/29] venus: helpers: add a helper to return opb buffer sizes

2018-05-15 Thread Stanimir Varbanov
Add a helper function to return current output picture buffer size. OPB sizes can vary depending on the selected decoder output(s). Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 10 ++ drivers/media/platform/qcom/venus/helpers.c | 15

[PATCH v2 22/29] venus: helpers: extend set_num_bufs helper with one more argument

2018-05-15 Thread Stanimir Varbanov
Extend venus_helper_set_num_bufs() helper function with one more argument to set number of output buffers for the secondary decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 16 ++-- drivers/media/platform/qcom/venus/helpers.h | 3

[PATCH v2 21/29] venus: helpers,vdec,venc: add helpers to set work mode and core usage

2018-05-15 Thread Stanimir Varbanov
These are new properties applicable to Venus version 4xx. Add the helpers and call them from decoder and encoder drivers. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 28 drivers/media/platform/qcom/venus/helpers.h | 2

[PATCH v2 20/29] venus: helpers: add a new helper to set raw format

2018-05-15 Thread Stanimir Varbanov
The new helper will has one more argument for buffer type, that way the decoder can configure the format on it's secondary output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 52 ++--- drivers/media/platform/qcom/venus/help

[PATCH v2 15/29] venus: helpers: rename a helper function and use buffer mode from caps

2018-05-15 Thread Stanimir Varbanov
Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and use buffer mode from enumerated per codec capabilities. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH v2 12/29] venus: add common capability parser

2018-05-15 Thread Stanimir Varbanov
This adds common capability parser for all supported Venus versions. Having it will help to enumerate better the supported raw formars and codecs and also the capabilities for every codec like max/min width/height, framerate, bitrate and so on. Signed-off-by: Stanimir Varbanov --- drivers/media

[PATCH v2 14/29] venus: core: delete not used flag for buffer mode

2018-05-15 Thread Stanimir Varbanov
Delete not used flag for capture buffer allocation mode. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h index fe2d2b9e8af8

[PATCH v2 17/29] venus: add helper function to set actual buffer size

2018-05-15 Thread Stanimir Varbanov
Add and use a helper function to set actual buffer size for particular buffer type. This is also preparation to use the second decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 12 drivers/media/platform/qcom/venus/helpers.h | 1

[PATCH v2 13/29] venus: helpers: make a commmon function for power_enable

2018-05-15 Thread Stanimir Varbanov
Make common function which will enable power when enabling/disabling clocks and also covers Venus 3xx/4xx versions. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 51 + drivers/media/platform/qcom/venus/helpers.h | 2 ++ drivers

[PATCH v2 18/29] venus: delete no longer used bufmode flag from instance

2018-05-15 Thread Stanimir Varbanov
Delete no longer used flag cap_bufs_mode_dynamic from instance structure. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 -- drivers/media/platform/qcom/venus/hfi_parser.c | 6 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers

[PATCH v2 19/29] venus: helpers: add buffer type argument to a helper

2018-05-15 Thread Stanimir Varbanov
This adds one more function argument to pass buffer type to set_output_resolution() helper function. That is a preparation to support secondary decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 5 +++-- drivers/media/platform/qcom/venus/helpers.h

[PATCH v2 11/29] venus: venc,vdec: adds clocks needed for venus 4xx

2018-05-15 Thread Stanimir Varbanov
This extends the clocks number to support suspend and resume on Venus version 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 4 +-- drivers/media/platform/qcom/venus/vdec.c | 42 ++-- drivers/media/platform/qcom/venus/venc.c

[PATCH v2 10/29] venus: hfi_venus: add suspend functionality for Venus 4xx

2018-05-15 Thread Stanimir Varbanov
This adds suspend (power collapse) functionality by reusing the suspend function for Venus 3xx and also enables idle indicator property for Venus 4xx (where it is disabled by default). Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 11 ++- 1 file

[PATCH v2 08/29] venus: hfi_venus: fix suspend function for venus 3xx versions

2018-05-15 Thread Stanimir Varbanov
This fixes the suspend function for Venus 3xx versions by add a check for WFI (wait for interrupt) bit. This bit is on when the ARM9 is idle and entered in low power mode. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c| 59

[PATCH v2 09/29] venus: hfi_venus: move set of default properties to core init

2018-05-15 Thread Stanimir Varbanov
property early before we enter into venus_suspend function where we need to check for ARM9 WFI. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/qcom/venus

[PATCH v2 06/29] venus: hfi: handle buffer output2 type as well

2018-05-15 Thread Stanimir Varbanov
This adds handling of buffers of type OUTPUT2 which is needed to support Venus 4xx version. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c | 3 ++- drivers/media/platform/qcom/venus/hfi_msgs.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v2 04/29] venus: hfi_cmds: add set_properties for 4xx version

2018-05-15 Thread Stanimir Varbanov
Adds set_properties method to handle newer 4xx properties and fall-back to 3xx for the rest. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_cmds.c | 64 +++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform

[PATCH v2 07/29] venus: hfi_venus: add halt AXI support for Venus 4xx

2018-05-15 Thread Stanimir Varbanov
Add AXI halt support for version 4xx by using venus wrapper registers. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media

[PATCH v2 02/29] venus: hfi: preparation to support venus 4xx

2018-05-15 Thread Stanimir Varbanov
This covers the differences between 1xx,3xx and 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 4 ++ drivers/media/platform/qcom/venus/helpers.c | 37 +++ drivers/media/platform/qcom/venus/hfi_helper.h | 84

[PATCH v2 03/29] venus: hfi: update sequence event to handle more properties

2018-05-15 Thread Stanimir Varbanov
HFI version 4xx can pass more properties in the sequence change event, extend the event structure with them. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.h | 9 ++ drivers/media/platform/qcom/venus/hfi_msgs.c | 46 2 files

[PATCH v2 00/29] Venus updates

2018-05-15 Thread Stanimir Varbanov
. * spelling typo in 15/28. * added Reviewed-by for DT changes. * extended 28/28 HEVC support for encoder, now the profile and level are selected properly. Comments are welcome! regards, Stan Stanimir Varbanov (29): venus: hfi_msgs: correct pointer increment venus: hfi: preparation to

Re: [PATCH v2 27/29] venus: implementing multi-stream support

2018-05-15 Thread Stanimir Varbanov
Hi Hans, On 05/15/2018 11:17 AM, Hans Verkuil wrote: > Hi Stanimir, > > On 05/15/18 09:58, Stanimir Varbanov wrote: >> This is implementing a multi-stream decoder support. The multi >> stream gives an option to use the secondary decoder output >> with different raw for

Re: [PATCH] pcie: qcom: Add support for sdm845 PCIe controller

2019-03-01 Thread Stanimir Varbanov
Hi Bjorn, Thanks for the patch! On 2/26/19 9:01 AM, Bjorn Andersson wrote: > The SDM845 has one Gen2 and one Gen3 controller, add support for these. > > Due to lack of hardware only the Gen2 controller has been verified. > > Signed-off-by: Bjorn Andersson > --- > .../devicetree/bindings/pci/q

[PATCH] venus: hfi_parser: fix Source Matcher errors

2019-03-12 Thread Stanimir Varbanov
This fixes following Smatch errors: hfi_parser.c:103 parse_profile_level() error: memcpy() 'proflevel' too small (8 vs 128) hfi_parser.c:129 parse_caps() error: memcpy() 'cap' too small (16 vs 512) Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/ven

Re: [RFC PATCH v1] PCI: qcom: Use quirk to override incorrect device class

2019-03-12 Thread Stanimir Varbanov
Hi Marc, Thanks for the patch! On 3/11/19 4:56 PM, Marc Gonzalez wrote: > Some chips report an incorrect device class. Override the incorrect > value using a quirk, instead of code in the read function. > > Signed-off-by: Marc Gonzalez > --- > FWIW, this quirk is no longer required on recent ch

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-28 Thread Stanimir Varbanov
Hi Tomasz, On 1/28/19 9:38 AM, Tomasz Figa wrote: > On Fri, Jan 25, 2019 at 7:25 PM Stanimir Varbanov > wrote: >> >> Hi Tomasz, >> >> Thanks for the comments! >> >> On 1/25/19 9:59 AM, Tomasz Figa wrote: >>> .Hi Stan, >>> >

Re: [PATCH] media: venus: core: fix max load for msm8996 and sdm845

2019-02-26 Thread Stanimir Varbanov
up changing the one for msm8996 instead. > > Fixes: de5a0bafcfc4 ("media: venus: core: correct maximum hardware load for > sdm845") > > Signed-off-by: Alexandre Courbot > --- > drivers/media/platform/qcom/venus/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

Re: [PATCH v2 4/7] PCI: qcom: Use clk_bulk API for 2.4.0 controllers

2019-02-26 Thread Stanimir Varbanov
gt; - struct clk *master_clk; > - struct clk *slave_clk; > + struct clk_bulk_data clks[3]; Could you make 3 as a define? Otherwise: Acked-by: Stanimir Varbanov -- regards, Stan

[PATCH 2/2] venus: vdec: Add support for conceal control

2021-02-09 Thread Stanimir Varbanov
Adds support for decoder conceal color control. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/hfi_cmds.c | 18 -- drivers/media/platform/qcom/venus/hfi_helper.h | 10 ++ drivers/media

[PATCH 1/2] v4l2-ctrl: Add decoder conceal color control

2021-02-09 Thread Stanimir Varbanov
Add decoder v4l2 control to set conceal color. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-codec.rst | 20 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 9 + include/uapi/linux/v4l2-controls.h| 1 + 3 files changed, 30

[PATCH 0/2] Add decoder conceal color ctrl

2021-02-09 Thread Stanimir Varbanov
Hello, The first patch is adding a new control for conceal error color and the second adds support for it in the Venus decoder driver. Comments are welcome! regards, Stan Stanimir Varbanov (2): v4l2-ctrl: Add decoder conceal color control venus: vdec: Add support for conceal control

[PATCH v5 0/5] HDR10 static metadata

2021-02-09 Thread Stanimir Varbanov
ted p_hdr10_cll and p_hdr10_mastering in vidioc-g-ext-ctrls.rst Comments are welcome! regards, Stan Stanimir Varbanov (5): v4l: Add new Colorimetry Class docs: Document colorimetry class v4l: Add HDR10 static metadata controls docs: Document CLL and Mastering display colorime

[PATCH v5 1/5] v4l: Add new Colorimetry Class

2021-02-09 Thread Stanimir Varbanov
Add Colorimetry control class for colorimetry controls Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++- include/uapi/linux/v4l2-controls.h | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b

[PATCH v5 3/5] v4l: Add HDR10 static metadata controls

2021-02-09 Thread Stanimir Varbanov
Introduce Content light level and Mastering display colour volume Colorimetry compound controls with relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 67 include/media/v4l2-ctrls.h | 4

[PATCH v5 2/5] docs: Document colorimetry class

2021-02-09 Thread Stanimir Varbanov
Add a document for ext control colorimetry class. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/common.rst| 1 + .../media/v4l/ext-ctrls-colorimetry.rst | 22 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 4 3 files changed, 27

[PATCH v5 4/5] docs: Document CLL and Mastering display colorimetry controls

2021-02-09 Thread Stanimir Varbanov
Document Content Light Level and Mastering Display v4l2 colorimetry controls. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-colorimetry.rst | 71 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 8 +++ .../media/videodev2.h.rst.exceptions | 2

[PATCH v5 5/5] venus: venc: Add support for CLL and Mastering display controls

2021-02-09 Thread Stanimir Varbanov
Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

Re: [PATCH 1/2] v4l2-ctrl: Add decoder conceal color control

2021-02-25 Thread Stanimir Varbanov
On 2/16/21 10:58 AM, Hans Verkuil wrote: > On 16/02/2021 09:56, Stanimir Varbanov wrote: >> >> >> On 2/15/21 1:57 PM, Hans Verkuil wrote: >>> On 15/02/2021 12:32, Stanimir Varbanov wrote: >>>> >>>> >>>> On 2/9/21 1:05 PM, Hans

[PATCH v5 0/3] Venus dynamic debug

2020-07-30 Thread Stanimir Varbanov
Hello, Changes in v5: * 1/3 - dropped dev_warn when set FW debug level - Greg KH * 3/3 - dropped pr_debug, and now group levels by prefix in dev_dbg v4 can be fount at [1]. regards, Stan [1] https://www.spinics.net/lists/kernel/msg3550106.html Stanimir Varbanov (3): venus: Add debugfs

[PATCH v5 2/3] venus: Add a debugfs file for SSR trigger

2020-07-30 Thread Stanimir Varbanov
The SSR (SubSystem Restart) is used to simulate an error on FW side of Venus. We support following type of triggers - fatal error, div by zero and watchdog IRQ. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/dbgfs.c | 30 +++ 1 file changed, 30

[PATCH v5 3/3] venus: Make debug infrastructure more flexible

2020-07-30 Thread Stanimir Varbanov
If you want to enable all levels: echo 'format "Venus" +p' > debugfs/dynamic_debug/control All the features which dynamic debugging provide are preserved. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 5 + drivers/media/pla

[PATCH v5 1/3] venus: Add debugfs interface to set firmware log level

2020-07-30 Thread Stanimir Varbanov
This will be useful when debugging specific issues related to firmware HFI interface. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/Makefile| 2 +- drivers/media/platform/qcom/venus/core.c | 3 +++ drivers/media/platform/qcom/venus/core.h | 3

[PATCH 0/3] Venus - recovery from firmware crash

2020-07-30 Thread Stanimir Varbanov
handling to ensure that the hardware and encoder/decoder drivers are idle. Also a wrong watchdog code in threaded irq has been removed. regards, Stan Stanimir Varbanov (3): venus: parser: Prepare parser for multiple invocations venus: Rework recovery mechanism venus: Add new interface

[PATCH 1/3] venus: parser: Prepare parser for multiple invocations

2020-07-30 Thread Stanimir Varbanov
Presently the hfi_parser has been called only once during driver probe. To prepare the parser function to be called multiple times from recovery we need to initialize few variables which are used during parsing time. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus

[PATCH 3/3] venus: Add new interface queues reinit

2020-07-30 Thread Stanimir Varbanov
will give to the recovery procedure one less reason to fail (if for some reason we couldn't allocate memory). Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 3 +- drivers/media/platform/qcom/venus/hfi.c | 5 ++ drivers/media/platform/qcom/venus/h

[PATCH 2/3] venus: Rework recovery mechanism

2020-07-30 Thread Stanimir Varbanov
After power domains and clock restructuring the recovery for sdm845 and v4 did not work properly. Fix that by reworking the recovery function and the sequence. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 24 ++- drivers/media/platform

Re: [PATCH 1/2] firmware: qcom_scm: Add memory protect virtual address ranges

2020-07-31 Thread Stanimir Varbanov
Hi Elliot, Thanks for the comments! On 7/29/20 8:15 PM, Elliot Berman wrote: > ++ > > On 7/24/2020 8:04 AM, Stanimir Varbanov wrote: >> Hi, >> >> Gentle ping for review. >> >> On 7/9/20 2:58 PM, Stanimir Varbanov wrote: >>> This adds a new SCM

Re: R: R: [PATCH v3 08/11] devicetree: bindings: pci: document PARF params bindings

2020-05-20 Thread Stanimir Varbanov
Hi, On 5/13/20 3:56 PM, ansuels...@gmail.com wrote: >> On 5/12/20 6:45 PM, Rob Herring wrote: >>> On Thu, May 07, 2020 at 09:34:35PM +0200, ansuels...@gmail.com >> wrote: > On Fri, May 01, 2020 at 12:06:15AM +0200, Ansuel Smith wrote: >> It is now supported the editing of Tx De-Emphasis, T

[PATCH v2 0/3] Venus dynamic debug

2020-05-21 Thread Stanimir Varbanov
Hello, Here is second version of the dynamic debug series. Few things are changed since v1: * Rebased on current media-tree master * Added one more patch for SSR trigger debug file regards, Stan Stanimir Varbanov (3): venus: Add debugfs interface to set firmware log level venus: Make

[PATCH v2 1/3] venus: Add debugfs interface to set firmware log level

2020-05-21 Thread Stanimir Varbanov
This will be useful when debugging specific issues related to firmware HFI interface. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/Makefile| 2 +- drivers/media/platform/qcom/venus/core.c | 5 drivers/media/platform/qcom/venus/core.h | 3

[PATCH v2 3/3] venus: Add a debugfs file for SSR trigger

2020-05-21 Thread Stanimir Varbanov
The SSR (SubSystem Restart) is used to simulate an error on FW side of Venus. We support following type of triggers - fatal error, div by zero and watchdog IRQ. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/dbgfs.c | 31 +++ 1 file changed, 31

[PATCH v2 2/3] venus: Make debug infrastructure more flexible

2020-05-21 Thread Stanimir Varbanov
If you want to enable all levels: echo 'format "VENUS" +p' > debugfs/dynamic_debug/control All the features which dynamic debugging provide are preserved. And finaly all dev_dbg are translated to VDBGX with appropriate debug levels. Signed-off-by: Stanimir Varbanov

Re: [RFC] Make dynamic debug infrastructure more flexible

2020-05-21 Thread Stanimir Varbanov
Hi Joe, Jason, On 5/21/20 11:06 PM, Joe Perches wrote: > On Thu, 2020-05-21 at 09:08 -0700, Joe Perches wrote: >> On Thu, 2020-05-21 at 16:28 +0300, Stanimir Varbanov wrote: >>> Here we introduce few debug macros with levels (low, medium and >>> high) and debug macro

Re: [PATCH 21/22] crypto: qce - add check for xts input length equal to zero

2020-08-07 Thread Stanimir Varbanov
> --- > drivers/crypto/qce/skcipher.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Stanimir Varbanov > > diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c > index 5630c5addd28..887fd4dc9b43 100644 > --- a/drivers/crypto/qce/skcipher.

Re: [RESEND 1/3] venus: core: handle race condititon for core ops

2020-08-10 Thread Stanimir Varbanov
Hi Mansur, Thanks for the patches! On 8/7/20 9:24 AM, Mansur Alisha Shaik wrote: > For core ops we are having only write protect but there > is no read protect, because of this in multthreading > and concurrency, one CPU core is reading without wait > which is causing the NULL pointer dereferece

Re: [RESEND 3/3] venus: handle use after free for iommu_map/iommu_unmap

2020-08-10 Thread Stanimir Varbanov
Hi, On 8/7/20 9:24 AM, Mansur Alisha Shaik wrote: > In concurrency usecase and reboot scenario we are trying > to map fw.iommu_domain which is already unmapped during I guess you want to say "to unmap iommu domain which is already unmapped" ? > shutdown. This is causing NULL pointer dereference

Re: [PATCH v4 2/2] venus: venc : Add support for priority ID control.

2021-01-12 Thread Stanimir Varbanov
edia/platform/qcom/venus/venc_ctrls.c | 9 - > 2 files changed, 10 insertions(+), 1 deletion(-) Acked-by: Stanimir Varbanov -- regards, Stan

Re: [PATCH v4 3/3] venus: venc: Add support for frame-specific min/max qp controls

2021-01-12 Thread Stanimir Varbanov
> drivers/media/platform/qcom/venus/venc.c | 21 +++-- > drivers/media/platform/qcom/venus/venc_ctrls.c | 114 > +++-- > 3 files changed, 142 insertions(+), 11 deletions(-) Acked-by: Stanimir Varbanov -- regards, Stan

[PATCH] venus: core: Fix platform driver shutdown

2020-12-21 Thread Stanimir Varbanov
With TZ system reboot cannot finish successfully. To fix that enable core clocks by runtime pm before TZ calls and disable clocks after that. Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus") Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/ve

Re: [PATCH] venus: venc: set IDR period to FW only for H264 & HEVC

2020-12-21 Thread Stanimir Varbanov
ivers/media/platform/qcom/venus/venc.c | 23 +-- > 1 file changed, 13 insertions(+), 10 deletions(-) Reviewed-by: Stanimir Varbanov > > diff --git a/drivers/media/platform/qcom/venus/venc.c > b/drivers/media/platform/qcom/venus/venc.c > index 3a2e449..618cf92 10

Re: [PATCH v2] venus: venc: set inband mode property to FW.

2020-12-21 Thread Stanimir Varbanov
On 12/16/20 8:49 AM, Dikshita Agarwal wrote: > set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW > to support inband sequence header mode. > > Signed-off-by: Dikshita Agarwal > > Changes since v1: > - added codec check > - fixed the mask while initializing the control > > --- >

Re: [PATCH v2 1/3] v4l: Add HDR10 static metadata controls

2020-12-07 Thread Stanimir Varbanov
On 12/2/20 1:12 PM, Hans Verkuil wrote: > On 24/11/2020 00:02, Stanimir Varbanov wrote: >> Add Content light level and Mastering display colour volume v4l2 >> compounf controls, relevant payload structures and validation. > > compounf -> compound > >> &g

[PATCH v3 0/3] HDR10 static metadata

2020-12-08 Thread Stanimir Varbanov
/linux-media/20201123230257.31690-1-stanimir.varba...@linaro.org/T/#mba512702aab370d4b0aa393dea54095e55d78552 Stanimir Varbanov (3): v4l: Add HDR10 static metadata controls docs: media: Document CLL and Mastering display venus: venc: Add support for CLL and Mastering display controls

[PATCH v3 1/3] v4l: Add HDR10 static metadata controls

2020-12-08 Thread Stanimir Varbanov
Here we introduce a new Colorimetry control class and add Content light level and Mastering display colour volume v4l2 compound controls, relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- .../media/videodev2.h.rst.exceptions | 2 + drivers/media/v4l2

[PATCH v3 2/3] docs: media: Document CLL and Mastering display

2020-12-08 Thread Stanimir Varbanov
Document Content light level and Mastering display colour volume. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/common.rst| 1 + .../media/v4l/ext-ctrls-colorimetry.rst | 88 +++ 2 files changed, 89 insertions(+) create mode 100644

Re: [PATCH v2 1/3] v4l: Add HDR10 static metadata controls

2020-12-08 Thread Stanimir Varbanov
Hi Hans, On 12/7/20 11:21 AM, Hans Verkuil wrote: > On 07/12/2020 10:06, Stanimir Varbanov wrote: >> >> >> On 12/2/20 1:12 PM, Hans Verkuil wrote: >>> On 24/11/2020 00:02, Stanimir Varbanov wrote: >>>> Add Content light level and Mastering display

[PATCH v3 3/3] venus: venc: Add support for CLL and Mastering display controls

2020-12-08 Thread Stanimir Varbanov
Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 3 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

[PATCH v2] venus: pm_helpers: Control core power domain manually

2021-01-13 Thread Stanimir Varbanov
Presently we use device_link to control core power domain. But this leads to issues because the genpd doesn't guarantee synchronous on/off for supplier devices. Switch to manually control by pmruntime calls. Tested-by: Fritz Koenig Signed-off-by: Stanimir Varbanov --- changes since v1: *

[PATCH] venus: hfi_plat: Fix warning for missing function prototype

2021-01-13 Thread Stanimir Varbanov
The bufreq_enc function should be static. Reported-by: kernel test robot Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c b

Re: [RESEND PATCH] PCI: qcom: use PHY_REFCLK_USE_PAD only for ipq8064

2021-01-18 Thread Stanimir Varbanov
489 ("PCI: qcom: Add support for tx term offset for rev 2.1.0") > Reported-by: Ilia Mirkin > Signed-off-by: Ilia Mirkin > Signed-off-by: Ansuel Smith > Cc: sta...@vger.kernel.org # v4.19+ Acked-by: Stanimir Varbanov > --- > drivers/pci/controller/dwc/pcie-qcom.

Re: [PATCH 2/2] media: dt-bindings: media: venus: Add sdm660 DT schema

2021-01-18 Thread Stanimir Varbanov
On 1/17/21 9:23 PM, AngeloGioacchino Del Regno wrote: > Il 17/01/21 16:45, Rob Herring ha scritto: >> On Fri, 15 Jan 2021 19:52:52 +0100, AngeloGioacchino Del Regno wrote: >>> Add new qcom,sdm660-venus DT binding schema. >>> >>> Signed-off-by: AngeloGioacchino Del Regno >>> >>> --- >>>   .../bi

Re: [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct

2021-01-18 Thread Stanimir Varbanov
ic const struct venus_resources sc7180_res = { > static const struct of_device_id venus_dt_match[] = { > { .compatible = "qcom,msm8916-venus", .data = &msm8916_res, }, > { .compatible = "qcom,msm8996-venus", .data = &msm8996_res, }, > + { .com

Re: [PATCH] venus: core: Fix platform driver shutdown

2021-01-19 Thread Stanimir Varbanov
On 1/19/21 9:40 AM, Shawn Guo wrote: > On Mon, Dec 21, 2020 at 11:58:20AM +0200, Stanimir Varbanov wrote: >> With TZ system reboot cannot finish successfully. To fix that >> enable core clocks by runtime pm before TZ calls and disable >> clocks after that. >> >

[PATCH v3 1/2] media: v4l2-ctrls: Add control for AUD generation

2021-01-19 Thread Stanimir Varbanov
Add a control to enable inserting of AUD NALU into encoded bitstream. Reviewed-by: Hans Verkuil Signed-off-by: Stanimir Varbanov --- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 5 + drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2

[PATCH v3 2/2] venus: venc: Add support for AUD NALU control

2021-01-19 Thread Stanimir Varbanov
Add support for Access Unit Delimiter control into encoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 14 ++ drivers/media/platform/qcom/venus/venc_ctrls.c | 8 +++- 3 files

[PATCH v3 0/2] AUD encoder control

2021-01-19 Thread Stanimir Varbanov
/list/?series=4083 Stanimir Varbanov (2): media: v4l2-ctrls: Add control for AUD generation venus: venc: Add support for AUD NALU control .../userspace-api/media/v4l/ext-ctrls-codec.rst| 5 + drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus

[PATCH] venus: pm_helpers: Control core power domain manually

2021-01-08 Thread Stanimir Varbanov
Presently we use device_link to control core power domain. But this leads to issues because the genpd doesn't guarantee synchronous on/off for supplier devices. Switch to manually control by pmruntime calls. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h

[PATCH v2 0/4] MFC private ctrls to std ctrls

2021-01-15 Thread Stanimir Varbanov
/ Stanimir Varbanov (4): v4l2-ctrl: Make display delay and display enable std controls venus: vdec: Add support for display delay and delay enable controls s5p-mfc: Use display delay and display enable std controls docs: Deprecate mfc display delay controls .../media/v4l/ext-ctrls-codec.rst

[PATCH v2 1/4] v4l2-ctrl: Make display delay and display enable std controls

2021-01-15 Thread Stanimir Varbanov
Make display delay and display delay enable MFC controls standard v4l controls. This will allow reuse of the controls for other decoder drivers. Also the new proposed controls are now codec agnostic because they could be used for any codec. Signed-off-by: Stanimir Varbanov --- .../userspace-api

[PATCH v2 4/4] docs: Deprecate mfc display delay controls

2021-01-15 Thread Stanimir Varbanov
Deprecate mfc private display delay and display enable controls for new clients and use the standard controls instead. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/ext-ctrls-codec.rst| 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation

[PATCH v2 2/4] venus: vdec: Add support for display delay and delay enable controls

2021-01-15 Thread Stanimir Varbanov
Add support for display delay and display delay enable std controls. With this we implement decoder decode output order (decode vs display). Once firmware implement few new features the controls will be used for other use-cases. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom

[PATCH v2 3/4] s5p-mfc: Use display delay and display enable std controls

2021-01-15 Thread Stanimir Varbanov
Use the standard display_delay and display_delay_enable controls, the legacy private MFC controls are kept for backward compatibility. Acked-by: Marek Szyprowski Signed-off-by: Stanimir Varbanov --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 16 1 file changed, 16

Re: [PATCH] media: venus: Fix internal buffer size calculations for v6.

2021-03-24 Thread Stanimir Varbanov
On 3/17/21 10:35 AM, Dikshita Agarwal wrote: > - Update persist buffer size for encoder to 204800. > - Update persist buffer size calculation for h264 decoder. > - h264d level 6 support needs update in internal buffer size. > update below buffers size > - h264 decoder colocated motion vector

Re: linux-next: manual merge of the opp tree with the v4l-dvb tree

2021-03-24 Thread Stanimir Varbanov
Thanks Stephen! On 3/23/21 2:27 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the opp tree got a conflict in: > > drivers/media/platform/qcom/venus/pm_helpers.c > > between commit: > > 08b1cf474b7f ("media: venus: core, venc, vdec: Fix probe dependency error") > >

Re: [PATCH v3 14/15] media: venus: Convert to use resource-managed OPP API

2021-03-25 Thread Stanimir Varbanov
Hi, On 3/14/21 6:34 PM, Dmitry Osipenko wrote: > From: Yangtao Li > > Use resource-managed OPP API to simplify code. > > Signed-off-by: Yangtao Li > Signed-off-by: Dmitry Osipenko > --- > drivers/media/platform/qcom/venus/core.h | 1 - > .../media/platform/qcom/venus/pm_helpers.c|

Re: linux-next: manual merge of the opp tree with the v4l-dvb tree

2021-03-25 Thread Stanimir Varbanov
Hi Viresh, On 3/25/21 6:25 AM, Viresh Kumar wrote: > On 24-03-21, 16:49, Stanimir Varbanov wrote: >> Thanks Stephen! >> >> On 3/23/21 2:27 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Today's linux-next merge of the opp tree got a con

Re: [PATCH] v4l2-ctrls: Fix h264 hierarchical coding type menu ctrl

2021-03-20 Thread Stanimir Varbanov
Kindly ping for review. On 3/3/21 12:42 AM, Stanimir Varbanov wrote: > Add a name of the menu and fill control type. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/driv

[PATCH v3 2/2] venus: vdec: Add support for conceal control

2021-03-23 Thread Stanimir Varbanov
Adds support for decoder conceal color control. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/hfi_cmds.c | 18 -- drivers/media/platform/qcom/venus/hfi_helper.h | 10 ++ drivers/media

[PATCH v3 1/2] v4l2-ctrl: Add decoder conceal color control

2021-03-23 Thread Stanimir Varbanov
Add decoder v4l2 control to set conceal color. Signed-off-by: Stanimir Varbanov Reviewed-by: Hans Verkuil --- .../media/v4l/ext-ctrls-codec.rst | 33 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 9 + include/uapi/linux/v4l2-controls.h| 1

[PATCH v3 0/2] Add decoder conceal color ctrl

2021-03-23 Thread Stanimir Varbanov
Hi, Changes since v2: * addressed Hans's comments 1/2 in documentation. regards, Stan Stanimir Varbanov (2): v4l2-ctrl: Add decoder conceal color control venus: vdec: Add support for conceal control .../media/v4l/ext-ctrls-codec.rst | 33 +++ drivers/

[PATCH v6 2/5] docs: Document colorimetry class

2021-03-23 Thread Stanimir Varbanov
Add a document for ext control colorimetry class. Signed-off-by: Stanimir Varbanov Reviewed-by: Hans Verkuil --- .../userspace-api/media/v4l/common.rst| 1 + .../media/v4l/ext-ctrls-colorimetry.rst | 22 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 4

[PATCH v6 3/5] v4l: Add HDR10 static metadata controls

2021-03-23 Thread Stanimir Varbanov
Introduce Content light level and Mastering display colour volume Colorimetry compound controls with relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 68 include/media/v4l2-ctrls.h | 4

[PATCH v6 4/5] docs: Document CLL and Mastering display colorimetry controls

2021-03-23 Thread Stanimir Varbanov
Document Content Light Level and Mastering Display v4l2 colorimetry controls. Signed-off-by: Stanimir Varbanov Reviewed-by: Hans Verkuil --- .../media/v4l/ext-ctrls-colorimetry.rst | 71 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 8 +++ .../media/videodev2

<    1   2   3   4   5   6   7   8   9   10   >